korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-04 09:34:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

modpost: inform compilers that fatal() never returns

Browse Source 
The function fatal() never returns because modpost_log() calls exit(1)
when LOG_FATAL is passed.

Inform compilers of this fact so that unreachable code flow can be
identified at compile time.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
This commit is contained in:
Masahiro Yamada 2023-12-03 18:49:32 +09:00
parent cc87b7c06f
commit 16a473f60e
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scripts/mod/modpost.c
View File

@ -90,6 +90,9 @@ void modpost_log(enum loglevel loglevel, const char *fmt, ...)
error_occurred = true; error_occurred = true;
} }
void __attribute__((alias("modpost_log")))
modpost_log_noret(enum loglevel loglevel, const char *fmt, ...);
static inline bool strends(const char *str, const char *postfix) static inline bool strends(const char *str, const char *postfix)
{ {
if (strlen(str) < strlen(postfix)) if (strlen(str) < strlen(postfix))

5
scripts/mod/modpost.h
View File

@ -200,6 +200,9 @@ enum loglevel {
void __attribute__((format(printf, 2, 3))) void __attribute__((format(printf, 2, 3)))
modpost_log(enum loglevel loglevel, const char *fmt, ...); modpost_log(enum loglevel loglevel, const char *fmt, ...);
void __attribute__((format(printf, 2, 3), noreturn))
modpost_log_noret(enum loglevel loglevel, const char *fmt, ...);
/* /*
* warn - show the given message, then let modpost continue running, still * warn - show the given message, then let modpost continue running, still
* allowing modpost to exit successfully. This should be used when * allowing modpost to exit successfully. This should be used when
@ -215,4 +218,4 @@ modpost_log(enum loglevel loglevel, const char *fmt, ...);
*/ */
#define warn(fmt, args...) modpost_log(LOG_WARN, fmt, ##args) #define warn(fmt, args...) modpost_log(LOG_WARN, fmt, ##args)
#define error(fmt, args...) modpost_log(LOG_ERROR, fmt, ##args) #define error(fmt, args...) modpost_log(LOG_ERROR, fmt, ##args)
#define fatal(fmt, args...) modpost_log(LOG_FATAL, fmt, ##args) #define fatal(fmt, args...) modpost_log_noret(LOG_FATAL, fmt, ##args)