mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-11 21:38:32 +08:00
gpio: wm831x: remove platform_set_drvdata() + cleanup probe
The platform_set_drvdata() call is only useful if we need to retrieve back the private information. Since the driver doesn't do that, it's not useful to have it. If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe. Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
This commit is contained in:
parent
96a03e867c
commit
14ebdaec6d
@ -261,7 +261,6 @@ static int wm831x_gpio_probe(struct platform_device *pdev)
|
||||
struct wm831x *wm831x = dev_get_drvdata(pdev->dev.parent);
|
||||
struct wm831x_pdata *pdata = &wm831x->pdata;
|
||||
struct wm831x_gpio *wm831x_gpio;
|
||||
int ret;
|
||||
|
||||
wm831x_gpio = devm_kzalloc(&pdev->dev, sizeof(*wm831x_gpio),
|
||||
GFP_KERNEL);
|
||||
@ -280,16 +279,7 @@ static int wm831x_gpio_probe(struct platform_device *pdev)
|
||||
wm831x_gpio->gpio_chip.of_node = wm831x->dev->of_node;
|
||||
#endif
|
||||
|
||||
ret = devm_gpiochip_add_data(&pdev->dev, &wm831x_gpio->gpio_chip,
|
||||
wm831x_gpio);
|
||||
if (ret < 0) {
|
||||
dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
|
||||
return ret;
|
||||
}
|
||||
|
||||
platform_set_drvdata(pdev, wm831x_gpio);
|
||||
|
||||
return ret;
|
||||
return devm_gpiochip_add_data(&pdev->dev, &wm831x_gpio->gpio_chip, wm831x_gpio);
|
||||
}
|
||||
|
||||
static struct platform_driver wm831x_gpio_driver = {
|
||||
|
Loading…
Reference in New Issue
Block a user