korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-17 01:04:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

USB: serial: digi_acceleport: Eliminate a NULL pointer dereference

Browse Source 
If port is NULL, then the call to dev_err will dereference a value that is
a small offset from NULL.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@

if ((E == NULL && ...) || ...)
{
  ... when != if (...) S1 else S2
      when != E = E1
* E->f
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Julia Lawall 2010-05-27 14:32:09 +02:00 committed by Greg Kroah-Hartman
parent 1f23b2d98c
commit 109f34e71b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/serial/digi_acceleport.c
View File

@ -1239,8 +1239,7 @@ static void digi_write_bulk_callback(struct urb *urb)
/* port and serial sanity check */ /* port and serial sanity check */
if (port == NULL || (priv = usb_get_serial_port_data(port)) == NULL) { if (port == NULL || (priv = usb_get_serial_port_data(port)) == NULL) {
dev_err(&port->dev, pr_err("%s: port or port->private is NULL, status=%d\n",
"%s: port or port->private is NULL, status=%d\n",
__func__, status); __func__, status);
return; return;
} }