korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-27 08:14:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

gadgetfs: list_for_each_safe() misuse

Browse Source 
really weirdly spelled "while the list is non-empty, pick its
first element, remove it from the list and free it" kind of loop...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2012-01-08 16:13:28 -05:00
parent 342827d7d1
commit 104bb37d3e
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/usb/gadget/inode.c
View File

@ -1569,20 +1569,18 @@ delegate:
static void destroy_ep_files (struct dev_data *dev) static void destroy_ep_files (struct dev_data *dev)
{ {
struct list_head *entry, *tmp;
DBG (dev, "%s %d\n", __func__, dev->state); DBG (dev, "%s %d\n", __func__, dev->state);
/* dev->state must prevent interference */ /* dev->state must prevent interference */
restart: restart:
spin_lock_irq (&dev->lock); spin_lock_irq (&dev->lock);
list_for_each_safe (entry, tmp, &dev->epfiles) { while (!list_empty(&dev->epfiles)) {
struct ep_data *ep; struct ep_data *ep;
struct inode *parent; struct inode *parent;
struct dentry *dentry; struct dentry *dentry;
/* break link to FS */ /* break link to FS */
ep = list_entry (entry, struct ep_data, epfiles); ep = list_first_entry (&dev->epfiles, struct ep_data, epfiles);
list_del_init (&ep->epfiles); list_del_init (&ep->epfiles);
dentry = ep->dentry; dentry = ep->dentry;
ep->dentry = NULL; ep->dentry = NULL;
@ -1605,8 +1603,7 @@ restart:
dput (dentry); dput (dentry);
mutex_unlock (&parent->i_mutex); mutex_unlock (&parent->i_mutex);
/* fds may still be open */ spin_lock_irq (&dev->lock);
goto restart;
} }
spin_unlock_irq (&dev->lock); spin_unlock_irq (&dev->lock);
} }