korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-11 12:28:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

ext[34]: avoid i_nlink warnings triggered by drop_nlink/inc_nlink kludge in symlink()

Browse Source 
Both ext3 and ext4 put the half-created symlink inode into the orphan list
for a while (see the comment in ext[34]_symlink() for gory details).  Then,
if everything went fine, they pull it out of the orphan list and bump the
link count back to 1.  The thing is, inc_nlink() is going to complain about
seeing somebody changing i_nlink from 0 to 1.  With a good reason, since
normally something like that is a bug.  Explicit set_nlink(inode, 1) does
the same thing as inc_nlink() here, but it does *not* complain - exactly
because it should be usable in strange situations like this one.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2012-01-08 19:50:23 -05:00
parent da01636a65
commit 0ce8c0109f
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/ext3/namei.c
View File

@ -2272,7 +2272,7 @@ retry:
err = PTR_ERR(handle); err = PTR_ERR(handle);
goto err_drop_inode; goto err_drop_inode;
} }
inc_nlink(inode); set_nlink(inode, 1);
err = ext3_orphan_del(handle, inode); err = ext3_orphan_del(handle, inode);
if (err) { if (err) {
ext3_journal_stop(handle); ext3_journal_stop(handle);

2
fs/ext4/namei.c
View File

@ -2315,7 +2315,7 @@ retry:
err = PTR_ERR(handle); err = PTR_ERR(handle);
goto err_drop_inode; goto err_drop_inode;
} }
inc_nlink(inode); set_nlink(inode, 1);
err = ext4_orphan_del(handle, inode); err = ext4_orphan_del(handle, inode);
if (err) { if (err) {
ext4_journal_stop(handle); ext4_journal_stop(handle);