korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-14 14:34:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

staging: unisys: visorbus: rename create_visor_device gotos

Browse Source 
Away is ambiguous when specifying error vs success. Make return labels
more meaningful by marking them as error paths.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Kershner 2016-03-12 21:27:12 -05:00 committed by Greg Kroah-Hartman
parent 8e33f48c95
commit 0b2acf34f3
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/staging/unisys/visorbus/visorbus_main.c
View File

@ -775,7 +775,7 @@ EXPORT_SYMBOL_GPL(visorbus_disable_channel_interrupts);
static int static int
create_visor_device(struct visor_device *dev) create_visor_device(struct visor_device *dev)
{ {
int rc; int err;
u32 chipset_bus_no = dev->chipset_bus_no; u32 chipset_bus_no = dev->chipset_bus_no;
u32 chipset_dev_no = dev->chipset_dev_no; u32 chipset_dev_no = dev->chipset_dev_no;
@ -797,8 +797,8 @@ create_visor_device(struct visor_device *dev)
if (!dev->periodic_work) { if (!dev->periodic_work) {
POSTCODE_LINUX_3(DEVICE_CREATE_FAILURE_PC, chipset_dev_no, POSTCODE_LINUX_3(DEVICE_CREATE_FAILURE_PC, chipset_dev_no,
DIAG_SEVERITY_ERR); DIAG_SEVERITY_ERR);
rc = -EINVAL; err = -EINVAL;
goto away; goto err_put;
} }
/* bus_id must be a unique name with respect to this bus TYPE /* bus_id must be a unique name with respect to this bus TYPE
@ -824,19 +824,19 @@ create_visor_device(struct visor_device *dev)
* claim the device. The device will be linked onto * claim the device. The device will be linked onto
* bus_type.klist_devices regardless (use bus_for_each_dev). * bus_type.klist_devices regardless (use bus_for_each_dev).
*/ */
rc = device_add(&dev->device); err = device_add(&dev->device);
if (rc < 0) { if (err < 0) {
POSTCODE_LINUX_3(DEVICE_ADD_PC, chipset_bus_no, POSTCODE_LINUX_3(DEVICE_ADD_PC, chipset_bus_no,
DIAG_SEVERITY_ERR); DIAG_SEVERITY_ERR);
goto away; goto err_put;
} }
list_add_tail(&dev->list_all, &list_all_device_instances); list_add_tail(&dev->list_all, &list_all_device_instances);
return 0; return 0; /* success: reference kept via unmatched get_device() */
away: err_put:
put_device(&dev->device); put_device(&dev->device);
return rc; return err;
} }
static void static void