korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-06 05:44:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

[media] m88ts2022: do not use dynamic stack allocation

Browse Source 
I2C transfer were using dynamic stack allocation. Get rid of it.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
This commit is contained in:
Antti Palosaari 2013-11-07 17:01:31 -03:00 committed by Mauro Carvalho Chehab
parent 0d62f800b5
commit 050ae82c35
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/media/tuners/m88ts2022.c
View File

@ -26,17 +26,22 @@
static int m88ts2022_wr_regs(struct m88ts2022_priv *priv, static int m88ts2022_wr_regs(struct m88ts2022_priv *priv,
u8 reg, const u8 *val, int len) u8 reg, const u8 *val, int len)
{ {
#define MAX_WR_LEN 3
#define MAX_WR_XFER_LEN (MAX_WR_LEN + 1)
int ret; int ret;
u8 buf[1 + len]; u8 buf[MAX_WR_XFER_LEN];
struct i2c_msg msg[1] = { struct i2c_msg msg[1] = {
{ {
.addr = priv->cfg->i2c_addr, .addr = priv->cfg->i2c_addr,
.flags = 0, .flags = 0,
.len = sizeof(buf), .len = 1 + len,
.buf = buf, .buf = buf,
} }
}; };
if (WARN_ON(len > MAX_WR_LEN))
return -EINVAL;
buf[0] = reg; buf[0] = reg;
memcpy(&buf[1], val, len); memcpy(&buf[1], val, len);
@ -57,8 +62,10 @@ static int m88ts2022_wr_regs(struct m88ts2022_priv *priv,
static int m88ts2022_rd_regs(struct m88ts2022_priv *priv, u8 reg, static int m88ts2022_rd_regs(struct m88ts2022_priv *priv, u8 reg,
u8 *val, int len) u8 *val, int len)
{ {
#define MAX_RD_LEN 1
#define MAX_RD_XFER_LEN (MAX_RD_LEN)
int ret; int ret;
u8 buf[len]; u8 buf[MAX_RD_XFER_LEN];
struct i2c_msg msg[2] = { struct i2c_msg msg[2] = {
{ {
.addr = priv->cfg->i2c_addr, .addr = priv->cfg->i2c_addr,
@ -68,11 +75,14 @@ static int m88ts2022_rd_regs(struct m88ts2022_priv *priv, u8 reg,
}, { }, {
.addr = priv->cfg->i2c_addr, .addr = priv->cfg->i2c_addr,
.flags = I2C_M_RD, .flags = I2C_M_RD,
.len = sizeof(buf), .len = len,
.buf = buf, .buf = buf,
} }
}; };
if (WARN_ON(len > MAX_RD_LEN))
return -EINVAL;
ret = i2c_transfer(priv->i2c, msg, 2); ret = i2c_transfer(priv->i2c, msg, 2);
if (ret == 2) { if (ret == 2) {
memcpy(val, buf, len); memcpy(val, buf, len);