korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-29 14:05:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

ksmbd: call putname after using the last component

Browse Source 
[ Upstream commit 6fe55c2799 ]

last component point filename struct. Currently putname is called after
vfs_path_parent_lookup(). And then last component is used for
lookup_one_qstr_excl(). name in last component is freed by previous
calling putname(). And It cause file lookup failure when testing
generic/464 test of xfstest.

Fixes: 74d7970feb ("ksmbd: fix racy issue from using ->d_parent and ->d_name")
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Namjae Jeon 2023-12-19 00:33:57 +09:00 committed by Greg Kroah-Hartman
parent b423ddab61
commit 049ed0f953
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/ksmbd/vfs.c
View File

@ -86,12 +86,14 @@ static int ksmbd_vfs_path_lookup_locked(struct ksmbd_share_config *share_conf,
err = vfs_path_parent_lookup(filename, flags, err = vfs_path_parent_lookup(filename, flags,
&parent_path, &last, &type, &parent_path, &last, &type,
root_share_path); root_share_path);
putname(filename); if (err) {
if (err) putname(filename);
return err; return err;
}
if (unlikely(type != LAST_NORM)) { if (unlikely(type != LAST_NORM)) {
path_put(&parent_path); path_put(&parent_path);
putname(filename);
return -ENOENT; return -ENOENT;
} }
@ -108,12 +110,14 @@ static int ksmbd_vfs_path_lookup_locked(struct ksmbd_share_config *share_conf,
path->dentry = d; path->dentry = d;
path->mnt = share_conf->vfs_path.mnt; path->mnt = share_conf->vfs_path.mnt;
path_put(&parent_path); path_put(&parent_path);
putname(filename);
return 0; return 0;
err_out: err_out:
inode_unlock(parent_path.dentry->d_inode); inode_unlock(parent_path.dentry->d_inode);
path_put(&parent_path); path_put(&parent_path);
putname(filename);
return -ENOENT; return -ENOENT;
} }