ACPI: EC: Avoid returning AE_OK on errors in address space handler

[ Upstream commit c4bd7f1d78 ]

If an error code other than EINVAL, ENODEV or ETIME is returned
by acpi_ec_read() / acpi_ec_write(), then AE_OK is incorrectly
returned by acpi_ec_space_handler().

Fix this by only returning AE_OK on success, and return AE_ERROR
otherwise.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Armin Wolf 2024-05-22 23:36:49 +02:00 committed by Greg Kroah-Hartman
parent 284daacf26
commit 044a7bfca8

View File

@ -1321,8 +1321,10 @@ acpi_ec_space_handler(u32 function, acpi_physical_address address,
return AE_NOT_FOUND; return AE_NOT_FOUND;
case -ETIME: case -ETIME:
return AE_TIME; return AE_TIME;
default: case 0:
return AE_OK; return AE_OK;
default:
return AE_ERROR;
} }
} }