mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-15 15:04:27 +08:00
platform: x86: Deletion of checks before backlight_device_unregister()
The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> For msi-wmi.c: Acked-by: Anisse Astier <anisse@astier.eu> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
This commit is contained in:
parent
a39f46df33
commit
0098181016
@ -843,8 +843,7 @@ static int asus_backlight_init(struct asus_laptop *asus)
|
||||
|
||||
static void asus_backlight_exit(struct asus_laptop *asus)
|
||||
{
|
||||
if (asus->backlight_device)
|
||||
backlight_device_unregister(asus->backlight_device);
|
||||
backlight_device_unregister(asus->backlight_device);
|
||||
asus->backlight_device = NULL;
|
||||
}
|
||||
|
||||
|
@ -1308,8 +1308,7 @@ static int asus_wmi_backlight_init(struct asus_wmi *asus)
|
||||
|
||||
static void asus_wmi_backlight_exit(struct asus_wmi *asus)
|
||||
{
|
||||
if (asus->backlight_device)
|
||||
backlight_device_unregister(asus->backlight_device);
|
||||
backlight_device_unregister(asus->backlight_device);
|
||||
|
||||
asus->backlight_device = NULL;
|
||||
}
|
||||
|
@ -1174,8 +1174,7 @@ static int eeepc_backlight_init(struct eeepc_laptop *eeepc)
|
||||
|
||||
static void eeepc_backlight_exit(struct eeepc_laptop *eeepc)
|
||||
{
|
||||
if (eeepc->backlight_device)
|
||||
backlight_device_unregister(eeepc->backlight_device);
|
||||
backlight_device_unregister(eeepc->backlight_device);
|
||||
eeepc->backlight_device = NULL;
|
||||
}
|
||||
|
||||
|
@ -1154,8 +1154,7 @@ fail_hotkey1:
|
||||
fail_hotkey:
|
||||
platform_driver_unregister(&fujitsupf_driver);
|
||||
fail_backlight:
|
||||
if (fujitsu->bl_device)
|
||||
backlight_device_unregister(fujitsu->bl_device);
|
||||
backlight_device_unregister(fujitsu->bl_device);
|
||||
fail_sysfs_group:
|
||||
sysfs_remove_group(&fujitsu->pf_device->dev.kobj,
|
||||
&fujitsupf_attribute_group);
|
||||
@ -1179,8 +1178,7 @@ static void __exit fujitsu_cleanup(void)
|
||||
|
||||
platform_driver_unregister(&fujitsupf_driver);
|
||||
|
||||
if (fujitsu->bl_device)
|
||||
backlight_device_unregister(fujitsu->bl_device);
|
||||
backlight_device_unregister(fujitsu->bl_device);
|
||||
|
||||
sysfs_remove_group(&fujitsu->pf_device->dev.kobj,
|
||||
&fujitsupf_attribute_group);
|
||||
|
@ -729,8 +729,7 @@ static int ideapad_backlight_init(struct ideapad_private *priv)
|
||||
|
||||
static void ideapad_backlight_exit(struct ideapad_private *priv)
|
||||
{
|
||||
if (priv->blightdev)
|
||||
backlight_device_unregister(priv->blightdev);
|
||||
backlight_device_unregister(priv->blightdev);
|
||||
priv->blightdev = NULL;
|
||||
}
|
||||
|
||||
|
@ -271,8 +271,7 @@ static int oaktrail_backlight_init(void)
|
||||
|
||||
static void oaktrail_backlight_exit(void)
|
||||
{
|
||||
if (oaktrail_bl_device)
|
||||
backlight_device_unregister(oaktrail_bl_device);
|
||||
backlight_device_unregister(oaktrail_bl_device);
|
||||
}
|
||||
|
||||
static int oaktrail_probe(struct platform_device *pdev)
|
||||
|
@ -354,8 +354,7 @@ static void __exit msi_wmi_exit(void)
|
||||
sparse_keymap_free(msi_wmi_input_dev);
|
||||
input_unregister_device(msi_wmi_input_dev);
|
||||
}
|
||||
if (backlight)
|
||||
backlight_device_unregister(backlight);
|
||||
backlight_device_unregister(backlight);
|
||||
}
|
||||
|
||||
module_init(msi_wmi_init);
|
||||
|
@ -3141,8 +3141,7 @@ static void sony_nc_backlight_setup(void)
|
||||
|
||||
static void sony_nc_backlight_cleanup(void)
|
||||
{
|
||||
if (sony_bl_props.dev)
|
||||
backlight_device_unregister(sony_bl_props.dev);
|
||||
backlight_device_unregister(sony_bl_props.dev);
|
||||
}
|
||||
|
||||
static int sony_nc_add(struct acpi_device *device)
|
||||
|
@ -1797,8 +1797,7 @@ static int toshiba_acpi_remove(struct acpi_device *acpi_dev)
|
||||
rfkill_destroy(dev->bt_rfk);
|
||||
}
|
||||
|
||||
if (dev->backlight_dev)
|
||||
backlight_device_unregister(dev->backlight_dev);
|
||||
backlight_device_unregister(dev->backlight_dev);
|
||||
|
||||
if (dev->illumination_supported)
|
||||
led_classdev_unregister(&dev->led_dev);
|
||||
|
Loading…
Reference in New Issue
Block a user