2018-08-10 18:26:49 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2011-10-29 17:57:23 +08:00
|
|
|
/*
|
2017-06-22 18:17:33 +08:00
|
|
|
* Synopsys DesignWare I2C adapter driver.
|
2011-10-29 17:57:23 +08:00
|
|
|
*
|
|
|
|
|
* Based on the TI DAVINCI I2C adapter driver.
|
|
|
|
|
*
|
|
|
|
|
* Copyright (C) 2006 Texas Instruments.
|
|
|
|
|
* Copyright (C) 2007 MontaVista Software Inc.
|
|
|
|
|
* Copyright (C) 2009 Provigent Ltd.
|
|
|
|
|
*/
|
2017-06-14 18:43:21 +08:00
|
|
|
#include <linux/acpi.h>
|
|
|
|
|
#include <linux/clk-provider.h>
|
|
|
|
|
#include <linux/clk.h>
|
2011-10-29 17:57:23 +08:00
|
|
|
#include <linux/delay.h>
|
2020-07-02 18:33:21 +08:00
|
|
|
#include <linux/dmi.h>
|
2011-10-29 17:57:23 +08:00
|
|
|
#include <linux/err.h>
|
2017-06-14 18:43:21 +08:00
|
|
|
#include <linux/errno.h>
|
|
|
|
|
#include <linux/i2c.h>
|
2011-10-29 17:57:23 +08:00
|
|
|
#include <linux/interrupt.h>
|
2017-06-14 18:43:21 +08:00
|
|
|
#include <linux/io.h>
|
|
|
|
|
#include <linux/kernel.h>
|
2020-05-28 17:33:21 +08:00
|
|
|
#include <linux/mfd/syscon.h>
|
2017-06-14 18:43:21 +08:00
|
|
|
#include <linux/module.h>
|
2013-06-26 16:55:06 +08:00
|
|
|
#include <linux/of.h>
|
2011-10-29 17:57:23 +08:00
|
|
|
#include <linux/platform_device.h>
|
2012-02-24 19:31:15 +08:00
|
|
|
#include <linux/pm.h>
|
2013-01-17 18:31:06 +08:00
|
|
|
#include <linux/pm_runtime.h>
|
2015-11-30 23:11:44 +08:00
|
|
|
#include <linux/property.h>
|
2020-05-28 17:33:21 +08:00
|
|
|
#include <linux/regmap.h>
|
2016-12-27 22:22:40 +08:00
|
|
|
#include <linux/reset.h>
|
2017-06-14 18:43:21 +08:00
|
|
|
#include <linux/sched.h>
|
2011-10-29 17:57:23 +08:00
|
|
|
#include <linux/slab.h>
|
PM: i2c-designware-platdrv: Optimize power management
Optimize the power management in i2c-designware-platdrv by making it
set the DPM_FLAG_SMART_SUSPEND and DPM_FLAG_LEAVE_SUSPENDED which
allows some code to be dropped from its PM callbacks.
First, setting DPM_FLAG_SMART_SUSPEND causes the intel-lpss driver
to avoid resuming i2c-designware-platdrv devices in its ->prepare
callback, so they can stay in runtime suspend after that point even
if the direct-complete feature is not used for them.
It also causes the ACPI PM domain and the PM core to avoid invoking
"late" and "noirq" suspend callbacks for these devices if they are
in runtime suspend at the beginning of the "late" phase of device
suspend during system suspend. That guarantees dw_i2c_plat_suspend()
to be called for a device only if it is not in runtime suspend.
Moreover, it causes the device's runtime PM status to be set to
"active" after calling dw_i2c_plat_resume() for it, so the
driver doesn't need internal flags to avoid invoking either
dw_i2c_plat_suspend() or dw_i2c_plat_resume() twice in a row.
Second, setting DPM_FLAG_LEAVE_SUSPENDED enables the optimization
allowing the device to stay suspended after system resume under
suitable conditions, so again the driver doesn't need to take
care of that by itself.
Accordingly, the internal "suspended" and "skip_resume" flags
used by the driver are not necessary any more, so drop them and
simplify the driver's PM callbacks.
Additionally, notice that dw_i2c_plat_complete() only needs to
schedule runtime PM resume for the device if platform firmware
has been involved in resuming the system, so make it call
pm_resume_via_firmware() to check that. Also make it check the
runtime PM status of the device instead of its direct_complete
flag which also works if the device remained suspended due to
the DPM_FLAG_LEAVE_SUSPENDED driver flag.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
2018-01-03 08:37:34 +08:00
|
|
|
#include <linux/suspend.h>
|
2021-07-12 22:20:26 +08:00
|
|
|
#include <linux/units.h>
|
2017-06-14 18:43:21 +08:00
|
|
|
|
2011-10-29 17:57:23 +08:00
|
|
|
#include "i2c-designware-core.h"
|
|
|
|
|
|
2011-10-07 02:26:30 +08:00
|
|
|
static u32 i2c_dw_get_clk_rate_khz(struct dw_i2c_dev *dev)
|
|
|
|
|
{
|
2021-07-12 22:20:26 +08:00
|
|
|
return clk_get_rate(dev->clk) / KILO;
|
2011-10-07 02:26:30 +08:00
|
|
|
}
|
2011-10-29 17:57:23 +08:00
|
|
|
|
2013-01-17 18:31:07 +08:00
|
|
|
#ifdef CONFIG_ACPI
|
|
|
|
|
static const struct acpi_device_id dw_i2c_acpi_match[] = {
|
|
|
|
|
{ "INT33C2", 0 },
|
|
|
|
|
{ "INT33C3", 0 },
|
2013-11-12 17:57:30 +08:00
|
|
|
{ "INT3432", 0 },
|
|
|
|
|
{ "INT3433", 0 },
|
2018-10-06 16:25:39 +08:00
|
|
|
{ "80860F41", ACCESS_NO_IRQ_SUSPEND },
|
2020-05-28 17:33:17 +08:00
|
|
|
{ "808622C1", ACCESS_NO_IRQ_SUSPEND },
|
2015-12-11 20:02:53 +08:00
|
|
|
{ "AMD0010", ACCESS_INTR_MASK },
|
2016-03-10 19:34:52 +08:00
|
|
|
{ "AMDI0010", ACCESS_INTR_MASK },
|
2015-12-16 05:55:53 +08:00
|
|
|
{ "AMDI0510", 0 },
|
2015-12-11 05:19:17 +08:00
|
|
|
{ "APMC0D0F", 0 },
|
2017-04-22 11:23:44 +08:00
|
|
|
{ "HISI02A1", 0 },
|
|
|
|
|
{ "HISI02A2", 0 },
|
2020-02-03 09:36:07 +08:00
|
|
|
{ "HISI02A3", 0 },
|
2020-08-07 17:35:29 +08:00
|
|
|
{ "HYGO0010", ACCESS_INTR_MASK },
|
2013-01-17 18:31:07 +08:00
|
|
|
{ }
|
|
|
|
|
};
|
|
|
|
|
MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
|
|
|
|
|
#endif
|
|
|
|
|
|
2018-08-31 23:11:09 +08:00
|
|
|
#ifdef CONFIG_OF
|
2020-05-28 17:33:21 +08:00
|
|
|
#define BT1_I2C_CTL 0x100
|
|
|
|
|
#define BT1_I2C_CTL_ADDR_MASK GENMASK(7, 0)
|
|
|
|
|
#define BT1_I2C_CTL_WR BIT(8)
|
|
|
|
|
#define BT1_I2C_CTL_GO BIT(31)
|
|
|
|
|
#define BT1_I2C_DI 0x104
|
|
|
|
|
#define BT1_I2C_DO 0x108
|
|
|
|
|
|
|
|
|
|
static int bt1_i2c_read(void *context, unsigned int reg, unsigned int *val)
|
|
|
|
|
{
|
|
|
|
|
struct dw_i2c_dev *dev = context;
|
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Note these methods shouldn't ever fail because the system controller
|
|
|
|
|
* registers are memory mapped. We check the return value just in case.
|
|
|
|
|
*/
|
|
|
|
|
ret = regmap_write(dev->sysmap, BT1_I2C_CTL,
|
|
|
|
|
BT1_I2C_CTL_GO | (reg & BT1_I2C_CTL_ADDR_MASK));
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
return regmap_read(dev->sysmap, BT1_I2C_DO, val);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int bt1_i2c_write(void *context, unsigned int reg, unsigned int val)
|
|
|
|
|
{
|
|
|
|
|
struct dw_i2c_dev *dev = context;
|
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
|
|
ret = regmap_write(dev->sysmap, BT1_I2C_DI, val);
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
return regmap_write(dev->sysmap, BT1_I2C_CTL,
|
|
|
|
|
BT1_I2C_CTL_GO | BT1_I2C_CTL_WR | (reg & BT1_I2C_CTL_ADDR_MASK));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct regmap_config bt1_i2c_cfg = {
|
|
|
|
|
.reg_bits = 32,
|
|
|
|
|
.val_bits = 32,
|
|
|
|
|
.reg_stride = 4,
|
|
|
|
|
.fast_io = true,
|
|
|
|
|
.reg_read = bt1_i2c_read,
|
|
|
|
|
.reg_write = bt1_i2c_write,
|
|
|
|
|
.max_register = DW_IC_COMP_TYPE,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static int bt1_i2c_request_regs(struct dw_i2c_dev *dev)
|
|
|
|
|
{
|
|
|
|
|
dev->sysmap = syscon_node_to_regmap(dev->dev->of_node->parent);
|
|
|
|
|
if (IS_ERR(dev->sysmap))
|
|
|
|
|
return PTR_ERR(dev->sysmap);
|
|
|
|
|
|
|
|
|
|
dev->map = devm_regmap_init(dev->dev, NULL, dev, &bt1_i2c_cfg);
|
|
|
|
|
return PTR_ERR_OR_ZERO(dev->map);
|
|
|
|
|
}
|
|
|
|
|
|
2018-08-31 23:11:12 +08:00
|
|
|
#define MSCC_ICPU_CFG_TWI_DELAY 0x0
|
|
|
|
|
#define MSCC_ICPU_CFG_TWI_DELAY_ENABLE BIT(0)
|
|
|
|
|
#define MSCC_ICPU_CFG_TWI_SPIKE_FILTER 0x4
|
|
|
|
|
|
|
|
|
|
static int mscc_twi_set_sda_hold_time(struct dw_i2c_dev *dev)
|
|
|
|
|
{
|
|
|
|
|
writel((dev->sda_hold_time << 1) | MSCC_ICPU_CFG_TWI_DELAY_ENABLE,
|
|
|
|
|
dev->ext + MSCC_ICPU_CFG_TWI_DELAY);
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int dw_i2c_of_configure(struct platform_device *pdev)
|
|
|
|
|
{
|
|
|
|
|
struct dw_i2c_dev *dev = platform_get_drvdata(pdev);
|
|
|
|
|
|
|
|
|
|
switch (dev->flags & MODEL_MASK) {
|
|
|
|
|
case MODEL_MSCC_OCELOT:
|
2020-04-25 21:44:44 +08:00
|
|
|
dev->ext = devm_platform_ioremap_resource(pdev, 1);
|
2018-08-31 23:11:12 +08:00
|
|
|
if (!IS_ERR(dev->ext))
|
|
|
|
|
dev->set_sda_hold_time = mscc_twi_set_sda_hold_time;
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2018-08-31 23:11:09 +08:00
|
|
|
static const struct of_device_id dw_i2c_of_match[] = {
|
|
|
|
|
{ .compatible = "snps,designware-i2c", },
|
2018-08-31 23:11:12 +08:00
|
|
|
{ .compatible = "mscc,ocelot-i2c", .data = (void *)MODEL_MSCC_OCELOT },
|
2020-05-28 17:33:21 +08:00
|
|
|
{ .compatible = "baikal,bt1-sys-i2c", .data = (void *)MODEL_BAIKAL_BT1 },
|
2018-08-31 23:11:09 +08:00
|
|
|
{},
|
|
|
|
|
};
|
|
|
|
|
MODULE_DEVICE_TABLE(of, dw_i2c_of_match);
|
2018-08-31 23:11:12 +08:00
|
|
|
#else
|
2020-05-28 17:33:21 +08:00
|
|
|
static int bt1_i2c_request_regs(struct dw_i2c_dev *dev)
|
2018-08-31 23:11:12 +08:00
|
|
|
{
|
|
|
|
|
return -ENODEV;
|
|
|
|
|
}
|
2017-06-14 18:43:22 +08:00
|
|
|
|
2018-08-31 23:11:12 +08:00
|
|
|
static inline int dw_i2c_of_configure(struct platform_device *pdev)
|
2017-06-22 18:17:33 +08:00
|
|
|
{
|
2018-08-31 23:11:12 +08:00
|
|
|
return -ENODEV;
|
2016-01-04 23:17:35 +08:00
|
|
|
}
|
2018-08-31 23:11:09 +08:00
|
|
|
#endif
|
2016-01-04 23:17:35 +08:00
|
|
|
|
2017-09-26 05:10:06 +08:00
|
|
|
static void dw_i2c_plat_pm_cleanup(struct dw_i2c_dev *dev)
|
|
|
|
|
{
|
|
|
|
|
pm_runtime_disable(dev->dev);
|
|
|
|
|
|
2018-09-06 03:51:31 +08:00
|
|
|
if (dev->shared_with_punit)
|
2017-09-26 05:10:06 +08:00
|
|
|
pm_runtime_put_noidle(dev->dev);
|
|
|
|
|
}
|
|
|
|
|
|
2020-05-28 17:33:20 +08:00
|
|
|
static int dw_i2c_plat_request_regs(struct dw_i2c_dev *dev)
|
|
|
|
|
{
|
|
|
|
|
struct platform_device *pdev = to_platform_device(dev->dev);
|
2020-05-28 17:33:21 +08:00
|
|
|
int ret;
|
2020-05-28 17:33:20 +08:00
|
|
|
|
2020-05-28 17:33:21 +08:00
|
|
|
switch (dev->flags & MODEL_MASK) {
|
|
|
|
|
case MODEL_BAIKAL_BT1:
|
|
|
|
|
ret = bt1_i2c_request_regs(dev);
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
dev->base = devm_platform_ioremap_resource(pdev, 0);
|
|
|
|
|
ret = PTR_ERR_OR_ZERO(dev->base);
|
|
|
|
|
break;
|
|
|
|
|
}
|
2020-05-28 17:33:20 +08:00
|
|
|
|
2020-05-28 17:33:21 +08:00
|
|
|
return ret;
|
2020-05-28 17:33:20 +08:00
|
|
|
}
|
2020-03-24 20:32:16 +08:00
|
|
|
|
2020-07-02 18:33:21 +08:00
|
|
|
static const struct dmi_system_id dw_i2c_hwmon_class_dmi[] = {
|
|
|
|
|
{
|
|
|
|
|
.ident = "Qtechnology QT5222",
|
|
|
|
|
.matches = {
|
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "Qtechnology"),
|
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "QT5222"),
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
{ } /* terminate list */
|
|
|
|
|
};
|
|
|
|
|
|
2015-08-31 22:31:32 +08:00
|
|
|
static int dw_i2c_plat_probe(struct platform_device *pdev)
|
2011-10-29 17:57:23 +08:00
|
|
|
{
|
|
|
|
|
struct i2c_adapter *adap;
|
2017-06-14 18:43:21 +08:00
|
|
|
struct dw_i2c_dev *dev;
|
2018-07-25 22:39:26 +08:00
|
|
|
struct i2c_timings *t;
|
2020-05-19 20:50:41 +08:00
|
|
|
int irq, ret;
|
2011-10-29 17:57:23 +08:00
|
|
|
|
|
|
|
|
irq = platform_get_irq(pdev, 0);
|
2015-03-09 17:03:12 +08:00
|
|
|
if (irq < 0)
|
|
|
|
|
return irq;
|
2011-10-29 17:57:23 +08:00
|
|
|
|
2013-04-10 08:36:36 +08:00
|
|
|
dev = devm_kzalloc(&pdev->dev, sizeof(struct dw_i2c_dev), GFP_KERNEL);
|
|
|
|
|
if (!dev)
|
|
|
|
|
return -ENOMEM;
|
2011-10-29 17:57:23 +08:00
|
|
|
|
2020-05-28 17:33:19 +08:00
|
|
|
dev->flags = (uintptr_t)device_get_match_data(&pdev->dev);
|
2013-04-10 08:36:36 +08:00
|
|
|
dev->dev = &pdev->dev;
|
2011-10-29 17:57:23 +08:00
|
|
|
dev->irq = irq;
|
|
|
|
|
platform_set_drvdata(pdev, dev);
|
|
|
|
|
|
2020-05-28 17:33:20 +08:00
|
|
|
ret = dw_i2c_plat_request_regs(dev);
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
2016-12-27 22:22:40 +08:00
|
|
|
dev->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL);
|
2019-08-19 18:31:30 +08:00
|
|
|
if (IS_ERR(dev->rst))
|
|
|
|
|
return PTR_ERR(dev->rst);
|
|
|
|
|
|
|
|
|
|
reset_control_deassert(dev->rst);
|
2016-12-27 22:22:40 +08:00
|
|
|
|
2018-07-25 22:39:26 +08:00
|
|
|
t = &dev->timings;
|
2021-03-31 23:48:51 +08:00
|
|
|
i2c_parse_fw_timings(&pdev->dev, t, false);
|
2015-11-30 23:11:44 +08:00
|
|
|
|
2020-06-23 17:15:01 +08:00
|
|
|
i2c_dw_adjust_bus_speed(dev);
|
2018-08-31 23:11:08 +08:00
|
|
|
|
2018-08-31 23:11:12 +08:00
|
|
|
if (pdev->dev.of_node)
|
|
|
|
|
dw_i2c_of_configure(pdev);
|
|
|
|
|
|
2015-11-30 23:11:44 +08:00
|
|
|
if (has_acpi_companion(&pdev->dev))
|
2020-05-19 20:50:41 +08:00
|
|
|
i2c_dw_acpi_configure(&pdev->dev);
|
2015-11-30 23:11:44 +08:00
|
|
|
|
2020-05-19 20:50:39 +08:00
|
|
|
ret = i2c_dw_validate_speed(dev);
|
|
|
|
|
if (ret)
|
2016-12-27 22:22:40 +08:00
|
|
|
goto exit_reset;
|
2013-06-26 16:55:06 +08:00
|
|
|
|
2017-06-14 18:43:21 +08:00
|
|
|
ret = i2c_dw_probe_lock_support(dev);
|
|
|
|
|
if (ret)
|
2016-12-27 22:22:40 +08:00
|
|
|
goto exit_reset;
|
2015-01-15 17:12:17 +08:00
|
|
|
|
2020-04-25 21:44:45 +08:00
|
|
|
i2c_dw_configure(dev);
|
2011-10-07 02:26:31 +08:00
|
|
|
|
2019-02-28 21:52:10 +08:00
|
|
|
/* Optional interface clock */
|
|
|
|
|
dev->pclk = devm_clk_get_optional(&pdev->dev, "pclk");
|
2019-08-19 18:24:23 +08:00
|
|
|
if (IS_ERR(dev->pclk)) {
|
|
|
|
|
ret = PTR_ERR(dev->pclk);
|
|
|
|
|
goto exit_reset;
|
|
|
|
|
}
|
2019-02-28 21:52:10 +08:00
|
|
|
|
2014-09-30 18:04:54 +08:00
|
|
|
dev->clk = devm_clk_get(&pdev->dev, NULL);
|
2017-11-02 10:40:26 +08:00
|
|
|
if (!i2c_dw_prepare_clk(dev, true)) {
|
2018-07-25 22:39:26 +08:00
|
|
|
u64 clk_khz;
|
|
|
|
|
|
2016-01-04 23:17:35 +08:00
|
|
|
dev->get_clk_rate_khz = i2c_dw_get_clk_rate_khz;
|
2018-07-25 22:39:26 +08:00
|
|
|
clk_khz = dev->get_clk_rate_khz(dev);
|
2014-09-30 18:04:54 +08:00
|
|
|
|
2018-07-25 22:39:26 +08:00
|
|
|
if (!dev->sda_hold_time && t->sda_hold_ns)
|
|
|
|
|
dev->sda_hold_time =
|
2021-07-12 22:20:26 +08:00
|
|
|
DIV_S64_ROUND_CLOSEST(clk_khz * t->sda_hold_ns, MICRO);
|
2014-09-30 18:04:54 +08:00
|
|
|
}
|
|
|
|
|
|
2011-10-29 17:57:23 +08:00
|
|
|
adap = &dev->adapter;
|
|
|
|
|
adap->owner = THIS_MODULE;
|
2020-07-02 18:33:21 +08:00
|
|
|
adap->class = dmi_check_system(dw_i2c_hwmon_class_dmi) ?
|
|
|
|
|
I2C_CLASS_HWMON : I2C_CLASS_DEPRECATED;
|
2015-10-24 03:27:07 +08:00
|
|
|
ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
|
2011-11-09 04:43:47 +08:00
|
|
|
adap->dev.of_node = pdev->dev.of_node;
|
i2c: i2c-designware-platdrv: Always use a dynamic adapter number
Before this commit the i2c-designware-platdrv assumes that if the pdev
has an apci-companion it should use a dynamic adapter-nr and it sets
adapter->nr to -1, otherwise it will use pdev->id as adapter->nr.
There are 3 ways how platform_device-s to which i2c-designware-platdrv
will bind can be instantiated:
1) Through of / devicetree
2) Through ACPI enumeration
3) Explicitly instantiated through platform_device_create + add
1) In case of devicetree-instantiation the drivers/of code always sets
pdev->id to PLATFORM_DEVID_NONE, which is -1 so in this case both paths
to set adapter->nr end up doing the same thing.
2) In case of ACPI instantiation the device will always have an
ACPI-companion, so we are already using dynamic adapter-nrs.
3) There are 2 places manually instantiating a designware_i2c platform_dev:
drivers/mfd/intel_quark_i2c_gpio.c
drivers/mfd/intel-lpss.c
In the intel_quark_i2c_gpio.c case pdev->id is always 0, so switching to
dynamic adapter-nrs here could lead to the bus-number no longer being
stable, but the quark X1000 only has 1 i2c-controller, which will also
be assigned bus-number 0 when using dynamic adapter-nrs.
In the intel-lpss.c case intel_lpss_probe() is called from either
intel-lpss-acpi.c in which case there always is an ACPI-companion, or
from intel-lpss-pci.c. In most cases devices handled by intel-lpss-pci.c
also have an ACPI-companion, so we use a dynamic adapter-nr. But in some
cases the ACPI-companion is missing and we would use pdev->id (allocated
from intel_lpss_devid_ida). Devices which use the intel-lpss-pci.c code
typically have many i2c busses, so using pdev->id in this case may lead
to a bus-number conflict, triggering a WARN(id < 0, "couldn't get idr")
in i2c-core-base.c causing an oops an the adapter registration to fail.
So in this case using non dynamic adapter-nrs is actually undesirable.
One machine on which this oops was triggering is the Apollo Lake based
Acer TravelMate Spin B118.
TL;DR: Switching to always using dynamic adapter-numbers does not make
any difference in most cases and in the one case where it does make a
difference the behavior change is desirable because the old behavior
caused an oops.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1687065
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2019-03-12 22:55:54 +08:00
|
|
|
adap->nr = -1;
|
2011-10-29 17:57:23 +08:00
|
|
|
|
i2c: designware: platdrv: Remove DPM_FLAG_SMART_SUSPEND flag on BYT and CHT
We already set DPM_FLAG_SMART_PREPARE, so we completely skip all
callbacks (other then prepare) where possible, quoting from
dw_i2c_plat_prepare():
/*
* If the ACPI companion device object is present for this device, it
* may be accessed during suspend and resume of other devices via I2C
* operation regions, so tell the PM core and middle layers to avoid
* skipping system suspend/resume callbacks for it in that case.
*/
return !has_acpi_companion(dev);
Also setting the DPM_FLAG_SMART_SUSPEND will cause acpi_subsys_suspend()
to leave the controller runtime-suspended even if dw_i2c_plat_prepare()
returned 0.
Leaving the controller runtime-suspended normally, when the I2C controller
is suspended during the suspend_late phase, is not an issue because
the pm_runtime_get_sync() done by i2c_dw_xfer() will (runtime-)resume it.
But for dw I2C controllers on Bay- and Cherry-Trail devices acpi_lpss.c
leaves the controller alive until the suspend_noirq phase, because it may
be used by the _PS3 ACPI methods of PCI devices and PCI devices are left
powered on until the suspend_noirq phase.
Between the suspend_late and resume_early phases runtime-pm is disabled.
So for any ACPI I2C OPRegion accesses done after the suspend_late phase,
the pm_runtime_get_sync() done by i2c_dw_xfer() is a no-op and the
controller is left runtime-suspended.
i2c_dw_xfer() has a check to catch this condition (rather then waiting
for the I2C transfer to timeout because the controller is suspended).
acpi_subsys_suspend() leaving the controller runtime-suspended in
combination with an ACPI I2C OPRegion access done after the suspend_late
phase triggers this check, leading to the following error being logged
on a Bay Trail based Lenovo Thinkpad 8 tablet:
[ 93.275882] i2c_designware 80860F41:00: Transfer while suspended
[ 93.275993] WARNING: CPU: 0 PID: 412 at drivers/i2c/busses/i2c-designware-master.c:429 i2c_dw_xfer+0x239/0x280
...
[ 93.276252] Workqueue: kacpi_notify acpi_os_execute_deferred
[ 93.276267] RIP: 0010:i2c_dw_xfer+0x239/0x280
...
[ 93.276340] Call Trace:
[ 93.276366] __i2c_transfer+0x121/0x520
[ 93.276379] i2c_transfer+0x4c/0x100
[ 93.276392] i2c_acpi_space_handler+0x219/0x510
[ 93.276408] ? up+0x40/0x60
[ 93.276419] ? i2c_acpi_notify+0x130/0x130
[ 93.276433] acpi_ev_address_space_dispatch+0x1e1/0x252
...
So since on BYT and CHT platforms we want ACPI I2c OPRegion accesses
to work until the suspend_noirq phase, we need the controller to be
runtime-resumed during the suspend phase if it is runtime-suspended
suspended at that time. This means that we must not set the
DPM_FLAG_SMART_SUSPEND on these platforms.
On BYT and CHT we already have a special ACCESS_NO_IRQ_SUSPEND flag
to make sure the controller stays functional until the suspend_noirq
phase. This commit makes the driver not set the DPM_FLAG_SMART_SUSPEND
flag when that flag is set.
Cc: stable@vger.kernel.org
Fixes: b30f2f65568f ("i2c: designware: Set IRQF_NO_SUSPEND flag for all BYT and CHT controllers")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2020-04-08 02:11:16 +08:00
|
|
|
if (dev->flags & ACCESS_NO_IRQ_SUSPEND) {
|
|
|
|
|
dev_pm_set_driver_flags(&pdev->dev,
|
|
|
|
|
DPM_FLAG_SMART_PREPARE |
|
2020-04-19 00:53:20 +08:00
|
|
|
DPM_FLAG_MAY_SKIP_RESUME);
|
i2c: designware: platdrv: Remove DPM_FLAG_SMART_SUSPEND flag on BYT and CHT
We already set DPM_FLAG_SMART_PREPARE, so we completely skip all
callbacks (other then prepare) where possible, quoting from
dw_i2c_plat_prepare():
/*
* If the ACPI companion device object is present for this device, it
* may be accessed during suspend and resume of other devices via I2C
* operation regions, so tell the PM core and middle layers to avoid
* skipping system suspend/resume callbacks for it in that case.
*/
return !has_acpi_companion(dev);
Also setting the DPM_FLAG_SMART_SUSPEND will cause acpi_subsys_suspend()
to leave the controller runtime-suspended even if dw_i2c_plat_prepare()
returned 0.
Leaving the controller runtime-suspended normally, when the I2C controller
is suspended during the suspend_late phase, is not an issue because
the pm_runtime_get_sync() done by i2c_dw_xfer() will (runtime-)resume it.
But for dw I2C controllers on Bay- and Cherry-Trail devices acpi_lpss.c
leaves the controller alive until the suspend_noirq phase, because it may
be used by the _PS3 ACPI methods of PCI devices and PCI devices are left
powered on until the suspend_noirq phase.
Between the suspend_late and resume_early phases runtime-pm is disabled.
So for any ACPI I2C OPRegion accesses done after the suspend_late phase,
the pm_runtime_get_sync() done by i2c_dw_xfer() is a no-op and the
controller is left runtime-suspended.
i2c_dw_xfer() has a check to catch this condition (rather then waiting
for the I2C transfer to timeout because the controller is suspended).
acpi_subsys_suspend() leaving the controller runtime-suspended in
combination with an ACPI I2C OPRegion access done after the suspend_late
phase triggers this check, leading to the following error being logged
on a Bay Trail based Lenovo Thinkpad 8 tablet:
[ 93.275882] i2c_designware 80860F41:00: Transfer while suspended
[ 93.275993] WARNING: CPU: 0 PID: 412 at drivers/i2c/busses/i2c-designware-master.c:429 i2c_dw_xfer+0x239/0x280
...
[ 93.276252] Workqueue: kacpi_notify acpi_os_execute_deferred
[ 93.276267] RIP: 0010:i2c_dw_xfer+0x239/0x280
...
[ 93.276340] Call Trace:
[ 93.276366] __i2c_transfer+0x121/0x520
[ 93.276379] i2c_transfer+0x4c/0x100
[ 93.276392] i2c_acpi_space_handler+0x219/0x510
[ 93.276408] ? up+0x40/0x60
[ 93.276419] ? i2c_acpi_notify+0x130/0x130
[ 93.276433] acpi_ev_address_space_dispatch+0x1e1/0x252
...
So since on BYT and CHT platforms we want ACPI I2c OPRegion accesses
to work until the suspend_noirq phase, we need the controller to be
runtime-resumed during the suspend phase if it is runtime-suspended
suspended at that time. This means that we must not set the
DPM_FLAG_SMART_SUSPEND on these platforms.
On BYT and CHT we already have a special ACCESS_NO_IRQ_SUSPEND flag
to make sure the controller stays functional until the suspend_noirq
phase. This commit makes the driver not set the DPM_FLAG_SMART_SUSPEND
flag when that flag is set.
Cc: stable@vger.kernel.org
Fixes: b30f2f65568f ("i2c: designware: Set IRQF_NO_SUSPEND flag for all BYT and CHT controllers")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2020-04-08 02:11:16 +08:00
|
|
|
} else {
|
|
|
|
|
dev_pm_set_driver_flags(&pdev->dev,
|
|
|
|
|
DPM_FLAG_SMART_PREPARE |
|
|
|
|
|
DPM_FLAG_SMART_SUSPEND |
|
2020-04-19 00:53:20 +08:00
|
|
|
DPM_FLAG_MAY_SKIP_RESUME);
|
i2c: designware: platdrv: Remove DPM_FLAG_SMART_SUSPEND flag on BYT and CHT
We already set DPM_FLAG_SMART_PREPARE, so we completely skip all
callbacks (other then prepare) where possible, quoting from
dw_i2c_plat_prepare():
/*
* If the ACPI companion device object is present for this device, it
* may be accessed during suspend and resume of other devices via I2C
* operation regions, so tell the PM core and middle layers to avoid
* skipping system suspend/resume callbacks for it in that case.
*/
return !has_acpi_companion(dev);
Also setting the DPM_FLAG_SMART_SUSPEND will cause acpi_subsys_suspend()
to leave the controller runtime-suspended even if dw_i2c_plat_prepare()
returned 0.
Leaving the controller runtime-suspended normally, when the I2C controller
is suspended during the suspend_late phase, is not an issue because
the pm_runtime_get_sync() done by i2c_dw_xfer() will (runtime-)resume it.
But for dw I2C controllers on Bay- and Cherry-Trail devices acpi_lpss.c
leaves the controller alive until the suspend_noirq phase, because it may
be used by the _PS3 ACPI methods of PCI devices and PCI devices are left
powered on until the suspend_noirq phase.
Between the suspend_late and resume_early phases runtime-pm is disabled.
So for any ACPI I2C OPRegion accesses done after the suspend_late phase,
the pm_runtime_get_sync() done by i2c_dw_xfer() is a no-op and the
controller is left runtime-suspended.
i2c_dw_xfer() has a check to catch this condition (rather then waiting
for the I2C transfer to timeout because the controller is suspended).
acpi_subsys_suspend() leaving the controller runtime-suspended in
combination with an ACPI I2C OPRegion access done after the suspend_late
phase triggers this check, leading to the following error being logged
on a Bay Trail based Lenovo Thinkpad 8 tablet:
[ 93.275882] i2c_designware 80860F41:00: Transfer while suspended
[ 93.275993] WARNING: CPU: 0 PID: 412 at drivers/i2c/busses/i2c-designware-master.c:429 i2c_dw_xfer+0x239/0x280
...
[ 93.276252] Workqueue: kacpi_notify acpi_os_execute_deferred
[ 93.276267] RIP: 0010:i2c_dw_xfer+0x239/0x280
...
[ 93.276340] Call Trace:
[ 93.276366] __i2c_transfer+0x121/0x520
[ 93.276379] i2c_transfer+0x4c/0x100
[ 93.276392] i2c_acpi_space_handler+0x219/0x510
[ 93.276408] ? up+0x40/0x60
[ 93.276419] ? i2c_acpi_notify+0x130/0x130
[ 93.276433] acpi_ev_address_space_dispatch+0x1e1/0x252
...
So since on BYT and CHT platforms we want ACPI I2c OPRegion accesses
to work until the suspend_noirq phase, we need the controller to be
runtime-resumed during the suspend phase if it is runtime-suspended
suspended at that time. This means that we must not set the
DPM_FLAG_SMART_SUSPEND on these platforms.
On BYT and CHT we already have a special ACCESS_NO_IRQ_SUSPEND flag
to make sure the controller stays functional until the suspend_noirq
phase. This commit makes the driver not set the DPM_FLAG_SMART_SUSPEND
flag when that flag is set.
Cc: stable@vger.kernel.org
Fixes: b30f2f65568f ("i2c: designware: Set IRQF_NO_SUSPEND flag for all BYT and CHT controllers")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2020-04-08 02:11:16 +08:00
|
|
|
}
|
2018-01-03 08:35:54 +08:00
|
|
|
|
2017-09-26 05:10:06 +08:00
|
|
|
/* The code below assumes runtime PM to be disabled. */
|
|
|
|
|
WARN_ON(pm_runtime_enabled(&pdev->dev));
|
|
|
|
|
|
|
|
|
|
pm_runtime_set_autosuspend_delay(&pdev->dev, 1000);
|
|
|
|
|
pm_runtime_use_autosuspend(&pdev->dev);
|
|
|
|
|
pm_runtime_set_active(&pdev->dev);
|
|
|
|
|
|
2018-09-06 03:51:31 +08:00
|
|
|
if (dev->shared_with_punit)
|
2017-09-26 05:10:06 +08:00
|
|
|
pm_runtime_get_noresume(&pdev->dev);
|
|
|
|
|
|
|
|
|
|
pm_runtime_enable(&pdev->dev);
|
2013-01-17 18:31:06 +08:00
|
|
|
|
2020-04-25 21:44:47 +08:00
|
|
|
ret = i2c_dw_probe(dev);
|
2017-06-14 18:43:21 +08:00
|
|
|
if (ret)
|
2016-12-27 22:22:40 +08:00
|
|
|
goto exit_probe;
|
2015-10-09 17:39:24 +08:00
|
|
|
|
2017-06-14 18:43:21 +08:00
|
|
|
return ret;
|
2016-12-27 22:22:40 +08:00
|
|
|
|
|
|
|
|
exit_probe:
|
2017-09-26 05:10:06 +08:00
|
|
|
dw_i2c_plat_pm_cleanup(dev);
|
2016-12-27 22:22:40 +08:00
|
|
|
exit_reset:
|
2019-08-19 18:31:30 +08:00
|
|
|
reset_control_assert(dev->rst);
|
2017-06-14 18:43:21 +08:00
|
|
|
return ret;
|
2011-10-29 17:57:23 +08:00
|
|
|
}
|
|
|
|
|
|
2015-08-31 22:31:32 +08:00
|
|
|
static int dw_i2c_plat_remove(struct platform_device *pdev)
|
2011-10-29 17:57:23 +08:00
|
|
|
{
|
|
|
|
|
struct dw_i2c_dev *dev = platform_get_drvdata(pdev);
|
|
|
|
|
|
2013-01-17 18:31:06 +08:00
|
|
|
pm_runtime_get_sync(&pdev->dev);
|
|
|
|
|
|
2011-10-29 17:57:23 +08:00
|
|
|
i2c_del_adapter(&dev->adapter);
|
|
|
|
|
|
2017-06-14 18:43:23 +08:00
|
|
|
dev->disable(dev);
|
2011-10-29 17:57:23 +08:00
|
|
|
|
2015-06-17 17:08:38 +08:00
|
|
|
pm_runtime_dont_use_autosuspend(&pdev->dev);
|
|
|
|
|
pm_runtime_put_sync(&pdev->dev);
|
2017-09-26 05:10:06 +08:00
|
|
|
dw_i2c_plat_pm_cleanup(dev);
|
|
|
|
|
|
2019-08-19 18:31:30 +08:00
|
|
|
reset_control_assert(dev->rst);
|
2013-01-17 18:31:06 +08:00
|
|
|
|
2011-10-29 17:57:23 +08:00
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2015-05-20 22:33:13 +08:00
|
|
|
#ifdef CONFIG_PM_SLEEP
|
2015-08-31 22:31:32 +08:00
|
|
|
static int dw_i2c_plat_prepare(struct device *dev)
|
2015-05-20 22:33:13 +08:00
|
|
|
{
|
2018-01-03 08:35:54 +08:00
|
|
|
/*
|
|
|
|
|
* If the ACPI companion device object is present for this device, it
|
|
|
|
|
* may be accessed during suspend and resume of other devices via I2C
|
|
|
|
|
* operation regions, so tell the PM core and middle layers to avoid
|
|
|
|
|
* skipping system suspend/resume callbacks for it in that case.
|
|
|
|
|
*/
|
|
|
|
|
return !has_acpi_companion(dev);
|
2015-05-20 22:33:13 +08:00
|
|
|
}
|
|
|
|
|
|
2015-08-31 22:31:32 +08:00
|
|
|
static void dw_i2c_plat_complete(struct device *dev)
|
2015-05-20 22:33:13 +08:00
|
|
|
{
|
PM: i2c-designware-platdrv: Optimize power management
Optimize the power management in i2c-designware-platdrv by making it
set the DPM_FLAG_SMART_SUSPEND and DPM_FLAG_LEAVE_SUSPENDED which
allows some code to be dropped from its PM callbacks.
First, setting DPM_FLAG_SMART_SUSPEND causes the intel-lpss driver
to avoid resuming i2c-designware-platdrv devices in its ->prepare
callback, so they can stay in runtime suspend after that point even
if the direct-complete feature is not used for them.
It also causes the ACPI PM domain and the PM core to avoid invoking
"late" and "noirq" suspend callbacks for these devices if they are
in runtime suspend at the beginning of the "late" phase of device
suspend during system suspend. That guarantees dw_i2c_plat_suspend()
to be called for a device only if it is not in runtime suspend.
Moreover, it causes the device's runtime PM status to be set to
"active" after calling dw_i2c_plat_resume() for it, so the
driver doesn't need internal flags to avoid invoking either
dw_i2c_plat_suspend() or dw_i2c_plat_resume() twice in a row.
Second, setting DPM_FLAG_LEAVE_SUSPENDED enables the optimization
allowing the device to stay suspended after system resume under
suitable conditions, so again the driver doesn't need to take
care of that by itself.
Accordingly, the internal "suspended" and "skip_resume" flags
used by the driver are not necessary any more, so drop them and
simplify the driver's PM callbacks.
Additionally, notice that dw_i2c_plat_complete() only needs to
schedule runtime PM resume for the device if platform firmware
has been involved in resuming the system, so make it call
pm_resume_via_firmware() to check that. Also make it check the
runtime PM status of the device instead of its direct_complete
flag which also works if the device remained suspended due to
the DPM_FLAG_LEAVE_SUSPENDED driver flag.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
2018-01-03 08:37:34 +08:00
|
|
|
/*
|
|
|
|
|
* The device can only be in runtime suspend at this point if it has not
|
|
|
|
|
* been resumed throughout the ending system suspend/resume cycle, so if
|
|
|
|
|
* the platform firmware might mess up with it, request the runtime PM
|
|
|
|
|
* framework to resume it.
|
|
|
|
|
*/
|
|
|
|
|
if (pm_runtime_suspended(dev) && pm_resume_via_firmware())
|
2015-05-20 22:33:13 +08:00
|
|
|
pm_request_resume(dev);
|
|
|
|
|
}
|
|
|
|
|
#else
|
2015-10-21 15:09:17 +08:00
|
|
|
#define dw_i2c_plat_prepare NULL
|
|
|
|
|
#define dw_i2c_plat_complete NULL
|
2015-05-20 22:33:13 +08:00
|
|
|
#endif
|
|
|
|
|
|
2014-05-15 22:37:23 +08:00
|
|
|
#ifdef CONFIG_PM
|
PM: i2c-designware-platdrv: Suspend/resume at the late/early stages
As reported by Rajat Jain, there are problems when ACPI operation
region handlers or similar, called at the ->resume_early() time, for
I2C client devices try to access an I2C controller that has already
been suspended at that point. To avoid that, move the suspend/resume
of i2c-designware-platdrv to the late/early stages, respectively.
While at it, avoid resuming the device from runtime suspend in the
driver's ->suspend callback which isn't particularly nice. [A better
approach would be to make the driver track the PM state of the device
so that it doesn't need to resume it in ->suspend, so implement it.]
First, drop dw_i2c_plat_suspend() added by commit a23318feeff6 (i2c:
designware: Fix system suspend) and rename dw_i2c_plat_runtime_suspend()
back to dw_i2c_plat_suspend().
Second, point the driver's ->late_suspend and ->early_resume
callbacks, rather than its ->suspend and ->resume callbacks,
to dw_i2c_plat_suspend() and dw_i2c_plat_resume(), respectively,
so that they are not executed in parallel with each other, for
example if runtime resume of the device takes place during system
suspend.
Finally, add "suspended" and "skip_resume" flags to struct dw_i2c_dev
and make dw_i2c_plat_suspend() and dw_i2c_plat_resume() use them to
avoid suspending or resuming the device twice in a row and to avoid
resuming a previously runtime-suspended device during system resume.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Johannes Stezenbach <js@sig21.net>
Tested-by: Rajat Jain <rajatja@google.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2017-09-25 07:30:51 +08:00
|
|
|
static int dw_i2c_plat_suspend(struct device *dev)
|
2012-02-24 19:31:15 +08:00
|
|
|
{
|
2017-07-28 00:16:24 +08:00
|
|
|
struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
|
2012-02-24 19:31:15 +08:00
|
|
|
|
2019-02-22 21:08:40 +08:00
|
|
|
i_dev->suspended = true;
|
|
|
|
|
|
2018-09-06 03:51:31 +08:00
|
|
|
if (i_dev->shared_with_punit)
|
i2c: designware: Re-init controllers with pm_disabled set on resume
On Bay Trail and Cherry Trail devices we set the pm_disabled flag for I2C
busses which the OS shares with the PUNIT as these need special handling.
Until now we called dev_pm_syscore_device(dev, true) for I2C controllers
with this flag set to keep these I2C controllers always on.
After commit 12864ff8545f ("ACPI / LPSS: Avoid PM quirks on suspend and
resume from hibernation"), this no longer works. This commit modifies
lpss_iosf_exit_d3_state() to only run if lpss_iosf_enter_d3_state() has ran
before it, so that it does not run on a resume from hibernate (or from S3).
On these systems the conditions for lpss_iosf_enter_d3_state() to run
never become true, so lpss_iosf_exit_d3_state() never gets called and
the 2 LPSS DMA controllers never get forced into D0 mode, instead they
are left in their default automatic power-on when needed mode.
The not forcing of D0 mode for the DMA controllers enables these systems
to properly enter S0ix modes, which is a good thing.
But after entering S0ix modes the I2C controller connected to the PMIC
no longer works, leading to e.g. broken battery monitoring.
The _PS3 method for this I2C controller looks like this:
Method (_PS3, 0, NotSerialized) // _PS3: Power State 3
{
If ((((PMID == 0x04) || (PMID == 0x05)) || (PMID == 0x06)))
{
Return (Zero)
}
PSAT |= 0x03
Local0 = PSAT /* \_SB_.I2C5.PSAT */
}
Where PMID = 0x05, so we enter the Return (Zero) path on these systems.
So even if we were to not call dev_pm_syscore_device(dev, true) the
I2C controller will be left in D0 rather then be switched to D3.
Yet on other Bay and Cherry Trail devices S0ix is not entered unless *all*
I2C controllers are in D3 mode. This combined with the I2C controller no
longer working now that we reach S0ix states on these systems leads to me
believing that the PUNIT itself puts the I2C controller in D3 when all
other conditions for entering S0ix states are true.
Since now the I2C controller is put in D3 over a suspend/resume we must
re-initialize it afterwards and that does indeed fix it no longer working.
This commit implements this fix by:
1) Making the suspend_late callback a no-op if pm_disabled is set and
making the resume_early callback skip the clock re-enable (since it now was
not disabled) while still doing the necessary I2C controller re-init.
2) Removing the dev_pm_syscore_device(dev, true) call, so that the suspend
and resume callbacks are actually called. Normally this would cause the
ACPI pm code to call _PS3 putting the I2C controller in D3, wreaking havoc
since it is shared with the PUNIT, but in this special case the _PS3 method
is a no-op so we can safely allow a "fake" suspend / resume.
Fixes: 12864ff8545f ("ACPI / LPSS: Avoid PM quirks on suspend and resume ...")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=200861
Cc: 4.15+ <stable@vger.kernel.org> # 4.15+
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2018-08-29 21:06:31 +08:00
|
|
|
return 0;
|
|
|
|
|
|
2017-06-14 18:43:23 +08:00
|
|
|
i_dev->disable(i_dev);
|
2017-11-02 10:40:26 +08:00
|
|
|
i2c_dw_prepare_clk(i_dev, false);
|
2012-02-24 19:31:15 +08:00
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2015-08-31 22:31:32 +08:00
|
|
|
static int dw_i2c_plat_resume(struct device *dev)
|
2012-02-24 19:31:15 +08:00
|
|
|
{
|
2017-07-28 00:16:24 +08:00
|
|
|
struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
|
2012-02-24 19:31:15 +08:00
|
|
|
|
2018-09-06 03:51:31 +08:00
|
|
|
if (!i_dev->shared_with_punit)
|
i2c: designware: Re-init controllers with pm_disabled set on resume
On Bay Trail and Cherry Trail devices we set the pm_disabled flag for I2C
busses which the OS shares with the PUNIT as these need special handling.
Until now we called dev_pm_syscore_device(dev, true) for I2C controllers
with this flag set to keep these I2C controllers always on.
After commit 12864ff8545f ("ACPI / LPSS: Avoid PM quirks on suspend and
resume from hibernation"), this no longer works. This commit modifies
lpss_iosf_exit_d3_state() to only run if lpss_iosf_enter_d3_state() has ran
before it, so that it does not run on a resume from hibernate (or from S3).
On these systems the conditions for lpss_iosf_enter_d3_state() to run
never become true, so lpss_iosf_exit_d3_state() never gets called and
the 2 LPSS DMA controllers never get forced into D0 mode, instead they
are left in their default automatic power-on when needed mode.
The not forcing of D0 mode for the DMA controllers enables these systems
to properly enter S0ix modes, which is a good thing.
But after entering S0ix modes the I2C controller connected to the PMIC
no longer works, leading to e.g. broken battery monitoring.
The _PS3 method for this I2C controller looks like this:
Method (_PS3, 0, NotSerialized) // _PS3: Power State 3
{
If ((((PMID == 0x04) || (PMID == 0x05)) || (PMID == 0x06)))
{
Return (Zero)
}
PSAT |= 0x03
Local0 = PSAT /* \_SB_.I2C5.PSAT */
}
Where PMID = 0x05, so we enter the Return (Zero) path on these systems.
So even if we were to not call dev_pm_syscore_device(dev, true) the
I2C controller will be left in D0 rather then be switched to D3.
Yet on other Bay and Cherry Trail devices S0ix is not entered unless *all*
I2C controllers are in D3 mode. This combined with the I2C controller no
longer working now that we reach S0ix states on these systems leads to me
believing that the PUNIT itself puts the I2C controller in D3 when all
other conditions for entering S0ix states are true.
Since now the I2C controller is put in D3 over a suspend/resume we must
re-initialize it afterwards and that does indeed fix it no longer working.
This commit implements this fix by:
1) Making the suspend_late callback a no-op if pm_disabled is set and
making the resume_early callback skip the clock re-enable (since it now was
not disabled) while still doing the necessary I2C controller re-init.
2) Removing the dev_pm_syscore_device(dev, true) call, so that the suspend
and resume callbacks are actually called. Normally this would cause the
ACPI pm code to call _PS3 putting the I2C controller in D3, wreaking havoc
since it is shared with the PUNIT, but in this special case the _PS3 method
is a no-op so we can safely allow a "fake" suspend / resume.
Fixes: 12864ff8545f ("ACPI / LPSS: Avoid PM quirks on suspend and resume ...")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=200861
Cc: 4.15+ <stable@vger.kernel.org> # 4.15+
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2018-08-29 21:06:31 +08:00
|
|
|
i2c_dw_prepare_clk(i_dev, true);
|
|
|
|
|
|
2017-06-14 18:43:23 +08:00
|
|
|
i_dev->init(i_dev);
|
2019-02-22 21:08:40 +08:00
|
|
|
i_dev->suspended = false;
|
2012-02-24 19:31:15 +08:00
|
|
|
|
PM: i2c-designware-platdrv: Suspend/resume at the late/early stages
As reported by Rajat Jain, there are problems when ACPI operation
region handlers or similar, called at the ->resume_early() time, for
I2C client devices try to access an I2C controller that has already
been suspended at that point. To avoid that, move the suspend/resume
of i2c-designware-platdrv to the late/early stages, respectively.
While at it, avoid resuming the device from runtime suspend in the
driver's ->suspend callback which isn't particularly nice. [A better
approach would be to make the driver track the PM state of the device
so that it doesn't need to resume it in ->suspend, so implement it.]
First, drop dw_i2c_plat_suspend() added by commit a23318feeff6 (i2c:
designware: Fix system suspend) and rename dw_i2c_plat_runtime_suspend()
back to dw_i2c_plat_suspend().
Second, point the driver's ->late_suspend and ->early_resume
callbacks, rather than its ->suspend and ->resume callbacks,
to dw_i2c_plat_suspend() and dw_i2c_plat_resume(), respectively,
so that they are not executed in parallel with each other, for
example if runtime resume of the device takes place during system
suspend.
Finally, add "suspended" and "skip_resume" flags to struct dw_i2c_dev
and make dw_i2c_plat_suspend() and dw_i2c_plat_resume() use them to
avoid suspending or resuming the device twice in a row and to avoid
resuming a previously runtime-suspended device during system resume.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Johannes Stezenbach <js@sig21.net>
Tested-by: Rajat Jain <rajatja@google.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2017-09-25 07:30:51 +08:00
|
|
|
return 0;
|
i2c: designware: Fix system suspend
The commit 8503ff166504 ("i2c: designware: Avoid unnecessary resuming
during system suspend"), may suggest to the PM core to try out the so
called direct_complete path for system sleep. In this path, the PM core
treats a runtime suspended device as it's already in a proper low power
state for system sleep, which makes it skip calling the system sleep
callbacks for the device, except for the ->prepare() and the ->complete()
callbacks.
However, the PM core may unset the direct_complete flag for a parent
device, in case its child device are being system suspended before. In this
scenario, the PM core invokes the system sleep callbacks, no matter if the
device is runtime suspended or not.
Particularly in cases of an existing i2c slave device, the above path is
triggered, which breaks the assumption that the i2c device is always
runtime resumed whenever the dw_i2c_plat_suspend() is being called.
More precisely, dw_i2c_plat_suspend() calls clk_core_disable() and
clk_core_unprepare(), for an already disabled/unprepared clock, leading to
a splat in the log about clocks calls being wrongly balanced and breaking
system sleep.
To still allow the direct_complete path in cases when it's possible, but
also to keep the fix simple, let's runtime resume the i2c device in the
->suspend() callback, before continuing to put the device into low power
state.
Note, in cases when the i2c device is attached to the ACPI PM domain, this
problem doesn't occur, because ACPI's ->suspend() callback, assigned to
acpi_subsys_suspend(), already calls pm_runtime_resume() for the device.
It should also be noted that this change does not fix commit 8503ff166504
("i2c: designware: Avoid unnecessary resuming during system suspend").
Because for the non-ACPI case, the system sleep support was already broken
prior that point.
Cc: <stable@vger.kernel.org> # v4.4+
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: John Stultz <john.stultz@linaro.org>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2017-08-09 21:28:22 +08:00
|
|
|
}
|
|
|
|
|
|
2015-05-20 22:33:13 +08:00
|
|
|
static const struct dev_pm_ops dw_i2c_dev_pm_ops = {
|
2015-08-31 22:31:32 +08:00
|
|
|
.prepare = dw_i2c_plat_prepare,
|
|
|
|
|
.complete = dw_i2c_plat_complete,
|
PM: i2c-designware-platdrv: Suspend/resume at the late/early stages
As reported by Rajat Jain, there are problems when ACPI operation
region handlers or similar, called at the ->resume_early() time, for
I2C client devices try to access an I2C controller that has already
been suspended at that point. To avoid that, move the suspend/resume
of i2c-designware-platdrv to the late/early stages, respectively.
While at it, avoid resuming the device from runtime suspend in the
driver's ->suspend callback which isn't particularly nice. [A better
approach would be to make the driver track the PM state of the device
so that it doesn't need to resume it in ->suspend, so implement it.]
First, drop dw_i2c_plat_suspend() added by commit a23318feeff6 (i2c:
designware: Fix system suspend) and rename dw_i2c_plat_runtime_suspend()
back to dw_i2c_plat_suspend().
Second, point the driver's ->late_suspend and ->early_resume
callbacks, rather than its ->suspend and ->resume callbacks,
to dw_i2c_plat_suspend() and dw_i2c_plat_resume(), respectively,
so that they are not executed in parallel with each other, for
example if runtime resume of the device takes place during system
suspend.
Finally, add "suspended" and "skip_resume" flags to struct dw_i2c_dev
and make dw_i2c_plat_suspend() and dw_i2c_plat_resume() use them to
avoid suspending or resuming the device twice in a row and to avoid
resuming a previously runtime-suspended device during system resume.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Johannes Stezenbach <js@sig21.net>
Tested-by: Rajat Jain <rajatja@google.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2017-09-25 07:30:51 +08:00
|
|
|
SET_LATE_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume)
|
|
|
|
|
SET_RUNTIME_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume, NULL)
|
2015-05-20 22:33:13 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
#define DW_I2C_DEV_PMOPS (&dw_i2c_dev_pm_ops)
|
|
|
|
|
#else
|
|
|
|
|
#define DW_I2C_DEV_PMOPS NULL
|
|
|
|
|
#endif
|
2014-05-15 22:37:23 +08:00
|
|
|
|
2017-06-14 18:43:21 +08:00
|
|
|
/* Work with hotplug and coldplug */
|
2011-10-29 17:57:23 +08:00
|
|
|
MODULE_ALIAS("platform:i2c_designware");
|
|
|
|
|
|
|
|
|
|
static struct platform_driver dw_i2c_driver = {
|
2015-08-31 22:31:32 +08:00
|
|
|
.probe = dw_i2c_plat_probe,
|
|
|
|
|
.remove = dw_i2c_plat_remove,
|
2011-10-29 17:57:23 +08:00
|
|
|
.driver = {
|
|
|
|
|
.name = "i2c_designware",
|
2011-11-09 04:43:47 +08:00
|
|
|
.of_match_table = of_match_ptr(dw_i2c_of_match),
|
2013-01-17 18:31:07 +08:00
|
|
|
.acpi_match_table = ACPI_PTR(dw_i2c_acpi_match),
|
2015-05-20 22:33:13 +08:00
|
|
|
.pm = DW_I2C_DEV_PMOPS,
|
2011-10-29 17:57:23 +08:00
|
|
|
},
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static int __init dw_i2c_init_driver(void)
|
|
|
|
|
{
|
2013-10-09 04:35:33 +08:00
|
|
|
return platform_driver_register(&dw_i2c_driver);
|
2011-10-29 17:57:23 +08:00
|
|
|
}
|
2012-02-29 14:57:46 +08:00
|
|
|
subsys_initcall(dw_i2c_init_driver);
|
2011-10-29 17:57:23 +08:00
|
|
|
|
|
|
|
|
static void __exit dw_i2c_exit_driver(void)
|
|
|
|
|
{
|
|
|
|
|
platform_driver_unregister(&dw_i2c_driver);
|
|
|
|
|
}
|
|
|
|
|
module_exit(dw_i2c_exit_driver);
|
|
|
|
|
|
|
|
|
|
MODULE_AUTHOR("Baruch Siach <baruch@tkos.co.il>");
|
|
|
|
|
MODULE_DESCRIPTION("Synopsys DesignWare I2C bus adapter");
|
|
|
|
|
MODULE_LICENSE("GPL");
|
