2019-10-05 00:05:25 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
/*
|
|
|
|
* Sony IMX290 CMOS Image Sensor Driver
|
|
|
|
*
|
|
|
|
* Copyright (C) 2019 FRAMOS GmbH.
|
|
|
|
*
|
|
|
|
* Copyright (C) 2019 Linaro Ltd.
|
|
|
|
* Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/clk.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/gpio/consumer.h>
|
|
|
|
#include <linux/i2c.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/pm_runtime.h>
|
|
|
|
#include <linux/regmap.h>
|
|
|
|
#include <linux/regulator/consumer.h>
|
|
|
|
#include <media/media-entity.h>
|
|
|
|
#include <media/v4l2-ctrls.h>
|
|
|
|
#include <media/v4l2-device.h>
|
|
|
|
#include <media/v4l2-fwnode.h>
|
|
|
|
#include <media/v4l2-subdev.h>
|
|
|
|
|
|
|
|
#define IMX290_STANDBY 0x3000
|
|
|
|
#define IMX290_REGHOLD 0x3001
|
|
|
|
#define IMX290_XMSTA 0x3002
|
2020-06-12 21:53:49 +08:00
|
|
|
#define IMX290_FR_FDG_SEL 0x3009
|
2020-06-12 21:53:51 +08:00
|
|
|
#define IMX290_BLKLEVEL_LOW 0x300a
|
|
|
|
#define IMX290_BLKLEVEL_HIGH 0x300b
|
2019-10-05 00:05:25 +08:00
|
|
|
#define IMX290_GAIN 0x3014
|
2020-06-12 21:53:49 +08:00
|
|
|
#define IMX290_HMAX_LOW 0x301c
|
|
|
|
#define IMX290_HMAX_HIGH 0x301d
|
2020-06-12 21:53:51 +08:00
|
|
|
#define IMX290_PGCTRL 0x308c
|
2020-06-12 21:53:49 +08:00
|
|
|
#define IMX290_PHY_LANE_NUM 0x3407
|
|
|
|
#define IMX290_CSI_LANE_MODE 0x3443
|
2019-10-05 00:05:25 +08:00
|
|
|
|
2020-06-12 21:53:51 +08:00
|
|
|
#define IMX290_PGCTRL_REGEN BIT(0)
|
|
|
|
#define IMX290_PGCTRL_THRU BIT(1)
|
|
|
|
#define IMX290_PGCTRL_MODE(n) ((n) << 4)
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
static const char * const imx290_supply_name[] = {
|
|
|
|
"vdda",
|
|
|
|
"vddd",
|
|
|
|
"vdddo",
|
|
|
|
};
|
|
|
|
|
|
|
|
#define IMX290_NUM_SUPPLIES ARRAY_SIZE(imx290_supply_name)
|
|
|
|
|
|
|
|
struct imx290_regval {
|
|
|
|
u16 reg;
|
|
|
|
u8 val;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imx290_mode {
|
|
|
|
u32 width;
|
|
|
|
u32 height;
|
2020-06-12 21:53:49 +08:00
|
|
|
u32 hmax;
|
2020-06-12 21:53:50 +08:00
|
|
|
u8 link_freq_index;
|
2019-10-05 00:05:25 +08:00
|
|
|
|
|
|
|
const struct imx290_regval *data;
|
|
|
|
u32 data_size;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imx290 {
|
|
|
|
struct device *dev;
|
|
|
|
struct clk *xclk;
|
|
|
|
struct regmap *regmap;
|
2020-06-12 21:53:49 +08:00
|
|
|
u8 nlanes;
|
2020-06-12 21:53:52 +08:00
|
|
|
u8 bpp;
|
2019-10-05 00:05:25 +08:00
|
|
|
|
|
|
|
struct v4l2_subdev sd;
|
|
|
|
struct media_pad pad;
|
|
|
|
struct v4l2_mbus_framefmt current_format;
|
|
|
|
const struct imx290_mode *current_mode;
|
|
|
|
|
|
|
|
struct regulator_bulk_data supplies[IMX290_NUM_SUPPLIES];
|
|
|
|
struct gpio_desc *rst_gpio;
|
|
|
|
|
|
|
|
struct v4l2_ctrl_handler ctrls;
|
|
|
|
struct v4l2_ctrl *link_freq;
|
|
|
|
struct v4l2_ctrl *pixel_rate;
|
|
|
|
|
|
|
|
struct mutex lock;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct imx290_pixfmt {
|
|
|
|
u32 code;
|
2020-06-12 21:53:52 +08:00
|
|
|
u8 bpp;
|
2019-10-05 00:05:25 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct imx290_pixfmt imx290_formats[] = {
|
2020-06-12 21:53:52 +08:00
|
|
|
{ MEDIA_BUS_FMT_SRGGB10_1X10, 10 },
|
|
|
|
{ MEDIA_BUS_FMT_SRGGB12_1X12, 12 },
|
2019-10-05 00:05:25 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct regmap_config imx290_regmap_config = {
|
|
|
|
.reg_bits = 16,
|
|
|
|
.val_bits = 8,
|
|
|
|
.cache_type = REGCACHE_RBTREE,
|
|
|
|
};
|
|
|
|
|
2020-06-12 21:53:51 +08:00
|
|
|
static const char * const imx290_test_pattern_menu[] = {
|
|
|
|
"Disabled",
|
|
|
|
"Sequence Pattern 1",
|
|
|
|
"Horizontal Color-bar Chart",
|
|
|
|
"Vertical Color-bar Chart",
|
|
|
|
"Sequence Pattern 2",
|
|
|
|
"Gradation Pattern 1",
|
|
|
|
"Gradation Pattern 2",
|
|
|
|
"000/555h Toggle Pattern",
|
|
|
|
};
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
static const struct imx290_regval imx290_global_init_settings[] = {
|
|
|
|
{ 0x3007, 0x00 },
|
|
|
|
{ 0x3018, 0x65 },
|
|
|
|
{ 0x3019, 0x04 },
|
|
|
|
{ 0x301a, 0x00 },
|
|
|
|
{ 0x3444, 0x20 },
|
|
|
|
{ 0x3445, 0x25 },
|
|
|
|
{ 0x303a, 0x0c },
|
|
|
|
{ 0x3040, 0x00 },
|
|
|
|
{ 0x3041, 0x00 },
|
|
|
|
{ 0x303c, 0x00 },
|
|
|
|
{ 0x303d, 0x00 },
|
|
|
|
{ 0x3042, 0x9c },
|
|
|
|
{ 0x3043, 0x07 },
|
|
|
|
{ 0x303e, 0x49 },
|
|
|
|
{ 0x303f, 0x04 },
|
|
|
|
{ 0x304b, 0x0a },
|
|
|
|
{ 0x300f, 0x00 },
|
|
|
|
{ 0x3010, 0x21 },
|
|
|
|
{ 0x3012, 0x64 },
|
|
|
|
{ 0x3016, 0x09 },
|
|
|
|
{ 0x3070, 0x02 },
|
|
|
|
{ 0x3071, 0x11 },
|
|
|
|
{ 0x309b, 0x10 },
|
|
|
|
{ 0x309c, 0x22 },
|
|
|
|
{ 0x30a2, 0x02 },
|
|
|
|
{ 0x30a6, 0x20 },
|
|
|
|
{ 0x30a8, 0x20 },
|
|
|
|
{ 0x30aa, 0x20 },
|
|
|
|
{ 0x30ac, 0x20 },
|
|
|
|
{ 0x30b0, 0x43 },
|
|
|
|
{ 0x3119, 0x9e },
|
|
|
|
{ 0x311c, 0x1e },
|
|
|
|
{ 0x311e, 0x08 },
|
|
|
|
{ 0x3128, 0x05 },
|
|
|
|
{ 0x313d, 0x83 },
|
|
|
|
{ 0x3150, 0x03 },
|
|
|
|
{ 0x317e, 0x00 },
|
|
|
|
{ 0x32b8, 0x50 },
|
|
|
|
{ 0x32b9, 0x10 },
|
|
|
|
{ 0x32ba, 0x00 },
|
|
|
|
{ 0x32bb, 0x04 },
|
|
|
|
{ 0x32c8, 0x50 },
|
|
|
|
{ 0x32c9, 0x10 },
|
|
|
|
{ 0x32ca, 0x00 },
|
|
|
|
{ 0x32cb, 0x04 },
|
|
|
|
{ 0x332c, 0xd3 },
|
|
|
|
{ 0x332d, 0x10 },
|
|
|
|
{ 0x332e, 0x0d },
|
|
|
|
{ 0x3358, 0x06 },
|
|
|
|
{ 0x3359, 0xe1 },
|
|
|
|
{ 0x335a, 0x11 },
|
|
|
|
{ 0x3360, 0x1e },
|
|
|
|
{ 0x3361, 0x61 },
|
|
|
|
{ 0x3362, 0x10 },
|
|
|
|
{ 0x33b0, 0x50 },
|
|
|
|
{ 0x33b2, 0x1a },
|
|
|
|
{ 0x33b3, 0x04 },
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct imx290_regval imx290_1080p_settings[] = {
|
|
|
|
/* mode settings */
|
|
|
|
{ 0x3007, 0x00 },
|
|
|
|
{ 0x303a, 0x0c },
|
|
|
|
{ 0x3414, 0x0a },
|
|
|
|
{ 0x3472, 0x80 },
|
|
|
|
{ 0x3473, 0x07 },
|
|
|
|
{ 0x3418, 0x38 },
|
|
|
|
{ 0x3419, 0x04 },
|
|
|
|
{ 0x3012, 0x64 },
|
|
|
|
{ 0x3013, 0x00 },
|
|
|
|
{ 0x305c, 0x18 },
|
|
|
|
{ 0x305d, 0x03 },
|
|
|
|
{ 0x305e, 0x20 },
|
|
|
|
{ 0x305f, 0x01 },
|
|
|
|
{ 0x315e, 0x1a },
|
|
|
|
{ 0x3164, 0x1a },
|
|
|
|
{ 0x3480, 0x49 },
|
|
|
|
/* data rate settings */
|
|
|
|
{ 0x3405, 0x10 },
|
|
|
|
{ 0x3446, 0x57 },
|
|
|
|
{ 0x3447, 0x00 },
|
|
|
|
{ 0x3448, 0x37 },
|
|
|
|
{ 0x3449, 0x00 },
|
|
|
|
{ 0x344a, 0x1f },
|
|
|
|
{ 0x344b, 0x00 },
|
|
|
|
{ 0x344c, 0x1f },
|
|
|
|
{ 0x344d, 0x00 },
|
|
|
|
{ 0x344e, 0x1f },
|
|
|
|
{ 0x344f, 0x00 },
|
|
|
|
{ 0x3450, 0x77 },
|
|
|
|
{ 0x3451, 0x00 },
|
|
|
|
{ 0x3452, 0x1f },
|
|
|
|
{ 0x3453, 0x00 },
|
|
|
|
{ 0x3454, 0x17 },
|
|
|
|
{ 0x3455, 0x00 },
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct imx290_regval imx290_720p_settings[] = {
|
|
|
|
/* mode settings */
|
|
|
|
{ 0x3007, 0x10 },
|
|
|
|
{ 0x303a, 0x06 },
|
|
|
|
{ 0x3414, 0x04 },
|
|
|
|
{ 0x3472, 0x00 },
|
|
|
|
{ 0x3473, 0x05 },
|
|
|
|
{ 0x3418, 0xd0 },
|
|
|
|
{ 0x3419, 0x02 },
|
|
|
|
{ 0x3012, 0x64 },
|
|
|
|
{ 0x3013, 0x00 },
|
|
|
|
{ 0x305c, 0x20 },
|
|
|
|
{ 0x305d, 0x00 },
|
|
|
|
{ 0x305e, 0x20 },
|
|
|
|
{ 0x305f, 0x01 },
|
|
|
|
{ 0x315e, 0x1a },
|
|
|
|
{ 0x3164, 0x1a },
|
|
|
|
{ 0x3480, 0x49 },
|
|
|
|
/* data rate settings */
|
|
|
|
{ 0x3405, 0x10 },
|
|
|
|
{ 0x3446, 0x4f },
|
|
|
|
{ 0x3447, 0x00 },
|
|
|
|
{ 0x3448, 0x2f },
|
|
|
|
{ 0x3449, 0x00 },
|
|
|
|
{ 0x344a, 0x17 },
|
|
|
|
{ 0x344b, 0x00 },
|
|
|
|
{ 0x344c, 0x17 },
|
|
|
|
{ 0x344d, 0x00 },
|
|
|
|
{ 0x344e, 0x17 },
|
|
|
|
{ 0x344f, 0x00 },
|
|
|
|
{ 0x3450, 0x57 },
|
|
|
|
{ 0x3451, 0x00 },
|
|
|
|
{ 0x3452, 0x17 },
|
|
|
|
{ 0x3453, 0x00 },
|
|
|
|
{ 0x3454, 0x17 },
|
|
|
|
{ 0x3455, 0x00 },
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct imx290_regval imx290_10bit_settings[] = {
|
|
|
|
{ 0x3005, 0x00},
|
|
|
|
{ 0x3046, 0x00},
|
|
|
|
{ 0x3129, 0x1d},
|
|
|
|
{ 0x317c, 0x12},
|
|
|
|
{ 0x31ec, 0x37},
|
|
|
|
{ 0x3441, 0x0a},
|
|
|
|
{ 0x3442, 0x0a},
|
|
|
|
{ 0x300a, 0x3c},
|
|
|
|
{ 0x300b, 0x00},
|
|
|
|
};
|
|
|
|
|
2020-06-12 21:53:52 +08:00
|
|
|
static const struct imx290_regval imx290_12bit_settings[] = {
|
|
|
|
{ 0x3005, 0x01 },
|
|
|
|
{ 0x3046, 0x01 },
|
|
|
|
{ 0x3129, 0x00 },
|
|
|
|
{ 0x317c, 0x00 },
|
|
|
|
{ 0x31ec, 0x0e },
|
|
|
|
{ 0x3441, 0x0c },
|
|
|
|
{ 0x3442, 0x0c },
|
|
|
|
{ 0x300a, 0xf0 },
|
|
|
|
{ 0x300b, 0x00 },
|
|
|
|
};
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
/* supported link frequencies */
|
2020-06-12 21:53:50 +08:00
|
|
|
#define FREQ_INDEX_1080P 0
|
|
|
|
#define FREQ_INDEX_720P 1
|
|
|
|
static const s64 imx290_link_freq_2lanes[] = {
|
|
|
|
[FREQ_INDEX_1080P] = 445500000,
|
|
|
|
[FREQ_INDEX_720P] = 297000000,
|
|
|
|
};
|
|
|
|
static const s64 imx290_link_freq_4lanes[] = {
|
|
|
|
[FREQ_INDEX_1080P] = 222750000,
|
|
|
|
[FREQ_INDEX_720P] = 148500000,
|
2019-10-05 00:05:25 +08:00
|
|
|
};
|
|
|
|
|
2020-06-12 21:53:50 +08:00
|
|
|
/*
|
|
|
|
* In this function and in the similar ones below We rely on imx290_probe()
|
|
|
|
* to ensure that nlanes is either 2 or 4.
|
|
|
|
*/
|
|
|
|
static inline const s64 *imx290_link_freqs_ptr(const struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
if (imx290->nlanes == 2)
|
|
|
|
return imx290_link_freq_2lanes;
|
|
|
|
else
|
|
|
|
return imx290_link_freq_4lanes;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int imx290_link_freqs_num(const struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
if (imx290->nlanes == 2)
|
|
|
|
return ARRAY_SIZE(imx290_link_freq_2lanes);
|
|
|
|
else
|
|
|
|
return ARRAY_SIZE(imx290_link_freq_4lanes);
|
|
|
|
}
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
/* Mode configs */
|
2020-06-12 21:53:49 +08:00
|
|
|
static const struct imx290_mode imx290_modes_2lanes[] = {
|
2019-10-05 00:05:25 +08:00
|
|
|
{
|
|
|
|
.width = 1920,
|
|
|
|
.height = 1080,
|
2020-06-12 21:53:49 +08:00
|
|
|
.hmax = 0x1130,
|
2020-06-12 21:53:50 +08:00
|
|
|
.link_freq_index = FREQ_INDEX_1080P,
|
2019-10-05 00:05:25 +08:00
|
|
|
.data = imx290_1080p_settings,
|
|
|
|
.data_size = ARRAY_SIZE(imx290_1080p_settings),
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.width = 1280,
|
|
|
|
.height = 720,
|
2020-06-12 21:53:49 +08:00
|
|
|
.hmax = 0x19c8,
|
2020-06-12 21:53:50 +08:00
|
|
|
.link_freq_index = FREQ_INDEX_720P,
|
2019-10-05 00:05:25 +08:00
|
|
|
.data = imx290_720p_settings,
|
|
|
|
.data_size = ARRAY_SIZE(imx290_720p_settings),
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2020-06-12 21:53:49 +08:00
|
|
|
static const struct imx290_mode imx290_modes_4lanes[] = {
|
|
|
|
{
|
|
|
|
.width = 1920,
|
|
|
|
.height = 1080,
|
|
|
|
.hmax = 0x0898,
|
2020-06-12 21:53:50 +08:00
|
|
|
.link_freq_index = FREQ_INDEX_1080P,
|
2020-06-12 21:53:49 +08:00
|
|
|
.data = imx290_1080p_settings,
|
|
|
|
.data_size = ARRAY_SIZE(imx290_1080p_settings),
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.width = 1280,
|
|
|
|
.height = 720,
|
|
|
|
.hmax = 0x0ce4,
|
2020-06-12 21:53:50 +08:00
|
|
|
.link_freq_index = FREQ_INDEX_720P,
|
2020-06-12 21:53:49 +08:00
|
|
|
.data = imx290_720p_settings,
|
|
|
|
.data_size = ARRAY_SIZE(imx290_720p_settings),
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline const struct imx290_mode *imx290_modes_ptr(const struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
if (imx290->nlanes == 2)
|
|
|
|
return imx290_modes_2lanes;
|
|
|
|
else
|
|
|
|
return imx290_modes_4lanes;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int imx290_modes_num(const struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
if (imx290->nlanes == 2)
|
|
|
|
return ARRAY_SIZE(imx290_modes_2lanes);
|
|
|
|
else
|
|
|
|
return ARRAY_SIZE(imx290_modes_4lanes);
|
|
|
|
}
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
static inline struct imx290 *to_imx290(struct v4l2_subdev *_sd)
|
|
|
|
{
|
|
|
|
return container_of(_sd, struct imx290, sd);
|
|
|
|
}
|
|
|
|
|
2021-11-24 19:48:45 +08:00
|
|
|
static inline int __always_unused imx290_read_reg(struct imx290 *imx290, u16 addr, u8 *value)
|
2019-10-05 00:05:25 +08:00
|
|
|
{
|
|
|
|
unsigned int regval;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = regmap_read(imx290->regmap, addr, ®val);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "I2C read failed for addr: %x\n", addr);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
*value = regval & 0xff;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imx290_write_reg(struct imx290 *imx290, u16 addr, u8 value)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = regmap_write(imx290->regmap, addr, value);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "I2C write failed for addr: %x\n", addr);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imx290_set_register_array(struct imx290 *imx290,
|
|
|
|
const struct imx290_regval *settings,
|
|
|
|
unsigned int num_settings)
|
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
for (i = 0; i < num_settings; ++i, ++settings) {
|
|
|
|
ret = imx290_write_reg(imx290, settings->reg, settings->val);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:54 +08:00
|
|
|
/* Provide 10ms settle time */
|
2020-06-24 00:52:26 +08:00
|
|
|
usleep_range(10000, 11000);
|
2020-06-12 21:53:54 +08:00
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imx290_write_buffered_reg(struct imx290 *imx290, u16 address_low,
|
|
|
|
u8 nr_regs, u32 value)
|
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = imx290_write_reg(imx290, IMX290_REGHOLD, 0x01);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "Error setting hold register\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < nr_regs; i++) {
|
|
|
|
ret = imx290_write_reg(imx290, address_low + i,
|
|
|
|
(u8)(value >> (i * 8)));
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "Error writing buffered registers\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = imx290_write_reg(imx290, IMX290_REGHOLD, 0x00);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "Error setting hold register\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imx290_set_gain(struct imx290 *imx290, u32 value)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = imx290_write_buffered_reg(imx290, IMX290_GAIN, 1, value);
|
|
|
|
if (ret)
|
|
|
|
dev_err(imx290->dev, "Unable to write gain\n");
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Stop streaming */
|
|
|
|
static int imx290_stop_streaming(struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = imx290_write_reg(imx290, IMX290_STANDBY, 0x01);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
msleep(30);
|
|
|
|
|
|
|
|
return imx290_write_reg(imx290, IMX290_XMSTA, 0x01);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imx290_set_ctrl(struct v4l2_ctrl *ctrl)
|
|
|
|
{
|
|
|
|
struct imx290 *imx290 = container_of(ctrl->handler,
|
|
|
|
struct imx290, ctrls);
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
/* V4L2 controls values will be applied only when power is already up */
|
|
|
|
if (!pm_runtime_get_if_in_use(imx290->dev))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
switch (ctrl->id) {
|
|
|
|
case V4L2_CID_GAIN:
|
|
|
|
ret = imx290_set_gain(imx290, ctrl->val);
|
|
|
|
break;
|
2020-06-12 21:53:51 +08:00
|
|
|
case V4L2_CID_TEST_PATTERN:
|
|
|
|
if (ctrl->val) {
|
|
|
|
imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW, 0x00);
|
|
|
|
imx290_write_reg(imx290, IMX290_BLKLEVEL_HIGH, 0x00);
|
2020-06-24 00:52:26 +08:00
|
|
|
usleep_range(10000, 11000);
|
2020-06-12 21:53:51 +08:00
|
|
|
imx290_write_reg(imx290, IMX290_PGCTRL,
|
|
|
|
(u8)(IMX290_PGCTRL_REGEN |
|
|
|
|
IMX290_PGCTRL_THRU |
|
|
|
|
IMX290_PGCTRL_MODE(ctrl->val)));
|
|
|
|
} else {
|
|
|
|
imx290_write_reg(imx290, IMX290_PGCTRL, 0x00);
|
2020-06-24 00:52:26 +08:00
|
|
|
usleep_range(10000, 11000);
|
2020-06-12 21:53:52 +08:00
|
|
|
if (imx290->bpp == 10)
|
|
|
|
imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW,
|
|
|
|
0x3c);
|
|
|
|
else /* 12 bits per pixel */
|
|
|
|
imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW,
|
|
|
|
0xf0);
|
2020-06-12 21:53:51 +08:00
|
|
|
imx290_write_reg(imx290, IMX290_BLKLEVEL_HIGH, 0x00);
|
|
|
|
}
|
|
|
|
break;
|
2019-10-05 00:05:25 +08:00
|
|
|
default:
|
|
|
|
ret = -EINVAL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
pm_runtime_put(imx290->dev);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct v4l2_ctrl_ops imx290_ctrl_ops = {
|
|
|
|
.s_ctrl = imx290_set_ctrl,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int imx290_enum_mbus_code(struct v4l2_subdev *sd,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2019-10-05 00:05:25 +08:00
|
|
|
struct v4l2_subdev_mbus_code_enum *code)
|
|
|
|
{
|
|
|
|
if (code->index >= ARRAY_SIZE(imx290_formats))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
code->code = imx290_formats[code->index].code;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:53 +08:00
|
|
|
static int imx290_enum_frame_size(struct v4l2_subdev *sd,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2020-06-12 21:53:53 +08:00
|
|
|
struct v4l2_subdev_frame_size_enum *fse)
|
|
|
|
{
|
|
|
|
const struct imx290 *imx290 = to_imx290(sd);
|
|
|
|
const struct imx290_mode *imx290_modes = imx290_modes_ptr(imx290);
|
|
|
|
|
|
|
|
if ((fse->code != imx290_formats[0].code) &&
|
|
|
|
(fse->code != imx290_formats[1].code))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (fse->index >= imx290_modes_num(imx290))
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
fse->min_width = imx290_modes[fse->index].width;
|
|
|
|
fse->max_width = imx290_modes[fse->index].width;
|
|
|
|
fse->min_height = imx290_modes[fse->index].height;
|
|
|
|
fse->max_height = imx290_modes[fse->index].height;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
static int imx290_get_fmt(struct v4l2_subdev *sd,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2019-10-05 00:05:25 +08:00
|
|
|
struct v4l2_subdev_format *fmt)
|
|
|
|
{
|
|
|
|
struct imx290 *imx290 = to_imx290(sd);
|
|
|
|
struct v4l2_mbus_framefmt *framefmt;
|
|
|
|
|
|
|
|
mutex_lock(&imx290->lock);
|
|
|
|
|
|
|
|
if (fmt->which == V4L2_SUBDEV_FORMAT_TRY)
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
framefmt = v4l2_subdev_get_try_format(&imx290->sd, sd_state,
|
2019-10-05 00:05:25 +08:00
|
|
|
fmt->pad);
|
|
|
|
else
|
|
|
|
framefmt = &imx290->current_format;
|
|
|
|
|
|
|
|
fmt->format = *framefmt;
|
|
|
|
|
|
|
|
mutex_unlock(&imx290->lock);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:50 +08:00
|
|
|
static inline u8 imx290_get_link_freq_index(struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
return imx290->current_mode->link_freq_index;
|
|
|
|
}
|
|
|
|
|
|
|
|
static s64 imx290_get_link_freq(struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
u8 index = imx290_get_link_freq_index(imx290);
|
|
|
|
|
|
|
|
return *(imx290_link_freqs_ptr(imx290) + index);
|
|
|
|
}
|
|
|
|
|
|
|
|
static u64 imx290_calc_pixel_rate(struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
s64 link_freq = imx290_get_link_freq(imx290);
|
|
|
|
u8 nlanes = imx290->nlanes;
|
|
|
|
u64 pixel_rate;
|
|
|
|
|
|
|
|
/* pixel rate = link_freq * 2 * nr_of_lanes / bits_per_sample */
|
|
|
|
pixel_rate = link_freq * 2 * nlanes;
|
2020-06-12 21:53:52 +08:00
|
|
|
do_div(pixel_rate, imx290->bpp);
|
2020-06-12 21:53:50 +08:00
|
|
|
return pixel_rate;
|
|
|
|
}
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
static int imx290_set_fmt(struct v4l2_subdev *sd,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
|
|
|
struct v4l2_subdev_format *fmt)
|
2019-10-05 00:05:25 +08:00
|
|
|
{
|
|
|
|
struct imx290 *imx290 = to_imx290(sd);
|
|
|
|
const struct imx290_mode *mode;
|
|
|
|
struct v4l2_mbus_framefmt *format;
|
|
|
|
unsigned int i;
|
|
|
|
|
|
|
|
mutex_lock(&imx290->lock);
|
|
|
|
|
2020-06-12 21:53:49 +08:00
|
|
|
mode = v4l2_find_nearest_size(imx290_modes_ptr(imx290),
|
|
|
|
imx290_modes_num(imx290), width, height,
|
2019-10-05 00:05:25 +08:00
|
|
|
fmt->format.width, fmt->format.height);
|
|
|
|
|
|
|
|
fmt->format.width = mode->width;
|
|
|
|
fmt->format.height = mode->height;
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(imx290_formats); i++)
|
|
|
|
if (imx290_formats[i].code == fmt->format.code)
|
|
|
|
break;
|
|
|
|
|
|
|
|
if (i >= ARRAY_SIZE(imx290_formats))
|
|
|
|
i = 0;
|
|
|
|
|
|
|
|
fmt->format.code = imx290_formats[i].code;
|
|
|
|
fmt->format.field = V4L2_FIELD_NONE;
|
|
|
|
|
|
|
|
if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
format = v4l2_subdev_get_try_format(sd, sd_state, fmt->pad);
|
2019-10-05 00:05:25 +08:00
|
|
|
} else {
|
|
|
|
format = &imx290->current_format;
|
|
|
|
imx290->current_mode = mode;
|
2020-06-12 21:53:52 +08:00
|
|
|
imx290->bpp = imx290_formats[i].bpp;
|
2020-06-12 21:53:50 +08:00
|
|
|
|
|
|
|
if (imx290->link_freq)
|
|
|
|
__v4l2_ctrl_s_ctrl(imx290->link_freq,
|
|
|
|
imx290_get_link_freq_index(imx290));
|
|
|
|
if (imx290->pixel_rate)
|
|
|
|
__v4l2_ctrl_s_ctrl_int64(imx290->pixel_rate,
|
|
|
|
imx290_calc_pixel_rate(imx290));
|
2019-10-05 00:05:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
*format = fmt->format;
|
|
|
|
|
|
|
|
mutex_unlock(&imx290->lock);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imx290_entity_init_cfg(struct v4l2_subdev *subdev,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
struct v4l2_subdev_state *sd_state)
|
2019-10-05 00:05:25 +08:00
|
|
|
{
|
|
|
|
struct v4l2_subdev_format fmt = { 0 };
|
|
|
|
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
fmt.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE;
|
2019-10-05 00:05:25 +08:00
|
|
|
fmt.format.width = 1920;
|
|
|
|
fmt.format.height = 1080;
|
|
|
|
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
imx290_set_fmt(subdev, sd_state, &fmt);
|
2019-10-05 00:05:25 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:50 +08:00
|
|
|
static int imx290_write_current_format(struct imx290 *imx290)
|
2019-10-05 00:05:25 +08:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
2020-06-12 21:53:50 +08:00
|
|
|
switch (imx290->current_format.code) {
|
2019-10-05 00:05:25 +08:00
|
|
|
case MEDIA_BUS_FMT_SRGGB10_1X10:
|
|
|
|
ret = imx290_set_register_array(imx290, imx290_10bit_settings,
|
|
|
|
ARRAY_SIZE(
|
|
|
|
imx290_10bit_settings));
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(imx290->dev, "Could not set format registers\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
break;
|
2020-06-12 21:53:52 +08:00
|
|
|
case MEDIA_BUS_FMT_SRGGB12_1X12:
|
|
|
|
ret = imx290_set_register_array(imx290, imx290_12bit_settings,
|
|
|
|
ARRAY_SIZE(
|
|
|
|
imx290_12bit_settings));
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(imx290->dev, "Could not set format registers\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
break;
|
2019-10-05 00:05:25 +08:00
|
|
|
default:
|
|
|
|
dev_err(imx290->dev, "Unknown pixel format\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:49 +08:00
|
|
|
static int imx290_set_hmax(struct imx290 *imx290, u32 val)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = imx290_write_reg(imx290, IMX290_HMAX_LOW, (val & 0xff));
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "Error setting HMAX register\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = imx290_write_reg(imx290, IMX290_HMAX_HIGH, ((val >> 8) & 0xff));
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "Error setting HMAX register\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
/* Start streaming */
|
|
|
|
static int imx290_start_streaming(struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/* Set init register settings */
|
|
|
|
ret = imx290_set_register_array(imx290, imx290_global_init_settings,
|
|
|
|
ARRAY_SIZE(
|
|
|
|
imx290_global_init_settings));
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(imx290->dev, "Could not set init registers\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:50 +08:00
|
|
|
/* Apply the register values related to current frame format */
|
|
|
|
ret = imx290_write_current_format(imx290);
|
2019-10-05 00:05:25 +08:00
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(imx290->dev, "Could not set frame format\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Apply default values of current mode */
|
|
|
|
ret = imx290_set_register_array(imx290, imx290->current_mode->data,
|
|
|
|
imx290->current_mode->data_size);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(imx290->dev, "Could not set current mode\n");
|
|
|
|
return ret;
|
|
|
|
}
|
2020-06-12 21:53:49 +08:00
|
|
|
ret = imx290_set_hmax(imx290, imx290->current_mode->hmax);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2019-10-05 00:05:25 +08:00
|
|
|
|
|
|
|
/* Apply customized values from user */
|
|
|
|
ret = v4l2_ctrl_handler_setup(imx290->sd.ctrl_handler);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "Could not sync v4l2 controls\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = imx290_write_reg(imx290, IMX290_STANDBY, 0x00);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
msleep(30);
|
|
|
|
|
|
|
|
/* Start streaming */
|
|
|
|
return imx290_write_reg(imx290, IMX290_XMSTA, 0x00);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imx290_set_stream(struct v4l2_subdev *sd, int enable)
|
|
|
|
{
|
|
|
|
struct imx290 *imx290 = to_imx290(sd);
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
if (enable) {
|
2021-04-23 23:19:13 +08:00
|
|
|
ret = pm_runtime_resume_and_get(imx290->dev);
|
|
|
|
if (ret < 0)
|
2019-10-05 00:05:25 +08:00
|
|
|
goto unlock_and_return;
|
|
|
|
|
|
|
|
ret = imx290_start_streaming(imx290);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "Start stream failed\n");
|
|
|
|
pm_runtime_put(imx290->dev);
|
|
|
|
goto unlock_and_return;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
imx290_stop_streaming(imx290);
|
|
|
|
pm_runtime_put(imx290->dev);
|
|
|
|
}
|
|
|
|
|
|
|
|
unlock_and_return:
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imx290_get_regulators(struct device *dev, struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
|
|
|
|
for (i = 0; i < IMX290_NUM_SUPPLIES; i++)
|
|
|
|
imx290->supplies[i].supply = imx290_supply_name[i];
|
|
|
|
|
|
|
|
return devm_regulator_bulk_get(dev, IMX290_NUM_SUPPLIES,
|
|
|
|
imx290->supplies);
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:49 +08:00
|
|
|
static int imx290_set_data_lanes(struct imx290 *imx290)
|
|
|
|
{
|
|
|
|
int ret = 0, laneval, frsel;
|
|
|
|
|
|
|
|
switch (imx290->nlanes) {
|
|
|
|
case 2:
|
|
|
|
laneval = 0x01;
|
|
|
|
frsel = 0x02;
|
|
|
|
break;
|
|
|
|
case 4:
|
|
|
|
laneval = 0x03;
|
|
|
|
frsel = 0x01;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
/*
|
|
|
|
* We should never hit this since the data lane count is
|
|
|
|
* validated in probe itself
|
|
|
|
*/
|
|
|
|
dev_err(imx290->dev, "Lane configuration not supported\n");
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = imx290_write_reg(imx290, IMX290_PHY_LANE_NUM, laneval);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "Error setting Physical Lane number register\n");
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = imx290_write_reg(imx290, IMX290_CSI_LANE_MODE, laneval);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(imx290->dev, "Error setting CSI Lane mode register\n");
|
|
|
|
goto exit;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = imx290_write_reg(imx290, IMX290_FR_FDG_SEL, frsel);
|
|
|
|
if (ret)
|
|
|
|
dev_err(imx290->dev, "Error setting FR/FDG SEL register\n");
|
|
|
|
|
|
|
|
exit:
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
static int imx290_power_on(struct device *dev)
|
|
|
|
{
|
2020-09-22 00:23:20 +08:00
|
|
|
struct v4l2_subdev *sd = dev_get_drvdata(dev);
|
2019-10-05 00:05:25 +08:00
|
|
|
struct imx290 *imx290 = to_imx290(sd);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = clk_prepare_enable(imx290->xclk);
|
|
|
|
if (ret) {
|
2020-09-22 00:23:20 +08:00
|
|
|
dev_err(dev, "Failed to enable clock\n");
|
2019-10-05 00:05:25 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = regulator_bulk_enable(IMX290_NUM_SUPPLIES, imx290->supplies);
|
|
|
|
if (ret) {
|
2020-09-22 00:23:20 +08:00
|
|
|
dev_err(dev, "Failed to enable regulators\n");
|
2019-10-05 00:05:25 +08:00
|
|
|
clk_disable_unprepare(imx290->xclk);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
usleep_range(1, 2);
|
2020-06-12 21:53:48 +08:00
|
|
|
gpiod_set_value_cansleep(imx290->rst_gpio, 0);
|
2019-10-05 00:05:25 +08:00
|
|
|
usleep_range(30000, 31000);
|
|
|
|
|
2020-06-12 21:53:49 +08:00
|
|
|
/* Set data lane count */
|
|
|
|
imx290_set_data_lanes(imx290);
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int imx290_power_off(struct device *dev)
|
|
|
|
{
|
2020-09-22 00:23:20 +08:00
|
|
|
struct v4l2_subdev *sd = dev_get_drvdata(dev);
|
2019-10-05 00:05:25 +08:00
|
|
|
struct imx290 *imx290 = to_imx290(sd);
|
|
|
|
|
|
|
|
clk_disable_unprepare(imx290->xclk);
|
2020-06-12 21:53:48 +08:00
|
|
|
gpiod_set_value_cansleep(imx290->rst_gpio, 1);
|
2019-10-05 00:05:25 +08:00
|
|
|
regulator_bulk_disable(IMX290_NUM_SUPPLIES, imx290->supplies);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct dev_pm_ops imx290_pm_ops = {
|
2020-06-12 21:53:47 +08:00
|
|
|
SET_RUNTIME_PM_OPS(imx290_power_off, imx290_power_on, NULL)
|
2019-10-05 00:05:25 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct v4l2_subdev_video_ops imx290_video_ops = {
|
|
|
|
.s_stream = imx290_set_stream,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct v4l2_subdev_pad_ops imx290_pad_ops = {
|
|
|
|
.init_cfg = imx290_entity_init_cfg,
|
|
|
|
.enum_mbus_code = imx290_enum_mbus_code,
|
2020-06-12 21:53:53 +08:00
|
|
|
.enum_frame_size = imx290_enum_frame_size,
|
2019-10-05 00:05:25 +08:00
|
|
|
.get_fmt = imx290_get_fmt,
|
|
|
|
.set_fmt = imx290_set_fmt,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct v4l2_subdev_ops imx290_subdev_ops = {
|
|
|
|
.video = &imx290_video_ops,
|
|
|
|
.pad = &imx290_pad_ops,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct media_entity_operations imx290_subdev_entity_ops = {
|
|
|
|
.link_validate = v4l2_subdev_link_validate,
|
|
|
|
};
|
|
|
|
|
2020-06-12 21:53:50 +08:00
|
|
|
/*
|
|
|
|
* Returns 0 if all link frequencies used by the driver for the given number
|
|
|
|
* of MIPI data lanes are mentioned in the device tree, or the value of the
|
|
|
|
* first missing frequency otherwise.
|
|
|
|
*/
|
2020-06-12 21:53:55 +08:00
|
|
|
static s64 imx290_check_link_freqs(const struct imx290 *imx290,
|
|
|
|
const struct v4l2_fwnode_endpoint *ep)
|
2020-06-12 21:53:50 +08:00
|
|
|
{
|
|
|
|
int i, j;
|
|
|
|
const s64 *freqs = imx290_link_freqs_ptr(imx290);
|
|
|
|
int freqs_count = imx290_link_freqs_num(imx290);
|
|
|
|
|
|
|
|
for (i = 0; i < freqs_count; i++) {
|
2020-06-12 21:53:55 +08:00
|
|
|
for (j = 0; j < ep->nr_of_link_frequencies; j++)
|
|
|
|
if (freqs[i] == ep->link_frequencies[j])
|
2020-06-12 21:53:50 +08:00
|
|
|
break;
|
2020-06-12 21:53:55 +08:00
|
|
|
if (j == ep->nr_of_link_frequencies)
|
2020-06-12 21:53:50 +08:00
|
|
|
return freqs[i];
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
static int imx290_probe(struct i2c_client *client)
|
|
|
|
{
|
|
|
|
struct device *dev = &client->dev;
|
|
|
|
struct fwnode_handle *endpoint;
|
2020-06-12 21:53:55 +08:00
|
|
|
/* Only CSI2 is supported for now: */
|
|
|
|
struct v4l2_fwnode_endpoint ep = {
|
|
|
|
.bus_type = V4L2_MBUS_CSI2_DPHY
|
|
|
|
};
|
2019-10-05 00:05:25 +08:00
|
|
|
struct imx290 *imx290;
|
|
|
|
u32 xclk_freq;
|
2020-06-12 21:53:50 +08:00
|
|
|
s64 fq;
|
2019-10-05 00:05:25 +08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
imx290 = devm_kzalloc(dev, sizeof(*imx290), GFP_KERNEL);
|
|
|
|
if (!imx290)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
imx290->dev = dev;
|
|
|
|
imx290->regmap = devm_regmap_init_i2c(client, &imx290_regmap_config);
|
|
|
|
if (IS_ERR(imx290->regmap)) {
|
|
|
|
dev_err(dev, "Unable to initialize I2C\n");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
endpoint = fwnode_graph_get_next_endpoint(dev_fwnode(dev), NULL);
|
|
|
|
if (!endpoint) {
|
|
|
|
dev_err(dev, "Endpoint node not found\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:55 +08:00
|
|
|
ret = v4l2_fwnode_endpoint_alloc_parse(endpoint, &ep);
|
2019-10-05 00:05:25 +08:00
|
|
|
fwnode_handle_put(endpoint);
|
2020-06-12 21:53:55 +08:00
|
|
|
if (ret == -ENXIO) {
|
|
|
|
dev_err(dev, "Unsupported bus type, should be CSI2\n");
|
|
|
|
goto free_err;
|
|
|
|
} else if (ret) {
|
2019-10-05 00:05:25 +08:00
|
|
|
dev_err(dev, "Parsing endpoint node failed\n");
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:49 +08:00
|
|
|
/* Get number of data lanes */
|
2020-06-12 21:53:55 +08:00
|
|
|
imx290->nlanes = ep.bus.mipi_csi2.num_data_lanes;
|
2020-06-12 21:53:49 +08:00
|
|
|
if (imx290->nlanes != 2 && imx290->nlanes != 4) {
|
|
|
|
dev_err(dev, "Invalid data lanes: %d\n", imx290->nlanes);
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
dev_dbg(dev, "Using %u data lanes\n", imx290->nlanes);
|
|
|
|
|
2020-06-12 21:53:55 +08:00
|
|
|
if (!ep.nr_of_link_frequencies) {
|
2019-10-05 00:05:25 +08:00
|
|
|
dev_err(dev, "link-frequency property not found in DT\n");
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:50 +08:00
|
|
|
/* Check that link frequences for all the modes are in device tree */
|
2020-06-12 21:53:55 +08:00
|
|
|
fq = imx290_check_link_freqs(imx290, &ep);
|
2020-06-12 21:53:50 +08:00
|
|
|
if (fq) {
|
|
|
|
dev_err(dev, "Link frequency of %lld is not supported\n", fq);
|
2019-10-05 00:05:25 +08:00
|
|
|
ret = -EINVAL;
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* get system clock (xclk) */
|
|
|
|
imx290->xclk = devm_clk_get(dev, "xclk");
|
|
|
|
if (IS_ERR(imx290->xclk)) {
|
|
|
|
dev_err(dev, "Could not get xclk");
|
|
|
|
ret = PTR_ERR(imx290->xclk);
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency",
|
|
|
|
&xclk_freq);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(dev, "Could not get xclk frequency\n");
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* external clock must be 37.125 MHz */
|
|
|
|
if (xclk_freq != 37125000) {
|
|
|
|
dev_err(dev, "External clock frequency %u is not supported\n",
|
|
|
|
xclk_freq);
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = clk_set_rate(imx290->xclk, xclk_freq);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(dev, "Could not set xclk frequency\n");
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = imx290_get_regulators(dev, imx290);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(dev, "Cannot get regulators\n");
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
2020-06-12 21:53:48 +08:00
|
|
|
imx290->rst_gpio = devm_gpiod_get_optional(dev, "reset",
|
|
|
|
GPIOD_OUT_HIGH);
|
2019-10-05 00:05:25 +08:00
|
|
|
if (IS_ERR(imx290->rst_gpio)) {
|
|
|
|
dev_err(dev, "Cannot get reset gpio\n");
|
|
|
|
ret = PTR_ERR(imx290->rst_gpio);
|
|
|
|
goto free_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_init(&imx290->lock);
|
|
|
|
|
2020-06-12 21:53:50 +08:00
|
|
|
/*
|
|
|
|
* Initialize the frame format. In particular, imx290->current_mode
|
|
|
|
* and imx290->bpp are set to defaults: imx290_calc_pixel_rate() call
|
|
|
|
* below relies on these fields.
|
|
|
|
*/
|
|
|
|
imx290_entity_init_cfg(&imx290->sd, NULL);
|
|
|
|
|
2020-06-12 21:53:51 +08:00
|
|
|
v4l2_ctrl_handler_init(&imx290->ctrls, 4);
|
2019-10-05 00:05:25 +08:00
|
|
|
|
|
|
|
v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
|
|
|
|
V4L2_CID_GAIN, 0, 72, 1, 0);
|
2020-06-12 21:53:50 +08:00
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
imx290->link_freq =
|
2020-06-12 21:53:50 +08:00
|
|
|
v4l2_ctrl_new_int_menu(&imx290->ctrls, &imx290_ctrl_ops,
|
2019-10-05 00:05:25 +08:00
|
|
|
V4L2_CID_LINK_FREQ,
|
2020-06-12 21:53:50 +08:00
|
|
|
imx290_link_freqs_num(imx290) - 1, 0,
|
|
|
|
imx290_link_freqs_ptr(imx290));
|
2019-10-05 00:05:25 +08:00
|
|
|
if (imx290->link_freq)
|
|
|
|
imx290->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
|
|
|
|
|
|
|
|
imx290->pixel_rate = v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
|
2020-06-12 21:53:50 +08:00
|
|
|
V4L2_CID_PIXEL_RATE,
|
|
|
|
1, INT_MAX, 1,
|
|
|
|
imx290_calc_pixel_rate(imx290));
|
2019-10-05 00:05:25 +08:00
|
|
|
|
2020-06-12 21:53:51 +08:00
|
|
|
v4l2_ctrl_new_std_menu_items(&imx290->ctrls, &imx290_ctrl_ops,
|
|
|
|
V4L2_CID_TEST_PATTERN,
|
|
|
|
ARRAY_SIZE(imx290_test_pattern_menu) - 1,
|
|
|
|
0, 0, imx290_test_pattern_menu);
|
|
|
|
|
2019-10-05 00:05:25 +08:00
|
|
|
imx290->sd.ctrl_handler = &imx290->ctrls;
|
|
|
|
|
|
|
|
if (imx290->ctrls.error) {
|
|
|
|
dev_err(dev, "Control initialization error %d\n",
|
|
|
|
imx290->ctrls.error);
|
|
|
|
ret = imx290->ctrls.error;
|
|
|
|
goto free_ctrl;
|
|
|
|
}
|
|
|
|
|
|
|
|
v4l2_i2c_subdev_init(&imx290->sd, client, &imx290_subdev_ops);
|
|
|
|
imx290->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
|
|
|
|
imx290->sd.dev = &client->dev;
|
|
|
|
imx290->sd.entity.ops = &imx290_subdev_entity_ops;
|
|
|
|
imx290->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
|
|
|
|
|
|
|
|
imx290->pad.flags = MEDIA_PAD_FL_SOURCE;
|
|
|
|
ret = media_entity_pads_init(&imx290->sd.entity, 1, &imx290->pad);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(dev, "Could not register media entity\n");
|
|
|
|
goto free_ctrl;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = v4l2_async_register_subdev(&imx290->sd);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(dev, "Could not register v4l2 device\n");
|
|
|
|
goto free_entity;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Power on the device to match runtime PM state below */
|
|
|
|
ret = imx290_power_on(dev);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(dev, "Could not power on the device\n");
|
|
|
|
goto free_entity;
|
|
|
|
}
|
|
|
|
|
|
|
|
pm_runtime_set_active(dev);
|
|
|
|
pm_runtime_enable(dev);
|
|
|
|
pm_runtime_idle(dev);
|
|
|
|
|
2020-06-12 21:53:55 +08:00
|
|
|
v4l2_fwnode_endpoint_free(&ep);
|
2019-10-05 00:05:25 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
free_entity:
|
|
|
|
media_entity_cleanup(&imx290->sd.entity);
|
|
|
|
free_ctrl:
|
|
|
|
v4l2_ctrl_handler_free(&imx290->ctrls);
|
|
|
|
mutex_destroy(&imx290->lock);
|
|
|
|
free_err:
|
2020-06-12 21:53:55 +08:00
|
|
|
v4l2_fwnode_endpoint_free(&ep);
|
2019-10-05 00:05:25 +08:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2022-08-15 16:02:30 +08:00
|
|
|
static void imx290_remove(struct i2c_client *client)
|
2019-10-05 00:05:25 +08:00
|
|
|
{
|
|
|
|
struct v4l2_subdev *sd = i2c_get_clientdata(client);
|
|
|
|
struct imx290 *imx290 = to_imx290(sd);
|
|
|
|
|
|
|
|
v4l2_async_unregister_subdev(sd);
|
|
|
|
media_entity_cleanup(&sd->entity);
|
|
|
|
v4l2_ctrl_handler_free(sd->ctrl_handler);
|
|
|
|
|
|
|
|
mutex_destroy(&imx290->lock);
|
|
|
|
|
|
|
|
pm_runtime_disable(imx290->dev);
|
|
|
|
if (!pm_runtime_status_suspended(imx290->dev))
|
|
|
|
imx290_power_off(imx290->dev);
|
|
|
|
pm_runtime_set_suspended(imx290->dev);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct of_device_id imx290_of_match[] = {
|
|
|
|
{ .compatible = "sony,imx290" },
|
|
|
|
{ /* sentinel */ }
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, imx290_of_match);
|
|
|
|
|
|
|
|
static struct i2c_driver imx290_i2c_driver = {
|
|
|
|
.probe_new = imx290_probe,
|
|
|
|
.remove = imx290_remove,
|
|
|
|
.driver = {
|
|
|
|
.name = "imx290",
|
|
|
|
.pm = &imx290_pm_ops,
|
|
|
|
.of_match_table = of_match_ptr(imx290_of_match),
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
|
|
|
module_i2c_driver(imx290_i2c_driver);
|
|
|
|
|
|
|
|
MODULE_DESCRIPTION("Sony IMX290 CMOS Image Sensor Driver");
|
|
|
|
MODULE_AUTHOR("FRAMOS GmbH");
|
|
|
|
MODULE_AUTHOR("Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>");
|
|
|
|
MODULE_LICENSE("GPL v2");
|