2018-06-06 10:42:14 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2006-06-09 12:48:12 +08:00
|
|
|
* Copyright (c) 2000-2006 Silicon Graphics, Inc.
|
2005-11-02 11:58:39 +08:00
|
|
|
* All Rights Reserved.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2017-12-11 19:35:19 +08:00
|
|
|
#include <linux/iversion.h>
|
2007-11-23 13:30:51 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
#include "xfs.h"
|
2005-11-02 11:38:42 +08:00
|
|
|
#include "xfs_fs.h"
|
2013-10-23 07:36:05 +08:00
|
|
|
#include "xfs_shared.h"
|
2013-10-23 07:50:10 +08:00
|
|
|
#include "xfs_format.h"
|
|
|
|
#include "xfs_log_format.h"
|
|
|
|
#include "xfs_trans_resv.h"
|
2005-04-17 06:20:36 +08:00
|
|
|
#include "xfs_mount.h"
|
2016-08-03 09:15:38 +08:00
|
|
|
#include "xfs_defer.h"
|
2013-10-23 07:51:50 +08:00
|
|
|
#include "xfs_inode.h"
|
2013-08-12 18:49:45 +08:00
|
|
|
#include "xfs_dir2.h"
|
|
|
|
#include "xfs_attr.h"
|
2013-10-23 07:50:10 +08:00
|
|
|
#include "xfs_trans_space.h"
|
|
|
|
#include "xfs_trans.h"
|
2005-04-17 06:20:36 +08:00
|
|
|
#include "xfs_buf_item.h"
|
2005-11-02 11:38:42 +08:00
|
|
|
#include "xfs_inode_item.h"
|
2022-07-14 09:47:42 +08:00
|
|
|
#include "xfs_iunlink_item.h"
|
2005-11-02 11:38:42 +08:00
|
|
|
#include "xfs_ialloc.h"
|
|
|
|
#include "xfs_bmap.h"
|
2013-08-12 18:49:42 +08:00
|
|
|
#include "xfs_bmap_util.h"
|
2017-11-01 03:04:49 +08:00
|
|
|
#include "xfs_errortag.h"
|
2005-04-17 06:20:36 +08:00
|
|
|
#include "xfs_error.h"
|
|
|
|
#include "xfs_quota.h"
|
2007-07-11 09:09:12 +08:00
|
|
|
#include "xfs_filestream.h"
|
2009-12-15 07:14:59 +08:00
|
|
|
#include "xfs_trace.h"
|
2012-10-08 18:56:11 +08:00
|
|
|
#include "xfs_icache.h"
|
2013-08-12 18:49:45 +08:00
|
|
|
#include "xfs_symlink.h"
|
2013-10-23 07:50:10 +08:00
|
|
|
#include "xfs_trans_priv.h"
|
|
|
|
#include "xfs_log.h"
|
2013-10-23 07:51:50 +08:00
|
|
|
#include "xfs_bmap_btree.h"
|
2016-10-04 00:11:38 +08:00
|
|
|
#include "xfs_reflink.h"
|
2021-06-02 08:48:24 +08:00
|
|
|
#include "xfs_ag.h"
|
xfs: xfs_is_shutdown vs xlog_is_shutdown cage fight
I've been chasing a recent resurgence in generic/388 recovery
failure and/or corruption events. The events have largely been
uninitialised inode chunks being tripped over in log recovery
such as:
XFS (pmem1): User initiated shutdown received.
pmem1: writeback error on inode 12621949, offset 1019904, sector 12968096
XFS (pmem1): Log I/O Error (0x6) detected at xfs_fs_goingdown+0xa3/0xf0 (fs/xfs/xfs_fsops.c:500). Shutting down filesystem.
XFS (pmem1): Please unmount the filesystem and rectify the problem(s)
XFS (pmem1): Unmounting Filesystem
XFS (pmem1): Mounting V5 Filesystem
XFS (pmem1): Starting recovery (logdev: internal)
XFS (pmem1): bad inode magic/vsn daddr 8723584 #0 (magic=1818)
XFS (pmem1): Metadata corruption detected at xfs_inode_buf_verify+0x180/0x190, xfs_inode block 0x851c80 xfs_inode_buf_verify
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): First 128 bytes of corrupted metadata buffer:
00000000: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000010: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000020: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000030: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000040: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000050: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000060: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000070: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
XFS (pmem1): metadata I/O error in "xlog_recover_items_pass2+0x52/0xc0" at daddr 0x851c80 len 32 error 117
XFS (pmem1): log mount/recovery failed: error -117
XFS (pmem1): log mount failed
There have been isolated random other issues, too - xfs_repair fails
because it finds some corruption in symlink blocks, rmap
inconsistencies, etc - but they are nowhere near as common as the
uninitialised inode chunk failure.
The problem has clearly happened at runtime before recovery has run;
I can see the ICREATE log item in the log shortly before the
actively recovered range of the log. This means the ICREATE was
definitely created and written to the log, but for some reason the
tail of the log has been moved past the ordered buffer log item that
tracks INODE_ALLOC buffers and, supposedly, prevents the tail of the
log moving past the ICREATE log item before the inode chunk buffer
is written to disk.
Tracing the fsstress processes that are running when the filesystem
shut down immediately pin-pointed the problem:
user shutdown marks xfs_mount as shutdown
godown-213341 [008] 6398.022871: console: [ 6397.915392] XFS (pmem1): User initiated shutdown received.
.....
aild tries to push ordered inode cluster buffer
xfsaild/pmem1-213314 [001] 6398.022974: xfs_buf_trylock: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 16 pincount 0 lock 0 flags DONE|INODES|PAGES caller xfs_inode_item_push+0x8e
xfsaild/pmem1-213314 [001] 6398.022976: xfs_ilock_nowait: dev 259:1 ino 0x851c80 flags ILOCK_SHARED caller xfs_iflush_cluster+0xae
xfs_iflush_cluster() checks xfs_is_shutdown(), returns true,
calls xfs_iflush_abort() to kill writeback of the inode.
Inode is removed from AIL, drops cluster buffer reference.
xfsaild/pmem1-213314 [001] 6398.022977: xfs_ail_delete: dev 259:1 lip 0xffff88880247ed80 old lsn 7/20344 new lsn 7/21000 type XFS_LI_INODE flags IN_AIL
xfsaild/pmem1-213314 [001] 6398.022978: xfs_buf_rele: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 17 pincount 0 lock 0 flags DONE|INODES|PAGES caller xfs_iflush_abort+0xd7
.....
All inodes on cluster buffer are aborted, then the cluster buffer
itself is aborted and removed from the AIL *without writeback*:
xfsaild/pmem1-213314 [001] 6398.023011: xfs_buf_error_relse: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 2 pincount 0 lock 0 flags ASYNC|DONE|STALE|INODES|PAGES caller xfs_buf_ioend_fail+0x33
xfsaild/pmem1-213314 [001] 6398.023012: xfs_ail_delete: dev 259:1 lip 0xffff8888053efde8 old lsn 7/20344 new lsn 7/20344 type XFS_LI_BUF flags IN_AIL
The inode buffer was at 7/20344 when it was removed from the AIL.
xfsaild/pmem1-213314 [001] 6398.023012: xfs_buf_item_relse: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 2 pincount 0 lock 0 flags ASYNC|DONE|STALE|INODES|PAGES caller xfs_buf_item_done+0x31
xfsaild/pmem1-213314 [001] 6398.023012: xfs_buf_rele: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 2 pincount 0 lock 0 flags ASYNC|DONE|STALE|INODES|PAGES caller xfs_buf_item_relse+0x39
.....
Userspace is still running, doing stuff. an fsstress process runs
syncfs() or sync() and we end up in sync_fs_one_sb() which issues
a log force. This pushes on the CIL:
fsstress-213322 [001] 6398.024430: xfs_fs_sync_fs: dev 259:1 m_features 0x20000000019ff6e9 opstate (clean|shutdown|inodegc|blockgc) s_flags 0x70810000 caller sync_fs_one_sb+0x26
fsstress-213322 [001] 6398.024430: xfs_log_force: dev 259:1 lsn 0x0 caller xfs_fs_sync_fs+0x82
fsstress-213322 [001] 6398.024430: xfs_log_force: dev 259:1 lsn 0x5f caller xfs_log_force+0x7c
<...>-194402 [001] 6398.024467: kmem_alloc: size 176 flags 0x14 caller xlog_cil_push_work+0x9f
And the CIL fills up iclogs with pending changes. This picks up
the current tail from the AIL:
<...>-194402 [001] 6398.024497: xlog_iclog_get_space: dev 259:1 state XLOG_STATE_ACTIVE refcnt 1 offset 0 lsn 0x0 flags caller xlog_write+0x149
<...>-194402 [001] 6398.024498: xlog_iclog_switch: dev 259:1 state XLOG_STATE_ACTIVE refcnt 1 offset 0 lsn 0x700005408 flags caller xlog_state_get_iclog_space+0x37e
<...>-194402 [001] 6398.024521: xlog_iclog_release: dev 259:1 state XLOG_STATE_WANT_SYNC refcnt 1 offset 32256 lsn 0x700005408 flags caller xlog_write+0x5f9
<...>-194402 [001] 6398.024522: xfs_log_assign_tail_lsn: dev 259:1 new tail lsn 7/21000, old lsn 7/20344, last sync 7/21448
And it moves the tail of the log to 7/21000 from 7/20344. This
*moves the tail of the log beyond the ICREATE transaction* that was
at 7/20344 and pinned by the inode cluster buffer that was cancelled
above.
....
godown-213341 [008] 6398.027005: xfs_force_shutdown: dev 259:1 tag logerror flags log_io|force_umount file fs/xfs/xfs_fsops.c line_num 500
godown-213341 [008] 6398.027022: console: [ 6397.915406] pmem1: writeback error on inode 12621949, offset 1019904, sector 12968096
godown-213341 [008] 6398.030551: console: [ 6397.919546] XFS (pmem1): Log I/O Error (0x6) detected at xfs_fs_goingdown+0xa3/0xf0 (fs/
And finally the log itself is now shutdown, stopping all further
writes to the log. But this is too late to prevent the corruption
that moving the tail of the log forwards after we start cancelling
writeback causes.
The fundamental problem here is that we are using the wrong shutdown
checks for log items. We've long conflated mount shutdown with log
shutdown state, and I started separating that recently with the
atomic shutdown state changes in commit b36d4651e165 ("xfs: make
forced shutdown processing atomic"). The changes in that commit
series are directly responsible for being able to diagnose this
issue because it clearly separated mount shutdown from log shutdown.
Essentially, once we start cancelling writeback of log items and
removing them from the AIL because the filesystem is shut down, we
*cannot* update the journal because we may have cancelled the items
that pin the tail of the log. That moves the tail of the log
forwards without having written the metadata back, hence we have
corrupt in memory state and writing to the journal propagates that
to the on-disk state.
What commit b36d4651e165 makes clear is that log item state needs to
change relative to log shutdown, not mount shutdown. IOWs, anything
that aborts metadata writeback needs to check log shutdown state
because log items directly affect log consistency. Having them check
mount shutdown state introduces the above race condition where we
cancel metadata writeback before the log shuts down.
To fix this, this patch works through all log items and converts
shutdown checks to use xlog_is_shutdown() rather than
xfs_is_shutdown(), so that we don't start aborting metadata
writeback before we shut off journal writes.
AFAICT, this race condition is a zero day IO error handling bug in
XFS that dates back to the introduction of XLOG_IO_ERROR,
XLOG_STATE_IOERROR and XFS_FORCED_SHUTDOWN back in January 1997.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
2022-03-18 00:09:13 +08:00
|
|
|
#include "xfs_log_priv.h"
|
2023-12-16 02:03:35 +08:00
|
|
|
#include "xfs_health.h"
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2021-10-13 02:09:23 +08:00
|
|
|
struct kmem_cache *xfs_inode_cache;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
STATIC int xfs_iunlink(struct xfs_trans *, struct xfs_inode *);
|
2021-06-02 08:48:51 +08:00
|
|
|
STATIC int xfs_iunlink_remove(struct xfs_trans *tp, struct xfs_perag *pag,
|
|
|
|
struct xfs_inode *);
|
2013-12-18 08:22:41 +08:00
|
|
|
|
2012-04-23 13:59:02 +08:00
|
|
|
/*
|
|
|
|
* helper function to extract extent size hint from inode
|
|
|
|
*/
|
|
|
|
xfs_extlen_t
|
|
|
|
xfs_get_extsz_hint(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
2019-10-15 01:07:21 +08:00
|
|
|
/*
|
|
|
|
* No point in aligning allocations if we need to COW to actually
|
|
|
|
* write to them.
|
|
|
|
*/
|
|
|
|
if (xfs_is_always_cow_inode(ip))
|
|
|
|
return 0;
|
2021-03-30 02:11:44 +08:00
|
|
|
if ((ip->i_diflags & XFS_DIFLAG_EXTSIZE) && ip->i_extsize)
|
2021-03-30 02:11:41 +08:00
|
|
|
return ip->i_extsize;
|
2012-04-23 13:59:02 +08:00
|
|
|
if (XFS_IS_REALTIME_INODE(ip))
|
|
|
|
return ip->i_mount->m_sb.sb_rextsize;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-10-04 00:11:43 +08:00
|
|
|
/*
|
|
|
|
* Helper function to extract CoW extent size hint from inode.
|
|
|
|
* Between the extent size hint and the CoW extent size hint, we
|
2016-10-04 00:11:49 +08:00
|
|
|
* return the greater of the two. If the value is zero (automatic),
|
|
|
|
* use the default size.
|
2016-10-04 00:11:43 +08:00
|
|
|
*/
|
|
|
|
xfs_extlen_t
|
|
|
|
xfs_get_cowextsz_hint(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
xfs_extlen_t a, b;
|
|
|
|
|
|
|
|
a = 0;
|
2021-03-30 02:11:45 +08:00
|
|
|
if (ip->i_diflags2 & XFS_DIFLAG2_COWEXTSIZE)
|
2021-03-30 02:11:42 +08:00
|
|
|
a = ip->i_cowextsize;
|
2016-10-04 00:11:43 +08:00
|
|
|
b = xfs_get_extsz_hint(ip);
|
|
|
|
|
2016-10-04 00:11:49 +08:00
|
|
|
a = max(a, b);
|
|
|
|
if (a == 0)
|
|
|
|
return XFS_DEFAULT_COWEXTSZ_HINT;
|
|
|
|
return a;
|
2016-10-04 00:11:43 +08:00
|
|
|
}
|
|
|
|
|
2012-10-08 18:56:10 +08:00
|
|
|
/*
|
2013-12-18 18:14:39 +08:00
|
|
|
* These two are wrapper routines around the xfs_ilock() routine used to
|
|
|
|
* centralize some grungy code. They are used in places that wish to lock the
|
|
|
|
* inode solely for reading the extents. The reason these places can't just
|
|
|
|
* call xfs_ilock(ip, XFS_ILOCK_SHARED) is that the inode lock also guards to
|
|
|
|
* bringing in of the extents from disk for a file in b-tree format. If the
|
|
|
|
* inode is in b-tree format, then we need to lock the inode exclusively until
|
|
|
|
* the extents are read in. Locking it exclusively all the time would limit
|
|
|
|
* our parallelism unnecessarily, though. What we do instead is check to see
|
|
|
|
* if the extents have been read in yet, and only lock the inode exclusively
|
|
|
|
* if they have not.
|
2012-10-08 18:56:10 +08:00
|
|
|
*
|
2013-12-18 18:14:39 +08:00
|
|
|
* The functions return a value which should be given to the corresponding
|
2013-12-07 04:30:08 +08:00
|
|
|
* xfs_iunlock() call.
|
2012-10-08 18:56:10 +08:00
|
|
|
*/
|
|
|
|
uint
|
2013-12-07 04:30:09 +08:00
|
|
|
xfs_ilock_data_map_shared(
|
|
|
|
struct xfs_inode *ip)
|
2012-10-08 18:56:10 +08:00
|
|
|
{
|
2013-12-07 04:30:09 +08:00
|
|
|
uint lock_mode = XFS_ILOCK_SHARED;
|
2012-10-08 18:56:10 +08:00
|
|
|
|
2021-04-14 02:15:12 +08:00
|
|
|
if (xfs_need_iread_extents(&ip->i_df))
|
2012-10-08 18:56:10 +08:00
|
|
|
lock_mode = XFS_ILOCK_EXCL;
|
|
|
|
xfs_ilock(ip, lock_mode);
|
|
|
|
return lock_mode;
|
|
|
|
}
|
|
|
|
|
2013-12-18 18:14:39 +08:00
|
|
|
uint
|
|
|
|
xfs_ilock_attr_map_shared(
|
|
|
|
struct xfs_inode *ip)
|
2012-10-08 18:56:10 +08:00
|
|
|
{
|
2013-12-18 18:14:39 +08:00
|
|
|
uint lock_mode = XFS_ILOCK_SHARED;
|
|
|
|
|
2022-07-10 01:56:06 +08:00
|
|
|
if (xfs_inode_has_attr_fork(ip) && xfs_need_iread_extents(&ip->i_af))
|
2013-12-18 18:14:39 +08:00
|
|
|
lock_mode = XFS_ILOCK_EXCL;
|
|
|
|
xfs_ilock(ip, lock_mode);
|
|
|
|
return lock_mode;
|
2012-10-08 18:56:10 +08:00
|
|
|
}
|
|
|
|
|
2022-06-20 05:53:42 +08:00
|
|
|
/*
|
|
|
|
* You can't set both SHARED and EXCL for the same lock,
|
|
|
|
* and only XFS_IOLOCK_SHARED, XFS_IOLOCK_EXCL, XFS_MMAPLOCK_SHARED,
|
|
|
|
* XFS_MMAPLOCK_EXCL, XFS_ILOCK_SHARED, XFS_ILOCK_EXCL are valid values
|
|
|
|
* to set in lock_flags.
|
|
|
|
*/
|
|
|
|
static inline void
|
|
|
|
xfs_lock_flags_assert(
|
|
|
|
uint lock_flags)
|
|
|
|
{
|
|
|
|
ASSERT((lock_flags & (XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL)) !=
|
|
|
|
(XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL));
|
|
|
|
ASSERT((lock_flags & (XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL)) !=
|
|
|
|
(XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL));
|
|
|
|
ASSERT((lock_flags & (XFS_ILOCK_SHARED | XFS_ILOCK_EXCL)) !=
|
|
|
|
(XFS_ILOCK_SHARED | XFS_ILOCK_EXCL));
|
|
|
|
ASSERT((lock_flags & ~(XFS_LOCK_MASK | XFS_LOCK_SUBCLASS_MASK)) == 0);
|
|
|
|
ASSERT(lock_flags != 0);
|
|
|
|
}
|
|
|
|
|
2012-10-08 18:56:10 +08:00
|
|
|
/*
|
2016-11-30 11:33:25 +08:00
|
|
|
* In addition to i_rwsem in the VFS inode, the xfs inode contains 2
|
2021-04-13 00:56:24 +08:00
|
|
|
* multi-reader locks: invalidate_lock and the i_lock. This routine allows
|
2016-11-30 11:33:25 +08:00
|
|
|
* various combinations of the locks to be obtained.
|
2012-10-08 18:56:10 +08:00
|
|
|
*
|
2015-02-23 18:43:37 +08:00
|
|
|
* The 3 locks should always be ordered so that the IO lock is obtained first,
|
|
|
|
* the mmap lock second and the ilock last in order to prevent deadlock.
|
2012-10-08 18:56:10 +08:00
|
|
|
*
|
2015-02-23 18:43:37 +08:00
|
|
|
* Basic locking order:
|
|
|
|
*
|
2021-04-13 00:56:24 +08:00
|
|
|
* i_rwsem -> invalidate_lock -> page_lock -> i_ilock
|
2015-02-23 18:43:37 +08:00
|
|
|
*
|
2020-06-09 12:33:54 +08:00
|
|
|
* mmap_lock locking order:
|
2015-02-23 18:43:37 +08:00
|
|
|
*
|
2020-06-09 12:33:54 +08:00
|
|
|
* i_rwsem -> page lock -> mmap_lock
|
2021-04-13 00:56:24 +08:00
|
|
|
* mmap_lock -> invalidate_lock -> page_lock
|
2015-02-23 18:43:37 +08:00
|
|
|
*
|
2020-06-09 12:33:54 +08:00
|
|
|
* The difference in mmap_lock locking order mean that we cannot hold the
|
2021-04-13 00:56:24 +08:00
|
|
|
* invalidate_lock over syscall based read(2)/write(2) based IO. These IO paths
|
|
|
|
* can fault in pages during copy in/out (for buffered IO) or require the
|
|
|
|
* mmap_lock in get_user_pages() to map the user pages into the kernel address
|
|
|
|
* space for direct IO. Similarly the i_rwsem cannot be taken inside a page
|
|
|
|
* fault because page faults already hold the mmap_lock.
|
2015-02-23 18:43:37 +08:00
|
|
|
*
|
|
|
|
* Hence to serialise fully against both syscall and mmap based IO, we need to
|
2021-04-13 00:56:24 +08:00
|
|
|
* take both the i_rwsem and the invalidate_lock. These locks should *only* be
|
|
|
|
* both taken in places where we need to invalidate the page cache in a race
|
2015-02-23 18:43:37 +08:00
|
|
|
* free manner (e.g. truncate, hole punch and other extent manipulation
|
|
|
|
* functions).
|
2012-10-08 18:56:10 +08:00
|
|
|
*/
|
|
|
|
void
|
|
|
|
xfs_ilock(
|
|
|
|
xfs_inode_t *ip,
|
|
|
|
uint lock_flags)
|
|
|
|
{
|
|
|
|
trace_xfs_ilock(ip, lock_flags, _RET_IP_);
|
|
|
|
|
2022-06-20 05:53:42 +08:00
|
|
|
xfs_lock_flags_assert(lock_flags);
|
2012-10-08 18:56:10 +08:00
|
|
|
|
2016-11-30 11:33:25 +08:00
|
|
|
if (lock_flags & XFS_IOLOCK_EXCL) {
|
|
|
|
down_write_nested(&VFS_I(ip)->i_rwsem,
|
|
|
|
XFS_IOLOCK_DEP(lock_flags));
|
|
|
|
} else if (lock_flags & XFS_IOLOCK_SHARED) {
|
|
|
|
down_read_nested(&VFS_I(ip)->i_rwsem,
|
|
|
|
XFS_IOLOCK_DEP(lock_flags));
|
|
|
|
}
|
2012-10-08 18:56:10 +08:00
|
|
|
|
2021-04-13 00:56:24 +08:00
|
|
|
if (lock_flags & XFS_MMAPLOCK_EXCL) {
|
|
|
|
down_write_nested(&VFS_I(ip)->i_mapping->invalidate_lock,
|
|
|
|
XFS_MMAPLOCK_DEP(lock_flags));
|
|
|
|
} else if (lock_flags & XFS_MMAPLOCK_SHARED) {
|
|
|
|
down_read_nested(&VFS_I(ip)->i_mapping->invalidate_lock,
|
|
|
|
XFS_MMAPLOCK_DEP(lock_flags));
|
|
|
|
}
|
2015-02-23 18:43:37 +08:00
|
|
|
|
2012-10-08 18:56:10 +08:00
|
|
|
if (lock_flags & XFS_ILOCK_EXCL)
|
|
|
|
mrupdate_nested(&ip->i_lock, XFS_ILOCK_DEP(lock_flags));
|
|
|
|
else if (lock_flags & XFS_ILOCK_SHARED)
|
|
|
|
mraccess_nested(&ip->i_lock, XFS_ILOCK_DEP(lock_flags));
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This is just like xfs_ilock(), except that the caller
|
|
|
|
* is guaranteed not to sleep. It returns 1 if it gets
|
|
|
|
* the requested locks and 0 otherwise. If the IO lock is
|
|
|
|
* obtained but the inode lock cannot be, then the IO lock
|
|
|
|
* is dropped before returning.
|
|
|
|
*
|
|
|
|
* ip -- the inode being locked
|
|
|
|
* lock_flags -- this parameter indicates the inode's locks to be
|
|
|
|
* to be locked. See the comment for xfs_ilock() for a list
|
|
|
|
* of valid values.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_ilock_nowait(
|
|
|
|
xfs_inode_t *ip,
|
|
|
|
uint lock_flags)
|
|
|
|
{
|
|
|
|
trace_xfs_ilock_nowait(ip, lock_flags, _RET_IP_);
|
|
|
|
|
2022-06-20 05:53:42 +08:00
|
|
|
xfs_lock_flags_assert(lock_flags);
|
2012-10-08 18:56:10 +08:00
|
|
|
|
|
|
|
if (lock_flags & XFS_IOLOCK_EXCL) {
|
2016-11-30 11:33:25 +08:00
|
|
|
if (!down_write_trylock(&VFS_I(ip)->i_rwsem))
|
2012-10-08 18:56:10 +08:00
|
|
|
goto out;
|
|
|
|
} else if (lock_flags & XFS_IOLOCK_SHARED) {
|
2016-11-30 11:33:25 +08:00
|
|
|
if (!down_read_trylock(&VFS_I(ip)->i_rwsem))
|
2012-10-08 18:56:10 +08:00
|
|
|
goto out;
|
|
|
|
}
|
2015-02-23 18:43:37 +08:00
|
|
|
|
|
|
|
if (lock_flags & XFS_MMAPLOCK_EXCL) {
|
2021-04-13 00:56:24 +08:00
|
|
|
if (!down_write_trylock(&VFS_I(ip)->i_mapping->invalidate_lock))
|
2015-02-23 18:43:37 +08:00
|
|
|
goto out_undo_iolock;
|
|
|
|
} else if (lock_flags & XFS_MMAPLOCK_SHARED) {
|
2021-04-13 00:56:24 +08:00
|
|
|
if (!down_read_trylock(&VFS_I(ip)->i_mapping->invalidate_lock))
|
2015-02-23 18:43:37 +08:00
|
|
|
goto out_undo_iolock;
|
|
|
|
}
|
|
|
|
|
2012-10-08 18:56:10 +08:00
|
|
|
if (lock_flags & XFS_ILOCK_EXCL) {
|
|
|
|
if (!mrtryupdate(&ip->i_lock))
|
2015-02-23 18:43:37 +08:00
|
|
|
goto out_undo_mmaplock;
|
2012-10-08 18:56:10 +08:00
|
|
|
} else if (lock_flags & XFS_ILOCK_SHARED) {
|
|
|
|
if (!mrtryaccess(&ip->i_lock))
|
2015-02-23 18:43:37 +08:00
|
|
|
goto out_undo_mmaplock;
|
2012-10-08 18:56:10 +08:00
|
|
|
}
|
|
|
|
return 1;
|
|
|
|
|
2015-02-23 18:43:37 +08:00
|
|
|
out_undo_mmaplock:
|
|
|
|
if (lock_flags & XFS_MMAPLOCK_EXCL)
|
2021-04-13 00:56:24 +08:00
|
|
|
up_write(&VFS_I(ip)->i_mapping->invalidate_lock);
|
2015-02-23 18:43:37 +08:00
|
|
|
else if (lock_flags & XFS_MMAPLOCK_SHARED)
|
2021-04-13 00:56:24 +08:00
|
|
|
up_read(&VFS_I(ip)->i_mapping->invalidate_lock);
|
2015-02-23 18:43:37 +08:00
|
|
|
out_undo_iolock:
|
2012-10-08 18:56:10 +08:00
|
|
|
if (lock_flags & XFS_IOLOCK_EXCL)
|
2016-11-30 11:33:25 +08:00
|
|
|
up_write(&VFS_I(ip)->i_rwsem);
|
2012-10-08 18:56:10 +08:00
|
|
|
else if (lock_flags & XFS_IOLOCK_SHARED)
|
2016-11-30 11:33:25 +08:00
|
|
|
up_read(&VFS_I(ip)->i_rwsem);
|
2015-02-23 18:43:37 +08:00
|
|
|
out:
|
2012-10-08 18:56:10 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* xfs_iunlock() is used to drop the inode locks acquired with
|
|
|
|
* xfs_ilock() and xfs_ilock_nowait(). The caller must pass
|
|
|
|
* in the flags given to xfs_ilock() or xfs_ilock_nowait() so
|
|
|
|
* that we know which locks to drop.
|
|
|
|
*
|
|
|
|
* ip -- the inode being unlocked
|
|
|
|
* lock_flags -- this parameter indicates the inode's locks to be
|
|
|
|
* to be unlocked. See the comment for xfs_ilock() for a list
|
|
|
|
* of valid values for this parameter.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
xfs_iunlock(
|
|
|
|
xfs_inode_t *ip,
|
|
|
|
uint lock_flags)
|
|
|
|
{
|
2022-06-20 05:53:42 +08:00
|
|
|
xfs_lock_flags_assert(lock_flags);
|
2012-10-08 18:56:10 +08:00
|
|
|
|
|
|
|
if (lock_flags & XFS_IOLOCK_EXCL)
|
2016-11-30 11:33:25 +08:00
|
|
|
up_write(&VFS_I(ip)->i_rwsem);
|
2012-10-08 18:56:10 +08:00
|
|
|
else if (lock_flags & XFS_IOLOCK_SHARED)
|
2016-11-30 11:33:25 +08:00
|
|
|
up_read(&VFS_I(ip)->i_rwsem);
|
2012-10-08 18:56:10 +08:00
|
|
|
|
2015-02-23 18:43:37 +08:00
|
|
|
if (lock_flags & XFS_MMAPLOCK_EXCL)
|
2021-04-13 00:56:24 +08:00
|
|
|
up_write(&VFS_I(ip)->i_mapping->invalidate_lock);
|
2015-02-23 18:43:37 +08:00
|
|
|
else if (lock_flags & XFS_MMAPLOCK_SHARED)
|
2021-04-13 00:56:24 +08:00
|
|
|
up_read(&VFS_I(ip)->i_mapping->invalidate_lock);
|
2015-02-23 18:43:37 +08:00
|
|
|
|
2012-10-08 18:56:10 +08:00
|
|
|
if (lock_flags & XFS_ILOCK_EXCL)
|
|
|
|
mrunlock_excl(&ip->i_lock);
|
|
|
|
else if (lock_flags & XFS_ILOCK_SHARED)
|
|
|
|
mrunlock_shared(&ip->i_lock);
|
|
|
|
|
|
|
|
trace_xfs_iunlock(ip, lock_flags, _RET_IP_);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* give up write locks. the i/o lock cannot be held nested
|
|
|
|
* if it is being demoted.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
xfs_ilock_demote(
|
|
|
|
xfs_inode_t *ip,
|
|
|
|
uint lock_flags)
|
|
|
|
{
|
2015-02-23 18:43:37 +08:00
|
|
|
ASSERT(lock_flags & (XFS_IOLOCK_EXCL|XFS_MMAPLOCK_EXCL|XFS_ILOCK_EXCL));
|
|
|
|
ASSERT((lock_flags &
|
|
|
|
~(XFS_IOLOCK_EXCL|XFS_MMAPLOCK_EXCL|XFS_ILOCK_EXCL)) == 0);
|
2012-10-08 18:56:10 +08:00
|
|
|
|
|
|
|
if (lock_flags & XFS_ILOCK_EXCL)
|
|
|
|
mrdemote(&ip->i_lock);
|
2015-02-23 18:43:37 +08:00
|
|
|
if (lock_flags & XFS_MMAPLOCK_EXCL)
|
2021-04-13 00:56:24 +08:00
|
|
|
downgrade_write(&VFS_I(ip)->i_mapping->invalidate_lock);
|
2012-10-08 18:56:10 +08:00
|
|
|
if (lock_flags & XFS_IOLOCK_EXCL)
|
2016-11-30 11:33:25 +08:00
|
|
|
downgrade_write(&VFS_I(ip)->i_rwsem);
|
2012-10-08 18:56:10 +08:00
|
|
|
|
|
|
|
trace_xfs_ilock_demote(ip, lock_flags, _RET_IP_);
|
|
|
|
}
|
|
|
|
|
2013-04-30 19:39:34 +08:00
|
|
|
#if defined(DEBUG) || defined(XFS_WARN)
|
2020-10-16 10:10:02 +08:00
|
|
|
static inline bool
|
|
|
|
__xfs_rwsem_islocked(
|
|
|
|
struct rw_semaphore *rwsem,
|
|
|
|
bool shared)
|
|
|
|
{
|
|
|
|
if (!debug_locks)
|
|
|
|
return rwsem_is_locked(rwsem);
|
|
|
|
|
|
|
|
if (!shared)
|
|
|
|
return lockdep_is_held_type(rwsem, 0);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We are checking that the lock is held at least in shared
|
|
|
|
* mode but don't care that it might be held exclusively
|
|
|
|
* (i.e. shared | excl). Hence we check if the lock is held
|
|
|
|
* in any mode rather than an explicit shared mode.
|
|
|
|
*/
|
|
|
|
return lockdep_is_held_type(rwsem, -1);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool
|
2012-10-08 18:56:10 +08:00
|
|
|
xfs_isilocked(
|
2020-10-16 10:10:02 +08:00
|
|
|
struct xfs_inode *ip,
|
2012-10-08 18:56:10 +08:00
|
|
|
uint lock_flags)
|
|
|
|
{
|
|
|
|
if (lock_flags & (XFS_ILOCK_EXCL|XFS_ILOCK_SHARED)) {
|
|
|
|
if (!(lock_flags & XFS_ILOCK_SHARED))
|
|
|
|
return !!ip->i_lock.mr_writer;
|
|
|
|
return rwsem_is_locked(&ip->i_lock.mr_lock);
|
|
|
|
}
|
|
|
|
|
2015-02-23 18:43:37 +08:00
|
|
|
if (lock_flags & (XFS_MMAPLOCK_EXCL|XFS_MMAPLOCK_SHARED)) {
|
2022-06-20 05:53:43 +08:00
|
|
|
return __xfs_rwsem_islocked(&VFS_I(ip)->i_mapping->invalidate_lock,
|
|
|
|
(lock_flags & XFS_MMAPLOCK_SHARED));
|
2015-02-23 18:43:37 +08:00
|
|
|
}
|
|
|
|
|
2020-10-16 10:10:02 +08:00
|
|
|
if (lock_flags & (XFS_IOLOCK_EXCL | XFS_IOLOCK_SHARED)) {
|
|
|
|
return __xfs_rwsem_islocked(&VFS_I(ip)->i_rwsem,
|
|
|
|
(lock_flags & XFS_IOLOCK_SHARED));
|
2012-10-08 18:56:10 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
ASSERT(0);
|
2020-10-16 10:10:02 +08:00
|
|
|
return false;
|
2012-10-08 18:56:10 +08:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2015-08-25 08:05:13 +08:00
|
|
|
/*
|
|
|
|
* xfs_lockdep_subclass_ok() is only used in an ASSERT, so is only called when
|
|
|
|
* DEBUG or XFS_WARN is set. And MAX_LOCKDEP_SUBCLASSES is then only defined
|
|
|
|
* when CONFIG_LOCKDEP is set. Hence the complex define below to avoid build
|
|
|
|
* errors and warnings.
|
|
|
|
*/
|
|
|
|
#if (defined(DEBUG) || defined(XFS_WARN)) && defined(CONFIG_LOCKDEP)
|
2015-08-20 07:27:49 +08:00
|
|
|
static bool
|
|
|
|
xfs_lockdep_subclass_ok(
|
|
|
|
int subclass)
|
|
|
|
{
|
|
|
|
return subclass < MAX_LOCKDEP_SUBCLASSES;
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
#define xfs_lockdep_subclass_ok(subclass) (true)
|
|
|
|
#endif
|
|
|
|
|
2013-08-12 18:49:45 +08:00
|
|
|
/*
|
2015-02-23 18:43:37 +08:00
|
|
|
* Bump the subclass so xfs_lock_inodes() acquires each lock with a different
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
* value. This can be called for any type of inode lock combination, including
|
|
|
|
* parent locking. Care must be taken to ensure we don't overrun the subclass
|
|
|
|
* storage fields in the class mask we build.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
2022-04-21 08:47:16 +08:00
|
|
|
static inline uint
|
|
|
|
xfs_lock_inumorder(
|
|
|
|
uint lock_mode,
|
|
|
|
uint subclass)
|
2013-08-12 18:49:45 +08:00
|
|
|
{
|
2022-04-21 08:47:16 +08:00
|
|
|
uint class = 0;
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
|
|
|
|
ASSERT(!(lock_mode & (XFS_ILOCK_PARENT | XFS_ILOCK_RTBITMAP |
|
|
|
|
XFS_ILOCK_RTSUM)));
|
2015-08-20 07:27:49 +08:00
|
|
|
ASSERT(xfs_lockdep_subclass_ok(subclass));
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
|
2015-02-23 18:43:37 +08:00
|
|
|
if (lock_mode & (XFS_IOLOCK_SHARED|XFS_IOLOCK_EXCL)) {
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
ASSERT(subclass <= XFS_IOLOCK_MAX_SUBCLASS);
|
|
|
|
class += subclass << XFS_IOLOCK_SHIFT;
|
2015-02-23 18:43:37 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (lock_mode & (XFS_MMAPLOCK_SHARED|XFS_MMAPLOCK_EXCL)) {
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
ASSERT(subclass <= XFS_MMAPLOCK_MAX_SUBCLASS);
|
|
|
|
class += subclass << XFS_MMAPLOCK_SHIFT;
|
2015-02-23 18:43:37 +08:00
|
|
|
}
|
|
|
|
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
if (lock_mode & (XFS_ILOCK_SHARED|XFS_ILOCK_EXCL)) {
|
|
|
|
ASSERT(subclass <= XFS_ILOCK_MAX_SUBCLASS);
|
|
|
|
class += subclass << XFS_ILOCK_SHIFT;
|
|
|
|
}
|
2013-08-12 18:49:45 +08:00
|
|
|
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
return (lock_mode & ~XFS_LOCK_SUBCLASS_MASK) | class;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2015-03-25 11:03:32 +08:00
|
|
|
* The following routine will lock n inodes in exclusive mode. We assume the
|
|
|
|
* caller calls us with the inodes in i_ino order.
|
2013-08-12 18:49:45 +08:00
|
|
|
*
|
2015-03-25 11:03:32 +08:00
|
|
|
* We need to detect deadlock where an inode that we lock is in the AIL and we
|
|
|
|
* start waiting for another inode that is locked by a thread in a long running
|
|
|
|
* transaction (such as truncate). This can result in deadlock since the long
|
|
|
|
* running trans might need to wait for the inode we just locked in order to
|
|
|
|
* push the tail and free space in the log.
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
*
|
|
|
|
* xfs_lock_inodes() can only be used to lock one type of lock at a time -
|
|
|
|
* the iolock, the mmaplock or the ilock, but not more than one at a time. If we
|
|
|
|
* lock more than one at a time, lockdep will report false positives saying we
|
|
|
|
* have violated locking orders.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
2016-06-01 15:38:15 +08:00
|
|
|
static void
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_lock_inodes(
|
2019-06-29 10:27:33 +08:00
|
|
|
struct xfs_inode **ips,
|
|
|
|
int inodes,
|
|
|
|
uint lock_mode)
|
2013-08-12 18:49:45 +08:00
|
|
|
{
|
2022-04-21 08:47:16 +08:00
|
|
|
int attempts = 0;
|
|
|
|
uint i;
|
|
|
|
int j;
|
|
|
|
bool try_lock;
|
2019-06-29 10:27:33 +08:00
|
|
|
struct xfs_log_item *lp;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
/*
|
|
|
|
* Currently supports between 2 and 5 inodes with exclusive locking. We
|
|
|
|
* support an arbitrary depth of locking here, but absolute limits on
|
2020-08-05 23:49:58 +08:00
|
|
|
* inodes depend on the type of locking and the limits placed by
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
* lockdep annotations in xfs_lock_inumorder. These are all checked by
|
|
|
|
* the asserts.
|
|
|
|
*/
|
2015-03-25 11:03:32 +08:00
|
|
|
ASSERT(ips && inodes >= 2 && inodes <= 5);
|
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:32:49 +08:00
|
|
|
ASSERT(lock_mode & (XFS_IOLOCK_EXCL | XFS_MMAPLOCK_EXCL |
|
|
|
|
XFS_ILOCK_EXCL));
|
|
|
|
ASSERT(!(lock_mode & (XFS_IOLOCK_SHARED | XFS_MMAPLOCK_SHARED |
|
|
|
|
XFS_ILOCK_SHARED)));
|
|
|
|
ASSERT(!(lock_mode & XFS_MMAPLOCK_EXCL) ||
|
|
|
|
inodes <= XFS_MMAPLOCK_MAX_SUBCLASS + 1);
|
|
|
|
ASSERT(!(lock_mode & XFS_ILOCK_EXCL) ||
|
|
|
|
inodes <= XFS_ILOCK_MAX_SUBCLASS + 1);
|
|
|
|
|
|
|
|
if (lock_mode & XFS_IOLOCK_EXCL) {
|
|
|
|
ASSERT(!(lock_mode & (XFS_MMAPLOCK_EXCL | XFS_ILOCK_EXCL)));
|
|
|
|
} else if (lock_mode & XFS_MMAPLOCK_EXCL)
|
|
|
|
ASSERT(!(lock_mode & XFS_ILOCK_EXCL));
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
again:
|
2022-04-21 08:47:16 +08:00
|
|
|
try_lock = false;
|
|
|
|
i = 0;
|
2013-08-12 18:49:45 +08:00
|
|
|
for (; i < inodes; i++) {
|
|
|
|
ASSERT(ips[i]);
|
|
|
|
|
2015-03-25 11:03:32 +08:00
|
|
|
if (i && (ips[i] == ips[i - 1])) /* Already locked */
|
2013-08-12 18:49:45 +08:00
|
|
|
continue;
|
|
|
|
|
|
|
|
/*
|
2015-03-25 11:03:32 +08:00
|
|
|
* If try_lock is not set yet, make sure all locked inodes are
|
|
|
|
* not in the AIL. If any are, set try_lock to be used later.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
|
|
|
if (!try_lock) {
|
|
|
|
for (j = (i - 1); j >= 0 && !try_lock; j--) {
|
2019-06-29 10:27:33 +08:00
|
|
|
lp = &ips[j]->i_itemp->ili_item;
|
2018-05-09 22:47:34 +08:00
|
|
|
if (lp && test_bit(XFS_LI_IN_AIL, &lp->li_flags))
|
2022-04-21 08:47:16 +08:00
|
|
|
try_lock = true;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If any of the previous locks we have locked is in the AIL,
|
|
|
|
* we must TRY to get the second and subsequent locks. If
|
|
|
|
* we can't get any, we must release all we have
|
|
|
|
* and try again.
|
|
|
|
*/
|
2015-03-25 11:03:32 +08:00
|
|
|
if (!try_lock) {
|
|
|
|
xfs_ilock(ips[i], xfs_lock_inumorder(lock_mode, i));
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* try_lock means we have an inode locked that is in the AIL. */
|
|
|
|
ASSERT(i != 0);
|
|
|
|
if (xfs_ilock_nowait(ips[i], xfs_lock_inumorder(lock_mode, i)))
|
|
|
|
continue;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2015-03-25 11:03:32 +08:00
|
|
|
/*
|
|
|
|
* Unlock all previous guys and try again. xfs_iunlock will try
|
|
|
|
* to push the tail if the inode is in the AIL.
|
|
|
|
*/
|
|
|
|
attempts++;
|
|
|
|
for (j = i - 1; j >= 0; j--) {
|
2013-08-12 18:49:45 +08:00
|
|
|
/*
|
2015-03-25 11:03:32 +08:00
|
|
|
* Check to see if we've already unlocked this one. Not
|
|
|
|
* the first one going back, and the inode ptr is the
|
|
|
|
* same.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
2015-03-25 11:03:32 +08:00
|
|
|
if (j != (i - 1) && ips[j] == ips[j + 1])
|
|
|
|
continue;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2015-03-25 11:03:32 +08:00
|
|
|
xfs_iunlock(ips[j], lock_mode);
|
|
|
|
}
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2015-03-25 11:03:32 +08:00
|
|
|
if ((attempts % 5) == 0) {
|
|
|
|
delay(1); /* Don't just spin the CPU */
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
2015-03-25 11:03:32 +08:00
|
|
|
goto again;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2021-05-24 19:17:49 +08:00
|
|
|
* xfs_lock_two_inodes() can only be used to lock ilock. The iolock and
|
|
|
|
* mmaplock must be double-locked separately since we use i_rwsem and
|
|
|
|
* invalidate_lock for that. We now support taking one lock EXCL and the
|
|
|
|
* other SHARED.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
|
|
|
void
|
|
|
|
xfs_lock_two_inodes(
|
2018-01-27 07:27:33 +08:00
|
|
|
struct xfs_inode *ip0,
|
|
|
|
uint ip0_mode,
|
|
|
|
struct xfs_inode *ip1,
|
|
|
|
uint ip1_mode)
|
2013-08-12 18:49:45 +08:00
|
|
|
{
|
|
|
|
int attempts = 0;
|
2019-06-29 10:27:33 +08:00
|
|
|
struct xfs_log_item *lp;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2018-01-27 07:27:33 +08:00
|
|
|
ASSERT(hweight32(ip0_mode) == 1);
|
|
|
|
ASSERT(hweight32(ip1_mode) == 1);
|
|
|
|
ASSERT(!(ip0_mode & (XFS_IOLOCK_SHARED|XFS_IOLOCK_EXCL)));
|
|
|
|
ASSERT(!(ip1_mode & (XFS_IOLOCK_SHARED|XFS_IOLOCK_EXCL)));
|
2021-05-24 19:17:49 +08:00
|
|
|
ASSERT(!(ip0_mode & (XFS_MMAPLOCK_SHARED|XFS_MMAPLOCK_EXCL)));
|
|
|
|
ASSERT(!(ip1_mode & (XFS_MMAPLOCK_SHARED|XFS_MMAPLOCK_EXCL)));
|
2013-08-12 18:49:45 +08:00
|
|
|
ASSERT(ip0->i_ino != ip1->i_ino);
|
|
|
|
|
|
|
|
if (ip0->i_ino > ip1->i_ino) {
|
2021-10-30 02:29:36 +08:00
|
|
|
swap(ip0, ip1);
|
|
|
|
swap(ip0_mode, ip1_mode);
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
again:
|
2018-01-27 07:27:33 +08:00
|
|
|
xfs_ilock(ip0, xfs_lock_inumorder(ip0_mode, 0));
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the first lock we have locked is in the AIL, we must TRY to get
|
|
|
|
* the second lock. If we can't get it, we must release the first one
|
|
|
|
* and try again.
|
|
|
|
*/
|
2019-06-29 10:27:33 +08:00
|
|
|
lp = &ip0->i_itemp->ili_item;
|
2018-05-09 22:47:34 +08:00
|
|
|
if (lp && test_bit(XFS_LI_IN_AIL, &lp->li_flags)) {
|
2018-01-27 07:27:33 +08:00
|
|
|
if (!xfs_ilock_nowait(ip1, xfs_lock_inumorder(ip1_mode, 1))) {
|
|
|
|
xfs_iunlock(ip0, ip0_mode);
|
2013-08-12 18:49:45 +08:00
|
|
|
if ((++attempts % 5) == 0)
|
|
|
|
delay(1); /* Don't just spin the CPU */
|
|
|
|
goto again;
|
|
|
|
}
|
|
|
|
} else {
|
2018-01-27 07:27:33 +08:00
|
|
|
xfs_ilock(ip1, xfs_lock_inumorder(ip1_mode, 1));
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-03-30 02:11:46 +08:00
|
|
|
uint
|
|
|
|
xfs_ip2xflags(
|
|
|
|
struct xfs_inode *ip)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
uint flags = 0;
|
|
|
|
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_ANY) {
|
|
|
|
if (ip->i_diflags & XFS_DIFLAG_REALTIME)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_REALTIME;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_PREALLOC)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_PREALLOC;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_IMMUTABLE)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_IMMUTABLE;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_APPEND)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_APPEND;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_SYNC)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_SYNC;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_NOATIME)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_NOATIME;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_NODUMP)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_NODUMP;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_RTINHERIT)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_RTINHERIT;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_PROJINHERIT)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_PROJINHERIT;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_NOSYMLINKS)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_NOSYMLINKS;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_EXTSIZE)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_EXTSIZE;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_EXTSZINHERIT)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_EXTSZINHERIT;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_NODEFRAG)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_NODEFRAG;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags & XFS_DIFLAG_FILESTREAM)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_FILESTREAM;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags2 & XFS_DIFLAG2_ANY) {
|
|
|
|
if (ip->i_diflags2 & XFS_DIFLAG2_DAX)
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_DAX;
|
2021-03-30 02:11:46 +08:00
|
|
|
if (ip->i_diflags2 & XFS_DIFLAG2_COWEXTSIZE)
|
2016-10-04 00:11:43 +08:00
|
|
|
flags |= FS_XFLAG_COWEXTSIZE;
|
2016-01-04 13:44:15 +08:00
|
|
|
}
|
|
|
|
|
2022-07-10 01:56:06 +08:00
|
|
|
if (xfs_inode_has_attr_fork(ip))
|
2016-01-04 13:44:15 +08:00
|
|
|
flags |= FS_XFLAG_HASATTR;
|
2005-04-17 06:20:36 +08:00
|
|
|
return flags;
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:45 +08:00
|
|
|
/*
|
|
|
|
* Lookups up an inode from "name". If ci_name is not NULL, then a CI match
|
|
|
|
* is allowed, otherwise it has to be an exact match. If a CI match is found,
|
|
|
|
* ci_name->name will point to a the actual name (caller must free) or
|
|
|
|
* will be set to NULL if an exact match is found.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_lookup(
|
2022-03-10 02:16:09 +08:00
|
|
|
struct xfs_inode *dp,
|
|
|
|
const struct xfs_name *name,
|
|
|
|
struct xfs_inode **ipp,
|
2013-08-12 18:49:45 +08:00
|
|
|
struct xfs_name *ci_name)
|
|
|
|
{
|
|
|
|
xfs_ino_t inum;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
trace_xfs_lookup(dp, name);
|
|
|
|
|
2021-08-19 09:46:53 +08:00
|
|
|
if (xfs_is_shutdown(dp->i_mount))
|
2014-06-25 12:58:08 +08:00
|
|
|
return -EIO;
|
2023-12-16 02:03:35 +08:00
|
|
|
if (xfs_ifork_zapped(dp, XFS_DATA_FORK))
|
|
|
|
return -EIO;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
error = xfs_dir_lookup(NULL, dp, name, &inum, ci_name);
|
|
|
|
if (error)
|
xfs: stop holding ILOCK over filldir callbacks
The recent change to the readdir locking made in 40194ec ("xfs:
reinstate the ilock in xfs_readdir") for CXFS directory sanity was
probably the wrong thing to do. Deep in the readdir code we
can take page faults in the filldir callback, and so taking a page
fault while holding an inode ilock creates a new set of locking
issues that lockdep warns all over the place about.
The locking order for regular inodes w.r.t. page faults is io_lock
-> pagefault -> mmap_sem -> ilock. The directory readdir code now
triggers ilock -> page fault -> mmap_sem. While we cannot deadlock
at this point, it inverts all the locking patterns that lockdep
normally sees on XFS inodes, and so triggers lockdep. We worked
around this with commit 93a8614 ("xfs: fix directory inode iolock
lockdep false positive"), but that then just moved the lockdep
warning to deeper in the page fault path and triggered on security
inode locks. Fixing the shmem issue there just moved the lockdep
reports somewhere else, and now we are getting false positives from
filesystem freezing annotations getting confused.
Further, if we enter memory reclaim in a readdir path, we now get
lockdep warning about potential deadlocks because the ilock is held
when we enter reclaim. This, again, is different to a regular file
in that we never allow memory reclaim to run while holding the ilock
for regular files. Hence lockdep now throws
ilock->kmalloc->reclaim->ilock warnings.
Basically, the problem is that the ilock is being used to protect
the directory data and the inode metadata, whereas for a regular
file the iolock protects the data and the ilock protects the
metadata. From the VFS perspective, the i_mutex serialises all
accesses to the directory data, and so not holding the ilock for
readdir doesn't matter. The issue is that CXFS doesn't access
directory data via the VFS, so it has no "data serialisaton"
mechanism. Hence we need to hold the IOLOCK in the correct places to
provide this low level directory data access serialisation.
The ilock can then be used just when the extent list needs to be
read, just like we do for regular files. The directory modification
code can take the iolock exclusive when the ilock is also taken,
and this then ensures that readdir is correct excluded while
modifications are in progress.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:33:00 +08:00
|
|
|
goto out_unlock;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
error = xfs_iget(dp->i_mount, NULL, inum, 0, 0, ipp);
|
|
|
|
if (error)
|
|
|
|
goto out_free_name;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_free_name:
|
|
|
|
if (ci_name)
|
|
|
|
kmem_free(ci_name->name);
|
xfs: stop holding ILOCK over filldir callbacks
The recent change to the readdir locking made in 40194ec ("xfs:
reinstate the ilock in xfs_readdir") for CXFS directory sanity was
probably the wrong thing to do. Deep in the readdir code we
can take page faults in the filldir callback, and so taking a page
fault while holding an inode ilock creates a new set of locking
issues that lockdep warns all over the place about.
The locking order for regular inodes w.r.t. page faults is io_lock
-> pagefault -> mmap_sem -> ilock. The directory readdir code now
triggers ilock -> page fault -> mmap_sem. While we cannot deadlock
at this point, it inverts all the locking patterns that lockdep
normally sees on XFS inodes, and so triggers lockdep. We worked
around this with commit 93a8614 ("xfs: fix directory inode iolock
lockdep false positive"), but that then just moved the lockdep
warning to deeper in the page fault path and triggered on security
inode locks. Fixing the shmem issue there just moved the lockdep
reports somewhere else, and now we are getting false positives from
filesystem freezing annotations getting confused.
Further, if we enter memory reclaim in a readdir path, we now get
lockdep warning about potential deadlocks because the ilock is held
when we enter reclaim. This, again, is different to a regular file
in that we never allow memory reclaim to run while holding the ilock
for regular files. Hence lockdep now throws
ilock->kmalloc->reclaim->ilock warnings.
Basically, the problem is that the ilock is being used to protect
the directory data and the inode metadata, whereas for a regular
file the iolock protects the data and the ilock protects the
metadata. From the VFS perspective, the i_mutex serialises all
accesses to the directory data, and so not holding the ilock for
readdir doesn't matter. The issue is that CXFS doesn't access
directory data via the VFS, so it has no "data serialisaton"
mechanism. Hence we need to hold the IOLOCK in the correct places to
provide this low level directory data access serialisation.
The ilock can then be used just when the extent list needs to be
read, just like we do for regular files. The directory modification
code can take the iolock exclusive when the ilock is also taken,
and this then ensures that readdir is correct excluded while
modifications are in progress.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 08:33:00 +08:00
|
|
|
out_unlock:
|
2013-08-12 18:49:45 +08:00
|
|
|
*ipp = NULL;
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2020-09-14 01:16:40 +08:00
|
|
|
/* Propagate di_flags from a parent inode to a child inode. */
|
|
|
|
static void
|
|
|
|
xfs_inode_inherit_flags(
|
|
|
|
struct xfs_inode *ip,
|
|
|
|
const struct xfs_inode *pip)
|
|
|
|
{
|
|
|
|
unsigned int di_flags = 0;
|
xfs: validate extsz hints against rt extent size when rtinherit is set
The RTINHERIT bit can be set on a directory so that newly created
regular files will have the REALTIME bit set to store their data on the
realtime volume. If an extent size hint (and EXTSZINHERIT) are set on
the directory, the hint will also be copied into the new file.
As pointed out in previous patches, for realtime files we require the
extent size hint be an integer multiple of the realtime extent, but we
don't perform the same validation on a directory with both RTINHERIT and
EXTSZINHERIT set, even though the only use-case of that combination is
to propagate extent size hints into new realtime files. This leads to
inode corruption errors when the bad values are propagated.
Because there may be existing filesystems with such a configuration, we
cannot simply amend the inode verifier to trip on these directories and
call it a day because that will cause previously "working" filesystems
to start throwing errors abruptly. Note that it's valid to have
directories with rtinherit set even if there is no realtime volume, in
which case the problem does not manifest because rtinherit is ignored if
there's no realtime device; and it's possible that someone set the flag,
crashed, repaired the filesystem (which clears the hint on the realtime
file) and continued.
Therefore, mitigate this issue in several ways: First, if we try to
write out an inode with both rtinherit/extszinherit set and an unaligned
extent size hint, turn off the hint to correct the error. Second, if
someone tries to misconfigure a directory via the fssetxattr ioctl, fail
the ioctl. Third, reverify both extent size hint values when we
propagate heritable inode attributes from parent to child, to prevent
misconfigurations from spreading.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
2021-05-13 03:51:26 +08:00
|
|
|
xfs_failaddr_t failaddr;
|
2020-09-14 01:16:40 +08:00
|
|
|
umode_t mode = VFS_I(ip)->i_mode;
|
|
|
|
|
|
|
|
if (S_ISDIR(mode)) {
|
2021-03-30 02:11:44 +08:00
|
|
|
if (pip->i_diflags & XFS_DIFLAG_RTINHERIT)
|
2020-09-14 01:16:40 +08:00
|
|
|
di_flags |= XFS_DIFLAG_RTINHERIT;
|
2021-03-30 02:11:44 +08:00
|
|
|
if (pip->i_diflags & XFS_DIFLAG_EXTSZINHERIT) {
|
2020-09-14 01:16:40 +08:00
|
|
|
di_flags |= XFS_DIFLAG_EXTSZINHERIT;
|
2021-03-30 02:11:41 +08:00
|
|
|
ip->i_extsize = pip->i_extsize;
|
2020-09-14 01:16:40 +08:00
|
|
|
}
|
2021-03-30 02:11:44 +08:00
|
|
|
if (pip->i_diflags & XFS_DIFLAG_PROJINHERIT)
|
2020-09-14 01:16:40 +08:00
|
|
|
di_flags |= XFS_DIFLAG_PROJINHERIT;
|
|
|
|
} else if (S_ISREG(mode)) {
|
2021-03-30 02:11:44 +08:00
|
|
|
if ((pip->i_diflags & XFS_DIFLAG_RTINHERIT) &&
|
2021-08-19 09:46:37 +08:00
|
|
|
xfs_has_realtime(ip->i_mount))
|
2020-09-14 01:16:40 +08:00
|
|
|
di_flags |= XFS_DIFLAG_REALTIME;
|
2021-03-30 02:11:44 +08:00
|
|
|
if (pip->i_diflags & XFS_DIFLAG_EXTSZINHERIT) {
|
2020-09-14 01:16:40 +08:00
|
|
|
di_flags |= XFS_DIFLAG_EXTSIZE;
|
2021-03-30 02:11:41 +08:00
|
|
|
ip->i_extsize = pip->i_extsize;
|
2020-09-14 01:16:40 +08:00
|
|
|
}
|
|
|
|
}
|
2021-03-30 02:11:44 +08:00
|
|
|
if ((pip->i_diflags & XFS_DIFLAG_NOATIME) &&
|
2020-09-14 01:16:40 +08:00
|
|
|
xfs_inherit_noatime)
|
|
|
|
di_flags |= XFS_DIFLAG_NOATIME;
|
2021-03-30 02:11:44 +08:00
|
|
|
if ((pip->i_diflags & XFS_DIFLAG_NODUMP) &&
|
2020-09-14 01:16:40 +08:00
|
|
|
xfs_inherit_nodump)
|
|
|
|
di_flags |= XFS_DIFLAG_NODUMP;
|
2021-03-30 02:11:44 +08:00
|
|
|
if ((pip->i_diflags & XFS_DIFLAG_SYNC) &&
|
2020-09-14 01:16:40 +08:00
|
|
|
xfs_inherit_sync)
|
|
|
|
di_flags |= XFS_DIFLAG_SYNC;
|
2021-03-30 02:11:44 +08:00
|
|
|
if ((pip->i_diflags & XFS_DIFLAG_NOSYMLINKS) &&
|
2020-09-14 01:16:40 +08:00
|
|
|
xfs_inherit_nosymlinks)
|
|
|
|
di_flags |= XFS_DIFLAG_NOSYMLINKS;
|
2021-03-30 02:11:44 +08:00
|
|
|
if ((pip->i_diflags & XFS_DIFLAG_NODEFRAG) &&
|
2020-09-14 01:16:40 +08:00
|
|
|
xfs_inherit_nodefrag)
|
|
|
|
di_flags |= XFS_DIFLAG_NODEFRAG;
|
2021-03-30 02:11:44 +08:00
|
|
|
if (pip->i_diflags & XFS_DIFLAG_FILESTREAM)
|
2020-09-14 01:16:40 +08:00
|
|
|
di_flags |= XFS_DIFLAG_FILESTREAM;
|
|
|
|
|
2021-03-30 02:11:44 +08:00
|
|
|
ip->i_diflags |= di_flags;
|
xfs: validate extsz hints against rt extent size when rtinherit is set
The RTINHERIT bit can be set on a directory so that newly created
regular files will have the REALTIME bit set to store their data on the
realtime volume. If an extent size hint (and EXTSZINHERIT) are set on
the directory, the hint will also be copied into the new file.
As pointed out in previous patches, for realtime files we require the
extent size hint be an integer multiple of the realtime extent, but we
don't perform the same validation on a directory with both RTINHERIT and
EXTSZINHERIT set, even though the only use-case of that combination is
to propagate extent size hints into new realtime files. This leads to
inode corruption errors when the bad values are propagated.
Because there may be existing filesystems with such a configuration, we
cannot simply amend the inode verifier to trip on these directories and
call it a day because that will cause previously "working" filesystems
to start throwing errors abruptly. Note that it's valid to have
directories with rtinherit set even if there is no realtime volume, in
which case the problem does not manifest because rtinherit is ignored if
there's no realtime device; and it's possible that someone set the flag,
crashed, repaired the filesystem (which clears the hint on the realtime
file) and continued.
Therefore, mitigate this issue in several ways: First, if we try to
write out an inode with both rtinherit/extszinherit set and an unaligned
extent size hint, turn off the hint to correct the error. Second, if
someone tries to misconfigure a directory via the fssetxattr ioctl, fail
the ioctl. Third, reverify both extent size hint values when we
propagate heritable inode attributes from parent to child, to prevent
misconfigurations from spreading.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
2021-05-13 03:51:26 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Inode verifiers on older kernels only check that the extent size
|
|
|
|
* hint is an integer multiple of the rt extent size on realtime files.
|
|
|
|
* They did not check the hint alignment on a directory with both
|
|
|
|
* rtinherit and extszinherit flags set. If the misaligned hint is
|
|
|
|
* propagated from a directory into a new realtime file, new file
|
|
|
|
* allocations will fail due to math errors in the rt allocator and/or
|
|
|
|
* trip the verifiers. Validate the hint settings in the new file so
|
|
|
|
* that we don't let broken hints propagate.
|
|
|
|
*/
|
|
|
|
failaddr = xfs_inode_validate_extsize(ip->i_mount, ip->i_extsize,
|
|
|
|
VFS_I(ip)->i_mode, ip->i_diflags);
|
|
|
|
if (failaddr) {
|
|
|
|
ip->i_diflags &= ~(XFS_DIFLAG_EXTSIZE |
|
|
|
|
XFS_DIFLAG_EXTSZINHERIT);
|
|
|
|
ip->i_extsize = 0;
|
|
|
|
}
|
2020-09-14 01:16:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Propagate di_flags2 from a parent inode to a child inode. */
|
|
|
|
static void
|
|
|
|
xfs_inode_inherit_flags2(
|
|
|
|
struct xfs_inode *ip,
|
|
|
|
const struct xfs_inode *pip)
|
|
|
|
{
|
xfs: validate extsz hints against rt extent size when rtinherit is set
The RTINHERIT bit can be set on a directory so that newly created
regular files will have the REALTIME bit set to store their data on the
realtime volume. If an extent size hint (and EXTSZINHERIT) are set on
the directory, the hint will also be copied into the new file.
As pointed out in previous patches, for realtime files we require the
extent size hint be an integer multiple of the realtime extent, but we
don't perform the same validation on a directory with both RTINHERIT and
EXTSZINHERIT set, even though the only use-case of that combination is
to propagate extent size hints into new realtime files. This leads to
inode corruption errors when the bad values are propagated.
Because there may be existing filesystems with such a configuration, we
cannot simply amend the inode verifier to trip on these directories and
call it a day because that will cause previously "working" filesystems
to start throwing errors abruptly. Note that it's valid to have
directories with rtinherit set even if there is no realtime volume, in
which case the problem does not manifest because rtinherit is ignored if
there's no realtime device; and it's possible that someone set the flag,
crashed, repaired the filesystem (which clears the hint on the realtime
file) and continued.
Therefore, mitigate this issue in several ways: First, if we try to
write out an inode with both rtinherit/extszinherit set and an unaligned
extent size hint, turn off the hint to correct the error. Second, if
someone tries to misconfigure a directory via the fssetxattr ioctl, fail
the ioctl. Third, reverify both extent size hint values when we
propagate heritable inode attributes from parent to child, to prevent
misconfigurations from spreading.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
2021-05-13 03:51:26 +08:00
|
|
|
xfs_failaddr_t failaddr;
|
|
|
|
|
2021-03-30 02:11:45 +08:00
|
|
|
if (pip->i_diflags2 & XFS_DIFLAG2_COWEXTSIZE) {
|
|
|
|
ip->i_diflags2 |= XFS_DIFLAG2_COWEXTSIZE;
|
2021-03-30 02:11:42 +08:00
|
|
|
ip->i_cowextsize = pip->i_cowextsize;
|
2020-09-14 01:16:40 +08:00
|
|
|
}
|
2021-03-30 02:11:45 +08:00
|
|
|
if (pip->i_diflags2 & XFS_DIFLAG2_DAX)
|
|
|
|
ip->i_diflags2 |= XFS_DIFLAG2_DAX;
|
xfs: validate extsz hints against rt extent size when rtinherit is set
The RTINHERIT bit can be set on a directory so that newly created
regular files will have the REALTIME bit set to store their data on the
realtime volume. If an extent size hint (and EXTSZINHERIT) are set on
the directory, the hint will also be copied into the new file.
As pointed out in previous patches, for realtime files we require the
extent size hint be an integer multiple of the realtime extent, but we
don't perform the same validation on a directory with both RTINHERIT and
EXTSZINHERIT set, even though the only use-case of that combination is
to propagate extent size hints into new realtime files. This leads to
inode corruption errors when the bad values are propagated.
Because there may be existing filesystems with such a configuration, we
cannot simply amend the inode verifier to trip on these directories and
call it a day because that will cause previously "working" filesystems
to start throwing errors abruptly. Note that it's valid to have
directories with rtinherit set even if there is no realtime volume, in
which case the problem does not manifest because rtinherit is ignored if
there's no realtime device; and it's possible that someone set the flag,
crashed, repaired the filesystem (which clears the hint on the realtime
file) and continued.
Therefore, mitigate this issue in several ways: First, if we try to
write out an inode with both rtinherit/extszinherit set and an unaligned
extent size hint, turn off the hint to correct the error. Second, if
someone tries to misconfigure a directory via the fssetxattr ioctl, fail
the ioctl. Third, reverify both extent size hint values when we
propagate heritable inode attributes from parent to child, to prevent
misconfigurations from spreading.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
2021-05-13 03:51:26 +08:00
|
|
|
|
|
|
|
/* Don't let invalid cowextsize hints propagate. */
|
|
|
|
failaddr = xfs_inode_validate_cowextsize(ip->i_mount, ip->i_cowextsize,
|
|
|
|
VFS_I(ip)->i_mode, ip->i_diflags, ip->i_diflags2);
|
|
|
|
if (failaddr) {
|
|
|
|
ip->i_diflags2 &= ~XFS_DIFLAG2_COWEXTSIZE;
|
|
|
|
ip->i_cowextsize = 0;
|
|
|
|
}
|
2020-09-14 01:16:40 +08:00
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2020-12-10 02:05:15 +08:00
|
|
|
* Initialise a newly allocated inode and return the in-core inode to the
|
|
|
|
* caller locked exclusively.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2021-06-02 08:48:24 +08:00
|
|
|
int
|
2020-12-10 02:05:15 +08:00
|
|
|
xfs_init_new_inode(
|
2023-01-13 19:49:25 +08:00
|
|
|
struct mnt_idmap *idmap,
|
2020-12-10 02:05:15 +08:00
|
|
|
struct xfs_trans *tp,
|
|
|
|
struct xfs_inode *pip,
|
|
|
|
xfs_ino_t ino,
|
|
|
|
umode_t mode,
|
|
|
|
xfs_nlink_t nlink,
|
|
|
|
dev_t rdev,
|
|
|
|
prid_t prid,
|
xfs: initialise attr fork on inode create
When we allocate a new inode, we often need to add an attribute to
the inode as part of the create. This can happen as a result of
needing to add default ACLs or security labels before the inode is
made visible to userspace.
This is highly inefficient right now. We do the create transaction
to allocate the inode, then we do an "add attr fork" transaction to
modify the just created empty inode to set the inode fork offset to
allow attributes to be stored, then we go and do the attribute
creation.
This means 3 transactions instead of 1 to allocate an inode, and
this greatly increases the load on the CIL commit code, resulting in
excessive contention on the CIL spin locks and performance
degradation:
18.99% [kernel] [k] __pv_queued_spin_lock_slowpath
3.57% [kernel] [k] do_raw_spin_lock
2.51% [kernel] [k] __raw_callee_save___pv_queued_spin_unlock
2.48% [kernel] [k] memcpy
2.34% [kernel] [k] xfs_log_commit_cil
The typical profile resulting from running fsmark on a selinux enabled
filesytem is adds this overhead to the create path:
- 15.30% xfs_init_security
- 15.23% security_inode_init_security
- 13.05% xfs_initxattrs
- 12.94% xfs_attr_set
- 6.75% xfs_bmap_add_attrfork
- 5.51% xfs_trans_commit
- 5.48% __xfs_trans_commit
- 5.35% xfs_log_commit_cil
- 3.86% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.70% xfs_trans_alloc
0.52% xfs_trans_reserve
- 5.41% xfs_attr_set_args
- 5.39% xfs_attr_set_shortform.constprop.0
- 4.46% xfs_trans_commit
- 4.46% __xfs_trans_commit
- 4.33% xfs_log_commit_cil
- 2.74% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
0.60% xfs_inode_item_format
0.90% xfs_attr_try_sf_addname
- 1.99% selinux_inode_init_security
- 1.02% security_sid_to_context_force
- 1.00% security_sid_to_context_core
- 0.92% sidtab_entry_to_string
- 0.90% sidtab_sid2str_get
0.59% sidtab_sid2str_put.part.0
- 0.82% selinux_determine_inode_label
- 0.77% security_transition_sid
0.70% security_compute_sid.part.0
And fsmark creation rate performance drops by ~25%. The key point to
note here is that half the additional overhead comes from adding the
attribute fork to the newly created inode. That's crazy, considering
we can do this same thing at inode create time with a couple of
lines of code and no extra overhead.
So, if we know we are going to add an attribute immediately after
creating the inode, let's just initialise the attribute fork inside
the create transaction and chop that whole chunk of code out of
the create fast path. This completely removes the performance
drop caused by enabling SELinux, and the profile looks like:
- 8.99% xfs_init_security
- 9.00% security_inode_init_security
- 6.43% xfs_initxattrs
- 6.37% xfs_attr_set
- 5.45% xfs_attr_set_args
- 5.42% xfs_attr_set_shortform.constprop.0
- 4.51% xfs_trans_commit
- 4.54% __xfs_trans_commit
- 4.59% xfs_log_commit_cil
- 2.67% _raw_spin_lock
- 3.28% do_raw_spin_lock
3.08% __pv_queued_spin_lock_slowpath
0.66% xfs_inode_item_format
- 0.90% xfs_attr_try_sf_addname
- 0.60% xfs_trans_alloc
- 2.35% selinux_inode_init_security
- 1.25% security_sid_to_context_force
- 1.21% security_sid_to_context_core
- 1.19% sidtab_entry_to_string
- 1.20% sidtab_sid2str_get
- 0.86% sidtab_sid2str_put.part.0
- 0.62% _raw_spin_lock_irqsave
- 0.77% do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.84% selinux_determine_inode_label
- 0.83% security_transition_sid
0.86% security_compute_sid.part.0
Which indicates the XFS overhead of creating the selinux xattr has
been halved. This doesn't fix the CIL lock contention problem, just
means it's not a limiting factor for this workload. Lock contention
in the security subsystems is going to be an issue soon, though...
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[djwong: fix compilation error when CONFIG_SECURITY=n]
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Gao Xiang <hsiangkao@redhat.com>
2021-03-23 00:52:03 +08:00
|
|
|
bool init_xattrs,
|
2020-12-10 02:05:15 +08:00
|
|
|
struct xfs_inode **ipp)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2021-01-23 08:48:18 +08:00
|
|
|
struct inode *dir = pip ? VFS_I(pip) : NULL;
|
2020-12-10 02:05:15 +08:00
|
|
|
struct xfs_mount *mp = tp->t_mountp;
|
|
|
|
struct xfs_inode *ip;
|
|
|
|
unsigned int flags;
|
|
|
|
int error;
|
|
|
|
struct timespec64 tv;
|
|
|
|
struct inode *inode;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2018-04-18 08:17:35 +08:00
|
|
|
/*
|
|
|
|
* Protect against obviously corrupt allocation btree records. Later
|
|
|
|
* xfs_iget checks will catch re-allocation of other active in-memory
|
|
|
|
* and on-disk inodes. If we don't catch reallocating the parent inode
|
|
|
|
* here we will deadlock in xfs_iget() so we have to do these checks
|
|
|
|
* first.
|
|
|
|
*/
|
|
|
|
if ((pip && ino == pip->i_ino) || !xfs_verify_dir_ino(mp, ino)) {
|
|
|
|
xfs_alert(mp, "Allocated a known in-use inode 0x%llx!", ino);
|
|
|
|
return -EFSCORRUPTED;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2020-12-10 02:05:15 +08:00
|
|
|
* Get the in-core inode with the lock held exclusively to prevent
|
|
|
|
* others from looking at until we're done.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2020-12-10 02:05:15 +08:00
|
|
|
error = xfs_iget(mp, tp, ino, XFS_IGET_CREATE, XFS_ILOCK_EXCL, &ip);
|
2008-10-30 14:36:14 +08:00
|
|
|
if (error)
|
2005-04-17 06:20:36 +08:00
|
|
|
return error;
|
2020-12-10 02:05:15 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
ASSERT(ip != NULL);
|
2016-02-09 13:54:58 +08:00
|
|
|
inode = VFS_I(ip);
|
2016-02-09 13:54:58 +08:00
|
|
|
set_nlink(inode, nlink);
|
2017-10-20 02:07:09 +08:00
|
|
|
inode->i_rdev = rdev;
|
2021-03-30 02:11:39 +08:00
|
|
|
ip->i_projid = prid;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2021-08-19 09:46:52 +08:00
|
|
|
if (dir && !(dir->i_mode & S_ISGID) && xfs_has_grpid(mp)) {
|
2023-01-13 19:49:31 +08:00
|
|
|
inode_fsuid_set(inode, idmap);
|
2021-01-23 08:48:18 +08:00
|
|
|
inode->i_gid = dir->i_gid;
|
|
|
|
inode->i_mode = mode;
|
2020-02-22 00:31:26 +08:00
|
|
|
} else {
|
2023-01-13 19:49:25 +08:00
|
|
|
inode_init_owner(idmap, inode, dir, mode);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the group ID of the new file does not match the effective group
|
|
|
|
* ID or one of the supplementary group IDs, the S_ISGID bit is cleared
|
|
|
|
* (and only if the irix_sgid_inherit compatibility variable is set).
|
|
|
|
*/
|
2022-09-19 04:54:14 +08:00
|
|
|
if (irix_sgid_inherit && (inode->i_mode & S_ISGID) &&
|
2023-01-13 19:49:30 +08:00
|
|
|
!vfsgid_in_group_p(i_gid_into_vfsgid(idmap, inode)))
|
2016-02-09 13:54:58 +08:00
|
|
|
inode->i_mode &= ~S_ISGID;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2021-03-30 02:11:40 +08:00
|
|
|
ip->i_disk_size = 0;
|
2020-05-19 01:27:22 +08:00
|
|
|
ip->i_df.if_nextents = 0;
|
2021-03-30 02:11:40 +08:00
|
|
|
ASSERT(ip->i_nblocks == 0);
|
2008-08-13 14:44:15 +08:00
|
|
|
|
2023-07-06 03:01:47 +08:00
|
|
|
tv = inode_set_ctime_current(inode);
|
2023-10-05 02:53:02 +08:00
|
|
|
inode_set_mtime_to_ts(inode, tv);
|
|
|
|
inode_set_atime_to_ts(inode, tv);
|
2008-08-13 14:44:15 +08:00
|
|
|
|
2021-03-30 02:11:41 +08:00
|
|
|
ip->i_extsize = 0;
|
2021-03-30 02:11:44 +08:00
|
|
|
ip->i_diflags = 0;
|
2013-04-03 13:11:17 +08:00
|
|
|
|
2021-08-19 09:46:37 +08:00
|
|
|
if (xfs_has_v3inodes(mp)) {
|
2017-12-11 19:35:19 +08:00
|
|
|
inode_set_iversion(inode, 1);
|
2021-03-30 02:11:42 +08:00
|
|
|
ip->i_cowextsize = 0;
|
2021-03-30 02:11:45 +08:00
|
|
|
ip->i_crtime = tv;
|
2013-04-03 13:11:17 +08:00
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
flags = XFS_ILOG_CORE;
|
|
|
|
switch (mode & S_IFMT) {
|
|
|
|
case S_IFIFO:
|
|
|
|
case S_IFCHR:
|
|
|
|
case S_IFBLK:
|
|
|
|
case S_IFSOCK:
|
2020-05-19 01:28:05 +08:00
|
|
|
ip->i_df.if_format = XFS_DINODE_FMT_DEV;
|
2005-04-17 06:20:36 +08:00
|
|
|
flags |= XFS_ILOG_DEV;
|
|
|
|
break;
|
|
|
|
case S_IFREG:
|
|
|
|
case S_IFDIR:
|
2021-03-30 02:11:44 +08:00
|
|
|
if (pip && (pip->i_diflags & XFS_DIFLAG_ANY))
|
2020-09-14 01:16:40 +08:00
|
|
|
xfs_inode_inherit_flags(ip, pip);
|
2021-03-30 02:11:45 +08:00
|
|
|
if (pip && (pip->i_diflags2 & XFS_DIFLAG2_ANY))
|
2020-09-14 01:16:40 +08:00
|
|
|
xfs_inode_inherit_flags2(ip, pip);
|
2021-04-21 06:54:36 +08:00
|
|
|
fallthrough;
|
2005-04-17 06:20:36 +08:00
|
|
|
case S_IFLNK:
|
2020-05-19 01:28:05 +08:00
|
|
|
ip->i_df.if_format = XFS_DINODE_FMT_EXTENTS;
|
2018-07-18 07:51:50 +08:00
|
|
|
ip->i_df.if_bytes = 0;
|
2023-12-20 14:34:55 +08:00
|
|
|
ip->i_df.if_data = NULL;
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
ASSERT(0);
|
|
|
|
}
|
|
|
|
|
xfs: initialise attr fork on inode create
When we allocate a new inode, we often need to add an attribute to
the inode as part of the create. This can happen as a result of
needing to add default ACLs or security labels before the inode is
made visible to userspace.
This is highly inefficient right now. We do the create transaction
to allocate the inode, then we do an "add attr fork" transaction to
modify the just created empty inode to set the inode fork offset to
allow attributes to be stored, then we go and do the attribute
creation.
This means 3 transactions instead of 1 to allocate an inode, and
this greatly increases the load on the CIL commit code, resulting in
excessive contention on the CIL spin locks and performance
degradation:
18.99% [kernel] [k] __pv_queued_spin_lock_slowpath
3.57% [kernel] [k] do_raw_spin_lock
2.51% [kernel] [k] __raw_callee_save___pv_queued_spin_unlock
2.48% [kernel] [k] memcpy
2.34% [kernel] [k] xfs_log_commit_cil
The typical profile resulting from running fsmark on a selinux enabled
filesytem is adds this overhead to the create path:
- 15.30% xfs_init_security
- 15.23% security_inode_init_security
- 13.05% xfs_initxattrs
- 12.94% xfs_attr_set
- 6.75% xfs_bmap_add_attrfork
- 5.51% xfs_trans_commit
- 5.48% __xfs_trans_commit
- 5.35% xfs_log_commit_cil
- 3.86% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.70% xfs_trans_alloc
0.52% xfs_trans_reserve
- 5.41% xfs_attr_set_args
- 5.39% xfs_attr_set_shortform.constprop.0
- 4.46% xfs_trans_commit
- 4.46% __xfs_trans_commit
- 4.33% xfs_log_commit_cil
- 2.74% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
0.60% xfs_inode_item_format
0.90% xfs_attr_try_sf_addname
- 1.99% selinux_inode_init_security
- 1.02% security_sid_to_context_force
- 1.00% security_sid_to_context_core
- 0.92% sidtab_entry_to_string
- 0.90% sidtab_sid2str_get
0.59% sidtab_sid2str_put.part.0
- 0.82% selinux_determine_inode_label
- 0.77% security_transition_sid
0.70% security_compute_sid.part.0
And fsmark creation rate performance drops by ~25%. The key point to
note here is that half the additional overhead comes from adding the
attribute fork to the newly created inode. That's crazy, considering
we can do this same thing at inode create time with a couple of
lines of code and no extra overhead.
So, if we know we are going to add an attribute immediately after
creating the inode, let's just initialise the attribute fork inside
the create transaction and chop that whole chunk of code out of
the create fast path. This completely removes the performance
drop caused by enabling SELinux, and the profile looks like:
- 8.99% xfs_init_security
- 9.00% security_inode_init_security
- 6.43% xfs_initxattrs
- 6.37% xfs_attr_set
- 5.45% xfs_attr_set_args
- 5.42% xfs_attr_set_shortform.constprop.0
- 4.51% xfs_trans_commit
- 4.54% __xfs_trans_commit
- 4.59% xfs_log_commit_cil
- 2.67% _raw_spin_lock
- 3.28% do_raw_spin_lock
3.08% __pv_queued_spin_lock_slowpath
0.66% xfs_inode_item_format
- 0.90% xfs_attr_try_sf_addname
- 0.60% xfs_trans_alloc
- 2.35% selinux_inode_init_security
- 1.25% security_sid_to_context_force
- 1.21% security_sid_to_context_core
- 1.19% sidtab_entry_to_string
- 1.20% sidtab_sid2str_get
- 0.86% sidtab_sid2str_put.part.0
- 0.62% _raw_spin_lock_irqsave
- 0.77% do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.84% selinux_determine_inode_label
- 0.83% security_transition_sid
0.86% security_compute_sid.part.0
Which indicates the XFS overhead of creating the selinux xattr has
been halved. This doesn't fix the CIL lock contention problem, just
means it's not a limiting factor for this workload. Lock contention
in the security subsystems is going to be an issue soon, though...
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[djwong: fix compilation error when CONFIG_SECURITY=n]
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Gao Xiang <hsiangkao@redhat.com>
2021-03-23 00:52:03 +08:00
|
|
|
/*
|
|
|
|
* If we need to create attributes immediately after allocating the
|
|
|
|
* inode, initialise an empty attribute fork right now. We use the
|
|
|
|
* default fork offset for attributes here as we don't know exactly what
|
|
|
|
* size or how many attributes we might be adding. We can do this
|
|
|
|
* safely here because we know the data fork is completely empty and
|
|
|
|
* this saves us from needing to run a separate transaction to set the
|
|
|
|
* fork offset in the immediate future.
|
|
|
|
*/
|
2021-08-19 09:46:37 +08:00
|
|
|
if (init_xattrs && xfs_has_attr(mp)) {
|
2021-03-30 02:11:44 +08:00
|
|
|
ip->i_forkoff = xfs_default_attroffset(ip) >> 3;
|
xfs: make inode attribute forks a permanent part of struct xfs_inode
Syzkaller reported a UAF bug a while back:
==================================================================
BUG: KASAN: use-after-free in xfs_ilock_attr_map_shared+0xe3/0xf6 fs/xfs/xfs_inode.c:127
Read of size 4 at addr ffff88802cec919c by task syz-executor262/2958
CPU: 2 PID: 2958 Comm: syz-executor262 Not tainted
5.15.0-0.30.3-20220406_1406 #3
Hardware name: Red Hat KVM, BIOS 1.13.0-2.module+el8.3.0+7860+a7792d29
04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x82/0xa9 lib/dump_stack.c:106
print_address_description.constprop.9+0x21/0x2d5 mm/kasan/report.c:256
__kasan_report mm/kasan/report.c:442 [inline]
kasan_report.cold.14+0x7f/0x11b mm/kasan/report.c:459
xfs_ilock_attr_map_shared+0xe3/0xf6 fs/xfs/xfs_inode.c:127
xfs_attr_get+0x378/0x4c2 fs/xfs/libxfs/xfs_attr.c:159
xfs_xattr_get+0xe3/0x150 fs/xfs/xfs_xattr.c:36
__vfs_getxattr+0xdf/0x13d fs/xattr.c:399
cap_inode_need_killpriv+0x41/0x5d security/commoncap.c:300
security_inode_need_killpriv+0x4c/0x97 security/security.c:1408
dentry_needs_remove_privs.part.28+0x21/0x63 fs/inode.c:1912
dentry_needs_remove_privs+0x80/0x9e fs/inode.c:1908
do_truncate+0xc3/0x1e0 fs/open.c:56
handle_truncate fs/namei.c:3084 [inline]
do_open fs/namei.c:3432 [inline]
path_openat+0x30ab/0x396d fs/namei.c:3561
do_filp_open+0x1c4/0x290 fs/namei.c:3588
do_sys_openat2+0x60d/0x98c fs/open.c:1212
do_sys_open+0xcf/0x13c fs/open.c:1228
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
RIP: 0033:0x7f7ef4bb753d
Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48
89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73
01 c3 48 8b 0d 1b 79 2c 00 f7 d8 64 89 01 48
RSP: 002b:00007f7ef52c2ed8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 0000000000404148 RCX: 00007f7ef4bb753d
RDX: 00007f7ef4bb753d RSI: 0000000000000000 RDI: 0000000020004fc0
RBP: 0000000000404140 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0030656c69662f2e
R13: 00007ffd794db37f R14: 00007ffd794db470 R15: 00007f7ef52c2fc0
</TASK>
Allocated by task 2953:
kasan_save_stack+0x19/0x38 mm/kasan/common.c:38
kasan_set_track mm/kasan/common.c:46 [inline]
set_alloc_info mm/kasan/common.c:434 [inline]
__kasan_slab_alloc+0x68/0x7c mm/kasan/common.c:467
kasan_slab_alloc include/linux/kasan.h:254 [inline]
slab_post_alloc_hook mm/slab.h:519 [inline]
slab_alloc_node mm/slub.c:3213 [inline]
slab_alloc mm/slub.c:3221 [inline]
kmem_cache_alloc+0x11b/0x3eb mm/slub.c:3226
kmem_cache_zalloc include/linux/slab.h:711 [inline]
xfs_ifork_alloc+0x25/0xa2 fs/xfs/libxfs/xfs_inode_fork.c:287
xfs_bmap_add_attrfork+0x3f2/0x9b1 fs/xfs/libxfs/xfs_bmap.c:1098
xfs_attr_set+0xe38/0x12a7 fs/xfs/libxfs/xfs_attr.c:746
xfs_xattr_set+0xeb/0x1a9 fs/xfs/xfs_xattr.c:59
__vfs_setxattr+0x11b/0x177 fs/xattr.c:180
__vfs_setxattr_noperm+0x128/0x5e0 fs/xattr.c:214
__vfs_setxattr_locked+0x1d4/0x258 fs/xattr.c:275
vfs_setxattr+0x154/0x33d fs/xattr.c:301
setxattr+0x216/0x29f fs/xattr.c:575
__do_sys_fsetxattr fs/xattr.c:632 [inline]
__se_sys_fsetxattr fs/xattr.c:621 [inline]
__x64_sys_fsetxattr+0x243/0x2fe fs/xattr.c:621
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
Freed by task 2949:
kasan_save_stack+0x19/0x38 mm/kasan/common.c:38
kasan_set_track+0x1c/0x21 mm/kasan/common.c:46
kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:360
____kasan_slab_free mm/kasan/common.c:366 [inline]
____kasan_slab_free mm/kasan/common.c:328 [inline]
__kasan_slab_free+0xe2/0x10e mm/kasan/common.c:374
kasan_slab_free include/linux/kasan.h:230 [inline]
slab_free_hook mm/slub.c:1700 [inline]
slab_free_freelist_hook mm/slub.c:1726 [inline]
slab_free mm/slub.c:3492 [inline]
kmem_cache_free+0xdc/0x3ce mm/slub.c:3508
xfs_attr_fork_remove+0x8d/0x132 fs/xfs/libxfs/xfs_attr_leaf.c:773
xfs_attr_sf_removename+0x5dd/0x6cb fs/xfs/libxfs/xfs_attr_leaf.c:822
xfs_attr_remove_iter+0x68c/0x805 fs/xfs/libxfs/xfs_attr.c:1413
xfs_attr_remove_args+0xb1/0x10d fs/xfs/libxfs/xfs_attr.c:684
xfs_attr_set+0xf1e/0x12a7 fs/xfs/libxfs/xfs_attr.c:802
xfs_xattr_set+0xeb/0x1a9 fs/xfs/xfs_xattr.c:59
__vfs_removexattr+0x106/0x16a fs/xattr.c:468
cap_inode_killpriv+0x24/0x47 security/commoncap.c:324
security_inode_killpriv+0x54/0xa1 security/security.c:1414
setattr_prepare+0x1a6/0x897 fs/attr.c:146
xfs_vn_change_ok+0x111/0x15e fs/xfs/xfs_iops.c:682
xfs_vn_setattr_size+0x5f/0x15a fs/xfs/xfs_iops.c:1065
xfs_vn_setattr+0x125/0x2ad fs/xfs/xfs_iops.c:1093
notify_change+0xae5/0x10a1 fs/attr.c:410
do_truncate+0x134/0x1e0 fs/open.c:64
handle_truncate fs/namei.c:3084 [inline]
do_open fs/namei.c:3432 [inline]
path_openat+0x30ab/0x396d fs/namei.c:3561
do_filp_open+0x1c4/0x290 fs/namei.c:3588
do_sys_openat2+0x60d/0x98c fs/open.c:1212
do_sys_open+0xcf/0x13c fs/open.c:1228
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
The buggy address belongs to the object at ffff88802cec9188
which belongs to the cache xfs_ifork of size 40
The buggy address is located 20 bytes inside of
40-byte region [ffff88802cec9188, ffff88802cec91b0)
The buggy address belongs to the page:
page:00000000c3af36a1 refcount:1 mapcount:0 mapping:0000000000000000
index:0x0 pfn:0x2cec9
flags: 0xfffffc0000200(slab|node=0|zone=1|lastcpupid=0x1fffff)
raw: 000fffffc0000200 ffffea00009d2580 0000000600000006 ffff88801a9ffc80
raw: 0000000000000000 0000000080490049 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff88802cec9080: fb fb fb fc fc fa fb fb fb fb fc fc fb fb fb fb
ffff88802cec9100: fb fc fc fb fb fb fb fb fc fc fb fb fb fb fb fc
>ffff88802cec9180: fc fa fb fb fb fb fc fc fa fb fb fb fb fc fc fb
^
ffff88802cec9200: fb fb fb fb fc fc fb fb fb fb fb fc fc fb fb fb
ffff88802cec9280: fb fb fc fc fa fb fb fb fb fc fc fa fb fb fb fb
==================================================================
The root cause of this bug is the unlocked access to xfs_inode.i_afp
from the getxattr code paths while trying to determine which ILOCK mode
to use to stabilize the xattr data. Unfortunately, the VFS does not
acquire i_rwsem when vfs_getxattr (or listxattr) call into the
filesystem, which means that getxattr can race with a removexattr that's
tearing down the attr fork and crash:
xfs_attr_set: xfs_attr_get:
xfs_attr_fork_remove: xfs_ilock_attr_map_shared:
xfs_idestroy_fork(ip->i_afp);
kmem_cache_free(xfs_ifork_cache, ip->i_afp);
if (ip->i_afp &&
ip->i_afp = NULL;
xfs_need_iread_extents(ip->i_afp))
<KABOOM>
ip->i_forkoff = 0;
Regrettably, the VFS is much more lax about i_rwsem and getxattr than
is immediately obvious -- not only does it not guarantee that we hold
i_rwsem, it actually doesn't guarantee that we *don't* hold it either.
The getxattr system call won't acquire the lock before calling XFS, but
the file capabilities code calls getxattr with and without i_rwsem held
to determine if the "security.capabilities" xattr is set on the file.
Fixing the VFS locking requires a treewide investigation into every code
path that could touch an xattr and what i_rwsem state it expects or sets
up. That could take years or even prove impossible; fortunately, we
can fix this UAF problem inside XFS.
An earlier version of this patch used smp_wmb in xfs_attr_fork_remove to
ensure that i_forkoff is always zeroed before i_afp is set to null and
changed the read paths to use smp_rmb before accessing i_forkoff and
i_afp, which avoided these UAF problems. However, the patch author was
too busy dealing with other problems in the meantime, and by the time he
came back to this issue, the situation had changed a bit.
On a modern system with selinux, each inode will always have at least
one xattr for the selinux label, so it doesn't make much sense to keep
incurring the extra pointer dereference. Furthermore, Allison's
upcoming parent pointer patchset will also cause nearly every inode in
the filesystem to have extended attributes. Therefore, make the inode
attribute fork structure part of struct xfs_inode, at a cost of 40 more
bytes.
This patch adds a clunky if_present field where necessary to maintain
the existing logic of xattr fork null pointer testing in the existing
codebase. The next patch switches the logic over to XFS_IFORK_Q and it
all goes away.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
2022-07-10 01:56:06 +08:00
|
|
|
xfs_ifork_init_attr(ip, XFS_DINODE_FMT_EXTENTS, 0);
|
xfs: initialise attr fork on inode create
When we allocate a new inode, we often need to add an attribute to
the inode as part of the create. This can happen as a result of
needing to add default ACLs or security labels before the inode is
made visible to userspace.
This is highly inefficient right now. We do the create transaction
to allocate the inode, then we do an "add attr fork" transaction to
modify the just created empty inode to set the inode fork offset to
allow attributes to be stored, then we go and do the attribute
creation.
This means 3 transactions instead of 1 to allocate an inode, and
this greatly increases the load on the CIL commit code, resulting in
excessive contention on the CIL spin locks and performance
degradation:
18.99% [kernel] [k] __pv_queued_spin_lock_slowpath
3.57% [kernel] [k] do_raw_spin_lock
2.51% [kernel] [k] __raw_callee_save___pv_queued_spin_unlock
2.48% [kernel] [k] memcpy
2.34% [kernel] [k] xfs_log_commit_cil
The typical profile resulting from running fsmark on a selinux enabled
filesytem is adds this overhead to the create path:
- 15.30% xfs_init_security
- 15.23% security_inode_init_security
- 13.05% xfs_initxattrs
- 12.94% xfs_attr_set
- 6.75% xfs_bmap_add_attrfork
- 5.51% xfs_trans_commit
- 5.48% __xfs_trans_commit
- 5.35% xfs_log_commit_cil
- 3.86% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.70% xfs_trans_alloc
0.52% xfs_trans_reserve
- 5.41% xfs_attr_set_args
- 5.39% xfs_attr_set_shortform.constprop.0
- 4.46% xfs_trans_commit
- 4.46% __xfs_trans_commit
- 4.33% xfs_log_commit_cil
- 2.74% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
0.60% xfs_inode_item_format
0.90% xfs_attr_try_sf_addname
- 1.99% selinux_inode_init_security
- 1.02% security_sid_to_context_force
- 1.00% security_sid_to_context_core
- 0.92% sidtab_entry_to_string
- 0.90% sidtab_sid2str_get
0.59% sidtab_sid2str_put.part.0
- 0.82% selinux_determine_inode_label
- 0.77% security_transition_sid
0.70% security_compute_sid.part.0
And fsmark creation rate performance drops by ~25%. The key point to
note here is that half the additional overhead comes from adding the
attribute fork to the newly created inode. That's crazy, considering
we can do this same thing at inode create time with a couple of
lines of code and no extra overhead.
So, if we know we are going to add an attribute immediately after
creating the inode, let's just initialise the attribute fork inside
the create transaction and chop that whole chunk of code out of
the create fast path. This completely removes the performance
drop caused by enabling SELinux, and the profile looks like:
- 8.99% xfs_init_security
- 9.00% security_inode_init_security
- 6.43% xfs_initxattrs
- 6.37% xfs_attr_set
- 5.45% xfs_attr_set_args
- 5.42% xfs_attr_set_shortform.constprop.0
- 4.51% xfs_trans_commit
- 4.54% __xfs_trans_commit
- 4.59% xfs_log_commit_cil
- 2.67% _raw_spin_lock
- 3.28% do_raw_spin_lock
3.08% __pv_queued_spin_lock_slowpath
0.66% xfs_inode_item_format
- 0.90% xfs_attr_try_sf_addname
- 0.60% xfs_trans_alloc
- 2.35% selinux_inode_init_security
- 1.25% security_sid_to_context_force
- 1.21% security_sid_to_context_core
- 1.19% sidtab_entry_to_string
- 1.20% sidtab_sid2str_get
- 0.86% sidtab_sid2str_put.part.0
- 0.62% _raw_spin_lock_irqsave
- 0.77% do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.84% selinux_determine_inode_label
- 0.83% security_transition_sid
0.86% security_compute_sid.part.0
Which indicates the XFS overhead of creating the selinux xattr has
been halved. This doesn't fix the CIL lock contention problem, just
means it's not a limiting factor for this workload. Lock contention
in the security subsystems is going to be an issue soon, though...
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[djwong: fix compilation error when CONFIG_SECURITY=n]
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Gao Xiang <hsiangkao@redhat.com>
2021-03-23 00:52:03 +08:00
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* Log the new values stuffed into the inode.
|
|
|
|
*/
|
2011-09-19 23:00:54 +08:00
|
|
|
xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);
|
2005-04-17 06:20:36 +08:00
|
|
|
xfs_trans_log_inode(tp, ip, flags);
|
|
|
|
|
2015-02-23 19:38:08 +08:00
|
|
|
/* now that we have an i_mode we can setup the inode structure */
|
2008-08-13 14:23:13 +08:00
|
|
|
xfs_setup_inode(ip);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
*ipp = ip;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:47 +08:00
|
|
|
/*
|
2016-02-09 13:54:58 +08:00
|
|
|
* Decrement the link count on an inode & log the change. If this causes the
|
|
|
|
* link count to go to zero, move the inode to AGI unlinked list so that it can
|
|
|
|
* be freed when the last active reference goes away via xfs_inactive().
|
2013-08-12 18:49:47 +08:00
|
|
|
*/
|
2016-06-01 15:38:15 +08:00
|
|
|
static int /* error */
|
2013-08-12 18:49:47 +08:00
|
|
|
xfs_droplink(
|
|
|
|
xfs_trans_t *tp,
|
|
|
|
xfs_inode_t *ip)
|
|
|
|
{
|
2023-10-10 10:09:01 +08:00
|
|
|
if (VFS_I(ip)->i_nlink == 0) {
|
|
|
|
xfs_alert(ip->i_mount,
|
|
|
|
"%s: Attempt to drop inode (%llu) with nlink zero.",
|
|
|
|
__func__, ip->i_ino);
|
|
|
|
return -EFSCORRUPTED;
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:47 +08:00
|
|
|
xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);
|
|
|
|
|
|
|
|
drop_nlink(VFS_I(ip));
|
|
|
|
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
|
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
if (VFS_I(ip)->i_nlink)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
return xfs_iunlink(tp, ip);
|
2013-08-12 18:49:47 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Increment the link count on an inode & log the change.
|
|
|
|
*/
|
2019-05-02 11:26:30 +08:00
|
|
|
static void
|
2013-08-12 18:49:47 +08:00
|
|
|
xfs_bumplink(
|
|
|
|
xfs_trans_t *tp,
|
|
|
|
xfs_inode_t *ip)
|
|
|
|
{
|
|
|
|
xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);
|
|
|
|
|
|
|
|
inc_nlink(VFS_I(ip));
|
|
|
|
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:45 +08:00
|
|
|
int
|
|
|
|
xfs_create(
|
2023-01-13 19:49:25 +08:00
|
|
|
struct mnt_idmap *idmap,
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_inode_t *dp,
|
|
|
|
struct xfs_name *name,
|
|
|
|
umode_t mode,
|
2017-10-20 02:07:09 +08:00
|
|
|
dev_t rdev,
|
xfs: initialise attr fork on inode create
When we allocate a new inode, we often need to add an attribute to
the inode as part of the create. This can happen as a result of
needing to add default ACLs or security labels before the inode is
made visible to userspace.
This is highly inefficient right now. We do the create transaction
to allocate the inode, then we do an "add attr fork" transaction to
modify the just created empty inode to set the inode fork offset to
allow attributes to be stored, then we go and do the attribute
creation.
This means 3 transactions instead of 1 to allocate an inode, and
this greatly increases the load on the CIL commit code, resulting in
excessive contention on the CIL spin locks and performance
degradation:
18.99% [kernel] [k] __pv_queued_spin_lock_slowpath
3.57% [kernel] [k] do_raw_spin_lock
2.51% [kernel] [k] __raw_callee_save___pv_queued_spin_unlock
2.48% [kernel] [k] memcpy
2.34% [kernel] [k] xfs_log_commit_cil
The typical profile resulting from running fsmark on a selinux enabled
filesytem is adds this overhead to the create path:
- 15.30% xfs_init_security
- 15.23% security_inode_init_security
- 13.05% xfs_initxattrs
- 12.94% xfs_attr_set
- 6.75% xfs_bmap_add_attrfork
- 5.51% xfs_trans_commit
- 5.48% __xfs_trans_commit
- 5.35% xfs_log_commit_cil
- 3.86% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.70% xfs_trans_alloc
0.52% xfs_trans_reserve
- 5.41% xfs_attr_set_args
- 5.39% xfs_attr_set_shortform.constprop.0
- 4.46% xfs_trans_commit
- 4.46% __xfs_trans_commit
- 4.33% xfs_log_commit_cil
- 2.74% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
0.60% xfs_inode_item_format
0.90% xfs_attr_try_sf_addname
- 1.99% selinux_inode_init_security
- 1.02% security_sid_to_context_force
- 1.00% security_sid_to_context_core
- 0.92% sidtab_entry_to_string
- 0.90% sidtab_sid2str_get
0.59% sidtab_sid2str_put.part.0
- 0.82% selinux_determine_inode_label
- 0.77% security_transition_sid
0.70% security_compute_sid.part.0
And fsmark creation rate performance drops by ~25%. The key point to
note here is that half the additional overhead comes from adding the
attribute fork to the newly created inode. That's crazy, considering
we can do this same thing at inode create time with a couple of
lines of code and no extra overhead.
So, if we know we are going to add an attribute immediately after
creating the inode, let's just initialise the attribute fork inside
the create transaction and chop that whole chunk of code out of
the create fast path. This completely removes the performance
drop caused by enabling SELinux, and the profile looks like:
- 8.99% xfs_init_security
- 9.00% security_inode_init_security
- 6.43% xfs_initxattrs
- 6.37% xfs_attr_set
- 5.45% xfs_attr_set_args
- 5.42% xfs_attr_set_shortform.constprop.0
- 4.51% xfs_trans_commit
- 4.54% __xfs_trans_commit
- 4.59% xfs_log_commit_cil
- 2.67% _raw_spin_lock
- 3.28% do_raw_spin_lock
3.08% __pv_queued_spin_lock_slowpath
0.66% xfs_inode_item_format
- 0.90% xfs_attr_try_sf_addname
- 0.60% xfs_trans_alloc
- 2.35% selinux_inode_init_security
- 1.25% security_sid_to_context_force
- 1.21% security_sid_to_context_core
- 1.19% sidtab_entry_to_string
- 1.20% sidtab_sid2str_get
- 0.86% sidtab_sid2str_put.part.0
- 0.62% _raw_spin_lock_irqsave
- 0.77% do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.84% selinux_determine_inode_label
- 0.83% security_transition_sid
0.86% security_compute_sid.part.0
Which indicates the XFS overhead of creating the selinux xattr has
been halved. This doesn't fix the CIL lock contention problem, just
means it's not a limiting factor for this workload. Lock contention
in the security subsystems is going to be an issue soon, though...
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[djwong: fix compilation error when CONFIG_SECURITY=n]
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Gao Xiang <hsiangkao@redhat.com>
2021-03-23 00:52:03 +08:00
|
|
|
bool init_xattrs,
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_inode_t **ipp)
|
|
|
|
{
|
|
|
|
int is_dir = S_ISDIR(mode);
|
|
|
|
struct xfs_mount *mp = dp->i_mount;
|
|
|
|
struct xfs_inode *ip = NULL;
|
|
|
|
struct xfs_trans *tp = NULL;
|
|
|
|
int error;
|
|
|
|
bool unlock_dp_on_error = false;
|
|
|
|
prid_t prid;
|
|
|
|
struct xfs_dquot *udqp = NULL;
|
|
|
|
struct xfs_dquot *gdqp = NULL;
|
|
|
|
struct xfs_dquot *pdqp = NULL;
|
2014-11-28 11:00:16 +08:00
|
|
|
struct xfs_trans_res *tres;
|
2013-08-12 18:49:45 +08:00
|
|
|
uint resblks;
|
2021-06-02 08:48:24 +08:00
|
|
|
xfs_ino_t ino;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
trace_xfs_create(dp, name);
|
|
|
|
|
2021-08-19 09:46:53 +08:00
|
|
|
if (xfs_is_shutdown(mp))
|
2014-06-25 12:58:08 +08:00
|
|
|
return -EIO;
|
2023-12-16 02:03:35 +08:00
|
|
|
if (xfs_ifork_zapped(dp, XFS_DATA_FORK))
|
|
|
|
return -EIO;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2013-12-18 08:22:39 +08:00
|
|
|
prid = xfs_get_initial_prid(dp);
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Make sure that we have allocated dquot(s) on disk.
|
|
|
|
*/
|
2023-01-13 19:49:31 +08:00
|
|
|
error = xfs_qm_vop_dqalloc(dp, mapped_fsuid(idmap, &init_user_ns),
|
|
|
|
mapped_fsgid(idmap, &init_user_ns), prid,
|
2021-03-03 01:32:52 +08:00
|
|
|
XFS_QMOPT_QUOTALL | XFS_QMOPT_INHERIT,
|
|
|
|
&udqp, &gdqp, &pdqp);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
if (is_dir) {
|
|
|
|
resblks = XFS_MKDIR_SPACE_RES(mp, name->len);
|
2014-11-28 11:00:16 +08:00
|
|
|
tres = &M_RES(mp)->tr_mkdir;
|
2013-08-12 18:49:45 +08:00
|
|
|
} else {
|
|
|
|
resblks = XFS_CREATE_SPACE_RES(mp, name->len);
|
2014-11-28 11:00:16 +08:00
|
|
|
tres = &M_RES(mp)->tr_create;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Initially assume that the file does not exist and
|
|
|
|
* reserve the resources for that case. If that is not
|
|
|
|
* the case we'll drop the one we have and get a more
|
|
|
|
* appropriate transaction later.
|
|
|
|
*/
|
2021-01-28 04:07:57 +08:00
|
|
|
error = xfs_trans_alloc_icreate(mp, tres, udqp, gdqp, pdqp, resblks,
|
|
|
|
&tp);
|
2014-06-25 12:58:08 +08:00
|
|
|
if (error == -ENOSPC) {
|
2013-08-12 18:49:45 +08:00
|
|
|
/* flush outstanding delalloc blocks and retry */
|
|
|
|
xfs_flush_inodes(mp);
|
2021-01-28 04:07:57 +08:00
|
|
|
error = xfs_trans_alloc_icreate(mp, tres, udqp, gdqp, pdqp,
|
|
|
|
resblks, &tp);
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
2015-06-04 11:47:56 +08:00
|
|
|
if (error)
|
2021-01-28 04:07:57 +08:00
|
|
|
goto out_release_dquots;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2016-11-30 11:33:25 +08:00
|
|
|
xfs_ilock(dp, XFS_ILOCK_EXCL | XFS_ILOCK_PARENT);
|
2013-08-12 18:49:45 +08:00
|
|
|
unlock_dp_on_error = true;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* A newly created regular or special file just has one directory
|
|
|
|
* entry pointing to them, but a directory also the "." entry
|
|
|
|
* pointing to itself.
|
|
|
|
*/
|
2021-06-02 08:48:24 +08:00
|
|
|
error = xfs_dialloc(&tp, dp->i_ino, mode, &ino);
|
|
|
|
if (!error)
|
2023-01-13 19:49:25 +08:00
|
|
|
error = xfs_init_new_inode(idmap, tp, dp, ino, mode,
|
2021-06-02 08:48:24 +08:00
|
|
|
is_dir ? 2 : 1, rdev, prid, init_xattrs, &ip);
|
2015-07-29 09:52:08 +08:00
|
|
|
if (error)
|
2015-06-04 11:47:56 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Now we join the directory inode to the transaction. We do not do it
|
2021-06-02 08:48:24 +08:00
|
|
|
* earlier because xfs_dialloc might commit the previous transaction
|
2013-08-12 18:49:45 +08:00
|
|
|
* (and release all the locks). An error from here on will result in
|
|
|
|
* the transaction cancel unlocking dp so don't do it explicitly in the
|
|
|
|
* error path.
|
|
|
|
*/
|
2016-11-30 11:33:25 +08:00
|
|
|
xfs_trans_ijoin(tp, dp, XFS_ILOCK_EXCL);
|
2013-08-12 18:49:45 +08:00
|
|
|
unlock_dp_on_error = false;
|
|
|
|
|
2018-07-12 13:26:21 +08:00
|
|
|
error = xfs_dir_createname(tp, dp, name, ip->i_ino,
|
2020-03-27 23:28:39 +08:00
|
|
|
resblks - XFS_IALLOC_SPACE_RES(mp));
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error) {
|
2014-06-25 12:58:08 +08:00
|
|
|
ASSERT(error != -ENOSPC);
|
2015-06-04 11:47:56 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
xfs_trans_ichgtime(tp, dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
|
|
|
|
xfs_trans_log_inode(tp, dp, XFS_ILOG_CORE);
|
|
|
|
|
|
|
|
if (is_dir) {
|
|
|
|
error = xfs_dir_init(tp, ip, dp);
|
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2019-05-02 11:26:30 +08:00
|
|
|
xfs_bumplink(tp, dp);
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If this is a synchronous mount, make sure that the
|
|
|
|
* create transaction goes to disk before returning to
|
|
|
|
* the user.
|
|
|
|
*/
|
2021-08-19 09:46:52 +08:00
|
|
|
if (xfs_has_wsync(mp) || xfs_has_dirsync(mp))
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_trans_set_sync(tp);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Attach the dquot(s) to the inodes and modify them incore.
|
|
|
|
* These ids of the inode couldn't have changed since the new
|
|
|
|
* inode has been locked ever since it was created.
|
|
|
|
*/
|
|
|
|
xfs_qm_vop_create_dqattach(tp, ip, udqp, gdqp, pdqp);
|
|
|
|
|
2015-06-04 11:48:08 +08:00
|
|
|
error = xfs_trans_commit(tp);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error)
|
|
|
|
goto out_release_inode;
|
|
|
|
|
|
|
|
xfs_qm_dqrele(udqp);
|
|
|
|
xfs_qm_dqrele(gdqp);
|
|
|
|
xfs_qm_dqrele(pdqp);
|
|
|
|
|
|
|
|
*ipp = ip;
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_trans_cancel:
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2013-08-12 18:49:45 +08:00
|
|
|
out_release_inode:
|
|
|
|
/*
|
2015-02-23 19:38:08 +08:00
|
|
|
* Wait until after the current transaction is aborted to finish the
|
|
|
|
* setup of the inode and release the inode. This prevents recursive
|
|
|
|
* transactions and deadlocks from xfs_inactive.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
2015-02-23 19:38:08 +08:00
|
|
|
if (ip) {
|
|
|
|
xfs_finish_inode_setup(ip);
|
2018-07-26 03:52:32 +08:00
|
|
|
xfs_irele(ip);
|
2015-02-23 19:38:08 +08:00
|
|
|
}
|
2021-01-28 04:07:57 +08:00
|
|
|
out_release_dquots:
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_qm_dqrele(udqp);
|
|
|
|
xfs_qm_dqrele(gdqp);
|
|
|
|
xfs_qm_dqrele(pdqp);
|
|
|
|
|
|
|
|
if (unlock_dp_on_error)
|
2016-11-30 11:33:25 +08:00
|
|
|
xfs_iunlock(dp, XFS_ILOCK_EXCL);
|
2013-08-12 18:49:45 +08:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2013-12-18 08:22:40 +08:00
|
|
|
int
|
|
|
|
xfs_create_tmpfile(
|
2023-01-13 19:49:25 +08:00
|
|
|
struct mnt_idmap *idmap,
|
2013-12-18 08:22:40 +08:00
|
|
|
struct xfs_inode *dp,
|
2014-04-17 06:15:30 +08:00
|
|
|
umode_t mode,
|
|
|
|
struct xfs_inode **ipp)
|
2013-12-18 08:22:40 +08:00
|
|
|
{
|
|
|
|
struct xfs_mount *mp = dp->i_mount;
|
|
|
|
struct xfs_inode *ip = NULL;
|
|
|
|
struct xfs_trans *tp = NULL;
|
|
|
|
int error;
|
|
|
|
prid_t prid;
|
|
|
|
struct xfs_dquot *udqp = NULL;
|
|
|
|
struct xfs_dquot *gdqp = NULL;
|
|
|
|
struct xfs_dquot *pdqp = NULL;
|
|
|
|
struct xfs_trans_res *tres;
|
|
|
|
uint resblks;
|
2021-06-02 08:48:24 +08:00
|
|
|
xfs_ino_t ino;
|
2013-12-18 08:22:40 +08:00
|
|
|
|
2021-08-19 09:46:53 +08:00
|
|
|
if (xfs_is_shutdown(mp))
|
2014-06-25 12:58:08 +08:00
|
|
|
return -EIO;
|
2013-12-18 08:22:40 +08:00
|
|
|
|
|
|
|
prid = xfs_get_initial_prid(dp);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Make sure that we have allocated dquot(s) on disk.
|
|
|
|
*/
|
2023-01-13 19:49:31 +08:00
|
|
|
error = xfs_qm_vop_dqalloc(dp, mapped_fsuid(idmap, &init_user_ns),
|
|
|
|
mapped_fsgid(idmap, &init_user_ns), prid,
|
2021-03-03 01:32:52 +08:00
|
|
|
XFS_QMOPT_QUOTALL | XFS_QMOPT_INHERIT,
|
|
|
|
&udqp, &gdqp, &pdqp);
|
2013-12-18 08:22:40 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
resblks = XFS_IALLOC_SPACE_RES(mp);
|
|
|
|
tres = &M_RES(mp)->tr_create_tmpfile;
|
2016-04-06 07:19:55 +08:00
|
|
|
|
2021-01-28 04:07:57 +08:00
|
|
|
error = xfs_trans_alloc_icreate(mp, tres, udqp, gdqp, pdqp, resblks,
|
|
|
|
&tp);
|
2013-12-18 08:22:40 +08:00
|
|
|
if (error)
|
2021-01-28 04:07:57 +08:00
|
|
|
goto out_release_dquots;
|
2013-12-18 08:22:40 +08:00
|
|
|
|
2021-06-02 08:48:24 +08:00
|
|
|
error = xfs_dialloc(&tp, dp->i_ino, mode, &ino);
|
|
|
|
if (!error)
|
2023-01-13 19:49:25 +08:00
|
|
|
error = xfs_init_new_inode(idmap, tp, dp, ino, mode,
|
2021-06-02 08:48:24 +08:00
|
|
|
0, 0, prid, false, &ip);
|
2015-07-29 09:52:08 +08:00
|
|
|
if (error)
|
2015-06-04 11:47:56 +08:00
|
|
|
goto out_trans_cancel;
|
2013-12-18 08:22:40 +08:00
|
|
|
|
2021-08-19 09:46:52 +08:00
|
|
|
if (xfs_has_wsync(mp))
|
2013-12-18 08:22:40 +08:00
|
|
|
xfs_trans_set_sync(tp);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Attach the dquot(s) to the inodes and modify them incore.
|
|
|
|
* These ids of the inode couldn't have changed since the new
|
|
|
|
* inode has been locked ever since it was created.
|
|
|
|
*/
|
|
|
|
xfs_qm_vop_create_dqattach(tp, ip, udqp, gdqp, pdqp);
|
|
|
|
|
|
|
|
error = xfs_iunlink(tp, ip);
|
|
|
|
if (error)
|
2015-06-04 11:47:56 +08:00
|
|
|
goto out_trans_cancel;
|
2013-12-18 08:22:40 +08:00
|
|
|
|
2015-06-04 11:48:08 +08:00
|
|
|
error = xfs_trans_commit(tp);
|
2013-12-18 08:22:40 +08:00
|
|
|
if (error)
|
|
|
|
goto out_release_inode;
|
|
|
|
|
|
|
|
xfs_qm_dqrele(udqp);
|
|
|
|
xfs_qm_dqrele(gdqp);
|
|
|
|
xfs_qm_dqrele(pdqp);
|
|
|
|
|
2014-04-17 06:15:30 +08:00
|
|
|
*ipp = ip;
|
2013-12-18 08:22:40 +08:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_trans_cancel:
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2013-12-18 08:22:40 +08:00
|
|
|
out_release_inode:
|
|
|
|
/*
|
2015-02-23 19:38:08 +08:00
|
|
|
* Wait until after the current transaction is aborted to finish the
|
|
|
|
* setup of the inode and release the inode. This prevents recursive
|
|
|
|
* transactions and deadlocks from xfs_inactive.
|
2013-12-18 08:22:40 +08:00
|
|
|
*/
|
2015-02-23 19:38:08 +08:00
|
|
|
if (ip) {
|
|
|
|
xfs_finish_inode_setup(ip);
|
2018-07-26 03:52:32 +08:00
|
|
|
xfs_irele(ip);
|
2015-02-23 19:38:08 +08:00
|
|
|
}
|
2021-01-28 04:07:57 +08:00
|
|
|
out_release_dquots:
|
2013-12-18 08:22:40 +08:00
|
|
|
xfs_qm_dqrele(udqp);
|
|
|
|
xfs_qm_dqrele(gdqp);
|
|
|
|
xfs_qm_dqrele(pdqp);
|
|
|
|
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:45 +08:00
|
|
|
int
|
|
|
|
xfs_link(
|
|
|
|
xfs_inode_t *tdp,
|
|
|
|
xfs_inode_t *sip,
|
|
|
|
struct xfs_name *target_name)
|
|
|
|
{
|
|
|
|
xfs_mount_t *mp = tdp->i_mount;
|
|
|
|
xfs_trans_t *tp;
|
2022-02-26 08:18:41 +08:00
|
|
|
int error, nospace_error = 0;
|
2013-08-12 18:49:45 +08:00
|
|
|
int resblks;
|
|
|
|
|
|
|
|
trace_xfs_link(tdp, target_name);
|
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
ASSERT(!S_ISDIR(VFS_I(sip)->i_mode));
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2021-08-19 09:46:53 +08:00
|
|
|
if (xfs_is_shutdown(mp))
|
2014-06-25 12:58:08 +08:00
|
|
|
return -EIO;
|
2023-12-16 02:03:35 +08:00
|
|
|
if (xfs_ifork_zapped(tdp, XFS_DATA_FORK))
|
|
|
|
return -EIO;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2018-05-05 06:30:21 +08:00
|
|
|
error = xfs_qm_dqattach(sip);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error)
|
|
|
|
goto std_return;
|
|
|
|
|
2018-05-05 06:30:21 +08:00
|
|
|
error = xfs_qm_dqattach(tdp);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error)
|
|
|
|
goto std_return;
|
|
|
|
|
|
|
|
resblks = XFS_LINK_SPACE_RES(mp, target_name->len);
|
2022-02-26 08:18:41 +08:00
|
|
|
error = xfs_trans_alloc_dir(tdp, &M_RES(mp)->tr_link, sip, &resblks,
|
|
|
|
&tp, &nospace_error);
|
2015-06-04 11:47:56 +08:00
|
|
|
if (error)
|
2016-04-06 07:19:55 +08:00
|
|
|
goto std_return;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we are using project inheritance, we only allow hard link
|
|
|
|
* creation in our tree when the project IDs are the same; else
|
|
|
|
* the tree quota mechanism could be circumvented.
|
|
|
|
*/
|
2021-03-30 02:11:44 +08:00
|
|
|
if (unlikely((tdp->i_diflags & XFS_DIFLAG_PROJINHERIT) &&
|
2021-03-30 02:11:39 +08:00
|
|
|
tdp->i_projid != sip->i_projid)) {
|
2014-06-25 12:58:08 +08:00
|
|
|
error = -EXDEV;
|
2013-08-12 18:49:45 +08:00
|
|
|
goto error_return;
|
|
|
|
}
|
|
|
|
|
2014-09-09 09:57:52 +08:00
|
|
|
if (!resblks) {
|
|
|
|
error = xfs_dir_canenter(tp, tdp, target_name);
|
|
|
|
if (error)
|
|
|
|
goto error_return;
|
|
|
|
}
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
/*
|
|
|
|
* Handle initial link state of O_TMPFILE inode
|
|
|
|
*/
|
|
|
|
if (VFS_I(sip)->i_nlink == 0) {
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_perag *pag;
|
|
|
|
|
|
|
|
pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, sip->i_ino));
|
|
|
|
error = xfs_iunlink_remove(tp, pag, sip);
|
|
|
|
xfs_perag_put(pag);
|
2013-12-18 08:22:41 +08:00
|
|
|
if (error)
|
2015-06-04 11:47:56 +08:00
|
|
|
goto error_return;
|
2013-12-18 08:22:41 +08:00
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:45 +08:00
|
|
|
error = xfs_dir_createname(tp, tdp, target_name, sip->i_ino,
|
2018-07-12 13:26:21 +08:00
|
|
|
resblks);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error)
|
2015-06-04 11:47:56 +08:00
|
|
|
goto error_return;
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_trans_ichgtime(tp, tdp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
|
|
|
|
xfs_trans_log_inode(tp, tdp, XFS_ILOG_CORE);
|
|
|
|
|
2019-05-02 11:26:30 +08:00
|
|
|
xfs_bumplink(tp, sip);
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If this is a synchronous mount, make sure that the
|
|
|
|
* link transaction goes to disk before returning to
|
|
|
|
* the user.
|
|
|
|
*/
|
2021-08-19 09:46:52 +08:00
|
|
|
if (xfs_has_wsync(mp) || xfs_has_dirsync(mp))
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_trans_set_sync(tp);
|
|
|
|
|
2015-06-04 11:48:08 +08:00
|
|
|
return xfs_trans_commit(tp);
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
error_return:
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2013-08-12 18:49:45 +08:00
|
|
|
std_return:
|
2022-02-26 08:18:41 +08:00
|
|
|
if (error == -ENOSPC && nospace_error)
|
|
|
|
error = nospace_error;
|
2013-08-12 18:49:45 +08:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2017-12-15 07:42:59 +08:00
|
|
|
/* Clear the reflink flag and the cowblocks tag if possible. */
|
|
|
|
static void
|
|
|
|
xfs_itruncate_clear_reflink_flags(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
struct xfs_ifork *dfork;
|
|
|
|
struct xfs_ifork *cfork;
|
|
|
|
|
|
|
|
if (!xfs_is_reflink_inode(ip))
|
|
|
|
return;
|
2022-07-10 01:56:05 +08:00
|
|
|
dfork = xfs_ifork_ptr(ip, XFS_DATA_FORK);
|
|
|
|
cfork = xfs_ifork_ptr(ip, XFS_COW_FORK);
|
2017-12-15 07:42:59 +08:00
|
|
|
if (dfork->if_bytes == 0 && cfork->if_bytes == 0)
|
2021-03-30 02:11:45 +08:00
|
|
|
ip->i_diflags2 &= ~XFS_DIFLAG2_REFLINK;
|
2017-12-15 07:42:59 +08:00
|
|
|
if (cfork->if_bytes == 0)
|
|
|
|
xfs_inode_clear_cowblocks_tag(ip);
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2011-07-08 20:34:34 +08:00
|
|
|
* Free up the underlying blocks past new_size. The new size must be smaller
|
|
|
|
* than the current size. This routine can be used both for the attribute and
|
|
|
|
* data fork, and does not modify the inode size, which is left to the caller.
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
2008-04-17 14:50:04 +08:00
|
|
|
* The transaction passed to this routine must have made a permanent log
|
|
|
|
* reservation of at least XFS_ITRUNCATE_LOG_RES. This routine may commit the
|
|
|
|
* given transaction and start new ones, so make sure everything involved in
|
|
|
|
* the transaction is tidy before calling here. Some transaction will be
|
|
|
|
* returned to the caller to be committed. The incoming transaction must
|
|
|
|
* already include the inode, and both inode locks must be held exclusively.
|
|
|
|
* The inode must also be "held" within the transaction. On return the inode
|
|
|
|
* will be "held" within the returned transaction. This routine does NOT
|
|
|
|
* require any disk space to be reserved for it within the transaction.
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
2008-04-17 14:50:04 +08:00
|
|
|
* If we get an error, we must return with the inode locked and linked into the
|
|
|
|
* current transaction. This keeps things simple for the higher level code,
|
|
|
|
* because it always knows that the inode is locked and held in the transaction
|
|
|
|
* that returns to it whether errors occur or not. We don't mark the inode
|
|
|
|
* dirty on error so that transactions can be easily aborted if possible.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
|
|
|
int
|
2018-05-11 00:35:42 +08:00
|
|
|
xfs_itruncate_extents_flags(
|
2011-07-08 20:34:34 +08:00
|
|
|
struct xfs_trans **tpp,
|
|
|
|
struct xfs_inode *ip,
|
|
|
|
int whichfork,
|
2018-05-09 23:45:04 +08:00
|
|
|
xfs_fsize_t new_size,
|
2018-05-11 00:35:42 +08:00
|
|
|
int flags)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2011-07-08 20:34:34 +08:00
|
|
|
struct xfs_mount *mp = ip->i_mount;
|
|
|
|
struct xfs_trans *tp = *tpp;
|
|
|
|
xfs_fileoff_t first_unmap_block;
|
|
|
|
int error = 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-07-04 23:13:31 +08:00
|
|
|
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
|
|
|
|
ASSERT(!atomic_read(&VFS_I(ip)->i_count) ||
|
|
|
|
xfs_isilocked(ip, XFS_IOLOCK_EXCL));
|
2011-12-19 04:00:11 +08:00
|
|
|
ASSERT(new_size <= XFS_ISIZE(ip));
|
2011-07-08 20:34:34 +08:00
|
|
|
ASSERT(tp->t_flags & XFS_TRANS_PERM_LOG_RES);
|
2005-04-17 06:20:36 +08:00
|
|
|
ASSERT(ip->i_itemp != NULL);
|
2010-06-24 09:36:58 +08:00
|
|
|
ASSERT(ip->i_itemp->ili_lock_flags == 0);
|
2011-07-08 20:34:34 +08:00
|
|
|
ASSERT(!XFS_NOT_DQATTACHED(mp, ip));
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2011-12-19 04:00:04 +08:00
|
|
|
trace_xfs_itruncate_extents_start(ip, new_size);
|
|
|
|
|
2018-05-11 00:35:42 +08:00
|
|
|
flags |= xfs_bmapi_aflag(whichfork);
|
2018-05-09 23:45:04 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* Since it is possible for space to become allocated beyond
|
|
|
|
* the end of the file (in a crash where the space is allocated
|
|
|
|
* but the inode size is not yet updated), simply remove any
|
|
|
|
* blocks which show up between the new EOF and the maximum
|
2020-01-03 05:20:13 +08:00
|
|
|
* possible file size.
|
|
|
|
*
|
|
|
|
* We have to free all the blocks to the bmbt maximum offset, even if
|
|
|
|
* the page cache can't scale that far.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2011-07-08 20:34:34 +08:00
|
|
|
first_unmap_block = XFS_B_TO_FSB(mp, (xfs_ufsize_t)new_size);
|
2020-12-05 05:28:35 +08:00
|
|
|
if (!xfs_verify_fileoff(mp, first_unmap_block)) {
|
2020-01-03 05:20:13 +08:00
|
|
|
WARN_ON_ONCE(first_unmap_block > XFS_MAX_FILEOFF);
|
2011-07-08 20:34:34 +08:00
|
|
|
return 0;
|
2020-01-03 05:20:13 +08:00
|
|
|
}
|
2011-07-08 20:34:34 +08:00
|
|
|
|
2023-12-16 02:03:43 +08:00
|
|
|
error = xfs_bunmapi_range(&tp, ip, flags, first_unmap_block,
|
|
|
|
XFS_MAX_FILEOFF);
|
|
|
|
if (error)
|
|
|
|
goto out;
|
2011-07-08 20:34:34 +08:00
|
|
|
|
2018-04-10 23:28:33 +08:00
|
|
|
if (whichfork == XFS_DATA_FORK) {
|
|
|
|
/* Remove all pending CoW reservations. */
|
|
|
|
error = xfs_reflink_cancel_cow_blocks(ip, &tp,
|
2020-01-03 05:20:13 +08:00
|
|
|
first_unmap_block, XFS_MAX_FILEOFF, true);
|
2018-04-10 23:28:33 +08:00
|
|
|
if (error)
|
|
|
|
goto out;
|
2016-10-04 00:11:38 +08:00
|
|
|
|
2018-04-10 23:28:33 +08:00
|
|
|
xfs_itruncate_clear_reflink_flags(ip);
|
|
|
|
}
|
2016-10-04 00:11:38 +08:00
|
|
|
|
2011-12-19 04:00:04 +08:00
|
|
|
/*
|
|
|
|
* Always re-log the inode so that our permanent transaction can keep
|
|
|
|
* on rolling it forward in the log.
|
|
|
|
*/
|
|
|
|
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
|
|
|
|
|
|
|
|
trace_xfs_itruncate_extents_end(ip, new_size);
|
|
|
|
|
2011-07-08 20:34:34 +08:00
|
|
|
out:
|
|
|
|
*tpp = tp;
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:45 +08:00
|
|
|
int
|
|
|
|
xfs_release(
|
|
|
|
xfs_inode_t *ip)
|
|
|
|
{
|
|
|
|
xfs_mount_t *mp = ip->i_mount;
|
2021-03-24 07:59:31 +08:00
|
|
|
int error = 0;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
if (!S_ISREG(VFS_I(ip)->i_mode) || (VFS_I(ip)->i_mode == 0))
|
2013-08-12 18:49:45 +08:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* If this is a read-only mount, don't do this (would generate I/O) */
|
2021-08-19 09:46:52 +08:00
|
|
|
if (xfs_is_readonly(mp))
|
2013-08-12 18:49:45 +08:00
|
|
|
return 0;
|
|
|
|
|
2021-08-19 09:46:53 +08:00
|
|
|
if (!xfs_is_shutdown(mp)) {
|
2013-08-12 18:49:45 +08:00
|
|
|
int truncated;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we previously truncated this file and removed old data
|
|
|
|
* in the process, we want to initiate "early" writeout on
|
|
|
|
* the last close. This is an attempt to combat the notorious
|
|
|
|
* NULL files problem which is particularly noticeable from a
|
|
|
|
* truncate down, buffered (re-)write (delalloc), followed by
|
|
|
|
* a crash. What we are effectively doing here is
|
|
|
|
* significantly reducing the time window where we'd otherwise
|
|
|
|
* be exposed to that problem.
|
|
|
|
*/
|
|
|
|
truncated = xfs_iflags_test_and_clear(ip, XFS_ITRUNCATED);
|
|
|
|
if (truncated) {
|
|
|
|
xfs_iflags_clear(ip, XFS_IDIRTY_RELEASE);
|
2014-08-04 11:22:49 +08:00
|
|
|
if (ip->i_delayed_blks > 0) {
|
2014-06-25 12:58:08 +08:00
|
|
|
error = filemap_flush(VFS_I(ip)->i_mapping);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
if (VFS_I(ip)->i_nlink == 0)
|
2013-08-12 18:49:45 +08:00
|
|
|
return 0;
|
|
|
|
|
2021-03-24 07:59:31 +08:00
|
|
|
/*
|
|
|
|
* If we can't get the iolock just skip truncating the blocks past EOF
|
|
|
|
* because we could deadlock with the mmap_lock otherwise. We'll get
|
|
|
|
* another chance to drop them once the last reference to the inode is
|
|
|
|
* dropped, so we'll never leak blocks permanently.
|
|
|
|
*/
|
|
|
|
if (!xfs_ilock_nowait(ip, XFS_IOLOCK_EXCL))
|
|
|
|
return 0;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2021-03-24 07:59:31 +08:00
|
|
|
if (xfs_can_free_eofblocks(ip, false)) {
|
2017-01-28 15:22:55 +08:00
|
|
|
/*
|
|
|
|
* Check if the inode is being opened, written and closed
|
|
|
|
* frequently and we have delayed allocation blocks outstanding
|
|
|
|
* (e.g. streaming writes from the NFS server), truncating the
|
|
|
|
* blocks past EOF will cause fragmentation to occur.
|
|
|
|
*
|
|
|
|
* In this case don't do the truncation, but we have to be
|
|
|
|
* careful how we detect this case. Blocks beyond EOF show up as
|
|
|
|
* i_delayed_blks even when the inode is clean, so we need to
|
|
|
|
* truncate them away first before checking for a dirty release.
|
|
|
|
* Hence on the first dirty close we will still remove the
|
|
|
|
* speculative allocation, but after that we will leave it in
|
|
|
|
* place.
|
|
|
|
*/
|
|
|
|
if (xfs_iflags_test(ip, XFS_IDIRTY_RELEASE))
|
2021-03-24 07:59:31 +08:00
|
|
|
goto out_unlock;
|
|
|
|
|
|
|
|
error = xfs_free_eofblocks(ip);
|
|
|
|
if (error)
|
|
|
|
goto out_unlock;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
/* delalloc blocks after truncation means it really is dirty */
|
|
|
|
if (ip->i_delayed_blks)
|
|
|
|
xfs_iflags_set(ip, XFS_IDIRTY_RELEASE);
|
|
|
|
}
|
2021-03-24 07:59:31 +08:00
|
|
|
|
|
|
|
out_unlock:
|
|
|
|
xfs_iunlock(ip, XFS_IOLOCK_EXCL);
|
|
|
|
return error;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
2013-09-20 23:06:10 +08:00
|
|
|
/*
|
|
|
|
* xfs_inactive_truncate
|
|
|
|
*
|
|
|
|
* Called to perform a truncate when an inode becomes unlinked.
|
|
|
|
*/
|
|
|
|
STATIC int
|
|
|
|
xfs_inactive_truncate(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
struct xfs_mount *mp = ip->i_mount;
|
|
|
|
struct xfs_trans *tp;
|
|
|
|
int error;
|
|
|
|
|
2016-04-06 07:19:55 +08:00
|
|
|
error = xfs_trans_alloc(mp, &M_RES(mp)->tr_itruncate, 0, 0, 0, &tp);
|
2013-09-20 23:06:10 +08:00
|
|
|
if (error) {
|
2021-08-19 09:46:53 +08:00
|
|
|
ASSERT(xfs_is_shutdown(mp));
|
2013-09-20 23:06:10 +08:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
xfs_ilock(ip, XFS_ILOCK_EXCL);
|
|
|
|
xfs_trans_ijoin(tp, ip, 0);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Log the inode size first to prevent stale data exposure in the event
|
|
|
|
* of a system crash before the truncate completes. See the related
|
2016-05-26 20:46:43 +08:00
|
|
|
* comment in xfs_vn_setattr_size() for details.
|
2013-09-20 23:06:10 +08:00
|
|
|
*/
|
2021-03-30 02:11:40 +08:00
|
|
|
ip->i_disk_size = 0;
|
2013-09-20 23:06:10 +08:00
|
|
|
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
|
|
|
|
|
|
|
|
error = xfs_itruncate_extents(&tp, ip, XFS_DATA_FORK, 0);
|
|
|
|
if (error)
|
|
|
|
goto error_trans_cancel;
|
|
|
|
|
2020-05-19 01:27:22 +08:00
|
|
|
ASSERT(ip->i_df.if_nextents == 0);
|
2013-09-20 23:06:10 +08:00
|
|
|
|
2015-06-04 11:48:08 +08:00
|
|
|
error = xfs_trans_commit(tp);
|
2013-09-20 23:06:10 +08:00
|
|
|
if (error)
|
|
|
|
goto error_unlock;
|
|
|
|
|
|
|
|
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
error_trans_cancel:
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2013-09-20 23:06:10 +08:00
|
|
|
error_unlock:
|
|
|
|
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2013-09-20 23:06:11 +08:00
|
|
|
/*
|
|
|
|
* xfs_inactive_ifree()
|
|
|
|
*
|
|
|
|
* Perform the inode free when an inode is unlinked.
|
|
|
|
*/
|
|
|
|
STATIC int
|
|
|
|
xfs_inactive_ifree(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
struct xfs_mount *mp = ip->i_mount;
|
|
|
|
struct xfs_trans *tp;
|
|
|
|
int error;
|
|
|
|
|
2014-04-24 14:00:52 +08:00
|
|
|
/*
|
2017-01-25 23:49:35 +08:00
|
|
|
* We try to use a per-AG reservation for any block needed by the finobt
|
|
|
|
* tree, but as the finobt feature predates the per-AG reservation
|
|
|
|
* support a degraded file system might not have enough space for the
|
|
|
|
* reservation at mount time. In that case try to dip into the reserved
|
|
|
|
* pool and pray.
|
2014-04-24 14:00:52 +08:00
|
|
|
*
|
|
|
|
* Send a warning if the reservation does happen to fail, as the inode
|
|
|
|
* now remains allocated and sits on the unlinked list until the fs is
|
|
|
|
* repaired.
|
|
|
|
*/
|
2019-02-15 01:33:15 +08:00
|
|
|
if (unlikely(mp->m_finobt_nores)) {
|
2017-01-25 23:49:35 +08:00
|
|
|
error = xfs_trans_alloc(mp, &M_RES(mp)->tr_ifree,
|
|
|
|
XFS_IFREE_SPACE_RES(mp), 0, XFS_TRANS_RESERVE,
|
|
|
|
&tp);
|
|
|
|
} else {
|
|
|
|
error = xfs_trans_alloc(mp, &M_RES(mp)->tr_ifree, 0, 0, 0, &tp);
|
|
|
|
}
|
2013-09-20 23:06:11 +08:00
|
|
|
if (error) {
|
2014-06-25 12:58:08 +08:00
|
|
|
if (error == -ENOSPC) {
|
2014-04-24 14:00:52 +08:00
|
|
|
xfs_warn_ratelimited(mp,
|
|
|
|
"Failed to remove inode(s) from unlinked list. "
|
|
|
|
"Please free space, unmount and run xfs_repair.");
|
|
|
|
} else {
|
2021-08-19 09:46:53 +08:00
|
|
|
ASSERT(xfs_is_shutdown(mp));
|
2014-04-24 14:00:52 +08:00
|
|
|
}
|
2013-09-20 23:06:11 +08:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
xfs: Don't allow logging of XFS_ISTALE inodes
In tracking down a problem in this patchset, I discovered we are
reclaiming dirty stale inodes. This wasn't discovered until inodes
were always attached to the cluster buffer and then the rcu callback
that freed inodes was assert failing because the inode still had an
active pointer to the cluster buffer after it had been reclaimed.
Debugging the issue indicated that this was a pre-existing issue
resulting from the way the inodes are handled in xfs_inactive_ifree.
When we free a cluster buffer from xfs_ifree_cluster, all the inodes
in cache are marked XFS_ISTALE. Those that are clean have nothing
else done to them and so eventually get cleaned up by background
reclaim. i.e. it is assumed we'll never dirty/relog an inode marked
XFS_ISTALE.
On journal commit dirty stale inodes as are handled by both
buffer and inode log items to run though xfs_istale_done() and
removed from the AIL (buffer log item commit) or the log item will
simply unpin it because the buffer log item will clean it. What happens
to any specific inode is entirely dependent on which log item wins
the commit race, but the result is the same - stale inodes are
clean, not attached to the cluster buffer, and not in the AIL. Hence
inode reclaim can just free these inodes without further care.
However, if the stale inode is relogged, it gets dirtied again and
relogged into the CIL. Most of the time this isn't an issue, because
relogging simply changes the inode's location in the current
checkpoint. Problems arise, however, when the CIL checkpoints
between two transactions in the xfs_inactive_ifree() deferops
processing. This results in the XFS_ISTALE inode being redirtied
and inserted into the CIL without any of the other stale cluster
buffer infrastructure being in place.
Hence on journal commit, it simply gets unpinned, so it remains
dirty in memory. Everything in inode writeback avoids XFS_ISTALE
inodes so it can't be written back, and it is not tracked in the AIL
so there's not even a trigger to attempt to clean the inode. Hence
the inode just sits dirty in memory until inode reclaim comes along,
sees that it is XFS_ISTALE, and goes to reclaim it. This reclaiming
of a dirty inode caused use after free, list corruptions and other
nasty issues later in this patchset.
Hence this patch addresses a violation of the "never log XFS_ISTALE
inodes" caused by the deferops processing rolling a transaction
and relogging a stale inode in xfs_inactive_free. It also adds a
bunch of asserts to catch this problem in debug kernels so that
we don't reintroduce this problem in future.
Reproducer for this issue was generic/558 on a v4 filesystem.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2020-06-30 05:48:45 +08:00
|
|
|
/*
|
|
|
|
* We do not hold the inode locked across the entire rolling transaction
|
|
|
|
* here. We only need to hold it for the first transaction that
|
|
|
|
* xfs_ifree() builds, which may mark the inode XFS_ISTALE if the
|
|
|
|
* underlying cluster buffer is freed. Relogging an XFS_ISTALE inode
|
|
|
|
* here breaks the relationship between cluster buffer invalidation and
|
|
|
|
* stale inode invalidation on cluster buffer item journal commit
|
|
|
|
* completion, and can result in leaving dirty stale inodes hanging
|
|
|
|
* around in memory.
|
|
|
|
*
|
|
|
|
* We have no need for serialising this inode operation against other
|
|
|
|
* operations - we freed the inode and hence reallocation is required
|
|
|
|
* and that will serialise on reallocating the space the deferops need
|
|
|
|
* to free. Hence we can unlock the inode on the first commit of
|
|
|
|
* the transaction rather than roll it right through the deferops. This
|
|
|
|
* avoids relogging the XFS_ISTALE inode.
|
|
|
|
*
|
|
|
|
* We check that xfs_ifree() hasn't grown an internal transaction roll
|
|
|
|
* by asserting that the inode is still locked when it returns.
|
|
|
|
*/
|
2013-09-20 23:06:11 +08:00
|
|
|
xfs_ilock(ip, XFS_ILOCK_EXCL);
|
xfs: Don't allow logging of XFS_ISTALE inodes
In tracking down a problem in this patchset, I discovered we are
reclaiming dirty stale inodes. This wasn't discovered until inodes
were always attached to the cluster buffer and then the rcu callback
that freed inodes was assert failing because the inode still had an
active pointer to the cluster buffer after it had been reclaimed.
Debugging the issue indicated that this was a pre-existing issue
resulting from the way the inodes are handled in xfs_inactive_ifree.
When we free a cluster buffer from xfs_ifree_cluster, all the inodes
in cache are marked XFS_ISTALE. Those that are clean have nothing
else done to them and so eventually get cleaned up by background
reclaim. i.e. it is assumed we'll never dirty/relog an inode marked
XFS_ISTALE.
On journal commit dirty stale inodes as are handled by both
buffer and inode log items to run though xfs_istale_done() and
removed from the AIL (buffer log item commit) or the log item will
simply unpin it because the buffer log item will clean it. What happens
to any specific inode is entirely dependent on which log item wins
the commit race, but the result is the same - stale inodes are
clean, not attached to the cluster buffer, and not in the AIL. Hence
inode reclaim can just free these inodes without further care.
However, if the stale inode is relogged, it gets dirtied again and
relogged into the CIL. Most of the time this isn't an issue, because
relogging simply changes the inode's location in the current
checkpoint. Problems arise, however, when the CIL checkpoints
between two transactions in the xfs_inactive_ifree() deferops
processing. This results in the XFS_ISTALE inode being redirtied
and inserted into the CIL without any of the other stale cluster
buffer infrastructure being in place.
Hence on journal commit, it simply gets unpinned, so it remains
dirty in memory. Everything in inode writeback avoids XFS_ISTALE
inodes so it can't be written back, and it is not tracked in the AIL
so there's not even a trigger to attempt to clean the inode. Hence
the inode just sits dirty in memory until inode reclaim comes along,
sees that it is XFS_ISTALE, and goes to reclaim it. This reclaiming
of a dirty inode caused use after free, list corruptions and other
nasty issues later in this patchset.
Hence this patch addresses a violation of the "never log XFS_ISTALE
inodes" caused by the deferops processing rolling a transaction
and relogging a stale inode in xfs_inactive_free. It also adds a
bunch of asserts to catch this problem in debug kernels so that
we don't reintroduce this problem in future.
Reproducer for this issue was generic/558 on a v4 filesystem.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2020-06-30 05:48:45 +08:00
|
|
|
xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);
|
2013-09-20 23:06:11 +08:00
|
|
|
|
2018-07-12 13:26:07 +08:00
|
|
|
error = xfs_ifree(tp, ip);
|
xfs: Don't allow logging of XFS_ISTALE inodes
In tracking down a problem in this patchset, I discovered we are
reclaiming dirty stale inodes. This wasn't discovered until inodes
were always attached to the cluster buffer and then the rcu callback
that freed inodes was assert failing because the inode still had an
active pointer to the cluster buffer after it had been reclaimed.
Debugging the issue indicated that this was a pre-existing issue
resulting from the way the inodes are handled in xfs_inactive_ifree.
When we free a cluster buffer from xfs_ifree_cluster, all the inodes
in cache are marked XFS_ISTALE. Those that are clean have nothing
else done to them and so eventually get cleaned up by background
reclaim. i.e. it is assumed we'll never dirty/relog an inode marked
XFS_ISTALE.
On journal commit dirty stale inodes as are handled by both
buffer and inode log items to run though xfs_istale_done() and
removed from the AIL (buffer log item commit) or the log item will
simply unpin it because the buffer log item will clean it. What happens
to any specific inode is entirely dependent on which log item wins
the commit race, but the result is the same - stale inodes are
clean, not attached to the cluster buffer, and not in the AIL. Hence
inode reclaim can just free these inodes without further care.
However, if the stale inode is relogged, it gets dirtied again and
relogged into the CIL. Most of the time this isn't an issue, because
relogging simply changes the inode's location in the current
checkpoint. Problems arise, however, when the CIL checkpoints
between two transactions in the xfs_inactive_ifree() deferops
processing. This results in the XFS_ISTALE inode being redirtied
and inserted into the CIL without any of the other stale cluster
buffer infrastructure being in place.
Hence on journal commit, it simply gets unpinned, so it remains
dirty in memory. Everything in inode writeback avoids XFS_ISTALE
inodes so it can't be written back, and it is not tracked in the AIL
so there's not even a trigger to attempt to clean the inode. Hence
the inode just sits dirty in memory until inode reclaim comes along,
sees that it is XFS_ISTALE, and goes to reclaim it. This reclaiming
of a dirty inode caused use after free, list corruptions and other
nasty issues later in this patchset.
Hence this patch addresses a violation of the "never log XFS_ISTALE
inodes" caused by the deferops processing rolling a transaction
and relogging a stale inode in xfs_inactive_free. It also adds a
bunch of asserts to catch this problem in debug kernels so that
we don't reintroduce this problem in future.
Reproducer for this issue was generic/558 on a v4 filesystem.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2020-06-30 05:48:45 +08:00
|
|
|
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
|
2013-09-20 23:06:11 +08:00
|
|
|
if (error) {
|
|
|
|
/*
|
|
|
|
* If we fail to free the inode, shut down. The cancel
|
|
|
|
* might do that, we need to make sure. Otherwise the
|
|
|
|
* inode might be lost for a long time or forever.
|
|
|
|
*/
|
2021-08-19 09:46:53 +08:00
|
|
|
if (!xfs_is_shutdown(mp)) {
|
2013-09-20 23:06:11 +08:00
|
|
|
xfs_notice(mp, "%s: xfs_ifree returned error %d",
|
|
|
|
__func__, error);
|
|
|
|
xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR);
|
|
|
|
}
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2013-09-20 23:06:11 +08:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Credit the quota account(s). The inode is gone.
|
|
|
|
*/
|
|
|
|
xfs_trans_mod_dquot_byino(tp, ip, XFS_TRANS_DQ_ICOUNT, -1);
|
|
|
|
|
2023-06-05 12:48:15 +08:00
|
|
|
return xfs_trans_commit(tp);
|
2013-09-20 23:06:11 +08:00
|
|
|
}
|
|
|
|
|
2021-08-07 02:05:39 +08:00
|
|
|
/*
|
|
|
|
* Returns true if we need to update the on-disk metadata before we can free
|
|
|
|
* the memory used by this inode. Updates include freeing post-eof
|
|
|
|
* preallocations; freeing COW staging extents; and marking the inode free in
|
|
|
|
* the inobt if it is on the unlinked list.
|
|
|
|
*/
|
|
|
|
bool
|
|
|
|
xfs_inode_needs_inactive(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
struct xfs_mount *mp = ip->i_mount;
|
2022-07-10 01:56:05 +08:00
|
|
|
struct xfs_ifork *cow_ifp = xfs_ifork_ptr(ip, XFS_COW_FORK);
|
2021-08-07 02:05:39 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the inode is already free, then there can be nothing
|
|
|
|
* to clean up here.
|
|
|
|
*/
|
|
|
|
if (VFS_I(ip)->i_mode == 0)
|
|
|
|
return false;
|
|
|
|
|
2023-09-11 23:42:34 +08:00
|
|
|
/*
|
|
|
|
* If this is a read-only mount, don't do this (would generate I/O)
|
|
|
|
* unless we're in log recovery and cleaning the iunlinked list.
|
|
|
|
*/
|
|
|
|
if (xfs_is_readonly(mp) && !xlog_recovery_needed(mp->m_log))
|
2021-08-07 02:05:39 +08:00
|
|
|
return false;
|
|
|
|
|
|
|
|
/* If the log isn't running, push inodes straight to reclaim. */
|
2021-08-19 09:46:53 +08:00
|
|
|
if (xfs_is_shutdown(mp) || xfs_has_norecovery(mp))
|
2021-08-07 02:05:39 +08:00
|
|
|
return false;
|
|
|
|
|
|
|
|
/* Metadata inodes require explicit resource cleanup. */
|
|
|
|
if (xfs_is_metadata_inode(ip))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/* Want to clean out the cow blocks if there are any. */
|
|
|
|
if (cow_ifp && cow_ifp->if_bytes > 0)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
/* Unlinked files must be freed. */
|
|
|
|
if (VFS_I(ip)->i_nlink == 0)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This file isn't being freed, so check if there are post-eof blocks
|
|
|
|
* to free. @force is true because we are evicting an inode from the
|
|
|
|
* cache. Post-eof blocks must be freed, lest we end up with broken
|
|
|
|
* free space accounting.
|
|
|
|
*
|
|
|
|
* Note: don't bother with iolock here since lockdep complains about
|
|
|
|
* acquiring it in reclaim context. We have the only reference to the
|
|
|
|
* inode at this point anyways.
|
|
|
|
*/
|
|
|
|
return xfs_can_free_eofblocks(ip, true);
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:45 +08:00
|
|
|
/*
|
|
|
|
* xfs_inactive
|
|
|
|
*
|
|
|
|
* This is called when the vnode reference count for the vnode
|
|
|
|
* goes to zero. If the file has been unlinked, then it must
|
|
|
|
* now be truncated. Also, we clear all of the read-ahead state
|
|
|
|
* kept for the inode here since the file is now closed.
|
|
|
|
*/
|
2023-06-05 12:48:15 +08:00
|
|
|
int
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_inactive(
|
|
|
|
xfs_inode_t *ip)
|
|
|
|
{
|
2013-08-12 18:49:59 +08:00
|
|
|
struct xfs_mount *mp;
|
2023-06-05 12:48:15 +08:00
|
|
|
int error = 0;
|
2013-08-12 18:49:59 +08:00
|
|
|
int truncate = 0;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the inode is already free, then there can be nothing
|
|
|
|
* to clean up here.
|
|
|
|
*/
|
2016-02-09 13:54:58 +08:00
|
|
|
if (VFS_I(ip)->i_mode == 0) {
|
2013-08-12 18:49:45 +08:00
|
|
|
ASSERT(ip->i_df.if_broot_bytes == 0);
|
2021-06-01 02:31:57 +08:00
|
|
|
goto out;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
mp = ip->i_mount;
|
2016-10-04 00:11:29 +08:00
|
|
|
ASSERT(!xfs_iflags_test(ip, XFS_IRECOVERY));
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2023-09-11 23:42:34 +08:00
|
|
|
/*
|
|
|
|
* If this is a read-only mount, don't do this (would generate I/O)
|
|
|
|
* unless we're in log recovery and cleaning the iunlinked list.
|
|
|
|
*/
|
|
|
|
if (xfs_is_readonly(mp) && !xlog_recovery_needed(mp->m_log))
|
2021-06-01 02:31:57 +08:00
|
|
|
goto out;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2021-03-23 00:51:54 +08:00
|
|
|
/* Metadata inodes require explicit resource cleanup. */
|
|
|
|
if (xfs_is_metadata_inode(ip))
|
2021-06-01 02:31:57 +08:00
|
|
|
goto out;
|
2021-03-23 00:51:54 +08:00
|
|
|
|
2018-03-07 09:08:31 +08:00
|
|
|
/* Try to clean out the cow blocks if there are any. */
|
2018-07-18 07:51:51 +08:00
|
|
|
if (xfs_inode_has_cow_data(ip))
|
2018-03-07 09:08:31 +08:00
|
|
|
xfs_reflink_cancel_cow_range(ip, 0, NULLFILEOFF, true);
|
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
if (VFS_I(ip)->i_nlink != 0) {
|
2013-08-12 18:49:45 +08:00
|
|
|
/*
|
|
|
|
* force is true because we are evicting an inode from the
|
|
|
|
* cache. Post-eof blocks must be freed, lest we end up with
|
|
|
|
* broken free space accounting.
|
2017-04-12 01:50:05 +08:00
|
|
|
*
|
|
|
|
* Note: don't bother with iolock here since lockdep complains
|
|
|
|
* about acquiring it in reclaim context. We have the only
|
|
|
|
* reference to the inode at this point anyways.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
2017-04-12 01:50:05 +08:00
|
|
|
if (xfs_can_free_eofblocks(ip, true))
|
2023-06-05 12:48:15 +08:00
|
|
|
error = xfs_free_eofblocks(ip);
|
2013-09-20 23:06:12 +08:00
|
|
|
|
2021-06-01 02:31:57 +08:00
|
|
|
goto out;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
if (S_ISREG(VFS_I(ip)->i_mode) &&
|
2021-03-30 02:11:40 +08:00
|
|
|
(ip->i_disk_size != 0 || XFS_ISIZE(ip) != 0 ||
|
2020-05-19 01:27:22 +08:00
|
|
|
ip->i_df.if_nextents > 0 || ip->i_delayed_blks > 0))
|
2013-08-12 18:49:45 +08:00
|
|
|
truncate = 1;
|
|
|
|
|
2023-09-11 23:39:08 +08:00
|
|
|
if (xfs_iflags_test(ip, XFS_IQUOTAUNCHECKED)) {
|
2023-09-24 23:35:53 +08:00
|
|
|
/*
|
|
|
|
* If this inode is being inactivated during a quotacheck and
|
|
|
|
* has not yet been scanned by quotacheck, we /must/ remove
|
|
|
|
* the dquots from the inode before inactivation changes the
|
|
|
|
* block and inode counts. Most probably this is a result of
|
|
|
|
* reloading the incore iunlinked list to purge unrecovered
|
|
|
|
* unlinked inodes.
|
|
|
|
*/
|
2023-09-11 23:39:08 +08:00
|
|
|
xfs_qm_dqdetach(ip);
|
|
|
|
} else {
|
|
|
|
error = xfs_qm_dqattach(ip);
|
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
}
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
if (S_ISLNK(VFS_I(ip)->i_mode))
|
2013-09-20 23:06:09 +08:00
|
|
|
error = xfs_inactive_symlink(ip);
|
2013-09-20 23:06:10 +08:00
|
|
|
else if (truncate)
|
|
|
|
error = xfs_inactive_truncate(ip);
|
|
|
|
if (error)
|
2021-06-01 02:31:57 +08:00
|
|
|
goto out;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If there are attributes associated with the file then blow them away
|
|
|
|
* now. The code calls a routine that recursively deconstructs the
|
2015-05-29 05:40:08 +08:00
|
|
|
* attribute fork. If also blows away the in-core attribute fork.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
2022-07-10 01:56:06 +08:00
|
|
|
if (xfs_inode_has_attr_fork(ip)) {
|
2013-08-12 18:49:45 +08:00
|
|
|
error = xfs_attr_inactive(ip);
|
|
|
|
if (error)
|
2021-06-01 02:31:57 +08:00
|
|
|
goto out;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
2021-03-30 02:11:44 +08:00
|
|
|
ASSERT(ip->i_forkoff == 0);
|
2013-08-12 18:49:45 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Free the inode.
|
|
|
|
*/
|
2023-06-05 12:48:15 +08:00
|
|
|
error = xfs_inactive_ifree(ip);
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2021-06-01 02:31:57 +08:00
|
|
|
out:
|
2013-08-12 18:49:45 +08:00
|
|
|
/*
|
2021-06-01 02:31:57 +08:00
|
|
|
* We're done making metadata updates for this inode, so we can release
|
|
|
|
* the attached dquots.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
|
|
|
xfs_qm_dqdetach(ip);
|
2023-06-05 12:48:15 +08:00
|
|
|
return error;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
2019-02-08 02:37:16 +08:00
|
|
|
/*
|
|
|
|
* In-Core Unlinked List Lookups
|
|
|
|
* =============================
|
|
|
|
*
|
|
|
|
* Every inode is supposed to be reachable from some other piece of metadata
|
|
|
|
* with the exception of the root directory. Inodes with a connection to a
|
|
|
|
* file descriptor but not linked from anywhere in the on-disk directory tree
|
|
|
|
* are collectively known as unlinked inodes, though the filesystem itself
|
|
|
|
* maintains links to these inodes so that on-disk metadata are consistent.
|
|
|
|
*
|
|
|
|
* XFS implements a per-AG on-disk hash table of unlinked inodes. The AGI
|
|
|
|
* header contains a number of buckets that point to an inode, and each inode
|
|
|
|
* record has a pointer to the next inode in the hash chain. This
|
|
|
|
* singly-linked list causes scaling problems in the iunlink remove function
|
|
|
|
* because we must walk that list to find the inode that points to the inode
|
|
|
|
* being removed from the unlinked hash bucket list.
|
|
|
|
*
|
2022-07-14 09:46:43 +08:00
|
|
|
* Hence we keep an in-memory double linked list to link each inode on an
|
|
|
|
* unlinked list. Because there are 64 unlinked lists per AGI, keeping pointer
|
|
|
|
* based lists would require having 64 list heads in the perag, one for each
|
|
|
|
* list. This is expensive in terms of memory (think millions of AGs) and cache
|
|
|
|
* misses on lookups. Instead, use the fact that inodes on the unlinked list
|
|
|
|
* must be referenced at the VFS level to keep them on the list and hence we
|
|
|
|
* have an existence guarantee for inodes on the unlinked list.
|
2019-02-08 02:37:16 +08:00
|
|
|
*
|
2022-07-14 09:46:43 +08:00
|
|
|
* Given we have an existence guarantee, we can use lockless inode cache lookups
|
|
|
|
* to resolve aginos to xfs inodes. This means we only need 8 bytes per inode
|
|
|
|
* for the double linked unlinked list, and we don't need any extra locking to
|
|
|
|
* keep the list safe as all manipulations are done under the AGI buffer lock.
|
|
|
|
* Keeping the list up to date does not require memory allocation, just finding
|
|
|
|
* the XFS inode and updating the next/prev unlinked list aginos.
|
2019-02-08 02:37:16 +08:00
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
2022-07-14 09:43:09 +08:00
|
|
|
* Find an inode on the unlinked list. This does not take references to the
|
|
|
|
* inode as we have existence guarantees by holding the AGI buffer lock and that
|
|
|
|
* only unlinked, referenced inodes can be on the unlinked inode list. If we
|
|
|
|
* don't find the inode in cache, then let the caller handle the situation.
|
2019-02-08 02:37:16 +08:00
|
|
|
*/
|
2022-07-14 09:43:09 +08:00
|
|
|
static struct xfs_inode *
|
|
|
|
xfs_iunlink_lookup(
|
2019-02-08 02:37:16 +08:00
|
|
|
struct xfs_perag *pag,
|
|
|
|
xfs_agino_t agino)
|
|
|
|
{
|
2022-07-14 09:43:09 +08:00
|
|
|
struct xfs_inode *ip;
|
2019-02-08 02:37:16 +08:00
|
|
|
|
2022-07-14 09:43:09 +08:00
|
|
|
rcu_read_lock();
|
|
|
|
ip = radix_tree_lookup(&pag->pag_ici_root, agino);
|
2023-09-11 23:39:06 +08:00
|
|
|
if (!ip) {
|
|
|
|
/* Caller can handle inode not being in memory. */
|
|
|
|
rcu_read_unlock();
|
|
|
|
return NULL;
|
|
|
|
}
|
2019-02-08 02:37:16 +08:00
|
|
|
|
|
|
|
/*
|
2023-09-11 23:39:06 +08:00
|
|
|
* Inode in RCU freeing limbo should not happen. Warn about this and
|
|
|
|
* let the caller handle the failure.
|
2019-02-08 02:37:16 +08:00
|
|
|
*/
|
2023-09-11 23:39:06 +08:00
|
|
|
if (WARN_ON_ONCE(!ip->i_ino)) {
|
2022-07-14 09:43:09 +08:00
|
|
|
rcu_read_unlock();
|
|
|
|
return NULL;
|
2019-02-08 02:37:16 +08:00
|
|
|
}
|
2022-07-14 09:43:09 +08:00
|
|
|
ASSERT(!xfs_iflags_test(ip, XFS_IRECLAIMABLE | XFS_IRECLAIM));
|
|
|
|
rcu_read_unlock();
|
|
|
|
return ip;
|
2019-02-08 02:37:16 +08:00
|
|
|
}
|
|
|
|
|
2023-09-11 23:39:06 +08:00
|
|
|
/*
|
|
|
|
* Update the prev pointer of the next agino. Returns -ENOLINK if the inode
|
|
|
|
* is not in cache.
|
|
|
|
*/
|
2019-02-08 02:37:16 +08:00
|
|
|
static int
|
2022-07-14 09:46:43 +08:00
|
|
|
xfs_iunlink_update_backref(
|
2019-02-08 02:37:16 +08:00
|
|
|
struct xfs_perag *pag,
|
|
|
|
xfs_agino_t prev_agino,
|
2022-07-14 09:46:43 +08:00
|
|
|
xfs_agino_t next_agino)
|
2019-02-08 02:37:16 +08:00
|
|
|
{
|
2022-07-14 09:46:43 +08:00
|
|
|
struct xfs_inode *ip;
|
2019-02-08 02:37:16 +08:00
|
|
|
|
2022-07-14 09:46:43 +08:00
|
|
|
/* No update necessary if we are at the end of the list. */
|
|
|
|
if (next_agino == NULLAGINO)
|
2019-02-08 02:37:16 +08:00
|
|
|
return 0;
|
|
|
|
|
2022-07-14 09:46:43 +08:00
|
|
|
ip = xfs_iunlink_lookup(pag, next_agino);
|
|
|
|
if (!ip)
|
2023-09-11 23:39:06 +08:00
|
|
|
return -ENOLINK;
|
|
|
|
|
2022-07-14 09:46:43 +08:00
|
|
|
ip->i_prev_unlinked = prev_agino;
|
|
|
|
return 0;
|
2019-02-08 02:37:16 +08:00
|
|
|
}
|
|
|
|
|
2019-02-08 02:37:14 +08:00
|
|
|
/*
|
|
|
|
* Point the AGI unlinked bucket at an inode and log the results. The caller
|
|
|
|
* is responsible for validating the old value.
|
|
|
|
*/
|
|
|
|
STATIC int
|
|
|
|
xfs_iunlink_update_bucket(
|
|
|
|
struct xfs_trans *tp,
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_perag *pag,
|
2019-02-08 02:37:14 +08:00
|
|
|
struct xfs_buf *agibp,
|
|
|
|
unsigned int bucket_index,
|
|
|
|
xfs_agino_t new_agino)
|
|
|
|
{
|
2020-03-10 23:57:29 +08:00
|
|
|
struct xfs_agi *agi = agibp->b_addr;
|
2019-02-08 02:37:14 +08:00
|
|
|
xfs_agino_t old_value;
|
|
|
|
int offset;
|
|
|
|
|
2022-07-07 17:13:10 +08:00
|
|
|
ASSERT(xfs_verify_agino_or_null(pag, new_agino));
|
2019-02-08 02:37:14 +08:00
|
|
|
|
|
|
|
old_value = be32_to_cpu(agi->agi_unlinked[bucket_index]);
|
2021-06-02 08:48:51 +08:00
|
|
|
trace_xfs_iunlink_update_bucket(tp->t_mountp, pag->pag_agno, bucket_index,
|
2019-02-08 02:37:14 +08:00
|
|
|
old_value, new_agino);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We should never find the head of the list already set to the value
|
|
|
|
* passed in because either we're adding or removing ourselves from the
|
|
|
|
* head of the list.
|
|
|
|
*/
|
2019-11-03 00:40:53 +08:00
|
|
|
if (old_value == new_agino) {
|
2020-03-12 01:37:54 +08:00
|
|
|
xfs_buf_mark_corrupt(agibp);
|
2019-02-08 02:37:14 +08:00
|
|
|
return -EFSCORRUPTED;
|
2019-11-03 00:40:53 +08:00
|
|
|
}
|
2019-02-08 02:37:14 +08:00
|
|
|
|
|
|
|
agi->agi_unlinked[bucket_index] = cpu_to_be32(new_agino);
|
|
|
|
offset = offsetof(struct xfs_agi, agi_unlinked) +
|
|
|
|
(sizeof(xfs_agino_t) * bucket_index);
|
|
|
|
xfs_trans_log_buf(tp, agibp, offset, offset + sizeof(xfs_agino_t) - 1);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-09-11 23:39:06 +08:00
|
|
|
/*
|
|
|
|
* Load the inode @next_agino into the cache and set its prev_unlinked pointer
|
|
|
|
* to @prev_agino. Caller must hold the AGI to synchronize with other changes
|
|
|
|
* to the unlinked list.
|
|
|
|
*/
|
|
|
|
STATIC int
|
|
|
|
xfs_iunlink_reload_next(
|
|
|
|
struct xfs_trans *tp,
|
|
|
|
struct xfs_buf *agibp,
|
|
|
|
xfs_agino_t prev_agino,
|
|
|
|
xfs_agino_t next_agino)
|
|
|
|
{
|
|
|
|
struct xfs_perag *pag = agibp->b_pag;
|
|
|
|
struct xfs_mount *mp = pag->pag_mount;
|
|
|
|
struct xfs_inode *next_ip = NULL;
|
|
|
|
xfs_ino_t ino;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
ASSERT(next_agino != NULLAGINO);
|
|
|
|
|
|
|
|
#ifdef DEBUG
|
|
|
|
rcu_read_lock();
|
|
|
|
next_ip = radix_tree_lookup(&pag->pag_ici_root, next_agino);
|
|
|
|
ASSERT(next_ip == NULL);
|
|
|
|
rcu_read_unlock();
|
|
|
|
#endif
|
|
|
|
|
|
|
|
xfs_info_ratelimited(mp,
|
|
|
|
"Found unrecovered unlinked inode 0x%x in AG 0x%x. Initiating recovery.",
|
|
|
|
next_agino, pag->pag_agno);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Use an untrusted lookup just to be cautious in case the AGI has been
|
|
|
|
* corrupted and now points at a free inode. That shouldn't happen,
|
|
|
|
* but we'd rather shut down now since we're already running in a weird
|
|
|
|
* situation.
|
|
|
|
*/
|
|
|
|
ino = XFS_AGINO_TO_INO(mp, pag->pag_agno, next_agino);
|
|
|
|
error = xfs_iget(mp, tp, ino, XFS_IGET_UNTRUSTED, 0, &next_ip);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
/* If this is not an unlinked inode, something is very wrong. */
|
|
|
|
if (VFS_I(next_ip)->i_nlink != 0) {
|
|
|
|
error = -EFSCORRUPTED;
|
|
|
|
goto rele;
|
|
|
|
}
|
|
|
|
|
|
|
|
next_ip->i_prev_unlinked = prev_agino;
|
|
|
|
trace_xfs_iunlink_reload_next(next_ip);
|
|
|
|
rele:
|
|
|
|
ASSERT(!(VFS_I(next_ip)->i_state & I_DONTCACHE));
|
2023-09-11 23:39:08 +08:00
|
|
|
if (xfs_is_quotacheck_running(mp) && next_ip)
|
|
|
|
xfs_iflags_set(next_ip, XFS_IQUOTAUNCHECKED);
|
2023-09-11 23:39:06 +08:00
|
|
|
xfs_irele(next_ip);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2022-07-14 09:36:40 +08:00
|
|
|
static int
|
|
|
|
xfs_iunlink_insert_inode(
|
2019-02-08 02:37:15 +08:00
|
|
|
struct xfs_trans *tp,
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_perag *pag,
|
2022-07-14 09:36:40 +08:00
|
|
|
struct xfs_buf *agibp,
|
2019-02-08 02:37:13 +08:00
|
|
|
struct xfs_inode *ip)
|
2019-02-08 02:37:15 +08:00
|
|
|
{
|
|
|
|
struct xfs_mount *mp = tp->t_mountp;
|
2022-07-14 09:36:40 +08:00
|
|
|
struct xfs_agi *agi = agibp->b_addr;
|
2019-02-08 02:37:14 +08:00
|
|
|
xfs_agino_t next_agino;
|
2019-02-08 02:37:13 +08:00
|
|
|
xfs_agino_t agino = XFS_INO_TO_AGINO(mp, ip->i_ino);
|
|
|
|
short bucket_index = agino % XFS_AGI_UNLINKED_BUCKETS;
|
2019-02-08 02:37:15 +08:00
|
|
|
int error;
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2019-02-08 02:37:14 +08:00
|
|
|
* Get the index into the agi hash table for the list this inode will
|
|
|
|
* go on. Make sure the pointer isn't garbage and that this inode
|
|
|
|
* isn't already on the list.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2019-02-08 02:37:14 +08:00
|
|
|
next_agino = be32_to_cpu(agi->agi_unlinked[bucket_index]);
|
|
|
|
if (next_agino == agino ||
|
2022-07-07 17:13:10 +08:00
|
|
|
!xfs_verify_agino_or_null(pag, next_agino)) {
|
2020-03-12 01:37:54 +08:00
|
|
|
xfs_buf_mark_corrupt(agibp);
|
2022-07-14 09:36:40 +08:00
|
|
|
return -EFSCORRUPTED;
|
2019-02-08 02:37:15 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2022-07-14 09:46:43 +08:00
|
|
|
* Update the prev pointer in the next inode to point back to this
|
|
|
|
* inode.
|
2019-02-08 02:37:15 +08:00
|
|
|
*/
|
2022-07-14 09:46:43 +08:00
|
|
|
error = xfs_iunlink_update_backref(pag, agino, next_agino);
|
2023-09-11 23:39:06 +08:00
|
|
|
if (error == -ENOLINK)
|
|
|
|
error = xfs_iunlink_reload_next(tp, agibp, agino, next_agino);
|
2022-07-14 09:46:43 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2019-02-08 02:37:14 +08:00
|
|
|
if (next_agino != NULLAGINO) {
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2019-02-08 02:37:15 +08:00
|
|
|
* There is already another inode in the bucket, so point this
|
|
|
|
* inode to the current head of the list.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2022-07-14 09:46:59 +08:00
|
|
|
error = xfs_iunlink_log_inode(tp, ip, pag, next_agino);
|
2007-11-23 13:27:51 +08:00
|
|
|
if (error)
|
2022-07-14 09:36:40 +08:00
|
|
|
return error;
|
2022-07-14 09:38:54 +08:00
|
|
|
ip->i_next_unlinked = next_agino;
|
2019-02-08 02:37:15 +08:00
|
|
|
}
|
|
|
|
|
2019-02-08 02:37:14 +08:00
|
|
|
/* Point the head of the list to point to this inode. */
|
2023-09-11 23:39:07 +08:00
|
|
|
ip->i_prev_unlinked = NULLAGINO;
|
2022-07-14 09:36:40 +08:00
|
|
|
return xfs_iunlink_update_bucket(tp, pag, agibp, bucket_index, agino);
|
2019-02-08 02:37:15 +08:00
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
xfs: don't ever put nlink > 0 inodes on the unlinked list
When XFS creates an O_TMPFILE file, the inode is created with nlink = 1,
put on the unlinked list, and then the VFS sets nlink = 0 in d_tmpfile.
If we crash before anything logs the inode (it's dirty incore but the
vfs doesn't tell us it's dirty so we never log that change), the iunlink
processing part of recovery will then explode with a pile of:
XFS: Assertion failed: VFS_I(ip)->i_nlink == 0, file:
fs/xfs/xfs_log_recover.c, line: 5072
Worse yet, since nlink is nonzero, the inodes also don't get cleaned up
and they just leak until the next xfs_repair run.
Therefore, change xfs_iunlink to require that inodes being put on the
unlinked list have nlink == 0, change the tmpfile callers to instantiate
nodes that way, and set the nlink to 1 just prior to calling d_tmpfile.
Fix the comment for xfs_iunlink while we're at it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2019-02-14 03:15:17 +08:00
|
|
|
* This is called when the inode's link count has gone to 0 or we are creating
|
|
|
|
* a tmpfile via O_TMPFILE. The inode @ip must have nlink == 0.
|
2016-02-09 13:54:58 +08:00
|
|
|
*
|
|
|
|
* We place the on-disk inode on a list in the AGI. It will be pulled from this
|
|
|
|
* list when the inode is freed.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2016-02-09 13:54:58 +08:00
|
|
|
STATIC int
|
2005-04-17 06:20:36 +08:00
|
|
|
xfs_iunlink(
|
2019-02-08 02:37:13 +08:00
|
|
|
struct xfs_trans *tp,
|
|
|
|
struct xfs_inode *ip)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2019-02-08 02:37:13 +08:00
|
|
|
struct xfs_mount *mp = tp->t_mountp;
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_perag *pag;
|
2019-02-08 02:37:13 +08:00
|
|
|
struct xfs_buf *agibp;
|
|
|
|
int error;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
xfs: don't ever put nlink > 0 inodes on the unlinked list
When XFS creates an O_TMPFILE file, the inode is created with nlink = 1,
put on the unlinked list, and then the VFS sets nlink = 0 in d_tmpfile.
If we crash before anything logs the inode (it's dirty incore but the
vfs doesn't tell us it's dirty so we never log that change), the iunlink
processing part of recovery will then explode with a pile of:
XFS: Assertion failed: VFS_I(ip)->i_nlink == 0, file:
fs/xfs/xfs_log_recover.c, line: 5072
Worse yet, since nlink is nonzero, the inodes also don't get cleaned up
and they just leak until the next xfs_repair run.
Therefore, change xfs_iunlink to require that inodes being put on the
unlinked list have nlink == 0, change the tmpfile callers to instantiate
nodes that way, and set the nlink to 1 just prior to calling d_tmpfile.
Fix the comment for xfs_iunlink while we're at it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2019-02-14 03:15:17 +08:00
|
|
|
ASSERT(VFS_I(ip)->i_nlink == 0);
|
2016-02-09 13:54:58 +08:00
|
|
|
ASSERT(VFS_I(ip)->i_mode != 0);
|
2019-02-08 02:37:16 +08:00
|
|
|
trace_xfs_iunlink(ip);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2021-06-02 08:48:51 +08:00
|
|
|
pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ip->i_ino));
|
|
|
|
|
2019-02-08 02:37:13 +08:00
|
|
|
/* Get the agi buffer first. It ensures lock ordering on the list. */
|
2022-07-07 17:07:47 +08:00
|
|
|
error = xfs_read_agi(pag, tp, &agibp);
|
2007-10-11 15:44:18 +08:00
|
|
|
if (error)
|
2021-06-02 08:48:51 +08:00
|
|
|
goto out;
|
2008-11-28 11:23:37 +08:00
|
|
|
|
2022-07-14 09:36:40 +08:00
|
|
|
error = xfs_iunlink_insert_inode(tp, pag, agibp, ip);
|
2021-06-02 08:48:51 +08:00
|
|
|
out:
|
|
|
|
xfs_perag_put(pag);
|
|
|
|
return error;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2022-07-14 09:36:40 +08:00
|
|
|
static int
|
|
|
|
xfs_iunlink_remove_inode(
|
2019-02-08 02:37:13 +08:00
|
|
|
struct xfs_trans *tp,
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_perag *pag,
|
2022-07-14 09:36:40 +08:00
|
|
|
struct xfs_buf *agibp,
|
2019-02-08 02:37:13 +08:00
|
|
|
struct xfs_inode *ip)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2019-02-08 02:37:13 +08:00
|
|
|
struct xfs_mount *mp = tp->t_mountp;
|
2022-07-14 09:36:40 +08:00
|
|
|
struct xfs_agi *agi = agibp->b_addr;
|
2019-02-08 02:37:13 +08:00
|
|
|
xfs_agino_t agino = XFS_INO_TO_AGINO(mp, ip->i_ino);
|
2019-02-08 02:37:15 +08:00
|
|
|
xfs_agino_t head_agino;
|
2019-02-08 02:37:13 +08:00
|
|
|
short bucket_index = agino % XFS_AGI_UNLINKED_BUCKETS;
|
|
|
|
int error;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2019-02-08 02:37:16 +08:00
|
|
|
trace_xfs_iunlink_remove(ip);
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2019-02-08 02:37:14 +08:00
|
|
|
* Get the index into the agi hash table for the list this inode will
|
|
|
|
* go on. Make sure the head pointer isn't garbage.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2019-02-08 02:37:15 +08:00
|
|
|
head_agino = be32_to_cpu(agi->agi_unlinked[bucket_index]);
|
2022-07-07 17:13:10 +08:00
|
|
|
if (!xfs_verify_agino(pag, head_agino)) {
|
2018-06-05 02:27:51 +08:00
|
|
|
XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp,
|
|
|
|
agi, sizeof(*agi));
|
|
|
|
return -EFSCORRUPTED;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2019-02-08 02:37:15 +08:00
|
|
|
/*
|
|
|
|
* Set our inode's next_unlinked pointer to NULL and then return
|
|
|
|
* the old pointer value so that we can update whatever was previous
|
|
|
|
* to us in the list to point to whatever was next in the list.
|
|
|
|
*/
|
2022-07-14 09:46:59 +08:00
|
|
|
error = xfs_iunlink_log_inode(tp, ip, pag, NULLAGINO);
|
2019-02-08 02:37:15 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
2019-02-08 02:37:14 +08:00
|
|
|
|
2019-02-08 02:37:16 +08:00
|
|
|
/*
|
2022-07-14 09:46:43 +08:00
|
|
|
* Update the prev pointer in the next inode to point back to previous
|
|
|
|
* inode in the chain.
|
2019-02-08 02:37:16 +08:00
|
|
|
*/
|
2022-07-14 09:46:43 +08:00
|
|
|
error = xfs_iunlink_update_backref(pag, ip->i_prev_unlinked,
|
|
|
|
ip->i_next_unlinked);
|
2023-09-11 23:39:06 +08:00
|
|
|
if (error == -ENOLINK)
|
|
|
|
error = xfs_iunlink_reload_next(tp, agibp, ip->i_prev_unlinked,
|
|
|
|
ip->i_next_unlinked);
|
2022-07-14 09:46:43 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
2019-02-08 02:37:16 +08:00
|
|
|
|
2020-07-14 00:13:00 +08:00
|
|
|
if (head_agino != agino) {
|
2022-07-14 09:43:09 +08:00
|
|
|
struct xfs_inode *prev_ip;
|
2012-07-04 00:21:22 +08:00
|
|
|
|
2022-07-14 09:46:43 +08:00
|
|
|
prev_ip = xfs_iunlink_lookup(pag, ip->i_prev_unlinked);
|
|
|
|
if (!prev_ip)
|
|
|
|
return -EFSCORRUPTED;
|
2019-02-08 02:37:16 +08:00
|
|
|
|
2022-07-14 09:46:59 +08:00
|
|
|
error = xfs_iunlink_log_inode(tp, prev_ip, pag,
|
2022-07-14 09:46:46 +08:00
|
|
|
ip->i_next_unlinked);
|
2022-07-14 09:43:09 +08:00
|
|
|
prev_ip->i_next_unlinked = ip->i_next_unlinked;
|
2022-07-14 09:46:43 +08:00
|
|
|
} else {
|
|
|
|
/* Point the head of the list to the next unlinked inode. */
|
|
|
|
error = xfs_iunlink_update_bucket(tp, pag, agibp, bucket_index,
|
|
|
|
ip->i_next_unlinked);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2019-02-08 02:37:16 +08:00
|
|
|
|
2022-07-14 09:43:09 +08:00
|
|
|
ip->i_next_unlinked = NULLAGINO;
|
2023-09-11 23:39:07 +08:00
|
|
|
ip->i_prev_unlinked = 0;
|
2022-07-14 09:46:43 +08:00
|
|
|
return error;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2022-07-14 09:36:40 +08:00
|
|
|
/*
|
|
|
|
* Pull the on-disk inode from the AGI unlinked list.
|
|
|
|
*/
|
|
|
|
STATIC int
|
|
|
|
xfs_iunlink_remove(
|
|
|
|
struct xfs_trans *tp,
|
|
|
|
struct xfs_perag *pag,
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
struct xfs_buf *agibp;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
trace_xfs_iunlink_remove(ip);
|
|
|
|
|
|
|
|
/* Get the agi buffer first. It ensures lock ordering on the list. */
|
|
|
|
error = xfs_read_agi(pag, tp, &agibp);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
return xfs_iunlink_remove_inode(tp, pag, agibp, ip);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2020-03-25 11:10:30 +08:00
|
|
|
/*
|
2020-06-30 05:49:18 +08:00
|
|
|
* Look up the inode number specified and if it is not already marked XFS_ISTALE
|
|
|
|
* mark it stale. We should only find clean inodes in this lookup that aren't
|
|
|
|
* already stale.
|
2020-03-25 11:10:30 +08:00
|
|
|
*/
|
2020-06-30 05:49:18 +08:00
|
|
|
static void
|
|
|
|
xfs_ifree_mark_inode_stale(
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_perag *pag,
|
2020-03-25 11:10:30 +08:00
|
|
|
struct xfs_inode *free_ip,
|
2020-04-02 23:18:57 +08:00
|
|
|
xfs_ino_t inum)
|
2020-03-25 11:10:30 +08:00
|
|
|
{
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_mount *mp = pag->pag_mount;
|
2020-06-30 05:49:18 +08:00
|
|
|
struct xfs_inode_log_item *iip;
|
2020-03-25 11:10:30 +08:00
|
|
|
struct xfs_inode *ip;
|
|
|
|
|
|
|
|
retry:
|
|
|
|
rcu_read_lock();
|
|
|
|
ip = radix_tree_lookup(&pag->pag_ici_root, XFS_INO_TO_AGINO(mp, inum));
|
|
|
|
|
|
|
|
/* Inode not in memory, nothing to do */
|
2020-06-30 05:49:18 +08:00
|
|
|
if (!ip) {
|
|
|
|
rcu_read_unlock();
|
|
|
|
return;
|
|
|
|
}
|
2020-03-25 11:10:30 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* because this is an RCU protected lookup, we could find a recently
|
|
|
|
* freed or even reallocated inode during the lookup. We need to check
|
|
|
|
* under the i_flags_lock for a valid inode here. Skip it if it is not
|
|
|
|
* valid, the wrong inode or stale.
|
|
|
|
*/
|
|
|
|
spin_lock(&ip->i_flags_lock);
|
2020-08-18 07:41:01 +08:00
|
|
|
if (ip->i_ino != inum || __xfs_iflags_test(ip, XFS_ISTALE))
|
|
|
|
goto out_iflags_unlock;
|
2020-03-25 11:10:30 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Don't try to lock/unlock the current inode, but we _cannot_ skip the
|
|
|
|
* other inodes that we did not find in the list attached to the buffer
|
|
|
|
* and are not already marked stale. If we can't lock it, back off and
|
|
|
|
* retry.
|
|
|
|
*/
|
|
|
|
if (ip != free_ip) {
|
|
|
|
if (!xfs_ilock_nowait(ip, XFS_ILOCK_EXCL)) {
|
2020-06-30 05:49:18 +08:00
|
|
|
spin_unlock(&ip->i_flags_lock);
|
2020-03-25 11:10:30 +08:00
|
|
|
rcu_read_unlock();
|
|
|
|
delay(1);
|
|
|
|
goto retry;
|
|
|
|
}
|
|
|
|
}
|
2020-06-30 05:49:18 +08:00
|
|
|
ip->i_flags |= XFS_ISTALE;
|
2020-03-25 11:10:30 +08:00
|
|
|
|
2020-06-30 05:49:18 +08:00
|
|
|
/*
|
2020-08-18 07:41:01 +08:00
|
|
|
* If the inode is flushing, it is already attached to the buffer. All
|
2020-06-30 05:49:18 +08:00
|
|
|
* we needed to do here is mark the inode stale so buffer IO completion
|
|
|
|
* will remove it from the AIL.
|
|
|
|
*/
|
|
|
|
iip = ip->i_itemp;
|
2020-08-18 07:41:01 +08:00
|
|
|
if (__xfs_iflags_test(ip, XFS_IFLUSHING)) {
|
2020-06-30 05:49:18 +08:00
|
|
|
ASSERT(!list_empty(&iip->ili_item.li_bio_list));
|
|
|
|
ASSERT(iip->ili_last_fields);
|
|
|
|
goto out_iunlock;
|
|
|
|
}
|
2020-03-25 11:10:30 +08:00
|
|
|
|
|
|
|
/*
|
2020-06-30 05:49:18 +08:00
|
|
|
* Inodes not attached to the buffer can be released immediately.
|
|
|
|
* Everything else has to go through xfs_iflush_abort() on journal
|
|
|
|
* commit as the flock synchronises removal of the inode from the
|
|
|
|
* cluster buffer against inode reclaim.
|
2020-03-25 11:10:30 +08:00
|
|
|
*/
|
2020-08-18 07:41:01 +08:00
|
|
|
if (!iip || list_empty(&iip->ili_item.li_bio_list))
|
2020-06-30 05:49:18 +08:00
|
|
|
goto out_iunlock;
|
2020-08-18 07:41:01 +08:00
|
|
|
|
|
|
|
__xfs_iflags_set(ip, XFS_IFLUSHING);
|
|
|
|
spin_unlock(&ip->i_flags_lock);
|
|
|
|
rcu_read_unlock();
|
2020-03-25 11:10:30 +08:00
|
|
|
|
2020-06-30 05:49:18 +08:00
|
|
|
/* we have a dirty inode in memory that has not yet been flushed. */
|
|
|
|
spin_lock(&iip->ili_lock);
|
|
|
|
iip->ili_last_fields = iip->ili_fields;
|
|
|
|
iip->ili_fields = 0;
|
|
|
|
iip->ili_fsync_fields = 0;
|
|
|
|
spin_unlock(&iip->ili_lock);
|
|
|
|
ASSERT(iip->ili_last_fields);
|
|
|
|
|
2020-08-18 07:41:01 +08:00
|
|
|
if (ip != free_ip)
|
|
|
|
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
|
|
|
return;
|
|
|
|
|
2020-06-30 05:49:18 +08:00
|
|
|
out_iunlock:
|
|
|
|
if (ip != free_ip)
|
|
|
|
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
2020-08-18 07:41:01 +08:00
|
|
|
out_iflags_unlock:
|
|
|
|
spin_unlock(&ip->i_flags_lock);
|
|
|
|
rcu_read_unlock();
|
2020-03-25 11:10:30 +08:00
|
|
|
}
|
|
|
|
|
2010-08-24 09:42:41 +08:00
|
|
|
/*
|
2013-08-12 11:14:59 +08:00
|
|
|
* A big issue when freeing the inode cluster is that we _cannot_ skip any
|
2010-08-24 09:42:41 +08:00
|
|
|
* inodes that are in memory - they all must be marked stale and attached to
|
|
|
|
* the cluster buffer.
|
|
|
|
*/
|
2021-06-02 08:48:51 +08:00
|
|
|
static int
|
2005-04-17 06:20:36 +08:00
|
|
|
xfs_ifree_cluster(
|
2020-06-30 05:49:18 +08:00
|
|
|
struct xfs_trans *tp,
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_perag *pag,
|
|
|
|
struct xfs_inode *free_ip,
|
2015-05-29 07:26:03 +08:00
|
|
|
struct xfs_icluster *xic)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2020-06-30 05:49:18 +08:00
|
|
|
struct xfs_mount *mp = free_ip->i_mount;
|
|
|
|
struct xfs_ino_geometry *igeo = M_IGEO(mp);
|
|
|
|
struct xfs_buf *bp;
|
|
|
|
xfs_daddr_t blkno;
|
|
|
|
xfs_ino_t inum = xic->first_ino;
|
2005-04-17 06:20:36 +08:00
|
|
|
int nbufs;
|
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 14:22:29 +08:00
|
|
|
int i, j;
|
2015-06-04 11:03:34 +08:00
|
|
|
int ioffset;
|
2020-01-24 09:01:18 +08:00
|
|
|
int error;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2019-06-06 02:19:34 +08:00
|
|
|
nbufs = igeo->ialloc_blks / igeo->blocks_per_cluster;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2019-06-06 02:19:34 +08:00
|
|
|
for (j = 0; j < nbufs; j++, inum += igeo->inodes_per_cluster) {
|
2015-05-29 07:26:03 +08:00
|
|
|
/*
|
|
|
|
* The allocation bitmap tells us which inodes of the chunk were
|
|
|
|
* physically allocated. Skip the cluster if an inode falls into
|
|
|
|
* a sparse region.
|
|
|
|
*/
|
2015-06-04 11:03:34 +08:00
|
|
|
ioffset = inum - xic->first_ino;
|
|
|
|
if ((xic->alloc & XFS_INOBT_MASK(ioffset)) == 0) {
|
2019-06-06 02:19:34 +08:00
|
|
|
ASSERT(ioffset % igeo->inodes_per_cluster == 0);
|
2015-05-29 07:26:03 +08:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
blkno = XFS_AGB_TO_DADDR(mp, XFS_INO_TO_AGNO(mp, inum),
|
|
|
|
XFS_INO_TO_AGBNO(mp, inum));
|
|
|
|
|
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 14:22:29 +08:00
|
|
|
/*
|
|
|
|
* We obtain and lock the backing buffer first in the process
|
2020-08-18 07:41:01 +08:00
|
|
|
* here to ensure dirty inodes attached to the buffer remain in
|
|
|
|
* the flushing state while we mark them stale.
|
|
|
|
*
|
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 14:22:29 +08:00
|
|
|
* If we scan the in-memory inodes first, then buffer IO can
|
|
|
|
* complete before we get a lock on it, and hence we may fail
|
|
|
|
* to mark all the active inodes on the buffer stale.
|
|
|
|
*/
|
2020-01-24 09:01:18 +08:00
|
|
|
error = xfs_trans_get_buf(tp, mp->m_ddev_targp, blkno,
|
|
|
|
mp->m_bsize * igeo->blocks_per_cluster,
|
|
|
|
XBF_UNMAPPED, &bp);
|
2020-06-30 05:49:18 +08:00
|
|
|
if (error)
|
2020-01-24 09:01:18 +08:00
|
|
|
return error;
|
2012-11-14 14:53:49 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* This buffer may not have been correctly initialised as we
|
|
|
|
* didn't read it from disk. That's not important because we are
|
|
|
|
* only using to mark the buffer as stale in the log, and to
|
|
|
|
* attach stale cached inodes on it. That means it will never be
|
|
|
|
* dispatched for IO. If it is, we want to know about it, and we
|
|
|
|
* want it to fail. We can acheive this by adding a write
|
|
|
|
* verifier to the buffer.
|
|
|
|
*/
|
2018-12-13 00:46:20 +08:00
|
|
|
bp->b_ops = &xfs_inode_buf_ops;
|
2012-11-14 14:53:49 +08:00
|
|
|
|
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 14:22:29 +08:00
|
|
|
/*
|
2020-06-30 05:49:18 +08:00
|
|
|
* Now we need to set all the cached clean inodes as XFS_ISTALE,
|
|
|
|
* too. This requires lookups, and will skip inodes that we've
|
|
|
|
* already marked XFS_ISTALE.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2020-06-30 05:49:18 +08:00
|
|
|
for (i = 0; i < igeo->inodes_per_cluster; i++)
|
2021-06-02 08:48:51 +08:00
|
|
|
xfs_ifree_mark_inode_stale(pag, free_ip, inum + i);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-08-24 09:42:41 +08:00
|
|
|
xfs_trans_stale_inode_buf(tp, bp);
|
2005-04-17 06:20:36 +08:00
|
|
|
xfs_trans_binval(tp, bp);
|
|
|
|
}
|
2011-09-20 21:56:55 +08:00
|
|
|
return 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2022-04-21 06:45:16 +08:00
|
|
|
* This is called to return an inode to the inode free list. The inode should
|
|
|
|
* already be truncated to 0 length and have no pages associated with it. This
|
|
|
|
* routine also assumes that the inode is already a part of the transaction.
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
2022-04-21 06:45:16 +08:00
|
|
|
* The on-disk copy of the inode will have been added to the list of unlinked
|
|
|
|
* inodes in the AGI. We need to remove the inode from that list atomically with
|
|
|
|
* respect to freeing it here.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_ifree(
|
2018-07-12 13:26:07 +08:00
|
|
|
struct xfs_trans *tp,
|
|
|
|
struct xfs_inode *ip)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_mount *mp = ip->i_mount;
|
|
|
|
struct xfs_perag *pag;
|
2015-05-29 07:26:03 +08:00
|
|
|
struct xfs_icluster xic = { 0 };
|
2020-06-30 05:48:46 +08:00
|
|
|
struct xfs_inode_log_item *iip = ip->i_itemp;
|
2021-06-02 08:48:51 +08:00
|
|
|
int error;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-04-22 15:34:00 +08:00
|
|
|
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
|
2016-02-09 13:54:58 +08:00
|
|
|
ASSERT(VFS_I(ip)->i_nlink == 0);
|
2020-05-19 01:27:22 +08:00
|
|
|
ASSERT(ip->i_df.if_nextents == 0);
|
2021-03-30 02:11:40 +08:00
|
|
|
ASSERT(ip->i_disk_size == 0 || !S_ISREG(VFS_I(ip)->i_mode));
|
2021-03-30 02:11:40 +08:00
|
|
|
ASSERT(ip->i_nblocks == 0);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2021-06-02 08:48:51 +08:00
|
|
|
pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ip->i_ino));
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2022-04-21 06:45:16 +08:00
|
|
|
* Free the inode first so that we guarantee that the AGI lock is going
|
|
|
|
* to be taken before we remove the inode from the unlinked list. This
|
|
|
|
* makes the AGI lock -> unlinked list modification order the same as
|
|
|
|
* used in O_TMPFILE creation.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2022-04-21 06:45:16 +08:00
|
|
|
error = xfs_difree(tp, pag, ip->i_ino, &xic);
|
2013-06-27 14:04:50 +08:00
|
|
|
if (error)
|
2022-05-30 08:56:33 +08:00
|
|
|
goto out;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2022-04-21 06:45:16 +08:00
|
|
|
error = xfs_iunlink_remove(tp, pag, ip);
|
2013-06-27 14:04:50 +08:00
|
|
|
if (error)
|
2021-06-02 08:48:51 +08:00
|
|
|
goto out;
|
2013-06-27 14:04:50 +08:00
|
|
|
|
2020-05-19 01:27:21 +08:00
|
|
|
/*
|
|
|
|
* Free any local-format data sitting around before we reset the
|
|
|
|
* data fork to extents format. Note that the attr fork data has
|
|
|
|
* already been freed by xfs_attr_inactive.
|
|
|
|
*/
|
2020-05-19 01:28:05 +08:00
|
|
|
if (ip->i_df.if_format == XFS_DINODE_FMT_LOCAL) {
|
2023-12-20 14:34:55 +08:00
|
|
|
kmem_free(ip->i_df.if_data);
|
|
|
|
ip->i_df.if_data = NULL;
|
2020-05-19 01:27:21 +08:00
|
|
|
ip->i_df.if_bytes = 0;
|
|
|
|
}
|
2017-11-23 04:21:07 +08:00
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
VFS_I(ip)->i_mode = 0; /* mark incore inode as free */
|
2021-03-30 02:11:44 +08:00
|
|
|
ip->i_diflags = 0;
|
2021-06-02 08:48:51 +08:00
|
|
|
ip->i_diflags2 = mp->m_ino_geo.new_diflags2;
|
2021-03-30 02:11:44 +08:00
|
|
|
ip->i_forkoff = 0; /* mark the attr fork not in use */
|
2020-05-19 01:28:05 +08:00
|
|
|
ip->i_df.if_format = XFS_DINODE_FMT_EXTENTS;
|
2021-03-30 02:11:38 +08:00
|
|
|
if (xfs_iflags_test(ip, XFS_IPRESERVE_DM_FIELDS))
|
|
|
|
xfs_iflags_clear(ip, XFS_IPRESERVE_DM_FIELDS);
|
2018-03-29 08:48:08 +08:00
|
|
|
|
|
|
|
/* Don't attempt to replay owner changes for a deleted inode */
|
2020-06-30 05:48:46 +08:00
|
|
|
spin_lock(&iip->ili_lock);
|
|
|
|
iip->ili_fields &= ~(XFS_ILOG_AOWNER | XFS_ILOG_DOWNER);
|
|
|
|
spin_unlock(&iip->ili_lock);
|
2018-03-29 08:48:08 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* Bump the generation count so no one will be confused
|
|
|
|
* by reincarnations of this inode.
|
|
|
|
*/
|
2016-02-09 13:54:58 +08:00
|
|
|
VFS_I(ip)->i_generation++;
|
2005-04-17 06:20:36 +08:00
|
|
|
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
|
|
|
|
|
2015-05-29 07:26:03 +08:00
|
|
|
if (xic.deleted)
|
2021-06-02 08:48:51 +08:00
|
|
|
error = xfs_ifree_cluster(tp, pag, ip, &xic);
|
|
|
|
out:
|
|
|
|
xfs_perag_put(pag);
|
2011-09-20 21:56:55 +08:00
|
|
|
return error;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2010-02-18 03:43:56 +08:00
|
|
|
* This is called to unpin an inode. The caller must have the inode locked
|
|
|
|
* in at least shared mode so that the buffer cannot be subsequently pinned
|
|
|
|
* once someone is waiting for it to be unpinned.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2010-02-18 03:43:56 +08:00
|
|
|
static void
|
2011-12-19 04:00:10 +08:00
|
|
|
xfs_iunpin(
|
2010-02-18 03:43:56 +08:00
|
|
|
struct xfs_inode *ip)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2008-04-22 15:34:00 +08:00
|
|
|
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_ILOCK_SHARED));
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-03-08 08:24:07 +08:00
|
|
|
trace_xfs_inode_unpin_nowait(ip, _RET_IP_);
|
|
|
|
|
2008-03-06 10:43:42 +08:00
|
|
|
/* Give the log a push to start the unpinning I/O */
|
2021-06-18 23:21:52 +08:00
|
|
|
xfs_log_force_seq(ip->i_mount, ip->i_itemp->ili_commit_seq, 0, NULL);
|
2010-01-19 17:56:46 +08:00
|
|
|
|
2008-03-06 10:43:42 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2011-12-19 04:00:10 +08:00
|
|
|
static void
|
|
|
|
__xfs_iunpin_wait(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
wait_queue_head_t *wq = bit_waitqueue(&ip->i_flags, __XFS_IPINNED_BIT);
|
|
|
|
DEFINE_WAIT_BIT(wait, &ip->i_flags, __XFS_IPINNED_BIT);
|
|
|
|
|
|
|
|
xfs_iunpin(ip);
|
|
|
|
|
|
|
|
do {
|
2017-03-05 18:25:39 +08:00
|
|
|
prepare_to_wait(wq, &wait.wq_entry, TASK_UNINTERRUPTIBLE);
|
2011-12-19 04:00:10 +08:00
|
|
|
if (xfs_ipincount(ip))
|
|
|
|
io_schedule();
|
|
|
|
} while (xfs_ipincount(ip));
|
2017-03-05 18:25:39 +08:00
|
|
|
finish_wait(wq, &wait.wq_entry);
|
2011-12-19 04:00:10 +08:00
|
|
|
}
|
|
|
|
|
2010-02-06 09:37:26 +08:00
|
|
|
void
|
2008-03-06 10:43:42 +08:00
|
|
|
xfs_iunpin_wait(
|
2010-02-18 03:43:56 +08:00
|
|
|
struct xfs_inode *ip)
|
2008-03-06 10:43:42 +08:00
|
|
|
{
|
2011-12-19 04:00:10 +08:00
|
|
|
if (xfs_ipincount(ip))
|
|
|
|
__xfs_iunpin_wait(ip);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2013-10-29 19:11:44 +08:00
|
|
|
/*
|
|
|
|
* Removing an inode from the namespace involves removing the directory entry
|
|
|
|
* and dropping the link count on the inode. Removing the directory entry can
|
|
|
|
* result in locking an AGF (directory blocks were freed) and removing a link
|
|
|
|
* count can result in placing the inode on an unlinked list which results in
|
|
|
|
* locking an AGI.
|
|
|
|
*
|
|
|
|
* The big problem here is that we have an ordering constraint on AGF and AGI
|
|
|
|
* locking - inode allocation locks the AGI, then can allocate a new extent for
|
|
|
|
* new inodes, locking the AGF after the AGI. Similarly, freeing the inode
|
|
|
|
* removes the inode from the unlinked list, requiring that we lock the AGI
|
|
|
|
* first, and then freeing the inode can result in an inode chunk being freed
|
|
|
|
* and hence freeing disk space requiring that we lock an AGF.
|
|
|
|
*
|
|
|
|
* Hence the ordering that is imposed by other parts of the code is AGI before
|
|
|
|
* AGF. This means we cannot remove the directory entry before we drop the inode
|
|
|
|
* reference count and put it on the unlinked list as this results in a lock
|
|
|
|
* order of AGF then AGI, and this can deadlock against inode allocation and
|
|
|
|
* freeing. Therefore we must drop the link counts before we remove the
|
|
|
|
* directory entry.
|
|
|
|
*
|
|
|
|
* This is still safe from a transactional point of view - it is not until we
|
2016-08-03 09:18:10 +08:00
|
|
|
* get to xfs_defer_finish() that we have the possibility of multiple
|
2013-10-29 19:11:44 +08:00
|
|
|
* transactions in this operation. Hence as long as we remove the directory
|
|
|
|
* entry and drop the link count in the first transaction of the remove
|
|
|
|
* operation, there are no transactional constraints on the ordering here.
|
|
|
|
*/
|
2013-08-12 18:49:45 +08:00
|
|
|
int
|
|
|
|
xfs_remove(
|
|
|
|
xfs_inode_t *dp,
|
|
|
|
struct xfs_name *name,
|
|
|
|
xfs_inode_t *ip)
|
|
|
|
{
|
|
|
|
xfs_mount_t *mp = dp->i_mount;
|
|
|
|
xfs_trans_t *tp = NULL;
|
2016-02-09 13:54:58 +08:00
|
|
|
int is_dir = S_ISDIR(VFS_I(ip)->i_mode);
|
2022-02-26 08:18:41 +08:00
|
|
|
int dontcare;
|
2013-08-12 18:49:45 +08:00
|
|
|
int error = 0;
|
|
|
|
uint resblks;
|
|
|
|
|
|
|
|
trace_xfs_remove(dp, name);
|
|
|
|
|
2021-08-19 09:46:53 +08:00
|
|
|
if (xfs_is_shutdown(mp))
|
2014-06-25 12:58:08 +08:00
|
|
|
return -EIO;
|
2023-12-16 02:03:35 +08:00
|
|
|
if (xfs_ifork_zapped(dp, XFS_DATA_FORK))
|
|
|
|
return -EIO;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2018-05-05 06:30:21 +08:00
|
|
|
error = xfs_qm_dqattach(dp);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error)
|
|
|
|
goto std_return;
|
|
|
|
|
2018-05-05 06:30:21 +08:00
|
|
|
error = xfs_qm_dqattach(ip);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error)
|
|
|
|
goto std_return;
|
|
|
|
|
|
|
|
/*
|
2022-02-26 08:18:41 +08:00
|
|
|
* We try to get the real space reservation first, allowing for
|
|
|
|
* directory btree deletion(s) implying possible bmap insert(s). If we
|
|
|
|
* can't get the space reservation then we use 0 instead, and avoid the
|
|
|
|
* bmap btree insert(s) in the directory code by, if the bmap insert
|
|
|
|
* tries to happen, instead trimming the LAST block from the directory.
|
|
|
|
*
|
|
|
|
* Ignore EDQUOT and ENOSPC being returned via nospace_error because
|
|
|
|
* the directory code can handle a reservationless update and we don't
|
|
|
|
* want to prevent a user from trying to free space by deleting things.
|
2013-08-12 18:49:45 +08:00
|
|
|
*/
|
|
|
|
resblks = XFS_REMOVE_SPACE_RES(mp);
|
2022-02-26 08:18:41 +08:00
|
|
|
error = xfs_trans_alloc_dir(dp, &M_RES(mp)->tr_remove, ip, &resblks,
|
|
|
|
&tp, &dontcare);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error) {
|
2014-06-25 12:58:08 +08:00
|
|
|
ASSERT(error != -ENOSPC);
|
2016-04-06 07:19:55 +08:00
|
|
|
goto std_return;
|
2013-08-12 18:49:45 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we're removing a directory perform some additional validation.
|
|
|
|
*/
|
|
|
|
if (is_dir) {
|
2016-02-09 13:54:58 +08:00
|
|
|
ASSERT(VFS_I(ip)->i_nlink >= 2);
|
|
|
|
if (VFS_I(ip)->i_nlink != 2) {
|
2014-06-25 12:58:08 +08:00
|
|
|
error = -ENOTEMPTY;
|
2013-08-12 18:49:45 +08:00
|
|
|
goto out_trans_cancel;
|
|
|
|
}
|
|
|
|
if (!xfs_dir_isempty(ip)) {
|
2014-06-25 12:58:08 +08:00
|
|
|
error = -ENOTEMPTY;
|
2013-08-12 18:49:45 +08:00
|
|
|
goto out_trans_cancel;
|
|
|
|
}
|
|
|
|
|
2013-10-29 19:11:44 +08:00
|
|
|
/* Drop the link from ip's "..". */
|
2013-08-12 18:49:45 +08:00
|
|
|
error = xfs_droplink(tp, dp);
|
|
|
|
if (error)
|
2013-10-29 19:11:44 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2013-10-29 19:11:44 +08:00
|
|
|
/* Drop the "." link from ip to self. */
|
2013-08-12 18:49:45 +08:00
|
|
|
error = xfs_droplink(tp, ip);
|
|
|
|
if (error)
|
2013-10-29 19:11:44 +08:00
|
|
|
goto out_trans_cancel;
|
2021-07-13 03:58:48 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Point the unlinked child directory's ".." entry to the root
|
|
|
|
* directory to eliminate back-references to inodes that may
|
|
|
|
* get freed before the child directory is closed. If the fs
|
|
|
|
* gets shrunk, this can lead to dirent inode validation errors.
|
|
|
|
*/
|
|
|
|
if (dp->i_ino != tp->t_mountp->m_sb.sb_rootino) {
|
|
|
|
error = xfs_dir_replace(tp, ip, &xfs_name_dotdot,
|
|
|
|
tp->t_mountp->m_sb.sb_rootino, 0);
|
|
|
|
if (error)
|
2022-11-17 11:20:20 +08:00
|
|
|
goto out_trans_cancel;
|
2021-07-13 03:58:48 +08:00
|
|
|
}
|
2013-08-12 18:49:45 +08:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* When removing a non-directory we need to log the parent
|
|
|
|
* inode here. For a directory this is done implicitly
|
|
|
|
* by the xfs_droplink call for the ".." entry.
|
|
|
|
*/
|
|
|
|
xfs_trans_log_inode(tp, dp, XFS_ILOG_CORE);
|
|
|
|
}
|
2013-10-29 19:11:44 +08:00
|
|
|
xfs_trans_ichgtime(tp, dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2013-10-29 19:11:44 +08:00
|
|
|
/* Drop the link from dp to ip. */
|
2013-08-12 18:49:45 +08:00
|
|
|
error = xfs_droplink(tp, ip);
|
|
|
|
if (error)
|
2013-10-29 19:11:44 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:45 +08:00
|
|
|
|
2018-07-12 13:26:21 +08:00
|
|
|
error = xfs_dir_removename(tp, dp, name, ip->i_ino, resblks);
|
2013-10-29 19:11:44 +08:00
|
|
|
if (error) {
|
2014-06-25 12:58:08 +08:00
|
|
|
ASSERT(error != -ENOENT);
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-10-29 19:11:44 +08:00
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:45 +08:00
|
|
|
/*
|
|
|
|
* If this is a synchronous mount, make sure that the
|
|
|
|
* remove transaction goes to disk before returning to
|
|
|
|
* the user.
|
|
|
|
*/
|
2021-08-19 09:46:52 +08:00
|
|
|
if (xfs_has_wsync(mp) || xfs_has_dirsync(mp))
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_trans_set_sync(tp);
|
|
|
|
|
2015-06-04 11:48:08 +08:00
|
|
|
error = xfs_trans_commit(tp);
|
2013-08-12 18:49:45 +08:00
|
|
|
if (error)
|
|
|
|
goto std_return;
|
|
|
|
|
2014-04-23 05:11:51 +08:00
|
|
|
if (is_dir && xfs_inode_is_filestream(ip))
|
2013-08-12 18:49:45 +08:00
|
|
|
xfs_filestream_deassociate(ip);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_trans_cancel:
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2013-08-12 18:49:45 +08:00
|
|
|
std_return:
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:46 +08:00
|
|
|
/*
|
|
|
|
* Enter all inodes for a rename transaction into a sorted array.
|
|
|
|
*/
|
2015-03-25 11:03:32 +08:00
|
|
|
#define __XFS_SORT_INODES 5
|
2013-08-12 18:49:46 +08:00
|
|
|
STATIC void
|
|
|
|
xfs_sort_for_rename(
|
2015-03-25 11:03:32 +08:00
|
|
|
struct xfs_inode *dp1, /* in: old (source) directory inode */
|
|
|
|
struct xfs_inode *dp2, /* in: new (target) directory inode */
|
|
|
|
struct xfs_inode *ip1, /* in: inode of old entry */
|
|
|
|
struct xfs_inode *ip2, /* in: inode of new entry */
|
|
|
|
struct xfs_inode *wip, /* in: whiteout inode */
|
|
|
|
struct xfs_inode **i_tab,/* out: sorted array of inodes */
|
|
|
|
int *num_inodes) /* in/out: inodes in array */
|
2013-08-12 18:49:46 +08:00
|
|
|
{
|
|
|
|
int i, j;
|
|
|
|
|
2015-03-25 11:03:32 +08:00
|
|
|
ASSERT(*num_inodes == __XFS_SORT_INODES);
|
|
|
|
memset(i_tab, 0, *num_inodes * sizeof(struct xfs_inode *));
|
|
|
|
|
2013-08-12 18:49:46 +08:00
|
|
|
/*
|
|
|
|
* i_tab contains a list of pointers to inodes. We initialize
|
|
|
|
* the table here & we'll sort it. We will then use it to
|
|
|
|
* order the acquisition of the inode locks.
|
|
|
|
*
|
|
|
|
* Note that the table may contain duplicates. e.g., dp1 == dp2.
|
|
|
|
*/
|
2015-03-25 11:03:32 +08:00
|
|
|
i = 0;
|
|
|
|
i_tab[i++] = dp1;
|
|
|
|
i_tab[i++] = dp2;
|
|
|
|
i_tab[i++] = ip1;
|
|
|
|
if (ip2)
|
|
|
|
i_tab[i++] = ip2;
|
|
|
|
if (wip)
|
|
|
|
i_tab[i++] = wip;
|
|
|
|
*num_inodes = i;
|
2013-08-12 18:49:46 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Sort the elements via bubble sort. (Remember, there are at
|
2015-03-25 11:03:32 +08:00
|
|
|
* most 5 elements to sort, so this is adequate.)
|
2013-08-12 18:49:46 +08:00
|
|
|
*/
|
|
|
|
for (i = 0; i < *num_inodes; i++) {
|
|
|
|
for (j = 1; j < *num_inodes; j++) {
|
|
|
|
if (i_tab[j]->i_ino < i_tab[j-1]->i_ino) {
|
2015-03-25 11:03:32 +08:00
|
|
|
struct xfs_inode *temp = i_tab[j];
|
2013-08-12 18:49:46 +08:00
|
|
|
i_tab[j] = i_tab[j-1];
|
|
|
|
i_tab[j-1] = temp;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-25 11:06:07 +08:00
|
|
|
static int
|
|
|
|
xfs_finish_rename(
|
2018-07-12 13:26:08 +08:00
|
|
|
struct xfs_trans *tp)
|
2015-03-25 11:06:07 +08:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
* If this is a synchronous mount, make sure that the rename transaction
|
|
|
|
* goes to disk before returning to the user.
|
|
|
|
*/
|
2021-08-19 09:46:52 +08:00
|
|
|
if (xfs_has_wsync(tp->t_mountp) || xfs_has_dirsync(tp->t_mountp))
|
2015-03-25 11:06:07 +08:00
|
|
|
xfs_trans_set_sync(tp);
|
|
|
|
|
2015-06-04 11:48:08 +08:00
|
|
|
return xfs_trans_commit(tp);
|
2015-03-25 11:06:07 +08:00
|
|
|
}
|
|
|
|
|
2014-12-24 05:51:42 +08:00
|
|
|
/*
|
|
|
|
* xfs_cross_rename()
|
|
|
|
*
|
2021-03-24 07:59:30 +08:00
|
|
|
* responsible for handling RENAME_EXCHANGE flag in renameat2() syscall
|
2014-12-24 05:51:42 +08:00
|
|
|
*/
|
|
|
|
STATIC int
|
|
|
|
xfs_cross_rename(
|
|
|
|
struct xfs_trans *tp,
|
|
|
|
struct xfs_inode *dp1,
|
|
|
|
struct xfs_name *name1,
|
|
|
|
struct xfs_inode *ip1,
|
|
|
|
struct xfs_inode *dp2,
|
|
|
|
struct xfs_name *name2,
|
|
|
|
struct xfs_inode *ip2,
|
|
|
|
int spaceres)
|
|
|
|
{
|
|
|
|
int error = 0;
|
|
|
|
int ip1_flags = 0;
|
|
|
|
int ip2_flags = 0;
|
|
|
|
int dp2_flags = 0;
|
|
|
|
|
|
|
|
/* Swap inode number for dirent in first parent */
|
2018-07-12 13:26:21 +08:00
|
|
|
error = xfs_dir_replace(tp, dp1, name1, ip2->i_ino, spaceres);
|
2014-12-24 05:51:42 +08:00
|
|
|
if (error)
|
2015-03-25 11:08:07 +08:00
|
|
|
goto out_trans_abort;
|
2014-12-24 05:51:42 +08:00
|
|
|
|
|
|
|
/* Swap inode number for dirent in second parent */
|
2018-07-12 13:26:21 +08:00
|
|
|
error = xfs_dir_replace(tp, dp2, name2, ip1->i_ino, spaceres);
|
2014-12-24 05:51:42 +08:00
|
|
|
if (error)
|
2015-03-25 11:08:07 +08:00
|
|
|
goto out_trans_abort;
|
2014-12-24 05:51:42 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we're renaming one or more directories across different parents,
|
|
|
|
* update the respective ".." entries (and link counts) to match the new
|
|
|
|
* parents.
|
|
|
|
*/
|
|
|
|
if (dp1 != dp2) {
|
|
|
|
dp2_flags = XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG;
|
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
if (S_ISDIR(VFS_I(ip2)->i_mode)) {
|
2014-12-24 05:51:42 +08:00
|
|
|
error = xfs_dir_replace(tp, ip2, &xfs_name_dotdot,
|
2018-07-12 13:26:21 +08:00
|
|
|
dp1->i_ino, spaceres);
|
2014-12-24 05:51:42 +08:00
|
|
|
if (error)
|
2015-03-25 11:08:07 +08:00
|
|
|
goto out_trans_abort;
|
2014-12-24 05:51:42 +08:00
|
|
|
|
|
|
|
/* transfer ip2 ".." reference to dp1 */
|
2016-02-09 13:54:58 +08:00
|
|
|
if (!S_ISDIR(VFS_I(ip1)->i_mode)) {
|
2014-12-24 05:51:42 +08:00
|
|
|
error = xfs_droplink(tp, dp2);
|
|
|
|
if (error)
|
2015-03-25 11:08:07 +08:00
|
|
|
goto out_trans_abort;
|
2019-05-02 11:26:30 +08:00
|
|
|
xfs_bumplink(tp, dp1);
|
2014-12-24 05:51:42 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Although ip1 isn't changed here, userspace needs
|
|
|
|
* to be warned about the change, so that applications
|
|
|
|
* relying on it (like backup ones), will properly
|
|
|
|
* notify the change
|
|
|
|
*/
|
|
|
|
ip1_flags |= XFS_ICHGTIME_CHG;
|
|
|
|
ip2_flags |= XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG;
|
|
|
|
}
|
|
|
|
|
2016-02-09 13:54:58 +08:00
|
|
|
if (S_ISDIR(VFS_I(ip1)->i_mode)) {
|
2014-12-24 05:51:42 +08:00
|
|
|
error = xfs_dir_replace(tp, ip1, &xfs_name_dotdot,
|
2018-07-12 13:26:21 +08:00
|
|
|
dp2->i_ino, spaceres);
|
2014-12-24 05:51:42 +08:00
|
|
|
if (error)
|
2015-03-25 11:08:07 +08:00
|
|
|
goto out_trans_abort;
|
2014-12-24 05:51:42 +08:00
|
|
|
|
|
|
|
/* transfer ip1 ".." reference to dp2 */
|
2016-02-09 13:54:58 +08:00
|
|
|
if (!S_ISDIR(VFS_I(ip2)->i_mode)) {
|
2014-12-24 05:51:42 +08:00
|
|
|
error = xfs_droplink(tp, dp1);
|
|
|
|
if (error)
|
2015-03-25 11:08:07 +08:00
|
|
|
goto out_trans_abort;
|
2019-05-02 11:26:30 +08:00
|
|
|
xfs_bumplink(tp, dp2);
|
2014-12-24 05:51:42 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Although ip2 isn't changed here, userspace needs
|
|
|
|
* to be warned about the change, so that applications
|
|
|
|
* relying on it (like backup ones), will properly
|
|
|
|
* notify the change
|
|
|
|
*/
|
|
|
|
ip1_flags |= XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG;
|
|
|
|
ip2_flags |= XFS_ICHGTIME_CHG;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ip1_flags) {
|
|
|
|
xfs_trans_ichgtime(tp, ip1, ip1_flags);
|
|
|
|
xfs_trans_log_inode(tp, ip1, XFS_ILOG_CORE);
|
|
|
|
}
|
|
|
|
if (ip2_flags) {
|
|
|
|
xfs_trans_ichgtime(tp, ip2, ip2_flags);
|
|
|
|
xfs_trans_log_inode(tp, ip2, XFS_ILOG_CORE);
|
|
|
|
}
|
|
|
|
if (dp2_flags) {
|
|
|
|
xfs_trans_ichgtime(tp, dp2, dp2_flags);
|
|
|
|
xfs_trans_log_inode(tp, dp2, XFS_ILOG_CORE);
|
|
|
|
}
|
|
|
|
xfs_trans_ichgtime(tp, dp1, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
|
|
|
|
xfs_trans_log_inode(tp, dp1, XFS_ILOG_CORE);
|
2018-07-12 13:26:08 +08:00
|
|
|
return xfs_finish_rename(tp);
|
2015-03-25 11:08:07 +08:00
|
|
|
|
|
|
|
out_trans_abort:
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2014-12-24 05:51:42 +08:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
/*
|
|
|
|
* xfs_rename_alloc_whiteout()
|
|
|
|
*
|
2020-08-05 23:49:58 +08:00
|
|
|
* Return a referenced, unlinked, unlocked inode that can be used as a
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
* whiteout in a rename transaction. We use a tmpfile inode here so that if we
|
|
|
|
* crash between allocating the inode and linking it into the rename transaction
|
|
|
|
* recovery will free the inode and we won't leak it.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
xfs_rename_alloc_whiteout(
|
2023-01-13 19:49:25 +08:00
|
|
|
struct mnt_idmap *idmap,
|
2022-07-10 01:56:02 +08:00
|
|
|
struct xfs_name *src_name,
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
struct xfs_inode *dp,
|
|
|
|
struct xfs_inode **wip)
|
|
|
|
{
|
|
|
|
struct xfs_inode *tmpfile;
|
2022-07-10 01:56:02 +08:00
|
|
|
struct qstr name;
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
int error;
|
|
|
|
|
2023-01-13 19:49:25 +08:00
|
|
|
error = xfs_create_tmpfile(idmap, dp, S_IFCHR | WHITEOUT_MODE,
|
2021-01-21 21:19:58 +08:00
|
|
|
&tmpfile);
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2022-07-10 01:56:02 +08:00
|
|
|
name.name = src_name->name;
|
|
|
|
name.len = src_name->len;
|
|
|
|
error = xfs_inode_init_security(VFS_I(tmpfile), VFS_I(dp), &name);
|
|
|
|
if (error) {
|
|
|
|
xfs_finish_inode_setup(tmpfile);
|
|
|
|
xfs_irele(tmpfile);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2015-05-29 06:14:55 +08:00
|
|
|
/*
|
|
|
|
* Prepare the tmpfile inode as if it were created through the VFS.
|
xfs: don't ever put nlink > 0 inodes on the unlinked list
When XFS creates an O_TMPFILE file, the inode is created with nlink = 1,
put on the unlinked list, and then the VFS sets nlink = 0 in d_tmpfile.
If we crash before anything logs the inode (it's dirty incore but the
vfs doesn't tell us it's dirty so we never log that change), the iunlink
processing part of recovery will then explode with a pile of:
XFS: Assertion failed: VFS_I(ip)->i_nlink == 0, file:
fs/xfs/xfs_log_recover.c, line: 5072
Worse yet, since nlink is nonzero, the inodes also don't get cleaned up
and they just leak until the next xfs_repair run.
Therefore, change xfs_iunlink to require that inodes being put on the
unlinked list have nlink == 0, change the tmpfile callers to instantiate
nodes that way, and set the nlink to 1 just prior to calling d_tmpfile.
Fix the comment for xfs_iunlink while we're at it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2019-02-14 03:15:17 +08:00
|
|
|
* Complete the inode setup and flag it as linkable. nlink is already
|
|
|
|
* zero, so we can skip the drop_nlink.
|
2015-05-29 06:14:55 +08:00
|
|
|
*/
|
2016-04-06 05:48:27 +08:00
|
|
|
xfs_setup_iops(tmpfile);
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
xfs_finish_inode_setup(tmpfile);
|
|
|
|
VFS_I(tmpfile)->i_state |= I_LINKABLE;
|
|
|
|
|
|
|
|
*wip = tmpfile;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:46 +08:00
|
|
|
/*
|
|
|
|
* xfs_rename
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_rename(
|
2023-01-13 19:49:25 +08:00
|
|
|
struct mnt_idmap *idmap,
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
struct xfs_inode *src_dp,
|
|
|
|
struct xfs_name *src_name,
|
|
|
|
struct xfs_inode *src_ip,
|
|
|
|
struct xfs_inode *target_dp,
|
|
|
|
struct xfs_name *target_name,
|
|
|
|
struct xfs_inode *target_ip,
|
|
|
|
unsigned int flags)
|
2013-08-12 18:49:46 +08:00
|
|
|
{
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
struct xfs_mount *mp = src_dp->i_mount;
|
|
|
|
struct xfs_trans *tp;
|
|
|
|
struct xfs_inode *wip = NULL; /* whiteout inode */
|
|
|
|
struct xfs_inode *inodes[__XFS_SORT_INODES];
|
2021-01-23 08:48:32 +08:00
|
|
|
int i;
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
int num_inodes = __XFS_SORT_INODES;
|
2015-03-25 12:12:30 +08:00
|
|
|
bool new_parent = (src_dp != target_dp);
|
2016-02-09 13:54:58 +08:00
|
|
|
bool src_is_directory = S_ISDIR(VFS_I(src_ip)->i_mode);
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
int spaceres;
|
2022-03-10 02:10:50 +08:00
|
|
|
bool retried = false;
|
|
|
|
int error, nospace_error = 0;
|
2013-08-12 18:49:46 +08:00
|
|
|
|
|
|
|
trace_xfs_rename(src_dp, target_dp, src_name, target_name);
|
|
|
|
|
2015-03-25 11:08:07 +08:00
|
|
|
if ((flags & RENAME_EXCHANGE) && !target_ip)
|
|
|
|
return -EINVAL;
|
|
|
|
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
/*
|
|
|
|
* If we are doing a whiteout operation, allocate the whiteout inode
|
|
|
|
* we will be placing at the target and ensure the type is set
|
|
|
|
* appropriately.
|
|
|
|
*/
|
|
|
|
if (flags & RENAME_WHITEOUT) {
|
2023-01-13 19:49:25 +08:00
|
|
|
error = xfs_rename_alloc_whiteout(idmap, src_name,
|
2022-07-10 01:56:02 +08:00
|
|
|
target_dp, &wip);
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
/* setup target dirent info as whiteout */
|
|
|
|
src_name->type = XFS_DIR3_FT_CHRDEV;
|
|
|
|
}
|
2013-08-12 18:49:46 +08:00
|
|
|
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
xfs_sort_for_rename(src_dp, target_dp, src_ip, target_ip, wip,
|
2013-08-12 18:49:46 +08:00
|
|
|
inodes, &num_inodes);
|
|
|
|
|
2022-03-10 02:10:50 +08:00
|
|
|
retry:
|
|
|
|
nospace_error = 0;
|
2013-08-12 18:49:46 +08:00
|
|
|
spaceres = XFS_RENAME_SPACE_RES(mp, target_name->len);
|
2016-04-06 07:19:55 +08:00
|
|
|
error = xfs_trans_alloc(mp, &M_RES(mp)->tr_rename, spaceres, 0, 0, &tp);
|
2014-06-25 12:58:08 +08:00
|
|
|
if (error == -ENOSPC) {
|
2022-03-10 02:10:50 +08:00
|
|
|
nospace_error = error;
|
2013-08-12 18:49:46 +08:00
|
|
|
spaceres = 0;
|
2016-04-06 07:19:55 +08:00
|
|
|
error = xfs_trans_alloc(mp, &M_RES(mp)->tr_rename, 0, 0, 0,
|
|
|
|
&tp);
|
2013-08-12 18:49:46 +08:00
|
|
|
}
|
2015-03-25 11:05:43 +08:00
|
|
|
if (error)
|
2016-04-06 07:19:55 +08:00
|
|
|
goto out_release_wip;
|
2013-08-12 18:49:46 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Attach the dquots to the inodes
|
|
|
|
*/
|
|
|
|
error = xfs_qm_vop_rename_dqattach(inodes);
|
2015-03-25 11:05:43 +08:00
|
|
|
if (error)
|
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:46 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Lock all the participating inodes. Depending upon whether
|
|
|
|
* the target_name exists in the target directory, and
|
|
|
|
* whether the target directory is the same as the source
|
2022-10-26 03:16:27 +08:00
|
|
|
* directory, we can lock from 2 to 5 inodes.
|
2013-08-12 18:49:46 +08:00
|
|
|
*/
|
|
|
|
xfs_lock_inodes(inodes, num_inodes, XFS_ILOCK_EXCL);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Join all the inodes to the transaction. From this point on,
|
|
|
|
* we can rely on either trans_commit or trans_cancel to unlock
|
|
|
|
* them.
|
|
|
|
*/
|
2016-11-30 11:33:25 +08:00
|
|
|
xfs_trans_ijoin(tp, src_dp, XFS_ILOCK_EXCL);
|
2013-08-12 18:49:46 +08:00
|
|
|
if (new_parent)
|
2016-11-30 11:33:25 +08:00
|
|
|
xfs_trans_ijoin(tp, target_dp, XFS_ILOCK_EXCL);
|
2013-08-12 18:49:46 +08:00
|
|
|
xfs_trans_ijoin(tp, src_ip, XFS_ILOCK_EXCL);
|
|
|
|
if (target_ip)
|
|
|
|
xfs_trans_ijoin(tp, target_ip, XFS_ILOCK_EXCL);
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
if (wip)
|
|
|
|
xfs_trans_ijoin(tp, wip, XFS_ILOCK_EXCL);
|
2013-08-12 18:49:46 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we are using project inheritance, we only allow renames
|
|
|
|
* into our tree when the project IDs are the same; else the
|
|
|
|
* tree quota mechanism would be circumvented.
|
|
|
|
*/
|
2021-03-30 02:11:44 +08:00
|
|
|
if (unlikely((target_dp->i_diflags & XFS_DIFLAG_PROJINHERIT) &&
|
2021-03-30 02:11:39 +08:00
|
|
|
target_dp->i_projid != src_ip->i_projid)) {
|
2014-06-25 12:58:08 +08:00
|
|
|
error = -EXDEV;
|
2015-03-25 11:05:43 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:46 +08:00
|
|
|
}
|
|
|
|
|
2015-03-25 11:08:07 +08:00
|
|
|
/* RENAME_EXCHANGE is unique from here on. */
|
|
|
|
if (flags & RENAME_EXCHANGE)
|
|
|
|
return xfs_cross_rename(tp, src_dp, src_name, src_ip,
|
|
|
|
target_dp, target_name, target_ip,
|
2018-07-12 13:26:20 +08:00
|
|
|
spaceres);
|
2014-12-24 05:51:42 +08:00
|
|
|
|
2022-03-10 02:10:50 +08:00
|
|
|
/*
|
|
|
|
* Try to reserve quota to handle an expansion of the target directory.
|
|
|
|
* We'll allow the rename to continue in reservationless mode if we hit
|
|
|
|
* a space usage constraint. If we trigger reservationless mode, save
|
|
|
|
* the errno if there isn't any free space in the target directory.
|
|
|
|
*/
|
|
|
|
if (spaceres != 0) {
|
|
|
|
error = xfs_trans_reserve_quota_nblks(tp, target_dp, spaceres,
|
|
|
|
0, false);
|
|
|
|
if (error == -EDQUOT || error == -ENOSPC) {
|
|
|
|
if (!retried) {
|
|
|
|
xfs_trans_cancel(tp);
|
|
|
|
xfs_blockgc_free_quota(target_dp, 0);
|
|
|
|
retried = true;
|
|
|
|
goto retry;
|
|
|
|
}
|
|
|
|
|
|
|
|
nospace_error = error;
|
|
|
|
spaceres = 0;
|
|
|
|
error = 0;
|
|
|
|
}
|
|
|
|
if (error)
|
|
|
|
goto out_trans_cancel;
|
|
|
|
}
|
|
|
|
|
2013-08-12 18:49:46 +08:00
|
|
|
/*
|
2019-09-04 12:06:50 +08:00
|
|
|
* Check for expected errors before we dirty the transaction
|
|
|
|
* so we can return an error without a transaction abort.
|
2013-08-12 18:49:46 +08:00
|
|
|
*/
|
|
|
|
if (target_ip == NULL) {
|
|
|
|
/*
|
|
|
|
* If there's no space reservation, check the entry will
|
|
|
|
* fit before actually inserting it.
|
|
|
|
*/
|
2014-09-09 09:57:52 +08:00
|
|
|
if (!spaceres) {
|
|
|
|
error = xfs_dir_canenter(tp, target_dp, target_name);
|
|
|
|
if (error)
|
2015-03-25 11:05:43 +08:00
|
|
|
goto out_trans_cancel;
|
2014-09-09 09:57:52 +08:00
|
|
|
}
|
2019-09-04 12:06:50 +08:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* If target exists and it's a directory, check that whether
|
|
|
|
* it can be destroyed.
|
|
|
|
*/
|
|
|
|
if (S_ISDIR(VFS_I(target_ip)->i_mode) &&
|
|
|
|
(!xfs_dir_isempty(target_ip) ||
|
|
|
|
(VFS_I(target_ip)->i_nlink > 2))) {
|
|
|
|
error = -EEXIST;
|
|
|
|
goto out_trans_cancel;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-01-23 08:48:32 +08:00
|
|
|
/*
|
|
|
|
* Lock the AGI buffers we need to handle bumping the nlink of the
|
|
|
|
* whiteout inode off the unlinked list and to handle dropping the
|
|
|
|
* nlink of the target inode. Per locking order rules, do this in
|
|
|
|
* increasing AG order and before directory block allocation tries to
|
|
|
|
* grab AGFs because we grab AGIs before AGFs.
|
|
|
|
*
|
|
|
|
* The (vfs) caller must ensure that if src is a directory then
|
|
|
|
* target_ip is either null or an empty directory.
|
|
|
|
*/
|
|
|
|
for (i = 0; i < num_inodes && inodes[i] != NULL; i++) {
|
|
|
|
if (inodes[i] == wip ||
|
|
|
|
(inodes[i] == target_ip &&
|
|
|
|
(VFS_I(target_ip)->i_nlink == 1 || src_is_directory))) {
|
2022-07-07 17:07:47 +08:00
|
|
|
struct xfs_perag *pag;
|
|
|
|
struct xfs_buf *bp;
|
2021-01-23 08:48:32 +08:00
|
|
|
|
2022-07-07 17:07:47 +08:00
|
|
|
pag = xfs_perag_get(mp,
|
|
|
|
XFS_INO_TO_AGNO(mp, inodes[i]->i_ino));
|
|
|
|
error = xfs_read_agi(pag, tp, &bp);
|
|
|
|
xfs_perag_put(pag);
|
2021-01-23 08:48:32 +08:00
|
|
|
if (error)
|
|
|
|
goto out_trans_cancel;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-09-04 12:06:50 +08:00
|
|
|
/*
|
|
|
|
* Directory entry creation below may acquire the AGF. Remove
|
|
|
|
* the whiteout from the unlinked list first to preserve correct
|
|
|
|
* AGI/AGF locking order. This dirties the transaction so failures
|
|
|
|
* after this point will abort and log recovery will clean up the
|
|
|
|
* mess.
|
|
|
|
*
|
|
|
|
* For whiteouts, we need to bump the link count on the whiteout
|
|
|
|
* inode. After this point, we have a real link, clear the tmpfile
|
|
|
|
* state flag from the inode so it doesn't accidentally get misused
|
|
|
|
* in future.
|
|
|
|
*/
|
|
|
|
if (wip) {
|
2021-06-02 08:48:51 +08:00
|
|
|
struct xfs_perag *pag;
|
|
|
|
|
2019-09-04 12:06:50 +08:00
|
|
|
ASSERT(VFS_I(wip)->i_nlink == 0);
|
2021-06-02 08:48:51 +08:00
|
|
|
|
|
|
|
pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, wip->i_ino));
|
|
|
|
error = xfs_iunlink_remove(tp, pag, wip);
|
|
|
|
xfs_perag_put(pag);
|
2019-09-04 12:06:50 +08:00
|
|
|
if (error)
|
|
|
|
goto out_trans_cancel;
|
|
|
|
|
|
|
|
xfs_bumplink(tp, wip);
|
|
|
|
VFS_I(wip)->i_state &= ~I_LINKABLE;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Set up the target.
|
|
|
|
*/
|
|
|
|
if (target_ip == NULL) {
|
2013-08-12 18:49:46 +08:00
|
|
|
/*
|
|
|
|
* If target does not exist and the rename crosses
|
|
|
|
* directories, adjust the target directory link count
|
|
|
|
* to account for the ".." reference from the new entry.
|
|
|
|
*/
|
|
|
|
error = xfs_dir_createname(tp, target_dp, target_name,
|
2018-07-12 13:26:21 +08:00
|
|
|
src_ip->i_ino, spaceres);
|
2013-08-12 18:49:46 +08:00
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:46 +08:00
|
|
|
|
|
|
|
xfs_trans_ichgtime(tp, target_dp,
|
|
|
|
XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
|
|
|
|
|
|
|
|
if (new_parent && src_is_directory) {
|
2019-05-02 11:26:30 +08:00
|
|
|
xfs_bumplink(tp, target_dp);
|
2013-08-12 18:49:46 +08:00
|
|
|
}
|
|
|
|
} else { /* target_ip != NULL */
|
|
|
|
/*
|
|
|
|
* Link the source inode under the target name.
|
|
|
|
* If the source inode is a directory and we are moving
|
|
|
|
* it across directories, its ".." entry will be
|
|
|
|
* inconsistent until we replace that down below.
|
|
|
|
*
|
|
|
|
* In case there is already an entry with the same
|
|
|
|
* name at the destination directory, remove it first.
|
|
|
|
*/
|
|
|
|
error = xfs_dir_replace(tp, target_dp, target_name,
|
2018-07-12 13:26:21 +08:00
|
|
|
src_ip->i_ino, spaceres);
|
2013-08-12 18:49:46 +08:00
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:46 +08:00
|
|
|
|
|
|
|
xfs_trans_ichgtime(tp, target_dp,
|
|
|
|
XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Decrement the link count on the target since the target
|
|
|
|
* dir no longer points to it.
|
|
|
|
*/
|
|
|
|
error = xfs_droplink(tp, target_ip);
|
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:46 +08:00
|
|
|
|
|
|
|
if (src_is_directory) {
|
|
|
|
/*
|
|
|
|
* Drop the link from the old "." entry.
|
|
|
|
*/
|
|
|
|
error = xfs_droplink(tp, target_ip);
|
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:46 +08:00
|
|
|
}
|
|
|
|
} /* target_ip != NULL */
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Remove the source.
|
|
|
|
*/
|
|
|
|
if (new_parent && src_is_directory) {
|
|
|
|
/*
|
|
|
|
* Rewrite the ".." entry to point to the new
|
|
|
|
* directory.
|
|
|
|
*/
|
|
|
|
error = xfs_dir_replace(tp, src_ip, &xfs_name_dotdot,
|
2018-07-12 13:26:21 +08:00
|
|
|
target_dp->i_ino, spaceres);
|
2014-06-25 12:58:08 +08:00
|
|
|
ASSERT(error != -EEXIST);
|
2013-08-12 18:49:46 +08:00
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:46 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We always want to hit the ctime on the source inode.
|
|
|
|
*
|
|
|
|
* This isn't strictly required by the standards since the source
|
|
|
|
* inode isn't really being changed, but old unix file systems did
|
|
|
|
* it and some incremental backup programs won't work without it.
|
|
|
|
*/
|
|
|
|
xfs_trans_ichgtime(tp, src_ip, XFS_ICHGTIME_CHG);
|
|
|
|
xfs_trans_log_inode(tp, src_ip, XFS_ILOG_CORE);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Adjust the link count on src_dp. This is necessary when
|
|
|
|
* renaming a directory, either within one parent when
|
|
|
|
* the target existed, or across two parent directories.
|
|
|
|
*/
|
|
|
|
if (src_is_directory && (new_parent || target_ip != NULL)) {
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Decrement link count on src_directory since the
|
|
|
|
* entry that's moved no longer points to it.
|
|
|
|
*/
|
|
|
|
error = xfs_droplink(tp, src_dp);
|
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:46 +08:00
|
|
|
}
|
|
|
|
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
/*
|
|
|
|
* For whiteouts, we only need to update the source dirent with the
|
|
|
|
* inode number of the whiteout inode rather than removing it
|
|
|
|
* altogether.
|
|
|
|
*/
|
2022-03-29 14:14:00 +08:00
|
|
|
if (wip)
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
error = xfs_dir_replace(tp, src_dp, src_name, wip->i_ino,
|
2018-07-12 13:26:21 +08:00
|
|
|
spaceres);
|
2022-03-29 14:14:00 +08:00
|
|
|
else
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
error = xfs_dir_removename(tp, src_dp, src_name, src_ip->i_ino,
|
2018-07-12 13:26:21 +08:00
|
|
|
spaceres);
|
2021-01-23 08:48:13 +08:00
|
|
|
|
2013-08-12 18:49:46 +08:00
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-08-12 18:49:46 +08:00
|
|
|
|
|
|
|
xfs_trans_ichgtime(tp, src_dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
|
|
|
|
xfs_trans_log_inode(tp, src_dp, XFS_ILOG_CORE);
|
|
|
|
if (new_parent)
|
|
|
|
xfs_trans_log_inode(tp, target_dp, XFS_ILOG_CORE);
|
|
|
|
|
2018-07-12 13:26:08 +08:00
|
|
|
error = xfs_finish_rename(tp);
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
if (wip)
|
2018-07-26 03:52:32 +08:00
|
|
|
xfs_irele(wip);
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
return error;
|
2013-08-12 18:49:46 +08:00
|
|
|
|
2015-03-25 11:05:43 +08:00
|
|
|
out_trans_cancel:
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2016-04-06 07:19:55 +08:00
|
|
|
out_release_wip:
|
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 11:08:08 +08:00
|
|
|
if (wip)
|
2018-07-26 03:52:32 +08:00
|
|
|
xfs_irele(wip);
|
2022-03-10 02:10:50 +08:00
|
|
|
if (error == -ENOSPC && nospace_error)
|
|
|
|
error = nospace_error;
|
2013-08-12 18:49:46 +08:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2020-06-30 05:49:19 +08:00
|
|
|
static int
|
|
|
|
xfs_iflush(
|
2013-04-03 13:11:17 +08:00
|
|
|
struct xfs_inode *ip,
|
|
|
|
struct xfs_buf *bp)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2013-04-03 13:11:17 +08:00
|
|
|
struct xfs_inode_log_item *iip = ip->i_itemp;
|
|
|
|
struct xfs_dinode *dip;
|
|
|
|
struct xfs_mount *mp = ip->i_mount;
|
2020-05-07 04:25:20 +08:00
|
|
|
int error;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-04-22 15:34:00 +08:00
|
|
|
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_ILOCK_SHARED));
|
2020-08-18 07:41:01 +08:00
|
|
|
ASSERT(xfs_iflags_test(ip, XFS_IFLUSHING));
|
2020-05-19 01:28:05 +08:00
|
|
|
ASSERT(ip->i_df.if_format != XFS_DINODE_FMT_BTREE ||
|
2020-05-19 01:27:22 +08:00
|
|
|
ip->i_df.if_nextents > XFS_IFORK_MAXEXT(ip, XFS_DATA_FORK));
|
2020-06-30 05:49:19 +08:00
|
|
|
ASSERT(iip->ili_item.li_buf == bp);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2015-06-22 07:44:29 +08:00
|
|
|
dip = xfs_buf_offset(bp, ip->i_imap.im_boffset);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-05-07 04:25:20 +08:00
|
|
|
/*
|
|
|
|
* We don't flush the inode if any of the following checks fail, but we
|
|
|
|
* do still update the log item and attach to the backing buffer as if
|
|
|
|
* the flush happened. This is a formality to facilitate predictable
|
|
|
|
* error handling as the caller will shutdown and fail the buffer.
|
|
|
|
*/
|
|
|
|
error = -EFSCORRUPTED;
|
2011-07-08 20:36:05 +08:00
|
|
|
if (XFS_TEST_ERROR(dip->di_magic != cpu_to_be16(XFS_DINODE_MAGIC),
|
2017-06-21 08:54:47 +08:00
|
|
|
mp, XFS_ERRTAG_IFLUSH_1)) {
|
2011-03-07 07:02:35 +08:00
|
|
|
xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
|
2022-09-19 04:47:14 +08:00
|
|
|
"%s: Bad inode %llu magic number 0x%x, ptr "PTR_FMT,
|
2011-03-07 07:02:35 +08:00
|
|
|
__func__, ip->i_ino, be16_to_cpu(dip->di_magic), dip);
|
2020-05-07 04:25:20 +08:00
|
|
|
goto flush_out;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2016-02-09 13:54:58 +08:00
|
|
|
if (S_ISREG(VFS_I(ip)->i_mode)) {
|
2005-04-17 06:20:36 +08:00
|
|
|
if (XFS_TEST_ERROR(
|
2020-05-19 01:28:05 +08:00
|
|
|
ip->i_df.if_format != XFS_DINODE_FMT_EXTENTS &&
|
|
|
|
ip->i_df.if_format != XFS_DINODE_FMT_BTREE,
|
2017-06-21 08:54:47 +08:00
|
|
|
mp, XFS_ERRTAG_IFLUSH_3)) {
|
2011-03-07 07:02:35 +08:00
|
|
|
xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
|
2022-09-19 04:47:14 +08:00
|
|
|
"%s: Bad regular inode %llu, ptr "PTR_FMT,
|
2011-03-07 07:02:35 +08:00
|
|
|
__func__, ip->i_ino, ip);
|
2020-05-07 04:25:20 +08:00
|
|
|
goto flush_out;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2016-02-09 13:54:58 +08:00
|
|
|
} else if (S_ISDIR(VFS_I(ip)->i_mode)) {
|
2005-04-17 06:20:36 +08:00
|
|
|
if (XFS_TEST_ERROR(
|
2020-05-19 01:28:05 +08:00
|
|
|
ip->i_df.if_format != XFS_DINODE_FMT_EXTENTS &&
|
|
|
|
ip->i_df.if_format != XFS_DINODE_FMT_BTREE &&
|
|
|
|
ip->i_df.if_format != XFS_DINODE_FMT_LOCAL,
|
2017-06-21 08:54:47 +08:00
|
|
|
mp, XFS_ERRTAG_IFLUSH_4)) {
|
2011-03-07 07:02:35 +08:00
|
|
|
xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
|
2022-09-19 04:47:14 +08:00
|
|
|
"%s: Bad directory inode %llu, ptr "PTR_FMT,
|
2011-03-07 07:02:35 +08:00
|
|
|
__func__, ip->i_ino, ip);
|
2020-05-07 04:25:20 +08:00
|
|
|
goto flush_out;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
}
|
xfs: make inode attribute forks a permanent part of struct xfs_inode
Syzkaller reported a UAF bug a while back:
==================================================================
BUG: KASAN: use-after-free in xfs_ilock_attr_map_shared+0xe3/0xf6 fs/xfs/xfs_inode.c:127
Read of size 4 at addr ffff88802cec919c by task syz-executor262/2958
CPU: 2 PID: 2958 Comm: syz-executor262 Not tainted
5.15.0-0.30.3-20220406_1406 #3
Hardware name: Red Hat KVM, BIOS 1.13.0-2.module+el8.3.0+7860+a7792d29
04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x82/0xa9 lib/dump_stack.c:106
print_address_description.constprop.9+0x21/0x2d5 mm/kasan/report.c:256
__kasan_report mm/kasan/report.c:442 [inline]
kasan_report.cold.14+0x7f/0x11b mm/kasan/report.c:459
xfs_ilock_attr_map_shared+0xe3/0xf6 fs/xfs/xfs_inode.c:127
xfs_attr_get+0x378/0x4c2 fs/xfs/libxfs/xfs_attr.c:159
xfs_xattr_get+0xe3/0x150 fs/xfs/xfs_xattr.c:36
__vfs_getxattr+0xdf/0x13d fs/xattr.c:399
cap_inode_need_killpriv+0x41/0x5d security/commoncap.c:300
security_inode_need_killpriv+0x4c/0x97 security/security.c:1408
dentry_needs_remove_privs.part.28+0x21/0x63 fs/inode.c:1912
dentry_needs_remove_privs+0x80/0x9e fs/inode.c:1908
do_truncate+0xc3/0x1e0 fs/open.c:56
handle_truncate fs/namei.c:3084 [inline]
do_open fs/namei.c:3432 [inline]
path_openat+0x30ab/0x396d fs/namei.c:3561
do_filp_open+0x1c4/0x290 fs/namei.c:3588
do_sys_openat2+0x60d/0x98c fs/open.c:1212
do_sys_open+0xcf/0x13c fs/open.c:1228
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
RIP: 0033:0x7f7ef4bb753d
Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48
89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73
01 c3 48 8b 0d 1b 79 2c 00 f7 d8 64 89 01 48
RSP: 002b:00007f7ef52c2ed8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 0000000000404148 RCX: 00007f7ef4bb753d
RDX: 00007f7ef4bb753d RSI: 0000000000000000 RDI: 0000000020004fc0
RBP: 0000000000404140 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0030656c69662f2e
R13: 00007ffd794db37f R14: 00007ffd794db470 R15: 00007f7ef52c2fc0
</TASK>
Allocated by task 2953:
kasan_save_stack+0x19/0x38 mm/kasan/common.c:38
kasan_set_track mm/kasan/common.c:46 [inline]
set_alloc_info mm/kasan/common.c:434 [inline]
__kasan_slab_alloc+0x68/0x7c mm/kasan/common.c:467
kasan_slab_alloc include/linux/kasan.h:254 [inline]
slab_post_alloc_hook mm/slab.h:519 [inline]
slab_alloc_node mm/slub.c:3213 [inline]
slab_alloc mm/slub.c:3221 [inline]
kmem_cache_alloc+0x11b/0x3eb mm/slub.c:3226
kmem_cache_zalloc include/linux/slab.h:711 [inline]
xfs_ifork_alloc+0x25/0xa2 fs/xfs/libxfs/xfs_inode_fork.c:287
xfs_bmap_add_attrfork+0x3f2/0x9b1 fs/xfs/libxfs/xfs_bmap.c:1098
xfs_attr_set+0xe38/0x12a7 fs/xfs/libxfs/xfs_attr.c:746
xfs_xattr_set+0xeb/0x1a9 fs/xfs/xfs_xattr.c:59
__vfs_setxattr+0x11b/0x177 fs/xattr.c:180
__vfs_setxattr_noperm+0x128/0x5e0 fs/xattr.c:214
__vfs_setxattr_locked+0x1d4/0x258 fs/xattr.c:275
vfs_setxattr+0x154/0x33d fs/xattr.c:301
setxattr+0x216/0x29f fs/xattr.c:575
__do_sys_fsetxattr fs/xattr.c:632 [inline]
__se_sys_fsetxattr fs/xattr.c:621 [inline]
__x64_sys_fsetxattr+0x243/0x2fe fs/xattr.c:621
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
Freed by task 2949:
kasan_save_stack+0x19/0x38 mm/kasan/common.c:38
kasan_set_track+0x1c/0x21 mm/kasan/common.c:46
kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:360
____kasan_slab_free mm/kasan/common.c:366 [inline]
____kasan_slab_free mm/kasan/common.c:328 [inline]
__kasan_slab_free+0xe2/0x10e mm/kasan/common.c:374
kasan_slab_free include/linux/kasan.h:230 [inline]
slab_free_hook mm/slub.c:1700 [inline]
slab_free_freelist_hook mm/slub.c:1726 [inline]
slab_free mm/slub.c:3492 [inline]
kmem_cache_free+0xdc/0x3ce mm/slub.c:3508
xfs_attr_fork_remove+0x8d/0x132 fs/xfs/libxfs/xfs_attr_leaf.c:773
xfs_attr_sf_removename+0x5dd/0x6cb fs/xfs/libxfs/xfs_attr_leaf.c:822
xfs_attr_remove_iter+0x68c/0x805 fs/xfs/libxfs/xfs_attr.c:1413
xfs_attr_remove_args+0xb1/0x10d fs/xfs/libxfs/xfs_attr.c:684
xfs_attr_set+0xf1e/0x12a7 fs/xfs/libxfs/xfs_attr.c:802
xfs_xattr_set+0xeb/0x1a9 fs/xfs/xfs_xattr.c:59
__vfs_removexattr+0x106/0x16a fs/xattr.c:468
cap_inode_killpriv+0x24/0x47 security/commoncap.c:324
security_inode_killpriv+0x54/0xa1 security/security.c:1414
setattr_prepare+0x1a6/0x897 fs/attr.c:146
xfs_vn_change_ok+0x111/0x15e fs/xfs/xfs_iops.c:682
xfs_vn_setattr_size+0x5f/0x15a fs/xfs/xfs_iops.c:1065
xfs_vn_setattr+0x125/0x2ad fs/xfs/xfs_iops.c:1093
notify_change+0xae5/0x10a1 fs/attr.c:410
do_truncate+0x134/0x1e0 fs/open.c:64
handle_truncate fs/namei.c:3084 [inline]
do_open fs/namei.c:3432 [inline]
path_openat+0x30ab/0x396d fs/namei.c:3561
do_filp_open+0x1c4/0x290 fs/namei.c:3588
do_sys_openat2+0x60d/0x98c fs/open.c:1212
do_sys_open+0xcf/0x13c fs/open.c:1228
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
The buggy address belongs to the object at ffff88802cec9188
which belongs to the cache xfs_ifork of size 40
The buggy address is located 20 bytes inside of
40-byte region [ffff88802cec9188, ffff88802cec91b0)
The buggy address belongs to the page:
page:00000000c3af36a1 refcount:1 mapcount:0 mapping:0000000000000000
index:0x0 pfn:0x2cec9
flags: 0xfffffc0000200(slab|node=0|zone=1|lastcpupid=0x1fffff)
raw: 000fffffc0000200 ffffea00009d2580 0000000600000006 ffff88801a9ffc80
raw: 0000000000000000 0000000080490049 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff88802cec9080: fb fb fb fc fc fa fb fb fb fb fc fc fb fb fb fb
ffff88802cec9100: fb fc fc fb fb fb fb fb fc fc fb fb fb fb fb fc
>ffff88802cec9180: fc fa fb fb fb fb fc fc fa fb fb fb fb fc fc fb
^
ffff88802cec9200: fb fb fb fb fc fc fb fb fb fb fb fc fc fb fb fb
ffff88802cec9280: fb fb fc fc fa fb fb fb fb fc fc fa fb fb fb fb
==================================================================
The root cause of this bug is the unlocked access to xfs_inode.i_afp
from the getxattr code paths while trying to determine which ILOCK mode
to use to stabilize the xattr data. Unfortunately, the VFS does not
acquire i_rwsem when vfs_getxattr (or listxattr) call into the
filesystem, which means that getxattr can race with a removexattr that's
tearing down the attr fork and crash:
xfs_attr_set: xfs_attr_get:
xfs_attr_fork_remove: xfs_ilock_attr_map_shared:
xfs_idestroy_fork(ip->i_afp);
kmem_cache_free(xfs_ifork_cache, ip->i_afp);
if (ip->i_afp &&
ip->i_afp = NULL;
xfs_need_iread_extents(ip->i_afp))
<KABOOM>
ip->i_forkoff = 0;
Regrettably, the VFS is much more lax about i_rwsem and getxattr than
is immediately obvious -- not only does it not guarantee that we hold
i_rwsem, it actually doesn't guarantee that we *don't* hold it either.
The getxattr system call won't acquire the lock before calling XFS, but
the file capabilities code calls getxattr with and without i_rwsem held
to determine if the "security.capabilities" xattr is set on the file.
Fixing the VFS locking requires a treewide investigation into every code
path that could touch an xattr and what i_rwsem state it expects or sets
up. That could take years or even prove impossible; fortunately, we
can fix this UAF problem inside XFS.
An earlier version of this patch used smp_wmb in xfs_attr_fork_remove to
ensure that i_forkoff is always zeroed before i_afp is set to null and
changed the read paths to use smp_rmb before accessing i_forkoff and
i_afp, which avoided these UAF problems. However, the patch author was
too busy dealing with other problems in the meantime, and by the time he
came back to this issue, the situation had changed a bit.
On a modern system with selinux, each inode will always have at least
one xattr for the selinux label, so it doesn't make much sense to keep
incurring the extra pointer dereference. Furthermore, Allison's
upcoming parent pointer patchset will also cause nearly every inode in
the filesystem to have extended attributes. Therefore, make the inode
attribute fork structure part of struct xfs_inode, at a cost of 40 more
bytes.
This patch adds a clunky if_present field where necessary to maintain
the existing logic of xattr fork null pointer testing in the existing
codebase. The next patch switches the logic over to XFS_IFORK_Q and it
all goes away.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
2022-07-10 01:56:06 +08:00
|
|
|
if (XFS_TEST_ERROR(ip->i_df.if_nextents + xfs_ifork_nextents(&ip->i_af) >
|
2021-03-30 02:11:40 +08:00
|
|
|
ip->i_nblocks, mp, XFS_ERRTAG_IFLUSH_5)) {
|
2011-03-07 07:02:35 +08:00
|
|
|
xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
|
2021-11-16 15:28:40 +08:00
|
|
|
"%s: detected corrupt incore inode %llu, "
|
|
|
|
"total extents = %llu nblocks = %lld, ptr "PTR_FMT,
|
2011-03-07 07:02:35 +08:00
|
|
|
__func__, ip->i_ino,
|
xfs: make inode attribute forks a permanent part of struct xfs_inode
Syzkaller reported a UAF bug a while back:
==================================================================
BUG: KASAN: use-after-free in xfs_ilock_attr_map_shared+0xe3/0xf6 fs/xfs/xfs_inode.c:127
Read of size 4 at addr ffff88802cec919c by task syz-executor262/2958
CPU: 2 PID: 2958 Comm: syz-executor262 Not tainted
5.15.0-0.30.3-20220406_1406 #3
Hardware name: Red Hat KVM, BIOS 1.13.0-2.module+el8.3.0+7860+a7792d29
04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x82/0xa9 lib/dump_stack.c:106
print_address_description.constprop.9+0x21/0x2d5 mm/kasan/report.c:256
__kasan_report mm/kasan/report.c:442 [inline]
kasan_report.cold.14+0x7f/0x11b mm/kasan/report.c:459
xfs_ilock_attr_map_shared+0xe3/0xf6 fs/xfs/xfs_inode.c:127
xfs_attr_get+0x378/0x4c2 fs/xfs/libxfs/xfs_attr.c:159
xfs_xattr_get+0xe3/0x150 fs/xfs/xfs_xattr.c:36
__vfs_getxattr+0xdf/0x13d fs/xattr.c:399
cap_inode_need_killpriv+0x41/0x5d security/commoncap.c:300
security_inode_need_killpriv+0x4c/0x97 security/security.c:1408
dentry_needs_remove_privs.part.28+0x21/0x63 fs/inode.c:1912
dentry_needs_remove_privs+0x80/0x9e fs/inode.c:1908
do_truncate+0xc3/0x1e0 fs/open.c:56
handle_truncate fs/namei.c:3084 [inline]
do_open fs/namei.c:3432 [inline]
path_openat+0x30ab/0x396d fs/namei.c:3561
do_filp_open+0x1c4/0x290 fs/namei.c:3588
do_sys_openat2+0x60d/0x98c fs/open.c:1212
do_sys_open+0xcf/0x13c fs/open.c:1228
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
RIP: 0033:0x7f7ef4bb753d
Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48
89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73
01 c3 48 8b 0d 1b 79 2c 00 f7 d8 64 89 01 48
RSP: 002b:00007f7ef52c2ed8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 0000000000404148 RCX: 00007f7ef4bb753d
RDX: 00007f7ef4bb753d RSI: 0000000000000000 RDI: 0000000020004fc0
RBP: 0000000000404140 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0030656c69662f2e
R13: 00007ffd794db37f R14: 00007ffd794db470 R15: 00007f7ef52c2fc0
</TASK>
Allocated by task 2953:
kasan_save_stack+0x19/0x38 mm/kasan/common.c:38
kasan_set_track mm/kasan/common.c:46 [inline]
set_alloc_info mm/kasan/common.c:434 [inline]
__kasan_slab_alloc+0x68/0x7c mm/kasan/common.c:467
kasan_slab_alloc include/linux/kasan.h:254 [inline]
slab_post_alloc_hook mm/slab.h:519 [inline]
slab_alloc_node mm/slub.c:3213 [inline]
slab_alloc mm/slub.c:3221 [inline]
kmem_cache_alloc+0x11b/0x3eb mm/slub.c:3226
kmem_cache_zalloc include/linux/slab.h:711 [inline]
xfs_ifork_alloc+0x25/0xa2 fs/xfs/libxfs/xfs_inode_fork.c:287
xfs_bmap_add_attrfork+0x3f2/0x9b1 fs/xfs/libxfs/xfs_bmap.c:1098
xfs_attr_set+0xe38/0x12a7 fs/xfs/libxfs/xfs_attr.c:746
xfs_xattr_set+0xeb/0x1a9 fs/xfs/xfs_xattr.c:59
__vfs_setxattr+0x11b/0x177 fs/xattr.c:180
__vfs_setxattr_noperm+0x128/0x5e0 fs/xattr.c:214
__vfs_setxattr_locked+0x1d4/0x258 fs/xattr.c:275
vfs_setxattr+0x154/0x33d fs/xattr.c:301
setxattr+0x216/0x29f fs/xattr.c:575
__do_sys_fsetxattr fs/xattr.c:632 [inline]
__se_sys_fsetxattr fs/xattr.c:621 [inline]
__x64_sys_fsetxattr+0x243/0x2fe fs/xattr.c:621
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
Freed by task 2949:
kasan_save_stack+0x19/0x38 mm/kasan/common.c:38
kasan_set_track+0x1c/0x21 mm/kasan/common.c:46
kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:360
____kasan_slab_free mm/kasan/common.c:366 [inline]
____kasan_slab_free mm/kasan/common.c:328 [inline]
__kasan_slab_free+0xe2/0x10e mm/kasan/common.c:374
kasan_slab_free include/linux/kasan.h:230 [inline]
slab_free_hook mm/slub.c:1700 [inline]
slab_free_freelist_hook mm/slub.c:1726 [inline]
slab_free mm/slub.c:3492 [inline]
kmem_cache_free+0xdc/0x3ce mm/slub.c:3508
xfs_attr_fork_remove+0x8d/0x132 fs/xfs/libxfs/xfs_attr_leaf.c:773
xfs_attr_sf_removename+0x5dd/0x6cb fs/xfs/libxfs/xfs_attr_leaf.c:822
xfs_attr_remove_iter+0x68c/0x805 fs/xfs/libxfs/xfs_attr.c:1413
xfs_attr_remove_args+0xb1/0x10d fs/xfs/libxfs/xfs_attr.c:684
xfs_attr_set+0xf1e/0x12a7 fs/xfs/libxfs/xfs_attr.c:802
xfs_xattr_set+0xeb/0x1a9 fs/xfs/xfs_xattr.c:59
__vfs_removexattr+0x106/0x16a fs/xattr.c:468
cap_inode_killpriv+0x24/0x47 security/commoncap.c:324
security_inode_killpriv+0x54/0xa1 security/security.c:1414
setattr_prepare+0x1a6/0x897 fs/attr.c:146
xfs_vn_change_ok+0x111/0x15e fs/xfs/xfs_iops.c:682
xfs_vn_setattr_size+0x5f/0x15a fs/xfs/xfs_iops.c:1065
xfs_vn_setattr+0x125/0x2ad fs/xfs/xfs_iops.c:1093
notify_change+0xae5/0x10a1 fs/attr.c:410
do_truncate+0x134/0x1e0 fs/open.c:64
handle_truncate fs/namei.c:3084 [inline]
do_open fs/namei.c:3432 [inline]
path_openat+0x30ab/0x396d fs/namei.c:3561
do_filp_open+0x1c4/0x290 fs/namei.c:3588
do_sys_openat2+0x60d/0x98c fs/open.c:1212
do_sys_open+0xcf/0x13c fs/open.c:1228
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
The buggy address belongs to the object at ffff88802cec9188
which belongs to the cache xfs_ifork of size 40
The buggy address is located 20 bytes inside of
40-byte region [ffff88802cec9188, ffff88802cec91b0)
The buggy address belongs to the page:
page:00000000c3af36a1 refcount:1 mapcount:0 mapping:0000000000000000
index:0x0 pfn:0x2cec9
flags: 0xfffffc0000200(slab|node=0|zone=1|lastcpupid=0x1fffff)
raw: 000fffffc0000200 ffffea00009d2580 0000000600000006 ffff88801a9ffc80
raw: 0000000000000000 0000000080490049 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff88802cec9080: fb fb fb fc fc fa fb fb fb fb fc fc fb fb fb fb
ffff88802cec9100: fb fc fc fb fb fb fb fb fc fc fb fb fb fb fb fc
>ffff88802cec9180: fc fa fb fb fb fb fc fc fa fb fb fb fb fc fc fb
^
ffff88802cec9200: fb fb fb fb fc fc fb fb fb fb fb fc fc fb fb fb
ffff88802cec9280: fb fb fc fc fa fb fb fb fb fc fc fa fb fb fb fb
==================================================================
The root cause of this bug is the unlocked access to xfs_inode.i_afp
from the getxattr code paths while trying to determine which ILOCK mode
to use to stabilize the xattr data. Unfortunately, the VFS does not
acquire i_rwsem when vfs_getxattr (or listxattr) call into the
filesystem, which means that getxattr can race with a removexattr that's
tearing down the attr fork and crash:
xfs_attr_set: xfs_attr_get:
xfs_attr_fork_remove: xfs_ilock_attr_map_shared:
xfs_idestroy_fork(ip->i_afp);
kmem_cache_free(xfs_ifork_cache, ip->i_afp);
if (ip->i_afp &&
ip->i_afp = NULL;
xfs_need_iread_extents(ip->i_afp))
<KABOOM>
ip->i_forkoff = 0;
Regrettably, the VFS is much more lax about i_rwsem and getxattr than
is immediately obvious -- not only does it not guarantee that we hold
i_rwsem, it actually doesn't guarantee that we *don't* hold it either.
The getxattr system call won't acquire the lock before calling XFS, but
the file capabilities code calls getxattr with and without i_rwsem held
to determine if the "security.capabilities" xattr is set on the file.
Fixing the VFS locking requires a treewide investigation into every code
path that could touch an xattr and what i_rwsem state it expects or sets
up. That could take years or even prove impossible; fortunately, we
can fix this UAF problem inside XFS.
An earlier version of this patch used smp_wmb in xfs_attr_fork_remove to
ensure that i_forkoff is always zeroed before i_afp is set to null and
changed the read paths to use smp_rmb before accessing i_forkoff and
i_afp, which avoided these UAF problems. However, the patch author was
too busy dealing with other problems in the meantime, and by the time he
came back to this issue, the situation had changed a bit.
On a modern system with selinux, each inode will always have at least
one xattr for the selinux label, so it doesn't make much sense to keep
incurring the extra pointer dereference. Furthermore, Allison's
upcoming parent pointer patchset will also cause nearly every inode in
the filesystem to have extended attributes. Therefore, make the inode
attribute fork structure part of struct xfs_inode, at a cost of 40 more
bytes.
This patch adds a clunky if_present field where necessary to maintain
the existing logic of xattr fork null pointer testing in the existing
codebase. The next patch switches the logic over to XFS_IFORK_Q and it
all goes away.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
2022-07-10 01:56:06 +08:00
|
|
|
ip->i_df.if_nextents + xfs_ifork_nextents(&ip->i_af),
|
2021-03-30 02:11:40 +08:00
|
|
|
ip->i_nblocks, ip);
|
2020-05-07 04:25:20 +08:00
|
|
|
goto flush_out;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2021-03-30 02:11:44 +08:00
|
|
|
if (XFS_TEST_ERROR(ip->i_forkoff > mp->m_sb.sb_inodesize,
|
2017-06-21 08:54:47 +08:00
|
|
|
mp, XFS_ERRTAG_IFLUSH_6)) {
|
2011-03-07 07:02:35 +08:00
|
|
|
xfs_alert_tag(mp, XFS_PTAG_IFLUSH,
|
2022-09-19 04:47:14 +08:00
|
|
|
"%s: bad inode %llu, forkoff 0x%x, ptr "PTR_FMT,
|
2021-03-30 02:11:44 +08:00
|
|
|
__func__, ip->i_ino, ip->i_forkoff, ip);
|
2020-05-07 04:25:20 +08:00
|
|
|
goto flush_out;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
xfs: di_flushiter considered harmful
When we made all inode updates transactional, we no longer needed
the log recovery detection for inodes being newer on disk than the
transaction being replayed - it was redundant as replay of the log
would always result in the latest version of the inode would be on
disk. It was redundant, but left in place because it wasn't
considered to be a problem.
However, with the new "don't read inodes on create" optimisation,
flushiter has come back to bite us. Essentially, the optimisation
made always initialises flushiter to zero in the create transaction,
and so if we then crash and run recovery and the inode already on
disk has a non-zero flushiter it will skip recovery of that inode.
As a result, log recovery does the wrong thing and we end up with a
corrupt filesystem.
Because we have to support old kernel to new kernel upgrades, we
can't just get rid of the flushiter support in log recovery as we
might be upgrading from a kernel that doesn't have fully transactional
inode updates. Unfortunately, for v4 superblocks there is no way to
guarantee that log recovery knows about this fact.
We cannot add a new inode format flag to say it's a "special inode
create" because it won't be understood by older kernels and so
recovery could do the wrong thing on downgrade. We cannot specially
detect the combination of zero mode/non-zero flushiter on disk to
non-zero mode, zero flushiter in the log item during recovery
because wrapping of the flushiter can result in false detection.
Hence that makes this "don't use flushiter" optimisation limited to
a disk format that guarantees that we don't need it. And that means
the only fix here is to limit the "no read IO on create"
optimisation to version 5 superblocks....
Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-07-24 13:47:30 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2021-03-30 02:11:42 +08:00
|
|
|
* Inode item log recovery for v2 inodes are dependent on the flushiter
|
|
|
|
* count for correct sequencing. We bump the flush iteration count so
|
|
|
|
* we can detect flushes which postdate a log record during recovery.
|
|
|
|
* This is redundant as we now log every change and hence this can't
|
|
|
|
* happen but we need to still do it to ensure backwards compatibility
|
|
|
|
* with old kernels that predate logging all inode changes.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2021-08-19 09:46:37 +08:00
|
|
|
if (!xfs_has_v3inodes(mp))
|
2021-03-30 02:11:42 +08:00
|
|
|
ip->i_flushiter++;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-05-15 05:01:31 +08:00
|
|
|
/*
|
|
|
|
* If there are inline format data / attr forks attached to this inode,
|
|
|
|
* make sure they are not corrupt.
|
|
|
|
*/
|
2020-05-19 01:28:05 +08:00
|
|
|
if (ip->i_df.if_format == XFS_DINODE_FMT_LOCAL &&
|
2020-05-15 05:01:31 +08:00
|
|
|
xfs_ifork_verify_local_data(ip))
|
|
|
|
goto flush_out;
|
2022-07-10 01:56:06 +08:00
|
|
|
if (xfs_inode_has_attr_fork(ip) &&
|
xfs: make inode attribute forks a permanent part of struct xfs_inode
Syzkaller reported a UAF bug a while back:
==================================================================
BUG: KASAN: use-after-free in xfs_ilock_attr_map_shared+0xe3/0xf6 fs/xfs/xfs_inode.c:127
Read of size 4 at addr ffff88802cec919c by task syz-executor262/2958
CPU: 2 PID: 2958 Comm: syz-executor262 Not tainted
5.15.0-0.30.3-20220406_1406 #3
Hardware name: Red Hat KVM, BIOS 1.13.0-2.module+el8.3.0+7860+a7792d29
04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x82/0xa9 lib/dump_stack.c:106
print_address_description.constprop.9+0x21/0x2d5 mm/kasan/report.c:256
__kasan_report mm/kasan/report.c:442 [inline]
kasan_report.cold.14+0x7f/0x11b mm/kasan/report.c:459
xfs_ilock_attr_map_shared+0xe3/0xf6 fs/xfs/xfs_inode.c:127
xfs_attr_get+0x378/0x4c2 fs/xfs/libxfs/xfs_attr.c:159
xfs_xattr_get+0xe3/0x150 fs/xfs/xfs_xattr.c:36
__vfs_getxattr+0xdf/0x13d fs/xattr.c:399
cap_inode_need_killpriv+0x41/0x5d security/commoncap.c:300
security_inode_need_killpriv+0x4c/0x97 security/security.c:1408
dentry_needs_remove_privs.part.28+0x21/0x63 fs/inode.c:1912
dentry_needs_remove_privs+0x80/0x9e fs/inode.c:1908
do_truncate+0xc3/0x1e0 fs/open.c:56
handle_truncate fs/namei.c:3084 [inline]
do_open fs/namei.c:3432 [inline]
path_openat+0x30ab/0x396d fs/namei.c:3561
do_filp_open+0x1c4/0x290 fs/namei.c:3588
do_sys_openat2+0x60d/0x98c fs/open.c:1212
do_sys_open+0xcf/0x13c fs/open.c:1228
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
RIP: 0033:0x7f7ef4bb753d
Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48
89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73
01 c3 48 8b 0d 1b 79 2c 00 f7 d8 64 89 01 48
RSP: 002b:00007f7ef52c2ed8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 0000000000404148 RCX: 00007f7ef4bb753d
RDX: 00007f7ef4bb753d RSI: 0000000000000000 RDI: 0000000020004fc0
RBP: 0000000000404140 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0030656c69662f2e
R13: 00007ffd794db37f R14: 00007ffd794db470 R15: 00007f7ef52c2fc0
</TASK>
Allocated by task 2953:
kasan_save_stack+0x19/0x38 mm/kasan/common.c:38
kasan_set_track mm/kasan/common.c:46 [inline]
set_alloc_info mm/kasan/common.c:434 [inline]
__kasan_slab_alloc+0x68/0x7c mm/kasan/common.c:467
kasan_slab_alloc include/linux/kasan.h:254 [inline]
slab_post_alloc_hook mm/slab.h:519 [inline]
slab_alloc_node mm/slub.c:3213 [inline]
slab_alloc mm/slub.c:3221 [inline]
kmem_cache_alloc+0x11b/0x3eb mm/slub.c:3226
kmem_cache_zalloc include/linux/slab.h:711 [inline]
xfs_ifork_alloc+0x25/0xa2 fs/xfs/libxfs/xfs_inode_fork.c:287
xfs_bmap_add_attrfork+0x3f2/0x9b1 fs/xfs/libxfs/xfs_bmap.c:1098
xfs_attr_set+0xe38/0x12a7 fs/xfs/libxfs/xfs_attr.c:746
xfs_xattr_set+0xeb/0x1a9 fs/xfs/xfs_xattr.c:59
__vfs_setxattr+0x11b/0x177 fs/xattr.c:180
__vfs_setxattr_noperm+0x128/0x5e0 fs/xattr.c:214
__vfs_setxattr_locked+0x1d4/0x258 fs/xattr.c:275
vfs_setxattr+0x154/0x33d fs/xattr.c:301
setxattr+0x216/0x29f fs/xattr.c:575
__do_sys_fsetxattr fs/xattr.c:632 [inline]
__se_sys_fsetxattr fs/xattr.c:621 [inline]
__x64_sys_fsetxattr+0x243/0x2fe fs/xattr.c:621
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
Freed by task 2949:
kasan_save_stack+0x19/0x38 mm/kasan/common.c:38
kasan_set_track+0x1c/0x21 mm/kasan/common.c:46
kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:360
____kasan_slab_free mm/kasan/common.c:366 [inline]
____kasan_slab_free mm/kasan/common.c:328 [inline]
__kasan_slab_free+0xe2/0x10e mm/kasan/common.c:374
kasan_slab_free include/linux/kasan.h:230 [inline]
slab_free_hook mm/slub.c:1700 [inline]
slab_free_freelist_hook mm/slub.c:1726 [inline]
slab_free mm/slub.c:3492 [inline]
kmem_cache_free+0xdc/0x3ce mm/slub.c:3508
xfs_attr_fork_remove+0x8d/0x132 fs/xfs/libxfs/xfs_attr_leaf.c:773
xfs_attr_sf_removename+0x5dd/0x6cb fs/xfs/libxfs/xfs_attr_leaf.c:822
xfs_attr_remove_iter+0x68c/0x805 fs/xfs/libxfs/xfs_attr.c:1413
xfs_attr_remove_args+0xb1/0x10d fs/xfs/libxfs/xfs_attr.c:684
xfs_attr_set+0xf1e/0x12a7 fs/xfs/libxfs/xfs_attr.c:802
xfs_xattr_set+0xeb/0x1a9 fs/xfs/xfs_xattr.c:59
__vfs_removexattr+0x106/0x16a fs/xattr.c:468
cap_inode_killpriv+0x24/0x47 security/commoncap.c:324
security_inode_killpriv+0x54/0xa1 security/security.c:1414
setattr_prepare+0x1a6/0x897 fs/attr.c:146
xfs_vn_change_ok+0x111/0x15e fs/xfs/xfs_iops.c:682
xfs_vn_setattr_size+0x5f/0x15a fs/xfs/xfs_iops.c:1065
xfs_vn_setattr+0x125/0x2ad fs/xfs/xfs_iops.c:1093
notify_change+0xae5/0x10a1 fs/attr.c:410
do_truncate+0x134/0x1e0 fs/open.c:64
handle_truncate fs/namei.c:3084 [inline]
do_open fs/namei.c:3432 [inline]
path_openat+0x30ab/0x396d fs/namei.c:3561
do_filp_open+0x1c4/0x290 fs/namei.c:3588
do_sys_openat2+0x60d/0x98c fs/open.c:1212
do_sys_open+0xcf/0x13c fs/open.c:1228
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x7e arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0x0
The buggy address belongs to the object at ffff88802cec9188
which belongs to the cache xfs_ifork of size 40
The buggy address is located 20 bytes inside of
40-byte region [ffff88802cec9188, ffff88802cec91b0)
The buggy address belongs to the page:
page:00000000c3af36a1 refcount:1 mapcount:0 mapping:0000000000000000
index:0x0 pfn:0x2cec9
flags: 0xfffffc0000200(slab|node=0|zone=1|lastcpupid=0x1fffff)
raw: 000fffffc0000200 ffffea00009d2580 0000000600000006 ffff88801a9ffc80
raw: 0000000000000000 0000000080490049 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff88802cec9080: fb fb fb fc fc fa fb fb fb fb fc fc fb fb fb fb
ffff88802cec9100: fb fc fc fb fb fb fb fb fc fc fb fb fb fb fb fc
>ffff88802cec9180: fc fa fb fb fb fb fc fc fa fb fb fb fb fc fc fb
^
ffff88802cec9200: fb fb fb fb fc fc fb fb fb fb fb fc fc fb fb fb
ffff88802cec9280: fb fb fc fc fa fb fb fb fb fc fc fa fb fb fb fb
==================================================================
The root cause of this bug is the unlocked access to xfs_inode.i_afp
from the getxattr code paths while trying to determine which ILOCK mode
to use to stabilize the xattr data. Unfortunately, the VFS does not
acquire i_rwsem when vfs_getxattr (or listxattr) call into the
filesystem, which means that getxattr can race with a removexattr that's
tearing down the attr fork and crash:
xfs_attr_set: xfs_attr_get:
xfs_attr_fork_remove: xfs_ilock_attr_map_shared:
xfs_idestroy_fork(ip->i_afp);
kmem_cache_free(xfs_ifork_cache, ip->i_afp);
if (ip->i_afp &&
ip->i_afp = NULL;
xfs_need_iread_extents(ip->i_afp))
<KABOOM>
ip->i_forkoff = 0;
Regrettably, the VFS is much more lax about i_rwsem and getxattr than
is immediately obvious -- not only does it not guarantee that we hold
i_rwsem, it actually doesn't guarantee that we *don't* hold it either.
The getxattr system call won't acquire the lock before calling XFS, but
the file capabilities code calls getxattr with and without i_rwsem held
to determine if the "security.capabilities" xattr is set on the file.
Fixing the VFS locking requires a treewide investigation into every code
path that could touch an xattr and what i_rwsem state it expects or sets
up. That could take years or even prove impossible; fortunately, we
can fix this UAF problem inside XFS.
An earlier version of this patch used smp_wmb in xfs_attr_fork_remove to
ensure that i_forkoff is always zeroed before i_afp is set to null and
changed the read paths to use smp_rmb before accessing i_forkoff and
i_afp, which avoided these UAF problems. However, the patch author was
too busy dealing with other problems in the meantime, and by the time he
came back to this issue, the situation had changed a bit.
On a modern system with selinux, each inode will always have at least
one xattr for the selinux label, so it doesn't make much sense to keep
incurring the extra pointer dereference. Furthermore, Allison's
upcoming parent pointer patchset will also cause nearly every inode in
the filesystem to have extended attributes. Therefore, make the inode
attribute fork structure part of struct xfs_inode, at a cost of 40 more
bytes.
This patch adds a clunky if_present field where necessary to maintain
the existing logic of xattr fork null pointer testing in the existing
codebase. The next patch switches the logic over to XFS_IFORK_Q and it
all goes away.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
2022-07-10 01:56:06 +08:00
|
|
|
ip->i_af.if_format == XFS_DINODE_FMT_LOCAL &&
|
2020-05-15 05:01:31 +08:00
|
|
|
xfs_ifork_verify_local_attr(ip))
|
2020-05-07 04:25:20 +08:00
|
|
|
goto flush_out;
|
2017-03-29 05:51:10 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2016-02-09 13:54:58 +08:00
|
|
|
* Copy the dirty parts of the inode into the on-disk inode. We always
|
|
|
|
* copy out the core of the inode, because if the inode is dirty at all
|
|
|
|
* the core must be.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2016-02-09 13:54:58 +08:00
|
|
|
xfs_inode_to_disk(ip, dip, iip->ili_item.li_lsn);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/* Wrap, we never let the log put out DI_MAX_FLUSH */
|
2021-08-19 09:46:37 +08:00
|
|
|
if (!xfs_has_v3inodes(mp)) {
|
2021-03-30 02:11:43 +08:00
|
|
|
if (ip->i_flushiter == DI_MAX_FLUSH)
|
|
|
|
ip->i_flushiter = 0;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2017-03-29 05:51:10 +08:00
|
|
|
xfs_iflush_fork(ip, dip, iip, XFS_DATA_FORK);
|
2022-07-10 01:56:06 +08:00
|
|
|
if (xfs_inode_has_attr_fork(ip))
|
2017-03-29 05:51:10 +08:00
|
|
|
xfs_iflush_fork(ip, dip, iip, XFS_ATTR_FORK);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/*
|
2012-02-29 17:53:54 +08:00
|
|
|
* We've recorded everything logged in the inode, so we'd like to clear
|
|
|
|
* the ili_fields bits so we don't log and flush things unnecessarily.
|
|
|
|
* However, we can't stop logging all this information until the data
|
|
|
|
* we've copied into the disk buffer is written to disk. If we did we
|
|
|
|
* might overwrite the copy of the inode in the log with all the data
|
|
|
|
* after re-logging only part of it, and in the face of a crash we
|
|
|
|
* wouldn't have all the data we need to recover.
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
2012-02-29 17:53:54 +08:00
|
|
|
* What we do is move the bits to the ili_last_fields field. When
|
|
|
|
* logging the inode, these bits are moved back to the ili_fields field.
|
2020-09-02 01:55:29 +08:00
|
|
|
* In the xfs_buf_inode_iodone() routine we clear ili_last_fields, since
|
|
|
|
* we know that the information those bits represent is permanently on
|
2012-02-29 17:53:54 +08:00
|
|
|
* disk. As long as the flush completes before the inode is logged
|
|
|
|
* again, then both ili_fields and ili_last_fields will be cleared.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2020-05-07 04:25:20 +08:00
|
|
|
error = 0;
|
|
|
|
flush_out:
|
2020-06-30 05:48:46 +08:00
|
|
|
spin_lock(&iip->ili_lock);
|
2013-04-03 13:11:17 +08:00
|
|
|
iip->ili_last_fields = iip->ili_fields;
|
|
|
|
iip->ili_fields = 0;
|
xfs: optimise away log forces on timestamp updates for fdatasync
xfs: timestamp updates cause excessive fdatasync log traffic
Sage Weil reported that a ceph test workload was writing to the
log on every fdatasync during an overwrite workload. Event tracing
showed that the only metadata modification being made was the
timestamp updates during the write(2) syscall, but fdatasync(2)
is supposed to ignore them. The key observation was that the
transactions in the log all looked like this:
INODE: #regs: 4 ino: 0x8b flags: 0x45 dsize: 32
And contained a flags field of 0x45 or 0x85, and had data and
attribute forks following the inode core. This means that the
timestamp updates were triggering dirty relogging of previously
logged parts of the inode that hadn't yet been flushed back to
disk.
There are two parts to this problem. The first is that XFS relogs
dirty regions in subsequent transactions, so it carries around the
fields that have been dirtied since the last time the inode was
written back to disk, not since the last time the inode was forced
into the log.
The second part is that on v5 filesystems, the inode change count
update during inode dirtying also sets the XFS_ILOG_CORE flag, so
on v5 filesystems this makes a timestamp update dirty the entire
inode.
As a result when fdatasync is run, it looks at the dirty fields in
the inode, and sees more than just the timestamp flag, even though
the only metadata change since the last fdatasync was just the
timestamps. Hence we force the log on every subsequent fdatasync
even though it is not needed.
To fix this, add a new field to the inode log item that tracks
changes since the last time fsync/fdatasync forced the log to flush
the changes to the journal. This flag is updated when we dirty the
inode, but we do it before updating the change count so it does not
carry the "core dirty" flag from timestamp updates. The fields are
zeroed when the inode is marked clean (due to writeback/freeing) or
when an fsync/datasync forces the log. Hence if we only dirty the
timestamps on the inode between fsync/fdatasync calls, the fdatasync
will not trigger another log force.
Over 100 runs of the test program:
Ext4 baseline:
runtime: 1.63s +/- 0.24s
avg lat: 1.59ms +/- 0.24ms
iops: ~2000
XFS, vanilla kernel:
runtime: 2.45s +/- 0.18s
avg lat: 2.39ms +/- 0.18ms
log forces: ~400/s
iops: ~1000
XFS, patched kernel:
runtime: 1.49s +/- 0.26s
avg lat: 1.46ms +/- 0.25ms
log forces: ~30/s
iops: ~1500
Reported-by: Sage Weil <sage@redhat.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-11-03 10:14:59 +08:00
|
|
|
iip->ili_fsync_fields = 0;
|
2020-06-30 05:48:46 +08:00
|
|
|
spin_unlock(&iip->ili_lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-06-30 05:48:46 +08:00
|
|
|
/*
|
|
|
|
* Store the current LSN of the inode so that we can tell whether the
|
2020-09-02 01:55:29 +08:00
|
|
|
* item has moved in the AIL from xfs_buf_inode_iodone().
|
2020-06-30 05:48:46 +08:00
|
|
|
*/
|
2013-04-03 13:11:17 +08:00
|
|
|
xfs_trans_ail_copy_lsn(mp->m_ail, &iip->ili_flush_lsn,
|
|
|
|
&iip->ili_item.li_lsn);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2013-04-03 13:11:17 +08:00
|
|
|
/* generate the checksum. */
|
|
|
|
xfs_dinode_calc_crc(mp, dip);
|
2020-05-07 04:25:20 +08:00
|
|
|
return error;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2018-07-26 03:52:32 +08:00
|
|
|
|
2020-06-30 05:49:19 +08:00
|
|
|
/*
|
|
|
|
* Non-blocking flush of dirty inode metadata into the backing buffer.
|
|
|
|
*
|
|
|
|
* The caller must have a reference to the inode and hold the cluster buffer
|
|
|
|
* locked. The function will walk across all the inodes on the cluster buffer it
|
|
|
|
* can find and lock without blocking, and flush them to the cluster buffer.
|
|
|
|
*
|
2020-06-30 05:49:20 +08:00
|
|
|
* On successful flushing of at least one inode, the caller must write out the
|
|
|
|
* buffer and release it. If no inodes are flushed, -EAGAIN will be returned and
|
|
|
|
* the caller needs to release the buffer. On failure, the filesystem will be
|
|
|
|
* shut down, the buffer will have been unlocked and released, and EFSCORRUPTED
|
|
|
|
* will be returned.
|
2020-06-30 05:49:19 +08:00
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_iflush_cluster(
|
|
|
|
struct xfs_buf *bp)
|
|
|
|
{
|
2020-06-30 05:49:20 +08:00
|
|
|
struct xfs_mount *mp = bp->b_mount;
|
|
|
|
struct xfs_log_item *lip, *n;
|
|
|
|
struct xfs_inode *ip;
|
|
|
|
struct xfs_inode_log_item *iip;
|
2020-06-30 05:49:19 +08:00
|
|
|
int clcount = 0;
|
2020-06-30 05:49:20 +08:00
|
|
|
int error = 0;
|
2020-06-30 05:49:19 +08:00
|
|
|
|
2020-06-30 05:49:20 +08:00
|
|
|
/*
|
|
|
|
* We must use the safe variant here as on shutdown xfs_iflush_abort()
|
2022-03-30 09:21:59 +08:00
|
|
|
* will remove itself from the list.
|
2020-06-30 05:49:20 +08:00
|
|
|
*/
|
|
|
|
list_for_each_entry_safe(lip, n, &bp->b_li_list, li_bio_list) {
|
|
|
|
iip = (struct xfs_inode_log_item *)lip;
|
|
|
|
ip = iip->ili_inode;
|
2020-06-30 05:49:19 +08:00
|
|
|
|
|
|
|
/*
|
2020-06-30 05:49:20 +08:00
|
|
|
* Quick and dirty check to avoid locks if possible.
|
2020-06-30 05:49:19 +08:00
|
|
|
*/
|
2020-08-18 07:41:01 +08:00
|
|
|
if (__xfs_iflags_test(ip, XFS_IRECLAIM | XFS_IFLUSHING))
|
2020-06-30 05:49:20 +08:00
|
|
|
continue;
|
|
|
|
if (xfs_ipincount(ip))
|
2020-06-30 05:49:19 +08:00
|
|
|
continue;
|
|
|
|
|
|
|
|
/*
|
2020-06-30 05:49:20 +08:00
|
|
|
* The inode is still attached to the buffer, which means it is
|
|
|
|
* dirty but reclaim might try to grab it. Check carefully for
|
|
|
|
* that, and grab the ilock while still holding the i_flags_lock
|
|
|
|
* to guarantee reclaim will not be able to reclaim this inode
|
|
|
|
* once we drop the i_flags_lock.
|
2020-06-30 05:49:19 +08:00
|
|
|
*/
|
2020-06-30 05:49:20 +08:00
|
|
|
spin_lock(&ip->i_flags_lock);
|
|
|
|
ASSERT(!__xfs_iflags_test(ip, XFS_ISTALE));
|
2020-08-18 07:41:01 +08:00
|
|
|
if (__xfs_iflags_test(ip, XFS_IRECLAIM | XFS_IFLUSHING)) {
|
2020-06-30 05:49:20 +08:00
|
|
|
spin_unlock(&ip->i_flags_lock);
|
|
|
|
continue;
|
2020-06-30 05:49:19 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2020-06-30 05:49:20 +08:00
|
|
|
* ILOCK will pin the inode against reclaim and prevent
|
|
|
|
* concurrent transactions modifying the inode while we are
|
2020-08-18 07:41:01 +08:00
|
|
|
* flushing the inode. If we get the lock, set the flushing
|
|
|
|
* state before we drop the i_flags_lock.
|
2020-06-30 05:49:19 +08:00
|
|
|
*/
|
2020-06-30 05:49:20 +08:00
|
|
|
if (!xfs_ilock_nowait(ip, XFS_ILOCK_SHARED)) {
|
|
|
|
spin_unlock(&ip->i_flags_lock);
|
2020-06-30 05:49:19 +08:00
|
|
|
continue;
|
2020-06-30 05:49:20 +08:00
|
|
|
}
|
2020-08-18 07:41:01 +08:00
|
|
|
__xfs_iflags_set(ip, XFS_IFLUSHING);
|
2020-06-30 05:49:20 +08:00
|
|
|
spin_unlock(&ip->i_flags_lock);
|
2020-06-30 05:49:19 +08:00
|
|
|
|
|
|
|
/*
|
2020-06-30 05:49:20 +08:00
|
|
|
* Abort flushing this inode if we are shut down because the
|
|
|
|
* inode may not currently be in the AIL. This can occur when
|
|
|
|
* log I/O failure unpins the inode without inserting into the
|
|
|
|
* AIL, leaving a dirty/unpinned inode attached to the buffer
|
|
|
|
* that otherwise looks like it should be flushed.
|
2020-06-30 05:49:19 +08:00
|
|
|
*/
|
xfs: xfs_is_shutdown vs xlog_is_shutdown cage fight
I've been chasing a recent resurgence in generic/388 recovery
failure and/or corruption events. The events have largely been
uninitialised inode chunks being tripped over in log recovery
such as:
XFS (pmem1): User initiated shutdown received.
pmem1: writeback error on inode 12621949, offset 1019904, sector 12968096
XFS (pmem1): Log I/O Error (0x6) detected at xfs_fs_goingdown+0xa3/0xf0 (fs/xfs/xfs_fsops.c:500). Shutting down filesystem.
XFS (pmem1): Please unmount the filesystem and rectify the problem(s)
XFS (pmem1): Unmounting Filesystem
XFS (pmem1): Mounting V5 Filesystem
XFS (pmem1): Starting recovery (logdev: internal)
XFS (pmem1): bad inode magic/vsn daddr 8723584 #0 (magic=1818)
XFS (pmem1): Metadata corruption detected at xfs_inode_buf_verify+0x180/0x190, xfs_inode block 0x851c80 xfs_inode_buf_verify
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): First 128 bytes of corrupted metadata buffer:
00000000: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000010: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000020: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000030: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000040: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000050: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000060: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000070: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
XFS (pmem1): metadata I/O error in "xlog_recover_items_pass2+0x52/0xc0" at daddr 0x851c80 len 32 error 117
XFS (pmem1): log mount/recovery failed: error -117
XFS (pmem1): log mount failed
There have been isolated random other issues, too - xfs_repair fails
because it finds some corruption in symlink blocks, rmap
inconsistencies, etc - but they are nowhere near as common as the
uninitialised inode chunk failure.
The problem has clearly happened at runtime before recovery has run;
I can see the ICREATE log item in the log shortly before the
actively recovered range of the log. This means the ICREATE was
definitely created and written to the log, but for some reason the
tail of the log has been moved past the ordered buffer log item that
tracks INODE_ALLOC buffers and, supposedly, prevents the tail of the
log moving past the ICREATE log item before the inode chunk buffer
is written to disk.
Tracing the fsstress processes that are running when the filesystem
shut down immediately pin-pointed the problem:
user shutdown marks xfs_mount as shutdown
godown-213341 [008] 6398.022871: console: [ 6397.915392] XFS (pmem1): User initiated shutdown received.
.....
aild tries to push ordered inode cluster buffer
xfsaild/pmem1-213314 [001] 6398.022974: xfs_buf_trylock: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 16 pincount 0 lock 0 flags DONE|INODES|PAGES caller xfs_inode_item_push+0x8e
xfsaild/pmem1-213314 [001] 6398.022976: xfs_ilock_nowait: dev 259:1 ino 0x851c80 flags ILOCK_SHARED caller xfs_iflush_cluster+0xae
xfs_iflush_cluster() checks xfs_is_shutdown(), returns true,
calls xfs_iflush_abort() to kill writeback of the inode.
Inode is removed from AIL, drops cluster buffer reference.
xfsaild/pmem1-213314 [001] 6398.022977: xfs_ail_delete: dev 259:1 lip 0xffff88880247ed80 old lsn 7/20344 new lsn 7/21000 type XFS_LI_INODE flags IN_AIL
xfsaild/pmem1-213314 [001] 6398.022978: xfs_buf_rele: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 17 pincount 0 lock 0 flags DONE|INODES|PAGES caller xfs_iflush_abort+0xd7
.....
All inodes on cluster buffer are aborted, then the cluster buffer
itself is aborted and removed from the AIL *without writeback*:
xfsaild/pmem1-213314 [001] 6398.023011: xfs_buf_error_relse: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 2 pincount 0 lock 0 flags ASYNC|DONE|STALE|INODES|PAGES caller xfs_buf_ioend_fail+0x33
xfsaild/pmem1-213314 [001] 6398.023012: xfs_ail_delete: dev 259:1 lip 0xffff8888053efde8 old lsn 7/20344 new lsn 7/20344 type XFS_LI_BUF flags IN_AIL
The inode buffer was at 7/20344 when it was removed from the AIL.
xfsaild/pmem1-213314 [001] 6398.023012: xfs_buf_item_relse: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 2 pincount 0 lock 0 flags ASYNC|DONE|STALE|INODES|PAGES caller xfs_buf_item_done+0x31
xfsaild/pmem1-213314 [001] 6398.023012: xfs_buf_rele: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 2 pincount 0 lock 0 flags ASYNC|DONE|STALE|INODES|PAGES caller xfs_buf_item_relse+0x39
.....
Userspace is still running, doing stuff. an fsstress process runs
syncfs() or sync() and we end up in sync_fs_one_sb() which issues
a log force. This pushes on the CIL:
fsstress-213322 [001] 6398.024430: xfs_fs_sync_fs: dev 259:1 m_features 0x20000000019ff6e9 opstate (clean|shutdown|inodegc|blockgc) s_flags 0x70810000 caller sync_fs_one_sb+0x26
fsstress-213322 [001] 6398.024430: xfs_log_force: dev 259:1 lsn 0x0 caller xfs_fs_sync_fs+0x82
fsstress-213322 [001] 6398.024430: xfs_log_force: dev 259:1 lsn 0x5f caller xfs_log_force+0x7c
<...>-194402 [001] 6398.024467: kmem_alloc: size 176 flags 0x14 caller xlog_cil_push_work+0x9f
And the CIL fills up iclogs with pending changes. This picks up
the current tail from the AIL:
<...>-194402 [001] 6398.024497: xlog_iclog_get_space: dev 259:1 state XLOG_STATE_ACTIVE refcnt 1 offset 0 lsn 0x0 flags caller xlog_write+0x149
<...>-194402 [001] 6398.024498: xlog_iclog_switch: dev 259:1 state XLOG_STATE_ACTIVE refcnt 1 offset 0 lsn 0x700005408 flags caller xlog_state_get_iclog_space+0x37e
<...>-194402 [001] 6398.024521: xlog_iclog_release: dev 259:1 state XLOG_STATE_WANT_SYNC refcnt 1 offset 32256 lsn 0x700005408 flags caller xlog_write+0x5f9
<...>-194402 [001] 6398.024522: xfs_log_assign_tail_lsn: dev 259:1 new tail lsn 7/21000, old lsn 7/20344, last sync 7/21448
And it moves the tail of the log to 7/21000 from 7/20344. This
*moves the tail of the log beyond the ICREATE transaction* that was
at 7/20344 and pinned by the inode cluster buffer that was cancelled
above.
....
godown-213341 [008] 6398.027005: xfs_force_shutdown: dev 259:1 tag logerror flags log_io|force_umount file fs/xfs/xfs_fsops.c line_num 500
godown-213341 [008] 6398.027022: console: [ 6397.915406] pmem1: writeback error on inode 12621949, offset 1019904, sector 12968096
godown-213341 [008] 6398.030551: console: [ 6397.919546] XFS (pmem1): Log I/O Error (0x6) detected at xfs_fs_goingdown+0xa3/0xf0 (fs/
And finally the log itself is now shutdown, stopping all further
writes to the log. But this is too late to prevent the corruption
that moving the tail of the log forwards after we start cancelling
writeback causes.
The fundamental problem here is that we are using the wrong shutdown
checks for log items. We've long conflated mount shutdown with log
shutdown state, and I started separating that recently with the
atomic shutdown state changes in commit b36d4651e165 ("xfs: make
forced shutdown processing atomic"). The changes in that commit
series are directly responsible for being able to diagnose this
issue because it clearly separated mount shutdown from log shutdown.
Essentially, once we start cancelling writeback of log items and
removing them from the AIL because the filesystem is shut down, we
*cannot* update the journal because we may have cancelled the items
that pin the tail of the log. That moves the tail of the log
forwards without having written the metadata back, hence we have
corrupt in memory state and writing to the journal propagates that
to the on-disk state.
What commit b36d4651e165 makes clear is that log item state needs to
change relative to log shutdown, not mount shutdown. IOWs, anything
that aborts metadata writeback needs to check log shutdown state
because log items directly affect log consistency. Having them check
mount shutdown state introduces the above race condition where we
cancel metadata writeback before the log shuts down.
To fix this, this patch works through all log items and converts
shutdown checks to use xlog_is_shutdown() rather than
xfs_is_shutdown(), so that we don't start aborting metadata
writeback before we shut off journal writes.
AFAICT, this race condition is a zero day IO error handling bug in
XFS that dates back to the introduction of XLOG_IO_ERROR,
XLOG_STATE_IOERROR and XFS_FORCED_SHUTDOWN back in January 1997.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
2022-03-18 00:09:13 +08:00
|
|
|
if (xlog_is_shutdown(mp->m_log)) {
|
2020-06-30 05:49:20 +08:00
|
|
|
xfs_iunpin_wait(ip);
|
|
|
|
xfs_iflush_abort(ip);
|
|
|
|
xfs_iunlock(ip, XFS_ILOCK_SHARED);
|
|
|
|
error = -EIO;
|
2020-06-30 05:49:19 +08:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2020-06-30 05:49:20 +08:00
|
|
|
/* don't block waiting on a log force to unpin dirty inodes */
|
|
|
|
if (xfs_ipincount(ip)) {
|
2020-08-18 07:41:01 +08:00
|
|
|
xfs_iflags_clear(ip, XFS_IFLUSHING);
|
2020-06-30 05:49:20 +08:00
|
|
|
xfs_iunlock(ip, XFS_ILOCK_SHARED);
|
|
|
|
continue;
|
2020-06-30 05:49:19 +08:00
|
|
|
}
|
|
|
|
|
2020-06-30 05:49:20 +08:00
|
|
|
if (!xfs_inode_clean(ip))
|
|
|
|
error = xfs_iflush(ip, bp);
|
|
|
|
else
|
2020-08-18 07:41:01 +08:00
|
|
|
xfs_iflags_clear(ip, XFS_IFLUSHING);
|
2020-06-30 05:49:20 +08:00
|
|
|
xfs_iunlock(ip, XFS_ILOCK_SHARED);
|
|
|
|
if (error)
|
|
|
|
break;
|
|
|
|
clcount++;
|
2020-06-30 05:49:19 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (error) {
|
xfs: xfs_is_shutdown vs xlog_is_shutdown cage fight
I've been chasing a recent resurgence in generic/388 recovery
failure and/or corruption events. The events have largely been
uninitialised inode chunks being tripped over in log recovery
such as:
XFS (pmem1): User initiated shutdown received.
pmem1: writeback error on inode 12621949, offset 1019904, sector 12968096
XFS (pmem1): Log I/O Error (0x6) detected at xfs_fs_goingdown+0xa3/0xf0 (fs/xfs/xfs_fsops.c:500). Shutting down filesystem.
XFS (pmem1): Please unmount the filesystem and rectify the problem(s)
XFS (pmem1): Unmounting Filesystem
XFS (pmem1): Mounting V5 Filesystem
XFS (pmem1): Starting recovery (logdev: internal)
XFS (pmem1): bad inode magic/vsn daddr 8723584 #0 (magic=1818)
XFS (pmem1): Metadata corruption detected at xfs_inode_buf_verify+0x180/0x190, xfs_inode block 0x851c80 xfs_inode_buf_verify
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): First 128 bytes of corrupted metadata buffer:
00000000: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000010: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000020: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000030: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000040: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000050: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000060: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
00000070: 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 ................
XFS (pmem1): metadata I/O error in "xlog_recover_items_pass2+0x52/0xc0" at daddr 0x851c80 len 32 error 117
XFS (pmem1): log mount/recovery failed: error -117
XFS (pmem1): log mount failed
There have been isolated random other issues, too - xfs_repair fails
because it finds some corruption in symlink blocks, rmap
inconsistencies, etc - but they are nowhere near as common as the
uninitialised inode chunk failure.
The problem has clearly happened at runtime before recovery has run;
I can see the ICREATE log item in the log shortly before the
actively recovered range of the log. This means the ICREATE was
definitely created and written to the log, but for some reason the
tail of the log has been moved past the ordered buffer log item that
tracks INODE_ALLOC buffers and, supposedly, prevents the tail of the
log moving past the ICREATE log item before the inode chunk buffer
is written to disk.
Tracing the fsstress processes that are running when the filesystem
shut down immediately pin-pointed the problem:
user shutdown marks xfs_mount as shutdown
godown-213341 [008] 6398.022871: console: [ 6397.915392] XFS (pmem1): User initiated shutdown received.
.....
aild tries to push ordered inode cluster buffer
xfsaild/pmem1-213314 [001] 6398.022974: xfs_buf_trylock: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 16 pincount 0 lock 0 flags DONE|INODES|PAGES caller xfs_inode_item_push+0x8e
xfsaild/pmem1-213314 [001] 6398.022976: xfs_ilock_nowait: dev 259:1 ino 0x851c80 flags ILOCK_SHARED caller xfs_iflush_cluster+0xae
xfs_iflush_cluster() checks xfs_is_shutdown(), returns true,
calls xfs_iflush_abort() to kill writeback of the inode.
Inode is removed from AIL, drops cluster buffer reference.
xfsaild/pmem1-213314 [001] 6398.022977: xfs_ail_delete: dev 259:1 lip 0xffff88880247ed80 old lsn 7/20344 new lsn 7/21000 type XFS_LI_INODE flags IN_AIL
xfsaild/pmem1-213314 [001] 6398.022978: xfs_buf_rele: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 17 pincount 0 lock 0 flags DONE|INODES|PAGES caller xfs_iflush_abort+0xd7
.....
All inodes on cluster buffer are aborted, then the cluster buffer
itself is aborted and removed from the AIL *without writeback*:
xfsaild/pmem1-213314 [001] 6398.023011: xfs_buf_error_relse: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 2 pincount 0 lock 0 flags ASYNC|DONE|STALE|INODES|PAGES caller xfs_buf_ioend_fail+0x33
xfsaild/pmem1-213314 [001] 6398.023012: xfs_ail_delete: dev 259:1 lip 0xffff8888053efde8 old lsn 7/20344 new lsn 7/20344 type XFS_LI_BUF flags IN_AIL
The inode buffer was at 7/20344 when it was removed from the AIL.
xfsaild/pmem1-213314 [001] 6398.023012: xfs_buf_item_relse: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 2 pincount 0 lock 0 flags ASYNC|DONE|STALE|INODES|PAGES caller xfs_buf_item_done+0x31
xfsaild/pmem1-213314 [001] 6398.023012: xfs_buf_rele: dev 259:1 daddr 0x851c80 bbcount 0x20 hold 2 pincount 0 lock 0 flags ASYNC|DONE|STALE|INODES|PAGES caller xfs_buf_item_relse+0x39
.....
Userspace is still running, doing stuff. an fsstress process runs
syncfs() or sync() and we end up in sync_fs_one_sb() which issues
a log force. This pushes on the CIL:
fsstress-213322 [001] 6398.024430: xfs_fs_sync_fs: dev 259:1 m_features 0x20000000019ff6e9 opstate (clean|shutdown|inodegc|blockgc) s_flags 0x70810000 caller sync_fs_one_sb+0x26
fsstress-213322 [001] 6398.024430: xfs_log_force: dev 259:1 lsn 0x0 caller xfs_fs_sync_fs+0x82
fsstress-213322 [001] 6398.024430: xfs_log_force: dev 259:1 lsn 0x5f caller xfs_log_force+0x7c
<...>-194402 [001] 6398.024467: kmem_alloc: size 176 flags 0x14 caller xlog_cil_push_work+0x9f
And the CIL fills up iclogs with pending changes. This picks up
the current tail from the AIL:
<...>-194402 [001] 6398.024497: xlog_iclog_get_space: dev 259:1 state XLOG_STATE_ACTIVE refcnt 1 offset 0 lsn 0x0 flags caller xlog_write+0x149
<...>-194402 [001] 6398.024498: xlog_iclog_switch: dev 259:1 state XLOG_STATE_ACTIVE refcnt 1 offset 0 lsn 0x700005408 flags caller xlog_state_get_iclog_space+0x37e
<...>-194402 [001] 6398.024521: xlog_iclog_release: dev 259:1 state XLOG_STATE_WANT_SYNC refcnt 1 offset 32256 lsn 0x700005408 flags caller xlog_write+0x5f9
<...>-194402 [001] 6398.024522: xfs_log_assign_tail_lsn: dev 259:1 new tail lsn 7/21000, old lsn 7/20344, last sync 7/21448
And it moves the tail of the log to 7/21000 from 7/20344. This
*moves the tail of the log beyond the ICREATE transaction* that was
at 7/20344 and pinned by the inode cluster buffer that was cancelled
above.
....
godown-213341 [008] 6398.027005: xfs_force_shutdown: dev 259:1 tag logerror flags log_io|force_umount file fs/xfs/xfs_fsops.c line_num 500
godown-213341 [008] 6398.027022: console: [ 6397.915406] pmem1: writeback error on inode 12621949, offset 1019904, sector 12968096
godown-213341 [008] 6398.030551: console: [ 6397.919546] XFS (pmem1): Log I/O Error (0x6) detected at xfs_fs_goingdown+0xa3/0xf0 (fs/
And finally the log itself is now shutdown, stopping all further
writes to the log. But this is too late to prevent the corruption
that moving the tail of the log forwards after we start cancelling
writeback causes.
The fundamental problem here is that we are using the wrong shutdown
checks for log items. We've long conflated mount shutdown with log
shutdown state, and I started separating that recently with the
atomic shutdown state changes in commit b36d4651e165 ("xfs: make
forced shutdown processing atomic"). The changes in that commit
series are directly responsible for being able to diagnose this
issue because it clearly separated mount shutdown from log shutdown.
Essentially, once we start cancelling writeback of log items and
removing them from the AIL because the filesystem is shut down, we
*cannot* update the journal because we may have cancelled the items
that pin the tail of the log. That moves the tail of the log
forwards without having written the metadata back, hence we have
corrupt in memory state and writing to the journal propagates that
to the on-disk state.
What commit b36d4651e165 makes clear is that log item state needs to
change relative to log shutdown, not mount shutdown. IOWs, anything
that aborts metadata writeback needs to check log shutdown state
because log items directly affect log consistency. Having them check
mount shutdown state introduces the above race condition where we
cancel metadata writeback before the log shuts down.
To fix this, this patch works through all log items and converts
shutdown checks to use xlog_is_shutdown() rather than
xfs_is_shutdown(), so that we don't start aborting metadata
writeback before we shut off journal writes.
AFAICT, this race condition is a zero day IO error handling bug in
XFS that dates back to the introduction of XLOG_IO_ERROR,
XLOG_STATE_IOERROR and XFS_FORCED_SHUTDOWN back in January 1997.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
2022-03-18 00:09:13 +08:00
|
|
|
/*
|
|
|
|
* Shutdown first so we kill the log before we release this
|
|
|
|
* buffer. If it is an INODE_ALLOC buffer and pins the tail
|
|
|
|
* of the log, failing it before the _log_ is shut down can
|
|
|
|
* result in the log tail being moved forward in the journal
|
|
|
|
* on disk because log writes can still be taking place. Hence
|
|
|
|
* unpinning the tail will allow the ICREATE intent to be
|
|
|
|
* removed from the log an recovery will fail with uninitialised
|
|
|
|
* inode cluster buffers.
|
|
|
|
*/
|
|
|
|
xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
|
2020-06-30 05:49:19 +08:00
|
|
|
bp->b_flags |= XBF_ASYNC;
|
|
|
|
xfs_buf_ioend_fail(bp);
|
2020-06-30 05:49:20 +08:00
|
|
|
return error;
|
2020-06-30 05:49:19 +08:00
|
|
|
}
|
2020-06-30 05:49:20 +08:00
|
|
|
|
|
|
|
if (!clcount)
|
|
|
|
return -EAGAIN;
|
|
|
|
|
|
|
|
XFS_STATS_INC(mp, xs_icluster_flushcnt);
|
|
|
|
XFS_STATS_ADD(mp, xs_icluster_flushinode, clcount);
|
|
|
|
return 0;
|
|
|
|
|
2020-06-30 05:49:19 +08:00
|
|
|
}
|
|
|
|
|
2018-07-26 03:52:32 +08:00
|
|
|
/* Release an inode. */
|
|
|
|
void
|
|
|
|
xfs_irele(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
trace_xfs_irele(ip, _RET_IP_);
|
|
|
|
iput(VFS_I(ip));
|
|
|
|
}
|
2020-04-04 02:45:37 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Ensure all commited transactions touching the inode are written to the log.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_log_force_inode(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
2021-06-18 23:21:52 +08:00
|
|
|
xfs_csn_t seq = 0;
|
2020-04-04 02:45:37 +08:00
|
|
|
|
|
|
|
xfs_ilock(ip, XFS_ILOCK_SHARED);
|
|
|
|
if (xfs_ipincount(ip))
|
2021-06-18 23:21:52 +08:00
|
|
|
seq = ip->i_itemp->ili_commit_seq;
|
2020-04-04 02:45:37 +08:00
|
|
|
xfs_iunlock(ip, XFS_ILOCK_SHARED);
|
|
|
|
|
2021-06-18 23:21:52 +08:00
|
|
|
if (!seq)
|
2020-04-04 02:45:37 +08:00
|
|
|
return 0;
|
2021-06-18 23:21:52 +08:00
|
|
|
return xfs_log_force_seq(ip->i_mount, seq, XFS_LOG_SYNC, NULL);
|
2020-04-04 02:45:37 +08:00
|
|
|
}
|
2020-06-30 05:47:20 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Grab the exclusive iolock for a data copy from src to dest, making sure to
|
|
|
|
* abide vfs locking order (lowest pointer value goes first) and breaking the
|
|
|
|
* layout leases before proceeding. The loop is needed because we cannot call
|
|
|
|
* the blocking break_layout() with the iolocks held, and therefore have to
|
|
|
|
* back out both locks.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
xfs_iolock_two_inodes_and_break_layout(
|
|
|
|
struct inode *src,
|
|
|
|
struct inode *dest)
|
|
|
|
{
|
|
|
|
int error;
|
|
|
|
|
|
|
|
if (src > dest)
|
|
|
|
swap(src, dest);
|
|
|
|
|
|
|
|
retry:
|
|
|
|
/* Wait to break both inodes' layouts before we start locking. */
|
|
|
|
error = break_layout(src, true);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
if (src != dest) {
|
|
|
|
error = break_layout(dest, true);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Lock one inode and make sure nobody got in and leased it. */
|
|
|
|
inode_lock(src);
|
|
|
|
error = break_layout(src, false);
|
|
|
|
if (error) {
|
|
|
|
inode_unlock(src);
|
|
|
|
if (error == -EWOULDBLOCK)
|
|
|
|
goto retry;
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (src == dest)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* Lock the other inode and make sure nobody got in and leased it. */
|
|
|
|
inode_lock_nested(dest, I_MUTEX_NONDIR2);
|
|
|
|
error = break_layout(dest, false);
|
|
|
|
if (error) {
|
|
|
|
inode_unlock(src);
|
|
|
|
inode_unlock(dest);
|
|
|
|
if (error == -EWOULDBLOCK)
|
|
|
|
goto retry;
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2022-06-03 13:37:38 +08:00
|
|
|
static int
|
|
|
|
xfs_mmaplock_two_inodes_and_break_dax_layout(
|
|
|
|
struct xfs_inode *ip1,
|
|
|
|
struct xfs_inode *ip2)
|
|
|
|
{
|
|
|
|
int error;
|
|
|
|
bool retry;
|
|
|
|
struct page *page;
|
|
|
|
|
|
|
|
if (ip1->i_ino > ip2->i_ino)
|
|
|
|
swap(ip1, ip2);
|
|
|
|
|
|
|
|
again:
|
|
|
|
retry = false;
|
|
|
|
/* Lock the first inode */
|
|
|
|
xfs_ilock(ip1, XFS_MMAPLOCK_EXCL);
|
|
|
|
error = xfs_break_dax_layouts(VFS_I(ip1), &retry);
|
|
|
|
if (error || retry) {
|
|
|
|
xfs_iunlock(ip1, XFS_MMAPLOCK_EXCL);
|
|
|
|
if (error == 0 && retry)
|
|
|
|
goto again;
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ip1 == ip2)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* Nested lock the second inode */
|
|
|
|
xfs_ilock(ip2, xfs_lock_inumorder(XFS_MMAPLOCK_EXCL, 1));
|
|
|
|
/*
|
|
|
|
* We cannot use xfs_break_dax_layouts() directly here because it may
|
|
|
|
* need to unlock & lock the XFS_MMAPLOCK_EXCL which is not suitable
|
|
|
|
* for this nested lock case.
|
|
|
|
*/
|
|
|
|
page = dax_layout_busy_page(VFS_I(ip2)->i_mapping);
|
|
|
|
if (page && page_ref_count(page) != 1) {
|
|
|
|
xfs_iunlock(ip2, XFS_MMAPLOCK_EXCL);
|
|
|
|
xfs_iunlock(ip1, XFS_MMAPLOCK_EXCL);
|
|
|
|
goto again;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-06-30 05:47:20 +08:00
|
|
|
/*
|
|
|
|
* Lock two inodes so that userspace cannot initiate I/O via file syscalls or
|
|
|
|
* mmap activity.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_ilock2_io_mmap(
|
|
|
|
struct xfs_inode *ip1,
|
|
|
|
struct xfs_inode *ip2)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = xfs_iolock_two_inodes_and_break_layout(VFS_I(ip1), VFS_I(ip2));
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2022-06-03 13:37:38 +08:00
|
|
|
|
|
|
|
if (IS_DAX(VFS_I(ip1)) && IS_DAX(VFS_I(ip2))) {
|
|
|
|
ret = xfs_mmaplock_two_inodes_and_break_dax_layout(ip1, ip2);
|
|
|
|
if (ret) {
|
|
|
|
inode_unlock(VFS_I(ip2));
|
|
|
|
if (ip1 != ip2)
|
|
|
|
inode_unlock(VFS_I(ip1));
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
} else
|
|
|
|
filemap_invalidate_lock_two(VFS_I(ip1)->i_mapping,
|
|
|
|
VFS_I(ip2)->i_mapping);
|
|
|
|
|
2020-06-30 05:47:20 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Unlock both inodes to allow IO and mmap activity. */
|
|
|
|
void
|
|
|
|
xfs_iunlock2_io_mmap(
|
|
|
|
struct xfs_inode *ip1,
|
|
|
|
struct xfs_inode *ip2)
|
|
|
|
{
|
2022-06-03 13:37:38 +08:00
|
|
|
if (IS_DAX(VFS_I(ip1)) && IS_DAX(VFS_I(ip2))) {
|
|
|
|
xfs_iunlock(ip2, XFS_MMAPLOCK_EXCL);
|
|
|
|
if (ip1 != ip2)
|
|
|
|
xfs_iunlock(ip1, XFS_MMAPLOCK_EXCL);
|
|
|
|
} else
|
|
|
|
filemap_invalidate_unlock_two(VFS_I(ip1)->i_mapping,
|
|
|
|
VFS_I(ip2)->i_mapping);
|
|
|
|
|
2020-06-30 05:47:20 +08:00
|
|
|
inode_unlock(VFS_I(ip2));
|
2021-05-24 19:17:49 +08:00
|
|
|
if (ip1 != ip2)
|
2020-06-30 05:47:20 +08:00
|
|
|
inode_unlock(VFS_I(ip1));
|
|
|
|
}
|
2023-09-11 23:39:07 +08:00
|
|
|
|
2023-10-18 04:12:08 +08:00
|
|
|
/* Drop the MMAPLOCK and the IOLOCK after a remap completes. */
|
|
|
|
void
|
|
|
|
xfs_iunlock2_remapping(
|
|
|
|
struct xfs_inode *ip1,
|
|
|
|
struct xfs_inode *ip2)
|
|
|
|
{
|
|
|
|
xfs_iflags_clear(ip1, XFS_IREMAPPING);
|
|
|
|
|
|
|
|
if (ip1 != ip2)
|
|
|
|
xfs_iunlock(ip1, XFS_MMAPLOCK_SHARED);
|
|
|
|
xfs_iunlock(ip2, XFS_MMAPLOCK_EXCL);
|
|
|
|
|
|
|
|
if (ip1 != ip2)
|
|
|
|
inode_unlock_shared(VFS_I(ip1));
|
|
|
|
inode_unlock(VFS_I(ip2));
|
|
|
|
}
|
|
|
|
|
2023-09-11 23:39:07 +08:00
|
|
|
/*
|
|
|
|
* Reload the incore inode list for this inode. Caller should ensure that
|
|
|
|
* the link count cannot change, either by taking ILOCK_SHARED or otherwise
|
|
|
|
* preventing other threads from executing.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_inode_reload_unlinked_bucket(
|
|
|
|
struct xfs_trans *tp,
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
struct xfs_mount *mp = tp->t_mountp;
|
|
|
|
struct xfs_buf *agibp;
|
|
|
|
struct xfs_agi *agi;
|
|
|
|
struct xfs_perag *pag;
|
|
|
|
xfs_agnumber_t agno = XFS_INO_TO_AGNO(mp, ip->i_ino);
|
|
|
|
xfs_agino_t agino = XFS_INO_TO_AGINO(mp, ip->i_ino);
|
|
|
|
xfs_agino_t prev_agino, next_agino;
|
|
|
|
unsigned int bucket;
|
|
|
|
bool foundit = false;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
/* Grab the first inode in the list */
|
|
|
|
pag = xfs_perag_get(mp, agno);
|
|
|
|
error = xfs_ialloc_read_agi(pag, tp, &agibp);
|
|
|
|
xfs_perag_put(pag);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2023-09-24 23:35:53 +08:00
|
|
|
/*
|
|
|
|
* We've taken ILOCK_SHARED and the AGI buffer lock to stabilize the
|
|
|
|
* incore unlinked list pointers for this inode. Check once more to
|
|
|
|
* see if we raced with anyone else to reload the unlinked list.
|
|
|
|
*/
|
|
|
|
if (!xfs_inode_unlinked_incomplete(ip)) {
|
|
|
|
foundit = true;
|
|
|
|
goto out_agibp;
|
|
|
|
}
|
|
|
|
|
2023-09-11 23:39:07 +08:00
|
|
|
bucket = agino % XFS_AGI_UNLINKED_BUCKETS;
|
|
|
|
agi = agibp->b_addr;
|
|
|
|
|
|
|
|
trace_xfs_inode_reload_unlinked_bucket(ip);
|
|
|
|
|
|
|
|
xfs_info_ratelimited(mp,
|
|
|
|
"Found unrecovered unlinked inode 0x%x in AG 0x%x. Initiating list recovery.",
|
|
|
|
agino, agno);
|
|
|
|
|
|
|
|
prev_agino = NULLAGINO;
|
|
|
|
next_agino = be32_to_cpu(agi->agi_unlinked[bucket]);
|
|
|
|
while (next_agino != NULLAGINO) {
|
|
|
|
struct xfs_inode *next_ip = NULL;
|
|
|
|
|
2023-09-24 23:35:53 +08:00
|
|
|
/* Found this caller's inode, set its backlink. */
|
2023-09-11 23:39:07 +08:00
|
|
|
if (next_agino == agino) {
|
|
|
|
next_ip = ip;
|
|
|
|
next_ip->i_prev_unlinked = prev_agino;
|
|
|
|
foundit = true;
|
2023-09-24 23:35:53 +08:00
|
|
|
goto next_inode;
|
2023-09-11 23:39:07 +08:00
|
|
|
}
|
|
|
|
|
2023-09-24 23:35:53 +08:00
|
|
|
/* Try in-memory lookup first. */
|
|
|
|
next_ip = xfs_iunlink_lookup(pag, next_agino);
|
|
|
|
if (next_ip)
|
|
|
|
goto next_inode;
|
|
|
|
|
|
|
|
/* Inode not in memory, try reloading it. */
|
|
|
|
error = xfs_iunlink_reload_next(tp, agibp, prev_agino,
|
|
|
|
next_agino);
|
|
|
|
if (error)
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* Grab the reloaded inode. */
|
|
|
|
next_ip = xfs_iunlink_lookup(pag, next_agino);
|
2023-09-11 23:39:07 +08:00
|
|
|
if (!next_ip) {
|
|
|
|
/* No incore inode at all? We reloaded it... */
|
|
|
|
ASSERT(next_ip != NULL);
|
|
|
|
error = -EFSCORRUPTED;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2023-09-24 23:35:53 +08:00
|
|
|
next_inode:
|
2023-09-11 23:39:07 +08:00
|
|
|
prev_agino = next_agino;
|
|
|
|
next_agino = next_ip->i_next_unlinked;
|
|
|
|
}
|
|
|
|
|
2023-09-24 23:35:53 +08:00
|
|
|
out_agibp:
|
2023-09-11 23:39:07 +08:00
|
|
|
xfs_trans_brelse(tp, agibp);
|
|
|
|
/* Should have found this inode somewhere in the iunlinked bucket. */
|
|
|
|
if (!error && !foundit)
|
|
|
|
error = -EFSCORRUPTED;
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Decide if this inode is missing its unlinked list and reload it. */
|
|
|
|
int
|
|
|
|
xfs_inode_reload_unlinked(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
struct xfs_trans *tp;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
error = xfs_trans_alloc_empty(ip->i_mount, &tp);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
xfs_ilock(ip, XFS_ILOCK_SHARED);
|
|
|
|
if (xfs_inode_unlinked_incomplete(ip))
|
|
|
|
error = xfs_inode_reload_unlinked_bucket(tp, ip);
|
|
|
|
xfs_iunlock(ip, XFS_ILOCK_SHARED);
|
|
|
|
xfs_trans_cancel(tp);
|
|
|
|
|
|
|
|
return error;
|
|
|
|
}
|
2023-12-16 02:03:35 +08:00
|
|
|
|
|
|
|
/* Has this inode fork been zapped by repair? */
|
|
|
|
bool
|
|
|
|
xfs_ifork_zapped(
|
|
|
|
const struct xfs_inode *ip,
|
|
|
|
int whichfork)
|
|
|
|
{
|
|
|
|
unsigned int datamask = 0;
|
|
|
|
|
|
|
|
switch (whichfork) {
|
|
|
|
case XFS_DATA_FORK:
|
|
|
|
switch (ip->i_vnode.i_mode & S_IFMT) {
|
|
|
|
case S_IFDIR:
|
|
|
|
datamask = XFS_SICK_INO_DIR_ZAPPED;
|
|
|
|
break;
|
|
|
|
case S_IFLNK:
|
|
|
|
datamask = XFS_SICK_INO_SYMLINK_ZAPPED;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return ip->i_sick & (XFS_SICK_INO_BMBTD_ZAPPED | datamask);
|
|
|
|
case XFS_ATTR_FORK:
|
|
|
|
return ip->i_sick & XFS_SICK_INO_BMBTA_ZAPPED;
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|