2019-05-19 20:08:55 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2010-02-03 03:25:44 +08:00
|
|
|
#undef DEBUG
|
|
|
|
|
|
|
|
/*
|
|
|
|
* ARM performance counter support.
|
|
|
|
*
|
|
|
|
* Copyright (C) 2009 picoChip Designs, Ltd., Jamie Iles
|
2010-11-14 03:04:32 +08:00
|
|
|
* Copyright (C) 2010 ARM Ltd., Will Deacon <will.deacon@arm.com>
|
2010-01-27 01:51:05 +08:00
|
|
|
*
|
2010-02-03 03:25:44 +08:00
|
|
|
* This code is based on the sparc64 perf event code, which is in turn based
|
2014-09-30 00:15:32 +08:00
|
|
|
* on the x86 code.
|
2010-02-03 03:25:44 +08:00
|
|
|
*/
|
|
|
|
#define pr_fmt(fmt) "hw perfevents: " fmt
|
|
|
|
|
2015-05-27 00:23:39 +08:00
|
|
|
#include <linux/bitmap.h>
|
2015-05-14 00:12:25 +08:00
|
|
|
#include <linux/cpumask.h>
|
2016-02-24 02:22:39 +08:00
|
|
|
#include <linux/cpu_pm.h>
|
2015-05-27 00:23:39 +08:00
|
|
|
#include <linux/export.h>
|
2010-02-03 03:25:44 +08:00
|
|
|
#include <linux/kernel.h>
|
2015-07-06 19:23:53 +08:00
|
|
|
#include <linux/perf/arm_pmu.h>
|
2015-05-27 00:23:39 +08:00
|
|
|
#include <linux/slab.h>
|
2017-02-01 23:36:40 +08:00
|
|
|
#include <linux/sched/clock.h>
|
2015-05-27 00:23:39 +08:00
|
|
|
#include <linux/spinlock.h>
|
2014-02-08 05:01:19 +08:00
|
|
|
#include <linux/irq.h>
|
|
|
|
#include <linux/irqdesc.h>
|
2010-02-03 03:25:44 +08:00
|
|
|
|
|
|
|
#include <asm/irq_regs.h>
|
|
|
|
|
2020-09-24 19:07:05 +08:00
|
|
|
static int armpmu_count_irq_users(const int irq);
|
|
|
|
|
|
|
|
struct pmu_irq_ops {
|
|
|
|
void (*enable_pmuirq)(unsigned int irq);
|
|
|
|
void (*disable_pmuirq)(unsigned int irq);
|
|
|
|
void (*free_pmuirq)(unsigned int irq, int cpu, void __percpu *devid);
|
|
|
|
};
|
|
|
|
|
|
|
|
static void armpmu_free_pmuirq(unsigned int irq, int cpu, void __percpu *devid)
|
|
|
|
{
|
|
|
|
free_irq(irq, per_cpu_ptr(devid, cpu));
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct pmu_irq_ops pmuirq_ops = {
|
|
|
|
.enable_pmuirq = enable_irq,
|
|
|
|
.disable_pmuirq = disable_irq_nosync,
|
|
|
|
.free_pmuirq = armpmu_free_pmuirq
|
|
|
|
};
|
|
|
|
|
2020-09-24 19:07:06 +08:00
|
|
|
static void armpmu_free_pmunmi(unsigned int irq, int cpu, void __percpu *devid)
|
|
|
|
{
|
|
|
|
free_nmi(irq, per_cpu_ptr(devid, cpu));
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct pmu_irq_ops pmunmi_ops = {
|
|
|
|
.enable_pmuirq = enable_nmi,
|
|
|
|
.disable_pmuirq = disable_nmi_nosync,
|
|
|
|
.free_pmuirq = armpmu_free_pmunmi
|
|
|
|
};
|
|
|
|
|
2020-09-24 19:07:05 +08:00
|
|
|
static void armpmu_enable_percpu_pmuirq(unsigned int irq)
|
|
|
|
{
|
|
|
|
enable_percpu_irq(irq, IRQ_TYPE_NONE);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void armpmu_free_percpu_pmuirq(unsigned int irq, int cpu,
|
|
|
|
void __percpu *devid)
|
|
|
|
{
|
|
|
|
if (armpmu_count_irq_users(irq) == 1)
|
|
|
|
free_percpu_irq(irq, devid);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct pmu_irq_ops percpu_pmuirq_ops = {
|
|
|
|
.enable_pmuirq = armpmu_enable_percpu_pmuirq,
|
|
|
|
.disable_pmuirq = disable_percpu_irq,
|
|
|
|
.free_pmuirq = armpmu_free_percpu_pmuirq
|
|
|
|
};
|
|
|
|
|
2020-09-24 19:07:06 +08:00
|
|
|
static void armpmu_enable_percpu_pmunmi(unsigned int irq)
|
|
|
|
{
|
|
|
|
if (!prepare_percpu_nmi(irq))
|
|
|
|
enable_percpu_nmi(irq, IRQ_TYPE_NONE);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void armpmu_disable_percpu_pmunmi(unsigned int irq)
|
|
|
|
{
|
|
|
|
disable_percpu_nmi(irq);
|
|
|
|
teardown_percpu_nmi(irq);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void armpmu_free_percpu_pmunmi(unsigned int irq, int cpu,
|
|
|
|
void __percpu *devid)
|
|
|
|
{
|
|
|
|
if (armpmu_count_irq_users(irq) == 1)
|
|
|
|
free_percpu_nmi(irq, devid);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct pmu_irq_ops percpu_pmunmi_ops = {
|
|
|
|
.enable_pmuirq = armpmu_enable_percpu_pmunmi,
|
|
|
|
.disable_pmuirq = armpmu_disable_percpu_pmunmi,
|
|
|
|
.free_pmuirq = armpmu_free_percpu_pmunmi
|
|
|
|
};
|
|
|
|
|
2017-12-13 00:56:06 +08:00
|
|
|
static DEFINE_PER_CPU(struct arm_pmu *, cpu_armpmu);
|
|
|
|
static DEFINE_PER_CPU(int, cpu_irq);
|
2020-09-24 19:07:05 +08:00
|
|
|
static DEFINE_PER_CPU(const struct pmu_irq_ops *, cpu_irq_ops);
|
2017-12-13 00:56:06 +08:00
|
|
|
|
2020-09-24 19:07:06 +08:00
|
|
|
static bool has_nmi;
|
|
|
|
|
2018-07-10 16:58:00 +08:00
|
|
|
static inline u64 arm_pmu_event_max_period(struct perf_event *event)
|
2018-07-10 16:57:58 +08:00
|
|
|
{
|
2018-07-10 16:58:00 +08:00
|
|
|
if (event->hw.flags & ARMPMU_EVT_64BIT)
|
|
|
|
return GENMASK_ULL(63, 0);
|
drivers/perf: apple_m1: Force 63bit counters for M2 CPUs
Sidharth reports that on M2, the PMU never generates any interrupt
when using 'perf record', which is a annoying as you get no sample.
I'm temped to say "no sample, no problem", but others may have
a different opinion.
Upon investigation, it appears that the counters on M2 are
significantly different from the ones on M1, as they count on
64 bits instead of 48. Which of course, in the fine M1 tradition,
means that we can only use 63 bits, as the top bit is used to signal
the interrupt...
This results in having to introduce yet another flag to indicate yet
another odd counter width. Who knows what the next crazy implementation
will do...
With this, perf can work out the correct offset, and 'perf record'
works as intended.
Tested on M2 and M2-Pro CPUs.
Cc: Janne Grunau <j@jannau.net>
Cc: Hector Martin <marcan@marcan.st>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>
Fixes: 7d0bfb7c9977 ("drivers/perf: apple_m1: Add Apple M2 support")
Reported-by: Sidharth Kshatriya <sid.kshatriya@gmail.com>
Tested-by: Sidharth Kshatriya <sid.kshatriya@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230528080205.288446-1-maz@kernel.org
Signed-off-by: Will Deacon <will@kernel.org>
2023-05-28 16:02:05 +08:00
|
|
|
else if (event->hw.flags & ARMPMU_EVT_63BIT)
|
|
|
|
return GENMASK_ULL(62, 0);
|
2022-02-09 02:56:03 +08:00
|
|
|
else if (event->hw.flags & ARMPMU_EVT_47BIT)
|
|
|
|
return GENMASK_ULL(46, 0);
|
2018-07-10 16:58:00 +08:00
|
|
|
else
|
|
|
|
return GENMASK_ULL(31, 0);
|
2018-07-10 16:57:58 +08:00
|
|
|
}
|
|
|
|
|
2010-02-03 03:25:44 +08:00
|
|
|
static int
|
2011-04-28 22:47:10 +08:00
|
|
|
armpmu_map_cache_event(const unsigned (*cache_map)
|
|
|
|
[PERF_COUNT_HW_CACHE_MAX]
|
|
|
|
[PERF_COUNT_HW_CACHE_OP_MAX]
|
|
|
|
[PERF_COUNT_HW_CACHE_RESULT_MAX],
|
|
|
|
u64 config)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
|
|
|
unsigned int cache_type, cache_op, cache_result, ret;
|
|
|
|
|
|
|
|
cache_type = (config >> 0) & 0xff;
|
|
|
|
if (cache_type >= PERF_COUNT_HW_CACHE_MAX)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
cache_op = (config >> 8) & 0xff;
|
|
|
|
if (cache_op >= PERF_COUNT_HW_CACHE_OP_MAX)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
cache_result = (config >> 16) & 0xff;
|
|
|
|
if (cache_result >= PERF_COUNT_HW_CACHE_RESULT_MAX)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2017-08-08 23:58:33 +08:00
|
|
|
if (!cache_map)
|
|
|
|
return -ENOENT;
|
|
|
|
|
2011-04-28 22:47:10 +08:00
|
|
|
ret = (int)(*cache_map)[cache_type][cache_op][cache_result];
|
2010-02-03 03:25:44 +08:00
|
|
|
|
|
|
|
if (ret == CACHE_OP_UNSUPPORTED)
|
|
|
|
return -ENOENT;
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-11-14 01:13:56 +08:00
|
|
|
static int
|
2012-07-29 19:36:28 +08:00
|
|
|
armpmu_map_hw_event(const unsigned (*event_map)[PERF_COUNT_HW_MAX], u64 config)
|
2010-11-14 01:13:56 +08:00
|
|
|
{
|
2013-08-09 01:41:59 +08:00
|
|
|
int mapping;
|
|
|
|
|
|
|
|
if (config >= PERF_COUNT_HW_MAX)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2017-08-08 23:58:33 +08:00
|
|
|
if (!event_map)
|
|
|
|
return -ENOENT;
|
|
|
|
|
2013-08-09 01:41:59 +08:00
|
|
|
mapping = (*event_map)[config];
|
2011-04-28 22:47:10 +08:00
|
|
|
return mapping == HW_OP_UNSUPPORTED ? -ENOENT : mapping;
|
2010-11-14 01:13:56 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2011-04-28 22:47:10 +08:00
|
|
|
armpmu_map_raw_event(u32 raw_event_mask, u64 config)
|
2010-11-14 01:13:56 +08:00
|
|
|
{
|
2011-04-28 22:47:10 +08:00
|
|
|
return (int)(config & raw_event_mask);
|
|
|
|
}
|
|
|
|
|
2012-07-29 19:36:28 +08:00
|
|
|
int
|
|
|
|
armpmu_map_event(struct perf_event *event,
|
|
|
|
const unsigned (*event_map)[PERF_COUNT_HW_MAX],
|
|
|
|
const unsigned (*cache_map)
|
|
|
|
[PERF_COUNT_HW_CACHE_MAX]
|
|
|
|
[PERF_COUNT_HW_CACHE_OP_MAX]
|
|
|
|
[PERF_COUNT_HW_CACHE_RESULT_MAX],
|
|
|
|
u32 raw_event_mask)
|
2011-04-28 22:47:10 +08:00
|
|
|
{
|
|
|
|
u64 config = event->attr.config;
|
2012-09-12 17:53:23 +08:00
|
|
|
int type = event->attr.type;
|
2011-04-28 22:47:10 +08:00
|
|
|
|
2012-09-12 17:53:23 +08:00
|
|
|
if (type == event->pmu->type)
|
|
|
|
return armpmu_map_raw_event(raw_event_mask, config);
|
|
|
|
|
|
|
|
switch (type) {
|
2011-04-28 22:47:10 +08:00
|
|
|
case PERF_TYPE_HARDWARE:
|
2012-07-29 19:36:28 +08:00
|
|
|
return armpmu_map_hw_event(event_map, config);
|
2011-04-28 22:47:10 +08:00
|
|
|
case PERF_TYPE_HW_CACHE:
|
|
|
|
return armpmu_map_cache_event(cache_map, config);
|
|
|
|
case PERF_TYPE_RAW:
|
|
|
|
return armpmu_map_raw_event(raw_event_mask, config);
|
|
|
|
}
|
|
|
|
|
|
|
|
return -ENOENT;
|
2010-11-14 01:13:56 +08:00
|
|
|
}
|
|
|
|
|
2012-07-30 19:00:02 +08:00
|
|
|
int armpmu_event_set_period(struct perf_event *event)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2011-04-28 23:27:54 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
|
2012-07-30 19:00:02 +08:00
|
|
|
struct hw_perf_event *hwc = &event->hw;
|
2010-05-21 20:43:08 +08:00
|
|
|
s64 left = local64_read(&hwc->period_left);
|
2010-02-03 03:25:44 +08:00
|
|
|
s64 period = hwc->sample_period;
|
2018-07-10 16:57:58 +08:00
|
|
|
u64 max_period;
|
2010-02-03 03:25:44 +08:00
|
|
|
int ret = 0;
|
|
|
|
|
2018-07-10 16:58:00 +08:00
|
|
|
max_period = arm_pmu_event_max_period(event);
|
2010-02-03 03:25:44 +08:00
|
|
|
if (unlikely(left <= -period)) {
|
|
|
|
left = period;
|
2010-05-21 20:43:08 +08:00
|
|
|
local64_set(&hwc->period_left, left);
|
2010-02-03 03:25:44 +08:00
|
|
|
hwc->last_period = period;
|
|
|
|
ret = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (unlikely(left <= 0)) {
|
|
|
|
left += period;
|
2010-05-21 20:43:08 +08:00
|
|
|
local64_set(&hwc->period_left, left);
|
2010-02-03 03:25:44 +08:00
|
|
|
hwc->last_period = period;
|
|
|
|
ret = 1;
|
|
|
|
}
|
|
|
|
|
2015-01-05 22:58:54 +08:00
|
|
|
/*
|
|
|
|
* Limit the maximum period to prevent the counter value
|
|
|
|
* from overtaking the one we are about to program. In
|
|
|
|
* effect we are reducing max_period to account for
|
|
|
|
* interrupt latency (and we are being very conservative).
|
|
|
|
*/
|
2018-07-10 16:57:58 +08:00
|
|
|
if (left > (max_period >> 1))
|
|
|
|
left = (max_period >> 1);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2010-05-21 20:43:08 +08:00
|
|
|
local64_set(&hwc->prev_count, (u64)-left);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2018-07-10 16:58:00 +08:00
|
|
|
armpmu->write_counter(event, (u64)(-left) & max_period);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
|
|
|
perf_event_update_userpage(event);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2012-07-30 19:00:02 +08:00
|
|
|
u64 armpmu_event_update(struct perf_event *event)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2011-04-28 23:27:54 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
|
2012-07-30 19:00:02 +08:00
|
|
|
struct hw_perf_event *hwc = &event->hw;
|
2011-03-26 00:12:37 +08:00
|
|
|
u64 delta, prev_raw_count, new_raw_count;
|
2018-07-10 16:58:00 +08:00
|
|
|
u64 max_period = arm_pmu_event_max_period(event);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
|
|
|
again:
|
2010-05-21 20:43:08 +08:00
|
|
|
prev_raw_count = local64_read(&hwc->prev_count);
|
2012-07-30 19:00:02 +08:00
|
|
|
new_raw_count = armpmu->read_counter(event);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2010-05-21 20:43:08 +08:00
|
|
|
if (local64_cmpxchg(&hwc->prev_count, prev_raw_count,
|
2010-02-03 03:25:44 +08:00
|
|
|
new_raw_count) != prev_raw_count)
|
|
|
|
goto again;
|
|
|
|
|
2018-07-10 16:57:58 +08:00
|
|
|
delta = (new_raw_count - prev_raw_count) & max_period;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2010-05-21 20:43:08 +08:00
|
|
|
local64_add(delta, &event->count);
|
|
|
|
local64_sub(delta, &hwc->period_left);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
|
|
|
return new_raw_count;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
armpmu_read(struct perf_event *event)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2012-07-30 19:00:02 +08:00
|
|
|
armpmu_event_update(event);
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
armpmu_stop(struct perf_event *event, int flags)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2011-04-28 23:27:54 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
|
2010-02-03 03:25:44 +08:00
|
|
|
struct hw_perf_event *hwc = &event->hw;
|
|
|
|
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
/*
|
|
|
|
* ARM pmu always has to update the counter, so ignore
|
|
|
|
* PERF_EF_UPDATE, see comments in armpmu_start().
|
|
|
|
*/
|
|
|
|
if (!(hwc->state & PERF_HES_STOPPED)) {
|
2012-07-30 19:00:02 +08:00
|
|
|
armpmu->disable(event);
|
|
|
|
armpmu_event_update(event);
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
hwc->state |= PERF_HES_STOPPED | PERF_HES_UPTODATE;
|
|
|
|
}
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
2012-07-30 19:00:02 +08:00
|
|
|
static void armpmu_start(struct perf_event *event, int flags)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2011-04-28 23:27:54 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
|
2010-02-03 03:25:44 +08:00
|
|
|
struct hw_perf_event *hwc = &event->hw;
|
|
|
|
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
/*
|
|
|
|
* ARM pmu always has to reprogram the period, so ignore
|
|
|
|
* PERF_EF_RELOAD, see the comment below.
|
|
|
|
*/
|
|
|
|
if (flags & PERF_EF_RELOAD)
|
|
|
|
WARN_ON_ONCE(!(hwc->state & PERF_HES_UPTODATE));
|
|
|
|
|
|
|
|
hwc->state = 0;
|
2010-02-03 03:25:44 +08:00
|
|
|
/*
|
|
|
|
* Set the period again. Some counters can't be stopped, so when we
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
* were stopped we simply disabled the IRQ source and the counter
|
2010-02-03 03:25:44 +08:00
|
|
|
* may have been left counting. If we don't do this step then we may
|
|
|
|
* get an interrupt too soon or *way* too late if the overflow has
|
|
|
|
* happened since disabling.
|
|
|
|
*/
|
2012-07-30 19:00:02 +08:00
|
|
|
armpmu_event_set_period(event);
|
|
|
|
armpmu->enable(event);
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
static void
|
|
|
|
armpmu_del(struct perf_event *event, int flags)
|
|
|
|
{
|
2011-04-28 23:27:54 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
|
2014-05-14 02:36:31 +08:00
|
|
|
struct pmu_hw_events *hw_events = this_cpu_ptr(armpmu->hw_events);
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
struct hw_perf_event *hwc = &event->hw;
|
|
|
|
int idx = hwc->idx;
|
|
|
|
|
|
|
|
armpmu_stop(event, PERF_EF_UPDATE);
|
2011-05-17 18:20:11 +08:00
|
|
|
hw_events->events[idx] = NULL;
|
2018-07-10 16:58:01 +08:00
|
|
|
armpmu->clear_event_idx(hw_events, event);
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
perf_event_update_userpage(event);
|
2018-07-10 16:58:01 +08:00
|
|
|
/* Clear the allocated counter */
|
|
|
|
hwc->idx = -1;
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
}
|
|
|
|
|
2010-02-03 03:25:44 +08:00
|
|
|
static int
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
armpmu_add(struct perf_event *event, int flags)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2011-04-28 23:27:54 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
|
2014-05-14 02:36:31 +08:00
|
|
|
struct pmu_hw_events *hw_events = this_cpu_ptr(armpmu->hw_events);
|
2010-02-03 03:25:44 +08:00
|
|
|
struct hw_perf_event *hwc = &event->hw;
|
|
|
|
int idx;
|
|
|
|
|
2015-05-14 00:12:25 +08:00
|
|
|
/* An event following a process won't be stopped earlier */
|
|
|
|
if (!cpumask_test_cpu(smp_processor_id(), &armpmu->supported_cpus))
|
|
|
|
return -ENOENT;
|
|
|
|
|
2010-02-03 03:25:44 +08:00
|
|
|
/* If we don't have a space for the counter then finish early. */
|
2012-07-30 19:00:02 +08:00
|
|
|
idx = armpmu->get_event_idx(hw_events, event);
|
2017-04-11 16:39:44 +08:00
|
|
|
if (idx < 0)
|
|
|
|
return idx;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If there is an event in the counter we are going to use then make
|
|
|
|
* sure it is disabled.
|
|
|
|
*/
|
|
|
|
event->hw.idx = idx;
|
2012-07-30 19:00:02 +08:00
|
|
|
armpmu->disable(event);
|
2011-05-17 18:20:11 +08:00
|
|
|
hw_events->events[idx] = event;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
hwc->state = PERF_HES_STOPPED | PERF_HES_UPTODATE;
|
|
|
|
if (flags & PERF_EF_START)
|
|
|
|
armpmu_start(event, PERF_EF_RELOAD);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
|
|
|
/* Propagate our changes to the userspace mapping. */
|
|
|
|
perf_event_update_userpage(event);
|
|
|
|
|
2017-04-11 16:39:44 +08:00
|
|
|
return 0;
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2015-03-18 02:14:58 +08:00
|
|
|
validate_event(struct pmu *pmu, struct pmu_hw_events *hw_events,
|
|
|
|
struct perf_event *event)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2015-03-18 02:14:58 +08:00
|
|
|
struct arm_pmu *armpmu;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2013-08-08 06:39:41 +08:00
|
|
|
if (is_software_event(event))
|
|
|
|
return 1;
|
|
|
|
|
2015-03-18 02:14:58 +08:00
|
|
|
/*
|
|
|
|
* Reject groups spanning multiple HW PMUs (e.g. CPU + CCI). The
|
|
|
|
* core perf code won't check that the pmu->ctx == leader->ctx
|
|
|
|
* until after pmu->event_init(event).
|
|
|
|
*/
|
|
|
|
if (event->pmu != pmu)
|
|
|
|
return 0;
|
|
|
|
|
2013-10-09 20:51:29 +08:00
|
|
|
if (event->state < PERF_EVENT_STATE_OFF)
|
2013-04-13 02:04:19 +08:00
|
|
|
return 1;
|
|
|
|
|
|
|
|
if (event->state == PERF_EVENT_STATE_OFF && !event->attr.enable_on_exec)
|
2010-09-02 16:32:08 +08:00
|
|
|
return 1;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2015-03-18 02:14:58 +08:00
|
|
|
armpmu = to_arm_pmu(event->pmu);
|
2012-07-30 19:00:02 +08:00
|
|
|
return armpmu->get_event_idx(hw_events, event) >= 0;
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
validate_group(struct perf_event *event)
|
|
|
|
{
|
|
|
|
struct perf_event *sibling, *leader = event->group_leader;
|
2011-05-17 18:20:11 +08:00
|
|
|
struct pmu_hw_events fake_pmu;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2011-11-17 23:05:14 +08:00
|
|
|
/*
|
|
|
|
* Initialise the fake PMU. We only need to populate the
|
|
|
|
* used_mask for the purposes of validation.
|
|
|
|
*/
|
2014-05-14 02:08:19 +08:00
|
|
|
memset(&fake_pmu.used_mask, 0, sizeof(fake_pmu.used_mask));
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2015-03-18 02:14:58 +08:00
|
|
|
if (!validate_event(event->pmu, &fake_pmu, leader))
|
2011-11-10 00:56:37 +08:00
|
|
|
return -EINVAL;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2022-04-09 04:33:30 +08:00
|
|
|
if (event == leader)
|
|
|
|
return 0;
|
|
|
|
|
2018-03-16 00:36:56 +08:00
|
|
|
for_each_sibling_event(sibling, leader) {
|
2015-03-18 02:14:58 +08:00
|
|
|
if (!validate_event(event->pmu, &fake_pmu, sibling))
|
2011-11-10 00:56:37 +08:00
|
|
|
return -EINVAL;
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
2015-03-18 02:14:58 +08:00
|
|
|
if (!validate_event(event->pmu, &fake_pmu, event))
|
2011-11-10 00:56:37 +08:00
|
|
|
return -EINVAL;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-07-31 17:34:25 +08:00
|
|
|
static irqreturn_t armpmu_dispatch_irq(int irq, void *dev)
|
2011-02-08 11:54:36 +08:00
|
|
|
{
|
2014-02-08 05:01:19 +08:00
|
|
|
struct arm_pmu *armpmu;
|
2014-02-12 02:08:41 +08:00
|
|
|
int ret;
|
|
|
|
u64 start_clock, finish_clock;
|
2014-02-08 05:01:19 +08:00
|
|
|
|
2014-05-14 02:46:10 +08:00
|
|
|
/*
|
|
|
|
* we request the IRQ with a (possibly percpu) struct arm_pmu**, but
|
|
|
|
* the handlers expect a struct arm_pmu*. The percpu_irq framework will
|
|
|
|
* do any necessary shifting, we just need to perform the first
|
|
|
|
* dereference.
|
|
|
|
*/
|
|
|
|
armpmu = *(void **)dev;
|
2017-12-13 00:56:06 +08:00
|
|
|
if (WARN_ON_ONCE(!armpmu))
|
|
|
|
return IRQ_NONE;
|
2017-04-11 16:39:49 +08:00
|
|
|
|
2014-02-12 02:08:41 +08:00
|
|
|
start_clock = sched_clock();
|
2018-05-10 18:35:15 +08:00
|
|
|
ret = armpmu->handle_irq(armpmu);
|
2014-02-12 02:08:41 +08:00
|
|
|
finish_clock = sched_clock();
|
|
|
|
|
|
|
|
perf_sample_event_took(finish_clock - start_clock);
|
|
|
|
return ret;
|
2011-02-08 11:54:36 +08:00
|
|
|
}
|
|
|
|
|
2010-02-03 03:25:44 +08:00
|
|
|
static int
|
|
|
|
__hw_perf_event_init(struct perf_event *event)
|
|
|
|
{
|
2011-04-28 23:27:54 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
|
2010-02-03 03:25:44 +08:00
|
|
|
struct hw_perf_event *hwc = &event->hw;
|
2023-12-12 00:13:21 +08:00
|
|
|
int mapping, ret;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2018-07-10 16:58:00 +08:00
|
|
|
hwc->flags = 0;
|
2011-04-28 22:47:10 +08:00
|
|
|
mapping = armpmu->map_event(event);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
|
|
|
if (mapping < 0) {
|
|
|
|
pr_debug("event %x:%llx not supported\n", event->attr.type,
|
|
|
|
event->attr.config);
|
|
|
|
return mapping;
|
|
|
|
}
|
|
|
|
|
2011-07-19 18:57:30 +08:00
|
|
|
/*
|
|
|
|
* We don't assign an index until we actually place the event onto
|
|
|
|
* hardware. Use -1 to signify that we haven't decided where to put it
|
|
|
|
* yet. For SMP systems, each core has it's own PMU so we can't do any
|
|
|
|
* clever allocation or constraints checking at this point.
|
|
|
|
*/
|
|
|
|
hwc->idx = -1;
|
|
|
|
hwc->config_base = 0;
|
|
|
|
hwc->config = 0;
|
|
|
|
hwc->event_base = 0;
|
|
|
|
|
2010-02-03 03:25:44 +08:00
|
|
|
/*
|
|
|
|
* Check whether we need to exclude the counter from certain modes.
|
|
|
|
*/
|
2023-12-12 00:13:21 +08:00
|
|
|
if (armpmu->set_event_filter) {
|
|
|
|
ret = armpmu->set_event_filter(hwc, &event->attr);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2011-07-19 18:57:30 +08:00
|
|
|
* Store the event encoding into the config_base field.
|
2010-02-03 03:25:44 +08:00
|
|
|
*/
|
2011-07-19 18:57:30 +08:00
|
|
|
hwc->config_base |= (unsigned long)mapping;
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2014-05-17 05:15:49 +08:00
|
|
|
if (!is_sampling_event(event)) {
|
2012-03-07 00:33:17 +08:00
|
|
|
/*
|
|
|
|
* For non-sampling runs, limit the sample_period to half
|
|
|
|
* of the counter width. That way, the new counter value
|
|
|
|
* is far less likely to overtake the previous one unless
|
|
|
|
* you have some serious IRQ latency issues.
|
|
|
|
*/
|
2018-07-10 16:58:00 +08:00
|
|
|
hwc->sample_period = arm_pmu_event_max_period(event) >> 1;
|
2010-02-03 03:25:44 +08:00
|
|
|
hwc->last_period = hwc->sample_period;
|
2010-05-21 20:43:08 +08:00
|
|
|
local64_set(&hwc->period_left, hwc->sample_period);
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
2022-04-09 04:33:30 +08:00
|
|
|
return validate_group(event);
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
2010-06-11 19:35:08 +08:00
|
|
|
static int armpmu_event_init(struct perf_event *event)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2011-04-28 23:27:54 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2015-05-14 00:12:25 +08:00
|
|
|
/*
|
|
|
|
* Reject CPU-affine events for CPUs that are of a different class to
|
|
|
|
* that which this PMU handles. Process-following events (where
|
|
|
|
* event->cpu == -1) can be migrated between CPUs, and thus we have to
|
|
|
|
* reject them later (in armpmu_add) if they're scheduled on a
|
|
|
|
* different class of CPU.
|
|
|
|
*/
|
|
|
|
if (event->cpu != -1 &&
|
|
|
|
!cpumask_test_cpu(event->cpu, &armpmu->supported_cpus))
|
|
|
|
return -ENOENT;
|
|
|
|
|
2012-02-10 06:20:59 +08:00
|
|
|
/* does not support taken branch sampling */
|
|
|
|
if (has_branch_stack(event))
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
|
drivers/perf: arm_pmu: split irq request from enable
For historical reasons, we lazily request and free interrupts in the
arm pmu driver. This requires us to refcount use of the pmu (by way of
counting the active events) in order to request/free interrupts at the
correct times, which complicates the driver somewhat.
The existing logic is flawed, as it only considers currently online CPUs
when requesting, freeing, or managing the affinity of interrupts.
Intervening hotplug events can result in erroneous IRQ affinity, online
CPUs for which interrupts have not been requested, or offline CPUs whose
interrupts are still requested.
To fix this, this patch splits the requesting of interrupts from any
per-cpu management (i.e. per-cpu enable/disable, and configuration of
cpu affinity). We now request all interrupts up-front at probe time (and
never free them, since we never unregister PMUs).
The management of affinity, and per-cpu enable/disable now happens in
our cpu hotplug callback, ensuring it occurs consistently. This means
that we must now invoke the CPU hotplug callback at boot time in order
to configure IRQs, and since the callback also resets the PMU hardware,
we can remove the duplicate reset in the probe path.
This rework renders our event refcounting unnecessary, so this is
removed.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[will: make armpmu_get_cpu_irq static]
Signed-off-by: Will Deacon <will.deacon@arm.com>
2017-03-10 18:46:15 +08:00
|
|
|
return __hw_perf_event_init(event);
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
static void armpmu_enable(struct pmu *pmu)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2011-05-17 18:20:11 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(pmu);
|
2014-05-14 02:36:31 +08:00
|
|
|
struct pmu_hw_events *hw_events = this_cpu_ptr(armpmu->hw_events);
|
2022-02-11 06:48:56 +08:00
|
|
|
bool enabled = !bitmap_empty(hw_events->used_mask, armpmu->num_events);
|
2010-02-03 03:25:44 +08:00
|
|
|
|
2015-05-14 00:12:25 +08:00
|
|
|
/* For task-bound events we may be called on other CPUs */
|
|
|
|
if (!cpumask_test_cpu(smp_processor_id(), &armpmu->supported_cpus))
|
|
|
|
return;
|
|
|
|
|
2011-07-01 21:38:12 +08:00
|
|
|
if (enabled)
|
2012-07-30 19:00:02 +08:00
|
|
|
armpmu->start(armpmu);
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
perf: Rework the PMU methods
Replace pmu::{enable,disable,start,stop,unthrottle} with
pmu::{add,del,start,stop}, all of which take a flags argument.
The new interface extends the capability to stop a counter while
keeping it scheduled on the PMU. We replace the throttled state with
the generic stopped state.
This also allows us to efficiently stop/start counters over certain
code paths (like IRQ handlers).
It also allows scheduling a counter without it starting, allowing for
a generic frozen state (useful for rotating stopped counters).
The stopped state is implemented in two different ways, depending on
how the architecture implemented the throttled state:
1) We disable the counter:
a) the pmu has per-counter enable bits, we flip that
b) we program a NOP event, preserving the counter state
2) We store the counter state and ignore all read/overflow events
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: stephane eranian <eranian@googlemail.com>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Yanmin <yanmin_zhang@linux.intel.com>
Cc: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Michael Cree <mcree@orcon.net.nz>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2010-06-16 20:37:10 +08:00
|
|
|
static void armpmu_disable(struct pmu *pmu)
|
2010-02-03 03:25:44 +08:00
|
|
|
{
|
2011-04-28 23:27:54 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(pmu);
|
2015-05-14 00:12:25 +08:00
|
|
|
|
|
|
|
/* For task-bound events we may be called on other CPUs */
|
|
|
|
if (!cpumask_test_cpu(smp_processor_id(), &armpmu->supported_cpus))
|
|
|
|
return;
|
|
|
|
|
2012-07-30 19:00:02 +08:00
|
|
|
armpmu->stop(armpmu);
|
2010-02-03 03:25:44 +08:00
|
|
|
}
|
|
|
|
|
2015-05-14 00:12:26 +08:00
|
|
|
/*
|
|
|
|
* In heterogeneous systems, events are specific to a particular
|
|
|
|
* microarchitecture, and aren't suitable for another. Thus, only match CPUs of
|
|
|
|
* the same microarchitecture.
|
|
|
|
*/
|
perf: Rewrite core context handling
There have been various issues and limitations with the way perf uses
(task) contexts to track events. Most notable is the single hardware
PMU task context, which has resulted in a number of yucky things (both
proposed and merged).
Notably:
- HW breakpoint PMU
- ARM big.little PMU / Intel ADL PMU
- Intel Branch Monitoring PMU
- AMD IBS PMU
- S390 cpum_cf PMU
- PowerPC trace_imc PMU
*Current design:*
Currently we have a per task and per cpu perf_event_contexts:
task_struct::perf_events_ctxp[] <-> perf_event_context <-> perf_cpu_context
^ | ^ | ^
`---------------------------------' | `--> pmu ---'
v ^
perf_event ------'
Each task has an array of pointers to a perf_event_context. Each
perf_event_context has a direct relation to a PMU and a group of
events for that PMU. The task related perf_event_context's have a
pointer back to that task.
Each PMU has a per-cpu pointer to a per-cpu perf_cpu_context, which
includes a perf_event_context, which again has a direct relation to
that PMU, and a group of events for that PMU.
The perf_cpu_context also tracks which task context is currently
associated with that CPU and includes a few other things like the
hrtimer for rotation etc.
Each perf_event is then associated with its PMU and one
perf_event_context.
*Proposed design:*
New design proposed by this patch reduce to a single task context and
a single CPU context but adds some intermediate data-structures:
task_struct::perf_event_ctxp -> perf_event_context <- perf_cpu_context
^ | ^ ^
`---------------------------' | |
| | perf_cpu_pmu_context <--.
| `----. ^ |
| | | |
| v v |
| ,--> perf_event_pmu_context |
| | |
| | |
v v |
perf_event ---> pmu ----------------'
With the new design, perf_event_context will hold all events for all
pmus in the (respective pinned/flexible) rbtrees. This can be achieved
by adding pmu to rbtree key:
{cpu, pmu, cgroup, group_index}
Each perf_event_context carries a list of perf_event_pmu_context which
is used to hold per-pmu-per-context state. For example, it keeps track
of currently active events for that pmu, a pmu specific task_ctx_data,
a flag to tell whether rotation is required or not etc.
Additionally, perf_cpu_pmu_context is used to hold per-pmu-per-cpu
state like hrtimer details to drive the event rotation, a pointer to
perf_event_pmu_context of currently running task and some other
ancillary information.
Each perf_event is associated to it's pmu, perf_event_context and
perf_event_pmu_context.
Further optimizations to current implementation are possible. For
example, ctx_resched() can be optimized to reschedule only single pmu
events.
Much thanks to Ravi for picking this up and pushing it towards
completion.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Co-developed-by: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20221008062424.313-1-ravi.bangoria@amd.com
2022-10-08 14:24:24 +08:00
|
|
|
static bool armpmu_filter(struct pmu *pmu, int cpu)
|
2015-05-14 00:12:26 +08:00
|
|
|
{
|
perf: Rewrite core context handling
There have been various issues and limitations with the way perf uses
(task) contexts to track events. Most notable is the single hardware
PMU task context, which has resulted in a number of yucky things (both
proposed and merged).
Notably:
- HW breakpoint PMU
- ARM big.little PMU / Intel ADL PMU
- Intel Branch Monitoring PMU
- AMD IBS PMU
- S390 cpum_cf PMU
- PowerPC trace_imc PMU
*Current design:*
Currently we have a per task and per cpu perf_event_contexts:
task_struct::perf_events_ctxp[] <-> perf_event_context <-> perf_cpu_context
^ | ^ | ^
`---------------------------------' | `--> pmu ---'
v ^
perf_event ------'
Each task has an array of pointers to a perf_event_context. Each
perf_event_context has a direct relation to a PMU and a group of
events for that PMU. The task related perf_event_context's have a
pointer back to that task.
Each PMU has a per-cpu pointer to a per-cpu perf_cpu_context, which
includes a perf_event_context, which again has a direct relation to
that PMU, and a group of events for that PMU.
The perf_cpu_context also tracks which task context is currently
associated with that CPU and includes a few other things like the
hrtimer for rotation etc.
Each perf_event is then associated with its PMU and one
perf_event_context.
*Proposed design:*
New design proposed by this patch reduce to a single task context and
a single CPU context but adds some intermediate data-structures:
task_struct::perf_event_ctxp -> perf_event_context <- perf_cpu_context
^ | ^ ^
`---------------------------' | |
| | perf_cpu_pmu_context <--.
| `----. ^ |
| | | |
| v v |
| ,--> perf_event_pmu_context |
| | |
| | |
v v |
perf_event ---> pmu ----------------'
With the new design, perf_event_context will hold all events for all
pmus in the (respective pinned/flexible) rbtrees. This can be achieved
by adding pmu to rbtree key:
{cpu, pmu, cgroup, group_index}
Each perf_event_context carries a list of perf_event_pmu_context which
is used to hold per-pmu-per-context state. For example, it keeps track
of currently active events for that pmu, a pmu specific task_ctx_data,
a flag to tell whether rotation is required or not etc.
Additionally, perf_cpu_pmu_context is used to hold per-pmu-per-cpu
state like hrtimer details to drive the event rotation, a pointer to
perf_event_pmu_context of currently running task and some other
ancillary information.
Each perf_event is associated to it's pmu, perf_event_context and
perf_event_pmu_context.
Further optimizations to current implementation are possible. For
example, ctx_resched() can be optimized to reschedule only single pmu
events.
Much thanks to Ravi for picking this up and pushing it towards
completion.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Co-developed-by: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20221008062424.313-1-ravi.bangoria@amd.com
2022-10-08 14:24:24 +08:00
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(pmu);
|
arm_pmu: fix event CPU filtering
Janne reports that perf has been broken on Apple M1 as of commit:
bd27568117664b8b ("perf: Rewrite core context handling")
That commit replaced the pmu::filter_match() callback with
pmu::filter(), whose return value has the opposite polarity, with true
implying events should be ignored rather than scheduled. While an
attempt was made to update the logic in armv8pmu_filter() and
armpmu_filter() accordingly, the return value remains inverted in a
couple of cases:
* If the arm_pmu does not have an arm_pmu::filter() callback,
armpmu_filter() will always return whether the CPU is supported rather
than whether the CPU is not supported.
As a result, the perf core will not schedule events on supported CPUs,
resulting in a loss of events. Additionally, the perf core will
attempt to schedule events on unsupported CPUs, but this will be
rejected by armpmu_add(), which may result in a loss of events from
other PMUs on those unsupported CPUs.
* If the arm_pmu does have an arm_pmu::filter() callback, and
armpmu_filter() is called on a CPU which is not supported by the
arm_pmu, armpmu_filter() will return false rather than true.
As a result, the perf core will attempt to schedule events on
unsupported CPUs, but this will be rejected by armpmu_add(), which may
result in a loss of events from other PMUs on those unsupported CPUs.
This means a loss of events can be seen with any arm_pmu driver, but
with the ARMv8 PMUv3 driver (which is the only arm_pmu driver with an
arm_pmu::filter() callback) the event loss will be more limited and may
go unnoticed, which is how this issue evaded testing so far.
Fix the CPU filtering by performing this consistently in
armpmu_filter(), and remove the redundant arm_pmu::filter() callback and
armv8pmu_filter() implementation.
Commit bd2756811766 also silently removed the CHAIN event filtering from
armv8pmu_filter(), which will be addressed by a separate patch without
using the filter callback.
Fixes: bd2756811766 ("perf: Rewrite core context handling")
Reported-by: Janne Grunau <j@jannau.net>
Link: https://lore.kernel.org/asahi/20230215-arm_pmu_m1_regression-v1-1-f5a266577c8d@jannau.net/
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Asahi Lina <lina@asahilina.net>
Cc: Eric Curtin <ecurtin@redhat.com>
Tested-by: Janne Grunau <j@jannau.net>
Link: https://lore.kernel.org/r/20230216141240.3833272-2-mark.rutland@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
2023-02-16 22:12:38 +08:00
|
|
|
return !cpumask_test_cpu(cpu, &armpmu->supported_cpus);
|
2015-05-14 00:12:26 +08:00
|
|
|
}
|
|
|
|
|
2021-05-28 09:41:30 +08:00
|
|
|
static ssize_t cpus_show(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *buf)
|
drivers/perf: arm_pmu: expose a cpumask in sysfs
In systems with heterogeneous CPUs, there are multiple logical CPU PMUs,
each of which covers a subset of CPUs in the system. In some cases
userspace needs to know which CPUs a given logical PMU covers, so we'd
like to expose a cpumask under sysfs, similar to what is done for uncore
PMUs.
Unfortunately, prior to commit 00e727bb389359c8 ("perf stat: Balance
opening and reading events"), perf stat only correctly handled a cpumask
holding a single CPU, and only when profiling in system-wide mode. In
other cases, the presence of a cpumask file could cause perf stat to
behave erratically.
Thus, exposing a cpumask file would break older perf binaries in cases
where they would otherwise work.
To avoid this issue while still providing userspace with the information
it needs, this patch exposes a differently-named file (cpus) under
sysfs. New tools can look for this and operate correctly, while older
tools will not be adversely affected by its presence.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
2016-09-09 21:08:30 +08:00
|
|
|
{
|
|
|
|
struct arm_pmu *armpmu = to_arm_pmu(dev_get_drvdata(dev));
|
|
|
|
return cpumap_print_to_pagebuf(true, buf, &armpmu->supported_cpus);
|
|
|
|
}
|
|
|
|
|
2021-05-28 09:41:30 +08:00
|
|
|
static DEVICE_ATTR_RO(cpus);
|
drivers/perf: arm_pmu: expose a cpumask in sysfs
In systems with heterogeneous CPUs, there are multiple logical CPU PMUs,
each of which covers a subset of CPUs in the system. In some cases
userspace needs to know which CPUs a given logical PMU covers, so we'd
like to expose a cpumask under sysfs, similar to what is done for uncore
PMUs.
Unfortunately, prior to commit 00e727bb389359c8 ("perf stat: Balance
opening and reading events"), perf stat only correctly handled a cpumask
holding a single CPU, and only when profiling in system-wide mode. In
other cases, the presence of a cpumask file could cause perf stat to
behave erratically.
Thus, exposing a cpumask file would break older perf binaries in cases
where they would otherwise work.
To avoid this issue while still providing userspace with the information
it needs, this patch exposes a differently-named file (cpus) under
sysfs. New tools can look for this and operate correctly, while older
tools will not be adversely affected by its presence.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
2016-09-09 21:08:30 +08:00
|
|
|
|
|
|
|
static struct attribute *armpmu_common_attrs[] = {
|
|
|
|
&dev_attr_cpus.attr,
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
2021-01-18 05:28:47 +08:00
|
|
|
static const struct attribute_group armpmu_common_attr_group = {
|
drivers/perf: arm_pmu: expose a cpumask in sysfs
In systems with heterogeneous CPUs, there are multiple logical CPU PMUs,
each of which covers a subset of CPUs in the system. In some cases
userspace needs to know which CPUs a given logical PMU covers, so we'd
like to expose a cpumask under sysfs, similar to what is done for uncore
PMUs.
Unfortunately, prior to commit 00e727bb389359c8 ("perf stat: Balance
opening and reading events"), perf stat only correctly handled a cpumask
holding a single CPU, and only when profiling in system-wide mode. In
other cases, the presence of a cpumask file could cause perf stat to
behave erratically.
Thus, exposing a cpumask file would break older perf binaries in cases
where they would otherwise work.
To avoid this issue while still providing userspace with the information
it needs, this patch exposes a differently-named file (cpus) under
sysfs. New tools can look for this and operate correctly, while older
tools will not be adversely affected by its presence.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
2016-09-09 21:08:30 +08:00
|
|
|
.attrs = armpmu_common_attrs,
|
|
|
|
};
|
|
|
|
|
2017-12-13 00:56:06 +08:00
|
|
|
static int armpmu_count_irq_users(const int irq)
|
2015-05-27 00:23:39 +08:00
|
|
|
{
|
2017-12-13 00:56:06 +08:00
|
|
|
int cpu, count = 0;
|
2015-05-27 00:23:39 +08:00
|
|
|
|
2017-12-13 00:56:06 +08:00
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
if (per_cpu(cpu_irq, cpu) == irq)
|
|
|
|
count++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return count;
|
|
|
|
}
|
2017-03-10 18:46:14 +08:00
|
|
|
|
2020-09-24 19:07:05 +08:00
|
|
|
static const struct pmu_irq_ops *armpmu_find_irq_ops(int irq)
|
|
|
|
{
|
|
|
|
const struct pmu_irq_ops *ops = NULL;
|
|
|
|
int cpu;
|
|
|
|
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
if (per_cpu(cpu_irq, cpu) != irq)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
ops = per_cpu(cpu_irq_ops, cpu);
|
|
|
|
if (ops)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ops;
|
|
|
|
}
|
|
|
|
|
2017-10-10 00:09:05 +08:00
|
|
|
void armpmu_free_irq(int irq, int cpu)
|
2017-12-13 00:56:06 +08:00
|
|
|
{
|
|
|
|
if (per_cpu(cpu_irq, cpu) == 0)
|
|
|
|
return;
|
|
|
|
if (WARN_ON(irq != per_cpu(cpu_irq, cpu)))
|
2017-04-11 16:39:51 +08:00
|
|
|
return;
|
2017-03-10 18:46:14 +08:00
|
|
|
|
2020-09-24 19:07:05 +08:00
|
|
|
per_cpu(cpu_irq_ops, cpu)->free_pmuirq(irq, cpu, &cpu_armpmu);
|
2017-12-13 00:56:06 +08:00
|
|
|
|
|
|
|
per_cpu(cpu_irq, cpu) = 0;
|
2020-09-24 19:07:05 +08:00
|
|
|
per_cpu(cpu_irq_ops, cpu) = NULL;
|
2017-04-11 16:39:51 +08:00
|
|
|
}
|
2017-03-10 18:46:14 +08:00
|
|
|
|
2017-10-10 00:09:05 +08:00
|
|
|
int armpmu_request_irq(int irq, int cpu)
|
2017-12-13 00:56:06 +08:00
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
const irq_handler_t handler = armpmu_dispatch_irq;
|
2020-09-24 19:07:05 +08:00
|
|
|
const struct pmu_irq_ops *irq_ops;
|
|
|
|
|
2017-04-11 16:39:51 +08:00
|
|
|
if (!irq)
|
|
|
|
return 0;
|
2015-05-27 00:23:39 +08:00
|
|
|
|
2018-02-06 00:41:59 +08:00
|
|
|
if (!irq_is_percpu_devid(irq)) {
|
2017-07-25 23:30:34 +08:00
|
|
|
unsigned long irq_flags;
|
|
|
|
|
|
|
|
err = irq_force_affinity(irq, cpumask_of(cpu));
|
|
|
|
|
|
|
|
if (err && num_possible_cpus() > 1) {
|
|
|
|
pr_warn("unable to set irq affinity (irq=%d, cpu=%u)\n",
|
|
|
|
irq, cpu);
|
|
|
|
goto err_out;
|
|
|
|
}
|
|
|
|
|
2018-02-06 00:41:56 +08:00
|
|
|
irq_flags = IRQF_PERCPU |
|
2021-06-02 09:00:41 +08:00
|
|
|
IRQF_NOBALANCING | IRQF_NO_AUTOEN |
|
2018-02-06 00:41:56 +08:00
|
|
|
IRQF_NO_THREAD;
|
2017-07-25 23:30:34 +08:00
|
|
|
|
2020-09-24 19:07:06 +08:00
|
|
|
err = request_nmi(irq, handler, irq_flags, "arm-pmu",
|
2017-12-13 00:56:06 +08:00
|
|
|
per_cpu_ptr(&cpu_armpmu, cpu));
|
2020-09-24 19:07:05 +08:00
|
|
|
|
2020-09-24 19:07:06 +08:00
|
|
|
/* If cannot get an NMI, get a normal interrupt */
|
|
|
|
if (err) {
|
|
|
|
err = request_irq(irq, handler, irq_flags, "arm-pmu",
|
|
|
|
per_cpu_ptr(&cpu_armpmu, cpu));
|
|
|
|
irq_ops = &pmuirq_ops;
|
|
|
|
} else {
|
|
|
|
has_nmi = true;
|
|
|
|
irq_ops = &pmunmi_ops;
|
|
|
|
}
|
2017-12-13 00:56:06 +08:00
|
|
|
} else if (armpmu_count_irq_users(irq) == 0) {
|
2020-09-24 19:07:06 +08:00
|
|
|
err = request_percpu_nmi(irq, handler, "arm-pmu", &cpu_armpmu);
|
|
|
|
|
|
|
|
/* If cannot get an NMI, get a normal interrupt */
|
|
|
|
if (err) {
|
|
|
|
err = request_percpu_irq(irq, handler, "arm-pmu",
|
|
|
|
&cpu_armpmu);
|
|
|
|
irq_ops = &percpu_pmuirq_ops;
|
|
|
|
} else {
|
2021-05-11 20:27:32 +08:00
|
|
|
has_nmi = true;
|
2020-09-24 19:07:06 +08:00
|
|
|
irq_ops = &percpu_pmunmi_ops;
|
|
|
|
}
|
2020-09-24 19:07:05 +08:00
|
|
|
} else {
|
|
|
|
/* Per cpudevid irq was already requested by another CPU */
|
|
|
|
irq_ops = armpmu_find_irq_ops(irq);
|
|
|
|
|
|
|
|
if (WARN_ON(!irq_ops))
|
|
|
|
err = -EINVAL;
|
2017-04-11 16:39:51 +08:00
|
|
|
}
|
2017-03-10 18:46:14 +08:00
|
|
|
|
2017-07-25 23:30:34 +08:00
|
|
|
if (err)
|
|
|
|
goto err_out;
|
2015-05-27 00:23:39 +08:00
|
|
|
|
2017-12-13 00:56:06 +08:00
|
|
|
per_cpu(cpu_irq, cpu) = irq;
|
2020-09-24 19:07:05 +08:00
|
|
|
per_cpu(cpu_irq_ops, cpu) = irq_ops;
|
2015-05-27 00:23:39 +08:00
|
|
|
return 0;
|
2017-07-25 23:30:34 +08:00
|
|
|
|
|
|
|
err_out:
|
|
|
|
pr_err("unable to request IRQ%d for ARM PMU counters\n", irq);
|
|
|
|
return err;
|
2015-05-27 00:23:39 +08:00
|
|
|
}
|
|
|
|
|
drivers/perf: arm_pmu: split irq request from enable
For historical reasons, we lazily request and free interrupts in the
arm pmu driver. This requires us to refcount use of the pmu (by way of
counting the active events) in order to request/free interrupts at the
correct times, which complicates the driver somewhat.
The existing logic is flawed, as it only considers currently online CPUs
when requesting, freeing, or managing the affinity of interrupts.
Intervening hotplug events can result in erroneous IRQ affinity, online
CPUs for which interrupts have not been requested, or offline CPUs whose
interrupts are still requested.
To fix this, this patch splits the requesting of interrupts from any
per-cpu management (i.e. per-cpu enable/disable, and configuration of
cpu affinity). We now request all interrupts up-front at probe time (and
never free them, since we never unregister PMUs).
The management of affinity, and per-cpu enable/disable now happens in
our cpu hotplug callback, ensuring it occurs consistently. This means
that we must now invoke the CPU hotplug callback at boot time in order
to configure IRQs, and since the callback also resets the PMU hardware,
we can remove the duplicate reset in the probe path.
This rework renders our event refcounting unnecessary, so this is
removed.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[will: make armpmu_get_cpu_irq static]
Signed-off-by: Will Deacon <will.deacon@arm.com>
2017-03-10 18:46:15 +08:00
|
|
|
static int armpmu_get_cpu_irq(struct arm_pmu *pmu, int cpu)
|
|
|
|
{
|
|
|
|
struct pmu_hw_events __percpu *hw_events = pmu->hw_events;
|
|
|
|
return per_cpu(hw_events->irq, cpu);
|
|
|
|
}
|
|
|
|
|
2023-05-20 01:18:42 +08:00
|
|
|
bool arm_pmu_irq_is_nmi(void)
|
|
|
|
{
|
|
|
|
return has_nmi;
|
|
|
|
}
|
|
|
|
|
2015-05-27 00:23:39 +08:00
|
|
|
/*
|
|
|
|
* PMU hardware loses all context when a CPU goes offline.
|
|
|
|
* When a CPU is hotplugged back in, since some hardware registers are
|
|
|
|
* UNKNOWN at reset, the PMU must be explicitly reset to avoid reading
|
|
|
|
* junk values out of them.
|
|
|
|
*/
|
2016-08-18 01:14:20 +08:00
|
|
|
static int arm_perf_starting_cpu(unsigned int cpu, struct hlist_node *node)
|
2015-05-27 00:23:39 +08:00
|
|
|
{
|
2016-08-18 01:14:20 +08:00
|
|
|
struct arm_pmu *pmu = hlist_entry_safe(node, struct arm_pmu, node);
|
drivers/perf: arm_pmu: split irq request from enable
For historical reasons, we lazily request and free interrupts in the
arm pmu driver. This requires us to refcount use of the pmu (by way of
counting the active events) in order to request/free interrupts at the
correct times, which complicates the driver somewhat.
The existing logic is flawed, as it only considers currently online CPUs
when requesting, freeing, or managing the affinity of interrupts.
Intervening hotplug events can result in erroneous IRQ affinity, online
CPUs for which interrupts have not been requested, or offline CPUs whose
interrupts are still requested.
To fix this, this patch splits the requesting of interrupts from any
per-cpu management (i.e. per-cpu enable/disable, and configuration of
cpu affinity). We now request all interrupts up-front at probe time (and
never free them, since we never unregister PMUs).
The management of affinity, and per-cpu enable/disable now happens in
our cpu hotplug callback, ensuring it occurs consistently. This means
that we must now invoke the CPU hotplug callback at boot time in order
to configure IRQs, and since the callback also resets the PMU hardware,
we can remove the duplicate reset in the probe path.
This rework renders our event refcounting unnecessary, so this is
removed.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[will: make armpmu_get_cpu_irq static]
Signed-off-by: Will Deacon <will.deacon@arm.com>
2017-03-10 18:46:15 +08:00
|
|
|
int irq;
|
2015-05-27 00:23:39 +08:00
|
|
|
|
2016-08-18 01:14:20 +08:00
|
|
|
if (!cpumask_test_cpu(cpu, &pmu->supported_cpus))
|
|
|
|
return 0;
|
|
|
|
if (pmu->reset)
|
|
|
|
pmu->reset(pmu);
|
drivers/perf: arm_pmu: split irq request from enable
For historical reasons, we lazily request and free interrupts in the
arm pmu driver. This requires us to refcount use of the pmu (by way of
counting the active events) in order to request/free interrupts at the
correct times, which complicates the driver somewhat.
The existing logic is flawed, as it only considers currently online CPUs
when requesting, freeing, or managing the affinity of interrupts.
Intervening hotplug events can result in erroneous IRQ affinity, online
CPUs for which interrupts have not been requested, or offline CPUs whose
interrupts are still requested.
To fix this, this patch splits the requesting of interrupts from any
per-cpu management (i.e. per-cpu enable/disable, and configuration of
cpu affinity). We now request all interrupts up-front at probe time (and
never free them, since we never unregister PMUs).
The management of affinity, and per-cpu enable/disable now happens in
our cpu hotplug callback, ensuring it occurs consistently. This means
that we must now invoke the CPU hotplug callback at boot time in order
to configure IRQs, and since the callback also resets the PMU hardware,
we can remove the duplicate reset in the probe path.
This rework renders our event refcounting unnecessary, so this is
removed.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[will: make armpmu_get_cpu_irq static]
Signed-off-by: Will Deacon <will.deacon@arm.com>
2017-03-10 18:46:15 +08:00
|
|
|
|
2017-12-13 00:56:06 +08:00
|
|
|
per_cpu(cpu_armpmu, cpu) = pmu;
|
|
|
|
|
drivers/perf: arm_pmu: split irq request from enable
For historical reasons, we lazily request and free interrupts in the
arm pmu driver. This requires us to refcount use of the pmu (by way of
counting the active events) in order to request/free interrupts at the
correct times, which complicates the driver somewhat.
The existing logic is flawed, as it only considers currently online CPUs
when requesting, freeing, or managing the affinity of interrupts.
Intervening hotplug events can result in erroneous IRQ affinity, online
CPUs for which interrupts have not been requested, or offline CPUs whose
interrupts are still requested.
To fix this, this patch splits the requesting of interrupts from any
per-cpu management (i.e. per-cpu enable/disable, and configuration of
cpu affinity). We now request all interrupts up-front at probe time (and
never free them, since we never unregister PMUs).
The management of affinity, and per-cpu enable/disable now happens in
our cpu hotplug callback, ensuring it occurs consistently. This means
that we must now invoke the CPU hotplug callback at boot time in order
to configure IRQs, and since the callback also resets the PMU hardware,
we can remove the duplicate reset in the probe path.
This rework renders our event refcounting unnecessary, so this is
removed.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[will: make armpmu_get_cpu_irq static]
Signed-off-by: Will Deacon <will.deacon@arm.com>
2017-03-10 18:46:15 +08:00
|
|
|
irq = armpmu_get_cpu_irq(pmu, cpu);
|
2020-09-24 19:07:05 +08:00
|
|
|
if (irq)
|
|
|
|
per_cpu(cpu_irq_ops, cpu)->enable_pmuirq(irq);
|
drivers/perf: arm_pmu: split irq request from enable
For historical reasons, we lazily request and free interrupts in the
arm pmu driver. This requires us to refcount use of the pmu (by way of
counting the active events) in order to request/free interrupts at the
correct times, which complicates the driver somewhat.
The existing logic is flawed, as it only considers currently online CPUs
when requesting, freeing, or managing the affinity of interrupts.
Intervening hotplug events can result in erroneous IRQ affinity, online
CPUs for which interrupts have not been requested, or offline CPUs whose
interrupts are still requested.
To fix this, this patch splits the requesting of interrupts from any
per-cpu management (i.e. per-cpu enable/disable, and configuration of
cpu affinity). We now request all interrupts up-front at probe time (and
never free them, since we never unregister PMUs).
The management of affinity, and per-cpu enable/disable now happens in
our cpu hotplug callback, ensuring it occurs consistently. This means
that we must now invoke the CPU hotplug callback at boot time in order
to configure IRQs, and since the callback also resets the PMU hardware,
we can remove the duplicate reset in the probe path.
This rework renders our event refcounting unnecessary, so this is
removed.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[will: make armpmu_get_cpu_irq static]
Signed-off-by: Will Deacon <will.deacon@arm.com>
2017-03-10 18:46:15 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int arm_perf_teardown_cpu(unsigned int cpu, struct hlist_node *node)
|
|
|
|
{
|
|
|
|
struct arm_pmu *pmu = hlist_entry_safe(node, struct arm_pmu, node);
|
|
|
|
int irq;
|
|
|
|
|
|
|
|
if (!cpumask_test_cpu(cpu, &pmu->supported_cpus))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
irq = armpmu_get_cpu_irq(pmu, cpu);
|
2020-09-24 19:07:05 +08:00
|
|
|
if (irq)
|
|
|
|
per_cpu(cpu_irq_ops, cpu)->disable_pmuirq(irq);
|
drivers/perf: arm_pmu: split irq request from enable
For historical reasons, we lazily request and free interrupts in the
arm pmu driver. This requires us to refcount use of the pmu (by way of
counting the active events) in order to request/free interrupts at the
correct times, which complicates the driver somewhat.
The existing logic is flawed, as it only considers currently online CPUs
when requesting, freeing, or managing the affinity of interrupts.
Intervening hotplug events can result in erroneous IRQ affinity, online
CPUs for which interrupts have not been requested, or offline CPUs whose
interrupts are still requested.
To fix this, this patch splits the requesting of interrupts from any
per-cpu management (i.e. per-cpu enable/disable, and configuration of
cpu affinity). We now request all interrupts up-front at probe time (and
never free them, since we never unregister PMUs).
The management of affinity, and per-cpu enable/disable now happens in
our cpu hotplug callback, ensuring it occurs consistently. This means
that we must now invoke the CPU hotplug callback at boot time in order
to configure IRQs, and since the callback also resets the PMU hardware,
we can remove the duplicate reset in the probe path.
This rework renders our event refcounting unnecessary, so this is
removed.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[will: make armpmu_get_cpu_irq static]
Signed-off-by: Will Deacon <will.deacon@arm.com>
2017-03-10 18:46:15 +08:00
|
|
|
|
2017-12-13 00:56:06 +08:00
|
|
|
per_cpu(cpu_armpmu, cpu) = NULL;
|
|
|
|
|
2016-07-14 01:16:36 +08:00
|
|
|
return 0;
|
2015-05-27 00:23:39 +08:00
|
|
|
}
|
|
|
|
|
2016-02-24 02:22:39 +08:00
|
|
|
#ifdef CONFIG_CPU_PM
|
|
|
|
static void cpu_pm_pmu_setup(struct arm_pmu *armpmu, unsigned long cmd)
|
|
|
|
{
|
|
|
|
struct pmu_hw_events *hw_events = this_cpu_ptr(armpmu->hw_events);
|
|
|
|
struct perf_event *event;
|
|
|
|
int idx;
|
|
|
|
|
|
|
|
for (idx = 0; idx < armpmu->num_events; idx++) {
|
|
|
|
event = hw_events->events[idx];
|
2018-07-10 16:58:04 +08:00
|
|
|
if (!event)
|
|
|
|
continue;
|
2016-02-24 02:22:39 +08:00
|
|
|
|
|
|
|
switch (cmd) {
|
|
|
|
case CPU_PM_ENTER:
|
|
|
|
/*
|
|
|
|
* Stop and update the counter
|
|
|
|
*/
|
|
|
|
armpmu_stop(event, PERF_EF_UPDATE);
|
|
|
|
break;
|
|
|
|
case CPU_PM_EXIT:
|
|
|
|
case CPU_PM_ENTER_FAILED:
|
2016-04-21 17:24:34 +08:00
|
|
|
/*
|
|
|
|
* Restore and enable the counter.
|
|
|
|
*/
|
2023-01-13 03:44:00 +08:00
|
|
|
armpmu_start(event, PERF_EF_RELOAD);
|
2016-02-24 02:22:39 +08:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int cpu_pm_pmu_notify(struct notifier_block *b, unsigned long cmd,
|
|
|
|
void *v)
|
|
|
|
{
|
|
|
|
struct arm_pmu *armpmu = container_of(b, struct arm_pmu, cpu_pm_nb);
|
|
|
|
struct pmu_hw_events *hw_events = this_cpu_ptr(armpmu->hw_events);
|
2022-02-11 06:48:56 +08:00
|
|
|
bool enabled = !bitmap_empty(hw_events->used_mask, armpmu->num_events);
|
2016-02-24 02:22:39 +08:00
|
|
|
|
|
|
|
if (!cpumask_test_cpu(smp_processor_id(), &armpmu->supported_cpus))
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Always reset the PMU registers on power-up even if
|
|
|
|
* there are no events running.
|
|
|
|
*/
|
|
|
|
if (cmd == CPU_PM_EXIT && armpmu->reset)
|
|
|
|
armpmu->reset(armpmu);
|
|
|
|
|
|
|
|
if (!enabled)
|
|
|
|
return NOTIFY_OK;
|
|
|
|
|
|
|
|
switch (cmd) {
|
|
|
|
case CPU_PM_ENTER:
|
|
|
|
armpmu->stop(armpmu);
|
|
|
|
cpu_pm_pmu_setup(armpmu, cmd);
|
|
|
|
break;
|
|
|
|
case CPU_PM_EXIT:
|
|
|
|
case CPU_PM_ENTER_FAILED:
|
2019-07-29 18:43:48 +08:00
|
|
|
cpu_pm_pmu_setup(armpmu, cmd);
|
2016-02-24 02:22:39 +08:00
|
|
|
armpmu->start(armpmu);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
}
|
|
|
|
|
|
|
|
return NOTIFY_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int cpu_pm_pmu_register(struct arm_pmu *cpu_pmu)
|
|
|
|
{
|
|
|
|
cpu_pmu->cpu_pm_nb.notifier_call = cpu_pm_pmu_notify;
|
|
|
|
return cpu_pm_register_notifier(&cpu_pmu->cpu_pm_nb);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cpu_pm_pmu_unregister(struct arm_pmu *cpu_pmu)
|
|
|
|
{
|
|
|
|
cpu_pm_unregister_notifier(&cpu_pmu->cpu_pm_nb);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static inline int cpu_pm_pmu_register(struct arm_pmu *cpu_pmu) { return 0; }
|
|
|
|
static inline void cpu_pm_pmu_unregister(struct arm_pmu *cpu_pmu) { }
|
|
|
|
#endif
|
|
|
|
|
2015-05-27 00:23:39 +08:00
|
|
|
static int cpu_pmu_init(struct arm_pmu *cpu_pmu)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
|
drivers/perf: arm_pmu: split irq request from enable
For historical reasons, we lazily request and free interrupts in the
arm pmu driver. This requires us to refcount use of the pmu (by way of
counting the active events) in order to request/free interrupts at the
correct times, which complicates the driver somewhat.
The existing logic is flawed, as it only considers currently online CPUs
when requesting, freeing, or managing the affinity of interrupts.
Intervening hotplug events can result in erroneous IRQ affinity, online
CPUs for which interrupts have not been requested, or offline CPUs whose
interrupts are still requested.
To fix this, this patch splits the requesting of interrupts from any
per-cpu management (i.e. per-cpu enable/disable, and configuration of
cpu affinity). We now request all interrupts up-front at probe time (and
never free them, since we never unregister PMUs).
The management of affinity, and per-cpu enable/disable now happens in
our cpu hotplug callback, ensuring it occurs consistently. This means
that we must now invoke the CPU hotplug callback at boot time in order
to configure IRQs, and since the callback also resets the PMU hardware,
we can remove the duplicate reset in the probe path.
This rework renders our event refcounting unnecessary, so this is
removed.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[will: make armpmu_get_cpu_irq static]
Signed-off-by: Will Deacon <will.deacon@arm.com>
2017-03-10 18:46:15 +08:00
|
|
|
err = cpuhp_state_add_instance(CPUHP_AP_PERF_ARM_STARTING,
|
|
|
|
&cpu_pmu->node);
|
2016-08-18 01:14:20 +08:00
|
|
|
if (err)
|
2017-03-10 18:46:13 +08:00
|
|
|
goto out;
|
2015-05-27 00:23:39 +08:00
|
|
|
|
2016-02-24 02:22:39 +08:00
|
|
|
err = cpu_pm_pmu_register(cpu_pmu);
|
|
|
|
if (err)
|
|
|
|
goto out_unregister;
|
|
|
|
|
2015-05-27 00:23:39 +08:00
|
|
|
return 0;
|
|
|
|
|
2016-02-24 02:22:39 +08:00
|
|
|
out_unregister:
|
2016-08-18 01:14:20 +08:00
|
|
|
cpuhp_state_remove_instance_nocalls(CPUHP_AP_PERF_ARM_STARTING,
|
|
|
|
&cpu_pmu->node);
|
2017-03-10 18:46:13 +08:00
|
|
|
out:
|
2015-05-27 00:23:39 +08:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cpu_pmu_destroy(struct arm_pmu *cpu_pmu)
|
|
|
|
{
|
2016-02-24 02:22:39 +08:00
|
|
|
cpu_pm_pmu_unregister(cpu_pmu);
|
2016-08-18 01:14:20 +08:00
|
|
|
cpuhp_state_remove_instance_nocalls(CPUHP_AP_PERF_ARM_STARTING,
|
|
|
|
&cpu_pmu->node);
|
2015-05-27 00:23:39 +08:00
|
|
|
}
|
|
|
|
|
arm_pmu: rework ACPI probing
The current ACPI PMU probing logic tries to associate PMUs with CPUs
when the CPU is first brought online, in order to handle late hotplug,
though PMUs are only registered during early boot, and so for late
hotplugged CPUs this can only associate the CPU with an existing PMU.
We tried to be clever and the have the arm_pmu_acpi_cpu_starting()
callback allocate a struct arm_pmu when no matching instance is found,
in order to avoid duplication of logic. However, as above this doesn't
do anything useful for late hotplugged CPUs, and this requires us to
allocate memory in an atomic context, which is especially problematic
for PREEMPT_RT, as reported by Valentin and Pierre.
This patch reworks the probing to detect PMUs for all online CPUs in the
arm_pmu_acpi_probe() function, which is more aligned with how DT probing
works. The arm_pmu_acpi_cpu_starting() callback only tries to associate
CPUs with an existing arm_pmu instance, avoiding the problem of
allocating in atomic context.
Note that as we didn't previously register PMUs for late-hotplugged
CPUs, this change doesn't result in a loss of existing functionality,
though we will now warn when we cannot associate a CPU with a PMU.
This change allows us to pull the hotplug callback registration into the
arm_pmu_acpi_probe() function, as we no longer need the callbacks to be
invoked shortly after probing the boot CPUs, and can register it without
invoking the calls.
For the moment the arm_pmu_acpi_init() initcall remains to register the
SPE PMU, though in future this should probably be moved elsewhere (e.g.
the arm64 ACPI init code), since this doesn't need to be tied to the
regular CPU PMU code.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reported-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lore.kernel.org/r/20210810134127.1394269-2-valentin.schneider@arm.com/
Reported-by: Pierre Gondois <pierre.gondois@arm.com>
Link: https://lore.kernel.org/linux-arm-kernel/20220912155105.1443303-1-pierre.gondois@arm.com/
Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Valentin Schneider <vschneid@redhat.com>
Cc: Will Deacon <will@kernel.org>
Reviewed-and-tested-by: Pierre Gondois <pierre.gondois@arm.com>
Link: https://lore.kernel.org/r/20220930111844.1522365-4-mark.rutland@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
2022-09-30 19:18:44 +08:00
|
|
|
struct arm_pmu *armpmu_alloc(void)
|
2017-03-10 18:46:13 +08:00
|
|
|
{
|
|
|
|
struct arm_pmu *pmu;
|
|
|
|
int cpu;
|
|
|
|
|
arm_pmu: rework ACPI probing
The current ACPI PMU probing logic tries to associate PMUs with CPUs
when the CPU is first brought online, in order to handle late hotplug,
though PMUs are only registered during early boot, and so for late
hotplugged CPUs this can only associate the CPU with an existing PMU.
We tried to be clever and the have the arm_pmu_acpi_cpu_starting()
callback allocate a struct arm_pmu when no matching instance is found,
in order to avoid duplication of logic. However, as above this doesn't
do anything useful for late hotplugged CPUs, and this requires us to
allocate memory in an atomic context, which is especially problematic
for PREEMPT_RT, as reported by Valentin and Pierre.
This patch reworks the probing to detect PMUs for all online CPUs in the
arm_pmu_acpi_probe() function, which is more aligned with how DT probing
works. The arm_pmu_acpi_cpu_starting() callback only tries to associate
CPUs with an existing arm_pmu instance, avoiding the problem of
allocating in atomic context.
Note that as we didn't previously register PMUs for late-hotplugged
CPUs, this change doesn't result in a loss of existing functionality,
though we will now warn when we cannot associate a CPU with a PMU.
This change allows us to pull the hotplug callback registration into the
arm_pmu_acpi_probe() function, as we no longer need the callbacks to be
invoked shortly after probing the boot CPUs, and can register it without
invoking the calls.
For the moment the arm_pmu_acpi_init() initcall remains to register the
SPE PMU, though in future this should probably be moved elsewhere (e.g.
the arm64 ACPI init code), since this doesn't need to be tied to the
regular CPU PMU code.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reported-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lore.kernel.org/r/20210810134127.1394269-2-valentin.schneider@arm.com/
Reported-by: Pierre Gondois <pierre.gondois@arm.com>
Link: https://lore.kernel.org/linux-arm-kernel/20220912155105.1443303-1-pierre.gondois@arm.com/
Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Valentin Schneider <vschneid@redhat.com>
Cc: Will Deacon <will@kernel.org>
Reviewed-and-tested-by: Pierre Gondois <pierre.gondois@arm.com>
Link: https://lore.kernel.org/r/20220930111844.1522365-4-mark.rutland@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
2022-09-30 19:18:44 +08:00
|
|
|
pmu = kzalloc(sizeof(*pmu), GFP_KERNEL);
|
2021-05-11 20:27:32 +08:00
|
|
|
if (!pmu)
|
2017-03-10 18:46:13 +08:00
|
|
|
goto out;
|
|
|
|
|
arm_pmu: rework ACPI probing
The current ACPI PMU probing logic tries to associate PMUs with CPUs
when the CPU is first brought online, in order to handle late hotplug,
though PMUs are only registered during early boot, and so for late
hotplugged CPUs this can only associate the CPU with an existing PMU.
We tried to be clever and the have the arm_pmu_acpi_cpu_starting()
callback allocate a struct arm_pmu when no matching instance is found,
in order to avoid duplication of logic. However, as above this doesn't
do anything useful for late hotplugged CPUs, and this requires us to
allocate memory in an atomic context, which is especially problematic
for PREEMPT_RT, as reported by Valentin and Pierre.
This patch reworks the probing to detect PMUs for all online CPUs in the
arm_pmu_acpi_probe() function, which is more aligned with how DT probing
works. The arm_pmu_acpi_cpu_starting() callback only tries to associate
CPUs with an existing arm_pmu instance, avoiding the problem of
allocating in atomic context.
Note that as we didn't previously register PMUs for late-hotplugged
CPUs, this change doesn't result in a loss of existing functionality,
though we will now warn when we cannot associate a CPU with a PMU.
This change allows us to pull the hotplug callback registration into the
arm_pmu_acpi_probe() function, as we no longer need the callbacks to be
invoked shortly after probing the boot CPUs, and can register it without
invoking the calls.
For the moment the arm_pmu_acpi_init() initcall remains to register the
SPE PMU, though in future this should probably be moved elsewhere (e.g.
the arm64 ACPI init code), since this doesn't need to be tied to the
regular CPU PMU code.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reported-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lore.kernel.org/r/20210810134127.1394269-2-valentin.schneider@arm.com/
Reported-by: Pierre Gondois <pierre.gondois@arm.com>
Link: https://lore.kernel.org/linux-arm-kernel/20220912155105.1443303-1-pierre.gondois@arm.com/
Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Valentin Schneider <vschneid@redhat.com>
Cc: Will Deacon <will@kernel.org>
Reviewed-and-tested-by: Pierre Gondois <pierre.gondois@arm.com>
Link: https://lore.kernel.org/r/20220930111844.1522365-4-mark.rutland@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
2022-09-30 19:18:44 +08:00
|
|
|
pmu->hw_events = alloc_percpu_gfp(struct pmu_hw_events, GFP_KERNEL);
|
2017-03-10 18:46:13 +08:00
|
|
|
if (!pmu->hw_events) {
|
|
|
|
pr_info("failed to allocate per-cpu PMU data.\n");
|
|
|
|
goto out_free_pmu;
|
|
|
|
}
|
|
|
|
|
2017-04-11 16:39:46 +08:00
|
|
|
pmu->pmu = (struct pmu) {
|
|
|
|
.pmu_enable = armpmu_enable,
|
|
|
|
.pmu_disable = armpmu_disable,
|
|
|
|
.event_init = armpmu_event_init,
|
|
|
|
.add = armpmu_add,
|
|
|
|
.del = armpmu_del,
|
|
|
|
.start = armpmu_start,
|
|
|
|
.stop = armpmu_stop,
|
|
|
|
.read = armpmu_read,
|
perf: Rewrite core context handling
There have been various issues and limitations with the way perf uses
(task) contexts to track events. Most notable is the single hardware
PMU task context, which has resulted in a number of yucky things (both
proposed and merged).
Notably:
- HW breakpoint PMU
- ARM big.little PMU / Intel ADL PMU
- Intel Branch Monitoring PMU
- AMD IBS PMU
- S390 cpum_cf PMU
- PowerPC trace_imc PMU
*Current design:*
Currently we have a per task and per cpu perf_event_contexts:
task_struct::perf_events_ctxp[] <-> perf_event_context <-> perf_cpu_context
^ | ^ | ^
`---------------------------------' | `--> pmu ---'
v ^
perf_event ------'
Each task has an array of pointers to a perf_event_context. Each
perf_event_context has a direct relation to a PMU and a group of
events for that PMU. The task related perf_event_context's have a
pointer back to that task.
Each PMU has a per-cpu pointer to a per-cpu perf_cpu_context, which
includes a perf_event_context, which again has a direct relation to
that PMU, and a group of events for that PMU.
The perf_cpu_context also tracks which task context is currently
associated with that CPU and includes a few other things like the
hrtimer for rotation etc.
Each perf_event is then associated with its PMU and one
perf_event_context.
*Proposed design:*
New design proposed by this patch reduce to a single task context and
a single CPU context but adds some intermediate data-structures:
task_struct::perf_event_ctxp -> perf_event_context <- perf_cpu_context
^ | ^ ^
`---------------------------' | |
| | perf_cpu_pmu_context <--.
| `----. ^ |
| | | |
| v v |
| ,--> perf_event_pmu_context |
| | |
| | |
v v |
perf_event ---> pmu ----------------'
With the new design, perf_event_context will hold all events for all
pmus in the (respective pinned/flexible) rbtrees. This can be achieved
by adding pmu to rbtree key:
{cpu, pmu, cgroup, group_index}
Each perf_event_context carries a list of perf_event_pmu_context which
is used to hold per-pmu-per-context state. For example, it keeps track
of currently active events for that pmu, a pmu specific task_ctx_data,
a flag to tell whether rotation is required or not etc.
Additionally, perf_cpu_pmu_context is used to hold per-pmu-per-cpu
state like hrtimer details to drive the event rotation, a pointer to
perf_event_pmu_context of currently running task and some other
ancillary information.
Each perf_event is associated to it's pmu, perf_event_context and
perf_event_pmu_context.
Further optimizations to current implementation are possible. For
example, ctx_resched() can be optimized to reschedule only single pmu
events.
Much thanks to Ravi for picking this up and pushing it towards
completion.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Co-developed-by: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20221008062424.313-1-ravi.bangoria@amd.com
2022-10-08 14:24:24 +08:00
|
|
|
.filter = armpmu_filter,
|
2017-04-11 16:39:46 +08:00
|
|
|
.attr_groups = pmu->attr_groups,
|
|
|
|
/*
|
|
|
|
* This is a CPU PMU potentially in a heterogeneous
|
2023-07-24 21:44:58 +08:00
|
|
|
* configuration (e.g. big.LITTLE) so
|
2023-07-24 21:44:56 +08:00
|
|
|
* PERF_PMU_CAP_EXTENDED_HW_TYPE is required to open
|
|
|
|
* PERF_TYPE_HARDWARE and PERF_TYPE_HW_CACHE events on a
|
|
|
|
* specific PMU.
|
2017-04-11 16:39:46 +08:00
|
|
|
*/
|
2023-07-24 21:44:58 +08:00
|
|
|
.capabilities = PERF_PMU_CAP_EXTENDED_REGS |
|
2023-07-24 21:44:56 +08:00
|
|
|
PERF_PMU_CAP_EXTENDED_HW_TYPE,
|
2017-04-11 16:39:46 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
pmu->attr_groups[ARMPMU_ATTR_GROUP_COMMON] =
|
|
|
|
&armpmu_common_attr_group;
|
|
|
|
|
2017-03-10 18:46:13 +08:00
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
struct pmu_hw_events *events;
|
|
|
|
|
|
|
|
events = per_cpu_ptr(pmu->hw_events, cpu);
|
|
|
|
events->percpu_pmu = pmu;
|
|
|
|
}
|
|
|
|
|
|
|
|
return pmu;
|
|
|
|
|
|
|
|
out_free_pmu:
|
|
|
|
kfree(pmu);
|
|
|
|
out:
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2017-04-11 16:39:53 +08:00
|
|
|
void armpmu_free(struct arm_pmu *pmu)
|
2017-03-10 18:46:13 +08:00
|
|
|
{
|
|
|
|
free_percpu(pmu->hw_events);
|
|
|
|
kfree(pmu);
|
|
|
|
}
|
|
|
|
|
2017-04-11 16:39:47 +08:00
|
|
|
int armpmu_register(struct arm_pmu *pmu)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = cpu_pmu_init(pmu);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2019-01-10 21:53:27 +08:00
|
|
|
if (!pmu->set_event_filter)
|
|
|
|
pmu->pmu.capabilities |= PERF_PMU_CAP_NO_EXCLUDE;
|
|
|
|
|
2017-04-11 16:39:47 +08:00
|
|
|
ret = perf_pmu_register(&pmu->pmu, pmu->name, -1);
|
|
|
|
if (ret)
|
|
|
|
goto out_destroy;
|
|
|
|
|
2020-09-24 19:07:06 +08:00
|
|
|
pr_info("enabled with %s PMU driver, %d counters available%s\n",
|
|
|
|
pmu->name, pmu->num_events,
|
|
|
|
has_nmi ? ", using NMIs" : "");
|
2017-04-11 16:39:47 +08:00
|
|
|
|
2021-09-19 21:09:49 +08:00
|
|
|
kvm_host_pmu_init(pmu);
|
|
|
|
|
2017-04-11 16:39:47 +08:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_destroy:
|
|
|
|
cpu_pmu_destroy(pmu);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-07-20 15:51:11 +08:00
|
|
|
static int arm_pmu_hp_init(void)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
2016-08-18 01:14:20 +08:00
|
|
|
ret = cpuhp_setup_state_multi(CPUHP_AP_PERF_ARM_STARTING,
|
2016-12-22 03:19:54 +08:00
|
|
|
"perf/arm/pmu:starting",
|
drivers/perf: arm_pmu: split irq request from enable
For historical reasons, we lazily request and free interrupts in the
arm pmu driver. This requires us to refcount use of the pmu (by way of
counting the active events) in order to request/free interrupts at the
correct times, which complicates the driver somewhat.
The existing logic is flawed, as it only considers currently online CPUs
when requesting, freeing, or managing the affinity of interrupts.
Intervening hotplug events can result in erroneous IRQ affinity, online
CPUs for which interrupts have not been requested, or offline CPUs whose
interrupts are still requested.
To fix this, this patch splits the requesting of interrupts from any
per-cpu management (i.e. per-cpu enable/disable, and configuration of
cpu affinity). We now request all interrupts up-front at probe time (and
never free them, since we never unregister PMUs).
The management of affinity, and per-cpu enable/disable now happens in
our cpu hotplug callback, ensuring it occurs consistently. This means
that we must now invoke the CPU hotplug callback at boot time in order
to configure IRQs, and since the callback also resets the PMU hardware,
we can remove the duplicate reset in the probe path.
This rework renders our event refcounting unnecessary, so this is
removed.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
[will: make armpmu_get_cpu_irq static]
Signed-off-by: Will Deacon <will.deacon@arm.com>
2017-03-10 18:46:15 +08:00
|
|
|
arm_perf_starting_cpu,
|
|
|
|
arm_perf_teardown_cpu);
|
2016-07-20 15:51:11 +08:00
|
|
|
if (ret)
|
|
|
|
pr_err("CPU hotplug notifier for ARM PMU could not be registered: %d\n",
|
|
|
|
ret);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
subsys_initcall(arm_pmu_hp_init);
|