2019-07-23 00:26:22 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
/*
|
2020-11-14 05:19:15 +08:00
|
|
|
* Opening fs-verity files
|
2019-07-23 00:26:22 +08:00
|
|
|
*
|
|
|
|
* Copyright 2019 Google LLC
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "fsverity_private.h"
|
|
|
|
|
|
|
|
#include <linux/slab.h>
|
|
|
|
|
|
|
|
static struct kmem_cache *fsverity_info_cachep;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* fsverity_init_merkle_tree_params() - initialize Merkle tree parameters
|
|
|
|
* @params: the parameters struct to initialize
|
|
|
|
* @inode: the inode for which the Merkle tree is being built
|
|
|
|
* @hash_algorithm: number of hash algorithm to use
|
|
|
|
* @log_blocksize: log base 2 of block size to use
|
|
|
|
* @salt: pointer to salt (optional)
|
|
|
|
* @salt_size: size of salt, possibly 0
|
|
|
|
*
|
|
|
|
* Validate the hash algorithm and block size, then compute the tree topology
|
|
|
|
* (num levels, num blocks in each level, etc.) and initialize @params.
|
|
|
|
*
|
|
|
|
* Return: 0 on success, -errno on failure
|
|
|
|
*/
|
|
|
|
int fsverity_init_merkle_tree_params(struct merkle_tree_params *params,
|
|
|
|
const struct inode *inode,
|
|
|
|
unsigned int hash_algorithm,
|
|
|
|
unsigned int log_blocksize,
|
|
|
|
const u8 *salt, size_t salt_size)
|
|
|
|
{
|
2020-01-01 01:55:45 +08:00
|
|
|
struct fsverity_hash_alg *hash_alg;
|
2019-07-23 00:26:22 +08:00
|
|
|
int err;
|
|
|
|
u64 blocks;
|
|
|
|
u64 offset;
|
|
|
|
int level;
|
|
|
|
|
|
|
|
memset(params, 0, sizeof(*params));
|
|
|
|
|
|
|
|
hash_alg = fsverity_get_hash_alg(inode, hash_algorithm);
|
|
|
|
if (IS_ERR(hash_alg))
|
|
|
|
return PTR_ERR(hash_alg);
|
|
|
|
params->hash_alg = hash_alg;
|
|
|
|
params->digest_size = hash_alg->digest_size;
|
|
|
|
|
|
|
|
params->hashstate = fsverity_prepare_hash_state(hash_alg, salt,
|
|
|
|
salt_size);
|
|
|
|
if (IS_ERR(params->hashstate)) {
|
|
|
|
err = PTR_ERR(params->hashstate);
|
|
|
|
params->hashstate = NULL;
|
|
|
|
fsverity_err(inode, "Error %d preparing hash state", err);
|
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (log_blocksize != PAGE_SHIFT) {
|
|
|
|
fsverity_warn(inode, "Unsupported log_blocksize: %u",
|
|
|
|
log_blocksize);
|
|
|
|
err = -EINVAL;
|
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
params->log_blocksize = log_blocksize;
|
|
|
|
params->block_size = 1 << log_blocksize;
|
|
|
|
|
|
|
|
if (WARN_ON(!is_power_of_2(params->digest_size))) {
|
|
|
|
err = -EINVAL;
|
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
if (params->block_size < 2 * params->digest_size) {
|
|
|
|
fsverity_warn(inode,
|
|
|
|
"Merkle tree block size (%u) too small for hash algorithm \"%s\"",
|
|
|
|
params->block_size, hash_alg->name);
|
|
|
|
err = -EINVAL;
|
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
params->log_arity = params->log_blocksize - ilog2(params->digest_size);
|
|
|
|
params->hashes_per_block = 1 << params->log_arity;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Compute the number of levels in the Merkle tree and create a map from
|
|
|
|
* level to the starting block of that level. Level 'num_levels - 1' is
|
|
|
|
* the root and is stored first. Level 0 is the level directly "above"
|
|
|
|
* the data blocks and is stored last.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* Compute number of levels and the number of blocks in each level */
|
2021-09-17 04:34:24 +08:00
|
|
|
blocks = ((u64)inode->i_size + params->block_size - 1) >> log_blocksize;
|
2019-07-23 00:26:22 +08:00
|
|
|
while (blocks > 1) {
|
|
|
|
if (params->num_levels >= FS_VERITY_MAX_LEVELS) {
|
|
|
|
fsverity_err(inode, "Too many levels in Merkle tree");
|
|
|
|
err = -EINVAL;
|
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
blocks = (blocks + params->hashes_per_block - 1) >>
|
|
|
|
params->log_arity;
|
|
|
|
/* temporarily using level_start[] to store blocks in level */
|
|
|
|
params->level_start[params->num_levels++] = blocks;
|
|
|
|
}
|
fs-verity: implement readahead of Merkle tree pages
When fs-verity verifies data pages, currently it reads each Merkle tree
page synchronously using read_mapping_page().
Therefore, when the Merkle tree pages aren't already cached, fs-verity
causes an extra 4 KiB I/O request for every 512 KiB of data (assuming
that the Merkle tree uses SHA-256 and 4 KiB blocks). This results in
more I/O requests and performance loss than is strictly necessary.
Therefore, implement readahead of the Merkle tree pages.
For simplicity, we take advantage of the fact that the kernel already
does readahead of the file's *data*, just like it does for any other
file. Due to this, we don't really need a separate readahead state
(struct file_ra_state) just for the Merkle tree, but rather we just need
to piggy-back on the existing data readahead requests.
We also only really need to bother with the first level of the Merkle
tree, since the usual fan-out factor is 128, so normally over 99% of
Merkle tree I/O requests are for the first level.
Therefore, make fsverity_verify_bio() enable readahead of the first
Merkle tree level, for up to 1/4 the number of pages in the bio, when it
sees that the REQ_RAHEAD flag is set on the bio. The readahead size is
then passed down to ->read_merkle_tree_page() for the filesystem to
(optionally) implement if it sees that the requested page is uncached.
While we're at it, also make build_merkle_tree_level() set the Merkle
tree readahead size, since it's easy to do there.
However, for now don't set the readahead size in fsverity_verify_page(),
since currently it's only used to verify holes on ext4 and f2fs, and it
would need parameters added to know how much to read ahead.
This patch significantly improves fs-verity sequential read performance.
Some quick benchmarks with 'cat'-ing a 250MB file after dropping caches:
On an ARM64 phone (using sha256-ce):
Before: 217 MB/s
After: 263 MB/s
(compare to sha256sum of non-verity file: 357 MB/s)
In an x86_64 VM (using sha256-avx2):
Before: 173 MB/s
After: 215 MB/s
(compare to sha256sum of non-verity file: 223 MB/s)
Link: https://lore.kernel.org/r/20200106205533.137005-1-ebiggers@kernel.org
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Eric Biggers <ebiggers@google.com>
2020-01-07 04:55:33 +08:00
|
|
|
params->level0_blocks = params->level_start[0];
|
2019-07-23 00:26:22 +08:00
|
|
|
|
|
|
|
/* Compute the starting block of each level */
|
|
|
|
offset = 0;
|
|
|
|
for (level = (int)params->num_levels - 1; level >= 0; level--) {
|
|
|
|
blocks = params->level_start[level];
|
|
|
|
params->level_start[level] = offset;
|
|
|
|
offset += blocks;
|
|
|
|
}
|
|
|
|
|
|
|
|
params->tree_size = offset << log_blocksize;
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
out_err:
|
|
|
|
kfree(params->hashstate);
|
|
|
|
memset(params, 0, sizeof(*params));
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2019-07-23 00:26:23 +08:00
|
|
|
/*
|
2020-11-14 05:19:17 +08:00
|
|
|
* Compute the file digest by hashing the fsverity_descriptor excluding the
|
2019-07-23 00:26:23 +08:00
|
|
|
* signature and with the sig_size field set to 0.
|
|
|
|
*/
|
2020-11-14 05:19:17 +08:00
|
|
|
static int compute_file_digest(struct fsverity_hash_alg *hash_alg,
|
|
|
|
struct fsverity_descriptor *desc,
|
|
|
|
u8 *file_digest)
|
2019-07-23 00:26:22 +08:00
|
|
|
{
|
2019-07-23 00:26:23 +08:00
|
|
|
__le32 sig_size = desc->sig_size;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
desc->sig_size = 0;
|
2020-11-14 05:19:17 +08:00
|
|
|
err = fsverity_hash_buffer(hash_alg, desc, sizeof(*desc), file_digest);
|
2019-07-23 00:26:23 +08:00
|
|
|
desc->sig_size = sig_size;
|
|
|
|
|
|
|
|
return err;
|
2019-07-23 00:26:22 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2021-01-16 02:18:14 +08:00
|
|
|
* Create a new fsverity_info from the given fsverity_descriptor (with optional
|
|
|
|
* appended signature), and check the signature if present. The
|
|
|
|
* fsverity_descriptor must have already undergone basic validation.
|
2019-07-23 00:26:22 +08:00
|
|
|
*/
|
|
|
|
struct fsverity_info *fsverity_create_info(const struct inode *inode,
|
2022-05-18 21:22:56 +08:00
|
|
|
struct fsverity_descriptor *desc)
|
2019-07-23 00:26:22 +08:00
|
|
|
{
|
|
|
|
struct fsverity_info *vi;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
vi = kmem_cache_zalloc(fsverity_info_cachep, GFP_KERNEL);
|
|
|
|
if (!vi)
|
|
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
vi->inode = inode;
|
|
|
|
|
|
|
|
err = fsverity_init_merkle_tree_params(&vi->tree_params, inode,
|
|
|
|
desc->hash_algorithm,
|
|
|
|
desc->log_blocksize,
|
|
|
|
desc->salt, desc->salt_size);
|
|
|
|
if (err) {
|
|
|
|
fsverity_err(inode,
|
|
|
|
"Error %d initializing Merkle tree parameters",
|
|
|
|
err);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
memcpy(vi->root_hash, desc->root_hash, vi->tree_params.digest_size);
|
|
|
|
|
2020-11-14 05:19:17 +08:00
|
|
|
err = compute_file_digest(vi->tree_params.hash_alg, desc,
|
|
|
|
vi->file_digest);
|
2019-07-23 00:26:22 +08:00
|
|
|
if (err) {
|
2020-11-14 05:19:17 +08:00
|
|
|
fsverity_err(inode, "Error %d computing file digest", err);
|
2019-07-23 00:26:22 +08:00
|
|
|
goto out;
|
|
|
|
}
|
2019-07-23 00:26:23 +08:00
|
|
|
|
2021-01-16 02:18:15 +08:00
|
|
|
err = fsverity_verify_signature(vi, desc->signature,
|
|
|
|
le32_to_cpu(desc->sig_size));
|
2019-07-23 00:26:22 +08:00
|
|
|
out:
|
|
|
|
if (err) {
|
|
|
|
fsverity_free_info(vi);
|
|
|
|
vi = ERR_PTR(err);
|
|
|
|
}
|
|
|
|
return vi;
|
|
|
|
}
|
|
|
|
|
|
|
|
void fsverity_set_info(struct inode *inode, struct fsverity_info *vi)
|
|
|
|
{
|
|
|
|
/*
|
2020-07-22 06:59:20 +08:00
|
|
|
* Multiple tasks may race to set ->i_verity_info, so use
|
|
|
|
* cmpxchg_release(). This pairs with the smp_load_acquire() in
|
|
|
|
* fsverity_get_info(). I.e., here we publish ->i_verity_info with a
|
|
|
|
* RELEASE barrier so that other tasks can ACQUIRE it.
|
2019-07-23 00:26:22 +08:00
|
|
|
*/
|
2020-07-22 06:59:20 +08:00
|
|
|
if (cmpxchg_release(&inode->i_verity_info, NULL, vi) != NULL) {
|
|
|
|
/* Lost the race, so free the fsverity_info we allocated. */
|
2019-07-23 00:26:22 +08:00
|
|
|
fsverity_free_info(vi);
|
2020-07-22 06:59:20 +08:00
|
|
|
/*
|
|
|
|
* Afterwards, the caller may access ->i_verity_info directly,
|
|
|
|
* so make sure to ACQUIRE the winning fsverity_info.
|
|
|
|
*/
|
|
|
|
(void)fsverity_get_info(inode);
|
|
|
|
}
|
2019-07-23 00:26:22 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void fsverity_free_info(struct fsverity_info *vi)
|
|
|
|
{
|
|
|
|
if (!vi)
|
|
|
|
return;
|
|
|
|
kfree(vi->tree_params.hashstate);
|
|
|
|
kmem_cache_free(fsverity_info_cachep, vi);
|
|
|
|
}
|
|
|
|
|
2021-01-16 02:18:14 +08:00
|
|
|
static bool validate_fsverity_descriptor(struct inode *inode,
|
|
|
|
const struct fsverity_descriptor *desc,
|
|
|
|
size_t desc_size)
|
2019-07-23 00:26:22 +08:00
|
|
|
{
|
2021-01-16 02:18:14 +08:00
|
|
|
if (desc_size < sizeof(*desc)) {
|
|
|
|
fsverity_err(inode, "Unrecognized descriptor size: %zu bytes",
|
|
|
|
desc_size);
|
|
|
|
return false;
|
|
|
|
}
|
2019-07-23 00:26:22 +08:00
|
|
|
|
2021-01-16 02:18:14 +08:00
|
|
|
if (desc->version != 1) {
|
|
|
|
fsverity_err(inode, "Unrecognized descriptor version: %u",
|
|
|
|
desc->version);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (memchr_inv(desc->__reserved, 0, sizeof(desc->__reserved))) {
|
|
|
|
fsverity_err(inode, "Reserved bits set in descriptor");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (desc->salt_size > sizeof(desc->salt)) {
|
|
|
|
fsverity_err(inode, "Invalid salt_size: %u", desc->salt_size);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (le64_to_cpu(desc->data_size) != inode->i_size) {
|
|
|
|
fsverity_err(inode,
|
|
|
|
"Wrong data_size: %llu (desc) != %lld (inode)",
|
|
|
|
le64_to_cpu(desc->data_size), inode->i_size);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (le32_to_cpu(desc->sig_size) > desc_size - sizeof(*desc)) {
|
|
|
|
fsverity_err(inode, "Signature overflows verity descriptor");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Read the inode's fsverity_descriptor (with optional appended signature) from
|
|
|
|
* the filesystem, and do basic validation of it.
|
|
|
|
*/
|
|
|
|
int fsverity_get_descriptor(struct inode *inode,
|
2022-05-18 21:22:56 +08:00
|
|
|
struct fsverity_descriptor **desc_ret)
|
2021-01-16 02:18:14 +08:00
|
|
|
{
|
|
|
|
int res;
|
|
|
|
struct fsverity_descriptor *desc;
|
2019-07-23 00:26:22 +08:00
|
|
|
|
|
|
|
res = inode->i_sb->s_vop->get_verity_descriptor(inode, NULL, 0);
|
|
|
|
if (res < 0) {
|
|
|
|
fsverity_err(inode,
|
|
|
|
"Error %d getting verity descriptor size", res);
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
if (res > FS_VERITY_MAX_DESCRIPTOR_SIZE) {
|
|
|
|
fsverity_err(inode, "Verity descriptor is too large (%d bytes)",
|
|
|
|
res);
|
|
|
|
return -EMSGSIZE;
|
|
|
|
}
|
|
|
|
desc = kmalloc(res, GFP_KERNEL);
|
|
|
|
if (!desc)
|
|
|
|
return -ENOMEM;
|
|
|
|
res = inode->i_sb->s_vop->get_verity_descriptor(inode, desc, res);
|
|
|
|
if (res < 0) {
|
|
|
|
fsverity_err(inode, "Error %d reading verity descriptor", res);
|
2021-01-16 02:18:14 +08:00
|
|
|
kfree(desc);
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!validate_fsverity_descriptor(inode, desc, res)) {
|
|
|
|
kfree(desc);
|
|
|
|
return -EINVAL;
|
2019-07-23 00:26:22 +08:00
|
|
|
}
|
|
|
|
|
2021-01-16 02:18:14 +08:00
|
|
|
*desc_ret = desc;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Ensure the inode has an ->i_verity_info */
|
|
|
|
static int ensure_verity_info(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct fsverity_info *vi = fsverity_get_info(inode);
|
|
|
|
struct fsverity_descriptor *desc;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
if (vi)
|
|
|
|
return 0;
|
|
|
|
|
2022-05-18 21:22:56 +08:00
|
|
|
err = fsverity_get_descriptor(inode, &desc);
|
2021-01-16 02:18:14 +08:00
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
2022-05-18 21:22:56 +08:00
|
|
|
vi = fsverity_create_info(inode, desc);
|
2019-07-23 00:26:22 +08:00
|
|
|
if (IS_ERR(vi)) {
|
2021-01-16 02:18:14 +08:00
|
|
|
err = PTR_ERR(vi);
|
2019-07-23 00:26:22 +08:00
|
|
|
goto out_free_desc;
|
|
|
|
}
|
|
|
|
|
|
|
|
fsverity_set_info(inode, vi);
|
2021-01-16 02:18:14 +08:00
|
|
|
err = 0;
|
2019-07-23 00:26:22 +08:00
|
|
|
out_free_desc:
|
|
|
|
kfree(desc);
|
2021-01-16 02:18:14 +08:00
|
|
|
return err;
|
2019-07-23 00:26:22 +08:00
|
|
|
}
|
|
|
|
|
2022-12-15 06:43:01 +08:00
|
|
|
int __fsverity_file_open(struct inode *inode, struct file *filp)
|
2019-07-23 00:26:22 +08:00
|
|
|
{
|
2022-12-15 14:04:20 +08:00
|
|
|
if (filp->f_mode & FMODE_WRITE)
|
2019-07-23 00:26:22 +08:00
|
|
|
return -EPERM;
|
|
|
|
return ensure_verity_info(inode);
|
|
|
|
}
|
2022-12-15 06:43:01 +08:00
|
|
|
EXPORT_SYMBOL_GPL(__fsverity_file_open);
|
2019-07-23 00:26:22 +08:00
|
|
|
|
2022-12-15 06:43:02 +08:00
|
|
|
int __fsverity_prepare_setattr(struct dentry *dentry, struct iattr *attr)
|
2019-07-23 00:26:22 +08:00
|
|
|
{
|
2022-12-15 14:04:20 +08:00
|
|
|
if (attr->ia_valid & ATTR_SIZE)
|
2019-07-23 00:26:22 +08:00
|
|
|
return -EPERM;
|
|
|
|
return 0;
|
|
|
|
}
|
2022-12-15 06:43:02 +08:00
|
|
|
EXPORT_SYMBOL_GPL(__fsverity_prepare_setattr);
|
2019-07-23 00:26:22 +08:00
|
|
|
|
2022-12-15 06:43:03 +08:00
|
|
|
void __fsverity_cleanup_inode(struct inode *inode)
|
2019-07-23 00:26:22 +08:00
|
|
|
{
|
|
|
|
fsverity_free_info(inode->i_verity_info);
|
|
|
|
inode->i_verity_info = NULL;
|
|
|
|
}
|
2022-12-15 06:43:03 +08:00
|
|
|
EXPORT_SYMBOL_GPL(__fsverity_cleanup_inode);
|
2019-07-23 00:26:22 +08:00
|
|
|
|
|
|
|
int __init fsverity_init_info_cache(void)
|
|
|
|
{
|
|
|
|
fsverity_info_cachep = KMEM_CACHE_USERCOPY(fsverity_info,
|
|
|
|
SLAB_RECLAIM_ACCOUNT,
|
2020-11-14 05:19:17 +08:00
|
|
|
file_digest);
|
2019-07-23 00:26:22 +08:00
|
|
|
if (!fsverity_info_cachep)
|
|
|
|
return -ENOMEM;
|
|
|
|
return 0;
|
|
|
|
}
|
2019-07-23 00:26:22 +08:00
|
|
|
|
|
|
|
void __init fsverity_exit_info_cache(void)
|
|
|
|
{
|
|
|
|
kmem_cache_destroy(fsverity_info_cachep);
|
|
|
|
fsverity_info_cachep = NULL;
|
|
|
|
}
|