2005-04-17 06:20:36 +08:00
|
|
|
/* Postprocess module symbol versions
|
|
|
|
*
|
|
|
|
* Copyright 2003 Kai Germaschewski
|
|
|
|
* Copyright 2002-2004 Rusty Russell, IBM Corporation
|
2008-01-12 02:17:15 +08:00
|
|
|
* Copyright 2006-2008 Sam Ravnborg
|
2005-04-17 06:20:36 +08:00
|
|
|
* Based in part on module-init-tools/depmod.c,file2alias
|
|
|
|
*
|
|
|
|
* This software may be used and distributed according to the terms
|
|
|
|
* of the GNU General Public License, incorporated herein by reference.
|
|
|
|
*
|
|
|
|
* Usage: modpost vmlinux module1.o module2.o ...
|
|
|
|
*/
|
|
|
|
|
2008-02-14 07:03:39 +08:00
|
|
|
#define _GNU_SOURCE
|
2020-01-04 23:36:51 +08:00
|
|
|
#include <elf.h>
|
2022-05-30 17:01:39 +08:00
|
|
|
#include <fnmatch.h>
|
2008-02-14 07:03:39 +08:00
|
|
|
#include <stdio.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
#include <ctype.h>
|
2010-08-11 15:42:26 +08:00
|
|
|
#include <string.h>
|
2013-04-04 15:07:38 +08:00
|
|
|
#include <limits.h>
|
2021-08-28 17:50:59 +08:00
|
|
|
#include <stdbool.h>
|
2013-09-23 13:53:54 +08:00
|
|
|
#include <errno.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
#include "modpost.h"
|
2006-06-10 03:53:55 +08:00
|
|
|
#include "../../include/linux/license.h"
|
2009-11-08 05:03:54 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/* Are we using CONFIG_MODVERSIONS? */
|
2022-05-01 16:40:07 +08:00
|
|
|
static bool modversions;
|
2005-04-17 06:20:36 +08:00
|
|
|
/* Is CONFIG_MODULE_SRCVERSION_ALL set? */
|
2022-05-01 16:40:07 +08:00
|
|
|
static bool all_versions;
|
2006-01-29 05:15:55 +08:00
|
|
|
/* If we are modposting external module set to 1 */
|
2022-05-01 16:40:07 +08:00
|
|
|
static bool external_module;
|
2006-09-08 04:08:54 +08:00
|
|
|
/* Only warn about unresolved symbols */
|
2022-05-01 16:40:07 +08:00
|
|
|
static bool warn_unresolved;
|
2022-05-09 03:06:19 +08:00
|
|
|
|
2022-04-05 19:33:53 +08:00
|
|
|
static int sec_mismatch_count;
|
2022-05-01 16:40:07 +08:00
|
|
|
static bool sec_mismatch_warn_only = true;
|
2013-09-23 13:53:54 +08:00
|
|
|
/* ignore missing files */
|
2022-05-01 16:40:07 +08:00
|
|
|
static bool ignore_missing_files;
|
2020-03-07 00:02:06 +08:00
|
|
|
/* If set to 1, only warn (instead of error) about missing ns imports */
|
2022-05-01 16:40:07 +08:00
|
|
|
static bool allow_missing_ns_imports;
|
2008-01-25 04:12:37 +08:00
|
|
|
|
2020-12-01 18:34:15 +08:00
|
|
|
static bool error_occurred;
|
|
|
|
|
kbuild: fix false-positive modpost warning when all symbols are trimmed
Nathan reports that the mips defconfig emits the following warning:
WARNING: modpost: Symbol info of vmlinux is missing. Unresolved symbol check will be entirely skipped.
This false-positive happens when CONFIG_TRIM_UNUSED_KSYMS is enabled,
but no CONFIG option is set to 'm'.
Commit a0590473c5e6 ("nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default")
turned the last 'm' into 'y' for the mips defconfig, and uncovered
this issue.
In this case, the module feature itself is enabled, but we have no
module to build. As a result, CONFIG_TRIM_UNUSED_KSYMS drops all the
instances of EXPORT_SYMBOL. Then, modpost wrongly assumes vmlinux is
missing because vmlinux.symvers is empty. (As another false-positive
case, you can create a module that does not use any symbol of vmlinux).
The current behavior is to entirely suppress the unresolved symbol
warnings when vmlinux is missing just because there are too many.
I found the origin of this code in the historical git tree. [1]
If this is a matter of noisiness, I think modpost can display the
first 10 warnings, and the number of suppressed warnings at the end.
You will get a bit noisier logs when you run 'make modules' without
vmlinux, but such warnings are better to show because you never know
the resulting modules are actually loadable or not.
This commit changes the following:
- If any of input *.symver files is missing, pass -w option to let
the module build keep going with warnings instead of errors.
- If there are too many (10+) unresolved symbol warnings, show only
the first 10, and also the number of suppressed warnings.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=1cc0e0529569bf6a94f6d49770aa6d4b599d2c46
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2021-03-26 02:54:11 +08:00
|
|
|
/*
|
|
|
|
* Cut off the warnings when there are too many. This typically occurs when
|
|
|
|
* vmlinux is missing. ('make modules' without building vmlinux.)
|
|
|
|
*/
|
|
|
|
#define MAX_UNRESOLVED_REPORTS 10
|
|
|
|
static unsigned int nr_unresolved;
|
|
|
|
|
2017-06-30 22:07:03 +08:00
|
|
|
/* In kernel, this size is defined in linux/module.h;
|
|
|
|
* here we use Elf_Addr instead of long for covering cross-compile
|
|
|
|
*/
|
|
|
|
|
|
|
|
#define MODULE_NAME_LEN (64 - sizeof(Elf_Addr))
|
|
|
|
|
2020-03-07 00:02:05 +08:00
|
|
|
void __attribute__((format(printf, 2, 3)))
|
|
|
|
modpost_log(enum loglevel loglevel, const char *fmt, ...)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
va_list arglist;
|
|
|
|
|
2020-03-07 00:02:05 +08:00
|
|
|
switch (loglevel) {
|
|
|
|
case LOG_WARN:
|
|
|
|
fprintf(stderr, "WARNING: ");
|
|
|
|
break;
|
|
|
|
case LOG_ERROR:
|
|
|
|
fprintf(stderr, "ERROR: ");
|
|
|
|
break;
|
|
|
|
case LOG_FATAL:
|
|
|
|
fprintf(stderr, "FATAL: ");
|
|
|
|
break;
|
|
|
|
default: /* invalid loglevel, ignore */
|
|
|
|
break;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-03-07 00:02:05 +08:00
|
|
|
fprintf(stderr, "modpost: ");
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
va_start(arglist, fmt);
|
|
|
|
vfprintf(stderr, fmt, arglist);
|
|
|
|
va_end(arglist);
|
2006-10-07 19:35:32 +08:00
|
|
|
|
2020-03-07 00:02:05 +08:00
|
|
|
if (loglevel == LOG_FATAL)
|
|
|
|
exit(1);
|
2020-12-01 18:34:15 +08:00
|
|
|
if (loglevel == LOG_ERROR)
|
|
|
|
error_occurred = true;
|
2006-10-07 19:35:32 +08:00
|
|
|
}
|
|
|
|
|
2021-08-28 17:50:59 +08:00
|
|
|
static inline bool strends(const char *str, const char *postfix)
|
|
|
|
{
|
|
|
|
if (strlen(str) < strlen(postfix))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return strcmp(str + strlen(str) - strlen(postfix), postfix) == 0;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
void *do_nofail(void *ptr, const char *expr)
|
2006-01-29 05:15:55 +08:00
|
|
|
{
|
2008-01-12 02:17:15 +08:00
|
|
|
if (!ptr)
|
2020-03-07 00:02:05 +08:00
|
|
|
fatal("Memory allocation failure: %s.\n", expr);
|
2006-01-29 05:15:55 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
return ptr;
|
|
|
|
}
|
|
|
|
|
2020-06-01 13:57:17 +08:00
|
|
|
char *read_text_file(const char *filename)
|
|
|
|
{
|
|
|
|
struct stat st;
|
|
|
|
size_t nbytes;
|
|
|
|
int fd;
|
|
|
|
char *buf;
|
|
|
|
|
|
|
|
fd = open(filename, O_RDONLY);
|
|
|
|
if (fd < 0) {
|
|
|
|
perror(filename);
|
|
|
|
exit(1);
|
|
|
|
}
|
2006-01-29 05:15:55 +08:00
|
|
|
|
2020-06-01 13:57:17 +08:00
|
|
|
if (fstat(fd, &st) < 0) {
|
|
|
|
perror(filename);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
buf = NOFAIL(malloc(st.st_size + 1));
|
|
|
|
|
|
|
|
nbytes = st.st_size;
|
|
|
|
|
|
|
|
while (nbytes) {
|
|
|
|
ssize_t bytes_read;
|
|
|
|
|
|
|
|
bytes_read = read(fd, buf, nbytes);
|
|
|
|
if (bytes_read < 0) {
|
|
|
|
perror(filename);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
nbytes -= bytes_read;
|
|
|
|
}
|
|
|
|
buf[st.st_size] = '\0';
|
|
|
|
|
|
|
|
close(fd);
|
|
|
|
|
|
|
|
return buf;
|
2006-01-29 05:15:55 +08:00
|
|
|
}
|
|
|
|
|
2020-06-01 13:57:17 +08:00
|
|
|
char *get_line(char **stringp)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2020-07-01 14:18:27 +08:00
|
|
|
char *orig = *stringp, *next;
|
|
|
|
|
2020-06-01 13:57:17 +08:00
|
|
|
/* do not return the unwanted extra line at EOF */
|
2020-07-01 14:18:27 +08:00
|
|
|
if (!orig || *orig == '\0')
|
2020-06-01 13:57:17 +08:00
|
|
|
return NULL;
|
2008-01-12 02:17:15 +08:00
|
|
|
|
2020-07-27 05:44:19 +08:00
|
|
|
/* don't use strsep here, it is not available everywhere */
|
2020-07-01 14:18:27 +08:00
|
|
|
next = strchr(orig, '\n');
|
|
|
|
if (next)
|
|
|
|
*next++ = '\0';
|
|
|
|
|
|
|
|
*stringp = next;
|
|
|
|
|
|
|
|
return orig;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* A list of all modules we processed */
|
2022-05-01 16:40:10 +08:00
|
|
|
LIST_HEAD(modules);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2018-05-09 17:50:40 +08:00
|
|
|
static struct module *find_module(const char *modname)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct module *mod;
|
|
|
|
|
2022-05-01 16:40:10 +08:00
|
|
|
list_for_each_entry(mod, &modules, list) {
|
2005-04-17 06:20:36 +08:00
|
|
|
if (strcmp(mod->name, modname) == 0)
|
2022-05-01 16:40:10 +08:00
|
|
|
return mod;
|
|
|
|
}
|
|
|
|
return NULL;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2022-05-30 17:01:38 +08:00
|
|
|
static struct module *new_module(const char *name, size_t namelen)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct module *mod;
|
2006-03-03 23:46:04 +08:00
|
|
|
|
2022-05-30 17:01:38 +08:00
|
|
|
mod = NOFAIL(malloc(sizeof(*mod) + namelen + 1));
|
2005-04-17 06:20:36 +08:00
|
|
|
memset(mod, 0, sizeof(*mod));
|
|
|
|
|
2022-05-01 16:40:15 +08:00
|
|
|
INIT_LIST_HEAD(&mod->exported_symbols);
|
2022-05-01 16:40:12 +08:00
|
|
|
INIT_LIST_HEAD(&mod->unresolved_symbols);
|
2022-05-01 16:40:14 +08:00
|
|
|
INIT_LIST_HEAD(&mod->missing_namespaces);
|
|
|
|
INIT_LIST_HEAD(&mod->imported_namespaces);
|
2022-05-01 16:40:12 +08:00
|
|
|
|
2022-05-30 17:01:38 +08:00
|
|
|
memcpy(mod->name, name, namelen);
|
|
|
|
mod->name[namelen] = '\0';
|
|
|
|
mod->is_vmlinux = (strcmp(mod->name, "vmlinux") == 0);
|
modpost: change mod->gpl_compatible to bool type
Currently, mod->gpl_compatible is tristate; it is set to -1 by default,
then to 1 or 0 when MODULE_LICENSE() is found.
Maybe, -1 was chosen to represent the 'unknown' license, but it is not
useful.
The current code:
if (!mod->gpl_compatible)
check_for_gpl_usage(exp->export, basename, exp->name);
... only cares whether gpl_compatible is zero or not.
Change it to a bool type with the initial value 'true', which has no
functional change.
The default value should be 'true' instead of 'false'.
Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into
error"), unknown module license is an error.
The error message, "missing MODULE_LICENSE()" is enough to explain the
issue. It is not sensible to show another message, "GPL-incompatible
module ... uses GPL-only symbol".
Add comments to explain this.
While I was here, I renamed gpl_compatible to is_gpl_compatible for
clarification, and also slightly refactored the code.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2022-05-01 16:40:08 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Set mod->is_gpl_compatible to true by default. If MODULE_LICENSE()
|
|
|
|
* is missing, do not check the use for EXPORT_SYMBOL_GPL() becasue
|
|
|
|
* modpost will exit wiht error anyway.
|
|
|
|
*/
|
|
|
|
mod->is_gpl_compatible = true;
|
|
|
|
|
2022-05-01 16:40:10 +08:00
|
|
|
list_add_tail(&mod->list, &modules);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
return mod;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* A hash of all exported symbols,
|
|
|
|
* struct symbol is also used for lists of unresolved symbols */
|
|
|
|
|
|
|
|
#define SYMBOL_HASH_SIZE 1024
|
|
|
|
|
|
|
|
struct symbol {
|
|
|
|
struct symbol *next;
|
2022-05-01 16:40:15 +08:00
|
|
|
struct list_head list; /* link to module::exported_symbols or module::unresolved_symbols */
|
2005-04-17 06:20:36 +08:00
|
|
|
struct module *module;
|
modpost: fix broken sym->namespace for external module builds
Currently, external module builds produce tons of false-positives:
WARNING: module <mod> uses symbol <sym> from namespace <ns>, but does not import it.
Here, the <ns> part shows a random string.
When you build external modules, the symbol info of vmlinux and
in-kernel modules are read from $(objtree)/Module.symvers, but
read_dump() is buggy in multiple ways:
[1] When the modpost is run for vmlinux and in-kernel modules,
sym_extract_namespace() allocates memory for the namespace. On the
other hand, read_dump() does not, then sym->namespace will point to
somewhere in the line buffer of get_next_line(). The data in the
buffer will be replaced soon, and sym->namespace will end up with
pointing to unrelated data. As a result, check_exports() will show
random strings in the warning messages.
[2] When there is no namespace, sym_extract_namespace() returns NULL.
On the other hand, read_dump() sets namespace to an empty string "".
(but, it will be later replaced with unrelated data due to bug [1].)
The check_exports() shows a warning unless exp->namespace is NULL,
so every symbol read from read_dump() emits the warning, which is
mostly false positive.
To address [1], sym_add_exported() calls strdup() for s->namespace.
The namespace from sym_extract_namespace() must be freed to avoid
memory leak.
For [2], I changed the if-conditional in check_exports().
This commit also fixes sym_add_exported() to set s->namespace correctly
when the symbol is preloaded.
Reviewed-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
2019-10-03 15:58:22 +08:00
|
|
|
char *namespace;
|
2022-05-01 16:40:07 +08:00
|
|
|
unsigned int crc;
|
|
|
|
bool crc_valid;
|
|
|
|
bool weak;
|
2022-05-09 03:06:19 +08:00
|
|
|
bool is_gpl_only; /* exported by EXPORT_SYMBOL_GPL */
|
modpost,fixdep: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-05-08 02:56:01 +08:00
|
|
|
char name[];
|
2005-04-17 06:20:36 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static struct symbol *symbolhash[SYMBOL_HASH_SIZE];
|
|
|
|
|
2021-03-26 13:52:19 +08:00
|
|
|
/* This is based on the hash algorithm from gdbm, via tdb */
|
2005-04-17 06:20:36 +08:00
|
|
|
static inline unsigned int tdb_hash(const char *name)
|
|
|
|
{
|
|
|
|
unsigned value; /* Used to compute the hash value. */
|
|
|
|
unsigned i; /* Used to cycle through random values. */
|
|
|
|
|
|
|
|
/* Set the initial value from the key size. */
|
2008-01-12 02:17:15 +08:00
|
|
|
for (value = 0x238F13AF * strlen(name), i = 0; name[i]; i++)
|
2005-04-17 06:20:36 +08:00
|
|
|
value = (value + (((unsigned char *)name)[i] << (i*5 % 24)));
|
|
|
|
|
|
|
|
return (1103515243 * value + 12345);
|
|
|
|
}
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
/**
|
|
|
|
* Allocate a new symbols for use in the hash of exported symbols or
|
|
|
|
* the list of unresolved symbols per module
|
|
|
|
**/
|
2022-05-01 16:40:19 +08:00
|
|
|
static struct symbol *alloc_symbol(const char *name)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct symbol *s = NOFAIL(malloc(sizeof(*s) + strlen(name) + 1));
|
|
|
|
|
|
|
|
memset(s, 0, sizeof(*s));
|
|
|
|
strcpy(s->name, name);
|
2022-05-27 18:01:51 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* For the hash of exported symbols */
|
2022-05-01 16:40:19 +08:00
|
|
|
static void hash_add_symbol(struct symbol *sym)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
unsigned int hash;
|
|
|
|
|
2022-05-01 16:40:19 +08:00
|
|
|
hash = tdb_hash(sym->name) % SYMBOL_HASH_SIZE;
|
|
|
|
sym->next = symbolhash[hash];
|
|
|
|
symbolhash[hash] = sym;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2022-05-01 16:40:11 +08:00
|
|
|
static void sym_add_unresolved(const char *name, struct module *mod, bool weak)
|
|
|
|
{
|
2022-05-01 16:40:12 +08:00
|
|
|
struct symbol *sym;
|
|
|
|
|
2022-05-01 16:40:19 +08:00
|
|
|
sym = alloc_symbol(name);
|
2022-05-01 16:40:12 +08:00
|
|
|
sym->weak = weak;
|
|
|
|
|
|
|
|
list_add_tail(&sym->list, &mod->unresolved_symbols);
|
2022-05-01 16:40:11 +08:00
|
|
|
}
|
|
|
|
|
2022-05-12 00:45:04 +08:00
|
|
|
static struct symbol *sym_find_with_module(const char *name, struct module *mod)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct symbol *s;
|
|
|
|
|
|
|
|
/* For our purposes, .foo matches foo. PPC64 needs this. */
|
|
|
|
if (name[0] == '.')
|
|
|
|
name++;
|
|
|
|
|
2008-01-12 02:17:15 +08:00
|
|
|
for (s = symbolhash[tdb_hash(name) % SYMBOL_HASH_SIZE]; s; s = s->next) {
|
2022-05-12 00:45:04 +08:00
|
|
|
if (strcmp(s->name, name) == 0 && (!mod || s->module == mod))
|
2005-04-17 06:20:36 +08:00
|
|
|
return s;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2022-05-12 00:45:04 +08:00
|
|
|
static struct symbol *find_symbol(const char *name)
|
|
|
|
{
|
|
|
|
return sym_find_with_module(name, NULL);
|
|
|
|
}
|
|
|
|
|
2022-04-25 03:07:56 +08:00
|
|
|
struct namespace_list {
|
2022-05-01 16:40:14 +08:00
|
|
|
struct list_head list;
|
2022-04-25 03:07:56 +08:00
|
|
|
char namespace[];
|
|
|
|
};
|
|
|
|
|
2022-05-01 16:40:14 +08:00
|
|
|
static bool contains_namespace(struct list_head *head, const char *namespace)
|
2019-09-06 18:32:28 +08:00
|
|
|
{
|
2022-05-01 16:40:14 +08:00
|
|
|
struct namespace_list *list;
|
|
|
|
|
|
|
|
list_for_each_entry(list, head, list) {
|
2019-10-29 20:38:09 +08:00
|
|
|
if (!strcmp(list->namespace, namespace))
|
2019-09-06 18:32:28 +08:00
|
|
|
return true;
|
2022-05-01 16:40:14 +08:00
|
|
|
}
|
2019-09-06 18:32:28 +08:00
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2022-05-01 16:40:14 +08:00
|
|
|
static void add_namespace(struct list_head *head, const char *namespace)
|
2019-09-06 18:32:28 +08:00
|
|
|
{
|
|
|
|
struct namespace_list *ns_entry;
|
|
|
|
|
2022-05-01 16:40:14 +08:00
|
|
|
if (!contains_namespace(head, namespace)) {
|
|
|
|
ns_entry = NOFAIL(malloc(sizeof(*ns_entry) +
|
2019-09-06 18:32:28 +08:00
|
|
|
strlen(namespace) + 1));
|
|
|
|
strcpy(ns_entry->namespace, namespace);
|
2022-05-01 16:40:14 +08:00
|
|
|
list_add_tail(&ns_entry->list, head);
|
2019-09-06 18:32:28 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-05-25 13:47:04 +08:00
|
|
|
static void *sym_get_data_by_offset(const struct elf_info *info,
|
|
|
|
unsigned int secindex, unsigned long offset)
|
2017-09-07 07:19:05 +08:00
|
|
|
{
|
2020-03-18 18:34:16 +08:00
|
|
|
Elf_Shdr *sechdr = &info->sechdrs[secindex];
|
2017-09-07 07:19:05 +08:00
|
|
|
|
2019-11-15 01:42:21 +08:00
|
|
|
return (void *)info->hdr + sechdr->sh_offset + offset;
|
2017-09-07 07:19:05 +08:00
|
|
|
}
|
2011-07-14 14:51:16 +08:00
|
|
|
|
2022-07-20 00:53:00 +08:00
|
|
|
void *sym_get_data(const struct elf_info *info, const Elf_Sym *sym)
|
2019-11-15 01:42:21 +08:00
|
|
|
{
|
2020-05-25 13:47:04 +08:00
|
|
|
return sym_get_data_by_offset(info, get_secindex(info, sym),
|
|
|
|
sym->st_value);
|
|
|
|
}
|
2019-11-15 01:42:21 +08:00
|
|
|
|
2020-05-25 13:47:05 +08:00
|
|
|
static const char *sech_name(const struct elf_info *info, Elf_Shdr *sechdr)
|
|
|
|
{
|
|
|
|
return sym_get_data_by_offset(info, info->secindex_strings,
|
|
|
|
sechdr->sh_name);
|
|
|
|
}
|
2019-11-15 01:42:21 +08:00
|
|
|
|
2022-07-31 01:36:34 +08:00
|
|
|
static const char *sec_name(const struct elf_info *info, unsigned int secindex)
|
2020-05-25 13:47:05 +08:00
|
|
|
{
|
2022-07-31 01:36:34 +08:00
|
|
|
/*
|
|
|
|
* If sym->st_shndx is a special section index, there is no
|
|
|
|
* corresponding section header.
|
|
|
|
* Return "" if the index is out of range of info->sechdrs[] array.
|
|
|
|
*/
|
|
|
|
if (secindex >= info->num_sections)
|
|
|
|
return "";
|
|
|
|
|
2020-05-25 13:47:05 +08:00
|
|
|
return sech_name(info, &info->sechdrs[secindex]);
|
2019-11-15 01:42:21 +08:00
|
|
|
}
|
|
|
|
|
2011-07-14 14:51:16 +08:00
|
|
|
#define strstarts(str, prefix) (strncmp(str, prefix, strlen(prefix)) == 0)
|
|
|
|
|
2019-10-18 17:31:40 +08:00
|
|
|
static void sym_update_namespace(const char *symname, const char *namespace)
|
|
|
|
{
|
|
|
|
struct symbol *s = find_symbol(symname);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* That symbol should have been created earlier and thus this is
|
|
|
|
* actually an assertion.
|
|
|
|
*/
|
|
|
|
if (!s) {
|
modpost: rename merror() to error()
The log function names, warn(), merror(), fatal() are inconsistent.
Commit 2a11665945d5 ("kbuild: distinguish between errors and warnings
in modpost") intentionally chose merror() to avoid the conflict with
the library function error(). See man page of error(3).
But, we are already causing the conflict with warn() because it is also
a library function. See man page of warn(3). err() would be a problem
for the same reason.
The common technique to work around name conflicts is to use macros.
For example:
/* in a header */
#define error(fmt, ...) __error(fmt, ##__VA_ARGS__)
#define warn(fmt, ...) __warn(fmt, ##__VA_ARGS__)
/* function definition */
void __error(const char *fmt, ...)
{
<our implementation>
}
void __warn(const char *fmt, ...)
{
<our implementation>
}
In this way, we can implement our own warn() and error(), still we can
include <error.h> and <err.h> with no problem.
And, commit 93c95e526a4e ("modpost: rework and consolidate logging
interface") already did that.
Since the log functions are all macros, we can use error() without
causing "conflicting types" errors.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-12-01 18:34:14 +08:00
|
|
|
error("Could not update namespace(%s) for symbol %s\n",
|
|
|
|
namespace, symname);
|
2019-10-18 17:31:40 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
free(s->namespace);
|
2022-04-05 19:33:54 +08:00
|
|
|
s->namespace = namespace[0] ? NOFAIL(strdup(namespace)) : NULL;
|
2019-10-18 17:31:40 +08:00
|
|
|
}
|
|
|
|
|
2019-10-18 17:31:41 +08:00
|
|
|
static struct symbol *sym_add_exported(const char *name, struct module *mod,
|
2022-05-09 03:06:19 +08:00
|
|
|
bool gpl_only)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct symbol *s = find_symbol(name);
|
|
|
|
|
2022-05-01 16:40:18 +08:00
|
|
|
if (s && (!external_module || s->module->is_vmlinux || s->module == mod)) {
|
2022-05-01 16:40:17 +08:00
|
|
|
error("%s: '%s' exported twice. Previous export was in %s%s\n",
|
|
|
|
mod->name, name, s->module->name,
|
|
|
|
s->module->is_vmlinux ? "" : ".ko");
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2019-11-15 01:42:26 +08:00
|
|
|
|
2022-05-01 16:40:19 +08:00
|
|
|
s = alloc_symbol(name);
|
2019-11-15 01:42:26 +08:00
|
|
|
s->module = mod;
|
2022-05-09 03:06:19 +08:00
|
|
|
s->is_gpl_only = gpl_only;
|
2022-05-01 16:40:18 +08:00
|
|
|
list_add_tail(&s->list, &mod->exported_symbols);
|
2022-05-01 16:40:19 +08:00
|
|
|
hash_add_symbol(s);
|
2022-05-01 16:40:18 +08:00
|
|
|
|
2006-01-29 05:15:55 +08:00
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
2022-05-13 19:39:21 +08:00
|
|
|
static void sym_set_crc(struct symbol *sym, unsigned int crc)
|
2006-01-29 05:15:55 +08:00
|
|
|
{
|
2022-05-13 19:39:21 +08:00
|
|
|
sym->crc = crc;
|
|
|
|
sym->crc_valid = true;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2020-06-01 13:57:31 +08:00
|
|
|
static void *grab_file(const char *filename, size_t *size)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct stat st;
|
2012-05-23 20:58:49 +08:00
|
|
|
void *map = MAP_FAILED;
|
2005-04-17 06:20:36 +08:00
|
|
|
int fd;
|
|
|
|
|
|
|
|
fd = open(filename, O_RDONLY);
|
2012-05-23 20:58:49 +08:00
|
|
|
if (fd < 0)
|
2005-04-17 06:20:36 +08:00
|
|
|
return NULL;
|
2012-05-23 20:58:49 +08:00
|
|
|
if (fstat(fd, &st))
|
|
|
|
goto failed;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
*size = st.st_size;
|
|
|
|
map = mmap(NULL, *size, PROT_READ|PROT_WRITE, MAP_PRIVATE, fd, 0);
|
|
|
|
|
2012-05-23 20:58:49 +08:00
|
|
|
failed:
|
|
|
|
close(fd);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (map == MAP_FAILED)
|
|
|
|
return NULL;
|
|
|
|
return map;
|
|
|
|
}
|
|
|
|
|
2020-06-01 13:57:31 +08:00
|
|
|
static void release_file(void *file, size_t size)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
munmap(file, size);
|
|
|
|
}
|
|
|
|
|
2007-02-26 22:33:52 +08:00
|
|
|
static int parse_elf(struct elf_info *info, const char *filename)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
unsigned int i;
|
2007-02-26 22:33:52 +08:00
|
|
|
Elf_Ehdr *hdr;
|
2005-04-17 06:20:36 +08:00
|
|
|
Elf_Shdr *sechdrs;
|
|
|
|
Elf_Sym *sym;
|
2010-07-29 07:47:53 +08:00
|
|
|
const char *secstrings;
|
|
|
|
unsigned int symtab_idx = ~0U, symtab_shndx_idx = ~0U;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
hdr = grab_file(filename, &info->size);
|
|
|
|
if (!hdr) {
|
2013-09-23 13:53:54 +08:00
|
|
|
if (ignore_missing_files) {
|
|
|
|
fprintf(stderr, "%s: %s (ignored)\n", filename,
|
|
|
|
strerror(errno));
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
perror(filename);
|
2006-06-25 05:46:54 +08:00
|
|
|
exit(1);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
info->hdr = hdr;
|
2007-02-26 22:33:52 +08:00
|
|
|
if (info->size < sizeof(*hdr)) {
|
|
|
|
/* file too small, assume this is an empty .o file */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
/* Is this a valid ELF file? */
|
|
|
|
if ((hdr->e_ident[EI_MAG0] != ELFMAG0) ||
|
|
|
|
(hdr->e_ident[EI_MAG1] != ELFMAG1) ||
|
|
|
|
(hdr->e_ident[EI_MAG2] != ELFMAG2) ||
|
|
|
|
(hdr->e_ident[EI_MAG3] != ELFMAG3)) {
|
|
|
|
/* Not an ELF file - silently ignore it */
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
/* Fix endianness in ELF header */
|
2009-05-04 04:02:55 +08:00
|
|
|
hdr->e_type = TO_NATIVE(hdr->e_type);
|
|
|
|
hdr->e_machine = TO_NATIVE(hdr->e_machine);
|
|
|
|
hdr->e_version = TO_NATIVE(hdr->e_version);
|
|
|
|
hdr->e_entry = TO_NATIVE(hdr->e_entry);
|
|
|
|
hdr->e_phoff = TO_NATIVE(hdr->e_phoff);
|
|
|
|
hdr->e_shoff = TO_NATIVE(hdr->e_shoff);
|
|
|
|
hdr->e_flags = TO_NATIVE(hdr->e_flags);
|
|
|
|
hdr->e_ehsize = TO_NATIVE(hdr->e_ehsize);
|
|
|
|
hdr->e_phentsize = TO_NATIVE(hdr->e_phentsize);
|
|
|
|
hdr->e_phnum = TO_NATIVE(hdr->e_phnum);
|
|
|
|
hdr->e_shentsize = TO_NATIVE(hdr->e_shentsize);
|
|
|
|
hdr->e_shnum = TO_NATIVE(hdr->e_shnum);
|
|
|
|
hdr->e_shstrndx = TO_NATIVE(hdr->e_shstrndx);
|
2005-04-17 06:20:36 +08:00
|
|
|
sechdrs = (void *)hdr + hdr->e_shoff;
|
|
|
|
info->sechdrs = sechdrs;
|
|
|
|
|
2022-07-20 00:52:59 +08:00
|
|
|
/* modpost only works for relocatable objects */
|
|
|
|
if (hdr->e_type != ET_REL)
|
|
|
|
fatal("%s: not relocatable object.", filename);
|
|
|
|
|
2007-08-27 18:15:07 +08:00
|
|
|
/* Check if file offset is correct */
|
|
|
|
if (hdr->e_shoff > info->size) {
|
2020-06-01 13:57:31 +08:00
|
|
|
fatal("section header offset=%lu in file '%s' is bigger than filesize=%zu\n",
|
|
|
|
(unsigned long)hdr->e_shoff, filename, info->size);
|
2007-08-27 18:15:07 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-05-20 06:55:27 +08:00
|
|
|
if (hdr->e_shnum == SHN_UNDEF) {
|
2010-07-29 07:47:53 +08:00
|
|
|
/*
|
|
|
|
* There are more than 64k sections,
|
|
|
|
* read count from .sh_size.
|
|
|
|
*/
|
|
|
|
info->num_sections = TO_NATIVE(sechdrs[0].sh_size);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
info->num_sections = hdr->e_shnum;
|
|
|
|
}
|
|
|
|
if (hdr->e_shstrndx == SHN_XINDEX) {
|
2011-05-20 06:55:27 +08:00
|
|
|
info->secindex_strings = TO_NATIVE(sechdrs[0].sh_link);
|
2010-07-29 07:47:53 +08:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
info->secindex_strings = hdr->e_shstrndx;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/* Fix endianness in section headers */
|
2010-07-29 07:47:53 +08:00
|
|
|
for (i = 0; i < info->num_sections; i++) {
|
2009-05-04 04:02:55 +08:00
|
|
|
sechdrs[i].sh_name = TO_NATIVE(sechdrs[i].sh_name);
|
|
|
|
sechdrs[i].sh_type = TO_NATIVE(sechdrs[i].sh_type);
|
|
|
|
sechdrs[i].sh_flags = TO_NATIVE(sechdrs[i].sh_flags);
|
|
|
|
sechdrs[i].sh_addr = TO_NATIVE(sechdrs[i].sh_addr);
|
|
|
|
sechdrs[i].sh_offset = TO_NATIVE(sechdrs[i].sh_offset);
|
|
|
|
sechdrs[i].sh_size = TO_NATIVE(sechdrs[i].sh_size);
|
|
|
|
sechdrs[i].sh_link = TO_NATIVE(sechdrs[i].sh_link);
|
|
|
|
sechdrs[i].sh_info = TO_NATIVE(sechdrs[i].sh_info);
|
|
|
|
sechdrs[i].sh_addralign = TO_NATIVE(sechdrs[i].sh_addralign);
|
|
|
|
sechdrs[i].sh_entsize = TO_NATIVE(sechdrs[i].sh_entsize);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
/* Find symbol table. */
|
2010-07-29 07:47:53 +08:00
|
|
|
secstrings = (void *)hdr + sechdrs[info->secindex_strings].sh_offset;
|
|
|
|
for (i = 1; i < info->num_sections; i++) {
|
2006-06-09 13:12:53 +08:00
|
|
|
const char *secname;
|
2009-02-05 23:48:02 +08:00
|
|
|
int nobits = sechdrs[i].sh_type == SHT_NOBITS;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-02-05 23:48:02 +08:00
|
|
|
if (!nobits && sechdrs[i].sh_offset > info->size) {
|
2008-01-12 02:17:15 +08:00
|
|
|
fatal("%s is truncated. sechdrs[i].sh_offset=%lu > "
|
|
|
|
"sizeof(*hrd)=%zu\n", filename,
|
|
|
|
(unsigned long)sechdrs[i].sh_offset,
|
|
|
|
sizeof(*hdr));
|
2007-02-26 22:33:52 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2006-06-09 13:12:53 +08:00
|
|
|
secname = secstrings + sechdrs[i].sh_name;
|
|
|
|
if (strcmp(secname, ".modinfo") == 0) {
|
2009-02-05 23:48:02 +08:00
|
|
|
if (nobits)
|
|
|
|
fatal("%s has NOBITS .modinfo\n", filename);
|
2005-04-17 06:20:36 +08:00
|
|
|
info->modinfo = (void *)hdr + sechdrs[i].sh_offset;
|
|
|
|
info->modinfo_len = sechdrs[i].sh_size;
|
modpost: remove useless export_from_sec()
With commit 1743694eb235 ("modpost: stop symbol preloading for
modversion CRC") applied, now export_from_sec() is useless.
handle_symbol() is called for every symbol in the ELF.
When 'symname' does not start with "__ksymtab", export_from_sec() is
called, and the returned value is stored in 'export'.
It is used in the last part of handle_symbol():
if (strstarts(symname, "__ksymtab_")) {
name = symname + strlen("__ksymtab_");
sym_add_exported(name, mod, export);
}
'export' is used only when 'symname' starts with "__ksymtab_".
So, the value returned by export_from_sec() is never used.
Remove useless export_from_sec(). This makes further cleanups possible.
I put the temporary code:
export = export_unknown;
Otherwise, I would get the compiler warning:
warning: 'export' may be used uninitialized in this function [-Wmaybe-uninitialized]
This is apparently false positive because
if (strstarts(symname, "__ksymtab_")
... is a stronger condition than:
if (strstarts(symname, "__ksymtab")
Anyway, this part will be cleaned up by the next commit.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2022-04-05 19:33:51 +08:00
|
|
|
}
|
2006-06-09 13:12:53 +08:00
|
|
|
|
2010-07-29 07:47:53 +08:00
|
|
|
if (sechdrs[i].sh_type == SHT_SYMTAB) {
|
|
|
|
unsigned int sh_link_idx;
|
|
|
|
symtab_idx = i;
|
|
|
|
info->symtab_start = (void *)hdr +
|
|
|
|
sechdrs[i].sh_offset;
|
|
|
|
info->symtab_stop = (void *)hdr +
|
|
|
|
sechdrs[i].sh_offset + sechdrs[i].sh_size;
|
2011-05-20 06:55:27 +08:00
|
|
|
sh_link_idx = sechdrs[i].sh_link;
|
2010-07-29 07:47:53 +08:00
|
|
|
info->strtab = (void *)hdr +
|
|
|
|
sechdrs[sh_link_idx].sh_offset;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-07-29 07:47:53 +08:00
|
|
|
/* 32bit section no. table? ("more than 64k sections") */
|
|
|
|
if (sechdrs[i].sh_type == SHT_SYMTAB_SHNDX) {
|
|
|
|
symtab_shndx_idx = i;
|
|
|
|
info->symtab_shndx_start = (void *)hdr +
|
|
|
|
sechdrs[i].sh_offset;
|
|
|
|
info->symtab_shndx_stop = (void *)hdr +
|
|
|
|
sechdrs[i].sh_offset + sechdrs[i].sh_size;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2008-01-12 02:17:15 +08:00
|
|
|
if (!info->symtab_start)
|
2006-01-28 23:57:26 +08:00
|
|
|
fatal("%s has no symtab?\n", filename);
|
2008-01-12 02:17:15 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/* Fix endianness in symbols */
|
|
|
|
for (sym = info->symtab_start; sym < info->symtab_stop; sym++) {
|
|
|
|
sym->st_shndx = TO_NATIVE(sym->st_shndx);
|
|
|
|
sym->st_name = TO_NATIVE(sym->st_name);
|
|
|
|
sym->st_value = TO_NATIVE(sym->st_value);
|
|
|
|
sym->st_size = TO_NATIVE(sym->st_size);
|
|
|
|
}
|
2010-07-29 07:47:53 +08:00
|
|
|
|
|
|
|
if (symtab_shndx_idx != ~0U) {
|
|
|
|
Elf32_Word *p;
|
2011-05-20 06:55:27 +08:00
|
|
|
if (symtab_idx != sechdrs[symtab_shndx_idx].sh_link)
|
2010-07-29 07:47:53 +08:00
|
|
|
fatal("%s: SYMTAB_SHNDX has bad sh_link: %u!=%u\n",
|
2011-05-20 06:55:27 +08:00
|
|
|
filename, sechdrs[symtab_shndx_idx].sh_link,
|
2010-07-29 07:47:53 +08:00
|
|
|
symtab_idx);
|
|
|
|
/* Fix endianness */
|
|
|
|
for (p = info->symtab_shndx_start; p < info->symtab_shndx_stop;
|
|
|
|
p++)
|
|
|
|
*p = TO_NATIVE(*p);
|
|
|
|
}
|
|
|
|
|
2007-02-26 22:33:52 +08:00
|
|
|
return 1;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
static void parse_elf_finish(struct elf_info *info)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
release_file(info->hdr, info->size);
|
|
|
|
}
|
|
|
|
|
2008-06-12 21:02:55 +08:00
|
|
|
static int ignore_undef_symbol(struct elf_info *info, const char *symname)
|
|
|
|
{
|
|
|
|
/* ignore __this_module, it will be resolved shortly */
|
2018-05-09 15:23:45 +08:00
|
|
|
if (strcmp(symname, "__this_module") == 0)
|
2008-06-12 21:02:55 +08:00
|
|
|
return 1;
|
|
|
|
/* ignore global offset table */
|
|
|
|
if (strcmp(symname, "_GLOBAL_OFFSET_TABLE_") == 0)
|
|
|
|
return 1;
|
|
|
|
if (info->hdr->e_machine == EM_PPC)
|
|
|
|
/* Special register function linked on all modules during final link of .ko */
|
2018-05-09 17:50:38 +08:00
|
|
|
if (strstarts(symname, "_restgpr_") ||
|
|
|
|
strstarts(symname, "_savegpr_") ||
|
|
|
|
strstarts(symname, "_rest32gpr_") ||
|
|
|
|
strstarts(symname, "_save32gpr_") ||
|
|
|
|
strstarts(symname, "_restvr_") ||
|
|
|
|
strstarts(symname, "_savevr_"))
|
2008-06-12 21:02:55 +08:00
|
|
|
return 1;
|
2010-06-30 04:08:42 +08:00
|
|
|
if (info->hdr->e_machine == EM_PPC64)
|
|
|
|
/* Special register function linked on all modules during final link of .ko */
|
2018-05-09 17:50:38 +08:00
|
|
|
if (strstarts(symname, "_restgpr0_") ||
|
|
|
|
strstarts(symname, "_savegpr0_") ||
|
|
|
|
strstarts(symname, "_restvr_") ||
|
|
|
|
strstarts(symname, "_savevr_") ||
|
2016-01-15 17:52:22 +08:00
|
|
|
strcmp(symname, ".TOC.") == 0)
|
2010-06-30 04:08:42 +08:00
|
|
|
return 1;
|
2022-03-07 03:56:07 +08:00
|
|
|
|
|
|
|
if (info->hdr->e_machine == EM_S390)
|
|
|
|
/* Expoline thunks are linked on all kernel modules during final link of .ko */
|
|
|
|
if (strstarts(symname, "__s390_indirect_jump_r"))
|
|
|
|
return 1;
|
2008-06-12 21:02:55 +08:00
|
|
|
/* Do not ignore this symbol */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-11-15 01:42:23 +08:00
|
|
|
static void handle_symbol(struct module *mod, struct elf_info *info,
|
|
|
|
const Elf_Sym *sym, const char *symname)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
switch (sym->st_shndx) {
|
|
|
|
case SHN_COMMON:
|
2018-05-09 17:50:38 +08:00
|
|
|
if (strstarts(symname, "__gnu_lto_")) {
|
2014-02-08 16:01:17 +08:00
|
|
|
/* Should warn here, but modpost runs before the linker */
|
|
|
|
} else
|
|
|
|
warn("\"%s\" [%s] is COMMON symbol\n", symname, mod->name);
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
case SHN_UNDEF:
|
|
|
|
/* undefined symbol */
|
|
|
|
if (ELF_ST_BIND(sym->st_info) != STB_GLOBAL &&
|
|
|
|
ELF_ST_BIND(sym->st_info) != STB_WEAK)
|
|
|
|
break;
|
2008-06-12 21:02:55 +08:00
|
|
|
if (ignore_undef_symbol(info, symname))
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
if (info->hdr->e_machine == EM_SPARC ||
|
|
|
|
info->hdr->e_machine == EM_SPARCV9) {
|
|
|
|
/* Ignore register directives. */
|
2005-08-20 04:44:57 +08:00
|
|
|
if (ELF_ST_TYPE(sym->st_info) == STT_SPARC_REGISTER)
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
2006-03-03 23:46:04 +08:00
|
|
|
if (symname[0] == '.') {
|
2018-08-16 03:30:38 +08:00
|
|
|
char *munged = NOFAIL(strdup(symname));
|
2006-03-03 23:46:04 +08:00
|
|
|
munged[0] = '_';
|
|
|
|
munged[1] = toupper(munged[1]);
|
|
|
|
symname = munged;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2006-03-03 23:46:04 +08:00
|
|
|
|
2022-05-01 16:40:11 +08:00
|
|
|
sym_add_unresolved(symname, mod,
|
|
|
|
ELF_ST_BIND(sym->st_info) == STB_WEAK);
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
/* All exported symbols */
|
2018-05-09 17:50:38 +08:00
|
|
|
if (strstarts(symname, "__ksymtab_")) {
|
2022-05-09 03:06:19 +08:00
|
|
|
const char *name, *secname;
|
2022-04-05 19:33:52 +08:00
|
|
|
|
2019-09-06 18:32:28 +08:00
|
|
|
name = symname + strlen("__ksymtab_");
|
2022-05-09 03:06:19 +08:00
|
|
|
secname = sec_name(info, get_secindex(info, sym));
|
|
|
|
|
|
|
|
if (strstarts(secname, "___ksymtab_gpl+"))
|
|
|
|
sym_add_exported(name, mod, true);
|
|
|
|
else if (strstarts(secname, "___ksymtab+"))
|
|
|
|
sym_add_exported(name, mod, false);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2018-05-09 15:23:45 +08:00
|
|
|
if (strcmp(symname, "init_module") == 0)
|
2022-05-01 16:40:07 +08:00
|
|
|
mod->has_init = true;
|
2018-05-09 15:23:45 +08:00
|
|
|
if (strcmp(symname, "cleanup_module") == 0)
|
2022-05-01 16:40:07 +08:00
|
|
|
mod->has_cleanup = true;
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
/**
|
|
|
|
* Parse tag=value strings from .modinfo section
|
|
|
|
**/
|
2005-04-17 06:20:36 +08:00
|
|
|
static char *next_string(char *string, unsigned long *secsize)
|
|
|
|
{
|
|
|
|
/* Skip non-zero chars */
|
|
|
|
while (string[0]) {
|
|
|
|
string++;
|
|
|
|
if ((*secsize)-- <= 1)
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Skip any zero padding. */
|
|
|
|
while (!string[0]) {
|
|
|
|
string++;
|
|
|
|
if ((*secsize)-- <= 1)
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
return string;
|
|
|
|
}
|
|
|
|
|
2018-05-09 17:50:37 +08:00
|
|
|
static char *get_next_modinfo(struct elf_info *info, const char *tag,
|
|
|
|
char *prev)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
char *p;
|
|
|
|
unsigned int taglen = strlen(tag);
|
2018-05-09 17:50:37 +08:00
|
|
|
char *modinfo = info->modinfo;
|
|
|
|
unsigned long size = info->modinfo_len;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2018-05-09 17:50:37 +08:00
|
|
|
if (prev) {
|
|
|
|
size -= prev - modinfo;
|
|
|
|
modinfo = next_string(prev, &size);
|
2006-06-10 03:53:55 +08:00
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
for (p = modinfo; p; p = next_string(p, &size)) {
|
|
|
|
if (strncmp(p, tag, taglen) == 0 && p[taglen] == '=')
|
|
|
|
return p + taglen + 1;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2018-05-09 17:50:37 +08:00
|
|
|
static char *get_modinfo(struct elf_info *info, const char *tag)
|
2006-06-10 03:53:55 +08:00
|
|
|
|
|
|
|
{
|
2018-05-09 17:50:37 +08:00
|
|
|
return get_next_modinfo(info, tag, NULL);
|
2006-06-10 03:53:55 +08:00
|
|
|
}
|
|
|
|
|
2008-01-24 02:54:27 +08:00
|
|
|
static const char *sym_name(struct elf_info *elf, Elf_Sym *sym)
|
|
|
|
{
|
2008-01-24 04:13:50 +08:00
|
|
|
if (sym)
|
|
|
|
return elf->strtab + sym->st_name;
|
|
|
|
else
|
2008-02-07 04:51:18 +08:00
|
|
|
return "(unknown)";
|
2008-01-24 02:54:27 +08:00
|
|
|
}
|
|
|
|
|
2022-05-30 17:01:39 +08:00
|
|
|
/*
|
|
|
|
* Check whether the 'string' argument matches one of the 'patterns',
|
|
|
|
* an array of shell wildcard patterns (glob).
|
|
|
|
*
|
|
|
|
* Return true is there is a match.
|
2008-01-14 05:21:31 +08:00
|
|
|
*/
|
2022-05-30 17:01:39 +08:00
|
|
|
static bool match(const char *string, const char *const patterns[])
|
2008-01-14 05:21:31 +08:00
|
|
|
{
|
2022-05-30 17:01:39 +08:00
|
|
|
const char *pattern;
|
2008-01-14 05:21:31 +08:00
|
|
|
|
2022-05-30 17:01:39 +08:00
|
|
|
while ((pattern = *patterns++)) {
|
|
|
|
if (!fnmatch(pattern, string, 0))
|
|
|
|
return true;
|
2008-01-14 05:21:31 +08:00
|
|
|
}
|
2022-05-30 17:01:39 +08:00
|
|
|
|
|
|
|
return false;
|
2008-01-14 05:21:31 +08:00
|
|
|
}
|
|
|
|
|
modpost: add PATTERNS() helper macro
This will be useful to define a NULL-terminated array inside a function
call.
Currently, string arrays passed to match() are defined in separate
places:
static const char *const init_sections[] = { ALL_INIT_SECTIONS, NULL };
static const char *const text_sections[] = { ALL_TEXT_SECTIONS, NULL };
static const char *const optim_symbols[] = { "*.constprop.*", NULL };
...
/* Check for pattern 5 */
if (match(fromsec, text_sections) &&
match(tosec, init_sections) &&
match(fromsym, optim_symbols))
return 0;
With the new helper macro, you can list the patterns directly in the
function call, like this:
/* Check for pattern 5 */
if (match(fromsec, PATTERNS(ALL_TEXT_SECTIONS)) &&
match(tosec, PATTERNS(ALL_INIT_SECTIONS)) &&
match(fromsym, PATTERNS("*.contprop.*")))
return 0;
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2022-08-01 17:39:00 +08:00
|
|
|
/* useful to pass patterns to match() directly */
|
|
|
|
#define PATTERNS(...) \
|
|
|
|
({ \
|
|
|
|
static const char *const patterns[] = {__VA_ARGS__, NULL}; \
|
|
|
|
patterns; \
|
|
|
|
})
|
|
|
|
|
2008-01-14 05:21:31 +08:00
|
|
|
/* sections that we do not want to do full section mismatch check on */
|
2014-08-27 18:58:53 +08:00
|
|
|
static const char *const section_white_list[] =
|
2009-05-04 19:05:26 +08:00
|
|
|
{
|
|
|
|
".comment*",
|
|
|
|
".debug*",
|
2010-12-16 09:11:22 +08:00
|
|
|
".zdebug*", /* Compressed debug sections. */
|
2018-03-08 17:48:46 +08:00
|
|
|
".GCC.command.line", /* record-gcc-switches */
|
2009-05-04 19:05:26 +08:00
|
|
|
".mdebug*", /* alpha, score, mips etc. */
|
|
|
|
".pdr", /* alpha, score, mips etc. */
|
|
|
|
".stab*",
|
|
|
|
".note*",
|
|
|
|
".got*",
|
|
|
|
".toc*",
|
2012-09-17 09:44:38 +08:00
|
|
|
".xt.prop", /* xtensa */
|
|
|
|
".xt.lit", /* xtensa */
|
2013-01-21 14:48:57 +08:00
|
|
|
".arcextmap*", /* arc */
|
|
|
|
".gnu.linkonce.arcext*", /* arc : modules */
|
2015-10-26 17:21:46 +08:00
|
|
|
".cmem*", /* EZchip */
|
|
|
|
".fmt_slot*", /* EZchip */
|
2014-02-08 16:01:17 +08:00
|
|
|
".gnu.lto*",
|
2017-03-02 02:04:44 +08:00
|
|
|
".discard.*",
|
2009-05-04 19:05:26 +08:00
|
|
|
NULL
|
|
|
|
};
|
2008-01-14 05:21:31 +08:00
|
|
|
|
2008-01-29 03:13:13 +08:00
|
|
|
/*
|
2009-04-24 04:49:33 +08:00
|
|
|
* This is used to find sections missing the SHF_ALLOC flag.
|
2008-01-29 03:13:13 +08:00
|
|
|
* The cause of this is often a section specified in assembler
|
2009-04-24 04:49:33 +08:00
|
|
|
* without "ax" / "aw".
|
2008-01-29 03:13:13 +08:00
|
|
|
*/
|
2009-04-24 04:49:33 +08:00
|
|
|
static void check_section(const char *modname, struct elf_info *elf,
|
2014-06-10 18:08:13 +08:00
|
|
|
Elf_Shdr *sechdr)
|
2008-01-29 03:13:13 +08:00
|
|
|
{
|
2009-04-24 04:49:33 +08:00
|
|
|
const char *sec = sech_name(elf, sechdr);
|
|
|
|
|
|
|
|
if (sechdr->sh_type == SHT_PROGBITS &&
|
|
|
|
!(sechdr->sh_flags & SHF_ALLOC) &&
|
|
|
|
!match(sec, section_white_list)) {
|
|
|
|
warn("%s (%s): unexpected non-allocatable section.\n"
|
|
|
|
"Did you forget to use \"ax\"/\"aw\" in a .S file?\n"
|
|
|
|
"Note that for example <linux/init.h> contains\n"
|
|
|
|
"section definitions for use in .S files.\n\n",
|
|
|
|
modname, sec);
|
2008-01-29 03:13:13 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-01-21 03:07:28 +08:00
|
|
|
#define ALL_INIT_DATA_SECTIONS \
|
2014-07-27 05:58:01 +08:00
|
|
|
".init.setup", ".init.rodata", ".meminit.rodata", \
|
|
|
|
".init.data", ".meminit.data"
|
2008-01-21 03:07:28 +08:00
|
|
|
#define ALL_EXIT_DATA_SECTIONS \
|
2014-07-27 05:58:01 +08:00
|
|
|
".exit.data", ".memexit.data"
|
2008-01-14 05:21:31 +08:00
|
|
|
|
2008-01-21 03:07:28 +08:00
|
|
|
#define ALL_INIT_TEXT_SECTIONS \
|
2014-07-27 05:58:01 +08:00
|
|
|
".init.text", ".meminit.text"
|
2008-01-21 03:07:28 +08:00
|
|
|
#define ALL_EXIT_TEXT_SECTIONS \
|
2014-07-27 05:58:01 +08:00
|
|
|
".exit.text", ".memexit.text"
|
2008-01-14 05:21:31 +08:00
|
|
|
|
2012-06-04 02:48:17 +08:00
|
|
|
#define ALL_PCI_INIT_SECTIONS \
|
2014-07-27 05:58:01 +08:00
|
|
|
".pci_fixup_early", ".pci_fixup_header", ".pci_fixup_final", \
|
|
|
|
".pci_fixup_enable", ".pci_fixup_resume", \
|
|
|
|
".pci_fixup_resume_early", ".pci_fixup_suspend"
|
2012-06-04 02:48:17 +08:00
|
|
|
|
2013-06-20 07:30:48 +08:00
|
|
|
#define ALL_XXXINIT_SECTIONS MEM_INIT_SECTIONS
|
|
|
|
#define ALL_XXXEXIT_SECTIONS MEM_EXIT_SECTIONS
|
2010-01-29 19:04:26 +08:00
|
|
|
|
|
|
|
#define ALL_INIT_SECTIONS INIT_SECTIONS, ALL_XXXINIT_SECTIONS
|
|
|
|
#define ALL_EXIT_SECTIONS EXIT_SECTIONS, ALL_XXXEXIT_SECTIONS
|
2008-01-14 05:21:31 +08:00
|
|
|
|
2014-07-27 05:58:01 +08:00
|
|
|
#define DATA_SECTIONS ".data", ".data.rel"
|
2015-04-13 19:12:52 +08:00
|
|
|
#define TEXT_SECTIONS ".text", ".text.unlikely", ".sched.text", \
|
2020-03-10 05:47:17 +08:00
|
|
|
".kprobes.text", ".cpuidle.text", ".noinstr.text"
|
2015-04-13 19:22:53 +08:00
|
|
|
#define OTHER_TEXT_SECTIONS ".ref.text", ".head.text", ".spinlock.text", \
|
2015-07-09 05:07:41 +08:00
|
|
|
".fixup", ".entry.text", ".exception.text", ".text.*", \
|
powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto
Using asm goto in __WARN_FLAGS() and WARN_ON() allows more
flexibility to GCC.
For that add an entry to the exception table so that
program_check_exception() knowns where to resume execution
after a WARNING.
Here are two exemples. The first one is done on PPC32 (which
benefits from the previous patch), the second is on PPC64.
unsigned long test(struct pt_regs *regs)
{
int ret;
WARN_ON(regs->msr & MSR_PR);
return regs->gpr[3];
}
unsigned long test9w(unsigned long a, unsigned long b)
{
if (WARN_ON(!b))
return 0;
return a / b;
}
Before the patch:
000003a8 <test>:
3a8: 81 23 00 84 lwz r9,132(r3)
3ac: 71 29 40 00 andi. r9,r9,16384
3b0: 40 82 00 0c bne 3bc <test+0x14>
3b4: 80 63 00 0c lwz r3,12(r3)
3b8: 4e 80 00 20 blr
3bc: 0f e0 00 00 twui r0,0
3c0: 80 63 00 0c lwz r3,12(r3)
3c4: 4e 80 00 20 blr
0000000000000bf0 <.test9w>:
bf0: 7c 89 00 74 cntlzd r9,r4
bf4: 79 29 d1 82 rldicl r9,r9,58,6
bf8: 0b 09 00 00 tdnei r9,0
bfc: 2c 24 00 00 cmpdi r4,0
c00: 41 82 00 0c beq c0c <.test9w+0x1c>
c04: 7c 63 23 92 divdu r3,r3,r4
c08: 4e 80 00 20 blr
c0c: 38 60 00 00 li r3,0
c10: 4e 80 00 20 blr
After the patch:
000003a8 <test>:
3a8: 81 23 00 84 lwz r9,132(r3)
3ac: 71 29 40 00 andi. r9,r9,16384
3b0: 40 82 00 0c bne 3bc <test+0x14>
3b4: 80 63 00 0c lwz r3,12(r3)
3b8: 4e 80 00 20 blr
3bc: 0f e0 00 00 twui r0,0
0000000000000c50 <.test9w>:
c50: 7c 89 00 74 cntlzd r9,r4
c54: 79 29 d1 82 rldicl r9,r9,58,6
c58: 0b 09 00 00 tdnei r9,0
c5c: 7c 63 23 92 divdu r3,r3,r4
c60: 4e 80 00 20 blr
c70: 38 60 00 00 li r3,0
c74: 4e 80 00 20 blr
In the first exemple, we see GCC doesn't need to duplicate what
happens after the trap.
In the second exemple, we see that GCC doesn't need to emit a test
and a branch in the likely path in addition to the trap.
We've got some WARN_ON() in .softirqentry.text section so it needs
to be added in the OTHER_TEXT_SECTIONS in modpost.c
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/389962b1b702e3c78d169e59bcfac56282889173.1618331882.git.christophe.leroy@csgroup.eu
2021-04-14 00:38:10 +08:00
|
|
|
".coldtext", ".softirqentry.text"
|
2008-01-14 05:21:31 +08:00
|
|
|
|
2009-03-12 18:58:33 +08:00
|
|
|
#define INIT_SECTIONS ".init.*"
|
|
|
|
#define MEM_INIT_SECTIONS ".meminit.*"
|
2008-01-21 03:07:28 +08:00
|
|
|
|
2009-03-12 18:58:33 +08:00
|
|
|
#define EXIT_SECTIONS ".exit.*"
|
|
|
|
#define MEM_EXIT_SECTIONS ".memexit.*"
|
2008-01-21 03:07:28 +08:00
|
|
|
|
2015-04-13 19:22:53 +08:00
|
|
|
#define ALL_TEXT_SECTIONS ALL_INIT_TEXT_SECTIONS, ALL_EXIT_TEXT_SECTIONS, \
|
|
|
|
TEXT_SECTIONS, OTHER_TEXT_SECTIONS
|
|
|
|
|
2008-01-20 17:43:27 +08:00
|
|
|
/* init data sections */
|
2014-08-27 18:58:53 +08:00
|
|
|
static const char *const init_data_sections[] =
|
|
|
|
{ ALL_INIT_DATA_SECTIONS, NULL };
|
2008-01-20 17:43:27 +08:00
|
|
|
|
|
|
|
/* all init sections */
|
2014-08-27 18:58:53 +08:00
|
|
|
static const char *const init_sections[] = { ALL_INIT_SECTIONS, NULL };
|
2008-01-20 17:43:27 +08:00
|
|
|
|
2015-04-20 08:50:40 +08:00
|
|
|
/* all text sections */
|
|
|
|
static const char *const text_sections[] = { ALL_TEXT_SECTIONS, NULL };
|
|
|
|
|
2008-01-20 17:43:27 +08:00
|
|
|
/* data section */
|
2014-08-27 18:58:53 +08:00
|
|
|
static const char *const data_sections[] = { DATA_SECTIONS, NULL };
|
2008-01-20 17:43:27 +08:00
|
|
|
|
2014-08-27 18:58:53 +08:00
|
|
|
static const char *const head_sections[] = { ".head.text*", NULL };
|
|
|
|
static const char *const linker_symbols[] =
|
2008-01-20 17:43:27 +08:00
|
|
|
{ "__init_begin", "_sinittext", "_einittext", NULL };
|
2015-04-20 08:50:40 +08:00
|
|
|
static const char *const optim_symbols[] = { "*.constprop.*", NULL };
|
2008-01-20 17:43:27 +08:00
|
|
|
|
2008-01-25 04:12:37 +08:00
|
|
|
enum mismatch {
|
2010-01-30 23:35:47 +08:00
|
|
|
TEXT_TO_ANY_INIT,
|
|
|
|
DATA_TO_ANY_INIT,
|
|
|
|
TEXT_TO_ANY_EXIT,
|
|
|
|
DATA_TO_ANY_EXIT,
|
|
|
|
XXXINIT_TO_SOME_INIT,
|
|
|
|
XXXEXIT_TO_SOME_EXIT,
|
|
|
|
ANY_INIT_TO_ANY_EXIT,
|
|
|
|
ANY_EXIT_TO_ANY_INIT,
|
2008-01-25 04:12:37 +08:00
|
|
|
EXPORT_TO_INIT_EXIT,
|
2015-04-13 19:22:53 +08:00
|
|
|
EXTABLE_TO_NON_TEXT,
|
2008-01-25 04:12:37 +08:00
|
|
|
};
|
|
|
|
|
2015-04-13 19:25:15 +08:00
|
|
|
/**
|
2021-03-26 13:52:19 +08:00
|
|
|
* Describe how to match sections on different criteria:
|
2015-04-13 19:25:15 +08:00
|
|
|
*
|
|
|
|
* @fromsec: Array of sections to be matched.
|
|
|
|
*
|
|
|
|
* @bad_tosec: Relocations applied to a section in @fromsec to a section in
|
|
|
|
* this array is forbidden (black-list). Can be empty.
|
|
|
|
*
|
|
|
|
* @good_tosec: Relocations applied to a section in @fromsec must be
|
2021-03-26 13:52:19 +08:00
|
|
|
* targeting sections in this array (white-list). Can be empty.
|
2015-04-13 19:25:15 +08:00
|
|
|
*
|
|
|
|
* @mismatch: Type of mismatch.
|
|
|
|
*
|
|
|
|
* @handler: Specific handler to call when a match is found. If NULL,
|
|
|
|
* default_mismatch_handler() will be called.
|
|
|
|
*
|
|
|
|
*/
|
2008-01-14 05:21:31 +08:00
|
|
|
struct sectioncheck {
|
|
|
|
const char *fromsec[20];
|
2015-04-13 19:11:04 +08:00
|
|
|
const char *bad_tosec[20];
|
|
|
|
const char *good_tosec[20];
|
2008-01-25 04:12:37 +08:00
|
|
|
enum mismatch mismatch;
|
2015-04-13 19:13:17 +08:00
|
|
|
void (*handler)(const char *modname, struct elf_info *elf,
|
|
|
|
const struct sectioncheck* const mismatch,
|
|
|
|
Elf_Rela *r, Elf_Sym *sym, const char *fromsec);
|
|
|
|
|
2008-01-14 05:21:31 +08:00
|
|
|
};
|
|
|
|
|
2015-04-13 19:22:53 +08:00
|
|
|
static void extable_mismatch_handler(const char *modname, struct elf_info *elf,
|
|
|
|
const struct sectioncheck* const mismatch,
|
|
|
|
Elf_Rela *r, Elf_Sym *sym,
|
|
|
|
const char *fromsec);
|
|
|
|
|
2014-08-27 18:58:53 +08:00
|
|
|
static const struct sectioncheck sectioncheck[] = {
|
2008-01-14 05:21:31 +08:00
|
|
|
/* Do not reference init/exit code/data from
|
|
|
|
* normal code and data
|
|
|
|
*/
|
|
|
|
{
|
2008-01-25 04:12:37 +08:00
|
|
|
.fromsec = { TEXT_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { ALL_INIT_SECTIONS, NULL },
|
2010-01-30 23:35:47 +08:00
|
|
|
.mismatch = TEXT_TO_ANY_INIT,
|
2008-01-25 04:12:37 +08:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.fromsec = { DATA_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { ALL_XXXINIT_SECTIONS, NULL },
|
2010-01-30 23:35:47 +08:00
|
|
|
.mismatch = DATA_TO_ANY_INIT,
|
2008-01-25 04:12:37 +08:00
|
|
|
},
|
2010-01-31 04:14:23 +08:00
|
|
|
{
|
|
|
|
.fromsec = { DATA_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { INIT_SECTIONS, NULL },
|
2010-01-31 04:14:23 +08:00
|
|
|
.mismatch = DATA_TO_ANY_INIT,
|
|
|
|
},
|
2008-01-25 04:12:37 +08:00
|
|
|
{
|
|
|
|
.fromsec = { TEXT_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { ALL_EXIT_SECTIONS, NULL },
|
2010-01-30 23:35:47 +08:00
|
|
|
.mismatch = TEXT_TO_ANY_EXIT,
|
2008-01-25 04:12:37 +08:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.fromsec = { DATA_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { ALL_EXIT_SECTIONS, NULL },
|
2010-01-30 23:35:47 +08:00
|
|
|
.mismatch = DATA_TO_ANY_EXIT,
|
2008-01-21 03:07:28 +08:00
|
|
|
},
|
2013-06-20 07:30:48 +08:00
|
|
|
/* Do not reference init code/data from meminit code/data */
|
2008-01-21 03:07:28 +08:00
|
|
|
{
|
2010-01-29 19:04:26 +08:00
|
|
|
.fromsec = { ALL_XXXINIT_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { INIT_SECTIONS, NULL },
|
2010-01-30 23:35:47 +08:00
|
|
|
.mismatch = XXXINIT_TO_SOME_INIT,
|
2008-01-21 03:07:28 +08:00
|
|
|
},
|
2013-06-20 07:30:48 +08:00
|
|
|
/* Do not reference exit code/data from memexit code/data */
|
2008-01-21 03:07:28 +08:00
|
|
|
{
|
2010-01-29 19:04:26 +08:00
|
|
|
.fromsec = { ALL_XXXEXIT_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { EXIT_SECTIONS, NULL },
|
2010-01-30 23:35:47 +08:00
|
|
|
.mismatch = XXXEXIT_TO_SOME_EXIT,
|
2008-01-14 05:21:31 +08:00
|
|
|
},
|
|
|
|
/* Do not use exit code/data from init code */
|
|
|
|
{
|
2008-01-21 03:07:28 +08:00
|
|
|
.fromsec = { ALL_INIT_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { ALL_EXIT_SECTIONS, NULL },
|
2010-01-30 23:35:47 +08:00
|
|
|
.mismatch = ANY_INIT_TO_ANY_EXIT,
|
2008-01-14 05:21:31 +08:00
|
|
|
},
|
|
|
|
/* Do not use init code/data from exit code */
|
|
|
|
{
|
2008-01-21 03:07:28 +08:00
|
|
|
.fromsec = { ALL_EXIT_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { ALL_INIT_SECTIONS, NULL },
|
2010-01-30 23:35:47 +08:00
|
|
|
.mismatch = ANY_EXIT_TO_ANY_INIT,
|
2008-01-14 05:21:31 +08:00
|
|
|
},
|
2012-06-04 02:48:17 +08:00
|
|
|
{
|
|
|
|
.fromsec = { ALL_PCI_INIT_SECTIONS, NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { INIT_SECTIONS, NULL },
|
2012-06-04 02:48:17 +08:00
|
|
|
.mismatch = ANY_INIT_TO_ANY_EXIT,
|
|
|
|
},
|
2008-01-14 05:21:31 +08:00
|
|
|
/* Do not export init/exit functions or data */
|
|
|
|
{
|
2022-06-11 02:32:30 +08:00
|
|
|
.fromsec = { "___ksymtab*", NULL },
|
2015-04-13 19:11:04 +08:00
|
|
|
.bad_tosec = { INIT_SECTIONS, EXIT_SECTIONS, NULL },
|
2010-01-31 03:52:50 +08:00
|
|
|
.mismatch = EXPORT_TO_INIT_EXIT,
|
2015-04-13 19:22:53 +08:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.fromsec = { "__ex_table", NULL },
|
|
|
|
/* If you're adding any new black-listed sections in here, consider
|
|
|
|
* adding a special 'printer' for them in scripts/check_extable.
|
|
|
|
*/
|
|
|
|
.bad_tosec = { ".altinstr_replacement", NULL },
|
|
|
|
.good_tosec = {ALL_TEXT_SECTIONS , NULL},
|
|
|
|
.mismatch = EXTABLE_TO_NON_TEXT,
|
|
|
|
.handler = extable_mismatch_handler,
|
2008-01-14 05:21:31 +08:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2010-01-30 23:56:20 +08:00
|
|
|
static const struct sectioncheck *section_mismatch(
|
|
|
|
const char *fromsec, const char *tosec)
|
2008-01-14 05:21:31 +08:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2015-04-16 11:46:41 +08:00
|
|
|
/*
|
|
|
|
* The target section could be the SHT_NUL section when we're
|
|
|
|
* handling relocations to un-resolved symbols, trying to match it
|
2018-03-08 17:48:46 +08:00
|
|
|
* doesn't make much sense and causes build failures on parisc
|
|
|
|
* architectures.
|
2015-04-16 11:46:41 +08:00
|
|
|
*/
|
|
|
|
if (*tosec == '\0')
|
|
|
|
return NULL;
|
|
|
|
|
2022-05-24 00:46:25 +08:00
|
|
|
for (i = 0; i < ARRAY_SIZE(sectioncheck); i++) {
|
|
|
|
const struct sectioncheck *check = §ioncheck[i];
|
|
|
|
|
2015-04-13 19:11:04 +08:00
|
|
|
if (match(fromsec, check->fromsec)) {
|
|
|
|
if (check->bad_tosec[0] && match(tosec, check->bad_tosec))
|
|
|
|
return check;
|
|
|
|
if (check->good_tosec[0] && !match(tosec, check->good_tosec))
|
|
|
|
return check;
|
|
|
|
}
|
2008-01-14 05:21:31 +08:00
|
|
|
}
|
2010-01-30 23:56:20 +08:00
|
|
|
return NULL;
|
2008-01-14 05:21:31 +08:00
|
|
|
}
|
|
|
|
|
2006-02-27 05:18:11 +08:00
|
|
|
/**
|
|
|
|
* Whitelist to allow certain references to pass with no warning.
|
2007-05-18 02:14:48 +08:00
|
|
|
*
|
2006-02-27 05:18:11 +08:00
|
|
|
* Pattern 1:
|
|
|
|
* If a module parameter is declared __initdata and permissions=0
|
|
|
|
* then this is legal despite the warning generated.
|
|
|
|
* We cannot see value of permissions here, so just ignore
|
|
|
|
* this pattern.
|
|
|
|
* The pattern is identified by:
|
|
|
|
* tosec = .init.data
|
2006-03-05 07:16:26 +08:00
|
|
|
* fromsec = .data*
|
2006-02-27 05:18:11 +08:00
|
|
|
* atsym =__param*
|
2006-03-03 23:46:04 +08:00
|
|
|
*
|
2010-08-12 13:04:16 +08:00
|
|
|
* Pattern 1a:
|
|
|
|
* module_param_call() ops can refer to __init set function if permissions=0
|
|
|
|
* The pattern is identified by:
|
|
|
|
* tosec = .init.text
|
|
|
|
* fromsec = .data*
|
|
|
|
* atsym = __param_ops_*
|
|
|
|
*
|
2007-01-11 08:52:44 +08:00
|
|
|
* Pattern 3:
|
2009-04-26 17:17:42 +08:00
|
|
|
* Whitelist all references from .head.text to any init section
|
2007-02-27 00:49:06 +08:00
|
|
|
*
|
2007-06-03 06:41:22 +08:00
|
|
|
* Pattern 4:
|
2007-01-11 08:52:44 +08:00
|
|
|
* Some symbols belong to init section but still it is ok to reference
|
|
|
|
* these from non-init sections as these symbols don't have any memory
|
|
|
|
* allocated for them and symbol address and value are same. So even
|
|
|
|
* if init section is freed, its ok to reference those symbols.
|
|
|
|
* For ex. symbols marking the init section boundaries.
|
|
|
|
* This pattern is identified by
|
|
|
|
* refsymname = __init_begin, _sinittext, _einittext
|
2007-02-27 00:49:06 +08:00
|
|
|
*
|
2015-04-20 08:50:40 +08:00
|
|
|
* Pattern 5:
|
|
|
|
* GCC may optimize static inlines when fed constant arg(s) resulting
|
|
|
|
* in functions like cpumask_empty() -- generating an associated symbol
|
|
|
|
* cpumask_empty.constprop.3 that appears in the audit. If the const that
|
|
|
|
* is passed in comes from __init, like say nmi_ipi_mask, we get a
|
|
|
|
* meaningless section warning. May need to add isra symbols too...
|
|
|
|
* This pattern is identified by
|
|
|
|
* tosec = init section
|
|
|
|
* fromsec = text section
|
|
|
|
* refsymname = *.constprop.*
|
|
|
|
*
|
modpost: skip ELF local symbols during section mismatch check
During development of a serial console driver with a gcc 8.2.0
toolchain for RISC-V, the following modpost warning appeared:
----
WARNING: vmlinux.o(.data+0x19b10): Section mismatch in reference from the variable .LANCHOR1 to the function .init.text:sifive_serial_console_setup()
The variable .LANCHOR1 references
the function __init sifive_serial_console_setup()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
----
".LANCHOR1" is an ELF local symbol, automatically created by gcc's section
anchor generation code:
https://gcc.gnu.org/onlinedocs/gccint/Anchored-Addresses.html
https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/varasm.c;h=cd9591a45617464946dcf9a126dde277d9de9804;hb=9fb89fa845c1b2e0a18d85ada0b077c84508ab78#l7473
This was verified by compiling the kernel with -fno-section-anchors
and observing that the ".LANCHOR1" ELF local symbol disappeared, and
modpost no longer warned about the section mismatch. The serial
driver code idiom triggering the warning is standard Linux serial
driver practice that has a specific whitelist inclusion in modpost.c.
I'm neither a modpost nor an ELF expert, but naively, it doesn't seem
useful for modpost to report section mismatch warnings caused by ELF
local symbols by default. Local symbols have compiler-generated
names, and thus bypass modpost's whitelisting algorithm, which relies
on the presence of a non-autogenerated symbol name. This increases
the likelihood that false positive warnings will be generated (as in
the above case).
Thus, disable section mismatch reporting on ELF local symbols. The
rationale here is similar to that of commit 2e3a10a1551d ("ARM: avoid
ARM binutils leaking ELF local symbols") and of similar code already
present in modpost.c:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/mod/modpost.c?h=v4.19-rc4&id=7876320f88802b22d4e2daf7eb027dd14175a0f8#n1256
This third version of the patch implements a suggestion from Masahiro
Yamada <yamada.masahiro@socionext.com> to restructure the code as an
additional pattern matching step inside secref_whitelist(), and
further improves the patch description.
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
2018-11-22 05:14:13 +08:00
|
|
|
* Pattern 6:
|
|
|
|
* Hide section mismatch warnings for ELF local symbols. The goal
|
|
|
|
* is to eliminate false positive modpost warnings caused by
|
|
|
|
* compiler-generated ELF local symbol names such as ".LANCHOR1".
|
|
|
|
* Autogenerated symbol names bypass modpost's "Pattern 2"
|
|
|
|
* whitelisting, which relies on pattern-matching against symbol
|
|
|
|
* names to work. (One situation where gcc can autogenerate ELF
|
|
|
|
* local symbols is when "-fsection-anchors" is used.)
|
2006-02-27 05:18:11 +08:00
|
|
|
**/
|
2010-01-31 03:52:50 +08:00
|
|
|
static int secref_whitelist(const struct sectioncheck *mismatch,
|
|
|
|
const char *fromsec, const char *fromsym,
|
2008-01-24 04:13:50 +08:00
|
|
|
const char *tosec, const char *tosym)
|
2006-02-27 05:18:11 +08:00
|
|
|
{
|
|
|
|
/* Check for pattern 1 */
|
2008-01-20 17:43:27 +08:00
|
|
|
if (match(tosec, init_data_sections) &&
|
|
|
|
match(fromsec, data_sections) &&
|
2018-05-09 17:50:38 +08:00
|
|
|
strstarts(fromsym, "__param"))
|
2008-01-24 04:13:50 +08:00
|
|
|
return 0;
|
2006-02-27 05:18:11 +08:00
|
|
|
|
2010-08-12 13:04:16 +08:00
|
|
|
/* Check for pattern 1a */
|
|
|
|
if (strcmp(tosec, ".init.text") == 0 &&
|
|
|
|
match(fromsec, data_sections) &&
|
2018-05-09 17:50:38 +08:00
|
|
|
strstarts(fromsym, "__param_ops_"))
|
2010-08-12 13:04:16 +08:00
|
|
|
return 0;
|
|
|
|
|
2022-08-01 17:39:02 +08:00
|
|
|
/* symbols in data sections that may refer to any init/exit sections */
|
|
|
|
if (match(fromsec, PATTERNS(DATA_SECTIONS)) &&
|
|
|
|
match(tosec, PATTERNS(ALL_INIT_SECTIONS, ALL_EXIT_SECTIONS)) &&
|
|
|
|
match(fromsym, PATTERNS("*_template", // scsi uses *_template a lot
|
|
|
|
"*_timer", // arm uses ops structures named _timer a lot
|
|
|
|
"*_sht", // scsi also used *_sht to some extent
|
|
|
|
"*_ops",
|
|
|
|
"*_probe",
|
|
|
|
"*_probe_one",
|
|
|
|
"*_console")))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* symbols in data sections that may refer to meminit/exit sections */
|
|
|
|
if (match(fromsec, PATTERNS(DATA_SECTIONS)) &&
|
|
|
|
match(tosec, PATTERNS(ALL_XXXINIT_SECTIONS, ALL_EXIT_SECTIONS)) &&
|
|
|
|
match(fromsym, PATTERNS("*driver")))
|
2008-01-24 04:13:50 +08:00
|
|
|
return 0;
|
2006-02-27 05:18:11 +08:00
|
|
|
|
2007-02-27 00:49:06 +08:00
|
|
|
/* Check for pattern 3 */
|
2008-01-20 17:43:27 +08:00
|
|
|
if (match(fromsec, head_sections) &&
|
|
|
|
match(tosec, init_sections))
|
2008-01-24 04:13:50 +08:00
|
|
|
return 0;
|
2007-02-27 00:49:06 +08:00
|
|
|
|
2007-06-03 06:41:22 +08:00
|
|
|
/* Check for pattern 4 */
|
2008-01-24 04:13:50 +08:00
|
|
|
if (match(tosym, linker_symbols))
|
|
|
|
return 0;
|
2007-02-27 00:49:06 +08:00
|
|
|
|
2015-04-20 08:50:40 +08:00
|
|
|
/* Check for pattern 5 */
|
|
|
|
if (match(fromsec, text_sections) &&
|
|
|
|
match(tosec, init_sections) &&
|
|
|
|
match(fromsym, optim_symbols))
|
|
|
|
return 0;
|
|
|
|
|
modpost: skip ELF local symbols during section mismatch check
During development of a serial console driver with a gcc 8.2.0
toolchain for RISC-V, the following modpost warning appeared:
----
WARNING: vmlinux.o(.data+0x19b10): Section mismatch in reference from the variable .LANCHOR1 to the function .init.text:sifive_serial_console_setup()
The variable .LANCHOR1 references
the function __init sifive_serial_console_setup()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
----
".LANCHOR1" is an ELF local symbol, automatically created by gcc's section
anchor generation code:
https://gcc.gnu.org/onlinedocs/gccint/Anchored-Addresses.html
https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/varasm.c;h=cd9591a45617464946dcf9a126dde277d9de9804;hb=9fb89fa845c1b2e0a18d85ada0b077c84508ab78#l7473
This was verified by compiling the kernel with -fno-section-anchors
and observing that the ".LANCHOR1" ELF local symbol disappeared, and
modpost no longer warned about the section mismatch. The serial
driver code idiom triggering the warning is standard Linux serial
driver practice that has a specific whitelist inclusion in modpost.c.
I'm neither a modpost nor an ELF expert, but naively, it doesn't seem
useful for modpost to report section mismatch warnings caused by ELF
local symbols by default. Local symbols have compiler-generated
names, and thus bypass modpost's whitelisting algorithm, which relies
on the presence of a non-autogenerated symbol name. This increases
the likelihood that false positive warnings will be generated (as in
the above case).
Thus, disable section mismatch reporting on ELF local symbols. The
rationale here is similar to that of commit 2e3a10a1551d ("ARM: avoid
ARM binutils leaking ELF local symbols") and of similar code already
present in modpost.c:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/mod/modpost.c?h=v4.19-rc4&id=7876320f88802b22d4e2daf7eb027dd14175a0f8#n1256
This third version of the patch implements a suggestion from Masahiro
Yamada <yamada.masahiro@socionext.com> to restructure the code as an
additional pattern matching step inside secref_whitelist(), and
further improves the patch description.
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
2018-11-22 05:14:13 +08:00
|
|
|
/* Check for pattern 6 */
|
|
|
|
if (strstarts(fromsym, ".L"))
|
|
|
|
return 0;
|
|
|
|
|
2008-01-24 04:13:50 +08:00
|
|
|
return 1;
|
2006-02-27 05:18:11 +08:00
|
|
|
}
|
|
|
|
|
2018-10-24 06:15:35 +08:00
|
|
|
static inline int is_arm_mapping_symbol(const char *str)
|
|
|
|
{
|
2022-05-24 00:46:22 +08:00
|
|
|
return str[0] == '$' &&
|
|
|
|
(str[1] == 'a' || str[1] == 'd' || str[1] == 't' || str[1] == 'x')
|
2018-10-24 06:15:35 +08:00
|
|
|
&& (str[2] == '\0' || str[2] == '.');
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If there's no name there, ignore it; likewise, ignore it if it's
|
|
|
|
* one of the magic symbols emitted used by current ARM tools.
|
|
|
|
*
|
|
|
|
* Otherwise if find_symbols_between() returns those symbols, they'll
|
|
|
|
* fail the whitelist tests and cause lots of false alarms ... fixable
|
|
|
|
* only by merging __exit and __init sections into __text, bloating
|
|
|
|
* the kernel (which is especially evil on embedded platforms).
|
|
|
|
*/
|
|
|
|
static inline int is_valid_name(struct elf_info *elf, Elf_Sym *sym)
|
|
|
|
{
|
|
|
|
const char *name = elf->strtab + sym->st_name;
|
|
|
|
|
|
|
|
if (!name || !strlen(name))
|
|
|
|
return 0;
|
|
|
|
return !is_arm_mapping_symbol(name);
|
|
|
|
}
|
|
|
|
|
2006-02-19 18:53:35 +08:00
|
|
|
/**
|
|
|
|
* Find symbol based on relocation record info.
|
|
|
|
* In some cases the symbol supplied is a valid symbol so
|
|
|
|
* return refsym. If st_name != 0 we assume this is a valid symbol.
|
|
|
|
* In other cases the symbol needs to be looked up in the symbol table
|
|
|
|
* based on section and address.
|
|
|
|
* **/
|
2008-01-19 04:04:34 +08:00
|
|
|
static Elf_Sym *find_elf_symbol(struct elf_info *elf, Elf64_Sword addr,
|
2006-02-19 18:53:35 +08:00
|
|
|
Elf_Sym *relsym)
|
|
|
|
{
|
|
|
|
Elf_Sym *sym;
|
2008-01-19 04:04:34 +08:00
|
|
|
Elf_Sym *near = NULL;
|
|
|
|
Elf64_Sword distance = 20;
|
|
|
|
Elf64_Sword d;
|
2010-07-29 07:47:53 +08:00
|
|
|
unsigned int relsym_secindex;
|
2006-02-19 18:53:35 +08:00
|
|
|
|
|
|
|
if (relsym->st_name != 0)
|
|
|
|
return relsym;
|
2010-07-29 07:47:53 +08:00
|
|
|
|
|
|
|
relsym_secindex = get_secindex(elf, relsym);
|
2006-02-19 18:53:35 +08:00
|
|
|
for (sym = elf->symtab_start; sym < elf->symtab_stop; sym++) {
|
2010-07-29 07:47:53 +08:00
|
|
|
if (get_secindex(elf, sym) != relsym_secindex)
|
2006-02-19 18:53:35 +08:00
|
|
|
continue;
|
2007-05-22 17:27:39 +08:00
|
|
|
if (ELF_ST_TYPE(sym->st_info) == STT_SECTION)
|
|
|
|
continue;
|
2018-10-24 06:15:35 +08:00
|
|
|
if (!is_valid_name(elf, sym))
|
|
|
|
continue;
|
2006-02-19 18:53:35 +08:00
|
|
|
if (sym->st_value == addr)
|
|
|
|
return sym;
|
2008-01-19 04:04:34 +08:00
|
|
|
/* Find a symbol nearby - addr are maybe negative */
|
|
|
|
d = sym->st_value - addr;
|
|
|
|
if (d < 0)
|
|
|
|
d = addr - sym->st_value;
|
|
|
|
if (d < distance) {
|
|
|
|
distance = d;
|
|
|
|
near = sym;
|
|
|
|
}
|
2006-02-19 18:53:35 +08:00
|
|
|
}
|
2008-01-19 04:04:34 +08:00
|
|
|
/* We need a close match */
|
|
|
|
if (distance < 20)
|
|
|
|
return near;
|
|
|
|
else
|
|
|
|
return NULL;
|
2006-02-19 18:53:35 +08:00
|
|
|
}
|
|
|
|
|
2006-02-18 05:42:02 +08:00
|
|
|
/*
|
2006-03-05 19:02:46 +08:00
|
|
|
* Find symbols before or equal addr and after addr - in the section sec.
|
|
|
|
* If we find two symbols with equal offset prefer one with a valid name.
|
|
|
|
* The ELF format may have a better way to detect what type of symbol
|
|
|
|
* it is, but this works for now.
|
2006-02-18 05:42:02 +08:00
|
|
|
**/
|
2008-01-23 04:44:32 +08:00
|
|
|
static Elf_Sym *find_elf_symbol2(struct elf_info *elf, Elf_Addr addr,
|
|
|
|
const char *sec)
|
2006-02-18 05:42:02 +08:00
|
|
|
{
|
|
|
|
Elf_Sym *sym;
|
2008-01-23 04:44:32 +08:00
|
|
|
Elf_Sym *near = NULL;
|
|
|
|
Elf_Addr distance = ~0;
|
2006-03-03 23:46:04 +08:00
|
|
|
|
2006-02-18 05:42:02 +08:00
|
|
|
for (sym = elf->symtab_start; sym < elf->symtab_stop; sym++) {
|
|
|
|
const char *symsec;
|
|
|
|
|
2010-07-29 07:47:53 +08:00
|
|
|
if (is_shndx_special(sym->st_shndx))
|
2006-02-18 05:42:02 +08:00
|
|
|
continue;
|
2010-07-29 07:47:53 +08:00
|
|
|
symsec = sec_name(elf, get_secindex(elf, sym));
|
2006-02-18 05:42:02 +08:00
|
|
|
if (strcmp(symsec, sec) != 0)
|
|
|
|
continue;
|
2007-02-21 05:58:16 +08:00
|
|
|
if (!is_valid_name(elf, sym))
|
|
|
|
continue;
|
2022-05-24 00:46:26 +08:00
|
|
|
if (sym->st_value <= addr && addr - sym->st_value <= distance) {
|
|
|
|
distance = addr - sym->st_value;
|
|
|
|
near = sym;
|
2006-02-18 05:42:02 +08:00
|
|
|
}
|
|
|
|
}
|
2008-01-23 04:44:32 +08:00
|
|
|
return near;
|
2006-02-18 05:42:02 +08:00
|
|
|
}
|
|
|
|
|
2008-01-25 04:12:37 +08:00
|
|
|
static int is_function(Elf_Sym *sym)
|
|
|
|
{
|
|
|
|
if (sym)
|
|
|
|
return ELF_ST_TYPE(sym->st_info) == STT_FUNC;
|
|
|
|
else
|
2008-02-07 04:51:18 +08:00
|
|
|
return -1;
|
2008-01-25 04:12:37 +08:00
|
|
|
}
|
|
|
|
|
2015-04-13 19:13:34 +08:00
|
|
|
static inline void get_pretty_name(int is_func, const char** name, const char** name_p)
|
|
|
|
{
|
|
|
|
switch (is_func) {
|
|
|
|
case 0: *name = "variable"; *name_p = ""; break;
|
|
|
|
case 1: *name = "function"; *name_p = "()"; break;
|
|
|
|
default: *name = "(unknown reference)"; *name_p = ""; break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-01-24 04:13:50 +08:00
|
|
|
/*
|
2006-02-18 05:42:02 +08:00
|
|
|
* Print a warning about a section mismatch.
|
|
|
|
* Try to find symbols near it so user can find it.
|
2006-02-27 05:18:11 +08:00
|
|
|
* Check whitelist before warning - it may be a false positive.
|
2008-01-24 04:13:50 +08:00
|
|
|
*/
|
2010-01-30 23:56:20 +08:00
|
|
|
static void report_sec_mismatch(const char *modname,
|
|
|
|
const struct sectioncheck *mismatch,
|
2014-06-10 18:08:13 +08:00
|
|
|
const char *fromsec,
|
|
|
|
const char *fromsym,
|
2022-08-01 17:38:59 +08:00
|
|
|
const char *tosec, const char *tosym)
|
2008-01-25 04:12:37 +08:00
|
|
|
{
|
2008-02-03 01:57:18 +08:00
|
|
|
sec_mismatch_count++;
|
|
|
|
|
2010-01-30 23:56:20 +08:00
|
|
|
switch (mismatch->mismatch) {
|
2010-01-30 23:35:47 +08:00
|
|
|
case TEXT_TO_ANY_INIT:
|
2022-08-01 17:38:59 +08:00
|
|
|
case DATA_TO_ANY_INIT:
|
2010-01-30 23:35:47 +08:00
|
|
|
case TEXT_TO_ANY_EXIT:
|
2022-08-01 17:38:59 +08:00
|
|
|
case DATA_TO_ANY_EXIT:
|
2010-01-30 23:35:47 +08:00
|
|
|
case XXXINIT_TO_SOME_INIT:
|
|
|
|
case XXXEXIT_TO_SOME_EXIT:
|
|
|
|
case ANY_INIT_TO_ANY_EXIT:
|
|
|
|
case ANY_EXIT_TO_ANY_INIT:
|
2022-08-01 17:38:59 +08:00
|
|
|
warn("%s: section mismatch in reference: %s (section: %s) -> %s (section: %s)\n",
|
|
|
|
modname, fromsym, fromsec, tosym, tosec);
|
2008-01-25 04:12:37 +08:00
|
|
|
break;
|
|
|
|
case EXPORT_TO_INIT_EXIT:
|
2022-08-01 17:38:59 +08:00
|
|
|
warn("%s: EXPORT_SYMBOL used for init/exit symbol: %s (section: %s)\n",
|
|
|
|
modname, tosym, tosec);
|
2008-01-25 04:12:37 +08:00
|
|
|
break;
|
2015-04-13 19:22:53 +08:00
|
|
|
case EXTABLE_TO_NON_TEXT:
|
2022-08-01 17:38:59 +08:00
|
|
|
fatal("There's a special handler for this mismatch type, we should never get here.\n");
|
2015-04-13 19:22:53 +08:00
|
|
|
break;
|
2008-01-25 04:12:37 +08:00
|
|
|
}
|
2008-01-24 04:13:50 +08:00
|
|
|
}
|
|
|
|
|
2015-04-13 19:13:17 +08:00
|
|
|
static void default_mismatch_handler(const char *modname, struct elf_info *elf,
|
|
|
|
const struct sectioncheck* const mismatch,
|
|
|
|
Elf_Rela *r, Elf_Sym *sym, const char *fromsec)
|
2008-01-24 04:13:50 +08:00
|
|
|
{
|
|
|
|
const char *tosec;
|
2015-04-13 19:13:17 +08:00
|
|
|
Elf_Sym *to;
|
|
|
|
Elf_Sym *from;
|
|
|
|
const char *tosym;
|
|
|
|
const char *fromsym;
|
2008-01-24 04:13:50 +08:00
|
|
|
|
2015-04-13 19:13:17 +08:00
|
|
|
from = find_elf_symbol2(elf, r->r_offset, fromsec);
|
|
|
|
fromsym = sym_name(elf, from);
|
|
|
|
|
2015-04-13 19:13:45 +08:00
|
|
|
tosec = sec_name(elf, get_secindex(elf, sym));
|
|
|
|
to = find_elf_symbol(elf, r->r_addend, sym);
|
|
|
|
tosym = sym_name(elf, to);
|
|
|
|
|
2015-04-13 19:13:17 +08:00
|
|
|
/* check whitelist - we may ignore it */
|
|
|
|
if (secref_whitelist(mismatch,
|
|
|
|
fromsec, fromsym, tosec, tosym)) {
|
|
|
|
report_sec_mismatch(modname, mismatch,
|
2022-08-01 17:38:59 +08:00
|
|
|
fromsec, fromsym, tosec, tosym);
|
2015-04-13 19:13:17 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-04-13 19:22:53 +08:00
|
|
|
static int is_executable_section(struct elf_info* elf, unsigned int section_index)
|
|
|
|
{
|
|
|
|
if (section_index > elf->num_sections)
|
|
|
|
fatal("section_index is outside elf->num_sections!\n");
|
|
|
|
|
|
|
|
return ((elf->sechdrs[section_index].sh_flags & SHF_EXECINSTR) == SHF_EXECINSTR);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We rely on a gross hack in section_rel[a]() calling find_extable_entry_size()
|
|
|
|
* to know the sizeof(struct exception_table_entry) for the target architecture.
|
|
|
|
*/
|
|
|
|
static unsigned int extable_entry_size = 0;
|
2015-04-16 11:35:36 +08:00
|
|
|
static void find_extable_entry_size(const char* const sec, const Elf_Rela* r)
|
2015-04-13 19:22:53 +08:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
* If we're currently checking the second relocation within __ex_table,
|
|
|
|
* that relocation offset tells us the offsetof(struct
|
|
|
|
* exception_table_entry, fixup) which is equal to sizeof(struct
|
|
|
|
* exception_table_entry) divided by two. We use that to our advantage
|
|
|
|
* since there's no portable way to get that size as every architecture
|
|
|
|
* seems to go with different sized types. Not pretty but better than
|
|
|
|
* hard-coding the size for every architecture..
|
|
|
|
*/
|
2015-04-16 11:35:36 +08:00
|
|
|
if (!extable_entry_size)
|
2015-04-13 19:22:53 +08:00
|
|
|
extable_entry_size = r->r_offset * 2;
|
|
|
|
}
|
2015-04-16 11:35:36 +08:00
|
|
|
|
2015-04-13 19:22:53 +08:00
|
|
|
static inline bool is_extable_fault_address(Elf_Rela *r)
|
|
|
|
{
|
2015-04-16 11:33:32 +08:00
|
|
|
/*
|
|
|
|
* extable_entry_size is only discovered after we've handled the
|
|
|
|
* _second_ relocation in __ex_table, so only abort when we're not
|
|
|
|
* handling the first reloc and extable_entry_size is zero.
|
|
|
|
*/
|
|
|
|
if (r->r_offset && extable_entry_size == 0)
|
2015-04-13 19:22:53 +08:00
|
|
|
fatal("extable_entry size hasn't been discovered!\n");
|
|
|
|
|
|
|
|
return ((r->r_offset == 0) ||
|
|
|
|
(r->r_offset % extable_entry_size == 0));
|
|
|
|
}
|
|
|
|
|
2015-04-16 11:35:36 +08:00
|
|
|
#define is_second_extable_reloc(Start, Cur, Sec) \
|
|
|
|
(((Cur) == (Start) + 1) && (strcmp("__ex_table", (Sec)) == 0))
|
|
|
|
|
2015-04-13 19:22:53 +08:00
|
|
|
static void report_extable_warnings(const char* modname, struct elf_info* elf,
|
|
|
|
const struct sectioncheck* const mismatch,
|
|
|
|
Elf_Rela* r, Elf_Sym* sym,
|
|
|
|
const char* fromsec, const char* tosec)
|
|
|
|
{
|
|
|
|
Elf_Sym* fromsym = find_elf_symbol2(elf, r->r_offset, fromsec);
|
|
|
|
const char* fromsym_name = sym_name(elf, fromsym);
|
|
|
|
Elf_Sym* tosym = find_elf_symbol(elf, r->r_addend, sym);
|
|
|
|
const char* tosym_name = sym_name(elf, tosym);
|
|
|
|
const char* from_pretty_name;
|
|
|
|
const char* from_pretty_name_p;
|
|
|
|
const char* to_pretty_name;
|
|
|
|
const char* to_pretty_name_p;
|
|
|
|
|
|
|
|
get_pretty_name(is_function(fromsym),
|
|
|
|
&from_pretty_name, &from_pretty_name_p);
|
|
|
|
get_pretty_name(is_function(tosym),
|
|
|
|
&to_pretty_name, &to_pretty_name_p);
|
|
|
|
|
|
|
|
warn("%s(%s+0x%lx): Section mismatch in reference"
|
|
|
|
" from the %s %s%s to the %s %s:%s%s\n",
|
|
|
|
modname, fromsec, (long)r->r_offset, from_pretty_name,
|
|
|
|
fromsym_name, from_pretty_name_p,
|
|
|
|
to_pretty_name, tosec, tosym_name, to_pretty_name_p);
|
|
|
|
|
|
|
|
if (!match(tosec, mismatch->bad_tosec) &&
|
|
|
|
is_executable_section(elf, get_secindex(elf, sym)))
|
|
|
|
fprintf(stderr,
|
|
|
|
"The relocation at %s+0x%lx references\n"
|
|
|
|
"section \"%s\" which is not in the list of\n"
|
|
|
|
"authorized sections. If you're adding a new section\n"
|
|
|
|
"and/or if this reference is valid, add \"%s\" to the\n"
|
|
|
|
"list of authorized sections to jump to on fault.\n"
|
|
|
|
"This can be achieved by adding \"%s\" to \n"
|
|
|
|
"OTHER_TEXT_SECTIONS in scripts/mod/modpost.c.\n",
|
|
|
|
fromsec, (long)r->r_offset, tosec, tosec, tosec);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void extable_mismatch_handler(const char* modname, struct elf_info *elf,
|
|
|
|
const struct sectioncheck* const mismatch,
|
|
|
|
Elf_Rela* r, Elf_Sym* sym,
|
|
|
|
const char *fromsec)
|
|
|
|
{
|
|
|
|
const char* tosec = sec_name(elf, get_secindex(elf, sym));
|
|
|
|
|
|
|
|
sec_mismatch_count++;
|
|
|
|
|
2019-02-01 12:50:45 +08:00
|
|
|
report_extable_warnings(modname, elf, mismatch, r, sym, fromsec, tosec);
|
2015-04-13 19:22:53 +08:00
|
|
|
|
|
|
|
if (match(tosec, mismatch->bad_tosec))
|
|
|
|
fatal("The relocation at %s+0x%lx references\n"
|
|
|
|
"section \"%s\" which is black-listed.\n"
|
|
|
|
"Something is seriously wrong and should be fixed.\n"
|
|
|
|
"You might get more information about where this is\n"
|
|
|
|
"coming from by using scripts/check_extable.sh %s\n",
|
|
|
|
fromsec, (long)r->r_offset, tosec, modname);
|
|
|
|
else if (!is_executable_section(elf, get_secindex(elf, sym))) {
|
|
|
|
if (is_extable_fault_address(r))
|
|
|
|
fatal("The relocation at %s+0x%lx references\n"
|
|
|
|
"section \"%s\" which is not executable, IOW\n"
|
|
|
|
"it is not possible for the kernel to fault\n"
|
|
|
|
"at that address. Something is seriously wrong\n"
|
|
|
|
"and should be fixed.\n",
|
|
|
|
fromsec, (long)r->r_offset, tosec);
|
|
|
|
else
|
|
|
|
fatal("The relocation at %s+0x%lx references\n"
|
|
|
|
"section \"%s\" which is not executable, IOW\n"
|
|
|
|
"the kernel will fault if it ever tries to\n"
|
|
|
|
"jump to it. Something is seriously wrong\n"
|
|
|
|
"and should be fixed.\n",
|
|
|
|
fromsec, (long)r->r_offset, tosec);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-04-13 19:13:17 +08:00
|
|
|
static void check_section_mismatch(const char *modname, struct elf_info *elf,
|
|
|
|
Elf_Rela *r, Elf_Sym *sym, const char *fromsec)
|
|
|
|
{
|
2018-01-16 21:21:29 +08:00
|
|
|
const char *tosec = sec_name(elf, get_secindex(elf, sym));
|
2015-04-13 19:13:17 +08:00
|
|
|
const struct sectioncheck *mismatch = section_mismatch(fromsec, tosec);
|
|
|
|
|
2010-01-30 23:56:20 +08:00
|
|
|
if (mismatch) {
|
2015-04-13 19:13:17 +08:00
|
|
|
if (mismatch->handler)
|
|
|
|
mismatch->handler(modname, elf, mismatch,
|
|
|
|
r, sym, fromsec);
|
|
|
|
else
|
|
|
|
default_mismatch_handler(modname, elf, mismatch,
|
|
|
|
r, sym, fromsec);
|
2006-02-18 05:42:02 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-05-22 17:27:39 +08:00
|
|
|
static unsigned int *reloc_location(struct elf_info *elf,
|
2008-01-19 04:49:29 +08:00
|
|
|
Elf_Shdr *sechdr, Elf_Rela *r)
|
2007-05-22 17:27:39 +08:00
|
|
|
{
|
2020-05-25 13:47:04 +08:00
|
|
|
return sym_get_data_by_offset(elf, sechdr->sh_info, r->r_offset);
|
2007-05-22 17:27:39 +08:00
|
|
|
}
|
|
|
|
|
2008-01-19 04:49:29 +08:00
|
|
|
static int addend_386_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
|
2007-05-22 17:27:39 +08:00
|
|
|
{
|
|
|
|
unsigned int r_typ = ELF_R_TYPE(r->r_info);
|
2008-01-19 04:49:29 +08:00
|
|
|
unsigned int *location = reloc_location(elf, sechdr, r);
|
2007-05-22 17:27:39 +08:00
|
|
|
|
|
|
|
switch (r_typ) {
|
|
|
|
case R_386_32:
|
|
|
|
r->r_addend = TO_NATIVE(*location);
|
|
|
|
break;
|
|
|
|
case R_386_PC32:
|
|
|
|
r->r_addend = TO_NATIVE(*location) + 4;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-02-15 04:58:56 +08:00
|
|
|
#ifndef R_ARM_CALL
|
|
|
|
#define R_ARM_CALL 28
|
|
|
|
#endif
|
|
|
|
#ifndef R_ARM_JUMP24
|
|
|
|
#define R_ARM_JUMP24 29
|
|
|
|
#endif
|
|
|
|
|
2014-02-15 05:41:18 +08:00
|
|
|
#ifndef R_ARM_THM_CALL
|
|
|
|
#define R_ARM_THM_CALL 10
|
|
|
|
#endif
|
|
|
|
#ifndef R_ARM_THM_JUMP24
|
|
|
|
#define R_ARM_THM_JUMP24 30
|
|
|
|
#endif
|
|
|
|
#ifndef R_ARM_THM_JUMP19
|
|
|
|
#define R_ARM_THM_JUMP19 51
|
|
|
|
#endif
|
|
|
|
|
2008-01-19 04:49:29 +08:00
|
|
|
static int addend_arm_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
|
2007-07-17 04:39:35 +08:00
|
|
|
{
|
|
|
|
unsigned int r_typ = ELF_R_TYPE(r->r_info);
|
|
|
|
|
|
|
|
switch (r_typ) {
|
|
|
|
case R_ARM_ABS32:
|
|
|
|
/* From ARM ABI: (S + A) | T */
|
2008-01-12 02:17:15 +08:00
|
|
|
r->r_addend = (int)(long)
|
2014-06-10 18:08:13 +08:00
|
|
|
(elf->symtab_start + ELF_R_SYM(r->r_info));
|
2007-07-17 04:39:35 +08:00
|
|
|
break;
|
|
|
|
case R_ARM_PC24:
|
2012-02-15 04:58:56 +08:00
|
|
|
case R_ARM_CALL:
|
|
|
|
case R_ARM_JUMP24:
|
2014-02-15 05:41:18 +08:00
|
|
|
case R_ARM_THM_CALL:
|
|
|
|
case R_ARM_THM_JUMP24:
|
|
|
|
case R_ARM_THM_JUMP19:
|
2007-07-17 04:39:35 +08:00
|
|
|
/* From ARM ABI: ((S + A) | T) - P */
|
2008-01-12 02:17:15 +08:00
|
|
|
r->r_addend = (int)(long)(elf->hdr +
|
2014-06-10 18:08:13 +08:00
|
|
|
sechdr->sh_offset +
|
|
|
|
(r->r_offset - sechdr->sh_addr));
|
2007-07-17 04:39:35 +08:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-01-19 04:49:29 +08:00
|
|
|
static int addend_mips_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
|
2007-05-22 17:27:39 +08:00
|
|
|
{
|
|
|
|
unsigned int r_typ = ELF_R_TYPE(r->r_info);
|
2008-01-19 04:49:29 +08:00
|
|
|
unsigned int *location = reloc_location(elf, sechdr, r);
|
2007-05-22 17:27:39 +08:00
|
|
|
unsigned int inst;
|
|
|
|
|
|
|
|
if (r_typ == R_MIPS_HI16)
|
|
|
|
return 1; /* skip this */
|
|
|
|
inst = TO_NATIVE(*location);
|
|
|
|
switch (r_typ) {
|
|
|
|
case R_MIPS_LO16:
|
|
|
|
r->r_addend = inst & 0xffff;
|
|
|
|
break;
|
|
|
|
case R_MIPS_26:
|
|
|
|
r->r_addend = (inst & 0x03ffffff) << 2;
|
|
|
|
break;
|
|
|
|
case R_MIPS_32:
|
|
|
|
r->r_addend = inst;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-11-18 19:22:51 +08:00
|
|
|
#ifndef EM_RISCV
|
|
|
|
#define EM_RISCV 243
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifndef R_RISCV_SUB32
|
|
|
|
#define R_RISCV_SUB32 39
|
|
|
|
#endif
|
|
|
|
|
2008-01-19 04:49:29 +08:00
|
|
|
static void section_rela(const char *modname, struct elf_info *elf,
|
2014-06-10 18:08:13 +08:00
|
|
|
Elf_Shdr *sechdr)
|
2008-01-19 04:49:29 +08:00
|
|
|
{
|
|
|
|
Elf_Sym *sym;
|
|
|
|
Elf_Rela *rela;
|
|
|
|
Elf_Rela r;
|
|
|
|
unsigned int r_sym;
|
|
|
|
const char *fromsec;
|
|
|
|
|
2008-01-24 02:54:27 +08:00
|
|
|
Elf_Rela *start = (void *)elf->hdr + sechdr->sh_offset;
|
2008-01-19 04:49:29 +08:00
|
|
|
Elf_Rela *stop = (void *)start + sechdr->sh_size;
|
|
|
|
|
2022-07-31 01:36:35 +08:00
|
|
|
fromsec = sec_name(elf, sechdr->sh_info);
|
2008-01-19 04:49:29 +08:00
|
|
|
/* if from section (name) is know good then skip it */
|
2009-04-24 04:49:33 +08:00
|
|
|
if (match(fromsec, section_white_list))
|
2008-01-19 04:49:29 +08:00
|
|
|
return;
|
2008-01-29 03:13:13 +08:00
|
|
|
|
2008-01-19 04:49:29 +08:00
|
|
|
for (rela = start; rela < stop; rela++) {
|
|
|
|
r.r_offset = TO_NATIVE(rela->r_offset);
|
|
|
|
#if KERNEL_ELFCLASS == ELFCLASS64
|
2008-01-24 02:54:27 +08:00
|
|
|
if (elf->hdr->e_machine == EM_MIPS) {
|
2008-01-19 04:49:29 +08:00
|
|
|
unsigned int r_typ;
|
|
|
|
r_sym = ELF64_MIPS_R_SYM(rela->r_info);
|
|
|
|
r_sym = TO_NATIVE(r_sym);
|
|
|
|
r_typ = ELF64_MIPS_R_TYPE(rela->r_info);
|
|
|
|
r.r_info = ELF64_R_INFO(r_sym, r_typ);
|
|
|
|
} else {
|
|
|
|
r.r_info = TO_NATIVE(rela->r_info);
|
|
|
|
r_sym = ELF_R_SYM(r.r_info);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
r.r_info = TO_NATIVE(rela->r_info);
|
|
|
|
r_sym = ELF_R_SYM(r.r_info);
|
|
|
|
#endif
|
|
|
|
r.r_addend = TO_NATIVE(rela->r_addend);
|
2021-11-18 19:22:51 +08:00
|
|
|
switch (elf->hdr->e_machine) {
|
|
|
|
case EM_RISCV:
|
|
|
|
if (!strcmp("__ex_table", fromsec) &&
|
|
|
|
ELF_R_TYPE(r.r_info) == R_RISCV_SUB32)
|
|
|
|
continue;
|
|
|
|
break;
|
|
|
|
}
|
2008-01-19 04:49:29 +08:00
|
|
|
sym = elf->symtab_start + r_sym;
|
|
|
|
/* Skip special sections */
|
2010-07-29 07:47:53 +08:00
|
|
|
if (is_shndx_special(sym->st_shndx))
|
2008-01-19 04:49:29 +08:00
|
|
|
continue;
|
2015-04-16 11:35:36 +08:00
|
|
|
if (is_second_extable_reloc(start, rela, fromsec))
|
|
|
|
find_extable_entry_size(fromsec, &r);
|
2008-01-24 04:13:50 +08:00
|
|
|
check_section_mismatch(modname, elf, &r, sym, fromsec);
|
2008-01-19 04:49:29 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void section_rel(const char *modname, struct elf_info *elf,
|
2014-06-10 18:08:13 +08:00
|
|
|
Elf_Shdr *sechdr)
|
2008-01-19 04:49:29 +08:00
|
|
|
{
|
|
|
|
Elf_Sym *sym;
|
|
|
|
Elf_Rel *rel;
|
|
|
|
Elf_Rela r;
|
|
|
|
unsigned int r_sym;
|
|
|
|
const char *fromsec;
|
|
|
|
|
2008-01-24 02:54:27 +08:00
|
|
|
Elf_Rel *start = (void *)elf->hdr + sechdr->sh_offset;
|
2008-01-19 04:49:29 +08:00
|
|
|
Elf_Rel *stop = (void *)start + sechdr->sh_size;
|
|
|
|
|
2022-07-31 01:36:35 +08:00
|
|
|
fromsec = sec_name(elf, sechdr->sh_info);
|
2008-01-19 04:49:29 +08:00
|
|
|
/* if from section (name) is know good then skip it */
|
2009-04-24 04:49:33 +08:00
|
|
|
if (match(fromsec, section_white_list))
|
2008-01-19 04:49:29 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
for (rel = start; rel < stop; rel++) {
|
|
|
|
r.r_offset = TO_NATIVE(rel->r_offset);
|
|
|
|
#if KERNEL_ELFCLASS == ELFCLASS64
|
2008-01-24 02:54:27 +08:00
|
|
|
if (elf->hdr->e_machine == EM_MIPS) {
|
2008-01-19 04:49:29 +08:00
|
|
|
unsigned int r_typ;
|
|
|
|
r_sym = ELF64_MIPS_R_SYM(rel->r_info);
|
|
|
|
r_sym = TO_NATIVE(r_sym);
|
|
|
|
r_typ = ELF64_MIPS_R_TYPE(rel->r_info);
|
|
|
|
r.r_info = ELF64_R_INFO(r_sym, r_typ);
|
|
|
|
} else {
|
|
|
|
r.r_info = TO_NATIVE(rel->r_info);
|
|
|
|
r_sym = ELF_R_SYM(r.r_info);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
r.r_info = TO_NATIVE(rel->r_info);
|
|
|
|
r_sym = ELF_R_SYM(r.r_info);
|
|
|
|
#endif
|
|
|
|
r.r_addend = 0;
|
2008-01-24 02:54:27 +08:00
|
|
|
switch (elf->hdr->e_machine) {
|
2008-01-19 04:49:29 +08:00
|
|
|
case EM_386:
|
|
|
|
if (addend_386_rel(elf, sechdr, &r))
|
|
|
|
continue;
|
|
|
|
break;
|
|
|
|
case EM_ARM:
|
|
|
|
if (addend_arm_rel(elf, sechdr, &r))
|
|
|
|
continue;
|
|
|
|
break;
|
|
|
|
case EM_MIPS:
|
|
|
|
if (addend_mips_rel(elf, sechdr, &r))
|
|
|
|
continue;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
sym = elf->symtab_start + r_sym;
|
|
|
|
/* Skip special sections */
|
2010-07-29 07:47:53 +08:00
|
|
|
if (is_shndx_special(sym->st_shndx))
|
2008-01-19 04:49:29 +08:00
|
|
|
continue;
|
2015-04-16 11:35:36 +08:00
|
|
|
if (is_second_extable_reloc(start, rel, fromsec))
|
|
|
|
find_extable_entry_size(fromsec, &r);
|
2008-01-24 04:13:50 +08:00
|
|
|
check_section_mismatch(modname, elf, &r, sym, fromsec);
|
2008-01-19 04:49:29 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-02-18 05:42:02 +08:00
|
|
|
/**
|
|
|
|
* A module includes a number of sections that are discarded
|
|
|
|
* either when loaded or when used as built-in.
|
|
|
|
* For loaded modules all functions marked __init and all data
|
tree-wide: fix comment/printk typos
"gadget", "through", "command", "maintain", "maintain", "controller", "address",
"between", "initiali[zs]e", "instead", "function", "select", "already",
"equal", "access", "management", "hierarchy", "registration", "interest",
"relative", "memory", "offset", "already",
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
2010-11-02 03:38:34 +08:00
|
|
|
* marked __initdata will be discarded when the module has been initialized.
|
2006-02-18 05:42:02 +08:00
|
|
|
* Likewise for modules used built-in the sections marked __exit
|
|
|
|
* are discarded because __exit marked function are supposed to be called
|
2008-07-30 13:33:44 +08:00
|
|
|
* only when a module is unloaded which never happens for built-in modules.
|
2006-02-18 05:42:02 +08:00
|
|
|
* The check_sec_ref() function traverses all relocation records
|
|
|
|
* to find all references to a section that reference a section that will
|
|
|
|
* be discarded and warns about it.
|
|
|
|
**/
|
2022-05-24 00:46:23 +08:00
|
|
|
static void check_sec_ref(const char *modname, struct elf_info *elf)
|
2006-02-18 05:42:02 +08:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
Elf_Shdr *sechdrs = elf->sechdrs;
|
2006-03-03 23:46:04 +08:00
|
|
|
|
2006-02-18 05:42:02 +08:00
|
|
|
/* Walk through all sections */
|
2010-07-29 07:47:53 +08:00
|
|
|
for (i = 0; i < elf->num_sections; i++) {
|
2009-04-24 04:49:33 +08:00
|
|
|
check_section(modname, elf, &elf->sechdrs[i]);
|
2006-02-18 05:42:02 +08:00
|
|
|
/* We want to process only relocation sections and not .init */
|
2008-01-19 04:49:29 +08:00
|
|
|
if (sechdrs[i].sh_type == SHT_RELA)
|
2008-01-14 05:21:31 +08:00
|
|
|
section_rela(modname, elf, &elf->sechdrs[i]);
|
2008-01-19 04:49:29 +08:00
|
|
|
else if (sechdrs[i].sh_type == SHT_REL)
|
2008-01-14 05:21:31 +08:00
|
|
|
section_rel(modname, elf, &elf->sechdrs[i]);
|
2006-02-18 05:42:02 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-02-08 16:01:12 +08:00
|
|
|
static char *remove_dot(char *s)
|
|
|
|
{
|
2014-07-27 05:57:01 +08:00
|
|
|
size_t n = strcspn(s, ".");
|
2014-02-08 16:01:12 +08:00
|
|
|
|
2014-07-27 05:57:01 +08:00
|
|
|
if (n && s[n]) {
|
|
|
|
size_t m = strspn(s + n + 1, "0123456789");
|
2022-05-24 23:27:18 +08:00
|
|
|
if (m && (s[n + m + 1] == '.' || s[n + m + 1] == 0))
|
2014-02-08 16:01:12 +08:00
|
|
|
s[n] = 0;
|
|
|
|
}
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
2022-05-13 19:39:21 +08:00
|
|
|
/*
|
|
|
|
* The CRCs are recorded in .*.cmd files in the form of:
|
|
|
|
* #SYMVER <name> <crc>
|
|
|
|
*/
|
|
|
|
static void extract_crcs_for_object(const char *object, struct module *mod)
|
|
|
|
{
|
|
|
|
char cmd_file[PATH_MAX];
|
|
|
|
char *buf, *p;
|
|
|
|
const char *base;
|
|
|
|
int dirlen, ret;
|
|
|
|
|
|
|
|
base = strrchr(object, '/');
|
|
|
|
if (base) {
|
|
|
|
base++;
|
|
|
|
dirlen = base - object;
|
|
|
|
} else {
|
|
|
|
dirlen = 0;
|
|
|
|
base = object;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = snprintf(cmd_file, sizeof(cmd_file), "%.*s.%s.cmd",
|
|
|
|
dirlen, object, base);
|
|
|
|
if (ret >= sizeof(cmd_file)) {
|
|
|
|
error("%s: too long path was truncated\n", cmd_file);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
buf = read_text_file(cmd_file);
|
|
|
|
p = buf;
|
|
|
|
|
|
|
|
while ((p = strstr(p, "\n#SYMVER "))) {
|
|
|
|
char *name;
|
|
|
|
size_t namelen;
|
|
|
|
unsigned int crc;
|
|
|
|
struct symbol *sym;
|
|
|
|
|
|
|
|
name = p + strlen("\n#SYMVER ");
|
|
|
|
|
|
|
|
p = strchr(name, ' ');
|
|
|
|
if (!p)
|
|
|
|
break;
|
|
|
|
|
|
|
|
namelen = p - name;
|
|
|
|
p++;
|
|
|
|
|
|
|
|
if (!isdigit(*p))
|
|
|
|
continue; /* skip this line */
|
|
|
|
|
|
|
|
crc = strtol(p, &p, 0);
|
|
|
|
if (*p != '\n')
|
|
|
|
continue; /* skip this line */
|
|
|
|
|
|
|
|
name[namelen] = '\0';
|
|
|
|
|
|
|
|
/*
|
|
|
|
* sym_find_with_module() may return NULL here.
|
|
|
|
* It typically occurs when CONFIG_TRIM_UNUSED_KSYMS=y.
|
|
|
|
* Since commit e1327a127703, genksyms calculates CRCs of all
|
|
|
|
* symbols, including trimmed ones. Ignore orphan CRCs.
|
|
|
|
*/
|
|
|
|
sym = sym_find_with_module(name, mod);
|
|
|
|
if (sym)
|
|
|
|
sym_set_crc(sym, crc);
|
|
|
|
}
|
|
|
|
|
|
|
|
free(buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The symbol versions (CRC) are recorded in the .*.cmd files.
|
|
|
|
* Parse them to retrieve CRCs for the current module.
|
|
|
|
*/
|
|
|
|
static void mod_set_crcs(struct module *mod)
|
|
|
|
{
|
|
|
|
char objlist[PATH_MAX];
|
|
|
|
char *buf, *p, *obj;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (mod->is_vmlinux) {
|
|
|
|
strcpy(objlist, ".vmlinux.objs");
|
|
|
|
} else {
|
|
|
|
/* objects for a module are listed in the *.mod file. */
|
|
|
|
ret = snprintf(objlist, sizeof(objlist), "%s.mod", mod->name);
|
|
|
|
if (ret >= sizeof(objlist)) {
|
|
|
|
error("%s: too long path was truncated\n", objlist);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
buf = read_text_file(objlist);
|
|
|
|
p = buf;
|
|
|
|
|
|
|
|
while ((obj = strsep(&p, "\n")) && obj[0])
|
|
|
|
extract_crcs_for_object(obj, mod);
|
|
|
|
|
|
|
|
free(buf);
|
|
|
|
}
|
|
|
|
|
2018-05-09 17:50:40 +08:00
|
|
|
static void read_symbols(const char *modname)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
const char *symname;
|
|
|
|
char *version;
|
2006-06-10 03:53:55 +08:00
|
|
|
char *license;
|
2019-09-06 18:32:28 +08:00
|
|
|
char *namespace;
|
2005-04-17 06:20:36 +08:00
|
|
|
struct module *mod;
|
|
|
|
struct elf_info info = { };
|
|
|
|
Elf_Sym *sym;
|
|
|
|
|
2007-02-26 22:33:52 +08:00
|
|
|
if (!parse_elf(&info, modname))
|
|
|
|
return;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2022-05-30 17:01:38 +08:00
|
|
|
if (!strends(modname, ".o")) {
|
|
|
|
error("%s: filename must be suffixed with .o\n", modname);
|
|
|
|
return;
|
2020-06-01 13:57:29 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2022-05-30 17:01:38 +08:00
|
|
|
/* strip trailing .o */
|
|
|
|
mod = new_module(modname, strlen(modname) - strlen(".o"));
|
|
|
|
|
2020-06-01 13:57:26 +08:00
|
|
|
if (!mod->is_vmlinux) {
|
2020-06-01 13:57:16 +08:00
|
|
|
license = get_modinfo(&info, "license");
|
|
|
|
if (!license)
|
2020-12-01 18:34:16 +08:00
|
|
|
error("missing MODULE_LICENSE() in %s\n", modname);
|
2020-06-01 13:57:16 +08:00
|
|
|
while (license) {
|
modpost: change mod->gpl_compatible to bool type
Currently, mod->gpl_compatible is tristate; it is set to -1 by default,
then to 1 or 0 when MODULE_LICENSE() is found.
Maybe, -1 was chosen to represent the 'unknown' license, but it is not
useful.
The current code:
if (!mod->gpl_compatible)
check_for_gpl_usage(exp->export, basename, exp->name);
... only cares whether gpl_compatible is zero or not.
Change it to a bool type with the initial value 'true', which has no
functional change.
The default value should be 'true' instead of 'false'.
Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into
error"), unknown module license is an error.
The error message, "missing MODULE_LICENSE()" is enough to explain the
issue. It is not sensible to show another message, "GPL-incompatible
module ... uses GPL-only symbol".
Add comments to explain this.
While I was here, I renamed gpl_compatible to is_gpl_compatible for
clarification, and also slightly refactored the code.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2022-05-01 16:40:08 +08:00
|
|
|
if (!license_is_gpl_compatible(license)) {
|
|
|
|
mod->is_gpl_compatible = false;
|
2020-06-01 13:57:16 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
license = get_next_modinfo(&info, "license", license);
|
2006-06-10 03:53:55 +08:00
|
|
|
}
|
|
|
|
|
2020-06-01 13:57:16 +08:00
|
|
|
namespace = get_modinfo(&info, "import_ns");
|
|
|
|
while (namespace) {
|
|
|
|
add_namespace(&mod->imported_namespaces, namespace);
|
|
|
|
namespace = get_next_modinfo(&info, "import_ns",
|
|
|
|
namespace);
|
|
|
|
}
|
2019-09-06 18:32:28 +08:00
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
|
2014-02-08 16:01:12 +08:00
|
|
|
symname = remove_dot(info.strtab + sym->st_name);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2019-11-15 01:42:23 +08:00
|
|
|
handle_symbol(mod, &info, sym, symname);
|
2005-04-17 06:20:36 +08:00
|
|
|
handle_moddevtable(mod, &info, sym, symname);
|
|
|
|
}
|
2019-08-01 14:06:57 +08:00
|
|
|
|
2019-10-18 17:31:42 +08:00
|
|
|
for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
|
|
|
|
symname = remove_dot(info.strtab + sym->st_name);
|
|
|
|
|
2019-11-15 01:42:24 +08:00
|
|
|
/* Apply symbol namespaces from __kstrtabns_<symbol> entries. */
|
2019-10-18 17:31:42 +08:00
|
|
|
if (strstarts(symname, "__kstrtabns_"))
|
|
|
|
sym_update_namespace(symname + strlen("__kstrtabns_"),
|
2022-04-05 19:33:54 +08:00
|
|
|
sym_get_data(&info, sym));
|
2019-10-18 17:31:42 +08:00
|
|
|
}
|
|
|
|
|
2022-05-24 00:46:23 +08:00
|
|
|
check_sec_ref(modname, &info);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-06-01 13:57:26 +08:00
|
|
|
if (!mod->is_vmlinux) {
|
2020-06-01 13:57:16 +08:00
|
|
|
version = get_modinfo(&info, "version");
|
|
|
|
if (version || all_versions)
|
2021-08-28 17:50:59 +08:00
|
|
|
get_src_version(mod->name, mod->srcversion,
|
2020-06-01 13:57:16 +08:00
|
|
|
sizeof(mod->srcversion) - 1);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
parse_elf_finish(&info);
|
|
|
|
|
2022-05-13 19:39:21 +08:00
|
|
|
if (modversions) {
|
|
|
|
/*
|
|
|
|
* Our trick to get versioning for module struct etc. - it's
|
|
|
|
* never passed as an argument to an exported function, so
|
|
|
|
* the automatic versioning doesn't pick it up, but it's really
|
|
|
|
* important anyhow.
|
|
|
|
*/
|
2022-05-01 16:40:11 +08:00
|
|
|
sym_add_unresolved("module_layout", mod, false);
|
2022-05-13 19:39:21 +08:00
|
|
|
|
|
|
|
mod_set_crcs(mod);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2013-04-04 15:07:38 +08:00
|
|
|
static void read_symbols_from_files(const char *filename)
|
|
|
|
{
|
|
|
|
FILE *in = stdin;
|
|
|
|
char fname[PATH_MAX];
|
|
|
|
|
|
|
|
if (strcmp(filename, "-") != 0) {
|
|
|
|
in = fopen(filename, "r");
|
|
|
|
if (!in)
|
|
|
|
fatal("Can't open filenames file %s: %m", filename);
|
|
|
|
}
|
|
|
|
|
|
|
|
while (fgets(fname, PATH_MAX, in) != NULL) {
|
|
|
|
if (strends(fname, "\n"))
|
|
|
|
fname[strlen(fname)-1] = '\0';
|
|
|
|
read_symbols(fname);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (in != stdin)
|
|
|
|
fclose(in);
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
#define SZ 500
|
|
|
|
|
|
|
|
/* We first write the generated file into memory using the
|
|
|
|
* following helper, then compare to the file on disk and
|
|
|
|
* only update the later if anything changed */
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
void __attribute__((format(printf, 2, 3))) buf_printf(struct buffer *buf,
|
|
|
|
const char *fmt, ...)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
char tmp[SZ];
|
|
|
|
int len;
|
|
|
|
va_list ap;
|
2006-03-03 23:46:04 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
va_start(ap, fmt);
|
|
|
|
len = vsnprintf(tmp, SZ, fmt, ap);
|
2006-03-17 15:04:08 +08:00
|
|
|
buf_write(buf, tmp, len);
|
2005-04-17 06:20:36 +08:00
|
|
|
va_end(ap);
|
|
|
|
}
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
void buf_write(struct buffer *buf, const char *s, int len)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
if (buf->size - buf->pos < len) {
|
2006-03-17 15:04:08 +08:00
|
|
|
buf->size += len + SZ;
|
2018-08-16 03:30:38 +08:00
|
|
|
buf->p = NOFAIL(realloc(buf->p, buf->size));
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
strncpy(buf->p + buf->pos, s, len);
|
|
|
|
buf->pos += len;
|
|
|
|
}
|
|
|
|
|
2020-12-01 18:34:15 +08:00
|
|
|
static void check_exports(struct module *mod)
|
2006-06-10 03:53:55 +08:00
|
|
|
{
|
|
|
|
struct symbol *s, *exp;
|
|
|
|
|
2022-05-01 16:40:12 +08:00
|
|
|
list_for_each_entry(s, &mod->unresolved_symbols, list) {
|
2006-06-10 11:45:06 +08:00
|
|
|
const char *basename;
|
2006-06-10 03:53:55 +08:00
|
|
|
exp = find_symbol(s->name);
|
2022-04-25 03:07:48 +08:00
|
|
|
if (!exp) {
|
kbuild: fix false-positive modpost warning when all symbols are trimmed
Nathan reports that the mips defconfig emits the following warning:
WARNING: modpost: Symbol info of vmlinux is missing. Unresolved symbol check will be entirely skipped.
This false-positive happens when CONFIG_TRIM_UNUSED_KSYMS is enabled,
but no CONFIG option is set to 'm'.
Commit a0590473c5e6 ("nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default")
turned the last 'm' into 'y' for the mips defconfig, and uncovered
this issue.
In this case, the module feature itself is enabled, but we have no
module to build. As a result, CONFIG_TRIM_UNUSED_KSYMS drops all the
instances of EXPORT_SYMBOL. Then, modpost wrongly assumes vmlinux is
missing because vmlinux.symvers is empty. (As another false-positive
case, you can create a module that does not use any symbol of vmlinux).
The current behavior is to entirely suppress the unresolved symbol
warnings when vmlinux is missing just because there are too many.
I found the origin of this code in the historical git tree. [1]
If this is a matter of noisiness, I think modpost can display the
first 10 warnings, and the number of suppressed warnings at the end.
You will get a bit noisier logs when you run 'make modules' without
vmlinux, but such warnings are better to show because you never know
the resulting modules are actually loadable or not.
This commit changes the following:
- If any of input *.symver files is missing, pass -w option to let
the module build keep going with warnings instead of errors.
- If there are too many (10+) unresolved symbol warnings, show only
the first 10, and also the number of suppressed warnings.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=1cc0e0529569bf6a94f6d49770aa6d4b599d2c46
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2021-03-26 02:54:11 +08:00
|
|
|
if (!s->weak && nr_unresolved++ < MAX_UNRESOLVED_REPORTS)
|
2020-03-07 00:02:05 +08:00
|
|
|
modpost_log(warn_unresolved ? LOG_WARN : LOG_ERROR,
|
|
|
|
"\"%s\" [%s.ko] undefined!\n",
|
|
|
|
s->name, mod->name);
|
2006-06-10 03:53:55 +08:00
|
|
|
continue;
|
2018-11-23 15:57:23 +08:00
|
|
|
}
|
2022-04-25 03:07:48 +08:00
|
|
|
if (exp->module == mod) {
|
|
|
|
error("\"%s\" [%s.ko] was exported without definition\n",
|
|
|
|
s->name, mod->name);
|
|
|
|
continue;
|
|
|
|
}
|
2022-04-25 03:07:49 +08:00
|
|
|
|
|
|
|
s->module = exp->module;
|
|
|
|
s->crc_valid = exp->crc_valid;
|
|
|
|
s->crc = exp->crc;
|
|
|
|
|
2006-06-10 11:45:06 +08:00
|
|
|
basename = strrchr(mod->name, '/');
|
2006-06-10 03:53:55 +08:00
|
|
|
if (basename)
|
|
|
|
basename++;
|
2006-07-01 17:44:23 +08:00
|
|
|
else
|
|
|
|
basename = mod->name;
|
2019-09-06 18:32:28 +08:00
|
|
|
|
2019-10-29 20:38:07 +08:00
|
|
|
if (exp->namespace &&
|
2022-05-01 16:40:14 +08:00
|
|
|
!contains_namespace(&mod->imported_namespaces, exp->namespace)) {
|
2020-03-07 00:02:06 +08:00
|
|
|
modpost_log(allow_missing_ns_imports ? LOG_WARN : LOG_ERROR,
|
|
|
|
"module %s uses symbol %s from namespace %s, but does not import it.\n",
|
|
|
|
basename, exp->name, exp->namespace);
|
2019-10-29 20:38:07 +08:00
|
|
|
add_namespace(&mod->missing_namespaces, exp->namespace);
|
2019-09-06 18:32:28 +08:00
|
|
|
}
|
|
|
|
|
2022-05-09 03:06:19 +08:00
|
|
|
if (!mod->is_gpl_compatible && exp->is_gpl_only)
|
|
|
|
error("GPL-incompatible module %s.ko uses GPL-only symbol '%s'\n",
|
|
|
|
basename, exp->name);
|
2008-01-12 02:17:15 +08:00
|
|
|
}
|
2006-06-10 03:53:55 +08:00
|
|
|
}
|
|
|
|
|
2020-12-01 18:34:15 +08:00
|
|
|
static void check_modname_len(struct module *mod)
|
2017-06-30 22:07:03 +08:00
|
|
|
{
|
|
|
|
const char *mod_name;
|
|
|
|
|
|
|
|
mod_name = strrchr(mod->name, '/');
|
|
|
|
if (mod_name == NULL)
|
|
|
|
mod_name = mod->name;
|
|
|
|
else
|
|
|
|
mod_name++;
|
2020-12-01 18:34:15 +08:00
|
|
|
if (strlen(mod_name) >= MODULE_NAME_LEN)
|
modpost: rename merror() to error()
The log function names, warn(), merror(), fatal() are inconsistent.
Commit 2a11665945d5 ("kbuild: distinguish between errors and warnings
in modpost") intentionally chose merror() to avoid the conflict with
the library function error(). See man page of error(3).
But, we are already causing the conflict with warn() because it is also
a library function. See man page of warn(3). err() would be a problem
for the same reason.
The common technique to work around name conflicts is to use macros.
For example:
/* in a header */
#define error(fmt, ...) __error(fmt, ##__VA_ARGS__)
#define warn(fmt, ...) __warn(fmt, ##__VA_ARGS__)
/* function definition */
void __error(const char *fmt, ...)
{
<our implementation>
}
void __warn(const char *fmt, ...)
{
<our implementation>
}
In this way, we can implement our own warn() and error(), still we can
include <error.h> and <err.h> with no problem.
And, commit 93c95e526a4e ("modpost: rework and consolidate logging
interface") already did that.
Since the log functions are all macros, we can use error() without
causing "conflicting types" errors.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-12-01 18:34:14 +08:00
|
|
|
error("module name is too long [%s.ko]\n", mod->name);
|
2017-06-30 22:07:03 +08:00
|
|
|
}
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
/**
|
|
|
|
* Header for the generated file
|
|
|
|
**/
|
|
|
|
static void add_header(struct buffer *b, struct module *mod)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
buf_printf(b, "#include <linux/module.h>\n");
|
2020-03-20 22:53:41 +08:00
|
|
|
/*
|
|
|
|
* Include build-salt.h after module.h in order to
|
|
|
|
* inherit the definitions.
|
|
|
|
*/
|
2020-04-19 23:55:06 +08:00
|
|
|
buf_printf(b, "#define INCLUDE_VERMAGIC\n");
|
2020-03-20 22:53:41 +08:00
|
|
|
buf_printf(b, "#include <linux/build-salt.h>\n");
|
2021-04-02 07:27:23 +08:00
|
|
|
buf_printf(b, "#include <linux/elfnote-lto.h>\n");
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 19:39:22 +08:00
|
|
|
buf_printf(b, "#include <linux/export-internal.h>\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
buf_printf(b, "#include <linux/vermagic.h>\n");
|
|
|
|
buf_printf(b, "#include <linux/compiler.h>\n");
|
|
|
|
buf_printf(b, "\n");
|
2018-07-06 08:49:37 +08:00
|
|
|
buf_printf(b, "BUILD_SALT;\n");
|
2021-04-02 07:27:23 +08:00
|
|
|
buf_printf(b, "BUILD_LTO_INFO;\n");
|
2018-07-06 08:49:37 +08:00
|
|
|
buf_printf(b, "\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
buf_printf(b, "MODULE_INFO(vermagic, VERMAGIC_STRING);\n");
|
2017-04-22 06:35:27 +08:00
|
|
|
buf_printf(b, "MODULE_INFO(name, KBUILD_MODNAME);\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
buf_printf(b, "\n");
|
2013-10-23 08:27:58 +08:00
|
|
|
buf_printf(b, "__visible struct module __this_module\n");
|
2020-10-22 10:36:07 +08:00
|
|
|
buf_printf(b, "__section(\".gnu.linkonce.this_module\") = {\n");
|
2012-04-26 02:10:15 +08:00
|
|
|
buf_printf(b, "\t.name = KBUILD_MODNAME,\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
if (mod->has_init)
|
2012-04-26 02:10:15 +08:00
|
|
|
buf_printf(b, "\t.init = init_module,\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
if (mod->has_cleanup)
|
|
|
|
buf_printf(b, "#ifdef CONFIG_MODULE_UNLOAD\n"
|
2012-04-26 02:10:15 +08:00
|
|
|
"\t.exit = cleanup_module,\n"
|
2005-04-17 06:20:36 +08:00
|
|
|
"#endif\n");
|
2012-04-26 02:10:15 +08:00
|
|
|
buf_printf(b, "\t.arch = MODULE_ARCH_INIT,\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
buf_printf(b, "};\n");
|
|
|
|
|
2022-05-05 15:22:32 +08:00
|
|
|
if (!external_module)
|
2011-10-24 21:12:28 +08:00
|
|
|
buf_printf(b, "\nMODULE_INFO(intree, \"Y\");\n");
|
|
|
|
|
2022-05-05 15:22:32 +08:00
|
|
|
buf_printf(b,
|
|
|
|
"\n"
|
|
|
|
"#ifdef CONFIG_RETPOLINE\n"
|
|
|
|
"MODULE_INFO(retpoline, \"Y\");\n"
|
|
|
|
"#endif\n");
|
2018-01-26 07:50:28 +08:00
|
|
|
|
2022-05-05 15:22:32 +08:00
|
|
|
if (strstarts(mod->name, "drivers/staging"))
|
2008-09-25 05:46:44 +08:00
|
|
|
buf_printf(b, "\nMODULE_INFO(staging, \"Y\");\n");
|
2022-07-08 12:48:45 +08:00
|
|
|
|
|
|
|
if (strstarts(mod->name, "tools/testing"))
|
|
|
|
buf_printf(b, "\nMODULE_INFO(test, \"Y\");\n");
|
2008-09-25 05:46:44 +08:00
|
|
|
}
|
|
|
|
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 19:39:22 +08:00
|
|
|
static void add_exported_symbols(struct buffer *buf, struct module *mod)
|
2022-05-13 19:39:21 +08:00
|
|
|
{
|
|
|
|
struct symbol *sym;
|
|
|
|
|
|
|
|
if (!modversions)
|
|
|
|
return;
|
|
|
|
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 19:39:22 +08:00
|
|
|
/* record CRCs for exported symbols */
|
|
|
|
buf_printf(buf, "\n");
|
2022-05-13 19:39:21 +08:00
|
|
|
list_for_each_entry(sym, &mod->exported_symbols, list) {
|
|
|
|
if (!sym->crc_valid) {
|
|
|
|
warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n"
|
|
|
|
"Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n",
|
|
|
|
sym->name, mod->name, mod->is_vmlinux ? "" : ".ko",
|
|
|
|
sym->name);
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 19:39:22 +08:00
|
|
|
continue;
|
2022-05-13 19:39:21 +08:00
|
|
|
}
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 19:39:22 +08:00
|
|
|
|
|
|
|
buf_printf(buf, "SYMBOL_CRC(%s, 0x%08x, \"%s\");\n",
|
|
|
|
sym->name, sym->crc, sym->is_gpl_only ? "_gpl" : "");
|
2022-05-13 19:39:21 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
/**
|
|
|
|
* Record CRCs for unresolved symbols
|
|
|
|
**/
|
2020-12-01 18:34:15 +08:00
|
|
|
static void add_versions(struct buffer *b, struct module *mod)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2022-04-25 03:07:49 +08:00
|
|
|
struct symbol *s;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (!modversions)
|
2020-12-01 18:34:15 +08:00
|
|
|
return;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
buf_printf(b, "\n");
|
|
|
|
buf_printf(b, "static const struct modversion_info ____versions[]\n");
|
2020-10-22 10:36:07 +08:00
|
|
|
buf_printf(b, "__used __section(\"__versions\") = {\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2022-05-01 16:40:12 +08:00
|
|
|
list_for_each_entry(s, &mod->unresolved_symbols, list) {
|
2008-01-12 02:17:15 +08:00
|
|
|
if (!s->module)
|
2005-04-17 06:20:36 +08:00
|
|
|
continue;
|
|
|
|
if (!s->crc_valid) {
|
2006-01-28 23:57:26 +08:00
|
|
|
warn("\"%s\" [%s.ko] has no CRC!\n",
|
2005-04-17 06:20:36 +08:00
|
|
|
s->name, mod->name);
|
|
|
|
continue;
|
|
|
|
}
|
2015-08-08 13:46:20 +08:00
|
|
|
if (strlen(s->name) >= MODULE_NAME_LEN) {
|
modpost: rename merror() to error()
The log function names, warn(), merror(), fatal() are inconsistent.
Commit 2a11665945d5 ("kbuild: distinguish between errors and warnings
in modpost") intentionally chose merror() to avoid the conflict with
the library function error(). See man page of error(3).
But, we are already causing the conflict with warn() because it is also
a library function. See man page of warn(3). err() would be a problem
for the same reason.
The common technique to work around name conflicts is to use macros.
For example:
/* in a header */
#define error(fmt, ...) __error(fmt, ##__VA_ARGS__)
#define warn(fmt, ...) __warn(fmt, ##__VA_ARGS__)
/* function definition */
void __error(const char *fmt, ...)
{
<our implementation>
}
void __warn(const char *fmt, ...)
{
<our implementation>
}
In this way, we can implement our own warn() and error(), still we can
include <error.h> and <err.h> with no problem.
And, commit 93c95e526a4e ("modpost: rework and consolidate logging
interface") already did that.
Since the log functions are all macros, we can use error() without
causing "conflicting types" errors.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2020-12-01 18:34:14 +08:00
|
|
|
error("too long symbol \"%s\" [%s.ko]\n",
|
|
|
|
s->name, mod->name);
|
2015-08-08 13:46:20 +08:00
|
|
|
break;
|
|
|
|
}
|
2018-05-09 15:23:45 +08:00
|
|
|
buf_printf(b, "\t{ %#8x, \"%s\" },\n",
|
2013-03-18 17:08:56 +08:00
|
|
|
s->crc, s->name);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
buf_printf(b, "};\n");
|
|
|
|
}
|
|
|
|
|
2018-11-23 15:57:21 +08:00
|
|
|
static void add_depends(struct buffer *b, struct module *mod)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct symbol *s;
|
|
|
|
int first = 1;
|
|
|
|
|
2018-11-23 15:57:21 +08:00
|
|
|
/* Clear ->seen flag of modules that own symbols needed by this. */
|
2022-05-01 16:40:12 +08:00
|
|
|
list_for_each_entry(s, &mod->unresolved_symbols, list) {
|
2018-11-23 15:57:21 +08:00
|
|
|
if (s->module)
|
2020-06-01 13:57:26 +08:00
|
|
|
s->module->seen = s->module->is_vmlinux;
|
2022-05-01 16:40:12 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
buf_printf(b, "\n");
|
2019-09-09 19:34:22 +08:00
|
|
|
buf_printf(b, "MODULE_INFO(depends, \"");
|
2022-05-01 16:40:12 +08:00
|
|
|
list_for_each_entry(s, &mod->unresolved_symbols, list) {
|
2007-02-27 02:46:52 +08:00
|
|
|
const char *p;
|
2005-04-17 06:20:36 +08:00
|
|
|
if (!s->module)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (s->module->seen)
|
|
|
|
continue;
|
|
|
|
|
2022-05-01 16:40:07 +08:00
|
|
|
s->module->seen = true;
|
2008-01-12 02:17:15 +08:00
|
|
|
p = strrchr(s->module->name, '/');
|
|
|
|
if (p)
|
2007-02-27 02:46:52 +08:00
|
|
|
p++;
|
|
|
|
else
|
|
|
|
p = s->module->name;
|
|
|
|
buf_printf(b, "%s%s", first ? "" : ",", p);
|
2005-04-17 06:20:36 +08:00
|
|
|
first = 0;
|
|
|
|
}
|
2019-09-09 19:34:22 +08:00
|
|
|
buf_printf(b, "\");\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
static void add_srcversion(struct buffer *b, struct module *mod)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
if (mod->srcversion[0]) {
|
|
|
|
buf_printf(b, "\n");
|
|
|
|
buf_printf(b, "MODULE_INFO(srcversion, \"%s\");\n",
|
|
|
|
mod->srcversion);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-06-01 13:57:12 +08:00
|
|
|
static void write_buf(struct buffer *b, const char *fname)
|
|
|
|
{
|
|
|
|
FILE *file;
|
|
|
|
|
2022-04-25 03:07:46 +08:00
|
|
|
if (error_occurred)
|
|
|
|
return;
|
|
|
|
|
2020-06-01 13:57:12 +08:00
|
|
|
file = fopen(fname, "w");
|
|
|
|
if (!file) {
|
|
|
|
perror(fname);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
if (fwrite(b->p, 1, b->pos, file) != b->pos) {
|
|
|
|
perror(fname);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
if (fclose(file) != 0) {
|
|
|
|
perror(fname);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
static void write_if_changed(struct buffer *b, const char *fname)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
char *tmp;
|
|
|
|
FILE *file;
|
|
|
|
struct stat st;
|
|
|
|
|
|
|
|
file = fopen(fname, "r");
|
|
|
|
if (!file)
|
|
|
|
goto write;
|
|
|
|
|
|
|
|
if (fstat(fileno(file), &st) < 0)
|
|
|
|
goto close_write;
|
|
|
|
|
|
|
|
if (st.st_size != b->pos)
|
|
|
|
goto close_write;
|
|
|
|
|
|
|
|
tmp = NOFAIL(malloc(b->pos));
|
|
|
|
if (fread(tmp, 1, b->pos, file) != b->pos)
|
|
|
|
goto free_write;
|
|
|
|
|
|
|
|
if (memcmp(tmp, b->p, b->pos) != 0)
|
|
|
|
goto free_write;
|
|
|
|
|
|
|
|
free(tmp);
|
|
|
|
fclose(file);
|
|
|
|
return;
|
|
|
|
|
|
|
|
free_write:
|
|
|
|
free(tmp);
|
|
|
|
close_write:
|
|
|
|
fclose(file);
|
|
|
|
write:
|
2020-06-01 13:57:12 +08:00
|
|
|
write_buf(b, fname);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 19:39:22 +08:00
|
|
|
static void write_vmlinux_export_c_file(struct module *mod)
|
|
|
|
{
|
|
|
|
struct buffer buf = { };
|
|
|
|
|
|
|
|
buf_printf(&buf,
|
|
|
|
"#include <linux/export-internal.h>\n");
|
|
|
|
|
|
|
|
add_exported_symbols(&buf, mod);
|
|
|
|
write_if_changed(&buf, ".vmlinux.export.c");
|
|
|
|
free(buf.p);
|
|
|
|
}
|
|
|
|
|
2022-05-05 15:22:33 +08:00
|
|
|
/* do sanity checks, and generate *.mod.c file */
|
|
|
|
static void write_mod_c_file(struct module *mod)
|
|
|
|
{
|
|
|
|
struct buffer buf = { };
|
|
|
|
char fname[PATH_MAX];
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
check_modname_len(mod);
|
|
|
|
check_exports(mod);
|
|
|
|
|
|
|
|
add_header(&buf, mod);
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 19:39:22 +08:00
|
|
|
add_exported_symbols(&buf, mod);
|
2022-05-05 15:22:33 +08:00
|
|
|
add_versions(&buf, mod);
|
|
|
|
add_depends(&buf, mod);
|
|
|
|
add_moddevtable(&buf, mod);
|
|
|
|
add_srcversion(&buf, mod);
|
|
|
|
|
|
|
|
ret = snprintf(fname, sizeof(fname), "%s.mod.c", mod->name);
|
|
|
|
if (ret >= sizeof(fname)) {
|
|
|
|
error("%s: too long path was truncated\n", fname);
|
|
|
|
goto free;
|
|
|
|
}
|
|
|
|
|
|
|
|
write_if_changed(&buf, fname);
|
|
|
|
|
|
|
|
free:
|
|
|
|
free(buf.p);
|
|
|
|
}
|
|
|
|
|
2006-06-09 13:12:53 +08:00
|
|
|
/* parse Module.symvers file. line format:
|
2020-03-12 01:01:20 +08:00
|
|
|
* 0x12345678<tab>symbol<tab>module<tab>export<tab>namespace
|
2006-06-09 13:12:53 +08:00
|
|
|
**/
|
2020-06-01 13:57:05 +08:00
|
|
|
static void read_dump(const char *fname)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2020-06-01 13:57:20 +08:00
|
|
|
char *buf, *pos, *line;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-06-01 13:57:20 +08:00
|
|
|
buf = read_text_file(fname);
|
|
|
|
if (!buf)
|
2005-04-17 06:20:36 +08:00
|
|
|
/* No symbol versions, silently ignore */
|
|
|
|
return;
|
|
|
|
|
2020-06-01 13:57:20 +08:00
|
|
|
pos = buf;
|
|
|
|
|
|
|
|
while ((line = get_line(&pos))) {
|
2020-03-12 01:01:20 +08:00
|
|
|
char *symname, *namespace, *modname, *d, *export;
|
2005-04-17 06:20:36 +08:00
|
|
|
unsigned int crc;
|
|
|
|
struct module *mod;
|
2006-01-29 05:15:55 +08:00
|
|
|
struct symbol *s;
|
2022-05-09 03:06:19 +08:00
|
|
|
bool gpl_only;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (!(symname = strchr(line, '\t')))
|
|
|
|
goto fail;
|
|
|
|
*symname++ = '\0';
|
2020-03-12 01:01:20 +08:00
|
|
|
if (!(modname = strchr(symname, '\t')))
|
2005-04-17 06:20:36 +08:00
|
|
|
goto fail;
|
|
|
|
*modname++ = '\0';
|
2020-03-12 01:01:20 +08:00
|
|
|
if (!(export = strchr(modname, '\t')))
|
|
|
|
goto fail;
|
|
|
|
*export++ = '\0';
|
|
|
|
if (!(namespace = strchr(export, '\t')))
|
|
|
|
goto fail;
|
|
|
|
*namespace++ = '\0';
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
crc = strtoul(line, &d, 16);
|
|
|
|
if (*symname == '\0' || *modname == '\0' || *d != '\0')
|
|
|
|
goto fail;
|
2022-05-09 03:06:19 +08:00
|
|
|
|
|
|
|
if (!strcmp(export, "EXPORT_SYMBOL_GPL")) {
|
|
|
|
gpl_only = true;
|
|
|
|
} else if (!strcmp(export, "EXPORT_SYMBOL")) {
|
|
|
|
gpl_only = false;
|
|
|
|
} else {
|
|
|
|
error("%s: unknown license %s. skip", symname, export);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2008-01-12 02:17:15 +08:00
|
|
|
mod = find_module(modname);
|
|
|
|
if (!mod) {
|
2022-05-30 17:01:38 +08:00
|
|
|
mod = new_module(modname, strlen(modname));
|
2022-05-01 16:40:07 +08:00
|
|
|
mod->from_dump = true;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2022-05-09 03:06:19 +08:00
|
|
|
s = sym_add_exported(symname, mod, gpl_only);
|
2022-05-13 19:39:21 +08:00
|
|
|
sym_set_crc(s, crc);
|
2019-10-18 17:31:41 +08:00
|
|
|
sym_update_namespace(symname, namespace);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2020-06-01 13:57:20 +08:00
|
|
|
free(buf);
|
2005-04-17 06:20:36 +08:00
|
|
|
return;
|
|
|
|
fail:
|
2020-06-01 13:57:20 +08:00
|
|
|
free(buf);
|
2005-04-17 06:20:36 +08:00
|
|
|
fatal("parse error in symbol dump file\n");
|
|
|
|
}
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
static void write_dump(const char *fname)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct buffer buf = { };
|
2022-05-01 16:40:15 +08:00
|
|
|
struct module *mod;
|
|
|
|
struct symbol *sym;
|
|
|
|
|
|
|
|
list_for_each_entry(mod, &modules, list) {
|
|
|
|
if (mod->from_dump)
|
|
|
|
continue;
|
|
|
|
list_for_each_entry(sym, &mod->exported_symbols, list) {
|
2022-05-09 03:06:19 +08:00
|
|
|
buf_printf(&buf, "0x%08x\t%s\t%s\tEXPORT_SYMBOL%s\t%s\n",
|
2022-05-01 16:40:15 +08:00
|
|
|
sym->crc, sym->name, mod->name,
|
2022-05-09 03:06:19 +08:00
|
|
|
sym->is_gpl_only ? "_GPL" : "",
|
2022-05-01 16:40:15 +08:00
|
|
|
sym->namespace ?: "");
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
}
|
2020-06-01 13:57:12 +08:00
|
|
|
write_buf(&buf, fname);
|
2016-08-03 03:43:01 +08:00
|
|
|
free(buf.p);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2019-10-29 20:38:07 +08:00
|
|
|
static void write_namespace_deps_files(const char *fname)
|
2019-09-06 18:32:31 +08:00
|
|
|
{
|
|
|
|
struct module *mod;
|
|
|
|
struct namespace_list *ns;
|
|
|
|
struct buffer ns_deps_buf = {};
|
|
|
|
|
2022-05-01 16:40:10 +08:00
|
|
|
list_for_each_entry(mod, &modules, list) {
|
2019-09-06 18:32:31 +08:00
|
|
|
|
2022-05-01 16:40:14 +08:00
|
|
|
if (mod->from_dump || list_empty(&mod->missing_namespaces))
|
2019-09-06 18:32:31 +08:00
|
|
|
continue;
|
|
|
|
|
2019-10-29 20:38:07 +08:00
|
|
|
buf_printf(&ns_deps_buf, "%s.ko:", mod->name);
|
2019-09-06 18:32:31 +08:00
|
|
|
|
2022-05-01 16:40:14 +08:00
|
|
|
list_for_each_entry(ns, &mod->missing_namespaces, list)
|
2019-10-29 20:38:07 +08:00
|
|
|
buf_printf(&ns_deps_buf, " %s", ns->namespace);
|
2019-09-06 18:32:31 +08:00
|
|
|
|
2019-10-29 20:38:07 +08:00
|
|
|
buf_printf(&ns_deps_buf, "\n");
|
2019-09-06 18:32:31 +08:00
|
|
|
}
|
2019-11-06 23:19:59 +08:00
|
|
|
|
2019-10-29 20:38:07 +08:00
|
|
|
write_if_changed(&ns_deps_buf, fname);
|
2019-11-06 23:19:59 +08:00
|
|
|
free(ns_deps_buf.p);
|
2019-09-06 18:32:31 +08:00
|
|
|
}
|
|
|
|
|
2020-06-01 13:57:07 +08:00
|
|
|
struct dump_list {
|
2022-05-01 16:40:13 +08:00
|
|
|
struct list_head list;
|
2008-02-28 16:40:52 +08:00
|
|
|
const char *file;
|
|
|
|
};
|
|
|
|
|
2006-01-29 00:19:35 +08:00
|
|
|
int main(int argc, char **argv)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct module *mod;
|
2019-10-29 20:38:07 +08:00
|
|
|
char *missing_namespace_deps = NULL;
|
2013-04-04 15:07:38 +08:00
|
|
|
char *dump_write = NULL, *files_source = NULL;
|
2005-04-17 06:20:36 +08:00
|
|
|
int opt;
|
2022-05-01 16:40:13 +08:00
|
|
|
LIST_HEAD(dump_lists);
|
|
|
|
struct dump_list *dl, *dl2;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-06-01 13:57:22 +08:00
|
|
|
while ((opt = getopt(argc, argv, "ei:mnT:o:awENd:")) != -1) {
|
2008-01-12 02:17:15 +08:00
|
|
|
switch (opt) {
|
2008-02-28 16:40:52 +08:00
|
|
|
case 'e':
|
2022-05-01 16:40:07 +08:00
|
|
|
external_module = true;
|
2020-06-01 13:57:08 +08:00
|
|
|
break;
|
|
|
|
case 'i':
|
2022-05-01 16:40:13 +08:00
|
|
|
dl = NOFAIL(malloc(sizeof(*dl)));
|
|
|
|
dl->file = optarg;
|
|
|
|
list_add_tail(&dl->list, &dump_lists);
|
2008-02-28 16:40:52 +08:00
|
|
|
break;
|
2008-01-12 02:17:15 +08:00
|
|
|
case 'm':
|
2022-05-01 16:40:07 +08:00
|
|
|
modversions = true;
|
2008-01-12 02:17:15 +08:00
|
|
|
break;
|
2013-09-23 13:53:54 +08:00
|
|
|
case 'n':
|
2022-05-01 16:40:07 +08:00
|
|
|
ignore_missing_files = true;
|
2013-09-23 13:53:54 +08:00
|
|
|
break;
|
2008-01-12 02:17:15 +08:00
|
|
|
case 'o':
|
|
|
|
dump_write = optarg;
|
|
|
|
break;
|
|
|
|
case 'a':
|
2022-05-01 16:40:07 +08:00
|
|
|
all_versions = true;
|
2008-01-12 02:17:15 +08:00
|
|
|
break;
|
2013-04-04 15:07:38 +08:00
|
|
|
case 'T':
|
|
|
|
files_source = optarg;
|
|
|
|
break;
|
2008-01-12 02:17:15 +08:00
|
|
|
case 'w':
|
2022-05-01 16:40:07 +08:00
|
|
|
warn_unresolved = true;
|
2008-01-12 02:17:15 +08:00
|
|
|
break;
|
2015-10-06 07:14:42 +08:00
|
|
|
case 'E':
|
2020-12-01 18:34:18 +08:00
|
|
|
sec_mismatch_warn_only = false;
|
2015-10-06 07:14:42 +08:00
|
|
|
break;
|
2020-03-07 00:02:06 +08:00
|
|
|
case 'N':
|
2022-05-01 16:40:07 +08:00
|
|
|
allow_missing_ns_imports = true;
|
2020-03-07 00:02:06 +08:00
|
|
|
break;
|
2019-09-06 18:32:31 +08:00
|
|
|
case 'd':
|
2019-10-29 20:38:07 +08:00
|
|
|
missing_namespace_deps = optarg;
|
2019-09-06 18:32:31 +08:00
|
|
|
break;
|
2008-01-12 02:17:15 +08:00
|
|
|
default:
|
|
|
|
exit(1);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-05-01 16:40:13 +08:00
|
|
|
list_for_each_entry_safe(dl, dl2, &dump_lists, list) {
|
|
|
|
read_dump(dl->file);
|
|
|
|
list_del(&dl->list);
|
|
|
|
free(dl);
|
2008-02-28 16:40:52 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-01-12 02:17:15 +08:00
|
|
|
while (optind < argc)
|
2005-04-17 06:20:36 +08:00
|
|
|
read_symbols(argv[optind++]);
|
|
|
|
|
2013-04-04 15:07:38 +08:00
|
|
|
if (files_source)
|
|
|
|
read_symbols_from_files(files_source);
|
|
|
|
|
2022-05-01 16:40:10 +08:00
|
|
|
list_for_each_entry(mod, &modules, list) {
|
2022-05-05 15:22:33 +08:00
|
|
|
if (mod->from_dump)
|
2022-04-25 03:07:45 +08:00
|
|
|
continue;
|
|
|
|
|
kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
include/{linux,asm-generic}/export.h defines a weak symbol, __crc_*
as a placeholder.
Genksyms writes the version CRCs into the linker script, which will be
used for filling the __crc_* symbols. The linker script format depends
on CONFIG_MODULE_REL_CRCS. If it is enabled, __crc_* holds the offset
to the reference of CRC.
It is time to get rid of this complexity.
Now that modpost parses text files (.*.cmd) to collect all the CRCs,
it can generate C code that will be linked to the vmlinux or modules.
Generate a new C file, .vmlinux.export.c, which contains the CRCs of
symbols exported by vmlinux. It is compiled and linked to vmlinux in
scripts/link-vmlinux.sh.
Put the CRCs of symbols exported by modules into the existing *.mod.c
files. No additional build step is needed for modules. As before,
*.mod.c are compiled and linked to *.ko in scripts/Makefile.modfinal.
No linker magic is used here. The new C implementation works in the
same way, whether CONFIG_RELOCATABLE is enabled or not.
CONFIG_MODULE_REL_CRCS is no longer needed.
Previously, Kbuild invoked additional $(LD) to update the CRCs in
objects, but this step is unneeded too.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
2022-05-13 19:39:22 +08:00
|
|
|
if (mod->is_vmlinux)
|
|
|
|
write_vmlinux_export_c_file(mod);
|
|
|
|
else
|
2022-05-05 15:22:33 +08:00
|
|
|
write_mod_c_file(mod);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2019-09-06 18:32:31 +08:00
|
|
|
|
2019-10-29 20:38:07 +08:00
|
|
|
if (missing_namespace_deps)
|
|
|
|
write_namespace_deps_files(missing_namespace_deps);
|
2019-09-06 18:32:31 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
if (dump_write)
|
|
|
|
write_dump(dump_write);
|
2020-12-01 18:34:18 +08:00
|
|
|
if (sec_mismatch_count && !sec_mismatch_warn_only)
|
|
|
|
error("Section mismatches detected.\n"
|
2019-02-01 12:50:45 +08:00
|
|
|
"Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.\n");
|
2019-08-01 14:06:57 +08:00
|
|
|
|
kbuild: fix false-positive modpost warning when all symbols are trimmed
Nathan reports that the mips defconfig emits the following warning:
WARNING: modpost: Symbol info of vmlinux is missing. Unresolved symbol check will be entirely skipped.
This false-positive happens when CONFIG_TRIM_UNUSED_KSYMS is enabled,
but no CONFIG option is set to 'm'.
Commit a0590473c5e6 ("nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default")
turned the last 'm' into 'y' for the mips defconfig, and uncovered
this issue.
In this case, the module feature itself is enabled, but we have no
module to build. As a result, CONFIG_TRIM_UNUSED_KSYMS drops all the
instances of EXPORT_SYMBOL. Then, modpost wrongly assumes vmlinux is
missing because vmlinux.symvers is empty. (As another false-positive
case, you can create a module that does not use any symbol of vmlinux).
The current behavior is to entirely suppress the unresolved symbol
warnings when vmlinux is missing just because there are too many.
I found the origin of this code in the historical git tree. [1]
If this is a matter of noisiness, I think modpost can display the
first 10 warnings, and the number of suppressed warnings at the end.
You will get a bit noisier logs when you run 'make modules' without
vmlinux, but such warnings are better to show because you never know
the resulting modules are actually loadable or not.
This commit changes the following:
- If any of input *.symver files is missing, pass -w option to let
the module build keep going with warnings instead of errors.
- If there are too many (10+) unresolved symbol warnings, show only
the first 10, and also the number of suppressed warnings.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=1cc0e0529569bf6a94f6d49770aa6d4b599d2c46
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
2021-03-26 02:54:11 +08:00
|
|
|
if (nr_unresolved > MAX_UNRESOLVED_REPORTS)
|
|
|
|
warn("suppressed %u unresolved symbol warnings because there were too many)\n",
|
|
|
|
nr_unresolved - MAX_UNRESOLVED_REPORTS);
|
|
|
|
|
2020-12-01 18:34:15 +08:00
|
|
|
return error_occurred ? 1 : 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|