i3c: Add core I3C infrastructure
Add core infrastructure to support I3C in Linux and document it.
This infrastructure adds basic I3C support. Advanced features will be
added afterwards.
There are a few design choices that are worth mentioning because they
impact the way I3C device drivers can interact with their devices:
- all functions used to send I3C/I2C frames must be called in
non-atomic context. Mainly done this way to ease implementation, but
this is not set in stone, and if anyone needs async support, new
functions can be added later on.
- the bus element is a separate object, but it's tightly coupled with
the master object. We thus have a 1:1 relationship between i3c_bus
and i3c_master_controller objects, and if 2 master controllers are
connected to the same bus and both exposed to the same Linux instance
they will appear as two distinct busses, and devices on this bus will
be exposed twice.
- I2C backward compatibility has been designed to be transparent to I2C
drivers and the I2C subsystem. The I3C master just registers an I2C
adapter which creates a new I2C bus. I'd say that, from a
representation PoV it's not ideal because what should appear as a
single I3C bus exposing I3C and I2C devices here appears as 2
different buses connected to each other through the parenting (the
I3C master is the parent of the I2C and I3C busses).
On the other hand, I don't see a better solution if we want something
that is not invasive.
Missing features:
- I3C HDR modes are not supported
- no support for multi-master and the associated concepts (mastership
handover, support for secondary masters, ...)
- I2C devices can only be described using DT because this is the only
use case I have. However, the framework can easily be extended with
ACPI and board info support
- I3C slave framework. This has been completely omitted, but shouldn't
have a huge impact on the I3C framework because I3C slaves don't see
the whole bus, it's only about handling master requests and generating
IBIs. Some of the struct, constant and enum definitions could be
shared, but most of the I3C slave framework logic will be different
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-19 17:52:29 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
/*
|
|
|
|
* Copyright (C) 2018 Cadence Design Systems Inc.
|
|
|
|
*
|
|
|
|
* Author: Boris Brezillon <boris.brezillon@bootlin.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/atomic.h>
|
|
|
|
#include <linux/bug.h>
|
|
|
|
#include <linux/completion.h>
|
|
|
|
#include <linux/device.h>
|
|
|
|
#include <linux/mutex.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
|
|
|
|
#include "internals.h"
|
|
|
|
|
|
|
|
/**
|
|
|
|
* i3c_device_do_priv_xfers() - do I3C SDR private transfers directed to a
|
|
|
|
* specific device
|
|
|
|
*
|
|
|
|
* @dev: device with which the transfers should be done
|
|
|
|
* @xfers: array of transfers
|
|
|
|
* @nxfers: number of transfers
|
|
|
|
*
|
|
|
|
* Initiate one or several private SDR transfers with @dev.
|
|
|
|
*
|
|
|
|
* This function can sleep and thus cannot be called in atomic context.
|
|
|
|
*
|
|
|
|
* Return: 0 in case of success, a negative error core otherwise.
|
2024-05-07 00:40:07 +08:00
|
|
|
* -EAGAIN: controller lost address arbitration. Target
|
|
|
|
* (IBI, HJ or controller role request) win the bus. Client
|
|
|
|
* driver needs to resend the 'xfers' some time later.
|
|
|
|
* See I3C spec ver 1.1.1 09-Jun-2021. Section: 5.1.2.2.3.
|
i3c: Add core I3C infrastructure
Add core infrastructure to support I3C in Linux and document it.
This infrastructure adds basic I3C support. Advanced features will be
added afterwards.
There are a few design choices that are worth mentioning because they
impact the way I3C device drivers can interact with their devices:
- all functions used to send I3C/I2C frames must be called in
non-atomic context. Mainly done this way to ease implementation, but
this is not set in stone, and if anyone needs async support, new
functions can be added later on.
- the bus element is a separate object, but it's tightly coupled with
the master object. We thus have a 1:1 relationship between i3c_bus
and i3c_master_controller objects, and if 2 master controllers are
connected to the same bus and both exposed to the same Linux instance
they will appear as two distinct busses, and devices on this bus will
be exposed twice.
- I2C backward compatibility has been designed to be transparent to I2C
drivers and the I2C subsystem. The I3C master just registers an I2C
adapter which creates a new I2C bus. I'd say that, from a
representation PoV it's not ideal because what should appear as a
single I3C bus exposing I3C and I2C devices here appears as 2
different buses connected to each other through the parenting (the
I3C master is the parent of the I2C and I3C busses).
On the other hand, I don't see a better solution if we want something
that is not invasive.
Missing features:
- I3C HDR modes are not supported
- no support for multi-master and the associated concepts (mastership
handover, support for secondary masters, ...)
- I2C devices can only be described using DT because this is the only
use case I have. However, the framework can easily be extended with
ACPI and board info support
- I3C slave framework. This has been completely omitted, but shouldn't
have a huge impact on the I3C framework because I3C slaves don't see
the whole bus, it's only about handling master requests and generating
IBIs. Some of the struct, constant and enum definitions could be
shared, but most of the I3C slave framework logic will be different
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-19 17:52:29 +08:00
|
|
|
*/
|
|
|
|
int i3c_device_do_priv_xfers(struct i3c_device *dev,
|
|
|
|
struct i3c_priv_xfer *xfers,
|
|
|
|
int nxfers)
|
|
|
|
{
|
|
|
|
int ret, i;
|
|
|
|
|
|
|
|
if (nxfers < 1)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
for (i = 0; i < nxfers; i++) {
|
|
|
|
if (!xfers[i].len || !xfers[i].data.in)
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
i3c_bus_normaluse_lock(dev->bus);
|
|
|
|
ret = i3c_dev_do_priv_xfers_locked(dev->desc, xfers, nxfers);
|
|
|
|
i3c_bus_normaluse_unlock(dev->bus);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_device_do_priv_xfers);
|
|
|
|
|
2022-12-08 04:50:59 +08:00
|
|
|
/**
|
|
|
|
* i3c_device_do_setdasa() - do I3C dynamic address assignement with
|
|
|
|
* static address
|
|
|
|
*
|
|
|
|
* @dev: device with which the DAA should be done
|
|
|
|
*
|
|
|
|
* Return: 0 in case of success, a negative error core otherwise.
|
|
|
|
*/
|
|
|
|
int i3c_device_do_setdasa(struct i3c_device *dev)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
i3c_bus_normaluse_lock(dev->bus);
|
|
|
|
ret = i3c_dev_setdasa_locked(dev->desc);
|
|
|
|
i3c_bus_normaluse_unlock(dev->bus);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_device_do_setdasa);
|
|
|
|
|
i3c: Add core I3C infrastructure
Add core infrastructure to support I3C in Linux and document it.
This infrastructure adds basic I3C support. Advanced features will be
added afterwards.
There are a few design choices that are worth mentioning because they
impact the way I3C device drivers can interact with their devices:
- all functions used to send I3C/I2C frames must be called in
non-atomic context. Mainly done this way to ease implementation, but
this is not set in stone, and if anyone needs async support, new
functions can be added later on.
- the bus element is a separate object, but it's tightly coupled with
the master object. We thus have a 1:1 relationship between i3c_bus
and i3c_master_controller objects, and if 2 master controllers are
connected to the same bus and both exposed to the same Linux instance
they will appear as two distinct busses, and devices on this bus will
be exposed twice.
- I2C backward compatibility has been designed to be transparent to I2C
drivers and the I2C subsystem. The I3C master just registers an I2C
adapter which creates a new I2C bus. I'd say that, from a
representation PoV it's not ideal because what should appear as a
single I3C bus exposing I3C and I2C devices here appears as 2
different buses connected to each other through the parenting (the
I3C master is the parent of the I2C and I3C busses).
On the other hand, I don't see a better solution if we want something
that is not invasive.
Missing features:
- I3C HDR modes are not supported
- no support for multi-master and the associated concepts (mastership
handover, support for secondary masters, ...)
- I2C devices can only be described using DT because this is the only
use case I have. However, the framework can easily be extended with
ACPI and board info support
- I3C slave framework. This has been completely omitted, but shouldn't
have a huge impact on the I3C framework because I3C slaves don't see
the whole bus, it's only about handling master requests and generating
IBIs. Some of the struct, constant and enum definitions could be
shared, but most of the I3C slave framework logic will be different
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-19 17:52:29 +08:00
|
|
|
/**
|
|
|
|
* i3c_device_get_info() - get I3C device information
|
|
|
|
*
|
|
|
|
* @dev: device we want information on
|
|
|
|
* @info: the information object to fill in
|
|
|
|
*
|
|
|
|
* Retrieve I3C dev info.
|
|
|
|
*/
|
2023-01-11 19:30:07 +08:00
|
|
|
void i3c_device_get_info(const struct i3c_device *dev,
|
i3c: Add core I3C infrastructure
Add core infrastructure to support I3C in Linux and document it.
This infrastructure adds basic I3C support. Advanced features will be
added afterwards.
There are a few design choices that are worth mentioning because they
impact the way I3C device drivers can interact with their devices:
- all functions used to send I3C/I2C frames must be called in
non-atomic context. Mainly done this way to ease implementation, but
this is not set in stone, and if anyone needs async support, new
functions can be added later on.
- the bus element is a separate object, but it's tightly coupled with
the master object. We thus have a 1:1 relationship between i3c_bus
and i3c_master_controller objects, and if 2 master controllers are
connected to the same bus and both exposed to the same Linux instance
they will appear as two distinct busses, and devices on this bus will
be exposed twice.
- I2C backward compatibility has been designed to be transparent to I2C
drivers and the I2C subsystem. The I3C master just registers an I2C
adapter which creates a new I2C bus. I'd say that, from a
representation PoV it's not ideal because what should appear as a
single I3C bus exposing I3C and I2C devices here appears as 2
different buses connected to each other through the parenting (the
I3C master is the parent of the I2C and I3C busses).
On the other hand, I don't see a better solution if we want something
that is not invasive.
Missing features:
- I3C HDR modes are not supported
- no support for multi-master and the associated concepts (mastership
handover, support for secondary masters, ...)
- I2C devices can only be described using DT because this is the only
use case I have. However, the framework can easily be extended with
ACPI and board info support
- I3C slave framework. This has been completely omitted, but shouldn't
have a huge impact on the I3C framework because I3C slaves don't see
the whole bus, it's only about handling master requests and generating
IBIs. Some of the struct, constant and enum definitions could be
shared, but most of the I3C slave framework logic will be different
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-19 17:52:29 +08:00
|
|
|
struct i3c_device_info *info)
|
|
|
|
{
|
|
|
|
if (!info)
|
|
|
|
return;
|
|
|
|
|
|
|
|
i3c_bus_normaluse_lock(dev->bus);
|
|
|
|
if (dev->desc)
|
|
|
|
*info = dev->desc->info;
|
|
|
|
i3c_bus_normaluse_unlock(dev->bus);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_device_get_info);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* i3c_device_disable_ibi() - Disable IBIs coming from a specific device
|
|
|
|
* @dev: device on which IBIs should be disabled
|
|
|
|
*
|
|
|
|
* This function disable IBIs coming from a specific device and wait for
|
|
|
|
* all pending IBIs to be processed.
|
|
|
|
*
|
|
|
|
* Return: 0 in case of success, a negative error core otherwise.
|
|
|
|
*/
|
|
|
|
int i3c_device_disable_ibi(struct i3c_device *dev)
|
|
|
|
{
|
|
|
|
int ret = -ENOENT;
|
|
|
|
|
|
|
|
i3c_bus_normaluse_lock(dev->bus);
|
|
|
|
if (dev->desc) {
|
|
|
|
mutex_lock(&dev->desc->ibi_lock);
|
|
|
|
ret = i3c_dev_disable_ibi_locked(dev->desc);
|
|
|
|
mutex_unlock(&dev->desc->ibi_lock);
|
|
|
|
}
|
|
|
|
i3c_bus_normaluse_unlock(dev->bus);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_device_disable_ibi);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* i3c_device_enable_ibi() - Enable IBIs coming from a specific device
|
|
|
|
* @dev: device on which IBIs should be enabled
|
|
|
|
*
|
|
|
|
* This function enable IBIs coming from a specific device and wait for
|
|
|
|
* all pending IBIs to be processed. This should be called on a device
|
|
|
|
* where i3c_device_request_ibi() has succeeded.
|
|
|
|
*
|
|
|
|
* Note that IBIs from this device might be received before this function
|
|
|
|
* returns to its caller.
|
|
|
|
*
|
|
|
|
* Return: 0 in case of success, a negative error core otherwise.
|
|
|
|
*/
|
|
|
|
int i3c_device_enable_ibi(struct i3c_device *dev)
|
|
|
|
{
|
|
|
|
int ret = -ENOENT;
|
|
|
|
|
|
|
|
i3c_bus_normaluse_lock(dev->bus);
|
|
|
|
if (dev->desc) {
|
|
|
|
mutex_lock(&dev->desc->ibi_lock);
|
|
|
|
ret = i3c_dev_enable_ibi_locked(dev->desc);
|
|
|
|
mutex_unlock(&dev->desc->ibi_lock);
|
|
|
|
}
|
|
|
|
i3c_bus_normaluse_unlock(dev->bus);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_device_enable_ibi);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* i3c_device_request_ibi() - Request an IBI
|
|
|
|
* @dev: device for which we should enable IBIs
|
|
|
|
* @req: setup requested for this IBI
|
|
|
|
*
|
|
|
|
* This function is responsible for pre-allocating all resources needed to
|
|
|
|
* process IBIs coming from @dev. When this function returns, the IBI is not
|
|
|
|
* enabled until i3c_device_enable_ibi() is called.
|
|
|
|
*
|
|
|
|
* Return: 0 in case of success, a negative error core otherwise.
|
|
|
|
*/
|
|
|
|
int i3c_device_request_ibi(struct i3c_device *dev,
|
|
|
|
const struct i3c_ibi_setup *req)
|
|
|
|
{
|
|
|
|
int ret = -ENOENT;
|
|
|
|
|
|
|
|
if (!req->handler || !req->num_slots)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
i3c_bus_normaluse_lock(dev->bus);
|
|
|
|
if (dev->desc) {
|
|
|
|
mutex_lock(&dev->desc->ibi_lock);
|
|
|
|
ret = i3c_dev_request_ibi_locked(dev->desc, req);
|
|
|
|
mutex_unlock(&dev->desc->ibi_lock);
|
|
|
|
}
|
|
|
|
i3c_bus_normaluse_unlock(dev->bus);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_device_request_ibi);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* i3c_device_free_ibi() - Free all resources needed for IBI handling
|
|
|
|
* @dev: device on which you want to release IBI resources
|
|
|
|
*
|
|
|
|
* This function is responsible for de-allocating resources previously
|
|
|
|
* allocated by i3c_device_request_ibi(). It should be called after disabling
|
|
|
|
* IBIs with i3c_device_disable_ibi().
|
|
|
|
*/
|
|
|
|
void i3c_device_free_ibi(struct i3c_device *dev)
|
|
|
|
{
|
|
|
|
i3c_bus_normaluse_lock(dev->bus);
|
|
|
|
if (dev->desc) {
|
|
|
|
mutex_lock(&dev->desc->ibi_lock);
|
|
|
|
i3c_dev_free_ibi_locked(dev->desc);
|
|
|
|
mutex_unlock(&dev->desc->ibi_lock);
|
|
|
|
}
|
|
|
|
i3c_bus_normaluse_unlock(dev->bus);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_device_free_ibi);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* i3cdev_to_dev() - Returns the device embedded in @i3cdev
|
|
|
|
* @i3cdev: I3C device
|
|
|
|
*
|
|
|
|
* Return: a pointer to a device object.
|
|
|
|
*/
|
|
|
|
struct device *i3cdev_to_dev(struct i3c_device *i3cdev)
|
|
|
|
{
|
|
|
|
return &i3cdev->dev;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3cdev_to_dev);
|
|
|
|
|
2019-07-19 21:30:54 +08:00
|
|
|
/**
|
|
|
|
* i3c_device_match_id() - Returns the i3c_device_id entry matching @i3cdev
|
|
|
|
* @i3cdev: I3C device
|
|
|
|
* @id_table: I3C device match table
|
|
|
|
*
|
|
|
|
* Return: a pointer to an i3c_device_id object or NULL if there's no match.
|
|
|
|
*/
|
|
|
|
const struct i3c_device_id *
|
|
|
|
i3c_device_match_id(struct i3c_device *i3cdev,
|
|
|
|
const struct i3c_device_id *id_table)
|
|
|
|
{
|
|
|
|
struct i3c_device_info devinfo;
|
|
|
|
const struct i3c_device_id *id;
|
2020-02-27 19:31:09 +08:00
|
|
|
u16 manuf, part, ext_info;
|
|
|
|
bool rndpid;
|
2019-07-19 21:30:54 +08:00
|
|
|
|
|
|
|
i3c_device_get_info(i3cdev, &devinfo);
|
|
|
|
|
2020-02-27 19:31:09 +08:00
|
|
|
manuf = I3C_PID_MANUF_ID(devinfo.pid);
|
|
|
|
part = I3C_PID_PART_ID(devinfo.pid);
|
|
|
|
ext_info = I3C_PID_EXTRA_INFO(devinfo.pid);
|
|
|
|
rndpid = I3C_PID_RND_LOWER_32BITS(devinfo.pid);
|
2019-07-19 21:30:54 +08:00
|
|
|
|
|
|
|
for (id = id_table; id->match_flags != 0; id++) {
|
|
|
|
if ((id->match_flags & I3C_MATCH_DCR) &&
|
2020-02-27 19:31:09 +08:00
|
|
|
id->dcr != devinfo.dcr)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if ((id->match_flags & I3C_MATCH_MANUF) &&
|
|
|
|
id->manuf_id != manuf)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if ((id->match_flags & I3C_MATCH_PART) &&
|
|
|
|
(rndpid || id->part_id != part))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if ((id->match_flags & I3C_MATCH_EXTRA_INFO) &&
|
|
|
|
(rndpid || id->extra_info != ext_info))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
return id;
|
2019-07-19 21:30:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_device_match_id);
|
|
|
|
|
i3c: Add core I3C infrastructure
Add core infrastructure to support I3C in Linux and document it.
This infrastructure adds basic I3C support. Advanced features will be
added afterwards.
There are a few design choices that are worth mentioning because they
impact the way I3C device drivers can interact with their devices:
- all functions used to send I3C/I2C frames must be called in
non-atomic context. Mainly done this way to ease implementation, but
this is not set in stone, and if anyone needs async support, new
functions can be added later on.
- the bus element is a separate object, but it's tightly coupled with
the master object. We thus have a 1:1 relationship between i3c_bus
and i3c_master_controller objects, and if 2 master controllers are
connected to the same bus and both exposed to the same Linux instance
they will appear as two distinct busses, and devices on this bus will
be exposed twice.
- I2C backward compatibility has been designed to be transparent to I2C
drivers and the I2C subsystem. The I3C master just registers an I2C
adapter which creates a new I2C bus. I'd say that, from a
representation PoV it's not ideal because what should appear as a
single I3C bus exposing I3C and I2C devices here appears as 2
different buses connected to each other through the parenting (the
I3C master is the parent of the I2C and I3C busses).
On the other hand, I don't see a better solution if we want something
that is not invasive.
Missing features:
- I3C HDR modes are not supported
- no support for multi-master and the associated concepts (mastership
handover, support for secondary masters, ...)
- I2C devices can only be described using DT because this is the only
use case I have. However, the framework can easily be extended with
ACPI and board info support
- I3C slave framework. This has been completely omitted, but shouldn't
have a huge impact on the I3C framework because I3C slaves don't see
the whole bus, it's only about handling master requests and generating
IBIs. Some of the struct, constant and enum definitions could be
shared, but most of the I3C slave framework logic will be different
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-19 17:52:29 +08:00
|
|
|
/**
|
|
|
|
* i3c_driver_register_with_owner() - register an I3C device driver
|
|
|
|
*
|
|
|
|
* @drv: driver to register
|
|
|
|
* @owner: module that owns this driver
|
|
|
|
*
|
|
|
|
* Register @drv to the core.
|
|
|
|
*
|
|
|
|
* Return: 0 in case of success, a negative error core otherwise.
|
|
|
|
*/
|
|
|
|
int i3c_driver_register_with_owner(struct i3c_driver *drv, struct module *owner)
|
|
|
|
{
|
|
|
|
drv->driver.owner = owner;
|
|
|
|
drv->driver.bus = &i3c_bus_type;
|
|
|
|
|
2021-01-28 17:10:47 +08:00
|
|
|
if (!drv->probe) {
|
|
|
|
pr_err("Trying to register an i3c driver without probe callback\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
i3c: Add core I3C infrastructure
Add core infrastructure to support I3C in Linux and document it.
This infrastructure adds basic I3C support. Advanced features will be
added afterwards.
There are a few design choices that are worth mentioning because they
impact the way I3C device drivers can interact with their devices:
- all functions used to send I3C/I2C frames must be called in
non-atomic context. Mainly done this way to ease implementation, but
this is not set in stone, and if anyone needs async support, new
functions can be added later on.
- the bus element is a separate object, but it's tightly coupled with
the master object. We thus have a 1:1 relationship between i3c_bus
and i3c_master_controller objects, and if 2 master controllers are
connected to the same bus and both exposed to the same Linux instance
they will appear as two distinct busses, and devices on this bus will
be exposed twice.
- I2C backward compatibility has been designed to be transparent to I2C
drivers and the I2C subsystem. The I3C master just registers an I2C
adapter which creates a new I2C bus. I'd say that, from a
representation PoV it's not ideal because what should appear as a
single I3C bus exposing I3C and I2C devices here appears as 2
different buses connected to each other through the parenting (the
I3C master is the parent of the I2C and I3C busses).
On the other hand, I don't see a better solution if we want something
that is not invasive.
Missing features:
- I3C HDR modes are not supported
- no support for multi-master and the associated concepts (mastership
handover, support for secondary masters, ...)
- I2C devices can only be described using DT because this is the only
use case I have. However, the framework can easily be extended with
ACPI and board info support
- I3C slave framework. This has been completely omitted, but shouldn't
have a huge impact on the I3C framework because I3C slaves don't see
the whole bus, it's only about handling master requests and generating
IBIs. Some of the struct, constant and enum definitions could be
shared, but most of the I3C slave framework logic will be different
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-19 17:52:29 +08:00
|
|
|
return driver_register(&drv->driver);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_driver_register_with_owner);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* i3c_driver_unregister() - unregister an I3C device driver
|
|
|
|
*
|
|
|
|
* @drv: driver to unregister
|
|
|
|
*
|
|
|
|
* Unregister @drv.
|
|
|
|
*/
|
|
|
|
void i3c_driver_unregister(struct i3c_driver *drv)
|
|
|
|
{
|
|
|
|
driver_unregister(&drv->driver);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(i3c_driver_unregister);
|