License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 22:07:57 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2021-09-23 15:46:04 +08:00
|
|
|
#include <math.h>
|
2015-06-03 22:25:59 +08:00
|
|
|
#include <stdio.h>
|
|
|
|
#include "evsel.h"
|
|
|
|
#include "stat.h"
|
|
|
|
#include "color.h"
|
2021-09-23 15:46:04 +08:00
|
|
|
#include "debug.h"
|
2016-03-02 02:57:52 +08:00
|
|
|
#include "pmu.h"
|
perf stat: Output JSON MetricExpr metric
Add generic infrastructure to perf stat to output ratios for
"MetricExpr" entries in the event lists. Many events are more useful as
ratios than in raw form, typically some count in relation to total
ticks.
Transfer the MetricExpr information from the alias to the evsel.
We mark the events that need to be collected for MetricExpr, and also
link the events using them with a pointer. The code is careful to always
prefer the right event in the same group to minimize multiplexing
errors. At the moment only a single relation is supported.
Then add a rblist to the stat shadow code that remembers stats based on
the cpu and context.
Then finally update and retrieve and print these values similarly to the
existing hardcoded perf metrics. We use the simple expression parser
added earlier to evaluate the expression.
Normally we just output the result without further commentary, but for
--metric-only this would lead to empty columns. So for this case use the
original event as description.
There is no attempt to automatically add the MetricExpr event, if it is
missing, however we suggest it to the user, because the user tool
doesn't have enough information to reliably construct a group that is
guaranteed to schedule. So we leave that to the user.
% perf stat -a -I 1000 -e '{unc_p_clockticks,unc_p_freq_max_os_cycles}'
1.000147889 800,085,181 unc_p_clockticks
1.000147889 93,126,241 unc_p_freq_max_os_cycles # 11.6
2.000448381 800,218,217 unc_p_clockticks
2.000448381 142,516,095 unc_p_freq_max_os_cycles # 17.8
3.000639852 800,243,057 unc_p_clockticks
3.000639852 162,292,689 unc_p_freq_max_os_cycles # 20.3
% perf stat -a -I 1000 -e '{unc_p_clockticks,unc_p_freq_max_os_cycles}' --metric-only
# time freq_max_os_cycles %
1.000127077 0.9
2.000301436 0.7
3.000456379 0.0
v2: Change from DivideBy to MetricExpr
v3: Use expr__ prefix. Support more than one other event.
v4: Update description
v5: Only print warning message once for multiple PMUs.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20170320201711.14142-11-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2017-03-21 04:17:08 +08:00
|
|
|
#include "rblist.h"
|
|
|
|
#include "evlist.h"
|
|
|
|
#include "expr.h"
|
2017-09-01 03:40:31 +08:00
|
|
|
#include "metricgroup.h"
|
perf stat: Take cgroups into account for shadow stats
As of now it doesn't consider cgroups when collecting shadow stats and
metrics so counter values from different cgroups will be saved in a same
slot. This resulted in incorrect numbers when those cgroups have
different workloads.
For example, let's look at the scenario below: cgroups A and C runs same
workload which burns a cpu while cgroup B runs a light workload.
$ perf stat -a -e cycles,instructions --for-each-cgroup A,B,C sleep 1
Performance counter stats for 'system wide':
3,958,116,522 cycles A
6,722,650,929 instructions A # 2.53 insn per cycle
1,132,741 cycles B
571,743 instructions B # 0.00 insn per cycle
4,007,799,935 cycles C
6,793,181,523 instructions C # 2.56 insn per cycle
1.001050869 seconds time elapsed
When I run 'perf stat' with single workload, it usually shows IPC around
1.7. We can verify it (6,722,650,929.0 / 3,958,116,522 = 1.698) for cgroup A.
But in this case, since cgroups are ignored, cycles are averaged so it
used the lower value for IPC calculation and resulted in around 2.5.
avg cycle: (3958116522 + 1132741 + 4007799935) / 3 = 2655683066
IPC (A) : 6722650929 / 2655683066 = 2.531
IPC (B) : 571743 / 2655683066 = 0.0002
IPC (C) : 6793181523 / 2655683066 = 2.557
We can simply compare cgroup pointers in the evsel and it'll be NULL
when cgroups are not specified. With this patch, I can see correct
numbers like below:
$ perf stat -a -e cycles,instructions --for-each-cgroup A,B,C sleep 1
Performance counter stats for 'system wide':
4,171,051,687 cycles A
7,219,793,922 instructions A # 1.73 insn per cycle
1,051,189 cycles B
583,102 instructions B # 0.55 insn per cycle
4,171,124,710 cycles C
7,192,944,580 instructions C # 1.72 insn per cycle
1.007909814 seconds time elapsed
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lore.kernel.org/lkml/20210115071139.257042-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2021-01-15 15:11:39 +08:00
|
|
|
#include "cgroup.h"
|
perf stat: Improve readability of shadow stats
This adds function convert_unit_double() and selects appropriate
unit for shadow stats between K/M/G.
$ sudo perf stat -a -- sleep 1
Before: Unit 'M' is selected even the number is very small.
Performance counter stats for 'system wide':
4,003.06 msec cpu-clock # 3.998 CPUs utilized
16,179 context-switches # 0.004 M/sec
161 cpu-migrations # 0.040 K/sec
4,699 page-faults # 0.001 M/sec
6,135,801,925 cycles # 1.533 GHz (83.21%)
5,783,308,491 stalled-cycles-frontend # 94.26% frontend cycles idle (83.21%)
4,543,694,050 stalled-cycles-backend # 74.05% backend cycles idle (66.49%)
4,720,130,587 instructions # 0.77 insn per cycle
# 1.23 stalled cycles per insn (83.28%)
753,848,078 branches # 188.318 M/sec (83.61%)
37,457,747 branch-misses # 4.97% of all branches (83.48%)
1.001283725 seconds time elapsed
After:
$ sudo perf stat -a -- sleep 2
Performance counter stats for 'system wide':
8,005.52 msec cpu-clock # 3.999 CPUs utilized
10,715 context-switches # 1.338 K/sec
785 cpu-migrations # 98.057 /sec
102 page-faults # 12.741 /sec
1,948,202,279 cycles # 0.243 GHz
2,816,470,932 stalled-cycles-frontend # 144.57% frontend cycles idle
2,661,172,207 stalled-cycles-backend # 136.60% backend cycles idle
464,172,105 instructions # 0.24 insn per cycle
# 6.07 stalled cycles per insn
91,567,662 branches # 11.438 M/sec
7,756,054 branch-misses # 8.47% of all branches
2.002040043 seconds time elapsed
v2:
o do not change 'sec' to 'cpu-sec'.
o use convert_unit_double to implement convert_unit.
Signed-off-by: Changbin Du <changbin.du@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20210315143047.3867-1-changbin.du@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2021-03-15 22:30:47 +08:00
|
|
|
#include "units.h"
|
2019-07-04 23:06:20 +08:00
|
|
|
#include <linux/zalloc.h>
|
2021-04-19 17:41:44 +08:00
|
|
|
#include "iostat.h"
|
2022-11-10 02:49:11 +08:00
|
|
|
#include "util/hashmap.h"
|
2015-06-03 22:25:59 +08:00
|
|
|
|
|
|
|
struct stats walltime_nsecs_stats;
|
2022-04-20 18:23:52 +08:00
|
|
|
struct rusage_stats ru_stats;
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:43 +08:00
|
|
|
enum {
|
|
|
|
CTX_BIT_USER = 1 << 0,
|
|
|
|
CTX_BIT_KERNEL = 1 << 1,
|
|
|
|
CTX_BIT_HV = 1 << 2,
|
|
|
|
CTX_BIT_HOST = 1 << 3,
|
|
|
|
CTX_BIT_IDLE = 1 << 4,
|
|
|
|
CTX_BIT_MAX = 1 << 5,
|
|
|
|
};
|
|
|
|
|
|
|
|
enum stat_type {
|
|
|
|
STAT_NONE = 0,
|
|
|
|
STAT_NSECS,
|
|
|
|
STAT_CYCLES,
|
2023-02-19 17:28:47 +08:00
|
|
|
STAT_INSTRUCTIONS,
|
2023-02-19 17:28:43 +08:00
|
|
|
STAT_STALLED_CYCLES_FRONT,
|
|
|
|
STAT_STALLED_CYCLES_BACK,
|
|
|
|
STAT_BRANCHES,
|
2023-02-19 17:28:47 +08:00
|
|
|
STAT_BRANCH_MISS,
|
|
|
|
STAT_CACHE_REFS,
|
|
|
|
STAT_CACHE_MISSES,
|
2023-02-19 17:28:43 +08:00
|
|
|
STAT_L1_DCACHE,
|
|
|
|
STAT_L1_ICACHE,
|
|
|
|
STAT_LL_CACHE,
|
|
|
|
STAT_ITLB_CACHE,
|
|
|
|
STAT_DTLB_CACHE,
|
2023-02-19 17:28:47 +08:00
|
|
|
STAT_L1D_MISS,
|
|
|
|
STAT_L1I_MISS,
|
|
|
|
STAT_LL_MISS,
|
|
|
|
STAT_DTLB_MISS,
|
|
|
|
STAT_ITLB_MISS,
|
2023-02-19 17:28:43 +08:00
|
|
|
STAT_MAX
|
|
|
|
};
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static int evsel_context(const struct evsel *evsel)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
|
|
|
int ctx = 0;
|
|
|
|
|
2019-07-21 19:24:29 +08:00
|
|
|
if (evsel->core.attr.exclude_kernel)
|
2015-06-03 22:25:59 +08:00
|
|
|
ctx |= CTX_BIT_KERNEL;
|
2019-07-21 19:24:29 +08:00
|
|
|
if (evsel->core.attr.exclude_user)
|
2015-06-03 22:25:59 +08:00
|
|
|
ctx |= CTX_BIT_USER;
|
2019-07-21 19:24:29 +08:00
|
|
|
if (evsel->core.attr.exclude_hv)
|
2015-06-03 22:25:59 +08:00
|
|
|
ctx |= CTX_BIT_HV;
|
2019-07-21 19:24:29 +08:00
|
|
|
if (evsel->core.attr.exclude_host)
|
2015-06-03 22:25:59 +08:00
|
|
|
ctx |= CTX_BIT_HOST;
|
2019-07-21 19:24:29 +08:00
|
|
|
if (evsel->core.attr.exclude_idle)
|
2015-06-03 22:25:59 +08:00
|
|
|
ctx |= CTX_BIT_IDLE;
|
|
|
|
|
|
|
|
return ctx;
|
|
|
|
}
|
|
|
|
|
2017-12-05 22:03:06 +08:00
|
|
|
void perf_stat__reset_shadow_stats(void)
|
|
|
|
{
|
|
|
|
memset(&walltime_nsecs_stats, 0, sizeof(walltime_nsecs_stats));
|
2022-04-20 18:23:52 +08:00
|
|
|
memset(&ru_stats, 0, sizeof(ru_stats));
|
2017-12-05 22:03:06 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static enum stat_type evsel__stat_type(const struct evsel *evsel)
|
|
|
|
{
|
|
|
|
/* Fake perf_hw_cache_op_id values for use with evsel__match. */
|
|
|
|
u64 PERF_COUNT_hw_cache_l1d_miss = PERF_COUNT_HW_CACHE_L1D |
|
|
|
|
((PERF_COUNT_HW_CACHE_OP_READ) << 8) |
|
|
|
|
((PERF_COUNT_HW_CACHE_RESULT_MISS) << 16);
|
|
|
|
u64 PERF_COUNT_hw_cache_l1i_miss = PERF_COUNT_HW_CACHE_L1I |
|
|
|
|
((PERF_COUNT_HW_CACHE_OP_READ) << 8) |
|
|
|
|
((PERF_COUNT_HW_CACHE_RESULT_MISS) << 16);
|
|
|
|
u64 PERF_COUNT_hw_cache_ll_miss = PERF_COUNT_HW_CACHE_LL |
|
|
|
|
((PERF_COUNT_HW_CACHE_OP_READ) << 8) |
|
|
|
|
((PERF_COUNT_HW_CACHE_RESULT_MISS) << 16);
|
|
|
|
u64 PERF_COUNT_hw_cache_dtlb_miss = PERF_COUNT_HW_CACHE_DTLB |
|
|
|
|
((PERF_COUNT_HW_CACHE_OP_READ) << 8) |
|
|
|
|
((PERF_COUNT_HW_CACHE_RESULT_MISS) << 16);
|
|
|
|
u64 PERF_COUNT_hw_cache_itlb_miss = PERF_COUNT_HW_CACHE_ITLB |
|
|
|
|
((PERF_COUNT_HW_CACHE_OP_READ) << 8) |
|
|
|
|
((PERF_COUNT_HW_CACHE_RESULT_MISS) << 16);
|
|
|
|
|
|
|
|
if (evsel__is_clock(evsel))
|
|
|
|
return STAT_NSECS;
|
|
|
|
else if (evsel__match(evsel, HARDWARE, HW_CPU_CYCLES))
|
|
|
|
return STAT_CYCLES;
|
|
|
|
else if (evsel__match(evsel, HARDWARE, HW_INSTRUCTIONS))
|
|
|
|
return STAT_INSTRUCTIONS;
|
|
|
|
else if (evsel__match(evsel, HARDWARE, HW_STALLED_CYCLES_FRONTEND))
|
|
|
|
return STAT_STALLED_CYCLES_FRONT;
|
|
|
|
else if (evsel__match(evsel, HARDWARE, HW_STALLED_CYCLES_BACKEND))
|
|
|
|
return STAT_STALLED_CYCLES_BACK;
|
|
|
|
else if (evsel__match(evsel, HARDWARE, HW_BRANCH_INSTRUCTIONS))
|
|
|
|
return STAT_BRANCHES;
|
|
|
|
else if (evsel__match(evsel, HARDWARE, HW_BRANCH_MISSES))
|
|
|
|
return STAT_BRANCH_MISS;
|
|
|
|
else if (evsel__match(evsel, HARDWARE, HW_CACHE_REFERENCES))
|
|
|
|
return STAT_CACHE_REFS;
|
|
|
|
else if (evsel__match(evsel, HARDWARE, HW_CACHE_MISSES))
|
|
|
|
return STAT_CACHE_MISSES;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, HW_CACHE_L1D))
|
|
|
|
return STAT_L1_DCACHE;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, HW_CACHE_L1I))
|
|
|
|
return STAT_L1_ICACHE;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, HW_CACHE_LL))
|
|
|
|
return STAT_LL_CACHE;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, HW_CACHE_DTLB))
|
|
|
|
return STAT_DTLB_CACHE;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, HW_CACHE_ITLB))
|
|
|
|
return STAT_ITLB_CACHE;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, hw_cache_l1d_miss))
|
|
|
|
return STAT_L1D_MISS;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, hw_cache_l1i_miss))
|
|
|
|
return STAT_L1I_MISS;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, hw_cache_ll_miss))
|
|
|
|
return STAT_LL_MISS;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, hw_cache_dtlb_miss))
|
|
|
|
return STAT_DTLB_MISS;
|
|
|
|
else if (evsel__match(evsel, HW_CACHE, hw_cache_itlb_miss))
|
|
|
|
return STAT_ITLB_MISS;
|
|
|
|
return STAT_NONE;
|
|
|
|
}
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static const char *get_ratio_color(const double ratios[3], double val)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
|
|
|
const char *color = PERF_COLOR_NORMAL;
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
if (val > ratios[0])
|
2015-06-03 22:25:59 +08:00
|
|
|
color = PERF_COLOR_RED;
|
2023-02-19 17:28:47 +08:00
|
|
|
else if (val > ratios[1])
|
2015-06-03 22:25:59 +08:00
|
|
|
color = PERF_COLOR_MAGENTA;
|
2023-02-19 17:28:47 +08:00
|
|
|
else if (val > ratios[2])
|
2015-06-03 22:25:59 +08:00
|
|
|
color = PERF_COLOR_YELLOW;
|
|
|
|
|
|
|
|
return color;
|
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static double find_stat(const struct evsel *evsel, int aggr_idx, enum stat_type type)
|
2017-12-05 22:03:05 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
const struct evsel *cur;
|
|
|
|
int evsel_ctx = evsel_context(evsel);
|
|
|
|
|
|
|
|
evlist__for_each_entry(evsel->evlist, cur) {
|
|
|
|
struct perf_stat_aggr *aggr;
|
|
|
|
|
|
|
|
/* Ignore the evsel that is being searched from. */
|
|
|
|
if (evsel == cur)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
/* Ignore evsels that are part of different groups. */
|
2023-03-12 10:15:36 +08:00
|
|
|
if (evsel->core.leader->nr_members > 1 &&
|
2023-02-19 17:28:47 +08:00
|
|
|
evsel->core.leader != cur->core.leader)
|
|
|
|
continue;
|
|
|
|
/* Ignore evsels with mismatched modifiers. */
|
|
|
|
if (evsel_ctx != evsel_context(cur))
|
|
|
|
continue;
|
|
|
|
/* Ignore if not the cgroup we're looking for. */
|
|
|
|
if (evsel->cgrp != cur->cgrp)
|
|
|
|
continue;
|
|
|
|
/* Ignore if not the stat we're looking for. */
|
|
|
|
if (type != evsel__stat_type(cur))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
aggr = &cur->stats->aggr[aggr_idx];
|
|
|
|
if (type == STAT_NSECS)
|
|
|
|
return aggr->counts.val;
|
|
|
|
return aggr->counts.val * cur->scale;
|
|
|
|
}
|
|
|
|
return 0.0;
|
2017-12-05 22:03:05 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_ratio(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel, int aggr_idx,
|
|
|
|
double numerator, struct perf_stat_output_ctx *out,
|
|
|
|
enum stat_type denominator_type,
|
|
|
|
const double color_ratios[3], const char *unit)
|
2017-12-05 22:03:05 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
double denominator = find_stat(evsel, aggr_idx, denominator_type);
|
2017-12-05 22:03:05 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
if (numerator && denominator) {
|
|
|
|
double ratio = numerator / denominator * 100.0;
|
|
|
|
const char *color = get_ratio_color(color_ratios, ratio);
|
2017-12-05 22:03:05 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
out->print_metric(config, out->ctx, color, "%7.2f%%", unit, ratio);
|
|
|
|
} else
|
|
|
|
out->print_metric(config, out->ctx, NULL, NULL, unit, 0);
|
2017-12-05 22:03:05 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_stalled_cycles_front(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double stalled,
|
|
|
|
struct perf_stat_output_ctx *out)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
static const double color_ratios[3] = {50.0, 30.0, 10.0};
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
print_ratio(config, evsel, aggr_idx, stalled, out, STAT_CYCLES, color_ratios,
|
|
|
|
"frontend cycles idle");
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_stalled_cycles_back(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double stalled,
|
|
|
|
struct perf_stat_output_ctx *out)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
static const double color_ratios[3] = {75.0, 50.0, 20.0};
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
print_ratio(config, evsel, aggr_idx, stalled, out, STAT_CYCLES, color_ratios,
|
|
|
|
"backend cycles idle");
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_branch_miss(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double misses,
|
|
|
|
struct perf_stat_output_ctx *out)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
static const double color_ratios[3] = {20.0, 10.0, 5.0};
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
print_ratio(config, evsel, aggr_idx, misses, out, STAT_BRANCHES, color_ratios,
|
|
|
|
"of all branches");
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_l1d_miss(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double misses,
|
|
|
|
struct perf_stat_output_ctx *out)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
static const double color_ratios[3] = {20.0, 10.0, 5.0};
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
print_ratio(config, evsel, aggr_idx, misses, out, STAT_L1_DCACHE, color_ratios,
|
|
|
|
"of all L1-dcache accesses");
|
|
|
|
}
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_l1i_miss(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double misses,
|
|
|
|
struct perf_stat_output_ctx *out)
|
|
|
|
{
|
|
|
|
static const double color_ratios[3] = {20.0, 10.0, 5.0};
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
print_ratio(config, evsel, aggr_idx, misses, out, STAT_L1_ICACHE, color_ratios,
|
|
|
|
"of all L1-icache accesses");
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_ll_miss(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double misses,
|
|
|
|
struct perf_stat_output_ctx *out)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
static const double color_ratios[3] = {20.0, 10.0, 5.0};
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
|
|
|
|
"of all L1-icache accesses");
|
|
|
|
}
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_dtlb_miss(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double misses,
|
|
|
|
struct perf_stat_output_ctx *out)
|
|
|
|
{
|
|
|
|
static const double color_ratios[3] = {20.0, 10.0, 5.0};
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
print_ratio(config, evsel, aggr_idx, misses, out, STAT_DTLB_CACHE, color_ratios,
|
|
|
|
"of all dTLB cache accesses");
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_itlb_miss(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double misses,
|
|
|
|
struct perf_stat_output_ctx *out)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
static const double color_ratios[3] = {20.0, 10.0, 5.0};
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
print_ratio(config, evsel, aggr_idx, misses, out, STAT_ITLB_CACHE, color_ratios,
|
|
|
|
"of all iTLB cache accesses");
|
|
|
|
}
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_cache_miss(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double misses,
|
|
|
|
struct perf_stat_output_ctx *out)
|
|
|
|
{
|
|
|
|
static const double color_ratios[3] = {20.0, 10.0, 5.0};
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
print_ratio(config, evsel, aggr_idx, misses, out, STAT_CACHE_REFS, color_ratios,
|
|
|
|
"of all cache refs");
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_instructions(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double instructions,
|
|
|
|
struct perf_stat_output_ctx *out)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
print_metric_t print_metric = out->print_metric;
|
|
|
|
void *ctxp = out->ctx;
|
|
|
|
double cycles = find_stat(evsel, aggr_idx, STAT_CYCLES);
|
|
|
|
double max_stalled = max(find_stat(evsel, aggr_idx, STAT_STALLED_CYCLES_FRONT),
|
|
|
|
find_stat(evsel, aggr_idx, STAT_STALLED_CYCLES_BACK));
|
|
|
|
|
|
|
|
if (cycles) {
|
|
|
|
print_metric(config, ctxp, NULL, "%7.2f ", "insn per cycle",
|
|
|
|
instructions / cycles);
|
|
|
|
} else
|
|
|
|
print_metric(config, ctxp, NULL, NULL, "insn per cycle", 0);
|
|
|
|
|
|
|
|
if (max_stalled && instructions) {
|
|
|
|
out->new_line(config, ctxp);
|
|
|
|
print_metric(config, ctxp, NULL, "%7.2f ", "stalled cycles per insn",
|
|
|
|
max_stalled / instructions);
|
|
|
|
}
|
|
|
|
}
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_cycles(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double cycles,
|
|
|
|
struct perf_stat_output_ctx *out)
|
|
|
|
{
|
|
|
|
double nsecs = find_stat(evsel, aggr_idx, STAT_NSECS);
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
if (cycles && nsecs) {
|
|
|
|
double ratio = cycles / nsecs;
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
out->print_metric(config, out->ctx, NULL, "%8.3f", "GHz", ratio);
|
|
|
|
} else
|
|
|
|
out->print_metric(config, out->ctx, NULL, NULL, "GHz", 0);
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
static void print_nsecs(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx __maybe_unused, double nsecs,
|
|
|
|
struct perf_stat_output_ctx *out)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
print_metric_t print_metric = out->print_metric;
|
|
|
|
void *ctxp = out->ctx;
|
|
|
|
double wall_time = avg_stats(&walltime_nsecs_stats);
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2023-02-19 17:28:47 +08:00
|
|
|
if (wall_time) {
|
|
|
|
print_metric(config, ctxp, NULL, "%8.3f", "CPUs utilized",
|
|
|
|
nsecs / (wall_time * evsel->scale));
|
|
|
|
} else
|
|
|
|
print_metric(config, ctxp, NULL, NULL, "CPUs utilized", 0);
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
|
|
|
|
2020-06-03 05:47:37 +08:00
|
|
|
static int prepare_metric(struct evsel **metric_events,
|
2020-07-20 02:13:11 +08:00
|
|
|
struct metric_ref *metric_refs,
|
2020-06-03 05:47:37 +08:00
|
|
|
struct expr_parse_ctx *pctx,
|
2023-02-19 17:28:45 +08:00
|
|
|
int aggr_idx)
|
2017-09-01 03:40:28 +08:00
|
|
|
{
|
2023-02-19 17:28:46 +08:00
|
|
|
int i;
|
2017-09-01 03:40:28 +08:00
|
|
|
|
|
|
|
for (i = 0; metric_events[i]; i++) {
|
2023-02-19 17:28:46 +08:00
|
|
|
char *n;
|
|
|
|
double val;
|
|
|
|
int source_count = 0;
|
2017-09-01 03:40:34 +08:00
|
|
|
|
2022-05-07 13:34:09 +08:00
|
|
|
if (evsel__is_tool(metric_events[i])) {
|
2023-02-19 17:28:46 +08:00
|
|
|
struct stats *stats;
|
|
|
|
double scale;
|
|
|
|
|
2022-05-07 13:34:09 +08:00
|
|
|
switch (metric_events[i]->tool_event) {
|
|
|
|
case PERF_TOOL_DURATION_TIME:
|
|
|
|
stats = &walltime_nsecs_stats;
|
|
|
|
scale = 1e-9;
|
|
|
|
break;
|
|
|
|
case PERF_TOOL_USER_TIME:
|
|
|
|
stats = &ru_stats.ru_utime_usec_stat;
|
|
|
|
scale = 1e-6;
|
|
|
|
break;
|
|
|
|
case PERF_TOOL_SYSTEM_TIME:
|
|
|
|
stats = &ru_stats.ru_stime_usec_stat;
|
|
|
|
scale = 1e-6;
|
|
|
|
break;
|
|
|
|
case PERF_TOOL_NONE:
|
|
|
|
pr_err("Invalid tool event 'none'");
|
|
|
|
abort();
|
|
|
|
case PERF_TOOL_MAX:
|
|
|
|
pr_err("Invalid tool event 'max'");
|
|
|
|
abort();
|
|
|
|
default:
|
|
|
|
pr_err("Unknown tool event '%s'", evsel__name(metric_events[i]));
|
|
|
|
abort();
|
|
|
|
}
|
2023-02-19 17:28:46 +08:00
|
|
|
val = avg_stats(stats) * scale;
|
|
|
|
source_count = 1;
|
2017-09-01 03:40:34 +08:00
|
|
|
} else {
|
2023-02-19 17:28:46 +08:00
|
|
|
struct perf_stat_evsel *ps = metric_events[i]->stats;
|
|
|
|
struct perf_stat_aggr *aggr = &ps->aggr[aggr_idx];
|
|
|
|
|
|
|
|
if (!aggr)
|
2017-09-01 03:40:34 +08:00
|
|
|
break;
|
2023-02-19 17:28:46 +08:00
|
|
|
|
perf metric: Change divide by zero and !support events behavior
Division by zero causes expression parsing to fail and no metric to be
generated. This can mean for short running benchmarks metrics are not
shown. Change the behavior to make the value nan, which gets shown like:
'''
$ perf stat -M TopdownL2 true
Performance counter stats for 'true':
1,031,492 INST_RETIRED.ANY # nan % tma_fetch_bandwidth
# nan % tma_heavy_operations
# nan % tma_light_operations
29,304 CPU_CLK_UNHALTED.REF_XCLK # nan % tma_fetch_latency
# nan % tma_branch_mispredicts
# nan % tma_machine_clears
# nan % tma_core_bound
# nan % tma_memory_bound
2,658,319 IDQ_UOPS_NOT_DELIVERED.CORE
11,167 EXE_ACTIVITY.BOUND_ON_STORES
262,058 EXE_ACTIVITY.1_PORTS_UTIL
<not counted> BR_MISP_RETIRED.ALL_BRANCHES (0.00%)
<not counted> INT_MISC.RECOVERY_CYCLES_ANY (0.00%)
<not counted> CPU_CLK_UNHALTED.ONE_THREAD_ACTIVE (0.00%)
<not counted> CPU_CLK_UNHALTED.THREAD (0.00%)
<not counted> UOPS_RETIRED.RETIRE_SLOTS (0.00%)
<not counted> CYCLE_ACTIVITY.STALLS_MEM_ANY (0.00%)
<not counted> UOPS_RETIRED.MACRO_FUSED (0.00%)
<not counted> IDQ_UOPS_NOT_DELIVERED.CYCLES_0_UOPS_DELIV.CORE (0.00%)
<not counted> EXE_ACTIVITY.2_PORTS_UTIL (0.00%)
<not counted> CYCLE_ACTIVITY.STALLS_TOTAL (0.00%)
<not counted> MACHINE_CLEARS.COUNT (0.00%)
<not counted> UOPS_ISSUED.ANY (0.00%)
0.002864879 seconds time elapsed
0.003012000 seconds user
0.000000000 seconds sys
'''
When events aren't supported a count of 0 can be confusing and make
metrics look meaningful. Change these to be nan also which, with the
next change, gets shown like:
'''
$ perf stat true
Performance counter stats for 'true':
1.25 msec task-clock:u # 0.387 CPUs utilized
0 context-switches:u # 0.000 /sec
0 cpu-migrations:u # 0.000 /sec
46 page-faults:u # 36.702 K/sec
255,942 cycles:u # 0.204 GHz (88.66%)
123,046 instructions:u # 0.48 insn per cycle
28,301 branches:u # 22.580 M/sec
2,489 branch-misses:u # 8.79% of all branches
4,719 CPU_CLK_UNHALTED.REF_XCLK:u # 3.765 M/sec
# nan % tma_frontend_bound
# nan % tma_retiring
# nan % tma_backend_bound
# nan % tma_bad_speculation
344,855 IDQ_UOPS_NOT_DELIVERED.CORE:u # 275.147 M/sec
<not supported> INT_MISC.RECOVERY_CYCLES_ANY:u
<not counted> CPU_CLK_UNHALTED.ONE_THREAD_ACTIVE:u (0.00%)
<not counted> CPU_CLK_UNHALTED.THREAD:u (0.00%)
<not counted> UOPS_RETIRED.RETIRE_SLOTS:u (0.00%)
<not counted> UOPS_ISSUED.ANY:u (0.00%)
0.003238142 seconds time elapsed
0.000000000 seconds user
0.003434000 seconds sys
'''
Ensure that nan metric values are quoted as nan isn't a valid number
in JSON.
Signed-off-by: Ian Rogers <irogers@google.com>
Tested-by: Kan Liang <kan.liang@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ahmad Yasin <ahmad.yasin@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Caleb Biggers <caleb.biggers@intel.com>
Cc: Edward Baker <edward.baker@intel.com>
Cc: Florian Fischer <florian.fischer@muhq.space>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kang Minchul <tegongkang@gmail.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Perry Taylor <perry.taylor@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Samantha Alt <samantha.alt@intel.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Sumanth Korikkar <sumanthk@linux.ibm.com>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Weilin Wang <weilin.wang@intel.com>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Link: https://lore.kernel.org/r/20230502223851.2234828-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2023-05-03 06:38:08 +08:00
|
|
|
if (!metric_events[i]->supported) {
|
|
|
|
/*
|
|
|
|
* Not supported events will have a count of 0,
|
|
|
|
* which can be confusing in a
|
|
|
|
* metric. Explicitly set the value to NAN. Not
|
|
|
|
* counted events (enable time of 0) are read as
|
|
|
|
* 0.
|
|
|
|
*/
|
|
|
|
val = NAN;
|
|
|
|
source_count = 0;
|
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* If an event was scaled during stat gathering,
|
|
|
|
* reverse the scale before computing the
|
|
|
|
* metric.
|
|
|
|
*/
|
|
|
|
val = aggr->counts.val * (1.0 / metric_events[i]->scale);
|
|
|
|
source_count = evsel__source_count(metric_events[i]);
|
|
|
|
}
|
2017-09-01 03:40:34 +08:00
|
|
|
}
|
perf metric: Encode and use metric-id as qualifier
For a metric like IPC a group of events like {instructions,cycles}:W
would be formed.
If the events names were changed in parsing then the metric expression
parser would fail to find them.
This change makes the event encoding be something like:
{instructions/metric-id=instructions/, cycles/metric-id=cycles/}
and then uses the evsel's stable metric-id value to locate the events.
This fixes the case that an event is restricted to user because of the
paranoia setting:
$ echo 2 > /proc/sys/kernel/perf_event_paranoid
$ perf stat -M IPC /bin/true
Performance counter stats for '/bin/true':
150,298 inst_retired.any:u # 0.77 IPC
187,095 cpu_clk_unhalted.thread:u
0.002042731 seconds time elapsed
0.000000000 seconds user
0.002377000 seconds sys
Adding the metric-id as a qualifier has a complication in that
qualifiers will become embedded in qualifiers.
For example, msr/tsc/ could become msr/tsc,metric-id=msr/tsc// which
will fail parse-events.
To solve this problem the metric is encoded and decoded for the
metric-id with !<num> standing in for an encoded value.
Previously ! wasn't parsed.
With this msr/tsc/ becomes msr/tsc,metric-id=msr!3tsc!3/
The metric expression parser is changed so that @ isn't changed to /,
instead this is done when the ID is encoded for parse events.
metricgroup__add_metric_non_group() and metricgroup__add_metric_weak_group()
need to inject the metric-id qualifier, so to avoid repetition they are
merged into a single metricgroup__build_event_string with error codes
more rigorously checked.
stat-shadow's prepare_metric() uses the metric-id to match the metricgroup
code.
As "metric-id=..." is added to all events, it is adding during testing
with the fake PMU.
This complicates pmu_str_check code as PE_PMU_EVENT_FAKE won't match as
part of a configuration.
The testing fake PMU case is fixed so that if a known qualifier with an
! is parsed then it isn't reported as a fake PMU.
This is sufficient to pass all testing but it and the original mechanism
are somewhat brittle.
Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Andi Kleen <ak@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Antonov <alexander.antonov@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andrew Kilroy <andrew.kilroy@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Changbin Du <changbin.du@intel.com>
Cc: Denys Zagorui <dzagorui@cisco.com>
Cc: Fabian Hemmer <copy@copy.sh>
Cc: Felix Fietkau <nbd@nbd.name>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: John Garry <john.garry@huawei.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Kees Kook <keescook@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nicholas Fraser <nfraser@codeweavers.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Paul Clarke <pc@us.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Riccardo Mancini <rickyman7@gmail.com>
Cc: Sami Tolvanen <samitolvanen@google.com>
Cc: ShihCheng Tu <mrtoastcheng@gmail.com>
Cc: Song Liu <songliubraving@fb.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Sumanth Korikkar <sumanthk@linux.ibm.com>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Cc: Wan Jiabing <wanjiabing@vivo.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20211015172132.1162559-17-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2021-10-16 01:21:27 +08:00
|
|
|
n = strdup(evsel__metric_id(metric_events[i]));
|
2019-06-25 03:37:11 +08:00
|
|
|
if (!n)
|
2020-06-03 05:47:37 +08:00
|
|
|
return -ENOMEM;
|
perf metric: Encode and use metric-id as qualifier
For a metric like IPC a group of events like {instructions,cycles}:W
would be formed.
If the events names were changed in parsing then the metric expression
parser would fail to find them.
This change makes the event encoding be something like:
{instructions/metric-id=instructions/, cycles/metric-id=cycles/}
and then uses the evsel's stable metric-id value to locate the events.
This fixes the case that an event is restricted to user because of the
paranoia setting:
$ echo 2 > /proc/sys/kernel/perf_event_paranoid
$ perf stat -M IPC /bin/true
Performance counter stats for '/bin/true':
150,298 inst_retired.any:u # 0.77 IPC
187,095 cpu_clk_unhalted.thread:u
0.002042731 seconds time elapsed
0.000000000 seconds user
0.002377000 seconds sys
Adding the metric-id as a qualifier has a complication in that
qualifiers will become embedded in qualifiers.
For example, msr/tsc/ could become msr/tsc,metric-id=msr/tsc// which
will fail parse-events.
To solve this problem the metric is encoded and decoded for the
metric-id with !<num> standing in for an encoded value.
Previously ! wasn't parsed.
With this msr/tsc/ becomes msr/tsc,metric-id=msr!3tsc!3/
The metric expression parser is changed so that @ isn't changed to /,
instead this is done when the ID is encoded for parse events.
metricgroup__add_metric_non_group() and metricgroup__add_metric_weak_group()
need to inject the metric-id qualifier, so to avoid repetition they are
merged into a single metricgroup__build_event_string with error codes
more rigorously checked.
stat-shadow's prepare_metric() uses the metric-id to match the metricgroup
code.
As "metric-id=..." is added to all events, it is adding during testing
with the fake PMU.
This complicates pmu_str_check code as PE_PMU_EVENT_FAKE won't match as
part of a configuration.
The testing fake PMU case is fixed so that if a known qualifier with an
! is parsed then it isn't reported as a fake PMU.
This is sufficient to pass all testing but it and the original mechanism
are somewhat brittle.
Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Andi Kleen <ak@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Antonov <alexander.antonov@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andrew Kilroy <andrew.kilroy@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Changbin Du <changbin.du@intel.com>
Cc: Denys Zagorui <dzagorui@cisco.com>
Cc: Fabian Hemmer <copy@copy.sh>
Cc: Felix Fietkau <nbd@nbd.name>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: John Garry <john.garry@huawei.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Kees Kook <keescook@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nicholas Fraser <nfraser@codeweavers.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Paul Clarke <pc@us.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Riccardo Mancini <rickyman7@gmail.com>
Cc: Sami Tolvanen <samitolvanen@google.com>
Cc: ShihCheng Tu <mrtoastcheng@gmail.com>
Cc: Song Liu <songliubraving@fb.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Sumanth Korikkar <sumanthk@linux.ibm.com>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Cc: Wan Jiabing <wanjiabing@vivo.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20211015172132.1162559-17-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2021-10-16 01:21:27 +08:00
|
|
|
|
2023-02-19 17:28:46 +08:00
|
|
|
expr__add_id_val_source_count(pctx, n, val, source_count);
|
2017-09-01 03:40:28 +08:00
|
|
|
}
|
2019-08-28 13:59:32 +08:00
|
|
|
|
2023-02-19 17:28:46 +08:00
|
|
|
for (int j = 0; metric_refs && metric_refs[j].metric_name; j++) {
|
|
|
|
int ret = expr__add_ref(pctx, &metric_refs[j]);
|
|
|
|
|
2020-07-20 02:13:11 +08:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2020-06-03 05:47:37 +08:00
|
|
|
return i;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void generic_metric(struct perf_stat_config *config,
|
|
|
|
const char *metric_expr,
|
2023-02-19 17:28:33 +08:00
|
|
|
const char *metric_threshold,
|
2020-06-03 05:47:37 +08:00
|
|
|
struct evsel **metric_events,
|
2020-07-20 02:13:11 +08:00
|
|
|
struct metric_ref *metric_refs,
|
2020-06-03 05:47:37 +08:00
|
|
|
char *name,
|
|
|
|
const char *metric_name,
|
|
|
|
const char *metric_unit,
|
|
|
|
int runtime,
|
2023-02-19 17:28:45 +08:00
|
|
|
int aggr_idx,
|
2023-02-19 17:28:44 +08:00
|
|
|
struct perf_stat_output_ctx *out)
|
2020-06-03 05:47:37 +08:00
|
|
|
{
|
|
|
|
print_metric_t print_metric = out->print_metric;
|
2021-09-23 15:46:04 +08:00
|
|
|
struct expr_parse_ctx *pctx;
|
2023-02-19 17:28:33 +08:00
|
|
|
double ratio, scale, threshold;
|
2020-06-03 05:47:37 +08:00
|
|
|
int i;
|
|
|
|
void *ctxp = out->ctx;
|
2023-02-19 17:28:33 +08:00
|
|
|
const char *color = NULL;
|
2020-06-03 05:47:37 +08:00
|
|
|
|
2021-09-23 15:46:04 +08:00
|
|
|
pctx = expr__ctx_new();
|
|
|
|
if (!pctx)
|
2020-06-03 05:47:37 +08:00
|
|
|
return;
|
|
|
|
|
2022-09-01 01:49:25 +08:00
|
|
|
if (config->user_requested_cpu_list)
|
|
|
|
pctx->sctx.user_requested_cpu_list = strdup(config->user_requested_cpu_list);
|
2022-09-01 01:49:21 +08:00
|
|
|
pctx->sctx.runtime = runtime;
|
2022-09-01 01:49:25 +08:00
|
|
|
pctx->sctx.system_wide = config->system_wide;
|
2023-02-19 17:28:45 +08:00
|
|
|
i = prepare_metric(metric_events, metric_refs, pctx, aggr_idx);
|
2021-09-23 15:46:04 +08:00
|
|
|
if (i < 0) {
|
|
|
|
expr__ctx_free(pctx);
|
|
|
|
return;
|
|
|
|
}
|
2017-09-01 03:40:28 +08:00
|
|
|
if (!metric_events[i]) {
|
2021-10-16 01:21:16 +08:00
|
|
|
if (expr__parse(&ratio, pctx, metric_expr) == 0) {
|
perf metricgroup: Scale the metric result
Some metrics define the scale unit, such as
{
"BriefDescription": "Intel Optane DC persistent memory read latency (ns). Derived from unc_m_pmm_rpq_occupancy.all",
"Counter": "0,1,2,3",
"EventCode": "0xE0",
"EventName": "UNC_M_PMM_READ_LATENCY",
"MetricExpr": "UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS",
"MetricName": "UNC_M_PMM_READ_LATENCY",
"PerPkg": "1",
"ScaleUnit": "6000000000ns",
"UMask": "0x1",
"Unit": "iMC"
},
For above example, the ratio should be,
ratio = (UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS) * 6000000000
But in current code, the ratio is not scaled ( * 6000000000)
With this patch, the ratio is scaled and the unit (ns) is printed.
For example,
# 219.4 ns UNC_M_PMM_READ_LATENCY
Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20190828055932.8269-4-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2019-08-28 13:59:31 +08:00
|
|
|
char *unit;
|
|
|
|
char metric_bf[64];
|
|
|
|
|
2023-02-19 17:28:33 +08:00
|
|
|
if (metric_threshold &&
|
2023-02-19 17:28:35 +08:00
|
|
|
expr__parse(&threshold, pctx, metric_threshold) == 0 &&
|
|
|
|
!isnan(threshold)) {
|
2023-02-19 17:28:33 +08:00
|
|
|
color = fpclassify(threshold) == FP_ZERO
|
|
|
|
? PERF_COLOR_GREEN : PERF_COLOR_RED;
|
|
|
|
}
|
|
|
|
|
perf metricgroup: Scale the metric result
Some metrics define the scale unit, such as
{
"BriefDescription": "Intel Optane DC persistent memory read latency (ns). Derived from unc_m_pmm_rpq_occupancy.all",
"Counter": "0,1,2,3",
"EventCode": "0xE0",
"EventName": "UNC_M_PMM_READ_LATENCY",
"MetricExpr": "UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS",
"MetricName": "UNC_M_PMM_READ_LATENCY",
"PerPkg": "1",
"ScaleUnit": "6000000000ns",
"UMask": "0x1",
"Unit": "iMC"
},
For above example, the ratio should be,
ratio = (UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS) * 6000000000
But in current code, the ratio is not scaled ( * 6000000000)
With this patch, the ratio is scaled and the unit (ns) is printed.
For example,
# 219.4 ns UNC_M_PMM_READ_LATENCY
Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20190828055932.8269-4-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2019-08-28 13:59:31 +08:00
|
|
|
if (metric_unit && metric_name) {
|
|
|
|
if (perf_pmu__convert_scale(metric_unit,
|
|
|
|
&unit, &scale) >= 0) {
|
|
|
|
ratio *= scale;
|
|
|
|
}
|
perf metricgroups: Enhance JSON/metric infrastructure to handle "?"
Patch enhances current metric infrastructure to handle "?" in the metric
expression. The "?" can be use for parameters whose value not known
while creating metric events and which can be replace later at runtime
to the proper value. It also add flexibility to create multiple events
out of single metric event added in JSON file.
Patch adds function 'arch_get_runtimeparam' which is a arch specific
function, returns the count of metric events need to be created. By
default it return 1.
This infrastructure needed for hv_24x7 socket/chip level events.
"hv_24x7" chip level events needs specific chip-id to which the data is
requested. Function 'arch_get_runtimeparam' implemented in header.c
which extract number of sockets from sysfs file "sockets" under
"/sys/devices/hv_24x7/interface/".
With this patch basically we are trying to create as many metric events
as define by runtime_param.
For that one loop is added in function 'metricgroup__add_metric', which
create multiple events at run time depend on return value of
'arch_get_runtimeparam' and merge that event in 'group_list'.
To achieve that we are actually passing this parameter value as part of
`expr__find_other` function and changing "?" present in metric
expression with this value.
As in our JSON file, there gonna be single metric event, and out of
which we are creating multiple events.
To understand which data count belongs to which parameter value,
we also printing param value in generic_metric function.
For example,
command:# ./perf stat -M PowerBUS_Frequency -C 0 -I 1000
1.000101867 9,356,933 hv_24x7/pm_pb_cyc,chip=0/ # 2.3 GHz PowerBUS_Frequency_0
1.000101867 9,366,134 hv_24x7/pm_pb_cyc,chip=1/ # 2.3 GHz PowerBUS_Frequency_1
2.000314878 9,365,868 hv_24x7/pm_pb_cyc,chip=0/ # 2.3 GHz PowerBUS_Frequency_0
2.000314878 9,366,092 hv_24x7/pm_pb_cyc,chip=1/ # 2.3 GHz PowerBUS_Frequency_1
So, here _0 and _1 after PowerBUS_Frequency specify parameter value.
Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Anju T Sudhakar <anju@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@ozlabs.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lore.kernel.org/lkml/20200401203340.31402-5-kjain@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2020-04-02 04:33:37 +08:00
|
|
|
if (strstr(metric_expr, "?"))
|
|
|
|
scnprintf(metric_bf, sizeof(metric_bf),
|
|
|
|
"%s %s_%d", unit, metric_name, runtime);
|
|
|
|
else
|
|
|
|
scnprintf(metric_bf, sizeof(metric_bf),
|
perf metricgroup: Scale the metric result
Some metrics define the scale unit, such as
{
"BriefDescription": "Intel Optane DC persistent memory read latency (ns). Derived from unc_m_pmm_rpq_occupancy.all",
"Counter": "0,1,2,3",
"EventCode": "0xE0",
"EventName": "UNC_M_PMM_READ_LATENCY",
"MetricExpr": "UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS",
"MetricName": "UNC_M_PMM_READ_LATENCY",
"PerPkg": "1",
"ScaleUnit": "6000000000ns",
"UMask": "0x1",
"Unit": "iMC"
},
For above example, the ratio should be,
ratio = (UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS) * 6000000000
But in current code, the ratio is not scaled ( * 6000000000)
With this patch, the ratio is scaled and the unit (ns) is printed.
For example,
# 219.4 ns UNC_M_PMM_READ_LATENCY
Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20190828055932.8269-4-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2019-08-28 13:59:31 +08:00
|
|
|
"%s %s", unit, metric_name);
|
perf metricgroups: Enhance JSON/metric infrastructure to handle "?"
Patch enhances current metric infrastructure to handle "?" in the metric
expression. The "?" can be use for parameters whose value not known
while creating metric events and which can be replace later at runtime
to the proper value. It also add flexibility to create multiple events
out of single metric event added in JSON file.
Patch adds function 'arch_get_runtimeparam' which is a arch specific
function, returns the count of metric events need to be created. By
default it return 1.
This infrastructure needed for hv_24x7 socket/chip level events.
"hv_24x7" chip level events needs specific chip-id to which the data is
requested. Function 'arch_get_runtimeparam' implemented in header.c
which extract number of sockets from sysfs file "sockets" under
"/sys/devices/hv_24x7/interface/".
With this patch basically we are trying to create as many metric events
as define by runtime_param.
For that one loop is added in function 'metricgroup__add_metric', which
create multiple events at run time depend on return value of
'arch_get_runtimeparam' and merge that event in 'group_list'.
To achieve that we are actually passing this parameter value as part of
`expr__find_other` function and changing "?" present in metric
expression with this value.
As in our JSON file, there gonna be single metric event, and out of
which we are creating multiple events.
To understand which data count belongs to which parameter value,
we also printing param value in generic_metric function.
For example,
command:# ./perf stat -M PowerBUS_Frequency -C 0 -I 1000
1.000101867 9,356,933 hv_24x7/pm_pb_cyc,chip=0/ # 2.3 GHz PowerBUS_Frequency_0
1.000101867 9,366,134 hv_24x7/pm_pb_cyc,chip=1/ # 2.3 GHz PowerBUS_Frequency_1
2.000314878 9,365,868 hv_24x7/pm_pb_cyc,chip=0/ # 2.3 GHz PowerBUS_Frequency_0
2.000314878 9,366,092 hv_24x7/pm_pb_cyc,chip=1/ # 2.3 GHz PowerBUS_Frequency_1
So, here _0 and _1 after PowerBUS_Frequency specify parameter value.
Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Anju T Sudhakar <anju@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@ozlabs.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lore.kernel.org/lkml/20200401203340.31402-5-kjain@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2020-04-02 04:33:37 +08:00
|
|
|
|
2023-02-19 17:28:33 +08:00
|
|
|
print_metric(config, ctxp, color, "%8.1f",
|
perf metricgroup: Scale the metric result
Some metrics define the scale unit, such as
{
"BriefDescription": "Intel Optane DC persistent memory read latency (ns). Derived from unc_m_pmm_rpq_occupancy.all",
"Counter": "0,1,2,3",
"EventCode": "0xE0",
"EventName": "UNC_M_PMM_READ_LATENCY",
"MetricExpr": "UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS",
"MetricName": "UNC_M_PMM_READ_LATENCY",
"PerPkg": "1",
"ScaleUnit": "6000000000ns",
"UMask": "0x1",
"Unit": "iMC"
},
For above example, the ratio should be,
ratio = (UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS) * 6000000000
But in current code, the ratio is not scaled ( * 6000000000)
With this patch, the ratio is scaled and the unit (ns) is printed.
For example,
# 219.4 ns UNC_M_PMM_READ_LATENCY
Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20190828055932.8269-4-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2019-08-28 13:59:31 +08:00
|
|
|
metric_bf, ratio);
|
|
|
|
} else {
|
2023-02-19 17:28:33 +08:00
|
|
|
print_metric(config, ctxp, color, "%8.2f",
|
perf metricgroup: Scale the metric result
Some metrics define the scale unit, such as
{
"BriefDescription": "Intel Optane DC persistent memory read latency (ns). Derived from unc_m_pmm_rpq_occupancy.all",
"Counter": "0,1,2,3",
"EventCode": "0xE0",
"EventName": "UNC_M_PMM_READ_LATENCY",
"MetricExpr": "UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS",
"MetricName": "UNC_M_PMM_READ_LATENCY",
"PerPkg": "1",
"ScaleUnit": "6000000000ns",
"UMask": "0x1",
"Unit": "iMC"
},
For above example, the ratio should be,
ratio = (UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS) * 6000000000
But in current code, the ratio is not scaled ( * 6000000000)
With this patch, the ratio is scaled and the unit (ns) is printed.
For example,
# 219.4 ns UNC_M_PMM_READ_LATENCY
Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20190828055932.8269-4-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2019-08-28 13:59:31 +08:00
|
|
|
metric_name ?
|
|
|
|
metric_name :
|
|
|
|
out->force_header ? name : "",
|
|
|
|
ratio);
|
|
|
|
}
|
|
|
|
} else {
|
2023-02-19 17:28:33 +08:00
|
|
|
print_metric(config, ctxp, color, /*unit=*/NULL,
|
2017-09-01 03:40:29 +08:00
|
|
|
out->force_header ?
|
|
|
|
(metric_name ? metric_name : name) : "", 0);
|
perf metricgroup: Scale the metric result
Some metrics define the scale unit, such as
{
"BriefDescription": "Intel Optane DC persistent memory read latency (ns). Derived from unc_m_pmm_rpq_occupancy.all",
"Counter": "0,1,2,3",
"EventCode": "0xE0",
"EventName": "UNC_M_PMM_READ_LATENCY",
"MetricExpr": "UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS",
"MetricName": "UNC_M_PMM_READ_LATENCY",
"PerPkg": "1",
"ScaleUnit": "6000000000ns",
"UMask": "0x1",
"Unit": "iMC"
},
For above example, the ratio should be,
ratio = (UNC_M_PMM_RPQ_OCCUPANCY.ALL / UNC_M_PMM_RPQ_INSERTS / UNC_M_CLOCKTICKS) * 6000000000
But in current code, the ratio is not scaled ( * 6000000000)
With this patch, the ratio is scaled and the unit (ns) is printed.
For example,
# 219.4 ns UNC_M_PMM_READ_LATENCY
Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20190828055932.8269-4-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2019-08-28 13:59:31 +08:00
|
|
|
}
|
2020-04-01 02:02:26 +08:00
|
|
|
} else {
|
2023-02-19 17:28:33 +08:00
|
|
|
print_metric(config, ctxp, color, /*unit=*/NULL,
|
2020-04-01 02:02:26 +08:00
|
|
|
out->force_header ?
|
|
|
|
(metric_name ? metric_name : name) : "", 0);
|
|
|
|
}
|
2019-06-25 03:37:11 +08:00
|
|
|
|
2021-09-23 15:46:04 +08:00
|
|
|
expr__ctx_free(pctx);
|
2017-09-01 03:40:28 +08:00
|
|
|
}
|
|
|
|
|
2023-02-19 17:28:45 +08:00
|
|
|
double test_generic_metric(struct metric_expr *mexp, int aggr_idx)
|
2020-06-03 05:47:39 +08:00
|
|
|
{
|
2021-09-23 15:46:04 +08:00
|
|
|
struct expr_parse_ctx *pctx;
|
2020-09-15 11:18:15 +08:00
|
|
|
double ratio = 0.0;
|
2020-06-03 05:47:39 +08:00
|
|
|
|
2021-09-23 15:46:04 +08:00
|
|
|
pctx = expr__ctx_new();
|
|
|
|
if (!pctx)
|
|
|
|
return NAN;
|
|
|
|
|
2023-02-19 17:28:45 +08:00
|
|
|
if (prepare_metric(mexp->metric_events, mexp->metric_refs, pctx, aggr_idx) < 0)
|
2020-09-15 11:18:15 +08:00
|
|
|
goto out;
|
2020-06-03 05:47:39 +08:00
|
|
|
|
2021-10-16 01:21:16 +08:00
|
|
|
if (expr__parse(&ratio, pctx, mexp->metric_expr))
|
2020-09-15 11:18:15 +08:00
|
|
|
ratio = 0.0;
|
2020-06-03 05:47:39 +08:00
|
|
|
|
2020-09-15 11:18:15 +08:00
|
|
|
out:
|
2021-09-23 15:46:04 +08:00
|
|
|
expr__ctx_free(pctx);
|
2020-06-03 05:47:39 +08:00
|
|
|
return ratio;
|
|
|
|
}
|
|
|
|
|
perf stat: New metricgroup output for the default mode
In the default mode, the current output of the metricgroup include both
events and metrics, which is not necessary and just makes the output
hard to read. Since different ARCHs (even different generations in the
same ARCH) may use different events. The output also vary on different
platforms.
For a metricgroup, only outputting the value of each metric is good
enough.
Add a new field default_metricgroup in evsel to indicate an event of the
default metricgroup. For those events, printout() should print the
metricgroup name rather than each event.
Add perf_stat__skip_metric_event() to skip the evsel in the Default
metricgroup, if it's not running or not the metric event.
Add print_metricgroup_header_t to pass the functions which print the
display name of each metricgroup in the Default metricgroup. Support all
three output methods.
Factor out perf_stat__print_shadow_stats_metricgroup() to print out each
metrics.
On SPR:
Before:
./perf_old stat sleep 1
Performance counter stats for 'sleep 1':
0.54 msec task-clock:u # 0.001 CPUs utilized
0 context-switches:u # 0.000 /sec
0 cpu-migrations:u # 0.000 /sec
68 page-faults:u # 125.445 K/sec
540,970 cycles:u # 0.998 GHz
556,325 instructions:u # 1.03 insn per cycle
123,602 branches:u # 228.018 M/sec
6,889 branch-misses:u # 5.57% of all branches
3,245,820 TOPDOWN.SLOTS:u # 18.4 % tma_backend_bound
# 17.2 % tma_retiring
# 23.1 % tma_bad_speculation
# 41.4 % tma_frontend_bound
564,859 topdown-retiring:u
1,370,999 topdown-fe-bound:u
603,271 topdown-be-bound:u
744,874 topdown-bad-spec:u
12,661 INT_MISC.UOP_DROPPING:u # 23.357 M/sec
1.001798215 seconds time elapsed
0.000193000 seconds user
0.001700000 seconds sys
After:
$ ./perf stat sleep 1
Performance counter stats for 'sleep 1':
0.51 msec task-clock:u # 0.001 CPUs utilized
0 context-switches:u # 0.000 /sec
0 cpu-migrations:u # 0.000 /sec
68 page-faults:u # 132.683 K/sec
545,228 cycles:u # 1.064 GHz
555,509 instructions:u # 1.02 insn per cycle
123,574 branches:u # 241.120 M/sec
6,957 branch-misses:u # 5.63% of all branches
TopdownL1 # 17.5 % tma_backend_bound
# 22.6 % tma_bad_speculation
# 42.7 % tma_frontend_bound
# 17.1 % tma_retiring
TopdownL2 # 21.8 % tma_branch_mispredicts
# 11.5 % tma_core_bound
# 13.4 % tma_fetch_bandwidth
# 29.3 % tma_fetch_latency
# 2.7 % tma_heavy_operations
# 14.5 % tma_light_operations
# 0.8 % tma_machine_clears
# 6.1 % tma_memory_bound
1.001712086 seconds time elapsed
0.000151000 seconds user
0.001618000 seconds sys
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ahmad Yasin <ahmad.yasin@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: https://lore.kernel.org/r/20230616031420.3751973-3-kan.liang@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2023-06-16 11:14:17 +08:00
|
|
|
static void perf_stat__print_metricgroup_header(struct perf_stat_config *config,
|
|
|
|
struct evsel *evsel,
|
|
|
|
void *ctxp,
|
|
|
|
const char *name,
|
|
|
|
struct perf_stat_output_ctx *out)
|
|
|
|
{
|
|
|
|
bool need_full_name = perf_pmus__num_core_pmus() > 1;
|
|
|
|
static const char *last_name;
|
|
|
|
static const char *last_pmu;
|
|
|
|
char full_name[64];
|
|
|
|
|
|
|
|
/*
|
|
|
|
* A metricgroup may have several metric events,
|
|
|
|
* e.g.,TopdownL1 on e-core of ADL.
|
|
|
|
* The name has been output by the first metric
|
|
|
|
* event. Only align with other metics from
|
|
|
|
* different metric events.
|
|
|
|
*/
|
|
|
|
if (last_name && !strcmp(last_name, name)) {
|
|
|
|
if (!need_full_name || !strcmp(last_pmu, evsel->pmu_name)) {
|
|
|
|
out->print_metricgroup_header(config, ctxp, NULL);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (need_full_name)
|
|
|
|
scnprintf(full_name, sizeof(full_name), "%s (%s)", name, evsel->pmu_name);
|
|
|
|
else
|
|
|
|
scnprintf(full_name, sizeof(full_name), "%s", name);
|
|
|
|
|
|
|
|
out->print_metricgroup_header(config, ctxp, full_name);
|
|
|
|
|
|
|
|
last_name = name;
|
|
|
|
last_pmu = evsel->pmu_name;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* perf_stat__print_shadow_stats_metricgroup - Print out metrics associated with the evsel
|
|
|
|
* For the non-default, all metrics associated
|
|
|
|
* with the evsel are printed.
|
|
|
|
* For the default mode, only the metrics from
|
|
|
|
* the same metricgroup and the name of the
|
|
|
|
* metricgroup are printed. To print the metrics
|
|
|
|
* from the next metricgroup (if available),
|
|
|
|
* invoke the function with correspoinding
|
|
|
|
* metric_expr.
|
|
|
|
*/
|
|
|
|
void *perf_stat__print_shadow_stats_metricgroup(struct perf_stat_config *config,
|
|
|
|
struct evsel *evsel,
|
|
|
|
int aggr_idx,
|
|
|
|
int *num,
|
|
|
|
void *from,
|
|
|
|
struct perf_stat_output_ctx *out,
|
|
|
|
struct rblist *metric_events)
|
|
|
|
{
|
|
|
|
struct metric_event *me;
|
|
|
|
struct metric_expr *mexp = from;
|
|
|
|
void *ctxp = out->ctx;
|
|
|
|
bool header_printed = false;
|
|
|
|
const char *name = NULL;
|
|
|
|
|
|
|
|
me = metricgroup__lookup(metric_events, evsel, false);
|
|
|
|
if (me == NULL)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
if (!mexp)
|
|
|
|
mexp = list_first_entry(&me->head, typeof(*mexp), nd);
|
|
|
|
|
|
|
|
list_for_each_entry_from(mexp, &me->head, nd) {
|
|
|
|
/* Print the display name of the Default metricgroup */
|
|
|
|
if (!config->metric_only && me->is_default) {
|
|
|
|
if (!name)
|
|
|
|
name = mexp->default_metricgroup_name;
|
|
|
|
/*
|
|
|
|
* Two or more metricgroup may share the same metric
|
|
|
|
* event, e.g., TopdownL1 and TopdownL2 on SPR.
|
|
|
|
* Return and print the prefix, e.g., noise, running
|
|
|
|
* for the next metricgroup.
|
|
|
|
*/
|
|
|
|
if (strcmp(name, mexp->default_metricgroup_name))
|
|
|
|
return (void *)mexp;
|
|
|
|
/* Only print the name of the metricgroup once */
|
|
|
|
if (!header_printed) {
|
|
|
|
header_printed = true;
|
|
|
|
perf_stat__print_metricgroup_header(config, evsel, ctxp,
|
|
|
|
name, out);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((*num)++ > 0)
|
|
|
|
out->new_line(config, ctxp);
|
|
|
|
generic_metric(config, mexp->metric_expr, mexp->metric_threshold,
|
|
|
|
mexp->metric_events, mexp->metric_refs, evsel->name,
|
|
|
|
mexp->metric_name, mexp->metric_unit, mexp->runtime,
|
|
|
|
aggr_idx, out);
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2018-08-30 14:32:28 +08:00
|
|
|
void perf_stat__print_shadow_stats(struct perf_stat_config *config,
|
2019-07-21 19:23:51 +08:00
|
|
|
struct evsel *evsel,
|
2023-02-19 17:28:45 +08:00
|
|
|
double avg, int aggr_idx,
|
2017-09-01 03:40:31 +08:00
|
|
|
struct perf_stat_output_ctx *out,
|
2023-02-19 17:28:44 +08:00
|
|
|
struct rblist *metric_events)
|
2015-06-03 22:25:59 +08:00
|
|
|
{
|
2023-02-19 17:28:47 +08:00
|
|
|
typedef void (*stat_print_function_t)(struct perf_stat_config *config,
|
|
|
|
const struct evsel *evsel,
|
|
|
|
int aggr_idx, double misses,
|
|
|
|
struct perf_stat_output_ctx *out);
|
|
|
|
static const stat_print_function_t stat_print_function[STAT_MAX] = {
|
|
|
|
[STAT_INSTRUCTIONS] = print_instructions,
|
|
|
|
[STAT_BRANCH_MISS] = print_branch_miss,
|
|
|
|
[STAT_L1D_MISS] = print_l1d_miss,
|
|
|
|
[STAT_L1I_MISS] = print_l1i_miss,
|
|
|
|
[STAT_DTLB_MISS] = print_dtlb_miss,
|
|
|
|
[STAT_ITLB_MISS] = print_itlb_miss,
|
|
|
|
[STAT_LL_MISS] = print_ll_miss,
|
|
|
|
[STAT_CACHE_MISSES] = print_cache_miss,
|
|
|
|
[STAT_STALLED_CYCLES_FRONT] = print_stalled_cycles_front,
|
|
|
|
[STAT_STALLED_CYCLES_BACK] = print_stalled_cycles_back,
|
|
|
|
[STAT_CYCLES] = print_cycles,
|
|
|
|
[STAT_NSECS] = print_nsecs,
|
2021-01-15 15:11:38 +08:00
|
|
|
};
|
2023-02-19 17:28:47 +08:00
|
|
|
print_metric_t print_metric = out->print_metric;
|
|
|
|
void *ctxp = out->ctx;
|
2017-09-01 03:40:31 +08:00
|
|
|
int num = 1;
|
2015-06-03 22:25:59 +08:00
|
|
|
|
2021-04-19 17:41:44 +08:00
|
|
|
if (config->iostat_run) {
|
|
|
|
iostat_print_metric(config, evsel, out);
|
2015-06-03 22:25:59 +08:00
|
|
|
} else {
|
2023-02-19 17:28:47 +08:00
|
|
|
stat_print_function_t fn = stat_print_function[evsel__stat_type(evsel)];
|
|
|
|
|
|
|
|
if (fn)
|
|
|
|
fn(config, evsel, aggr_idx, avg, out);
|
|
|
|
else {
|
|
|
|
double nsecs = find_stat(evsel, aggr_idx, STAT_NSECS);
|
|
|
|
|
|
|
|
if (nsecs) {
|
|
|
|
char unit = ' ';
|
|
|
|
char unit_buf[10] = "/sec";
|
|
|
|
double ratio = convert_unit_double(1000000000.0 * avg / nsecs,
|
|
|
|
&unit);
|
|
|
|
|
|
|
|
if (unit != ' ')
|
|
|
|
snprintf(unit_buf, sizeof(unit_buf), "%c/sec", unit);
|
|
|
|
print_metric(config, ctxp, NULL, "%8.3f", unit_buf, ratio);
|
|
|
|
} else
|
|
|
|
num = 0;
|
|
|
|
}
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
2017-09-01 03:40:31 +08:00
|
|
|
|
perf stat: New metricgroup output for the default mode
In the default mode, the current output of the metricgroup include both
events and metrics, which is not necessary and just makes the output
hard to read. Since different ARCHs (even different generations in the
same ARCH) may use different events. The output also vary on different
platforms.
For a metricgroup, only outputting the value of each metric is good
enough.
Add a new field default_metricgroup in evsel to indicate an event of the
default metricgroup. For those events, printout() should print the
metricgroup name rather than each event.
Add perf_stat__skip_metric_event() to skip the evsel in the Default
metricgroup, if it's not running or not the metric event.
Add print_metricgroup_header_t to pass the functions which print the
display name of each metricgroup in the Default metricgroup. Support all
three output methods.
Factor out perf_stat__print_shadow_stats_metricgroup() to print out each
metrics.
On SPR:
Before:
./perf_old stat sleep 1
Performance counter stats for 'sleep 1':
0.54 msec task-clock:u # 0.001 CPUs utilized
0 context-switches:u # 0.000 /sec
0 cpu-migrations:u # 0.000 /sec
68 page-faults:u # 125.445 K/sec
540,970 cycles:u # 0.998 GHz
556,325 instructions:u # 1.03 insn per cycle
123,602 branches:u # 228.018 M/sec
6,889 branch-misses:u # 5.57% of all branches
3,245,820 TOPDOWN.SLOTS:u # 18.4 % tma_backend_bound
# 17.2 % tma_retiring
# 23.1 % tma_bad_speculation
# 41.4 % tma_frontend_bound
564,859 topdown-retiring:u
1,370,999 topdown-fe-bound:u
603,271 topdown-be-bound:u
744,874 topdown-bad-spec:u
12,661 INT_MISC.UOP_DROPPING:u # 23.357 M/sec
1.001798215 seconds time elapsed
0.000193000 seconds user
0.001700000 seconds sys
After:
$ ./perf stat sleep 1
Performance counter stats for 'sleep 1':
0.51 msec task-clock:u # 0.001 CPUs utilized
0 context-switches:u # 0.000 /sec
0 cpu-migrations:u # 0.000 /sec
68 page-faults:u # 132.683 K/sec
545,228 cycles:u # 1.064 GHz
555,509 instructions:u # 1.02 insn per cycle
123,574 branches:u # 241.120 M/sec
6,957 branch-misses:u # 5.63% of all branches
TopdownL1 # 17.5 % tma_backend_bound
# 22.6 % tma_bad_speculation
# 42.7 % tma_frontend_bound
# 17.1 % tma_retiring
TopdownL2 # 21.8 % tma_branch_mispredicts
# 11.5 % tma_core_bound
# 13.4 % tma_fetch_bandwidth
# 29.3 % tma_fetch_latency
# 2.7 % tma_heavy_operations
# 14.5 % tma_light_operations
# 0.8 % tma_machine_clears
# 6.1 % tma_memory_bound
1.001712086 seconds time elapsed
0.000151000 seconds user
0.001618000 seconds sys
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ahmad Yasin <ahmad.yasin@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: https://lore.kernel.org/r/20230616031420.3751973-3-kan.liang@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2023-06-16 11:14:17 +08:00
|
|
|
perf_stat__print_shadow_stats_metricgroup(config, evsel, aggr_idx,
|
|
|
|
&num, NULL, out, metric_events);
|
2017-09-01 03:40:31 +08:00
|
|
|
|
|
|
|
if (num == 0)
|
2018-08-30 14:32:28 +08:00
|
|
|
print_metric(config, ctxp, NULL, NULL, NULL, 0);
|
2015-06-03 22:25:59 +08:00
|
|
|
}
|
perf stat: New metricgroup output for the default mode
In the default mode, the current output of the metricgroup include both
events and metrics, which is not necessary and just makes the output
hard to read. Since different ARCHs (even different generations in the
same ARCH) may use different events. The output also vary on different
platforms.
For a metricgroup, only outputting the value of each metric is good
enough.
Add a new field default_metricgroup in evsel to indicate an event of the
default metricgroup. For those events, printout() should print the
metricgroup name rather than each event.
Add perf_stat__skip_metric_event() to skip the evsel in the Default
metricgroup, if it's not running or not the metric event.
Add print_metricgroup_header_t to pass the functions which print the
display name of each metricgroup in the Default metricgroup. Support all
three output methods.
Factor out perf_stat__print_shadow_stats_metricgroup() to print out each
metrics.
On SPR:
Before:
./perf_old stat sleep 1
Performance counter stats for 'sleep 1':
0.54 msec task-clock:u # 0.001 CPUs utilized
0 context-switches:u # 0.000 /sec
0 cpu-migrations:u # 0.000 /sec
68 page-faults:u # 125.445 K/sec
540,970 cycles:u # 0.998 GHz
556,325 instructions:u # 1.03 insn per cycle
123,602 branches:u # 228.018 M/sec
6,889 branch-misses:u # 5.57% of all branches
3,245,820 TOPDOWN.SLOTS:u # 18.4 % tma_backend_bound
# 17.2 % tma_retiring
# 23.1 % tma_bad_speculation
# 41.4 % tma_frontend_bound
564,859 topdown-retiring:u
1,370,999 topdown-fe-bound:u
603,271 topdown-be-bound:u
744,874 topdown-bad-spec:u
12,661 INT_MISC.UOP_DROPPING:u # 23.357 M/sec
1.001798215 seconds time elapsed
0.000193000 seconds user
0.001700000 seconds sys
After:
$ ./perf stat sleep 1
Performance counter stats for 'sleep 1':
0.51 msec task-clock:u # 0.001 CPUs utilized
0 context-switches:u # 0.000 /sec
0 cpu-migrations:u # 0.000 /sec
68 page-faults:u # 132.683 K/sec
545,228 cycles:u # 1.064 GHz
555,509 instructions:u # 1.02 insn per cycle
123,574 branches:u # 241.120 M/sec
6,957 branch-misses:u # 5.63% of all branches
TopdownL1 # 17.5 % tma_backend_bound
# 22.6 % tma_bad_speculation
# 42.7 % tma_frontend_bound
# 17.1 % tma_retiring
TopdownL2 # 21.8 % tma_branch_mispredicts
# 11.5 % tma_core_bound
# 13.4 % tma_fetch_bandwidth
# 29.3 % tma_fetch_latency
# 2.7 % tma_heavy_operations
# 14.5 % tma_light_operations
# 0.8 % tma_machine_clears
# 6.1 % tma_memory_bound
1.001712086 seconds time elapsed
0.000151000 seconds user
0.001618000 seconds sys
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ahmad Yasin <ahmad.yasin@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: https://lore.kernel.org/r/20230616031420.3751973-3-kan.liang@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2023-06-16 11:14:17 +08:00
|
|
|
|
|
|
|
/**
|
|
|
|
* perf_stat__skip_metric_event - Skip the evsel in the Default metricgroup,
|
|
|
|
* if it's not running or not the metric event.
|
|
|
|
*/
|
|
|
|
bool perf_stat__skip_metric_event(struct evsel *evsel,
|
|
|
|
struct rblist *metric_events,
|
|
|
|
u64 ena, u64 run)
|
|
|
|
{
|
|
|
|
if (!evsel->default_metricgroup)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (!ena || !run)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return !metricgroup__lookup(metric_events, evsel, false);
|
|
|
|
}
|