2019-05-22 15:51:44 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2014-08-07 07:05:25 +08:00
|
|
|
/*
|
|
|
|
* Contiguous Memory Allocator
|
|
|
|
*
|
|
|
|
* Copyright (c) 2010-2011 by Samsung Electronics.
|
|
|
|
* Copyright IBM Corporation, 2013
|
|
|
|
* Copyright LG Electronics Inc., 2014
|
|
|
|
* Written by:
|
|
|
|
* Marek Szyprowski <m.szyprowski@samsung.com>
|
|
|
|
* Michal Nazarewicz <mina86@mina86.com>
|
|
|
|
* Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
|
|
|
|
* Joonsoo Kim <iamjoonsoo.kim@lge.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#define pr_fmt(fmt) "cma: " fmt
|
|
|
|
|
2015-04-16 07:14:50 +08:00
|
|
|
#define CREATE_TRACE_POINTS
|
2014-08-07 07:05:25 +08:00
|
|
|
|
|
|
|
#include <linux/memblock.h>
|
|
|
|
#include <linux/err.h>
|
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/sizes.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/log2.h>
|
|
|
|
#include <linux/cma.h>
|
2014-10-10 06:26:47 +08:00
|
|
|
#include <linux/highmem.h>
|
2014-12-13 08:58:31 +08:00
|
|
|
#include <linux/io.h>
|
2018-04-06 07:25:34 +08:00
|
|
|
#include <linux/kmemleak.h>
|
2015-04-16 07:14:50 +08:00
|
|
|
#include <trace/events/cma.h>
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2023-03-22 01:05:02 +08:00
|
|
|
#include "internal.h"
|
2015-04-15 06:44:57 +08:00
|
|
|
#include "cma.h"
|
|
|
|
|
|
|
|
struct cma cma_areas[MAX_CMA_AREAS];
|
|
|
|
unsigned cma_area_count;
|
Revert "mm/cma.c: remove redundant cma_mutex lock"
This reverts commit a4efc174b382fcdb which introduced a regression issue
that when there're multiple processes allocating dma memory in parallel by
calling dma_alloc_coherent(), it may fail sometimes as follows:
Error log:
cma: cma_alloc: linux,cma: alloc failed, req-size: 148 pages, ret: -16
cma: number of available pages:
3@125+20@172+12@236+4@380+32@736+17@2287+23@2473+20@36076+99@40477+108@40852+44@41108+20@41196+108@41364+108@41620+
108@42900+108@43156+483@44061+1763@45341+1440@47712+20@49324+20@49388+5076@49452+2304@55040+35@58141+20@58220+20@58284+
7188@58348+84@66220+7276@66452+227@74525+6371@75549=> 33161 free of 81920 total pages
When issue happened, we saw there were still 33161 pages (129M) free CMA
memory and a lot available free slots for 148 pages in CMA bitmap that we
want to allocate.
When dumping memory info, we found that there was also ~342M normal
memory, but only 1352K CMA memory left in buddy system while a lot of
pageblocks were isolated.
Memory info log:
Normal free:351096kB min:30000kB low:37500kB high:45000kB reserved_highatomic:0KB
active_anon:98060kB inactive_anon:98948kB active_file:60864kB inactive_file:31776kB
unevictable:0kB writepending:0kB present:1048576kB managed:1018328kB mlocked:0kB
bounce:0kB free_pcp:220kB local_pcp:192kB free_cma:1352kB lowmem_reserve[]: 0 0 0
Normal: 78*4kB (UECI) 1772*8kB (UMECI) 1335*16kB (UMECI) 360*32kB (UMECI) 65*64kB (UMCI)
36*128kB (UMECI) 16*256kB (UMCI) 6*512kB (EI) 8*1024kB (UEI) 4*2048kB (MI) 8*4096kB (EI)
8*8192kB (UI) 3*16384kB (EI) 8*32768kB (M) = 489288kB
The root cause of this issue is that since commit a4efc174b382 ("mm/cma.c:
remove redundant cma_mutex lock"), CMA supports concurrent memory
allocation. It's possible that the memory range process A trying to alloc
has already been isolated by the allocation of process B during memory
migration.
The problem here is that the memory range isolated during one allocation
by start_isolate_page_range() could be much bigger than the real size we
want to alloc due to the range is aligned to MAX_ORDER_NR_PAGES.
Taking an ARMv7 platform with 1G memory as an example, when
MAX_ORDER_NR_PAGES is big (e.g. 32M with max_order 14) and CMA memory is
relatively small (e.g. 128M), there're only 4 MAX_ORDER slot, then it's
very easy that all CMA memory may have already been isolated by other
processes when one trying to allocate memory using dma_alloc_coherent().
Since current CMA code will only scan one time of whole available CMA
memory, then dma_alloc_coherent() may easy fail due to contention with
other processes.
This patch simply falls back to the original method that using cma_mutex
to make alloc_contig_range() run sequentially to avoid the issue.
Link: https://lkml.kernel.org/r/20220509094551.3596244-1-aisheng.dong@nxp.com
Link: https://lore.kernel.org/all/20220315144521.3810298-2-aisheng.dong@nxp.com/
Fixes: a4efc174b382 ("mm/cma.c: remove redundant cma_mutex lock")
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: <stable@vger.kernel.org> [5.11+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2022-05-14 06:11:26 +08:00
|
|
|
static DEFINE_MUTEX(cma_mutex);
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2015-04-15 06:47:04 +08:00
|
|
|
phys_addr_t cma_get_base(const struct cma *cma)
|
2014-08-07 07:05:25 +08:00
|
|
|
{
|
|
|
|
return PFN_PHYS(cma->base_pfn);
|
|
|
|
}
|
|
|
|
|
2015-04-15 06:47:04 +08:00
|
|
|
unsigned long cma_get_size(const struct cma *cma)
|
2014-08-07 07:05:25 +08:00
|
|
|
{
|
|
|
|
return cma->count << PAGE_SHIFT;
|
|
|
|
}
|
|
|
|
|
2017-04-19 02:27:03 +08:00
|
|
|
const char *cma_get_name(const struct cma *cma)
|
|
|
|
{
|
2020-08-12 09:31:57 +08:00
|
|
|
return cma->name;
|
2017-04-19 02:27:03 +08:00
|
|
|
}
|
|
|
|
|
2015-04-15 06:47:04 +08:00
|
|
|
static unsigned long cma_bitmap_aligned_mask(const struct cma *cma,
|
cma: fix calculation of aligned offset
The align_offset parameter is used by bitmap_find_next_zero_area_off()
to represent the offset of map's base from the previous alignment
boundary; the function ensures that the returned index, plus the
align_offset, honors the specified align_mask.
The logic introduced by commit b5be83e308f7 ("mm: cma: align to physical
address, not CMA region position") has the cma driver calculate the
offset to the *next* alignment boundary. In most cases, the base
alignment is greater than that specified when making allocations,
resulting in a zero offset whether we align up or down. In the example
given with the commit, the base alignment (8MB) was half the requested
alignment (16MB) so the math also happened to work since the offset is
8MB in both directions. However, when requesting allocations with an
alignment greater than twice that of the base, the returned index would
not be correctly aligned.
Also, the align_order arguments of cma_bitmap_aligned_mask() and
cma_bitmap_aligned_offset() should not be negative so the argument type
was made unsigned.
Fixes: b5be83e308f7 ("mm: cma: align to physical address, not CMA region position")
Link: http://lkml.kernel.org/r/20170628170742.2895-1-opendmb@gmail.com
Signed-off-by: Angus Clark <angus@angusclark.org>
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Angus Clark <angus@angusclark.org>
Cc: Laura Abbott <labbott@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Shiraz Hashim <shashim@codeaurora.org>
Cc: Jaewon Kim <jaewon31.kim@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2017-07-11 06:49:44 +08:00
|
|
|
unsigned int align_order)
|
2014-08-07 07:05:25 +08:00
|
|
|
{
|
2014-10-14 06:51:03 +08:00
|
|
|
if (align_order <= cma->order_per_bit)
|
|
|
|
return 0;
|
|
|
|
return (1UL << (align_order - cma->order_per_bit)) - 1;
|
2014-08-07 07:05:25 +08:00
|
|
|
}
|
|
|
|
|
2015-03-13 07:25:57 +08:00
|
|
|
/*
|
cma: fix calculation of aligned offset
The align_offset parameter is used by bitmap_find_next_zero_area_off()
to represent the offset of map's base from the previous alignment
boundary; the function ensures that the returned index, plus the
align_offset, honors the specified align_mask.
The logic introduced by commit b5be83e308f7 ("mm: cma: align to physical
address, not CMA region position") has the cma driver calculate the
offset to the *next* alignment boundary. In most cases, the base
alignment is greater than that specified when making allocations,
resulting in a zero offset whether we align up or down. In the example
given with the commit, the base alignment (8MB) was half the requested
alignment (16MB) so the math also happened to work since the offset is
8MB in both directions. However, when requesting allocations with an
alignment greater than twice that of the base, the returned index would
not be correctly aligned.
Also, the align_order arguments of cma_bitmap_aligned_mask() and
cma_bitmap_aligned_offset() should not be negative so the argument type
was made unsigned.
Fixes: b5be83e308f7 ("mm: cma: align to physical address, not CMA region position")
Link: http://lkml.kernel.org/r/20170628170742.2895-1-opendmb@gmail.com
Signed-off-by: Angus Clark <angus@angusclark.org>
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Angus Clark <angus@angusclark.org>
Cc: Laura Abbott <labbott@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Shiraz Hashim <shashim@codeaurora.org>
Cc: Jaewon Kim <jaewon31.kim@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2017-07-11 06:49:44 +08:00
|
|
|
* Find the offset of the base PFN from the specified align_order.
|
|
|
|
* The value returned is represented in order_per_bits.
|
2015-03-13 07:25:57 +08:00
|
|
|
*/
|
2015-04-15 06:47:04 +08:00
|
|
|
static unsigned long cma_bitmap_aligned_offset(const struct cma *cma,
|
cma: fix calculation of aligned offset
The align_offset parameter is used by bitmap_find_next_zero_area_off()
to represent the offset of map's base from the previous alignment
boundary; the function ensures that the returned index, plus the
align_offset, honors the specified align_mask.
The logic introduced by commit b5be83e308f7 ("mm: cma: align to physical
address, not CMA region position") has the cma driver calculate the
offset to the *next* alignment boundary. In most cases, the base
alignment is greater than that specified when making allocations,
resulting in a zero offset whether we align up or down. In the example
given with the commit, the base alignment (8MB) was half the requested
alignment (16MB) so the math also happened to work since the offset is
8MB in both directions. However, when requesting allocations with an
alignment greater than twice that of the base, the returned index would
not be correctly aligned.
Also, the align_order arguments of cma_bitmap_aligned_mask() and
cma_bitmap_aligned_offset() should not be negative so the argument type
was made unsigned.
Fixes: b5be83e308f7 ("mm: cma: align to physical address, not CMA region position")
Link: http://lkml.kernel.org/r/20170628170742.2895-1-opendmb@gmail.com
Signed-off-by: Angus Clark <angus@angusclark.org>
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Angus Clark <angus@angusclark.org>
Cc: Laura Abbott <labbott@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Shiraz Hashim <shashim@codeaurora.org>
Cc: Jaewon Kim <jaewon31.kim@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2017-07-11 06:49:44 +08:00
|
|
|
unsigned int align_order)
|
2014-12-13 08:54:48 +08:00
|
|
|
{
|
cma: fix calculation of aligned offset
The align_offset parameter is used by bitmap_find_next_zero_area_off()
to represent the offset of map's base from the previous alignment
boundary; the function ensures that the returned index, plus the
align_offset, honors the specified align_mask.
The logic introduced by commit b5be83e308f7 ("mm: cma: align to physical
address, not CMA region position") has the cma driver calculate the
offset to the *next* alignment boundary. In most cases, the base
alignment is greater than that specified when making allocations,
resulting in a zero offset whether we align up or down. In the example
given with the commit, the base alignment (8MB) was half the requested
alignment (16MB) so the math also happened to work since the offset is
8MB in both directions. However, when requesting allocations with an
alignment greater than twice that of the base, the returned index would
not be correctly aligned.
Also, the align_order arguments of cma_bitmap_aligned_mask() and
cma_bitmap_aligned_offset() should not be negative so the argument type
was made unsigned.
Fixes: b5be83e308f7 ("mm: cma: align to physical address, not CMA region position")
Link: http://lkml.kernel.org/r/20170628170742.2895-1-opendmb@gmail.com
Signed-off-by: Angus Clark <angus@angusclark.org>
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Angus Clark <angus@angusclark.org>
Cc: Laura Abbott <labbott@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Shiraz Hashim <shashim@codeaurora.org>
Cc: Jaewon Kim <jaewon31.kim@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2017-07-11 06:49:44 +08:00
|
|
|
return (cma->base_pfn & ((1UL << align_order) - 1))
|
|
|
|
>> cma->order_per_bit;
|
2014-12-13 08:54:48 +08:00
|
|
|
}
|
|
|
|
|
2015-04-15 06:47:04 +08:00
|
|
|
static unsigned long cma_bitmap_pages_to_bits(const struct cma *cma,
|
|
|
|
unsigned long pages)
|
2014-08-07 07:05:25 +08:00
|
|
|
{
|
|
|
|
return ALIGN(pages, 1UL << cma->order_per_bit) >> cma->order_per_bit;
|
|
|
|
}
|
|
|
|
|
2015-04-15 06:47:04 +08:00
|
|
|
static void cma_clear_bitmap(struct cma *cma, unsigned long pfn,
|
2021-05-05 09:37:34 +08:00
|
|
|
unsigned long count)
|
2014-08-07 07:05:25 +08:00
|
|
|
{
|
|
|
|
unsigned long bitmap_no, bitmap_count;
|
2021-05-05 09:34:44 +08:00
|
|
|
unsigned long flags;
|
2014-08-07 07:05:25 +08:00
|
|
|
|
|
|
|
bitmap_no = (pfn - cma->base_pfn) >> cma->order_per_bit;
|
|
|
|
bitmap_count = cma_bitmap_pages_to_bits(cma, count);
|
|
|
|
|
2021-05-05 09:34:44 +08:00
|
|
|
spin_lock_irqsave(&cma->lock, flags);
|
2014-08-07 07:05:25 +08:00
|
|
|
bitmap_clear(cma->bitmap, bitmap_no, bitmap_count);
|
2021-05-05 09:34:44 +08:00
|
|
|
spin_unlock_irqrestore(&cma->lock, flags);
|
2014-08-07 07:05:25 +08:00
|
|
|
}
|
|
|
|
|
2020-08-12 09:32:03 +08:00
|
|
|
static void __init cma_activate_area(struct cma *cma)
|
2014-08-07 07:05:25 +08:00
|
|
|
{
|
2021-02-26 09:16:37 +08:00
|
|
|
unsigned long base_pfn = cma->base_pfn, pfn;
|
2014-08-07 07:05:25 +08:00
|
|
|
struct zone *zone;
|
|
|
|
|
2019-12-01 09:57:22 +08:00
|
|
|
cma->bitmap = bitmap_zalloc(cma_bitmap_maxno(cma), GFP_KERNEL);
|
2020-08-12 09:32:03 +08:00
|
|
|
if (!cma->bitmap)
|
|
|
|
goto out_error;
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2021-02-26 09:16:37 +08:00
|
|
|
/*
|
|
|
|
* alloc_contig_range() requires the pfn range specified to be in the
|
|
|
|
* same zone. Simplify by forcing the entire CMA resv range to be in the
|
|
|
|
* same zone.
|
|
|
|
*/
|
|
|
|
WARN_ON_ONCE(!pfn_valid(base_pfn));
|
|
|
|
zone = page_zone(pfn_to_page(base_pfn));
|
|
|
|
for (pfn = base_pfn + 1; pfn < base_pfn + cma->count; pfn++) {
|
|
|
|
WARN_ON_ONCE(!pfn_valid(pfn));
|
|
|
|
if (page_zone(pfn_to_page(pfn)) != zone)
|
|
|
|
goto not_in_zone;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (pfn = base_pfn; pfn < base_pfn + cma->count;
|
|
|
|
pfn += pageblock_nr_pages)
|
|
|
|
init_cma_reserved_pageblock(pfn_to_page(pfn));
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2021-05-05 09:34:44 +08:00
|
|
|
spin_lock_init(&cma->lock);
|
2015-04-15 06:44:59 +08:00
|
|
|
|
|
|
|
#ifdef CONFIG_CMA_DEBUGFS
|
|
|
|
INIT_HLIST_HEAD(&cma->mem_head);
|
|
|
|
spin_lock_init(&cma->mem_head_lock);
|
|
|
|
#endif
|
|
|
|
|
2020-08-12 09:32:03 +08:00
|
|
|
return;
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2018-05-23 09:18:21 +08:00
|
|
|
not_in_zone:
|
2019-12-01 09:57:22 +08:00
|
|
|
bitmap_free(cma->bitmap);
|
2020-08-12 09:32:03 +08:00
|
|
|
out_error:
|
2021-02-26 09:16:37 +08:00
|
|
|
/* Expose all pages to the buddy, they are useless for CMA. */
|
2022-03-23 05:46:14 +08:00
|
|
|
if (!cma->reserve_pages_on_error) {
|
|
|
|
for (pfn = base_pfn; pfn < base_pfn + cma->count; pfn++)
|
|
|
|
free_reserved_page(pfn_to_page(pfn));
|
|
|
|
}
|
2021-02-26 09:16:37 +08:00
|
|
|
totalcma_pages -= cma->count;
|
2014-10-24 18:18:39 +08:00
|
|
|
cma->count = 0;
|
2020-08-12 09:32:03 +08:00
|
|
|
pr_err("CMA area %s could not be activated\n", cma->name);
|
|
|
|
return;
|
2014-08-07 07:05:25 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int __init cma_init_reserved_areas(void)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2020-08-12 09:32:03 +08:00
|
|
|
for (i = 0; i < cma_area_count; i++)
|
|
|
|
cma_activate_area(&cma_areas[i]);
|
2014-08-07 07:05:25 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2018-05-23 09:18:21 +08:00
|
|
|
core_initcall(cma_init_reserved_areas);
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2022-03-23 05:46:14 +08:00
|
|
|
void __init cma_reserve_pages_on_error(struct cma *cma)
|
|
|
|
{
|
|
|
|
cma->reserve_pages_on_error = true;
|
|
|
|
}
|
|
|
|
|
2014-10-14 06:51:09 +08:00
|
|
|
/**
|
|
|
|
* cma_init_reserved_mem() - create custom contiguous area from reserved memory
|
|
|
|
* @base: Base address of the reserved area
|
|
|
|
* @size: Size of the reserved area (in bytes),
|
|
|
|
* @order_per_bit: Order of pages represented by one bit on bitmap.
|
2018-04-06 07:24:57 +08:00
|
|
|
* @name: The name of the area. If this parameter is NULL, the name of
|
|
|
|
* the area will be set to "cmaN", where N is a running counter of
|
|
|
|
* used areas.
|
2014-10-14 06:51:09 +08:00
|
|
|
* @res_cma: Pointer to store the created cma region.
|
|
|
|
*
|
|
|
|
* This function creates custom contiguous area from already reserved memory.
|
|
|
|
*/
|
|
|
|
int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size,
|
2015-04-15 06:47:04 +08:00
|
|
|
unsigned int order_per_bit,
|
2017-04-19 02:27:03 +08:00
|
|
|
const char *name,
|
2015-04-15 06:47:04 +08:00
|
|
|
struct cma **res_cma)
|
2014-10-14 06:51:09 +08:00
|
|
|
{
|
|
|
|
struct cma *cma;
|
|
|
|
|
|
|
|
/* Sanity checks */
|
|
|
|
if (cma_area_count == ARRAY_SIZE(cma_areas)) {
|
|
|
|
pr_err("Not enough slots for CMA reserved regions!\n");
|
|
|
|
return -ENOSPC;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!size || !memblock_is_region_reserved(base, size))
|
|
|
|
return -EINVAL;
|
|
|
|
|
2022-03-23 05:43:17 +08:00
|
|
|
/* ensure minimal alignment required by mm core */
|
|
|
|
if (!IS_ALIGNED(base | size, CMA_MIN_ALIGNMENT_BYTES))
|
2014-10-14 06:51:09 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Each reserved area must be initialised later, when more kernel
|
|
|
|
* subsystems (like slab allocator) are available.
|
|
|
|
*/
|
|
|
|
cma = &cma_areas[cma_area_count];
|
2020-08-12 09:31:57 +08:00
|
|
|
|
|
|
|
if (name)
|
|
|
|
snprintf(cma->name, CMA_MAX_NAME, name);
|
|
|
|
else
|
|
|
|
snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count);
|
|
|
|
|
2014-10-14 06:51:09 +08:00
|
|
|
cma->base_pfn = PFN_DOWN(base);
|
|
|
|
cma->count = size >> PAGE_SHIFT;
|
|
|
|
cma->order_per_bit = order_per_bit;
|
|
|
|
*res_cma = cma;
|
|
|
|
cma_area_count++;
|
2015-02-12 07:26:27 +08:00
|
|
|
totalcma_pages += (size / PAGE_SIZE);
|
2014-10-14 06:51:09 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
/**
|
2020-04-11 05:32:42 +08:00
|
|
|
* cma_declare_contiguous_nid() - reserve custom contiguous area
|
2014-08-07 07:05:25 +08:00
|
|
|
* @base: Base address of the reserved area optional, use 0 for any
|
2014-08-07 07:05:32 +08:00
|
|
|
* @size: Size of the reserved area (in bytes),
|
2014-08-07 07:05:25 +08:00
|
|
|
* @limit: End address of the reserved memory (optional, 0 for any).
|
|
|
|
* @alignment: Alignment for the CMA area, should be power of 2 or zero
|
|
|
|
* @order_per_bit: Order of pages represented by one bit on bitmap.
|
|
|
|
* @fixed: hint about where to place the reserved area
|
2018-04-06 07:24:57 +08:00
|
|
|
* @name: The name of the area. See function cma_init_reserved_mem()
|
2014-08-07 07:05:32 +08:00
|
|
|
* @res_cma: Pointer to store the created cma region.
|
2020-04-11 05:32:42 +08:00
|
|
|
* @nid: nid of the free area to find, %NUMA_NO_NODE for any node
|
2014-08-07 07:05:25 +08:00
|
|
|
*
|
|
|
|
* This function reserves memory from early allocator. It should be
|
|
|
|
* called by arch specific code once the early allocator (memblock or bootmem)
|
|
|
|
* has been activated and all other subsystems have already allocated/reserved
|
|
|
|
* memory. This function allows to create custom reserved areas.
|
|
|
|
*
|
|
|
|
* If @fixed is true, reserve contiguous area at exactly @base. If false,
|
|
|
|
* reserve in range from @base to @limit.
|
|
|
|
*/
|
2020-04-11 05:32:42 +08:00
|
|
|
int __init cma_declare_contiguous_nid(phys_addr_t base,
|
2014-08-07 07:05:32 +08:00
|
|
|
phys_addr_t size, phys_addr_t limit,
|
2014-08-07 07:05:25 +08:00
|
|
|
phys_addr_t alignment, unsigned int order_per_bit,
|
2020-04-11 05:32:42 +08:00
|
|
|
bool fixed, const char *name, struct cma **res_cma,
|
|
|
|
int nid)
|
2014-08-07 07:05:25 +08:00
|
|
|
{
|
2014-10-10 06:26:47 +08:00
|
|
|
phys_addr_t memblock_end = memblock_end_of_DRAM();
|
2014-12-11 07:41:12 +08:00
|
|
|
phys_addr_t highmem_start;
|
2023-12-05 10:17:51 +08:00
|
|
|
int ret;
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2014-12-11 07:41:12 +08:00
|
|
|
/*
|
2017-01-11 05:35:41 +08:00
|
|
|
* We can't use __pa(high_memory) directly, since high_memory
|
|
|
|
* isn't a valid direct map VA, and DEBUG_VIRTUAL will (validly)
|
|
|
|
* complain. Find the boundary by adding one to the last valid
|
|
|
|
* address.
|
2014-12-11 07:41:12 +08:00
|
|
|
*/
|
2017-01-11 05:35:41 +08:00
|
|
|
highmem_start = __pa(high_memory - 1) + 1;
|
2014-10-24 18:18:42 +08:00
|
|
|
pr_debug("%s(size %pa, base %pa, limit %pa alignment %pa)\n",
|
|
|
|
__func__, &size, &base, &limit, &alignment);
|
2014-08-07 07:05:25 +08:00
|
|
|
|
|
|
|
if (cma_area_count == ARRAY_SIZE(cma_areas)) {
|
|
|
|
pr_err("Not enough slots for CMA reserved regions!\n");
|
|
|
|
return -ENOSPC;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!size)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (alignment && !is_power_of_2(alignment))
|
|
|
|
return -EINVAL;
|
|
|
|
|
2023-07-12 15:47:58 +08:00
|
|
|
if (!IS_ENABLED(CONFIG_NUMA))
|
|
|
|
nid = NUMA_NO_NODE;
|
|
|
|
|
2022-03-23 05:43:17 +08:00
|
|
|
/* Sanitise input arguments. */
|
|
|
|
alignment = max_t(phys_addr_t, alignment, CMA_MIN_ALIGNMENT_BYTES);
|
2019-07-17 07:26:24 +08:00
|
|
|
if (fixed && base & (alignment - 1)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
pr_err("Region at %pa must be aligned to %pa bytes\n",
|
|
|
|
&base, &alignment);
|
|
|
|
goto err;
|
|
|
|
}
|
2014-08-07 07:05:25 +08:00
|
|
|
base = ALIGN(base, alignment);
|
|
|
|
size = ALIGN(size, alignment);
|
|
|
|
limit &= ~(alignment - 1);
|
|
|
|
|
2014-10-24 18:18:40 +08:00
|
|
|
if (!base)
|
|
|
|
fixed = false;
|
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
/* size should be aligned with order_per_bit */
|
|
|
|
if (!IS_ALIGNED(size >> PAGE_SHIFT, 1 << order_per_bit))
|
|
|
|
return -EINVAL;
|
|
|
|
|
2014-10-10 06:26:47 +08:00
|
|
|
/*
|
2014-10-24 18:18:41 +08:00
|
|
|
* If allocating at a fixed base the request region must not cross the
|
|
|
|
* low/high memory boundary.
|
2014-10-10 06:26:47 +08:00
|
|
|
*/
|
2014-10-24 18:18:41 +08:00
|
|
|
if (fixed && base < highmem_start && base + size > highmem_start) {
|
2014-10-10 06:26:47 +08:00
|
|
|
ret = -EINVAL;
|
2014-10-24 18:18:42 +08:00
|
|
|
pr_err("Region at %pa defined on low/high memory boundary (%pa)\n",
|
|
|
|
&base, &highmem_start);
|
2014-10-10 06:26:47 +08:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2014-10-24 18:18:41 +08:00
|
|
|
/*
|
|
|
|
* If the limit is unspecified or above the memblock end, its effective
|
|
|
|
* value will be the memblock end. Set it explicitly to simplify further
|
|
|
|
* checks.
|
|
|
|
*/
|
|
|
|
if (limit == 0 || limit > memblock_end)
|
|
|
|
limit = memblock_end;
|
|
|
|
|
2019-07-17 07:26:24 +08:00
|
|
|
if (base + size > limit) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
pr_err("Size (%pa) of region at %pa exceeds limit (%pa)\n",
|
|
|
|
&size, &base, &limit);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
/* Reserve memory */
|
2014-10-24 18:18:40 +08:00
|
|
|
if (fixed) {
|
2014-08-07 07:05:25 +08:00
|
|
|
if (memblock_is_region_reserved(base, size) ||
|
|
|
|
memblock_reserve(base, size) < 0) {
|
|
|
|
ret = -EBUSY;
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
} else {
|
2014-10-24 18:18:41 +08:00
|
|
|
phys_addr_t addr = 0;
|
|
|
|
|
mm: cma: allocate cma areas bottom-up
Currently cma areas without a fixed base are allocated close to the end of
the node. This placement is sub-optimal because of compaction: it brings
pages into the cma area. In particular, it can bring in hot executable
pages, even if there is a plenty of free memory on the machine. This
results in cma allocation failures.
Instead let's place cma areas close to the beginning of a node. In this
case the compaction will help to free cma areas, resulting in better cma
allocation success rates.
If there is enough memory let's try to allocate bottom-up starting with
4GB to exclude any possible interference with DMA32. On smaller machines
or in a case of a failure, stick with the old behavior.
16GB vm, 2GB cma area:
With this patch:
[ 0.000000] Command line: root=/dev/vda3 rootflags=subvol=/root systemd.unified_cgroup_hierarchy=1 enforcing=0 console=ttyS0,115200 hugetlb_cma=2G
[ 0.002928] hugetlb_cma: reserve 2048 MiB, up to 2048 MiB per node
[ 0.002930] cma: Reserved 2048 MiB at 0x0000000100000000
[ 0.002931] hugetlb_cma: reserved 2048 MiB on node 0
Without this patch:
[ 0.000000] Command line: root=/dev/vda3 rootflags=subvol=/root systemd.unified_cgroup_hierarchy=1 enforcing=0 console=ttyS0,115200 hugetlb_cma=2G
[ 0.002930] hugetlb_cma: reserve 2048 MiB, up to 2048 MiB per node
[ 0.002933] cma: Reserved 2048 MiB at 0x00000003c0000000
[ 0.002934] hugetlb_cma: reserved 2048 MiB on node 0
v2:
- switched to memblock_set_bottom_up(true), by Mike
- start with 4GB, by Mike
[guro@fb.com: whitespace fix, per Mike]
Link: https://lkml.kernel.org/r/20201221170551.GB3428478@carbon.DHCP.thefacebook.com
[guro@fb.com: fix 32-bit warnings]
Link: https://lkml.kernel.org/r/20201223163537.GA4011967@carbon.DHCP.thefacebook.com
[guro@fb.com: fix 32-bit systems]
[akpm@linux-foundation.org: build fix]
Link: https://lkml.kernel.org/r/20201217201214.3414100-1-guro@fb.com
Signed-off-by: Roman Gushchin <guro@fb.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
Cc: Wonhyuk Yang <vvghjk1234@gmail.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Michal Hocko <mhocko@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2021-02-26 09:16:33 +08:00
|
|
|
/*
|
|
|
|
* If there is enough memory, try a bottom-up allocation first.
|
|
|
|
* It will place the new cma area close to the start of the node
|
|
|
|
* and guarantee that the compaction is moving pages out of the
|
|
|
|
* cma area and not into it.
|
|
|
|
* Avoid using first 4GB to not interfere with constrained zones
|
|
|
|
* like DMA/DMA32.
|
|
|
|
*/
|
|
|
|
#ifdef CONFIG_PHYS_ADDR_T_64BIT
|
|
|
|
if (!memblock_bottom_up() && memblock_end >= SZ_4G + size) {
|
|
|
|
memblock_set_bottom_up(true);
|
|
|
|
addr = memblock_alloc_range_nid(size, alignment, SZ_4G,
|
|
|
|
limit, nid, true);
|
|
|
|
memblock_set_bottom_up(false);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2023-01-18 16:05:23 +08:00
|
|
|
/*
|
|
|
|
* All pages in the reserved area must come from the same zone.
|
|
|
|
* If the requested region crosses the low/high memory boundary,
|
|
|
|
* try allocating from high memory first and fall back to low
|
|
|
|
* memory in case of failure.
|
|
|
|
*/
|
|
|
|
if (!addr && base < highmem_start && limit > highmem_start) {
|
|
|
|
addr = memblock_alloc_range_nid(size, alignment,
|
|
|
|
highmem_start, limit, nid, true);
|
|
|
|
limit = highmem_start;
|
|
|
|
}
|
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
if (!addr) {
|
2020-04-11 05:32:42 +08:00
|
|
|
addr = memblock_alloc_range_nid(size, alignment, base,
|
mm/cma.c: use exact_nid true to fix possible per-numa cma leak
Calling cma_declare_contiguous_nid() with false exact_nid for per-numa
reservation can easily cause cma leak and various confusion. For example,
mm/hugetlb.c is trying to reserve per-numa cma for gigantic pages. But it
can easily leak cma and make users confused when system has memoryless
nodes.
In case the system has 4 numa nodes, and only numa node0 has memory. if
we set hugetlb_cma=4G in bootargs, mm/hugetlb.c will get 4 cma areas for 4
different numa nodes. since exact_nid=false in current code, all 4 numa
nodes will get cma successfully from node0, but hugetlb_cma[1 to 3] will
never be available to hugepage will only allocate memory from
hugetlb_cma[0].
In case the system has 4 numa nodes, both numa node0&2 has memory, other
nodes have no memory. if we set hugetlb_cma=4G in bootargs, mm/hugetlb.c
will get 4 cma areas for 4 different numa nodes. since exact_nid=false in
current code, all 4 numa nodes will get cma successfully from node0 or 2,
but hugetlb_cma[1] and [3] will never be available to hugepage as
mm/hugetlb.c will only allocate memory from hugetlb_cma[0] and
hugetlb_cma[2]. This causes permanent leak of the cma areas which are
supposed to be used by memoryless node.
Of cource we can workaround the issue by letting mm/hugetlb.c scan all cma
areas in alloc_gigantic_page() even node_mask includes node0 only. that
means when node_mask includes node0 only, we can get page from
hugetlb_cma[1] to hugetlb_cma[3]. But this will cause kernel crash in
free_gigantic_page() while it wants to free page by:
cma_release(hugetlb_cma[page_to_nid(page)], page, 1 << order)
On the other hand, exact_nid=false won't consider numa distance, it might
be not that useful to leverage cma areas on remote nodes. I feel it is
much simpler to make exact_nid true to make everything clear. After that,
memoryless nodes won't be able to reserve per-numa CMA from other nodes
which have memory.
Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Roman Gushchin <guro@fb.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Aslan Bakirov <aslan@fb.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Andreas Schaufler <andreas.schaufler@gmx.de>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Joonsoo Kim <js1304@gmail.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/20200628074345.27228-1-song.bao.hua@hisilicon.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-07-04 06:15:24 +08:00
|
|
|
limit, nid, true);
|
2014-10-24 18:18:41 +08:00
|
|
|
if (!addr) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto err;
|
|
|
|
}
|
2014-08-07 07:05:25 +08:00
|
|
|
}
|
2014-10-24 18:18:41 +08:00
|
|
|
|
2014-12-13 08:58:31 +08:00
|
|
|
/*
|
|
|
|
* kmemleak scans/reads tracked objects for pointers to other
|
|
|
|
* objects but this address isn't mapped and accessible
|
|
|
|
*/
|
2016-10-12 04:55:11 +08:00
|
|
|
kmemleak_ignore_phys(addr);
|
2014-10-24 18:18:41 +08:00
|
|
|
base = addr;
|
2014-08-07 07:05:25 +08:00
|
|
|
}
|
|
|
|
|
2017-04-19 02:27:03 +08:00
|
|
|
ret = cma_init_reserved_mem(base, size, order_per_bit, name, res_cma);
|
2014-10-14 06:51:09 +08:00
|
|
|
if (ret)
|
2019-03-06 07:49:50 +08:00
|
|
|
goto free_mem;
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2023-07-12 15:47:58 +08:00
|
|
|
pr_info("Reserved %ld MiB at %pa on node %d\n", (unsigned long)size / SZ_1M,
|
|
|
|
&base, nid);
|
2014-08-07 07:05:25 +08:00
|
|
|
return 0;
|
|
|
|
|
2019-03-06 07:49:50 +08:00
|
|
|
free_mem:
|
2021-11-06 04:43:19 +08:00
|
|
|
memblock_phys_free(base, size);
|
2014-08-07 07:05:25 +08:00
|
|
|
err:
|
2023-07-12 15:47:58 +08:00
|
|
|
pr_err("Failed to reserve %ld MiB on node %d\n", (unsigned long)size / SZ_1M,
|
|
|
|
nid);
|
2014-08-07 07:05:25 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2017-02-25 06:58:50 +08:00
|
|
|
static void cma_debug_show_areas(struct cma *cma)
|
|
|
|
{
|
2019-05-14 08:17:41 +08:00
|
|
|
unsigned long next_zero_bit, next_set_bit, nr_zero;
|
2017-02-25 06:58:50 +08:00
|
|
|
unsigned long start = 0;
|
2019-05-14 08:17:41 +08:00
|
|
|
unsigned long nr_part, nr_total = 0;
|
|
|
|
unsigned long nbits = cma_bitmap_maxno(cma);
|
2017-02-25 06:58:50 +08:00
|
|
|
|
2021-05-05 09:34:44 +08:00
|
|
|
spin_lock_irq(&cma->lock);
|
2017-02-25 06:58:50 +08:00
|
|
|
pr_info("number of available pages: ");
|
|
|
|
for (;;) {
|
2019-05-14 08:17:41 +08:00
|
|
|
next_zero_bit = find_next_zero_bit(cma->bitmap, nbits, start);
|
|
|
|
if (next_zero_bit >= nbits)
|
2017-02-25 06:58:50 +08:00
|
|
|
break;
|
2019-05-14 08:17:41 +08:00
|
|
|
next_set_bit = find_next_bit(cma->bitmap, nbits, next_zero_bit);
|
2017-02-25 06:58:50 +08:00
|
|
|
nr_zero = next_set_bit - next_zero_bit;
|
2019-05-14 08:17:41 +08:00
|
|
|
nr_part = nr_zero << cma->order_per_bit;
|
|
|
|
pr_cont("%s%lu@%lu", nr_total ? "+" : "", nr_part,
|
|
|
|
next_zero_bit);
|
|
|
|
nr_total += nr_part;
|
2017-02-25 06:58:50 +08:00
|
|
|
start = next_zero_bit + nr_zero;
|
|
|
|
}
|
2019-05-14 08:17:41 +08:00
|
|
|
pr_cont("=> %lu free of %lu total pages\n", nr_total, cma->count);
|
2021-05-05 09:34:44 +08:00
|
|
|
spin_unlock_irq(&cma->lock);
|
2017-02-25 06:58:50 +08:00
|
|
|
}
|
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
/**
|
|
|
|
* cma_alloc() - allocate pages from contiguous area
|
|
|
|
* @cma: Contiguous memory region for which the allocation is performed.
|
|
|
|
* @count: Requested number of pages.
|
|
|
|
* @align: Requested alignment of pages (in PAGE_SIZE order).
|
2018-08-18 06:48:57 +08:00
|
|
|
* @no_warn: Avoid printing message about failed allocation
|
2014-08-07 07:05:25 +08:00
|
|
|
*
|
|
|
|
* This function allocates part of contiguous memory on specific
|
|
|
|
* contiguous memory area.
|
|
|
|
*/
|
2021-05-05 09:37:34 +08:00
|
|
|
struct page *cma_alloc(struct cma *cma, unsigned long count,
|
|
|
|
unsigned int align, bool no_warn)
|
2014-08-07 07:05:25 +08:00
|
|
|
{
|
2015-11-06 10:50:08 +08:00
|
|
|
unsigned long mask, offset;
|
|
|
|
unsigned long pfn = -1;
|
|
|
|
unsigned long start = 0;
|
2014-08-07 07:05:25 +08:00
|
|
|
unsigned long bitmap_maxno, bitmap_no, bitmap_count;
|
2021-05-05 09:37:34 +08:00
|
|
|
unsigned long i;
|
2014-08-07 07:05:25 +08:00
|
|
|
struct page *page = NULL;
|
2017-02-25 06:58:50 +08:00
|
|
|
int ret = -ENOMEM;
|
2024-01-10 09:22:33 +08:00
|
|
|
const char *name = cma ? cma->name : NULL;
|
|
|
|
|
|
|
|
trace_cma_alloc_start(name, count, align);
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2020-08-12 09:31:54 +08:00
|
|
|
if (!cma || !cma->count || !cma->bitmap)
|
2024-02-01 10:37:14 +08:00
|
|
|
return page;
|
2014-08-07 07:05:25 +08:00
|
|
|
|
2023-07-07 02:33:34 +08:00
|
|
|
pr_debug("%s(cma %p, name: %s, count %lu, align %d)\n", __func__,
|
|
|
|
(void *)cma, cma->name, count, align);
|
2014-08-07 07:05:25 +08:00
|
|
|
|
|
|
|
if (!count)
|
2024-02-01 10:37:14 +08:00
|
|
|
return page;
|
2014-08-07 07:05:25 +08:00
|
|
|
|
|
|
|
mask = cma_bitmap_aligned_mask(cma, align);
|
2014-12-13 08:54:48 +08:00
|
|
|
offset = cma_bitmap_aligned_offset(cma, align);
|
2014-08-07 07:05:25 +08:00
|
|
|
bitmap_maxno = cma_bitmap_maxno(cma);
|
|
|
|
bitmap_count = cma_bitmap_pages_to_bits(cma, count);
|
|
|
|
|
2016-11-11 02:46:16 +08:00
|
|
|
if (bitmap_count > bitmap_maxno)
|
2024-02-01 10:37:14 +08:00
|
|
|
return page;
|
2016-11-11 02:46:16 +08:00
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
for (;;) {
|
2021-05-05 09:34:44 +08:00
|
|
|
spin_lock_irq(&cma->lock);
|
2014-12-13 08:54:48 +08:00
|
|
|
bitmap_no = bitmap_find_next_zero_area_off(cma->bitmap,
|
|
|
|
bitmap_maxno, start, bitmap_count, mask,
|
|
|
|
offset);
|
2014-08-07 07:05:25 +08:00
|
|
|
if (bitmap_no >= bitmap_maxno) {
|
2021-05-05 09:34:44 +08:00
|
|
|
spin_unlock_irq(&cma->lock);
|
2014-08-07 07:05:25 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
bitmap_set(cma->bitmap, bitmap_no, bitmap_count);
|
|
|
|
/*
|
|
|
|
* It's safe to drop the lock here. We've marked this region for
|
|
|
|
* our exclusive use. If the migration fails we will take the
|
|
|
|
* lock again and unmark it.
|
|
|
|
*/
|
2021-05-05 09:34:44 +08:00
|
|
|
spin_unlock_irq(&cma->lock);
|
2014-08-07 07:05:25 +08:00
|
|
|
|
|
|
|
pfn = cma->base_pfn + (bitmap_no << cma->order_per_bit);
|
Revert "mm/cma.c: remove redundant cma_mutex lock"
This reverts commit a4efc174b382fcdb which introduced a regression issue
that when there're multiple processes allocating dma memory in parallel by
calling dma_alloc_coherent(), it may fail sometimes as follows:
Error log:
cma: cma_alloc: linux,cma: alloc failed, req-size: 148 pages, ret: -16
cma: number of available pages:
3@125+20@172+12@236+4@380+32@736+17@2287+23@2473+20@36076+99@40477+108@40852+44@41108+20@41196+108@41364+108@41620+
108@42900+108@43156+483@44061+1763@45341+1440@47712+20@49324+20@49388+5076@49452+2304@55040+35@58141+20@58220+20@58284+
7188@58348+84@66220+7276@66452+227@74525+6371@75549=> 33161 free of 81920 total pages
When issue happened, we saw there were still 33161 pages (129M) free CMA
memory and a lot available free slots for 148 pages in CMA bitmap that we
want to allocate.
When dumping memory info, we found that there was also ~342M normal
memory, but only 1352K CMA memory left in buddy system while a lot of
pageblocks were isolated.
Memory info log:
Normal free:351096kB min:30000kB low:37500kB high:45000kB reserved_highatomic:0KB
active_anon:98060kB inactive_anon:98948kB active_file:60864kB inactive_file:31776kB
unevictable:0kB writepending:0kB present:1048576kB managed:1018328kB mlocked:0kB
bounce:0kB free_pcp:220kB local_pcp:192kB free_cma:1352kB lowmem_reserve[]: 0 0 0
Normal: 78*4kB (UECI) 1772*8kB (UMECI) 1335*16kB (UMECI) 360*32kB (UMECI) 65*64kB (UMCI)
36*128kB (UMECI) 16*256kB (UMCI) 6*512kB (EI) 8*1024kB (UEI) 4*2048kB (MI) 8*4096kB (EI)
8*8192kB (UI) 3*16384kB (EI) 8*32768kB (M) = 489288kB
The root cause of this issue is that since commit a4efc174b382 ("mm/cma.c:
remove redundant cma_mutex lock"), CMA supports concurrent memory
allocation. It's possible that the memory range process A trying to alloc
has already been isolated by the allocation of process B during memory
migration.
The problem here is that the memory range isolated during one allocation
by start_isolate_page_range() could be much bigger than the real size we
want to alloc due to the range is aligned to MAX_ORDER_NR_PAGES.
Taking an ARMv7 platform with 1G memory as an example, when
MAX_ORDER_NR_PAGES is big (e.g. 32M with max_order 14) and CMA memory is
relatively small (e.g. 128M), there're only 4 MAX_ORDER slot, then it's
very easy that all CMA memory may have already been isolated by other
processes when one trying to allocate memory using dma_alloc_coherent().
Since current CMA code will only scan one time of whole available CMA
memory, then dma_alloc_coherent() may easy fail due to contention with
other processes.
This patch simply falls back to the original method that using cma_mutex
to make alloc_contig_range() run sequentially to avoid the issue.
Link: https://lkml.kernel.org/r/20220509094551.3596244-1-aisheng.dong@nxp.com
Link: https://lore.kernel.org/all/20220315144521.3810298-2-aisheng.dong@nxp.com/
Fixes: a4efc174b382 ("mm/cma.c: remove redundant cma_mutex lock")
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: <stable@vger.kernel.org> [5.11+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2022-05-14 06:11:26 +08:00
|
|
|
mutex_lock(&cma_mutex);
|
2017-02-25 06:58:37 +08:00
|
|
|
ret = alloc_contig_range(pfn, pfn + count, MIGRATE_CMA,
|
2018-08-18 06:48:57 +08:00
|
|
|
GFP_KERNEL | (no_warn ? __GFP_NOWARN : 0));
|
Revert "mm/cma.c: remove redundant cma_mutex lock"
This reverts commit a4efc174b382fcdb which introduced a regression issue
that when there're multiple processes allocating dma memory in parallel by
calling dma_alloc_coherent(), it may fail sometimes as follows:
Error log:
cma: cma_alloc: linux,cma: alloc failed, req-size: 148 pages, ret: -16
cma: number of available pages:
3@125+20@172+12@236+4@380+32@736+17@2287+23@2473+20@36076+99@40477+108@40852+44@41108+20@41196+108@41364+108@41620+
108@42900+108@43156+483@44061+1763@45341+1440@47712+20@49324+20@49388+5076@49452+2304@55040+35@58141+20@58220+20@58284+
7188@58348+84@66220+7276@66452+227@74525+6371@75549=> 33161 free of 81920 total pages
When issue happened, we saw there were still 33161 pages (129M) free CMA
memory and a lot available free slots for 148 pages in CMA bitmap that we
want to allocate.
When dumping memory info, we found that there was also ~342M normal
memory, but only 1352K CMA memory left in buddy system while a lot of
pageblocks were isolated.
Memory info log:
Normal free:351096kB min:30000kB low:37500kB high:45000kB reserved_highatomic:0KB
active_anon:98060kB inactive_anon:98948kB active_file:60864kB inactive_file:31776kB
unevictable:0kB writepending:0kB present:1048576kB managed:1018328kB mlocked:0kB
bounce:0kB free_pcp:220kB local_pcp:192kB free_cma:1352kB lowmem_reserve[]: 0 0 0
Normal: 78*4kB (UECI) 1772*8kB (UMECI) 1335*16kB (UMECI) 360*32kB (UMECI) 65*64kB (UMCI)
36*128kB (UMECI) 16*256kB (UMCI) 6*512kB (EI) 8*1024kB (UEI) 4*2048kB (MI) 8*4096kB (EI)
8*8192kB (UI) 3*16384kB (EI) 8*32768kB (M) = 489288kB
The root cause of this issue is that since commit a4efc174b382 ("mm/cma.c:
remove redundant cma_mutex lock"), CMA supports concurrent memory
allocation. It's possible that the memory range process A trying to alloc
has already been isolated by the allocation of process B during memory
migration.
The problem here is that the memory range isolated during one allocation
by start_isolate_page_range() could be much bigger than the real size we
want to alloc due to the range is aligned to MAX_ORDER_NR_PAGES.
Taking an ARMv7 platform with 1G memory as an example, when
MAX_ORDER_NR_PAGES is big (e.g. 32M with max_order 14) and CMA memory is
relatively small (e.g. 128M), there're only 4 MAX_ORDER slot, then it's
very easy that all CMA memory may have already been isolated by other
processes when one trying to allocate memory using dma_alloc_coherent().
Since current CMA code will only scan one time of whole available CMA
memory, then dma_alloc_coherent() may easy fail due to contention with
other processes.
This patch simply falls back to the original method that using cma_mutex
to make alloc_contig_range() run sequentially to avoid the issue.
Link: https://lkml.kernel.org/r/20220509094551.3596244-1-aisheng.dong@nxp.com
Link: https://lore.kernel.org/all/20220315144521.3810298-2-aisheng.dong@nxp.com/
Fixes: a4efc174b382 ("mm/cma.c: remove redundant cma_mutex lock")
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: <stable@vger.kernel.org> [5.11+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2022-05-14 06:11:26 +08:00
|
|
|
mutex_unlock(&cma_mutex);
|
2014-08-07 07:05:25 +08:00
|
|
|
if (ret == 0) {
|
|
|
|
page = pfn_to_page(pfn);
|
|
|
|
break;
|
|
|
|
}
|
2014-08-07 07:05:30 +08:00
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
cma_clear_bitmap(cma, pfn, count);
|
2014-08-07 07:05:30 +08:00
|
|
|
if (ret != -EBUSY)
|
|
|
|
break;
|
|
|
|
|
2023-06-13 17:25:33 +08:00
|
|
|
pr_debug("%s(): memory range at pfn 0x%lx %p is busy, retrying\n",
|
|
|
|
__func__, pfn, pfn_to_page(pfn));
|
2021-05-05 09:37:25 +08:00
|
|
|
|
2021-05-05 09:37:31 +08:00
|
|
|
trace_cma_alloc_busy_retry(cma->name, pfn, pfn_to_page(pfn),
|
|
|
|
count, align);
|
2014-08-07 07:05:25 +08:00
|
|
|
/* try again with a bit different memory target */
|
|
|
|
start = bitmap_no + mask + 1;
|
|
|
|
}
|
|
|
|
|
2018-12-28 16:30:57 +08:00
|
|
|
/*
|
|
|
|
* CMA can allocate multiple page blocks, which results in different
|
|
|
|
* blocks being marked with different tags. Reset the tags to ignore
|
|
|
|
* those page blocks.
|
|
|
|
*/
|
|
|
|
if (page) {
|
|
|
|
for (i = 0; i < count; i++)
|
mm/cma: use nth_page() in place of direct struct page manipulation
Patch series "Use nth_page() in place of direct struct page manipulation",
v3.
On SPARSEMEM without VMEMMAP, struct page is not guaranteed to be
contiguous, since each memory section's memmap might be allocated
independently. hugetlb pages can go beyond a memory section size, thus
direct struct page manipulation on hugetlb pages/subpages might give wrong
struct page. Kernel provides nth_page() to do the manipulation properly.
Use that whenever code can see hugetlb pages.
This patch (of 5):
When dealing with hugetlb pages, manipulating struct page pointers
directly can get to wrong struct page, since struct page is not guaranteed
to be contiguous on SPARSEMEM without VMEMMAP. Use nth_page() to handle
it properly.
Without the fix, page_kasan_tag_reset() could reset wrong page tags,
causing a wrong kasan result. No related bug is reported. The fix
comes from code inspection.
Link: https://lkml.kernel.org/r/20230913201248.452081-1-zi.yan@sent.com
Link: https://lkml.kernel.org/r/20230913201248.452081-2-zi.yan@sent.com
Fixes: 2813b9c02962 ("kasan, mm, arm64: tag non slab memory allocated via pagealloc")
Signed-off-by: Zi Yan <ziy@nvidia.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Mike Rapoport (IBM) <rppt@kernel.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2023-09-14 04:12:44 +08:00
|
|
|
page_kasan_tag_reset(nth_page(page, i));
|
2018-12-28 16:30:57 +08:00
|
|
|
}
|
|
|
|
|
2018-08-18 06:48:57 +08:00
|
|
|
if (ret && !no_warn) {
|
2021-05-05 09:37:34 +08:00
|
|
|
pr_err_ratelimited("%s: %s: alloc failed, req-size: %lu pages, ret: %d\n",
|
2021-05-05 09:37:22 +08:00
|
|
|
__func__, cma->name, count, ret);
|
2017-02-25 06:58:50 +08:00
|
|
|
cma_debug_show_areas(cma);
|
|
|
|
}
|
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
pr_debug("%s(): returned %p\n", __func__, page);
|
2024-01-10 09:22:33 +08:00
|
|
|
trace_cma_alloc_finish(name, pfn, page, count, align, ret);
|
2021-05-05 09:37:28 +08:00
|
|
|
if (page) {
|
2021-05-05 09:37:19 +08:00
|
|
|
count_vm_event(CMA_ALLOC_SUCCESS);
|
2021-05-05 09:37:28 +08:00
|
|
|
cma_sysfs_account_success_pages(cma, count);
|
|
|
|
} else {
|
2021-05-05 09:37:19 +08:00
|
|
|
count_vm_event(CMA_ALLOC_FAIL);
|
2024-02-01 10:37:14 +08:00
|
|
|
cma_sysfs_account_fail_pages(cma, count);
|
2021-05-05 09:37:28 +08:00
|
|
|
}
|
2021-05-05 09:37:19 +08:00
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
return page;
|
|
|
|
}
|
|
|
|
|
2021-11-06 04:41:23 +08:00
|
|
|
bool cma_pages_valid(struct cma *cma, const struct page *pages,
|
|
|
|
unsigned long count)
|
|
|
|
{
|
|
|
|
unsigned long pfn;
|
|
|
|
|
|
|
|
if (!cma || !pages)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
pfn = page_to_pfn(pages);
|
|
|
|
|
|
|
|
if (pfn < cma->base_pfn || pfn >= cma->base_pfn + cma->count) {
|
|
|
|
pr_debug("%s(page %p, count %lu)\n", __func__,
|
|
|
|
(void *)pages, count);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-08-07 07:05:25 +08:00
|
|
|
/**
|
|
|
|
* cma_release() - release allocated pages
|
|
|
|
* @cma: Contiguous memory region for which the allocation is performed.
|
|
|
|
* @pages: Allocated pages.
|
|
|
|
* @count: Number of allocated pages.
|
|
|
|
*
|
2019-07-17 07:26:00 +08:00
|
|
|
* This function releases memory allocated by cma_alloc().
|
2014-08-07 07:05:25 +08:00
|
|
|
* It returns false when provided pages do not belong to contiguous area and
|
|
|
|
* true otherwise.
|
|
|
|
*/
|
2021-05-05 09:37:34 +08:00
|
|
|
bool cma_release(struct cma *cma, const struct page *pages,
|
|
|
|
unsigned long count)
|
2014-08-07 07:05:25 +08:00
|
|
|
{
|
|
|
|
unsigned long pfn;
|
|
|
|
|
2021-11-06 04:41:23 +08:00
|
|
|
if (!cma_pages_valid(cma, pages, count))
|
2014-08-07 07:05:25 +08:00
|
|
|
return false;
|
|
|
|
|
2021-05-05 09:37:34 +08:00
|
|
|
pr_debug("%s(page %p, count %lu)\n", __func__, (void *)pages, count);
|
2014-08-07 07:05:25 +08:00
|
|
|
|
|
|
|
pfn = page_to_pfn(pages);
|
|
|
|
|
|
|
|
VM_BUG_ON(pfn + count > cma->base_pfn + cma->count);
|
|
|
|
|
|
|
|
free_contig_range(pfn, count);
|
|
|
|
cma_clear_bitmap(cma, pfn, count);
|
2024-02-06 12:57:31 +08:00
|
|
|
cma_sysfs_account_release_pages(cma, count);
|
2021-05-05 09:37:31 +08:00
|
|
|
trace_cma_release(cma->name, pfn, pages, count);
|
2014-08-07 07:05:25 +08:00
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
2017-04-19 02:27:04 +08:00
|
|
|
|
|
|
|
int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < cma_area_count; i++) {
|
|
|
|
int ret = it(&cma_areas[i], data);
|
|
|
|
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|