2017-05-08 05:25:26 +08:00
|
|
|
#!/usr/bin/env perl
|
2018-02-21 03:24:23 +08:00
|
|
|
# SPDX-License-Identifier: GPL-2.0
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2017-05-08 05:25:26 +08:00
|
|
|
use warnings;
|
2005-04-17 06:20:36 +08:00
|
|
|
use strict;
|
|
|
|
|
|
|
|
## Copyright (c) 1998 Michael Zucchi, All Rights Reserved ##
|
|
|
|
## Copyright (C) 2000, 1 Tim Waugh <twaugh@redhat.com> ##
|
|
|
|
## Copyright (C) 2001 Simon Huggins ##
|
2012-01-22 02:31:54 +08:00
|
|
|
## Copyright (C) 2005-2012 Randy Dunlap ##
|
2012-08-12 16:46:15 +08:00
|
|
|
## Copyright (C) 2012 Dan Luedtke ##
|
2005-04-17 06:20:36 +08:00
|
|
|
## ##
|
|
|
|
## #define enhancements by Armin Kuster <akuster@mvista.com> ##
|
|
|
|
## Copyright (c) 2000 MontaVista Software, Inc. ##
|
2022-02-19 02:16:28 +08:00
|
|
|
#
|
|
|
|
# Copyright (C) 2022 Tomasz Warniełło (POD)
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2022-02-19 02:16:19 +08:00
|
|
|
use Pod::Usage qw/pod2usage/;
|
|
|
|
|
2022-02-19 02:16:18 +08:00
|
|
|
=head1 NAME
|
|
|
|
|
|
|
|
kernel-doc - Print formatted kernel documentation to stdout
|
|
|
|
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
|
|
|
|
kernel-doc [-h] [-v] [-Werror]
|
|
|
|
[ -man |
|
|
|
|
-rst [-sphinx-version VERSION] [-enable-lineno] |
|
|
|
|
-none
|
|
|
|
]
|
|
|
|
[
|
|
|
|
-export |
|
|
|
|
-internal |
|
|
|
|
[-function NAME] ... |
|
|
|
|
[-nosymbol NAME] ...
|
|
|
|
]
|
|
|
|
[-no-doc-sections]
|
|
|
|
[-export-file FILE] ...
|
|
|
|
FILE ...
|
|
|
|
|
|
|
|
Run `kernel-doc -h` for details.
|
|
|
|
|
2022-02-19 02:16:20 +08:00
|
|
|
=head1 DESCRIPTION
|
|
|
|
|
|
|
|
Read C language source or header FILEs, extract embedded documentation comments,
|
|
|
|
and print formatted documentation to standard output.
|
|
|
|
|
|
|
|
The documentation comments are identified by the "/**" opening comment mark.
|
|
|
|
|
|
|
|
See Documentation/doc-guide/kernel-doc.rst for the documentation comment syntax.
|
|
|
|
|
2022-02-19 02:16:18 +08:00
|
|
|
=cut
|
|
|
|
|
2022-02-19 02:16:21 +08:00
|
|
|
# more perldoc at the end of the file
|
|
|
|
|
2011-01-06 08:28:43 +08:00
|
|
|
## init lots of data
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
my $errors = 0;
|
|
|
|
my $warnings = 0;
|
2007-07-19 16:48:24 +08:00
|
|
|
my $anon_struct_union = 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
# match expressions used to find embedded type information
|
2017-03-31 04:11:28 +08:00
|
|
|
my $type_constant = '\b``([^\`]+)``\b';
|
|
|
|
my $type_constant2 = '\%([-_\w]+)';
|
2005-04-17 06:20:36 +08:00
|
|
|
my $type_func = '(\w+)\(\)';
|
2018-11-08 00:47:13 +08:00
|
|
|
my $type_param = '\@(\w*((\.\w+)|(->\w+))*(\.\.\.)?)';
|
2020-04-15 00:48:28 +08:00
|
|
|
my $type_param_ref = '([\!]?)\@(\w*((\.\w+)|(->\w+))*(\.\.\.)?)';
|
2016-08-25 06:31:15 +08:00
|
|
|
my $type_fp_param = '\@(\w+)\(\)'; # Special RST handling for func ptr params
|
2020-04-15 00:48:27 +08:00
|
|
|
my $type_fp_param2 = '\@(\w+->\S+)\(\)'; # Special RST handling for structs with func ptr params
|
2005-04-17 06:20:36 +08:00
|
|
|
my $type_env = '(\$\w+)';
|
2017-01-02 23:22:27 +08:00
|
|
|
my $type_enum = '\&(enum\s*([_\w]+))';
|
|
|
|
my $type_struct = '\&(struct\s*([_\w]+))';
|
|
|
|
my $type_typedef = '\&(typedef\s*([_\w]+))';
|
|
|
|
my $type_union = '\&(union\s*([_\w]+))';
|
2017-01-02 23:22:26 +08:00
|
|
|
my $type_member = '\&([_\w]+)(\.|->)([_\w]+)';
|
2017-01-02 23:22:27 +08:00
|
|
|
my $type_fallback = '\&([_\w]+)';
|
2016-05-26 21:35:02 +08:00
|
|
|
my $type_member_func = $type_member . '\(\)';
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
# Output conversion substitutions.
|
|
|
|
# One for each output format
|
|
|
|
|
|
|
|
# these are pretty rough
|
2015-09-08 04:01:59 +08:00
|
|
|
my @highlights_man = (
|
|
|
|
[$type_constant, "\$1"],
|
2017-03-31 04:11:28 +08:00
|
|
|
[$type_constant2, "\$1"],
|
2015-09-08 04:01:59 +08:00
|
|
|
[$type_func, "\\\\fB\$1\\\\fP"],
|
2017-01-02 23:22:27 +08:00
|
|
|
[$type_enum, "\\\\fI\$1\\\\fP"],
|
2015-09-08 04:01:59 +08:00
|
|
|
[$type_struct, "\\\\fI\$1\\\\fP"],
|
2017-01-02 23:22:27 +08:00
|
|
|
[$type_typedef, "\\\\fI\$1\\\\fP"],
|
|
|
|
[$type_union, "\\\\fI\$1\\\\fP"],
|
2017-01-02 23:22:26 +08:00
|
|
|
[$type_param, "\\\\fI\$1\\\\fP"],
|
2020-04-15 00:48:28 +08:00
|
|
|
[$type_param_ref, "\\\\fI\$1\$2\\\\fP"],
|
2017-01-02 23:22:27 +08:00
|
|
|
[$type_member, "\\\\fI\$1\$2\$3\\\\fP"],
|
|
|
|
[$type_fallback, "\\\\fI\$1\\\\fP"]
|
2015-09-08 04:01:59 +08:00
|
|
|
);
|
2005-04-17 06:20:36 +08:00
|
|
|
my $blankline_man = "";
|
|
|
|
|
2016-05-12 21:15:37 +08:00
|
|
|
# rst-mode
|
|
|
|
my @highlights_rst = (
|
|
|
|
[$type_constant, "``\$1``"],
|
2017-03-31 04:11:28 +08:00
|
|
|
[$type_constant2, "``\$1``"],
|
2016-05-26 21:35:02 +08:00
|
|
|
# Note: need to escape () to avoid func matching later
|
2017-01-02 23:22:26 +08:00
|
|
|
[$type_member_func, "\\:c\\:type\\:`\$1\$2\$3\\\\(\\\\) <\$1>`"],
|
|
|
|
[$type_member, "\\:c\\:type\\:`\$1\$2\$3 <\$1>`"],
|
2016-08-25 06:31:15 +08:00
|
|
|
[$type_fp_param, "**\$1\\\\(\\\\)**"],
|
2020-04-15 00:48:27 +08:00
|
|
|
[$type_fp_param2, "**\$1\\\\(\\\\)**"],
|
2019-06-22 07:34:30 +08:00
|
|
|
[$type_func, "\$1()"],
|
2017-01-02 23:22:27 +08:00
|
|
|
[$type_enum, "\\:c\\:type\\:`\$1 <\$2>`"],
|
|
|
|
[$type_struct, "\\:c\\:type\\:`\$1 <\$2>`"],
|
|
|
|
[$type_typedef, "\\:c\\:type\\:`\$1 <\$2>`"],
|
|
|
|
[$type_union, "\\:c\\:type\\:`\$1 <\$2>`"],
|
2016-05-26 18:57:06 +08:00
|
|
|
# in rst this can refer to any type
|
2017-01-02 23:22:27 +08:00
|
|
|
[$type_fallback, "\\:c\\:type\\:`\$1`"],
|
2020-04-15 00:48:28 +08:00
|
|
|
[$type_param_ref, "**\$1\$2**"]
|
2016-05-12 21:15:37 +08:00
|
|
|
);
|
|
|
|
my $blankline_rst = "\n";
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
# read arguments
|
2009-06-09 23:50:38 +08:00
|
|
|
if ($#ARGV == -1) {
|
2022-02-19 02:16:19 +08:00
|
|
|
pod2usage(
|
|
|
|
-message => "No arguments!\n",
|
|
|
|
-exitval => 1,
|
|
|
|
-verbose => 99,
|
|
|
|
-sections => 'SYNOPSIS',
|
|
|
|
-output => \*STDERR,
|
|
|
|
);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2011-01-06 08:28:43 +08:00
|
|
|
my $kernelversion;
|
2020-10-04 15:44:28 +08:00
|
|
|
my ($sphinx_major, $sphinx_minor, $sphinx_patch);
|
2020-09-24 21:30:37 +08:00
|
|
|
|
2011-01-06 08:28:43 +08:00
|
|
|
my $dohighlight = "";
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
my $verbose = 0;
|
2020-07-29 00:20:40 +08:00
|
|
|
my $Werror = 0;
|
2017-12-18 20:30:11 +08:00
|
|
|
my $output_mode = "rst";
|
2012-10-05 08:15:08 +08:00
|
|
|
my $output_preformatted = 0;
|
2007-10-25 06:08:48 +08:00
|
|
|
my $no_doc_sections = 0;
|
2016-06-04 04:21:34 +08:00
|
|
|
my $enable_lineno = 0;
|
2017-12-18 20:30:11 +08:00
|
|
|
my @highlights = @highlights_rst;
|
|
|
|
my $blankline = $blankline_rst;
|
2005-04-17 06:20:36 +08:00
|
|
|
my $modulename = "Kernel API";
|
2016-05-30 03:19:35 +08:00
|
|
|
|
|
|
|
use constant {
|
|
|
|
OUTPUT_ALL => 0, # output all symbols and doc sections
|
|
|
|
OUTPUT_INCLUDE => 1, # output only specified symbols
|
2020-09-29 20:23:39 +08:00
|
|
|
OUTPUT_EXPORTED => 2, # output exported symbols
|
|
|
|
OUTPUT_INTERNAL => 3, # output non-exported symbols
|
2016-05-30 03:19:35 +08:00
|
|
|
};
|
|
|
|
my $output_selection = OUTPUT_ALL;
|
2019-05-25 04:52:01 +08:00
|
|
|
my $show_not_found = 0; # No longer used
|
2015-07-09 03:07:16 +08:00
|
|
|
|
2016-06-07 16:00:52 +08:00
|
|
|
my @export_file_list;
|
|
|
|
|
2015-07-09 03:07:16 +08:00
|
|
|
my @build_time;
|
|
|
|
if (defined($ENV{'KBUILD_BUILD_TIMESTAMP'}) &&
|
|
|
|
(my $seconds = `date -d"${ENV{'KBUILD_BUILD_TIMESTAMP'}}" +%s`) ne '') {
|
|
|
|
@build_time = gmtime($seconds);
|
|
|
|
} else {
|
|
|
|
@build_time = localtime;
|
|
|
|
}
|
|
|
|
|
2006-02-01 19:06:58 +08:00
|
|
|
my $man_date = ('January', 'February', 'March', 'April', 'May', 'June',
|
|
|
|
'July', 'August', 'September', 'October',
|
2015-07-09 03:07:16 +08:00
|
|
|
'November', 'December')[$build_time[4]] .
|
|
|
|
" " . ($build_time[5]+1900);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2011-01-06 08:28:43 +08:00
|
|
|
# Essentially these are globals.
|
2009-06-09 23:50:38 +08:00
|
|
|
# They probably want to be tidied up, made more localised or something.
|
|
|
|
# CAVEAT EMPTOR! Some of the others I localised may not want to be, which
|
2005-04-17 06:20:36 +08:00
|
|
|
# could cause "use of undefined value" or other bugs.
|
2009-06-09 23:50:38 +08:00
|
|
|
my ($function, %function_table, %parametertypes, $declaration_purpose);
|
2020-09-29 20:23:39 +08:00
|
|
|
my %nosymbol_table = ();
|
2016-06-04 04:21:34 +08:00
|
|
|
my $declaration_start_line;
|
2009-06-09 23:50:38 +08:00
|
|
|
my ($type, $declaration_name, $return_type);
|
2010-02-27 05:06:03 +08:00
|
|
|
my ($newsection, $newcontents, $prototype, $brcount, %source_map);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-03-14 03:32:43 +08:00
|
|
|
if (defined($ENV{'KBUILD_VERBOSE'})) {
|
|
|
|
$verbose = "$ENV{'KBUILD_VERBOSE'}";
|
|
|
|
}
|
|
|
|
|
2020-07-29 00:20:40 +08:00
|
|
|
if (defined($ENV{'KCFLAGS'})) {
|
|
|
|
my $kcflags = "$ENV{'KCFLAGS'}";
|
|
|
|
|
|
|
|
if ($kcflags =~ /Werror/) {
|
|
|
|
$Werror = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-07-31 06:54:01 +08:00
|
|
|
if (defined($ENV{'KDOC_WERROR'})) {
|
|
|
|
$Werror = "$ENV{'KDOC_WERROR'}";
|
|
|
|
}
|
|
|
|
|
2006-02-01 19:06:58 +08:00
|
|
|
# Generated docbook code is inserted in a template at a point where
|
2005-04-17 06:20:36 +08:00
|
|
|
# docbook v3.1 requires a non-zero sequence of RefEntry's; see:
|
2020-05-26 14:05:44 +08:00
|
|
|
# https://www.oasis-open.org/docbook/documentation/reference/html/refentry.html
|
2005-04-17 06:20:36 +08:00
|
|
|
# We keep track of number of generated entries and generate a dummy
|
|
|
|
# if needs be to ensure the expanded template can be postprocessed
|
|
|
|
# into html.
|
|
|
|
my $section_counter = 0;
|
|
|
|
|
|
|
|
my $lineprefix="";
|
|
|
|
|
2016-05-26 19:56:05 +08:00
|
|
|
# Parser states
|
|
|
|
use constant {
|
2020-04-15 00:48:29 +08:00
|
|
|
STATE_NORMAL => 0, # normal code
|
|
|
|
STATE_NAME => 1, # looking for function name
|
|
|
|
STATE_BODY_MAYBE => 2, # body - or maybe more description
|
|
|
|
STATE_BODY => 3, # the body of the comment
|
|
|
|
STATE_BODY_WITH_BLANK_LINE => 4, # the body, which has a blank line
|
|
|
|
STATE_PROTO => 5, # scanning prototype
|
|
|
|
STATE_DOCBLOCK => 6, # documentation block
|
|
|
|
STATE_INLINE => 7, # gathering doc outside main block
|
2016-05-26 19:56:05 +08:00
|
|
|
};
|
2005-04-17 06:20:36 +08:00
|
|
|
my $state;
|
2006-06-25 20:48:55 +08:00
|
|
|
my $in_doc_sect;
|
2018-02-06 06:36:05 +08:00
|
|
|
my $leading_space;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2016-05-26 19:56:05 +08:00
|
|
|
# Inline documentation state
|
|
|
|
use constant {
|
|
|
|
STATE_INLINE_NA => 0, # not applicable ($state != STATE_INLINE)
|
|
|
|
STATE_INLINE_NAME => 1, # looking for member name (@foo:)
|
|
|
|
STATE_INLINE_TEXT => 2, # looking for member documentation
|
|
|
|
STATE_INLINE_END => 3, # done
|
|
|
|
STATE_INLINE_ERROR => 4, # error - Comment without header was found.
|
|
|
|
# Spit a warning as it's not
|
|
|
|
# proper kernel-doc and ignore the rest.
|
|
|
|
};
|
|
|
|
my $inline_doc_state;
|
2015-08-04 20:04:08 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
#declaration types: can be
|
|
|
|
# 'function', 'struct', 'union', 'enum', 'typedef'
|
|
|
|
my $decl_type;
|
|
|
|
|
2021-01-14 16:04:47 +08:00
|
|
|
# Name of the kernel-doc identifier for non-DOC markups
|
|
|
|
my $identifier;
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
my $doc_start = '^/\*\*\s*$'; # Allow whitespace at end of comment start.
|
|
|
|
my $doc_end = '\*/';
|
|
|
|
my $doc_com = '\s*\*\s*';
|
2012-10-05 08:15:10 +08:00
|
|
|
my $doc_com_body = '\s*\* ?';
|
2009-06-09 23:50:38 +08:00
|
|
|
my $doc_decl = $doc_com . '(\w+)';
|
kernel-doc: limit the "section header:" detection to a select few
kernel-doc currently identifies anything matching "section header:"
(specifically a string of word characters and spaces followed by a
colon) as a new section in the documentation comment, and renders the
section header accordingly.
Unfortunately, this turns all uses of colon into sections, mostly
unintentionally. Considering the output, erroneously creating sections
when not intended is always worse than erroneously not creating sections
when intended. For example, a line with "http://example.com" turns into
a "http" heading followed by "//example.com" in normal text style, which
is quite ugly. OTOH, "WARNING: Beware of the Leopard" is just fine even
if "WARNING" does not turn into a heading.
It is virtually impossible to change all the kernel-doc comments, either
way. The compromise is to pick the most commonly used and depended on
section headers (with variants) and accept them as section headers.
The accepted section headers are, case insensitive:
* description:
* context:
* return:
* returns:
Additionally, case sensitive:
* @return:
All of the above are commonly used in the kernel-doc comments, and will
result in worse output if not identified as section headers. Also,
kernel-doc already has some special handling for all of them, so there's
nothing particularly controversial in adding more special treatment for
them.
While at it, improve the whitespace handling surrounding section
names. Do not consider the whitespace as part of the name.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
2016-05-29 16:35:28 +08:00
|
|
|
# @params and a strictly limited set of supported section names
|
2021-03-27 03:16:35 +08:00
|
|
|
# Specifically:
|
|
|
|
# Match @word:
|
|
|
|
# @...:
|
|
|
|
# @{section-name}:
|
|
|
|
# while trying to not match literal block starts like "example::"
|
|
|
|
#
|
2018-11-08 00:47:12 +08:00
|
|
|
my $doc_sect = $doc_com .
|
2021-03-27 03:16:35 +08:00
|
|
|
'\s*(\@[.\w]+|\@\.\.\.|description|context|returns?|notes?|examples?)\s*:([^:].*)?$';
|
2012-10-05 08:15:10 +08:00
|
|
|
my $doc_content = $doc_com_body . '(.*)';
|
2009-06-09 23:50:38 +08:00
|
|
|
my $doc_block = $doc_com . 'DOC:\s*(.*)?';
|
2016-05-26 19:56:05 +08:00
|
|
|
my $doc_inline_start = '^\s*/\*\*\s*$';
|
2018-02-16 21:48:18 +08:00
|
|
|
my $doc_inline_sect = '\s*\*\s*(@\s*[\w][\w\.]*\s*):(.*)';
|
2016-05-26 19:56:05 +08:00
|
|
|
my $doc_inline_end = '^\s*\*/\s*$';
|
2016-11-16 23:26:16 +08:00
|
|
|
my $doc_inline_oneline = '^\s*/\*\*\s*(@[\w\s]+):\s*(.*)\s*\*/\s*$';
|
2016-01-21 19:05:22 +08:00
|
|
|
my $export_symbol = '^\s*EXPORT_SYMBOL(_GPL)?\s*\(\s*(\w+)\s*\)\s*;';
|
2022-11-30 04:29:27 +08:00
|
|
|
my $export_symbol_ns = '^\s*EXPORT_SYMBOL_NS(_GPL)?\s*\(\s*(\w+)\s*,\s*\w+\)\s*;';
|
2021-05-14 22:42:44 +08:00
|
|
|
my $function_pointer = qr{([^\(]*\(\*)\s*\)\s*\(([^\)]*)\)};
|
|
|
|
my $attribute = qr{__attribute__\s*\(\([a-z0-9,_\*\s\(\)]*\)\)}i;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
my %parameterdescs;
|
2016-06-04 04:21:34 +08:00
|
|
|
my %parameterdesc_start_lines;
|
2005-04-17 06:20:36 +08:00
|
|
|
my @parameterlist;
|
|
|
|
my %sections;
|
|
|
|
my @sectionlist;
|
2016-06-04 04:21:34 +08:00
|
|
|
my %section_start_lines;
|
2008-12-20 00:49:30 +08:00
|
|
|
my $sectcheck;
|
|
|
|
my $struct_actual;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
my $contents = "";
|
2016-06-04 04:21:34 +08:00
|
|
|
my $new_start_line = 0;
|
kernel-doc: limit the "section header:" detection to a select few
kernel-doc currently identifies anything matching "section header:"
(specifically a string of word characters and spaces followed by a
colon) as a new section in the documentation comment, and renders the
section header accordingly.
Unfortunately, this turns all uses of colon into sections, mostly
unintentionally. Considering the output, erroneously creating sections
when not intended is always worse than erroneously not creating sections
when intended. For example, a line with "http://example.com" turns into
a "http" heading followed by "//example.com" in normal text style, which
is quite ugly. OTOH, "WARNING: Beware of the Leopard" is just fine even
if "WARNING" does not turn into a heading.
It is virtually impossible to change all the kernel-doc comments, either
way. The compromise is to pick the most commonly used and depended on
section headers (with variants) and accept them as section headers.
The accepted section headers are, case insensitive:
* description:
* context:
* return:
* returns:
Additionally, case sensitive:
* @return:
All of the above are commonly used in the kernel-doc comments, and will
result in worse output if not identified as section headers. Also,
kernel-doc already has some special handling for all of them, so there's
nothing particularly controversial in adding more special treatment for
them.
While at it, improve the whitespace handling surrounding section
names. Do not consider the whitespace as part of the name.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
2016-05-29 16:35:28 +08:00
|
|
|
|
|
|
|
# the canonical section names. see also $doc_sect above.
|
2005-04-17 06:20:36 +08:00
|
|
|
my $section_default = "Description"; # default section
|
|
|
|
my $section_intro = "Introduction";
|
|
|
|
my $section = $section_default;
|
|
|
|
my $section_context = "Context";
|
2012-11-27 05:22:27 +08:00
|
|
|
my $section_return = "Return";
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
my $undescribed = "-- undescribed --";
|
|
|
|
|
|
|
|
reset_state();
|
|
|
|
|
2017-12-18 20:30:10 +08:00
|
|
|
while ($ARGV[0] =~ m/^--?(.*)/) {
|
|
|
|
my $cmd = $1;
|
|
|
|
shift @ARGV;
|
|
|
|
if ($cmd eq "man") {
|
2005-04-17 06:20:36 +08:00
|
|
|
$output_mode = "man";
|
2015-09-08 04:01:59 +08:00
|
|
|
@highlights = @highlights_man;
|
2005-04-17 06:20:36 +08:00
|
|
|
$blankline = $blankline_man;
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq "rst") {
|
2016-05-12 21:15:37 +08:00
|
|
|
$output_mode = "rst";
|
|
|
|
@highlights = @highlights_rst;
|
|
|
|
$blankline = $blankline_rst;
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq "none") {
|
2017-11-21 02:40:40 +08:00
|
|
|
$output_mode = "none";
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq "module") { # not needed for XML, inherits from calling document
|
2005-04-17 06:20:36 +08:00
|
|
|
$modulename = shift @ARGV;
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq "function") { # to only output specific functions
|
2016-05-30 03:19:35 +08:00
|
|
|
$output_selection = OUTPUT_INCLUDE;
|
2005-04-17 06:20:36 +08:00
|
|
|
$function = shift @ARGV;
|
|
|
|
$function_table{$function} = 1;
|
2020-09-29 20:23:39 +08:00
|
|
|
} elsif ($cmd eq "nosymbol") { # Exclude specific symbols
|
|
|
|
my $symbol = shift @ARGV;
|
|
|
|
$nosymbol_table{$symbol} = 1;
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq "export") { # only exported symbols
|
2016-05-30 03:19:35 +08:00
|
|
|
$output_selection = OUTPUT_EXPORTED;
|
2016-06-07 15:29:59 +08:00
|
|
|
%function_table = ();
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq "internal") { # only non-exported symbols
|
2016-05-30 03:19:35 +08:00
|
|
|
$output_selection = OUTPUT_INTERNAL;
|
2016-06-07 15:29:59 +08:00
|
|
|
%function_table = ();
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq "export-file") {
|
2016-06-07 16:00:52 +08:00
|
|
|
my $file = shift @ARGV;
|
|
|
|
push(@export_file_list, $file);
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq "v") {
|
2005-04-17 06:20:36 +08:00
|
|
|
$verbose = 1;
|
2020-07-29 00:20:40 +08:00
|
|
|
} elsif ($cmd eq "Werror") {
|
|
|
|
$Werror = 1;
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif (($cmd eq "h") || ($cmd eq "help")) {
|
2022-02-19 02:16:26 +08:00
|
|
|
pod2usage(-exitval => 0, -verbose => 2);
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq 'no-doc-sections') {
|
2007-10-25 06:08:48 +08:00
|
|
|
$no_doc_sections = 1;
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq 'enable-lineno') {
|
2016-06-04 04:21:34 +08:00
|
|
|
$enable_lineno = 1;
|
2017-12-18 20:30:10 +08:00
|
|
|
} elsif ($cmd eq 'show-not-found') {
|
2019-05-25 04:52:01 +08:00
|
|
|
$show_not_found = 1; # A no-op but don't fail
|
2020-10-04 15:44:28 +08:00
|
|
|
} elsif ($cmd eq "sphinx-version") {
|
|
|
|
my $ver_string = shift @ARGV;
|
|
|
|
if ($ver_string =~ m/^(\d+)(\.\d+)?(\.\d+)?/) {
|
|
|
|
$sphinx_major = $1;
|
|
|
|
if (defined($2)) {
|
|
|
|
$sphinx_minor = substr($2,1);
|
|
|
|
} else {
|
|
|
|
$sphinx_minor = 0;
|
|
|
|
}
|
|
|
|
if (defined($3)) {
|
|
|
|
$sphinx_patch = substr($3,1)
|
|
|
|
} else {
|
|
|
|
$sphinx_patch = 0;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
die "Sphinx version should either major.minor or major.minor.patch format\n";
|
|
|
|
}
|
2017-12-18 20:30:10 +08:00
|
|
|
} else {
|
2022-02-24 21:02:46 +08:00
|
|
|
# Unknown argument
|
|
|
|
pod2usage(
|
|
|
|
-message => "Argument unknown!\n",
|
|
|
|
-exitval => 1,
|
|
|
|
-verbose => 99,
|
|
|
|
-sections => 'SYNOPSIS',
|
|
|
|
-output => \*STDERR,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
if ($#ARGV < 0){
|
|
|
|
pod2usage(
|
|
|
|
-message => "FILE argument missing\n",
|
|
|
|
-exitval => 1,
|
|
|
|
-verbose => 99,
|
|
|
|
-sections => 'SYNOPSIS',
|
|
|
|
-output => \*STDERR,
|
|
|
|
);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-01-06 08:28:43 +08:00
|
|
|
# continue execution near EOF;
|
|
|
|
|
2020-09-24 21:30:37 +08:00
|
|
|
# The C domain dialect changed on Sphinx 3. So, we need to check the
|
|
|
|
# version in order to produce the right tags.
|
|
|
|
sub findprog($)
|
|
|
|
{
|
|
|
|
foreach(split(/:/, $ENV{PATH})) {
|
|
|
|
return "$_/$_[0]" if(-x "$_/$_[0]");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
sub get_sphinx_version()
|
|
|
|
{
|
|
|
|
my $ver;
|
|
|
|
|
|
|
|
my $cmd = "sphinx-build";
|
|
|
|
if (!findprog($cmd)) {
|
|
|
|
my $cmd = "sphinx-build3";
|
2020-10-04 15:44:28 +08:00
|
|
|
if (!findprog($cmd)) {
|
|
|
|
$sphinx_major = 1;
|
|
|
|
$sphinx_minor = 2;
|
|
|
|
$sphinx_patch = 0;
|
|
|
|
printf STDERR "Warning: Sphinx version not found. Using default (Sphinx version %d.%d.%d)\n",
|
|
|
|
$sphinx_major, $sphinx_minor, $sphinx_patch;
|
|
|
|
return;
|
|
|
|
}
|
2020-09-24 21:30:37 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
open IN, "$cmd --version 2>&1 |";
|
|
|
|
while (<IN>) {
|
|
|
|
if (m/^\s*sphinx-build\s+([\d]+)\.([\d\.]+)(\+\/[\da-f]+)?$/) {
|
2020-10-04 15:44:28 +08:00
|
|
|
$sphinx_major = $1;
|
|
|
|
$sphinx_minor = $2;
|
|
|
|
$sphinx_patch = $3;
|
2020-09-24 21:30:37 +08:00
|
|
|
last;
|
|
|
|
}
|
|
|
|
# Sphinx 1.2.x uses a different format
|
|
|
|
if (m/^\s*Sphinx.*\s+([\d]+)\.([\d\.]+)$/) {
|
2020-10-04 15:44:28 +08:00
|
|
|
$sphinx_major = $1;
|
|
|
|
$sphinx_minor = $2;
|
|
|
|
$sphinx_patch = $3;
|
2020-09-24 21:30:37 +08:00
|
|
|
last;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
close IN;
|
|
|
|
}
|
|
|
|
|
2007-05-08 15:30:54 +08:00
|
|
|
# get kernel version from env
|
|
|
|
sub get_kernel_version() {
|
2007-10-25 06:08:48 +08:00
|
|
|
my $version = 'unknown kernel version';
|
2007-05-08 15:30:54 +08:00
|
|
|
|
|
|
|
if (defined($ENV{'KERNELVERSION'})) {
|
|
|
|
$version = $ENV{'KERNELVERSION'};
|
|
|
|
}
|
|
|
|
return $version;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2016-06-04 04:21:34 +08:00
|
|
|
#
|
|
|
|
sub print_lineno {
|
|
|
|
my $lineno = shift;
|
|
|
|
if ($enable_lineno && defined($lineno)) {
|
2022-03-26 18:27:24 +08:00
|
|
|
print ".. LINENO " . $lineno . "\n";
|
2016-06-04 04:21:34 +08:00
|
|
|
}
|
|
|
|
}
|
2022-06-13 17:05:10 +08:00
|
|
|
|
|
|
|
sub emit_warning {
|
|
|
|
my $location = shift;
|
|
|
|
my $msg = shift;
|
|
|
|
print STDERR "$location: warning: $msg";
|
|
|
|
++$warnings;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
##
|
|
|
|
# dumps section contents to arrays/hashes intended for that purpose.
|
|
|
|
#
|
|
|
|
sub dump_section {
|
2008-04-28 17:16:34 +08:00
|
|
|
my $file = shift;
|
2005-04-17 06:20:36 +08:00
|
|
|
my $name = shift;
|
|
|
|
my $contents = join "\n", @_;
|
|
|
|
|
2016-05-26 13:57:29 +08:00
|
|
|
if ($name =~ m/$type_param/) {
|
2005-04-17 06:20:36 +08:00
|
|
|
$name = $1;
|
|
|
|
$parameterdescs{$name} = $contents;
|
2008-12-20 00:49:30 +08:00
|
|
|
$sectcheck = $sectcheck . $name . " ";
|
2016-06-04 04:21:34 +08:00
|
|
|
$parameterdesc_start_lines{$name} = $new_start_line;
|
|
|
|
$new_start_line = 0;
|
2008-12-02 05:14:03 +08:00
|
|
|
} elsif ($name eq "@\.\.\.") {
|
|
|
|
$name = "...";
|
|
|
|
$parameterdescs{$name} = $contents;
|
2008-12-20 00:49:30 +08:00
|
|
|
$sectcheck = $sectcheck . $name . " ";
|
2016-06-04 04:21:34 +08:00
|
|
|
$parameterdesc_start_lines{$name} = $new_start_line;
|
|
|
|
$new_start_line = 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
} else {
|
2008-04-28 17:16:34 +08:00
|
|
|
if (defined($sections{$name}) && ($sections{$name} ne "")) {
|
2016-06-10 16:14:05 +08:00
|
|
|
# Only warn on user specified duplicate section names.
|
|
|
|
if ($name ne $section_default) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "duplicate section name '$name'\n");
|
2016-06-10 16:14:05 +08:00
|
|
|
}
|
2016-05-29 14:40:44 +08:00
|
|
|
$sections{$name} .= $contents;
|
|
|
|
} else {
|
|
|
|
$sections{$name} = $contents;
|
|
|
|
push @sectionlist, $name;
|
2016-06-04 04:21:34 +08:00
|
|
|
$section_start_lines{$name} = $new_start_line;
|
|
|
|
$new_start_line = 0;
|
2008-04-28 17:16:34 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-10-25 06:08:48 +08:00
|
|
|
##
|
|
|
|
# dump DOC: section after checking that it should go out
|
|
|
|
#
|
|
|
|
sub dump_doc_section {
|
2008-04-28 17:16:34 +08:00
|
|
|
my $file = shift;
|
2007-10-25 06:08:48 +08:00
|
|
|
my $name = shift;
|
|
|
|
my $contents = join "\n", @_;
|
|
|
|
|
2007-10-25 06:08:48 +08:00
|
|
|
if ($no_doc_sections) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-09-29 20:23:39 +08:00
|
|
|
return if (defined($nosymbol_table{$name}));
|
|
|
|
|
2016-05-30 03:19:35 +08:00
|
|
|
if (($output_selection == OUTPUT_ALL) ||
|
2020-09-29 20:23:39 +08:00
|
|
|
(($output_selection == OUTPUT_INCLUDE) &&
|
|
|
|
defined($function_table{$name})))
|
2007-10-25 06:08:48 +08:00
|
|
|
{
|
2008-04-28 17:16:34 +08:00
|
|
|
dump_section($file, $name, $contents);
|
2007-10-25 06:08:48 +08:00
|
|
|
output_blockhead({'sectionlist' => \@sectionlist,
|
|
|
|
'sections' => \%sections,
|
|
|
|
'module' => $modulename,
|
2016-05-30 03:19:35 +08:00
|
|
|
'content-only' => ($output_selection != OUTPUT_ALL), });
|
2007-10-25 06:08:48 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
##
|
|
|
|
# output function
|
|
|
|
#
|
|
|
|
# parameterdescs, a hash.
|
|
|
|
# function => "function name"
|
|
|
|
# parameterlist => @list of parameters
|
|
|
|
# parameterdescs => %parameter descriptions
|
|
|
|
# sectionlist => @list of sections
|
2007-02-10 17:46:04 +08:00
|
|
|
# sections => %section descriptions
|
2006-02-01 19:06:58 +08:00
|
|
|
#
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
sub output_highlight {
|
|
|
|
my $contents = join "\n",@_;
|
|
|
|
my $line;
|
|
|
|
|
|
|
|
# DEBUG
|
|
|
|
# if (!defined $contents) {
|
|
|
|
# use Carp;
|
|
|
|
# confess "output_highlight got called with no args?\n";
|
|
|
|
# }
|
|
|
|
|
2007-05-08 15:29:51 +08:00
|
|
|
# print STDERR "contents b4:$contents\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
eval $dohighlight;
|
|
|
|
die $@ if $@;
|
2007-05-08 15:29:51 +08:00
|
|
|
# print STDERR "contents af:$contents\n";
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
foreach $line (split "\n", $contents) {
|
2012-10-05 08:15:10 +08:00
|
|
|
if (! $output_preformatted) {
|
|
|
|
$line =~ s/^\s*//;
|
|
|
|
}
|
2007-05-08 15:24:39 +08:00
|
|
|
if ($line eq ""){
|
2012-10-05 08:15:08 +08:00
|
|
|
if (! $output_preformatted) {
|
2018-02-06 03:40:15 +08:00
|
|
|
print $lineprefix, $blankline;
|
2012-10-05 08:15:08 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
} else {
|
2007-07-19 16:48:25 +08:00
|
|
|
if ($output_mode eq "man" && substr($line, 0, 1) eq ".") {
|
|
|
|
print "\\&$line";
|
|
|
|
} else {
|
|
|
|
print $lineprefix, $line;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
print "\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
##
|
|
|
|
# output function in man
|
|
|
|
sub output_function_man(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter, $section);
|
|
|
|
my $count;
|
|
|
|
|
|
|
|
print ".TH \"$args{'function'}\" 9 \"$args{'function'}\" \"$man_date\" \"Kernel Hacker's Manual\" LINUX\n";
|
|
|
|
|
|
|
|
print ".SH NAME\n";
|
2009-06-09 23:50:38 +08:00
|
|
|
print $args{'function'} . " \\- " . $args{'purpose'} . "\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
print ".SH SYNOPSIS\n";
|
2007-02-10 17:46:04 +08:00
|
|
|
if ($args{'functiontype'} ne "") {
|
2009-06-09 23:50:38 +08:00
|
|
|
print ".B \"" . $args{'functiontype'} . "\" " . $args{'function'} . "\n";
|
2007-02-10 17:46:04 +08:00
|
|
|
} else {
|
2009-06-09 23:50:38 +08:00
|
|
|
print ".B \"" . $args{'function'} . "\n";
|
2007-02-10 17:46:04 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
$count = 0;
|
|
|
|
my $parenth = "(";
|
|
|
|
my $post = ",";
|
|
|
|
foreach my $parameter (@{$args{'parameterlist'}}) {
|
|
|
|
if ($count == $#{$args{'parameterlist'}}) {
|
|
|
|
$post = ");";
|
|
|
|
}
|
|
|
|
$type = $args{'parametertypes'}{$parameter};
|
2021-05-14 22:42:44 +08:00
|
|
|
if ($type =~ m/$function_pointer/) {
|
2005-04-17 06:20:36 +08:00
|
|
|
# pointer-to-function
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
print ".BI \"" . $parenth . $1 . "\" " . " \") (" . $2 . ")" . $post . "\"\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
} else {
|
|
|
|
$type =~ s/([^\*])$/$1 /;
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
print ".BI \"" . $parenth . $type . "\" " . " \"" . $post . "\"\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
$count++;
|
|
|
|
$parenth = "";
|
|
|
|
}
|
|
|
|
|
|
|
|
print ".SH ARGUMENTS\n";
|
|
|
|
foreach $parameter (@{$args{'parameterlist'}}) {
|
|
|
|
my $parameter_name = $parameter;
|
|
|
|
$parameter_name =~ s/\[.*//;
|
|
|
|
|
2009-06-09 23:50:38 +08:00
|
|
|
print ".IP \"" . $parameter . "\" 12\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
output_highlight($args{'parameterdescs'}{$parameter_name});
|
|
|
|
}
|
|
|
|
foreach $section (@{$args{'sectionlist'}}) {
|
|
|
|
print ".SH \"", uc $section, "\"\n";
|
|
|
|
output_highlight($args{'sections'}{$section});
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
##
|
|
|
|
# output enum in man
|
|
|
|
sub output_enum_man(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter, $section);
|
|
|
|
my $count;
|
|
|
|
|
|
|
|
print ".TH \"$args{'module'}\" 9 \"enum $args{'enum'}\" \"$man_date\" \"API Manual\" LINUX\n";
|
|
|
|
|
|
|
|
print ".SH NAME\n";
|
2009-06-09 23:50:38 +08:00
|
|
|
print "enum " . $args{'enum'} . " \\- " . $args{'purpose'} . "\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
print ".SH SYNOPSIS\n";
|
2009-06-09 23:50:38 +08:00
|
|
|
print "enum " . $args{'enum'} . " {\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
$count = 0;
|
|
|
|
foreach my $parameter (@{$args{'parameterlist'}}) {
|
2007-05-08 15:24:39 +08:00
|
|
|
print ".br\n.BI \" $parameter\"\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
if ($count == $#{$args{'parameterlist'}}) {
|
|
|
|
print "\n};\n";
|
|
|
|
last;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
print ", \n.br\n";
|
|
|
|
}
|
|
|
|
$count++;
|
|
|
|
}
|
|
|
|
|
|
|
|
print ".SH Constants\n";
|
|
|
|
foreach $parameter (@{$args{'parameterlist'}}) {
|
|
|
|
my $parameter_name = $parameter;
|
|
|
|
$parameter_name =~ s/\[.*//;
|
|
|
|
|
2009-06-09 23:50:38 +08:00
|
|
|
print ".IP \"" . $parameter . "\" 12\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
output_highlight($args{'parameterdescs'}{$parameter_name});
|
|
|
|
}
|
|
|
|
foreach $section (@{$args{'sectionlist'}}) {
|
|
|
|
print ".SH \"$section\"\n";
|
|
|
|
output_highlight($args{'sections'}{$section});
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
##
|
|
|
|
# output struct in man
|
|
|
|
sub output_struct_man(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter, $section);
|
|
|
|
|
2009-06-09 23:50:38 +08:00
|
|
|
print ".TH \"$args{'module'}\" 9 \"" . $args{'type'} . " " . $args{'struct'} . "\" \"$man_date\" \"API Manual\" LINUX\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
print ".SH NAME\n";
|
2009-06-09 23:50:38 +08:00
|
|
|
print $args{'type'} . " " . $args{'struct'} . " \\- " . $args{'purpose'} . "\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
my $declaration = $args{'definition'};
|
|
|
|
$declaration =~ s/\t/ /g;
|
|
|
|
$declaration =~ s/\n/"\n.br\n.BI \"/g;
|
2005-04-17 06:20:36 +08:00
|
|
|
print ".SH SYNOPSIS\n";
|
2009-06-09 23:50:38 +08:00
|
|
|
print $args{'type'} . " " . $args{'struct'} . " {\n.br\n";
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
print ".BI \"$declaration\n};\n.br\n\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-06-25 20:49:14 +08:00
|
|
|
print ".SH Members\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
foreach $parameter (@{$args{'parameterlist'}}) {
|
|
|
|
($parameter =~ /^#/) && next;
|
|
|
|
|
|
|
|
my $parameter_name = $parameter;
|
|
|
|
$parameter_name =~ s/\[.*//;
|
|
|
|
|
2007-05-08 15:24:39 +08:00
|
|
|
($args{'parameterdescs'}{$parameter_name} ne $undescribed) || next;
|
2009-06-09 23:50:38 +08:00
|
|
|
print ".IP \"" . $parameter . "\" 12\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
output_highlight($args{'parameterdescs'}{$parameter_name});
|
|
|
|
}
|
|
|
|
foreach $section (@{$args{'sectionlist'}}) {
|
|
|
|
print ".SH \"$section\"\n";
|
|
|
|
output_highlight($args{'sections'}{$section});
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
##
|
|
|
|
# output typedef in man
|
|
|
|
sub output_typedef_man(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter, $section);
|
|
|
|
|
|
|
|
print ".TH \"$args{'module'}\" 9 \"$args{'typedef'}\" \"$man_date\" \"API Manual\" LINUX\n";
|
|
|
|
|
|
|
|
print ".SH NAME\n";
|
2009-06-09 23:50:38 +08:00
|
|
|
print "typedef " . $args{'typedef'} . " \\- " . $args{'purpose'} . "\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
foreach $section (@{$args{'sectionlist'}}) {
|
|
|
|
print ".SH \"$section\"\n";
|
|
|
|
output_highlight($args{'sections'}{$section});
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-10-25 06:08:48 +08:00
|
|
|
sub output_blockhead_man(%) {
|
2005-04-17 06:20:36 +08:00
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter, $section);
|
|
|
|
my $count;
|
|
|
|
|
|
|
|
print ".TH \"$args{'module'}\" 9 \"$args{'module'}\" \"$man_date\" \"API Manual\" LINUX\n";
|
|
|
|
|
|
|
|
foreach $section (@{$args{'sectionlist'}}) {
|
|
|
|
print ".SH \"$section\"\n";
|
|
|
|
output_highlight($args{'sections'}{$section});
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-05-12 21:15:37 +08:00
|
|
|
##
|
|
|
|
# output in restructured text
|
|
|
|
#
|
|
|
|
|
|
|
|
#
|
|
|
|
# This could use some work; it's used to output the DOC: sections, and
|
|
|
|
# starts by putting out the name of the doc section itself, but that tends
|
|
|
|
# to duplicate a header already in the template file.
|
|
|
|
#
|
|
|
|
sub output_blockhead_rst(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter, $section);
|
|
|
|
|
|
|
|
foreach $section (@{$args{'sectionlist'}}) {
|
2020-09-29 20:23:39 +08:00
|
|
|
next if (defined($nosymbol_table{$section}));
|
|
|
|
|
2016-05-30 03:27:35 +08:00
|
|
|
if ($output_selection != OUTPUT_INCLUDE) {
|
2021-01-18 19:08:13 +08:00
|
|
|
print ".. _$section:\n\n";
|
2016-05-30 03:27:35 +08:00
|
|
|
print "**$section**\n\n";
|
|
|
|
}
|
2016-06-04 04:21:34 +08:00
|
|
|
print_lineno($section_start_lines{$section});
|
2016-05-12 21:15:37 +08:00
|
|
|
output_highlight_rst($args{'sections'}{$section});
|
|
|
|
print "\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-02-07 06:58:45 +08:00
|
|
|
#
|
|
|
|
# Apply the RST highlights to a sub-block of text.
|
2018-11-08 00:47:12 +08:00
|
|
|
#
|
2018-02-07 06:58:45 +08:00
|
|
|
sub highlight_block($) {
|
|
|
|
# The dohighlight kludge requires the text be called $contents
|
|
|
|
my $contents = shift;
|
2016-05-12 21:15:37 +08:00
|
|
|
eval $dohighlight;
|
|
|
|
die $@ if $@;
|
2018-02-07 06:58:45 +08:00
|
|
|
return $contents;
|
|
|
|
}
|
2016-05-12 21:15:37 +08:00
|
|
|
|
2018-02-07 06:58:45 +08:00
|
|
|
#
|
|
|
|
# Regexes used only here.
|
|
|
|
#
|
|
|
|
my $sphinx_literal = '^[^.].*::$';
|
|
|
|
my $sphinx_cblock = '^\.\.\ +code-block::';
|
|
|
|
|
|
|
|
sub output_highlight_rst {
|
|
|
|
my $input = join "\n",@_;
|
|
|
|
my $output = "";
|
|
|
|
my $line;
|
|
|
|
my $in_literal = 0;
|
|
|
|
my $litprefix;
|
|
|
|
my $block = "";
|
|
|
|
|
|
|
|
foreach $line (split "\n",$input) {
|
|
|
|
#
|
|
|
|
# If we're in a literal block, see if we should drop out
|
|
|
|
# of it. Otherwise pass the line straight through unmunged.
|
|
|
|
#
|
|
|
|
if ($in_literal) {
|
|
|
|
if (! ($line =~ /^\s*$/)) {
|
|
|
|
#
|
|
|
|
# If this is the first non-blank line in a literal
|
|
|
|
# block we need to figure out what the proper indent is.
|
|
|
|
#
|
|
|
|
if ($litprefix eq "") {
|
|
|
|
$line =~ /^(\s*)/;
|
|
|
|
$litprefix = '^' . $1;
|
|
|
|
$output .= $line . "\n";
|
|
|
|
} elsif (! ($line =~ /$litprefix/)) {
|
|
|
|
$in_literal = 0;
|
|
|
|
} else {
|
|
|
|
$output .= $line . "\n";
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
$output .= $line . "\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#
|
|
|
|
# Not in a literal block (or just dropped out)
|
|
|
|
#
|
|
|
|
if (! $in_literal) {
|
|
|
|
$block .= $line . "\n";
|
|
|
|
if (($line =~ /$sphinx_literal/) || ($line =~ /$sphinx_cblock/)) {
|
|
|
|
$in_literal = 1;
|
|
|
|
$litprefix = "";
|
|
|
|
$output .= highlight_block($block);
|
|
|
|
$block = ""
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($block) {
|
|
|
|
$output .= highlight_block($block);
|
|
|
|
}
|
|
|
|
foreach $line (split "\n", $output) {
|
2016-05-27 03:04:33 +08:00
|
|
|
print $lineprefix . $line . "\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
sub output_function_rst(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter, $section);
|
2016-05-26 22:18:17 +08:00
|
|
|
my $oldprefix = $lineprefix;
|
docs-rst: kernel-doc: fix typedef output in RST format
When using a typedef function like this one:
typedef bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);
The Sphinx C domain expects it to create a c:type: reference,
as that's the way it creates the type references when parsing
a c:function:: declaration.
So, a declaration like:
.. c:function:: bool v4l2_valid_dv_timings (const struct v4l2_dv_timings * t, const struct v4l2_dv_timings_cap * cap, v4l2_check_dv_timings_fnc fnc, void * fnc_handle)
Will create a cross reference for :c:type:`v4l2_check_dv_timings_fnc`.
So, when outputting such typedefs in RST format, we need to handle
this special case, as otherwise it will produce those warnings:
./include/media/v4l2-dv-timings.h:43: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:60: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:81: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
So, change the kernel-doc script to produce a RST output for the
above typedef as:
.. c:type:: v4l2_check_dv_timings_fnc
**Typedef**: timings check callback
**Syntax**
``bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);``
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-08-31 07:20:58 +08:00
|
|
|
my $start = "";
|
2020-09-30 15:47:01 +08:00
|
|
|
my $is_macro = 0;
|
docs-rst: kernel-doc: fix typedef output in RST format
When using a typedef function like this one:
typedef bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);
The Sphinx C domain expects it to create a c:type: reference,
as that's the way it creates the type references when parsing
a c:function:: declaration.
So, a declaration like:
.. c:function:: bool v4l2_valid_dv_timings (const struct v4l2_dv_timings * t, const struct v4l2_dv_timings_cap * cap, v4l2_check_dv_timings_fnc fnc, void * fnc_handle)
Will create a cross reference for :c:type:`v4l2_check_dv_timings_fnc`.
So, when outputting such typedefs in RST format, we need to handle
this special case, as otherwise it will produce those warnings:
./include/media/v4l2-dv-timings.h:43: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:60: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:81: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
So, change the kernel-doc script to produce a RST output for the
above typedef as:
.. c:type:: v4l2_check_dv_timings_fnc
**Typedef**: timings check callback
**Syntax**
``bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);``
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-08-31 07:20:58 +08:00
|
|
|
|
2020-09-25 16:05:40 +08:00
|
|
|
if ($sphinx_major < 3) {
|
|
|
|
if ($args{'typedef'}) {
|
2020-09-24 21:30:37 +08:00
|
|
|
print ".. c:type:: ". $args{'function'} . "\n\n";
|
2020-09-25 16:05:40 +08:00
|
|
|
print_lineno($declaration_start_line);
|
|
|
|
print " **Typedef**: ";
|
|
|
|
$lineprefix = "";
|
|
|
|
output_highlight_rst($args{'purpose'});
|
|
|
|
$start = "\n\n**Syntax**\n\n ``";
|
2020-09-30 15:47:01 +08:00
|
|
|
$is_macro = 1;
|
2020-09-24 21:30:37 +08:00
|
|
|
} else {
|
2020-09-25 16:05:40 +08:00
|
|
|
print ".. c:function:: ";
|
2020-09-24 21:30:37 +08:00
|
|
|
}
|
docs-rst: kernel-doc: fix typedef output in RST format
When using a typedef function like this one:
typedef bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);
The Sphinx C domain expects it to create a c:type: reference,
as that's the way it creates the type references when parsing
a c:function:: declaration.
So, a declaration like:
.. c:function:: bool v4l2_valid_dv_timings (const struct v4l2_dv_timings * t, const struct v4l2_dv_timings_cap * cap, v4l2_check_dv_timings_fnc fnc, void * fnc_handle)
Will create a cross reference for :c:type:`v4l2_check_dv_timings_fnc`.
So, when outputting such typedefs in RST format, we need to handle
this special case, as otherwise it will produce those warnings:
./include/media/v4l2-dv-timings.h:43: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:60: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:81: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
So, change the kernel-doc script to produce a RST output for the
above typedef as:
.. c:type:: v4l2_check_dv_timings_fnc
**Typedef**: timings check callback
**Syntax**
``bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);``
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-08-31 07:20:58 +08:00
|
|
|
} else {
|
2020-09-30 15:47:01 +08:00
|
|
|
if ($args{'typedef'} || $args{'functiontype'} eq "") {
|
|
|
|
$is_macro = 1;
|
|
|
|
print ".. c:macro:: ". $args{'function'} . "\n\n";
|
|
|
|
} else {
|
|
|
|
print ".. c:function:: ";
|
|
|
|
}
|
2020-09-25 16:05:40 +08:00
|
|
|
|
|
|
|
if ($args{'typedef'}) {
|
|
|
|
print_lineno($declaration_start_line);
|
|
|
|
print " **Typedef**: ";
|
|
|
|
$lineprefix = "";
|
|
|
|
output_highlight_rst($args{'purpose'});
|
|
|
|
$start = "\n\n**Syntax**\n\n ``";
|
|
|
|
} else {
|
2020-09-30 15:47:01 +08:00
|
|
|
print "``" if ($is_macro);
|
2020-09-25 16:05:40 +08:00
|
|
|
}
|
docs-rst: kernel-doc: fix typedef output in RST format
When using a typedef function like this one:
typedef bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);
The Sphinx C domain expects it to create a c:type: reference,
as that's the way it creates the type references when parsing
a c:function:: declaration.
So, a declaration like:
.. c:function:: bool v4l2_valid_dv_timings (const struct v4l2_dv_timings * t, const struct v4l2_dv_timings_cap * cap, v4l2_check_dv_timings_fnc fnc, void * fnc_handle)
Will create a cross reference for :c:type:`v4l2_check_dv_timings_fnc`.
So, when outputting such typedefs in RST format, we need to handle
this special case, as otherwise it will produce those warnings:
./include/media/v4l2-dv-timings.h:43: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:60: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:81: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
So, change the kernel-doc script to produce a RST output for the
above typedef as:
.. c:type:: v4l2_check_dv_timings_fnc
**Typedef**: timings check callback
**Syntax**
``bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);``
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-08-31 07:20:58 +08:00
|
|
|
}
|
2016-05-12 21:15:37 +08:00
|
|
|
if ($args{'functiontype'} ne "") {
|
docs-rst: kernel-doc: fix typedef output in RST format
When using a typedef function like this one:
typedef bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);
The Sphinx C domain expects it to create a c:type: reference,
as that's the way it creates the type references when parsing
a c:function:: declaration.
So, a declaration like:
.. c:function:: bool v4l2_valid_dv_timings (const struct v4l2_dv_timings * t, const struct v4l2_dv_timings_cap * cap, v4l2_check_dv_timings_fnc fnc, void * fnc_handle)
Will create a cross reference for :c:type:`v4l2_check_dv_timings_fnc`.
So, when outputting such typedefs in RST format, we need to handle
this special case, as otherwise it will produce those warnings:
./include/media/v4l2-dv-timings.h:43: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:60: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:81: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
So, change the kernel-doc script to produce a RST output for the
above typedef as:
.. c:type:: v4l2_check_dv_timings_fnc
**Typedef**: timings check callback
**Syntax**
``bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);``
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-08-31 07:20:58 +08:00
|
|
|
$start .= $args{'functiontype'} . " " . $args{'function'} . " (";
|
2016-05-12 21:15:37 +08:00
|
|
|
} else {
|
docs-rst: kernel-doc: fix typedef output in RST format
When using a typedef function like this one:
typedef bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);
The Sphinx C domain expects it to create a c:type: reference,
as that's the way it creates the type references when parsing
a c:function:: declaration.
So, a declaration like:
.. c:function:: bool v4l2_valid_dv_timings (const struct v4l2_dv_timings * t, const struct v4l2_dv_timings_cap * cap, v4l2_check_dv_timings_fnc fnc, void * fnc_handle)
Will create a cross reference for :c:type:`v4l2_check_dv_timings_fnc`.
So, when outputting such typedefs in RST format, we need to handle
this special case, as otherwise it will produce those warnings:
./include/media/v4l2-dv-timings.h:43: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:60: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:81: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
So, change the kernel-doc script to produce a RST output for the
above typedef as:
.. c:type:: v4l2_check_dv_timings_fnc
**Typedef**: timings check callback
**Syntax**
``bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);``
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-08-31 07:20:58 +08:00
|
|
|
$start .= $args{'function'} . " (";
|
2016-05-12 21:15:37 +08:00
|
|
|
}
|
|
|
|
print $start;
|
|
|
|
|
|
|
|
my $count = 0;
|
|
|
|
foreach my $parameter (@{$args{'parameterlist'}}) {
|
|
|
|
if ($count ne 0) {
|
|
|
|
print ", ";
|
|
|
|
}
|
|
|
|
$count++;
|
|
|
|
$type = $args{'parametertypes'}{$parameter};
|
doc-rst: kernel-doc: fix handling of address_space tags
The RST cpp:function handler is very pedantic: it doesn't allow any
macros like __user on it:
Documentation/media/kapi/dtv-core.rst:28: WARNING: Error when parsing function declaration.
If the function has no return type:
Error in declarator or parameters and qualifiers
Invalid definition: Expecting "(" in parameters_and_qualifiers. [error at 8]
ssize_t dvb_ringbuffer_pkt_read_user (struct dvb_ringbuffer * rbuf, size_t idx, int offset, u8 __user * buf, size_t len)
--------^
If the function has a return type:
Error in declarator or parameters and qualifiers
If pointer to member declarator:
Invalid definition: Expected '::' in pointer to member (function). [error at 37]
ssize_t dvb_ringbuffer_pkt_read_user (struct dvb_ringbuffer * rbuf, size_t idx, int offset, u8 __user * buf, size_t len)
-------------------------------------^
If declarator-id:
Invalid definition: Expecting "," or ")" in parameters_and_qualifiers, got "*". [error at 102]
ssize_t dvb_ringbuffer_pkt_read_user (struct dvb_ringbuffer * rbuf, size_t idx, int offset, u8 __user * buf, size_t len)
------------------------------------------------------------------------------------------------------^
So, we have to remove it from the function prototype.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-07-22 22:46:36 +08:00
|
|
|
|
2021-05-14 22:42:44 +08:00
|
|
|
if ($type =~ m/$function_pointer/) {
|
2016-05-12 21:15:37 +08:00
|
|
|
# pointer-to-function
|
2020-04-14 22:37:43 +08:00
|
|
|
print $1 . $parameter . ") (" . $2 . ")";
|
2016-05-12 21:15:37 +08:00
|
|
|
} else {
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
print $type;
|
2016-05-12 21:15:37 +08:00
|
|
|
}
|
|
|
|
}
|
2020-09-30 15:47:01 +08:00
|
|
|
if ($is_macro) {
|
|
|
|
print ")``\n\n";
|
docs-rst: kernel-doc: fix typedef output in RST format
When using a typedef function like this one:
typedef bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);
The Sphinx C domain expects it to create a c:type: reference,
as that's the way it creates the type references when parsing
a c:function:: declaration.
So, a declaration like:
.. c:function:: bool v4l2_valid_dv_timings (const struct v4l2_dv_timings * t, const struct v4l2_dv_timings_cap * cap, v4l2_check_dv_timings_fnc fnc, void * fnc_handle)
Will create a cross reference for :c:type:`v4l2_check_dv_timings_fnc`.
So, when outputting such typedefs in RST format, we need to handle
this special case, as otherwise it will produce those warnings:
./include/media/v4l2-dv-timings.h:43: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:60: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:81: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
So, change the kernel-doc script to produce a RST output for the
above typedef as:
.. c:type:: v4l2_check_dv_timings_fnc
**Typedef**: timings check callback
**Syntax**
``bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);``
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-08-31 07:20:58 +08:00
|
|
|
} else {
|
2020-09-30 15:47:01 +08:00
|
|
|
print ")\n\n";
|
|
|
|
}
|
|
|
|
if (!$args{'typedef'}) {
|
docs-rst: kernel-doc: fix typedef output in RST format
When using a typedef function like this one:
typedef bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);
The Sphinx C domain expects it to create a c:type: reference,
as that's the way it creates the type references when parsing
a c:function:: declaration.
So, a declaration like:
.. c:function:: bool v4l2_valid_dv_timings (const struct v4l2_dv_timings * t, const struct v4l2_dv_timings_cap * cap, v4l2_check_dv_timings_fnc fnc, void * fnc_handle)
Will create a cross reference for :c:type:`v4l2_check_dv_timings_fnc`.
So, when outputting such typedefs in RST format, we need to handle
this special case, as otherwise it will produce those warnings:
./include/media/v4l2-dv-timings.h:43: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:60: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:81: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
So, change the kernel-doc script to produce a RST output for the
above typedef as:
.. c:type:: v4l2_check_dv_timings_fnc
**Typedef**: timings check callback
**Syntax**
``bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);``
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-08-31 07:20:58 +08:00
|
|
|
print_lineno($declaration_start_line);
|
|
|
|
$lineprefix = " ";
|
|
|
|
output_highlight_rst($args{'purpose'});
|
|
|
|
print "\n";
|
|
|
|
}
|
2016-05-12 21:15:37 +08:00
|
|
|
|
2022-10-01 01:52:09 +08:00
|
|
|
#
|
|
|
|
# Put our descriptive text into a container (thus an HTML <div>) to help
|
|
|
|
# set the function prototypes apart.
|
|
|
|
#
|
|
|
|
print ".. container:: kernelindent\n\n";
|
2016-05-26 23:30:27 +08:00
|
|
|
$lineprefix = " ";
|
2022-10-01 01:52:09 +08:00
|
|
|
print $lineprefix . "**Parameters**\n\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
foreach $parameter (@{$args{'parameterlist'}}) {
|
|
|
|
my $parameter_name = $parameter;
|
2017-01-10 04:11:57 +08:00
|
|
|
$parameter_name =~ s/\[.*//;
|
2016-05-12 21:15:37 +08:00
|
|
|
$type = $args{'parametertypes'}{$parameter};
|
|
|
|
|
|
|
|
if ($type ne "") {
|
2022-10-01 01:52:09 +08:00
|
|
|
print $lineprefix . "``$type``\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
} else {
|
2022-10-01 01:52:09 +08:00
|
|
|
print $lineprefix . "``$parameter``\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
}
|
2016-06-04 04:21:34 +08:00
|
|
|
|
|
|
|
print_lineno($parameterdesc_start_lines{$parameter_name});
|
|
|
|
|
2022-10-01 01:52:09 +08:00
|
|
|
$lineprefix = " ";
|
2016-05-20 01:32:48 +08:00
|
|
|
if (defined($args{'parameterdescs'}{$parameter_name}) &&
|
|
|
|
$args{'parameterdescs'}{$parameter_name} ne $undescribed) {
|
2016-05-12 21:15:37 +08:00
|
|
|
output_highlight_rst($args{'parameterdescs'}{$parameter_name});
|
|
|
|
} else {
|
2022-10-01 01:52:09 +08:00
|
|
|
print $lineprefix . "*undescribed*\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
}
|
2022-10-01 01:52:09 +08:00
|
|
|
$lineprefix = " ";
|
2016-05-12 21:15:37 +08:00
|
|
|
print "\n";
|
|
|
|
}
|
2016-05-26 22:18:17 +08:00
|
|
|
|
2016-05-12 21:15:37 +08:00
|
|
|
output_section_rst(@_);
|
2022-10-01 01:52:09 +08:00
|
|
|
$lineprefix = $oldprefix;
|
2016-05-12 21:15:37 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
sub output_section_rst(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my $section;
|
|
|
|
my $oldprefix = $lineprefix;
|
|
|
|
|
|
|
|
foreach $section (@{$args{'sectionlist'}}) {
|
2022-10-01 01:52:09 +08:00
|
|
|
print $lineprefix . "**$section**\n\n";
|
2016-06-04 04:21:34 +08:00
|
|
|
print_lineno($section_start_lines{$section});
|
2016-05-12 21:15:37 +08:00
|
|
|
output_highlight_rst($args{'sections'}{$section});
|
|
|
|
print "\n";
|
|
|
|
}
|
|
|
|
print "\n";
|
|
|
|
}
|
|
|
|
|
|
|
|
sub output_enum_rst(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter);
|
2016-05-26 22:18:17 +08:00
|
|
|
my $oldprefix = $lineprefix;
|
2016-05-12 21:15:37 +08:00
|
|
|
my $count;
|
2022-10-01 01:52:09 +08:00
|
|
|
my $outer;
|
2016-05-12 21:15:38 +08:00
|
|
|
|
2020-09-24 21:30:37 +08:00
|
|
|
if ($sphinx_major < 3) {
|
|
|
|
my $name = "enum " . $args{'enum'};
|
|
|
|
print "\n\n.. c:type:: " . $name . "\n\n";
|
|
|
|
} else {
|
|
|
|
my $name = $args{'enum'};
|
|
|
|
print "\n\n.. c:enum:: " . $name . "\n\n";
|
|
|
|
}
|
2016-06-04 04:21:34 +08:00
|
|
|
print_lineno($declaration_start_line);
|
2022-10-01 01:52:09 +08:00
|
|
|
$lineprefix = " ";
|
2016-05-26 22:18:17 +08:00
|
|
|
output_highlight_rst($args{'purpose'});
|
|
|
|
print "\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
|
2022-10-01 01:52:09 +08:00
|
|
|
print ".. container:: kernelindent\n\n";
|
|
|
|
$outer = $lineprefix . " ";
|
|
|
|
$lineprefix = $outer . " ";
|
|
|
|
print $outer . "**Constants**\n\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
foreach $parameter (@{$args{'parameterlist'}}) {
|
2022-10-01 01:52:09 +08:00
|
|
|
print $outer . "``$parameter``\n";
|
|
|
|
|
2016-05-12 21:15:37 +08:00
|
|
|
if ($args{'parameterdescs'}{$parameter} ne $undescribed) {
|
|
|
|
output_highlight_rst($args{'parameterdescs'}{$parameter});
|
|
|
|
} else {
|
2022-10-01 01:52:09 +08:00
|
|
|
print $lineprefix . "*undescribed*\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
}
|
|
|
|
print "\n";
|
|
|
|
}
|
2022-10-01 01:52:09 +08:00
|
|
|
print "\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
$lineprefix = $oldprefix;
|
|
|
|
output_section_rst(@_);
|
|
|
|
}
|
|
|
|
|
|
|
|
sub output_typedef_rst(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter);
|
2016-05-26 22:18:17 +08:00
|
|
|
my $oldprefix = $lineprefix;
|
2020-09-24 21:30:37 +08:00
|
|
|
my $name;
|
2016-05-12 21:15:37 +08:00
|
|
|
|
2020-09-24 21:30:37 +08:00
|
|
|
if ($sphinx_major < 3) {
|
|
|
|
$name = "typedef " . $args{'typedef'};
|
|
|
|
} else {
|
|
|
|
$name = $args{'typedef'};
|
|
|
|
}
|
2016-05-12 21:15:38 +08:00
|
|
|
print "\n\n.. c:type:: " . $name . "\n\n";
|
2016-06-04 04:21:34 +08:00
|
|
|
print_lineno($declaration_start_line);
|
2016-05-26 22:18:17 +08:00
|
|
|
$lineprefix = " ";
|
|
|
|
output_highlight_rst($args{'purpose'});
|
|
|
|
print "\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
|
2016-05-26 22:18:17 +08:00
|
|
|
$lineprefix = $oldprefix;
|
2016-05-12 21:15:37 +08:00
|
|
|
output_section_rst(@_);
|
|
|
|
}
|
|
|
|
|
|
|
|
sub output_struct_rst(%) {
|
|
|
|
my %args = %{$_[0]};
|
|
|
|
my ($parameter);
|
2016-05-26 22:18:17 +08:00
|
|
|
my $oldprefix = $lineprefix;
|
2016-05-12 21:15:37 +08:00
|
|
|
|
2020-09-24 21:30:37 +08:00
|
|
|
if ($sphinx_major < 3) {
|
|
|
|
my $name = $args{'type'} . " " . $args{'struct'};
|
|
|
|
print "\n\n.. c:type:: " . $name . "\n\n";
|
|
|
|
} else {
|
|
|
|
my $name = $args{'struct'};
|
2020-10-27 17:51:05 +08:00
|
|
|
if ($args{'type'} eq 'union') {
|
|
|
|
print "\n\n.. c:union:: " . $name . "\n\n";
|
|
|
|
} else {
|
|
|
|
print "\n\n.. c:struct:: " . $name . "\n\n";
|
|
|
|
}
|
2020-09-24 21:30:37 +08:00
|
|
|
}
|
2016-06-04 04:21:34 +08:00
|
|
|
print_lineno($declaration_start_line);
|
2022-10-01 01:52:09 +08:00
|
|
|
$lineprefix = " ";
|
2016-05-26 22:18:17 +08:00
|
|
|
output_highlight_rst($args{'purpose'});
|
|
|
|
print "\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
|
2022-10-01 01:52:09 +08:00
|
|
|
print ".. container:: kernelindent\n\n";
|
|
|
|
print $lineprefix . "**Definition**::\n\n";
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
my $declaration = $args{'definition'};
|
2022-10-01 01:52:09 +08:00
|
|
|
$lineprefix = $lineprefix . " ";
|
|
|
|
$declaration =~ s/\t/$lineprefix/g;
|
|
|
|
print $lineprefix . $args{'type'} . " " . $args{'struct'} . " {\n$declaration" . $lineprefix . "};\n\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
|
2016-05-26 23:30:27 +08:00
|
|
|
$lineprefix = " ";
|
2022-10-01 01:52:09 +08:00
|
|
|
print $lineprefix . "**Members**\n\n";
|
2016-05-12 21:15:37 +08:00
|
|
|
foreach $parameter (@{$args{'parameterlist'}}) {
|
|
|
|
($parameter =~ /^#/) && next;
|
|
|
|
|
|
|
|
my $parameter_name = $parameter;
|
|
|
|
$parameter_name =~ s/\[.*//;
|
|
|
|
|
|
|
|
($args{'parameterdescs'}{$parameter_name} ne $undescribed) || next;
|
|
|
|
$type = $args{'parametertypes'}{$parameter};
|
2016-06-04 04:21:34 +08:00
|
|
|
print_lineno($parameterdesc_start_lines{$parameter_name});
|
2022-10-01 01:52:09 +08:00
|
|
|
print $lineprefix . "``" . $parameter . "``\n";
|
|
|
|
$lineprefix = " ";
|
2016-05-12 21:15:37 +08:00
|
|
|
output_highlight_rst($args{'parameterdescs'}{$parameter_name});
|
2022-10-01 01:52:09 +08:00
|
|
|
$lineprefix = " ";
|
2016-05-12 21:15:37 +08:00
|
|
|
print "\n";
|
|
|
|
}
|
|
|
|
print "\n";
|
2016-05-26 22:18:17 +08:00
|
|
|
|
|
|
|
$lineprefix = $oldprefix;
|
2016-05-12 21:15:37 +08:00
|
|
|
output_section_rst(@_);
|
|
|
|
}
|
|
|
|
|
2017-11-21 02:40:40 +08:00
|
|
|
## none mode output functions
|
|
|
|
|
|
|
|
sub output_function_none(%) {
|
|
|
|
}
|
|
|
|
|
|
|
|
sub output_enum_none(%) {
|
|
|
|
}
|
|
|
|
|
|
|
|
sub output_typedef_none(%) {
|
|
|
|
}
|
|
|
|
|
|
|
|
sub output_struct_none(%) {
|
|
|
|
}
|
|
|
|
|
|
|
|
sub output_blockhead_none(%) {
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
##
|
2006-10-11 16:22:12 +08:00
|
|
|
# generic output function for all types (function, struct/union, typedef, enum);
|
|
|
|
# calls the generated, variable output_ function name based on
|
|
|
|
# functype and output_mode
|
2005-04-17 06:20:36 +08:00
|
|
|
sub output_declaration {
|
|
|
|
no strict 'refs';
|
|
|
|
my $name = shift;
|
|
|
|
my $functype = shift;
|
|
|
|
my $func = "output_${functype}_$output_mode";
|
2020-09-29 20:23:39 +08:00
|
|
|
|
|
|
|
return if (defined($nosymbol_table{$name}));
|
|
|
|
|
2016-05-30 03:19:35 +08:00
|
|
|
if (($output_selection == OUTPUT_ALL) ||
|
|
|
|
(($output_selection == OUTPUT_INCLUDE ||
|
|
|
|
$output_selection == OUTPUT_EXPORTED) &&
|
|
|
|
defined($function_table{$name})) ||
|
2020-09-29 20:23:39 +08:00
|
|
|
($output_selection == OUTPUT_INTERNAL &&
|
2016-05-30 03:19:35 +08:00
|
|
|
!($functype eq "function" && defined($function_table{$name}))))
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-05-08 15:24:39 +08:00
|
|
|
&$func(@_);
|
2005-04-17 06:20:36 +08:00
|
|
|
$section_counter++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
##
|
2006-10-11 16:22:12 +08:00
|
|
|
# generic output function - calls the right one based on current output mode.
|
2007-10-25 06:08:48 +08:00
|
|
|
sub output_blockhead {
|
2005-04-17 06:20:36 +08:00
|
|
|
no strict 'refs';
|
2009-06-09 23:50:38 +08:00
|
|
|
my $func = "output_blockhead_" . $output_mode;
|
2005-04-17 06:20:36 +08:00
|
|
|
&$func(@_);
|
|
|
|
$section_counter++;
|
|
|
|
}
|
|
|
|
|
|
|
|
##
|
2006-02-01 19:06:58 +08:00
|
|
|
# takes a declaration (struct, union, enum, typedef) and
|
2005-04-17 06:20:36 +08:00
|
|
|
# invokes the right handler. NOT called for functions.
|
|
|
|
sub dump_declaration($$) {
|
|
|
|
no strict 'refs';
|
|
|
|
my ($prototype, $file) = @_;
|
2009-06-09 23:50:38 +08:00
|
|
|
my $func = "dump_" . $decl_type;
|
2005-04-17 06:20:36 +08:00
|
|
|
&$func(@_);
|
|
|
|
}
|
|
|
|
|
|
|
|
sub dump_union($$) {
|
|
|
|
dump_struct(@_);
|
|
|
|
}
|
|
|
|
|
|
|
|
sub dump_struct($$) {
|
|
|
|
my $x = shift;
|
|
|
|
my $file = shift;
|
2021-02-25 22:50:33 +08:00
|
|
|
my $decl_type;
|
|
|
|
my $members;
|
|
|
|
my $type = qr{struct|union};
|
|
|
|
# For capturing struct/union definition body, i.e. "{members*}qualifiers*"
|
2021-05-14 22:42:44 +08:00
|
|
|
my $qualifiers = qr{$attribute|__packed|__aligned|____cacheline_aligned_in_smp|____cacheline_aligned};
|
|
|
|
my $definition_body = qr{\{(.*)\}\s*$qualifiers*};
|
|
|
|
my $struct_members = qr{($type)([^\{\};]+)\{([^\{\}]*)\}([^\{\}\;]*)\;};
|
2021-02-25 22:50:33 +08:00
|
|
|
|
|
|
|
if ($x =~ /($type)\s+(\w+)\s*$definition_body/) {
|
|
|
|
$decl_type = $1;
|
2007-05-08 15:24:39 +08:00
|
|
|
$declaration_name = $2;
|
2021-02-25 22:50:33 +08:00
|
|
|
$members = $3;
|
|
|
|
} elsif ($x =~ /typedef\s+($type)\s*$definition_body\s*(\w+)\s*;/) {
|
|
|
|
$decl_type = $1;
|
|
|
|
$declaration_name = $3;
|
|
|
|
$members = $2;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2021-02-25 22:50:33 +08:00
|
|
|
if ($members) {
|
2021-01-14 16:04:47 +08:00
|
|
|
if ($identifier ne $declaration_name) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "expecting prototype for $decl_type $identifier. Prototype was for $decl_type $declaration_name instead\n");
|
2021-01-14 16:04:47 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2005-11-14 08:08:13 +08:00
|
|
|
# ignore members marked private:
|
2015-10-05 20:03:48 +08:00
|
|
|
$members =~ s/\/\*\s*private:.*?\/\*\s*public:.*?\*\///gosi;
|
|
|
|
$members =~ s/\/\*\s*private:.*//gosi;
|
2005-11-14 08:08:13 +08:00
|
|
|
# strip comments:
|
|
|
|
$members =~ s/\/\*.*?\*\///gos;
|
2010-03-24 04:35:14 +08:00
|
|
|
# strip attributes
|
2021-05-14 22:42:44 +08:00
|
|
|
$members =~ s/\s*$attribute/ /gi;
|
2019-09-18 03:41:45 +08:00
|
|
|
$members =~ s/\s*__aligned\s*\([^;]*\)/ /gos;
|
|
|
|
$members =~ s/\s*__packed\s*/ /gos;
|
|
|
|
$members =~ s/\s*CRYPTO_MINALIGN_ATTR/ /gos;
|
2019-09-18 03:41:46 +08:00
|
|
|
$members =~ s/\s*____cacheline_aligned_in_smp/ /gos;
|
2020-09-11 02:54:15 +08:00
|
|
|
$members =~ s/\s*____cacheline_aligned/ /gos;
|
stddef: Introduce struct_group() helper macro
Kernel code has a regular need to describe groups of members within a
structure usually when they need to be copied or initialized separately
from the rest of the surrounding structure. The generally accepted design
pattern in C is to use a named sub-struct:
struct foo {
int one;
struct {
int two;
int three, four;
} thing;
int five;
};
This would allow for traditional references and sizing:
memcpy(&dst.thing, &src.thing, sizeof(dst.thing));
However, doing this would mean that referencing struct members enclosed
by such named structs would always require including the sub-struct name
in identifiers:
do_something(dst.thing.three);
This has tended to be quite inflexible, especially when such groupings
need to be added to established code which causes huge naming churn.
Three workarounds exist in the kernel for this problem, and each have
other negative properties.
To avoid the naming churn, there is a design pattern of adding macro
aliases for the named struct:
#define f_three thing.three
This ends up polluting the global namespace, and makes it difficult to
search for identifiers.
Another common work-around in kernel code avoids the pollution by avoiding
the named struct entirely, instead identifying the group's boundaries using
either a pair of empty anonymous structs of a pair of zero-element arrays:
struct foo {
int one;
struct { } start;
int two;
int three, four;
struct { } finish;
int five;
};
struct foo {
int one;
int start[0];
int two;
int three, four;
int finish[0];
int five;
};
This allows code to avoid needing to use a sub-struct named for member
references within the surrounding structure, but loses the benefits of
being able to actually use such a struct, making it rather fragile. Using
these requires open-coded calculation of sizes and offsets. The efforts
made to avoid common mistakes include lots of comments, or adding various
BUILD_BUG_ON()s. Such code is left with no way for the compiler to reason
about the boundaries (e.g. the "start" object looks like it's 0 bytes
in length), making bounds checking depend on open-coded calculations:
if (length > offsetof(struct foo, finish) -
offsetof(struct foo, start))
return -EINVAL;
memcpy(&dst.start, &src.start, offsetof(struct foo, finish) -
offsetof(struct foo, start));
However, the vast majority of places in the kernel that operate on
groups of members do so without any identification of the grouping,
relying either on comments or implicit knowledge of the struct contents,
which is even harder for the compiler to reason about, and results in
even more fragile manual sizing, usually depending on member locations
outside of the region (e.g. to copy "two" and "three", use the start of
"four" to find the size):
BUILD_BUG_ON((offsetof(struct foo, four) <
offsetof(struct foo, two)) ||
(offsetof(struct foo, four) <
offsetof(struct foo, three));
if (length > offsetof(struct foo, four) -
offsetof(struct foo, two))
return -EINVAL;
memcpy(&dst.two, &src.two, length);
In order to have a regular programmatic way to describe a struct
region that can be used for references and sizing, can be examined for
bounds checking, avoids forcing the use of intermediate identifiers,
and avoids polluting the global namespace, introduce the struct_group()
macro. This macro wraps the member declarations to create an anonymous
union of an anonymous struct (no intermediate name) and a named struct
(for references and sizing):
struct foo {
int one;
struct_group(thing,
int two;
int three, four;
);
int five;
};
if (length > sizeof(src.thing))
return -EINVAL;
memcpy(&dst.thing, &src.thing, length);
do_something(dst.three);
There are some rare cases where the resulting struct_group() needs
attributes added, so struct_group_attr() is also introduced to allow
for specifying struct attributes (e.g. __align(x) or __packed).
Additionally, there are places where such declarations would like to
have the struct be tagged, so struct_group_tagged() is added.
Given there is a need for a handful of UAPI uses too, the underlying
__struct_group() macro has been defined in UAPI so it can be used there
too.
To avoid confusing scripts/kernel-doc, hide the macro from its struct
parsing.
Co-developed-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Keith Packard <keithp@keithp.com>
Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/lkml/20210728023217.GC35706@embeddedor
Enhanced-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Link: https://lore.kernel.org/lkml/41183a98-bdb9-4ad6-7eab-5a7292a6df84@rasmusvillemoes.dk
Enhanced-by: Dan Williams <dan.j.williams@intel.com>
Link: https://lore.kernel.org/lkml/1d9a2e6df2a9a35b2cdd50a9a68cac5991e7e5f0.camel@intel.com
Enhanced-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://lore.kernel.org/lkml/YQKa76A6XuFqgM03@phenom.ffwll.local
Acked-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
2021-05-18 11:01:15 +08:00
|
|
|
# unwrap struct_group():
|
|
|
|
# - first eat non-declaration parameters and rewrite for final match
|
|
|
|
# - then remove macro, outer parens, and trailing semicolon
|
|
|
|
$members =~ s/\bstruct_group\s*\(([^,]*,)/STRUCT_GROUP(/gos;
|
|
|
|
$members =~ s/\bstruct_group_(attr|tagged)\s*\(([^,]*,){2}/STRUCT_GROUP(/gos;
|
|
|
|
$members =~ s/\b__struct_group\s*\(([^,]*,){3}/STRUCT_GROUP(/gos;
|
|
|
|
$members =~ s/\bSTRUCT_GROUP(\(((?:(?>[^)(]+)|(?1))*)\))[^;]*;/$2/gos;
|
2020-06-23 15:09:00 +08:00
|
|
|
|
2021-05-14 22:42:44 +08:00
|
|
|
my $args = qr{([^,)]+)};
|
2015-11-08 17:52:00 +08:00
|
|
|
# replace DECLARE_BITMAP
|
2020-06-23 15:09:00 +08:00
|
|
|
$members =~ s/__ETHTOOL_DECLARE_LINK_MODE_MASK\s*\(([^\)]+)\)/DECLARE_BITMAP($1, __ETHTOOL_LINK_MODE_MASK_NBITS)/gos;
|
2021-10-30 10:11:21 +08:00
|
|
|
$members =~ s/DECLARE_PHY_INTERFACE_MASK\s*\(([^\)]+)\)/DECLARE_BITMAP($1, PHY_INTERFACE_MODE_MAX)/gos;
|
2021-05-14 22:42:44 +08:00
|
|
|
$members =~ s/DECLARE_BITMAP\s*\($args,\s*$args\)/unsigned long $1\[BITS_TO_LONGS($2)\]/gos;
|
2017-07-01 10:09:59 +08:00
|
|
|
# replace DECLARE_HASHTABLE
|
2021-05-14 22:42:44 +08:00
|
|
|
$members =~ s/DECLARE_HASHTABLE\s*\($args,\s*$args\)/unsigned long $1\[1 << (($2) - 1)\]/gos;
|
2017-12-08 22:05:12 +08:00
|
|
|
# replace DECLARE_KFIFO
|
2021-05-14 22:42:44 +08:00
|
|
|
$members =~ s/DECLARE_KFIFO\s*\($args,\s*$args,\s*$args\)/$2 \*$1/gos;
|
2017-12-08 22:05:12 +08:00
|
|
|
# replace DECLARE_KFIFO_PTR
|
2021-05-14 22:42:44 +08:00
|
|
|
$members =~ s/DECLARE_KFIFO_PTR\s*\($args,\s*$args\)/$2 \*$1/gos;
|
stddef: Introduce DECLARE_FLEX_ARRAY() helper
There are many places where kernel code wants to have several different
typed trailing flexible arrays. This would normally be done with multiple
flexible arrays in a union, but since GCC and Clang don't (on the surface)
allow this, there have been many open-coded workarounds, usually involving
neighboring 0-element arrays at the end of a structure. For example,
instead of something like this:
struct thing {
...
union {
struct type1 foo[];
struct type2 bar[];
};
};
code works around the compiler with:
struct thing {
...
struct type1 foo[0];
struct type2 bar[];
};
Another case is when a flexible array is wanted as the single member
within a struct (which itself is usually in a union). For example, this
would be worked around as:
union many {
...
struct {
struct type3 baz[0];
};
};
These kinds of work-arounds cause problems with size checks against such
zero-element arrays (for example when building with -Warray-bounds and
-Wzero-length-bounds, and with the coming FORTIFY_SOURCE improvements),
so they must all be converted to "real" flexible arrays, avoiding warnings
like this:
fs/hpfs/anode.c: In function 'hpfs_add_sector_to_btree':
fs/hpfs/anode.c:209:27: warning: array subscript 0 is outside the bounds of an interior zero-length array 'struct bplus_internal_node[0]' [-Wzero-length-bounds]
209 | anode->btree.u.internal[0].down = cpu_to_le32(a);
| ~~~~~~~~~~~~~~~~~~~~~~~^~~
In file included from fs/hpfs/hpfs_fn.h:26,
from fs/hpfs/anode.c:10:
fs/hpfs/hpfs.h:412:32: note: while referencing 'internal'
412 | struct bplus_internal_node internal[0]; /* (internal) 2-word entries giving
| ^~~~~~~~
drivers/net/can/usb/etas_es58x/es58x_fd.c: In function 'es58x_fd_tx_can_msg':
drivers/net/can/usb/etas_es58x/es58x_fd.c:360:35: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'u8[0]' {aka 'unsigned char[]'} [-Wzero-length-bounds]
360 | tx_can_msg = (typeof(tx_can_msg))&es58x_fd_urb_cmd->raw_msg[msg_len];
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/can/usb/etas_es58x/es58x_core.h:22,
from drivers/net/can/usb/etas_es58x/es58x_fd.c:17:
drivers/net/can/usb/etas_es58x/es58x_fd.h:231:6: note: while referencing 'raw_msg'
231 | u8 raw_msg[0];
| ^~~~~~~
However, it _is_ entirely possible to have one or more flexible arrays
in a struct or union: it just has to be in another struct. And since it
cannot be alone in a struct, such a struct must have at least 1 other
named member -- but that member can be zero sized. Wrap all this nonsense
into the new DECLARE_FLEX_ARRAY() in support of having flexible arrays
in unions (or alone in a struct).
As with struct_group(), since this is needed in UAPI headers as well,
implement the core there, with a non-UAPI wrapper.
Additionally update kernel-doc to understand its existence.
https://github.com/KSPP/linux/issues/137
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
2021-08-10 02:21:23 +08:00
|
|
|
# replace DECLARE_FLEX_ARRAY
|
|
|
|
$members =~ s/(?:__)?DECLARE_FLEX_ARRAY\s*\($args,\s*$args\)/$1 $2\[\]/gos;
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
my $declaration = $members;
|
|
|
|
|
|
|
|
# Split nested struct/union elements as newer ones
|
2021-05-14 22:42:44 +08:00
|
|
|
while ($members =~ m/$struct_members/) {
|
scripts: kernel-doc: improve nested logic to handle multiple identifiers
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
<code>
struct foo { int a; }; /* Just to avoid errors if compiled */
/**
* struct my_struct - a struct with nested unions and structs
* @arg1: first argument of anonymous union/anonymous struct
* @arg2: second argument of anonymous union/anonymous struct
* @arg1b: first argument of anonymous union/anonymous struct
* @arg2b: second argument of anonymous union/anonymous struct
* @arg3: third argument of anonymous union/anonymous struct
* @arg4: fourth argument of anonymous union/anonymous struct
* @bar.st1.arg1: first argument of struct st1 on union bar
* @bar.st1.arg2: second argument of struct st1 on union bar
* @bar.st1.bar1: bar1 at st1
* @bar.st1.bar2: bar2 at st1
* @bar.st2.arg1: first argument of struct st2 on union bar
* @bar.st2.arg2: second argument of struct st2 on union bar
* @bar.st3.arg2: second argument of struct st3 on union bar
* @f1: nested function on anonimous union/struct
* @bar.st2.f2: nested function on named union/struct
*/
struct my_struct {
/* Anonymous union/struct*/
union {
struct {
char arg1 : 1;
char arg2 : 3;
};
struct {
int arg1b;
int arg2b;
};
struct {
void *arg3;
int arg4;
int (*f1)(char foo, int bar);
};
};
union {
struct {
int arg1;
int arg2;
struct foo bar1, *bar2;
} st1; /* bar.st1 is undocumented, cause a warning */
struct {
void *arg1; /* bar.st3.arg1 is undocumented, cause a warning */
int arg2;
int (*f2)(char foo, int bar); /* bar.st3.fn2 is undocumented, cause a warning */
} st2, st3, *st4;
int (*f3)(char foo, int bar); /* f3 is undocumented, cause a warning */
} bar; /* bar is undocumented, cause a warning */
/* private: */
int undoc_privat; /* is undocumented but private, no warning */
/* public: */
int undoc_public; /* is undocumented, cause a warning */
};
</code>
It produces the following warnings, as expected:
test2.h:57: warning: Function parameter or member 'bar' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.f3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'undoc_public' not described in 'my_struct'
Suggested-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:17 +08:00
|
|
|
my $newmember;
|
|
|
|
my $maintype = $1;
|
|
|
|
my $ids = $4;
|
|
|
|
my $content = $3;
|
|
|
|
foreach my $id(split /,/, $ids) {
|
|
|
|
$newmember .= "$maintype $id; ";
|
|
|
|
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
$id =~ s/[:\[].*//;
|
scripts: kernel-doc: improve nested logic to handle multiple identifiers
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
<code>
struct foo { int a; }; /* Just to avoid errors if compiled */
/**
* struct my_struct - a struct with nested unions and structs
* @arg1: first argument of anonymous union/anonymous struct
* @arg2: second argument of anonymous union/anonymous struct
* @arg1b: first argument of anonymous union/anonymous struct
* @arg2b: second argument of anonymous union/anonymous struct
* @arg3: third argument of anonymous union/anonymous struct
* @arg4: fourth argument of anonymous union/anonymous struct
* @bar.st1.arg1: first argument of struct st1 on union bar
* @bar.st1.arg2: second argument of struct st1 on union bar
* @bar.st1.bar1: bar1 at st1
* @bar.st1.bar2: bar2 at st1
* @bar.st2.arg1: first argument of struct st2 on union bar
* @bar.st2.arg2: second argument of struct st2 on union bar
* @bar.st3.arg2: second argument of struct st3 on union bar
* @f1: nested function on anonimous union/struct
* @bar.st2.f2: nested function on named union/struct
*/
struct my_struct {
/* Anonymous union/struct*/
union {
struct {
char arg1 : 1;
char arg2 : 3;
};
struct {
int arg1b;
int arg2b;
};
struct {
void *arg3;
int arg4;
int (*f1)(char foo, int bar);
};
};
union {
struct {
int arg1;
int arg2;
struct foo bar1, *bar2;
} st1; /* bar.st1 is undocumented, cause a warning */
struct {
void *arg1; /* bar.st3.arg1 is undocumented, cause a warning */
int arg2;
int (*f2)(char foo, int bar); /* bar.st3.fn2 is undocumented, cause a warning */
} st2, st3, *st4;
int (*f3)(char foo, int bar); /* f3 is undocumented, cause a warning */
} bar; /* bar is undocumented, cause a warning */
/* private: */
int undoc_privat; /* is undocumented but private, no warning */
/* public: */
int undoc_public; /* is undocumented, cause a warning */
};
</code>
It produces the following warnings, as expected:
test2.h:57: warning: Function parameter or member 'bar' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.f3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'undoc_public' not described in 'my_struct'
Suggested-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:17 +08:00
|
|
|
$id =~ s/^\s*\**(\S+)\s*/$1/;
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
foreach my $arg (split /;/, $content) {
|
|
|
|
next if ($arg =~ m/^\s*$/);
|
2017-12-18 20:30:16 +08:00
|
|
|
if ($arg =~ m/^([^\(]+\(\*?\s*)([\w\.]*)(\s*\).*)/) {
|
|
|
|
# pointer-to-function
|
|
|
|
my $type = $1;
|
|
|
|
my $name = $2;
|
|
|
|
my $extra = $3;
|
|
|
|
next if (!$name);
|
|
|
|
if ($id =~ m/^\s*$/) {
|
|
|
|
# anonymous struct/union
|
scripts: kernel-doc: improve nested logic to handle multiple identifiers
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
<code>
struct foo { int a; }; /* Just to avoid errors if compiled */
/**
* struct my_struct - a struct with nested unions and structs
* @arg1: first argument of anonymous union/anonymous struct
* @arg2: second argument of anonymous union/anonymous struct
* @arg1b: first argument of anonymous union/anonymous struct
* @arg2b: second argument of anonymous union/anonymous struct
* @arg3: third argument of anonymous union/anonymous struct
* @arg4: fourth argument of anonymous union/anonymous struct
* @bar.st1.arg1: first argument of struct st1 on union bar
* @bar.st1.arg2: second argument of struct st1 on union bar
* @bar.st1.bar1: bar1 at st1
* @bar.st1.bar2: bar2 at st1
* @bar.st2.arg1: first argument of struct st2 on union bar
* @bar.st2.arg2: second argument of struct st2 on union bar
* @bar.st3.arg2: second argument of struct st3 on union bar
* @f1: nested function on anonimous union/struct
* @bar.st2.f2: nested function on named union/struct
*/
struct my_struct {
/* Anonymous union/struct*/
union {
struct {
char arg1 : 1;
char arg2 : 3;
};
struct {
int arg1b;
int arg2b;
};
struct {
void *arg3;
int arg4;
int (*f1)(char foo, int bar);
};
};
union {
struct {
int arg1;
int arg2;
struct foo bar1, *bar2;
} st1; /* bar.st1 is undocumented, cause a warning */
struct {
void *arg1; /* bar.st3.arg1 is undocumented, cause a warning */
int arg2;
int (*f2)(char foo, int bar); /* bar.st3.fn2 is undocumented, cause a warning */
} st2, st3, *st4;
int (*f3)(char foo, int bar); /* f3 is undocumented, cause a warning */
} bar; /* bar is undocumented, cause a warning */
/* private: */
int undoc_privat; /* is undocumented but private, no warning */
/* public: */
int undoc_public; /* is undocumented, cause a warning */
};
</code>
It produces the following warnings, as expected:
test2.h:57: warning: Function parameter or member 'bar' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.f3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'undoc_public' not described in 'my_struct'
Suggested-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:17 +08:00
|
|
|
$newmember .= "$type$name$extra; ";
|
2017-12-18 20:30:16 +08:00
|
|
|
} else {
|
scripts: kernel-doc: improve nested logic to handle multiple identifiers
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
<code>
struct foo { int a; }; /* Just to avoid errors if compiled */
/**
* struct my_struct - a struct with nested unions and structs
* @arg1: first argument of anonymous union/anonymous struct
* @arg2: second argument of anonymous union/anonymous struct
* @arg1b: first argument of anonymous union/anonymous struct
* @arg2b: second argument of anonymous union/anonymous struct
* @arg3: third argument of anonymous union/anonymous struct
* @arg4: fourth argument of anonymous union/anonymous struct
* @bar.st1.arg1: first argument of struct st1 on union bar
* @bar.st1.arg2: second argument of struct st1 on union bar
* @bar.st1.bar1: bar1 at st1
* @bar.st1.bar2: bar2 at st1
* @bar.st2.arg1: first argument of struct st2 on union bar
* @bar.st2.arg2: second argument of struct st2 on union bar
* @bar.st3.arg2: second argument of struct st3 on union bar
* @f1: nested function on anonimous union/struct
* @bar.st2.f2: nested function on named union/struct
*/
struct my_struct {
/* Anonymous union/struct*/
union {
struct {
char arg1 : 1;
char arg2 : 3;
};
struct {
int arg1b;
int arg2b;
};
struct {
void *arg3;
int arg4;
int (*f1)(char foo, int bar);
};
};
union {
struct {
int arg1;
int arg2;
struct foo bar1, *bar2;
} st1; /* bar.st1 is undocumented, cause a warning */
struct {
void *arg1; /* bar.st3.arg1 is undocumented, cause a warning */
int arg2;
int (*f2)(char foo, int bar); /* bar.st3.fn2 is undocumented, cause a warning */
} st2, st3, *st4;
int (*f3)(char foo, int bar); /* f3 is undocumented, cause a warning */
} bar; /* bar is undocumented, cause a warning */
/* private: */
int undoc_privat; /* is undocumented but private, no warning */
/* public: */
int undoc_public; /* is undocumented, cause a warning */
};
</code>
It produces the following warnings, as expected:
test2.h:57: warning: Function parameter or member 'bar' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.f3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'undoc_public' not described in 'my_struct'
Suggested-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:17 +08:00
|
|
|
$newmember .= "$type$id.$name$extra; ";
|
2017-12-18 20:30:16 +08:00
|
|
|
}
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
} else {
|
scripts: kernel-doc: improve nested logic to handle multiple identifiers
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
<code>
struct foo { int a; }; /* Just to avoid errors if compiled */
/**
* struct my_struct - a struct with nested unions and structs
* @arg1: first argument of anonymous union/anonymous struct
* @arg2: second argument of anonymous union/anonymous struct
* @arg1b: first argument of anonymous union/anonymous struct
* @arg2b: second argument of anonymous union/anonymous struct
* @arg3: third argument of anonymous union/anonymous struct
* @arg4: fourth argument of anonymous union/anonymous struct
* @bar.st1.arg1: first argument of struct st1 on union bar
* @bar.st1.arg2: second argument of struct st1 on union bar
* @bar.st1.bar1: bar1 at st1
* @bar.st1.bar2: bar2 at st1
* @bar.st2.arg1: first argument of struct st2 on union bar
* @bar.st2.arg2: second argument of struct st2 on union bar
* @bar.st3.arg2: second argument of struct st3 on union bar
* @f1: nested function on anonimous union/struct
* @bar.st2.f2: nested function on named union/struct
*/
struct my_struct {
/* Anonymous union/struct*/
union {
struct {
char arg1 : 1;
char arg2 : 3;
};
struct {
int arg1b;
int arg2b;
};
struct {
void *arg3;
int arg4;
int (*f1)(char foo, int bar);
};
};
union {
struct {
int arg1;
int arg2;
struct foo bar1, *bar2;
} st1; /* bar.st1 is undocumented, cause a warning */
struct {
void *arg1; /* bar.st3.arg1 is undocumented, cause a warning */
int arg2;
int (*f2)(char foo, int bar); /* bar.st3.fn2 is undocumented, cause a warning */
} st2, st3, *st4;
int (*f3)(char foo, int bar); /* f3 is undocumented, cause a warning */
} bar; /* bar is undocumented, cause a warning */
/* private: */
int undoc_privat; /* is undocumented but private, no warning */
/* public: */
int undoc_public; /* is undocumented, cause a warning */
};
</code>
It produces the following warnings, as expected:
test2.h:57: warning: Function parameter or member 'bar' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.f3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'undoc_public' not described in 'my_struct'
Suggested-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:17 +08:00
|
|
|
my $type;
|
|
|
|
my $names;
|
|
|
|
$arg =~ s/^\s+//;
|
|
|
|
$arg =~ s/\s+$//;
|
|
|
|
# Handle bitmaps
|
|
|
|
$arg =~ s/:\s*\d+\s*//g;
|
|
|
|
# Handle arrays
|
2018-03-29 22:58:59 +08:00
|
|
|
$arg =~ s/\[.*\]//g;
|
scripts: kernel-doc: improve nested logic to handle multiple identifiers
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
<code>
struct foo { int a; }; /* Just to avoid errors if compiled */
/**
* struct my_struct - a struct with nested unions and structs
* @arg1: first argument of anonymous union/anonymous struct
* @arg2: second argument of anonymous union/anonymous struct
* @arg1b: first argument of anonymous union/anonymous struct
* @arg2b: second argument of anonymous union/anonymous struct
* @arg3: third argument of anonymous union/anonymous struct
* @arg4: fourth argument of anonymous union/anonymous struct
* @bar.st1.arg1: first argument of struct st1 on union bar
* @bar.st1.arg2: second argument of struct st1 on union bar
* @bar.st1.bar1: bar1 at st1
* @bar.st1.bar2: bar2 at st1
* @bar.st2.arg1: first argument of struct st2 on union bar
* @bar.st2.arg2: second argument of struct st2 on union bar
* @bar.st3.arg2: second argument of struct st3 on union bar
* @f1: nested function on anonimous union/struct
* @bar.st2.f2: nested function on named union/struct
*/
struct my_struct {
/* Anonymous union/struct*/
union {
struct {
char arg1 : 1;
char arg2 : 3;
};
struct {
int arg1b;
int arg2b;
};
struct {
void *arg3;
int arg4;
int (*f1)(char foo, int bar);
};
};
union {
struct {
int arg1;
int arg2;
struct foo bar1, *bar2;
} st1; /* bar.st1 is undocumented, cause a warning */
struct {
void *arg1; /* bar.st3.arg1 is undocumented, cause a warning */
int arg2;
int (*f2)(char foo, int bar); /* bar.st3.fn2 is undocumented, cause a warning */
} st2, st3, *st4;
int (*f3)(char foo, int bar); /* f3 is undocumented, cause a warning */
} bar; /* bar is undocumented, cause a warning */
/* private: */
int undoc_privat; /* is undocumented but private, no warning */
/* public: */
int undoc_public; /* is undocumented, cause a warning */
};
</code>
It produces the following warnings, as expected:
test2.h:57: warning: Function parameter or member 'bar' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.f3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'undoc_public' not described in 'my_struct'
Suggested-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:17 +08:00
|
|
|
# The type may have multiple words,
|
|
|
|
# and multiple IDs can be defined, like:
|
|
|
|
# const struct foo, *bar, foobar
|
|
|
|
# So, we remove spaces when parsing the
|
|
|
|
# names, in order to match just names
|
|
|
|
# and commas for the names
|
|
|
|
$arg =~ s/\s*,\s*/,/g;
|
|
|
|
if ($arg =~ m/(.*)\s+([\S+,]+)/) {
|
|
|
|
$type = $1;
|
|
|
|
$names = $2;
|
2017-12-18 20:30:16 +08:00
|
|
|
} else {
|
scripts: kernel-doc: improve nested logic to handle multiple identifiers
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
<code>
struct foo { int a; }; /* Just to avoid errors if compiled */
/**
* struct my_struct - a struct with nested unions and structs
* @arg1: first argument of anonymous union/anonymous struct
* @arg2: second argument of anonymous union/anonymous struct
* @arg1b: first argument of anonymous union/anonymous struct
* @arg2b: second argument of anonymous union/anonymous struct
* @arg3: third argument of anonymous union/anonymous struct
* @arg4: fourth argument of anonymous union/anonymous struct
* @bar.st1.arg1: first argument of struct st1 on union bar
* @bar.st1.arg2: second argument of struct st1 on union bar
* @bar.st1.bar1: bar1 at st1
* @bar.st1.bar2: bar2 at st1
* @bar.st2.arg1: first argument of struct st2 on union bar
* @bar.st2.arg2: second argument of struct st2 on union bar
* @bar.st3.arg2: second argument of struct st3 on union bar
* @f1: nested function on anonimous union/struct
* @bar.st2.f2: nested function on named union/struct
*/
struct my_struct {
/* Anonymous union/struct*/
union {
struct {
char arg1 : 1;
char arg2 : 3;
};
struct {
int arg1b;
int arg2b;
};
struct {
void *arg3;
int arg4;
int (*f1)(char foo, int bar);
};
};
union {
struct {
int arg1;
int arg2;
struct foo bar1, *bar2;
} st1; /* bar.st1 is undocumented, cause a warning */
struct {
void *arg1; /* bar.st3.arg1 is undocumented, cause a warning */
int arg2;
int (*f2)(char foo, int bar); /* bar.st3.fn2 is undocumented, cause a warning */
} st2, st3, *st4;
int (*f3)(char foo, int bar); /* f3 is undocumented, cause a warning */
} bar; /* bar is undocumented, cause a warning */
/* private: */
int undoc_privat; /* is undocumented but private, no warning */
/* public: */
int undoc_public; /* is undocumented, cause a warning */
};
</code>
It produces the following warnings, as expected:
test2.h:57: warning: Function parameter or member 'bar' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.f3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'undoc_public' not described in 'my_struct'
Suggested-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:17 +08:00
|
|
|
$newmember .= "$arg; ";
|
|
|
|
next;
|
|
|
|
}
|
|
|
|
foreach my $name (split /,/, $names) {
|
|
|
|
$name =~ s/^\s*\**(\S+)\s*/$1/;
|
|
|
|
next if (($name =~ m/^\s*$/));
|
|
|
|
if ($id =~ m/^\s*$/) {
|
|
|
|
# anonymous struct/union
|
|
|
|
$newmember .= "$type $name; ";
|
|
|
|
} else {
|
|
|
|
$newmember .= "$type $id.$name; ";
|
|
|
|
}
|
2017-12-18 20:30:16 +08:00
|
|
|
}
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
}
|
|
|
|
}
|
scripts: kernel-doc: improve nested logic to handle multiple identifiers
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
<code>
struct foo { int a; }; /* Just to avoid errors if compiled */
/**
* struct my_struct - a struct with nested unions and structs
* @arg1: first argument of anonymous union/anonymous struct
* @arg2: second argument of anonymous union/anonymous struct
* @arg1b: first argument of anonymous union/anonymous struct
* @arg2b: second argument of anonymous union/anonymous struct
* @arg3: third argument of anonymous union/anonymous struct
* @arg4: fourth argument of anonymous union/anonymous struct
* @bar.st1.arg1: first argument of struct st1 on union bar
* @bar.st1.arg2: second argument of struct st1 on union bar
* @bar.st1.bar1: bar1 at st1
* @bar.st1.bar2: bar2 at st1
* @bar.st2.arg1: first argument of struct st2 on union bar
* @bar.st2.arg2: second argument of struct st2 on union bar
* @bar.st3.arg2: second argument of struct st3 on union bar
* @f1: nested function on anonimous union/struct
* @bar.st2.f2: nested function on named union/struct
*/
struct my_struct {
/* Anonymous union/struct*/
union {
struct {
char arg1 : 1;
char arg2 : 3;
};
struct {
int arg1b;
int arg2b;
};
struct {
void *arg3;
int arg4;
int (*f1)(char foo, int bar);
};
};
union {
struct {
int arg1;
int arg2;
struct foo bar1, *bar2;
} st1; /* bar.st1 is undocumented, cause a warning */
struct {
void *arg1; /* bar.st3.arg1 is undocumented, cause a warning */
int arg2;
int (*f2)(char foo, int bar); /* bar.st3.fn2 is undocumented, cause a warning */
} st2, st3, *st4;
int (*f3)(char foo, int bar); /* f3 is undocumented, cause a warning */
} bar; /* bar is undocumented, cause a warning */
/* private: */
int undoc_privat; /* is undocumented but private, no warning */
/* public: */
int undoc_public; /* is undocumented, cause a warning */
};
</code>
It produces the following warnings, as expected:
test2.h:57: warning: Function parameter or member 'bar' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.f3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'undoc_public' not described in 'my_struct'
Suggested-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:17 +08:00
|
|
|
}
|
2021-05-14 22:42:44 +08:00
|
|
|
$members =~ s/$struct_members/$newmember/;
|
scripts: kernel-doc: improve nested logic to handle multiple identifiers
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
<code>
struct foo { int a; }; /* Just to avoid errors if compiled */
/**
* struct my_struct - a struct with nested unions and structs
* @arg1: first argument of anonymous union/anonymous struct
* @arg2: second argument of anonymous union/anonymous struct
* @arg1b: first argument of anonymous union/anonymous struct
* @arg2b: second argument of anonymous union/anonymous struct
* @arg3: third argument of anonymous union/anonymous struct
* @arg4: fourth argument of anonymous union/anonymous struct
* @bar.st1.arg1: first argument of struct st1 on union bar
* @bar.st1.arg2: second argument of struct st1 on union bar
* @bar.st1.bar1: bar1 at st1
* @bar.st1.bar2: bar2 at st1
* @bar.st2.arg1: first argument of struct st2 on union bar
* @bar.st2.arg2: second argument of struct st2 on union bar
* @bar.st3.arg2: second argument of struct st3 on union bar
* @f1: nested function on anonimous union/struct
* @bar.st2.f2: nested function on named union/struct
*/
struct my_struct {
/* Anonymous union/struct*/
union {
struct {
char arg1 : 1;
char arg2 : 3;
};
struct {
int arg1b;
int arg2b;
};
struct {
void *arg3;
int arg4;
int (*f1)(char foo, int bar);
};
};
union {
struct {
int arg1;
int arg2;
struct foo bar1, *bar2;
} st1; /* bar.st1 is undocumented, cause a warning */
struct {
void *arg1; /* bar.st3.arg1 is undocumented, cause a warning */
int arg2;
int (*f2)(char foo, int bar); /* bar.st3.fn2 is undocumented, cause a warning */
} st2, st3, *st4;
int (*f3)(char foo, int bar); /* f3 is undocumented, cause a warning */
} bar; /* bar is undocumented, cause a warning */
/* private: */
int undoc_privat; /* is undocumented but private, no warning */
/* public: */
int undoc_public; /* is undocumented, cause a warning */
};
</code>
It produces the following warnings, as expected:
test2.h:57: warning: Function parameter or member 'bar' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st3.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg1' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.arg2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.st4.f2' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'bar.f3' not described in 'my_struct'
test2.h:57: warning: Function parameter or member 'undoc_public' not described in 'my_struct'
Suggested-by: Markus Heiser <markus.heiser@darmarit.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:17 +08:00
|
|
|
}
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
|
|
|
|
# Ignore other nested elements, like enums
|
2018-08-06 00:41:09 +08:00
|
|
|
$members =~ s/(\{[^\{\}]*\})//g;
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
|
scripts: kernel-doc: print the declaration name on warnings
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code,
it will never print anything. I suspect that originally
it was using the second argument of output_declaration().
I opted to not rely on a globally defined $declaration_name,
but, instead, to pass it explicitly as a parameter.
While here, I removed a unaligned check for !$anon_struct_union.
This is not needed, as, if $anon_struct_union is not zero,
$parameterdescs{$param} will be defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:15 +08:00
|
|
|
create_parameterlist($members, ';', $file, $declaration_name);
|
2017-12-18 20:30:14 +08:00
|
|
|
check_sections($file, $declaration_name, $decl_type, $sectcheck, $struct_actual);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
# Adjust declaration for better display
|
2018-08-06 00:41:09 +08:00
|
|
|
$declaration =~ s/([\{;])/$1\n/g;
|
|
|
|
$declaration =~ s/\}\s+;/};/g;
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
# Better handle inlined enums
|
2018-08-06 00:41:09 +08:00
|
|
|
do {} while ($declaration =~ s/(enum\s+\{[^\}]+),([^\n])/$1,\n$2/);
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
|
|
|
|
my @def_args = split /\n/, $declaration;
|
|
|
|
my $level = 1;
|
|
|
|
$declaration = "";
|
|
|
|
foreach my $clause (@def_args) {
|
|
|
|
$clause =~ s/^\s+//;
|
|
|
|
$clause =~ s/\s+$//;
|
|
|
|
$clause =~ s/\s+/ /;
|
|
|
|
next if (!$clause);
|
2018-08-06 00:41:09 +08:00
|
|
|
$level-- if ($clause =~ m/(\})/ && $level > 1);
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
if (!($clause =~ m/^\s*#/)) {
|
|
|
|
$declaration .= "\t" x $level;
|
|
|
|
}
|
|
|
|
$declaration .= "\t" . $clause . "\n";
|
2018-08-06 00:41:09 +08:00
|
|
|
$level++ if ($clause =~ m/(\{)/ && !($clause =~m/\}/));
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
output_declaration($declaration_name,
|
|
|
|
'struct',
|
|
|
|
{'struct' => $declaration_name,
|
|
|
|
'module' => $modulename,
|
scripts: kernel-doc: parse next structs/unions
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
CGU_CLK_MUX_GLITCHFREE = BIT(4),
CGU_CLK_DIV = BIT(5),
CGU_CLK_FIXDIV = BIT(6),
CGU_CLK_CUSTOM = BIT(7),
} type;
int parents[4];
union {
struct ingenic_cgu_pll_info pll;
struct {
struct ingenic_cgu_gate_info gate;
struct ingenic_cgu_mux_info mux;
struct ingenic_cgu_div_info div;
struct ingenic_cgu_fixdiv_info fixdiv;
};
struct ingenic_cgu_custom_info custom;
};
};
Currently, such struct is documented as:
**Definition**
::
struct ingenic_cgu_clk_info {
const char * name;
};
**Members**
``name``
name of the clock
With is obvioulsy wrong. It also generates an error:
drivers/clk/ingenic/cgu.h:169: warning: No description found for parameter 'enum'
However, there's nothing wrong with this kernel-doc markup: everything
is documented there.
It makes sense to document all fields there. So, add a
way for the core to parse those structs.
With this patch, all documented fields will properly generate
documentation.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:13 +08:00
|
|
|
'definition' => $declaration,
|
2005-04-17 06:20:36 +08:00
|
|
|
'parameterlist' => \@parameterlist,
|
|
|
|
'parameterdescs' => \%parameterdescs,
|
|
|
|
'parametertypes' => \%parametertypes,
|
|
|
|
'sectionlist' => \@sectionlist,
|
|
|
|
'sections' => \%sections,
|
|
|
|
'purpose' => $declaration_purpose,
|
|
|
|
'type' => $decl_type
|
|
|
|
});
|
|
|
|
}
|
|
|
|
else {
|
2015-09-05 06:43:21 +08:00
|
|
|
print STDERR "${file}:$.: error: Cannot parse struct or union!\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
++$errors;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-12-31 08:32:55 +08:00
|
|
|
|
|
|
|
sub show_warnings($$) {
|
|
|
|
my $functype = shift;
|
|
|
|
my $name = shift;
|
|
|
|
|
2020-09-29 20:23:39 +08:00
|
|
|
return 0 if (defined($nosymbol_table{$name}));
|
|
|
|
|
2017-12-31 08:32:55 +08:00
|
|
|
return 1 if ($output_selection == OUTPUT_ALL);
|
|
|
|
|
|
|
|
if ($output_selection == OUTPUT_EXPORTED) {
|
|
|
|
if (defined($function_table{$name})) {
|
|
|
|
return 1;
|
|
|
|
} else {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if ($output_selection == OUTPUT_INTERNAL) {
|
|
|
|
if (!($functype eq "function" && defined($function_table{$name}))) {
|
|
|
|
return 1;
|
|
|
|
} else {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if ($output_selection == OUTPUT_INCLUDE) {
|
|
|
|
if (defined($function_table{$name})) {
|
|
|
|
return 1;
|
|
|
|
} else {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
die("Please add the new output type at show_warnings()");
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
sub dump_enum($$) {
|
|
|
|
my $x = shift;
|
|
|
|
my $file = shift;
|
2020-10-01 14:23:52 +08:00
|
|
|
my $members;
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2005-11-14 08:08:13 +08:00
|
|
|
$x =~ s@/\*.*?\*/@@gos; # strip comments.
|
2015-11-08 17:48:05 +08:00
|
|
|
# strip #define macros inside enums
|
|
|
|
$x =~ s@#\s*((define|ifdef)\s+|endif)[^;]*;@@gos;
|
2010-08-11 09:02:50 +08:00
|
|
|
|
2020-10-01 14:23:52 +08:00
|
|
|
if ($x =~ /typedef\s+enum\s*\{(.*)\}\s*(\w*)\s*;/) {
|
|
|
|
$declaration_name = $2;
|
|
|
|
$members = $1;
|
|
|
|
} elsif ($x =~ /enum\s+(\w*)\s*\{(.*)\}/) {
|
2007-05-08 15:24:39 +08:00
|
|
|
$declaration_name = $1;
|
2020-10-01 14:23:52 +08:00
|
|
|
$members = $2;
|
|
|
|
}
|
|
|
|
|
2020-11-03 01:06:37 +08:00
|
|
|
if ($members) {
|
2021-01-14 16:04:47 +08:00
|
|
|
if ($identifier ne $declaration_name) {
|
2021-03-03 16:42:14 +08:00
|
|
|
if ($identifier eq "") {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "wrong kernel-doc identifier on line:\n");
|
2021-03-03 16:42:14 +08:00
|
|
|
} else {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "expecting prototype for enum $identifier. Prototype was for enum $declaration_name instead\n");
|
2021-03-03 16:42:14 +08:00
|
|
|
}
|
2021-01-14 16:04:47 +08:00
|
|
|
return;
|
|
|
|
}
|
2021-03-03 16:42:14 +08:00
|
|
|
$declaration_name = "(anonymous)" if ($declaration_name eq "");
|
2021-01-14 16:04:47 +08:00
|
|
|
|
2017-09-19 19:08:13 +08:00
|
|
|
my %_members;
|
|
|
|
|
2017-06-17 03:27:48 +08:00
|
|
|
$members =~ s/\s+$//;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
foreach my $arg (split ',', $members) {
|
|
|
|
$arg =~ s/^\s*(\w+).*/$1/;
|
|
|
|
push @parameterlist, $arg;
|
|
|
|
if (!$parameterdescs{$arg}) {
|
2007-05-08 15:24:39 +08:00
|
|
|
$parameterdescs{$arg} = $undescribed;
|
2017-12-31 08:32:55 +08:00
|
|
|
if (show_warnings("enum", $declaration_name)) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "Enum value '$arg' not described in enum '$declaration_name'\n");
|
2017-12-18 20:30:18 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2017-09-19 19:08:13 +08:00
|
|
|
$_members{$arg} = 1;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2006-02-01 19:06:58 +08:00
|
|
|
|
2017-09-19 19:08:13 +08:00
|
|
|
while (my ($k, $v) = each %parameterdescs) {
|
|
|
|
if (!exists($_members{$k})) {
|
2017-12-31 08:32:55 +08:00
|
|
|
if (show_warnings("enum", $declaration_name)) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "Excess enum value '$k' description in '$declaration_name'\n");
|
2017-12-18 20:30:18 +08:00
|
|
|
}
|
2017-09-19 19:08:13 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
output_declaration($declaration_name,
|
|
|
|
'enum',
|
|
|
|
{'enum' => $declaration_name,
|
|
|
|
'module' => $modulename,
|
|
|
|
'parameterlist' => \@parameterlist,
|
|
|
|
'parameterdescs' => \%parameterdescs,
|
|
|
|
'sectionlist' => \@sectionlist,
|
|
|
|
'sections' => \%sections,
|
|
|
|
'purpose' => $declaration_purpose
|
|
|
|
});
|
2020-10-01 14:23:52 +08:00
|
|
|
} else {
|
2015-09-05 06:43:21 +08:00
|
|
|
print STDERR "${file}:$.: error: Cannot parse enum!\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
++$errors;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-12-02 16:17:32 +08:00
|
|
|
my $typedef_type = qr { ((?:\s+[\w\*]+\b){1,8})\s* }x;
|
2020-10-27 18:20:37 +08:00
|
|
|
my $typedef_ident = qr { \*?\s*(\w\S+)\s* }x;
|
|
|
|
my $typedef_args = qr { \s*\((.*)\); }x;
|
|
|
|
|
|
|
|
my $typedef1 = qr { typedef$typedef_type\($typedef_ident\)$typedef_args }x;
|
|
|
|
my $typedef2 = qr { typedef$typedef_type$typedef_ident$typedef_args }x;
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
sub dump_typedef($$) {
|
|
|
|
my $x = shift;
|
|
|
|
my $file = shift;
|
|
|
|
|
2005-11-14 08:08:13 +08:00
|
|
|
$x =~ s@/\*.*?\*/@@gos; # strip comments.
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-10-27 18:20:37 +08:00
|
|
|
# Parse function typedef prototypes
|
|
|
|
if ($x =~ $typedef1 || $x =~ $typedef2) {
|
2015-10-09 03:14:45 +08:00
|
|
|
$return_type = $1;
|
|
|
|
$declaration_name = $2;
|
|
|
|
my $args = $3;
|
2020-10-27 18:20:36 +08:00
|
|
|
$return_type =~ s/^\s+//;
|
2015-10-09 03:14:45 +08:00
|
|
|
|
2021-01-14 16:04:47 +08:00
|
|
|
if ($identifier ne $declaration_name) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "expecting prototype for typedef $identifier. Prototype was for typedef $declaration_name instead\n");
|
2021-01-14 16:04:47 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
scripts: kernel-doc: print the declaration name on warnings
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code,
it will never print anything. I suspect that originally
it was using the second argument of output_declaration().
I opted to not rely on a globally defined $declaration_name,
but, instead, to pass it explicitly as a parameter.
While here, I removed a unaligned check for !$anon_struct_union.
This is not needed, as, if $anon_struct_union is not zero,
$parameterdescs{$param} will be defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:15 +08:00
|
|
|
create_parameterlist($args, ',', $file, $declaration_name);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
output_declaration($declaration_name,
|
2015-10-09 03:14:45 +08:00
|
|
|
'function',
|
|
|
|
{'function' => $declaration_name,
|
docs-rst: kernel-doc: fix typedef output in RST format
When using a typedef function like this one:
typedef bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);
The Sphinx C domain expects it to create a c:type: reference,
as that's the way it creates the type references when parsing
a c:function:: declaration.
So, a declaration like:
.. c:function:: bool v4l2_valid_dv_timings (const struct v4l2_dv_timings * t, const struct v4l2_dv_timings_cap * cap, v4l2_check_dv_timings_fnc fnc, void * fnc_handle)
Will create a cross reference for :c:type:`v4l2_check_dv_timings_fnc`.
So, when outputting such typedefs in RST format, we need to handle
this special case, as otherwise it will produce those warnings:
./include/media/v4l2-dv-timings.h:43: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:60: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
./include/media/v4l2-dv-timings.h:81: WARNING: c:type reference target not found: v4l2_check_dv_timings_fnc
So, change the kernel-doc script to produce a RST output for the
above typedef as:
.. c:type:: v4l2_check_dv_timings_fnc
**Typedef**: timings check callback
**Syntax**
``bool v4l2_check_dv_timings_fnc (const struct v4l2_dv_timings * t, void * handle);``
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2016-08-31 07:20:58 +08:00
|
|
|
'typedef' => 1,
|
2005-04-17 06:20:36 +08:00
|
|
|
'module' => $modulename,
|
2015-10-09 03:14:45 +08:00
|
|
|
'functiontype' => $return_type,
|
|
|
|
'parameterlist' => \@parameterlist,
|
|
|
|
'parameterdescs' => \%parameterdescs,
|
|
|
|
'parametertypes' => \%parametertypes,
|
2005-04-17 06:20:36 +08:00
|
|
|
'sectionlist' => \@sectionlist,
|
|
|
|
'sections' => \%sections,
|
|
|
|
'purpose' => $declaration_purpose
|
|
|
|
});
|
2015-10-09 03:14:45 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
while (($x =~ /\(*.\)\s*;$/) || ($x =~ /\[*.\]\s*;$/)) {
|
|
|
|
$x =~ s/\(*.\)\s*;$/;/;
|
|
|
|
$x =~ s/\[*.\]\s*;$/;/;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2015-10-09 03:14:45 +08:00
|
|
|
|
|
|
|
if ($x =~ /typedef.*\s+(\w+)\s*;/) {
|
2015-10-09 02:21:44 +08:00
|
|
|
$declaration_name = $1;
|
|
|
|
|
2021-01-14 16:04:47 +08:00
|
|
|
if ($identifier ne $declaration_name) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "expecting prototype for typedef $identifier. Prototype was for typedef $declaration_name instead\n");
|
2021-01-14 16:04:47 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2015-10-09 02:21:44 +08:00
|
|
|
output_declaration($declaration_name,
|
|
|
|
'typedef',
|
|
|
|
{'typedef' => $declaration_name,
|
|
|
|
'module' => $modulename,
|
|
|
|
'sectionlist' => \@sectionlist,
|
|
|
|
'sections' => \%sections,
|
|
|
|
'purpose' => $declaration_purpose
|
|
|
|
});
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
else {
|
2015-09-05 06:43:21 +08:00
|
|
|
print STDERR "${file}:$.: error: Cannot parse typedef!\n";
|
2005-04-17 06:20:36 +08:00
|
|
|
++$errors;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-12-20 00:49:30 +08:00
|
|
|
sub save_struct_actual($) {
|
|
|
|
my $actual = shift;
|
|
|
|
|
|
|
|
# strip all spaces from the actual param so that it looks like one string item
|
|
|
|
$actual =~ s/\s*//g;
|
|
|
|
$struct_actual = $struct_actual . $actual . " ";
|
|
|
|
}
|
|
|
|
|
scripts: kernel-doc: print the declaration name on warnings
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code,
it will never print anything. I suspect that originally
it was using the second argument of output_declaration().
I opted to not rely on a globally defined $declaration_name,
but, instead, to pass it explicitly as a parameter.
While here, I removed a unaligned check for !$anon_struct_union.
This is not needed, as, if $anon_struct_union is not zero,
$parameterdescs{$param} will be defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:15 +08:00
|
|
|
sub create_parameterlist($$$$) {
|
2005-04-17 06:20:36 +08:00
|
|
|
my $args = shift;
|
|
|
|
my $splitter = shift;
|
|
|
|
my $file = shift;
|
scripts: kernel-doc: print the declaration name on warnings
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code,
it will never print anything. I suspect that originally
it was using the second argument of output_declaration().
I opted to not rely on a globally defined $declaration_name,
but, instead, to pass it explicitly as a parameter.
While here, I removed a unaligned check for !$anon_struct_union.
This is not needed, as, if $anon_struct_union is not zero,
$parameterdescs{$param} will be defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:15 +08:00
|
|
|
my $declaration_name = shift;
|
2005-04-17 06:20:36 +08:00
|
|
|
my $type;
|
|
|
|
my $param;
|
|
|
|
|
2006-01-10 12:53:55 +08:00
|
|
|
# temporarily replace commas inside function pointer definition
|
2021-05-14 22:42:44 +08:00
|
|
|
my $arg_expr = qr{\([^\),]+};
|
|
|
|
while ($args =~ /$arg_expr,/) {
|
|
|
|
$args =~ s/($arg_expr),/$1#/g;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2006-02-01 19:06:58 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
foreach my $arg (split($splitter, $args)) {
|
|
|
|
# strip comments
|
|
|
|
$arg =~ s/\/\*.*\*\///;
|
2022-09-03 05:33:44 +08:00
|
|
|
# ignore argument attributes
|
|
|
|
$arg =~ s/\sPOS0?\s/ /;
|
2007-05-08 15:24:39 +08:00
|
|
|
# strip leading/trailing spaces
|
|
|
|
$arg =~ s/^\s*//;
|
2005-04-17 06:20:36 +08:00
|
|
|
$arg =~ s/\s*$//;
|
|
|
|
$arg =~ s/\s+/ /;
|
|
|
|
|
|
|
|
if ($arg =~ /^#/) {
|
|
|
|
# Treat preprocessor directive as a typeless variable just to fill
|
|
|
|
# corresponding data structures "correctly". Catch it later in
|
|
|
|
# output_* subs.
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
push_parameter($arg, "", "", $file);
|
2008-02-24 07:24:01 +08:00
|
|
|
} elsif ($arg =~ m/\(.+\)\s*\(/) {
|
2005-04-17 06:20:36 +08:00
|
|
|
# pointer-to-function
|
|
|
|
$arg =~ tr/#/,/;
|
2021-02-17 22:56:25 +08:00
|
|
|
$arg =~ m/[^\(]+\(\*?\s*([\w\[\]\.]*)\s*\)/;
|
2005-04-17 06:20:36 +08:00
|
|
|
$param = $1;
|
|
|
|
$type = $arg;
|
2008-02-24 07:24:01 +08:00
|
|
|
$type =~ s/([^\(]+\(\*?)\s*$param/$1/;
|
2008-12-20 00:49:30 +08:00
|
|
|
save_struct_actual($param);
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
push_parameter($param, $type, $arg, $file, $declaration_name);
|
2005-11-14 08:08:13 +08:00
|
|
|
} elsif ($arg) {
|
2005-04-17 06:20:36 +08:00
|
|
|
$arg =~ s/\s*:\s*/:/g;
|
|
|
|
$arg =~ s/\s*\[/\[/g;
|
|
|
|
|
|
|
|
my @args = split('\s*,\s*', $arg);
|
|
|
|
if ($args[0] =~ m/\*/) {
|
|
|
|
$args[0] =~ s/(\*+)\s*/ $1/;
|
|
|
|
}
|
2007-05-08 15:29:05 +08:00
|
|
|
|
|
|
|
my @first_arg;
|
|
|
|
if ($args[0] =~ /^(.*\s+)(.*?\[.*\].*)$/) {
|
|
|
|
shift @args;
|
|
|
|
push(@first_arg, split('\s+', $1));
|
|
|
|
push(@first_arg, $2);
|
|
|
|
} else {
|
|
|
|
@first_arg = split('\s+', shift @args);
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
unshift(@args, pop @first_arg);
|
|
|
|
$type = join " ", @first_arg;
|
|
|
|
|
|
|
|
foreach $param (@args) {
|
|
|
|
if ($param =~ m/^(\*+)\s*(.*)/) {
|
2008-12-20 00:49:30 +08:00
|
|
|
save_struct_actual($2);
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
|
|
|
|
push_parameter($2, "$type $1", $arg, $file, $declaration_name);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
elsif ($param =~ m/(.*?):(\d+)/) {
|
2008-05-17 06:45:52 +08:00
|
|
|
if ($type ne "") { # skip unnamed bit-fields
|
2008-12-20 00:49:30 +08:00
|
|
|
save_struct_actual($1);
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
push_parameter($1, "$type:$2", $arg, $file, $declaration_name)
|
2008-05-17 06:45:52 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
else {
|
2008-12-20 00:49:30 +08:00
|
|
|
save_struct_actual($param);
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
push_parameter($param, $type, $arg, $file, $declaration_name);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
sub push_parameter($$$$$) {
|
2005-04-17 06:20:36 +08:00
|
|
|
my $param = shift;
|
|
|
|
my $type = shift;
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
my $org_arg = shift;
|
2005-04-17 06:20:36 +08:00
|
|
|
my $file = shift;
|
scripts: kernel-doc: print the declaration name on warnings
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code,
it will never print anything. I suspect that originally
it was using the second argument of output_declaration().
I opted to not rely on a globally defined $declaration_name,
but, instead, to pass it explicitly as a parameter.
While here, I removed a unaligned check for !$anon_struct_union.
This is not needed, as, if $anon_struct_union is not zero,
$parameterdescs{$param} will be defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:15 +08:00
|
|
|
my $declaration_name = shift;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2007-07-19 16:48:24 +08:00
|
|
|
if (($anon_struct_union == 1) && ($type eq "") &&
|
|
|
|
($param eq "}")) {
|
|
|
|
return; # ignore the ending }; from anon. struct/union
|
|
|
|
}
|
|
|
|
|
|
|
|
$anon_struct_union = 0;
|
2017-03-31 04:11:29 +08:00
|
|
|
$param =~ s/[\[\)].*//;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-01-10 12:53:55 +08:00
|
|
|
if ($type eq "" && $param =~ /\.\.\.$/)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2016-10-28 16:14:08 +08:00
|
|
|
if (!$param =~ /\w\.\.\.$/) {
|
|
|
|
# handles unnamed variable parameters
|
|
|
|
$param = "...";
|
|
|
|
}
|
scripts/kernel-doc: Add support for named variable macro arguments
Currently, when kernel-doc encounters a macro with a named variable
argument[1], such as this:
#define hlist_for_each_entry_rcu(pos, head, member, cond...)
... it expects the variable argument to be documented as `cond...`,
rather than `cond`. This is semantically wrong, because the name (as
used in the macro body) is actually `cond`.
With this patch, kernel-doc will accept the name without dots (`cond`
in the example above) in doc comments, and warn if the name with dots
(`cond...`) is used and verbose mode[2] is enabled.
The support for the `cond...` syntax can be removed later, when the
documentation of all such macros has been switched to the new syntax.
Testing this patch on top of v5.4-rc6, `make htmldocs` shows a few
changes in log output and HTML output:
1) The following warnings[3] are eliminated:
./include/linux/rculist.h:374: warning:
Excess function parameter 'cond' description in 'list_for_each_entry_rcu'
./include/linux/rculist.h:651: warning:
Excess function parameter 'cond' description in 'hlist_for_each_entry_rcu'
2) For list_for_each_entry_rcu and hlist_for_each_entry_rcu, the
correct description is shown
3) Named variable arguments are shown without dots
[1]: https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html
[2]: scripts/kernel-doc -v
[3]: See also https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?h=dev&id=5bc4bc0d6153617eabde275285b7b5a8137fdf3c
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Tested-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2019-11-07 21:41:33 +08:00
|
|
|
elsif ($param =~ /\w\.\.\.$/) {
|
|
|
|
# for named variable parameters of the form `x...`, remove the dots
|
|
|
|
$param =~ s/\.\.\.$//;
|
|
|
|
}
|
2008-12-02 05:14:03 +08:00
|
|
|
if (!defined $parameterdescs{$param} || $parameterdescs{$param} eq "") {
|
|
|
|
$parameterdescs{$param} = "variable arguments";
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
elsif ($type eq "" && ($param eq "" or $param eq "void"))
|
|
|
|
{
|
|
|
|
$param="void";
|
|
|
|
$parameterdescs{void} = "no arguments";
|
|
|
|
}
|
2006-12-22 17:10:50 +08:00
|
|
|
elsif ($type eq "" && ($param eq "struct" or $param eq "union"))
|
|
|
|
# handle unnamed (anonymous) union or struct:
|
|
|
|
{
|
|
|
|
$type = $param;
|
2007-07-19 16:48:24 +08:00
|
|
|
$param = "{unnamed_" . $param . "}";
|
2006-12-22 17:10:50 +08:00
|
|
|
$parameterdescs{$param} = "anonymous\n";
|
2007-07-19 16:48:24 +08:00
|
|
|
$anon_struct_union = 1;
|
2006-12-22 17:10:50 +08:00
|
|
|
}
|
|
|
|
|
2006-01-10 12:53:55 +08:00
|
|
|
# warn if parameter has no description
|
2006-12-22 17:10:50 +08:00
|
|
|
# (but ignore ones starting with # as these are not parameters
|
|
|
|
# but inline preprocessor statements);
|
scripts: kernel-doc: print the declaration name on warnings
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code,
it will never print anything. I suspect that originally
it was using the second argument of output_declaration().
I opted to not rely on a globally defined $declaration_name,
but, instead, to pass it explicitly as a parameter.
While here, I removed a unaligned check for !$anon_struct_union.
This is not needed, as, if $anon_struct_union is not zero,
$parameterdescs{$param} will be defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:15 +08:00
|
|
|
# Note: It will also ignore void params and unnamed structs/unions
|
2017-03-31 04:11:29 +08:00
|
|
|
if (!defined $parameterdescs{$param} && $param !~ /^#/) {
|
scripts: kernel-doc: print the declaration name on warnings
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code,
it will never print anything. I suspect that originally
it was using the second argument of output_declaration().
I opted to not rely on a globally defined $declaration_name,
but, instead, to pass it explicitly as a parameter.
While here, I removed a unaligned check for !$anon_struct_union.
This is not needed, as, if $anon_struct_union is not zero,
$parameterdescs{$param} will be defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:15 +08:00
|
|
|
$parameterdescs{$param} = $undescribed;
|
2006-01-10 12:53:55 +08:00
|
|
|
|
2019-01-12 03:31:39 +08:00
|
|
|
if (show_warnings($type, $declaration_name) && $param !~ /\./) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "Function parameter or member '$param' not described in '$declaration_name'\n");
|
2017-12-18 20:30:18 +08:00
|
|
|
}
|
2007-05-08 15:24:39 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2011-03-31 09:57:33 +08:00
|
|
|
# strip spaces from $param so that it is one continuous string
|
2009-06-18 08:37:47 +08:00
|
|
|
# on @parameterlist;
|
|
|
|
# this fixes a problem where check_sections() cannot find
|
|
|
|
# a parameter like "addr[6 + 2]" because it actually appears
|
|
|
|
# as "addr[6", "+", "2]" on the parameter list;
|
|
|
|
# but it's better to maintain the param string unchanged for output,
|
|
|
|
# so just weaken the string compare in check_sections() to ignore
|
|
|
|
# "[blah" in a parameter string;
|
|
|
|
###$param =~ s/\s*//g;
|
2005-04-17 06:20:36 +08:00
|
|
|
push @parameterlist, $param;
|
scripts: kernel-doc: don't mangle with parameter list
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c, on this function:
u32 __pure crc32_be_generic (u32 crc, unsigned char const *p, size_t len, const u32 (*tab)[256], u32 polynomial);
The current logic mangles it, producing this output:
const u32 ( *tab
That's something that it is not recognizeable.
So, instead, let's push the argument as-is, and use it
when printing the function prototype and when describing
each argument.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-09-30 18:24:43 +08:00
|
|
|
$org_arg =~ s/\s\s+/ /g;
|
|
|
|
$parametertypes{$param} = $org_arg;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2017-12-18 20:30:14 +08:00
|
|
|
sub check_sections($$$$$) {
|
|
|
|
my ($file, $decl_name, $decl_type, $sectcheck, $prmscheck) = @_;
|
2008-12-20 00:49:30 +08:00
|
|
|
my @sects = split ' ', $sectcheck;
|
|
|
|
my @prms = split ' ', $prmscheck;
|
|
|
|
my $err;
|
|
|
|
my ($px, $sx);
|
|
|
|
my $prm_clean; # strip trailing "[array size]" and/or beginning "*"
|
|
|
|
|
|
|
|
foreach $sx (0 .. $#sects) {
|
|
|
|
$err = 1;
|
|
|
|
foreach $px (0 .. $#prms) {
|
|
|
|
$prm_clean = $prms[$px];
|
|
|
|
$prm_clean =~ s/\[.*\]//;
|
2021-05-14 22:42:44 +08:00
|
|
|
$prm_clean =~ s/$attribute//i;
|
2009-06-18 08:37:47 +08:00
|
|
|
# ignore array size in a parameter string;
|
|
|
|
# however, the original param string may contain
|
|
|
|
# spaces, e.g.: addr[6 + 2]
|
|
|
|
# and this appears in @prms as "addr[6" since the
|
|
|
|
# parameter list is split at spaces;
|
|
|
|
# hence just ignore "[..." for the sections check;
|
|
|
|
$prm_clean =~ s/\[.*//;
|
|
|
|
|
2008-12-20 00:49:30 +08:00
|
|
|
##$prm_clean =~ s/^\**//;
|
|
|
|
if ($prm_clean eq $sects[$sx]) {
|
|
|
|
$err = 0;
|
|
|
|
last;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if ($err) {
|
|
|
|
if ($decl_type eq "function") {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.",
|
2008-12-20 00:49:30 +08:00
|
|
|
"Excess function parameter " .
|
|
|
|
"'$sects[$sx]' " .
|
2022-06-13 17:05:10 +08:00
|
|
|
"description in '$decl_name'\n");
|
2008-12-20 00:49:30 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-11-27 05:22:27 +08:00
|
|
|
##
|
|
|
|
# Checks the section describing the return value of a function.
|
|
|
|
sub check_return_section {
|
|
|
|
my $file = shift;
|
|
|
|
my $declaration_name = shift;
|
|
|
|
my $return_type = shift;
|
|
|
|
|
|
|
|
# Ignore an empty return type (It's a macro)
|
|
|
|
# Ignore functions with a "void" return type. (But don't ignore "void *")
|
|
|
|
if (($return_type eq "") || ($return_type =~ /void\s*\w*\s*$/)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!defined($sections{$section_return}) ||
|
|
|
|
$sections{$section_return} eq "") {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.",
|
2012-11-27 05:22:27 +08:00
|
|
|
"No description found for return value of " .
|
2022-06-13 17:05:10 +08:00
|
|
|
"'$declaration_name'\n");
|
2012-11-27 05:22:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
##
|
|
|
|
# takes a function prototype and the name of the current file being
|
|
|
|
# processed and spits out all the details stored in the global
|
|
|
|
# arrays/hashes.
|
|
|
|
sub dump_function($$) {
|
|
|
|
my $prototype = shift;
|
|
|
|
my $file = shift;
|
2014-07-13 00:55:03 +08:00
|
|
|
my $noret = 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
scripts: kernel-doc: fix line number handling
Address several issues related to pointing to the wrong line
number:
1) ensure that line numbers will always be initialized
When section is the default (Description), the line number
is not initializing, producing this:
$ ./scripts/kernel-doc --enable-lineno ./drivers/media/v4l2-core/v4l2-mem2mem.c|less
**Description**
#define LINENO 0
In case of streamoff or release called on any context,
1] If the context is currently running, then abort job will be called
2] If the context is queued, then the context will be removed from
the job_queue
Which is not right. Ensure that the line number will always
be there. After applied, the result now points to the right location:
**Description**
#define LINENO 410
In case of streamoff or release called on any context,
1] If the context is currently running, then abort job will be called
2] If the context is queued, then the context will be removed from
the job_queue
2) The line numbers for function prototypes are always + 1,
because it is taken at the line after handling the prototype.
Change the logic to point to the next line after the /** */
block;
3) The "DOC:" line number should point to the same line as this
markup is found, and not to the next one.
Probably part of the issues were due to a but that was causing
the line number offset to be incremented by one, if --export
were used.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-10-09 16:15:25 +08:00
|
|
|
print_lineno($new_start_line);
|
2020-09-09 22:10:33 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
$prototype =~ s/^static +//;
|
|
|
|
$prototype =~ s/^extern +//;
|
2005-05-01 23:59:25 +08:00
|
|
|
$prototype =~ s/^asmlinkage +//;
|
2005-04-17 06:20:36 +08:00
|
|
|
$prototype =~ s/^inline +//;
|
|
|
|
$prototype =~ s/^__inline__ +//;
|
2006-10-11 16:22:10 +08:00
|
|
|
$prototype =~ s/^__inline +//;
|
|
|
|
$prototype =~ s/^__always_inline +//;
|
|
|
|
$prototype =~ s/^noinline +//;
|
2022-09-03 05:33:44 +08:00
|
|
|
$prototype =~ s/^__FORTIFY_INLINE +//;
|
2008-06-20 07:03:29 +08:00
|
|
|
$prototype =~ s/__init +//;
|
2010-03-24 04:35:24 +08:00
|
|
|
$prototype =~ s/__init_or_module +//;
|
2021-04-27 19:48:28 +08:00
|
|
|
$prototype =~ s/__deprecated +//;
|
2021-03-06 19:35:10 +08:00
|
|
|
$prototype =~ s/__flatten +//;
|
2014-08-25 09:17:17 +08:00
|
|
|
$prototype =~ s/__meminit +//;
|
2012-01-22 02:31:54 +08:00
|
|
|
$prototype =~ s/__must_check +//;
|
2012-08-17 07:23:20 +08:00
|
|
|
$prototype =~ s/__weak +//;
|
2018-03-15 20:06:23 +08:00
|
|
|
$prototype =~ s/__sched +//;
|
2019-08-06 00:29:50 +08:00
|
|
|
$prototype =~ s/__printf\s*\(\s*\d*\s*,\s*\d*\s*\) +//;
|
2022-09-03 05:33:44 +08:00
|
|
|
$prototype =~ s/__(?:re)?alloc_size\s*\(\s*\d+\s*(?:,\s*\d+\s*)?\) +//;
|
|
|
|
$prototype =~ s/__diagnose_as\s*\(\s*\S+\s*(?:,\s*\d+\s*)*\) +//;
|
2014-07-13 00:55:03 +08:00
|
|
|
my $define = $prototype =~ s/^#\s*define\s+//; #ak added
|
2021-03-06 19:35:10 +08:00
|
|
|
$prototype =~ s/__attribute_const__ +//;
|
2017-01-02 23:22:24 +08:00
|
|
|
$prototype =~ s/__attribute__\s*\(\(
|
|
|
|
(?:
|
|
|
|
[\w\s]++ # attribute name
|
|
|
|
(?:\([^)]*+\))? # attribute arguments
|
|
|
|
\s*+,? # optional comma at the end
|
|
|
|
)+
|
|
|
|
\)\)\s+//x;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
# Yes, this truly is vile. We are looking for:
|
|
|
|
# 1. Return type (may be nothing if we're looking at a macro)
|
|
|
|
# 2. Function name
|
|
|
|
# 3. Function parameters.
|
|
|
|
#
|
|
|
|
# All the while we have to watch out for function pointer parameters
|
|
|
|
# (which IIRC is what the two sections are for), C types (these
|
|
|
|
# regexps don't even start to express all the possibilities), and
|
|
|
|
# so on.
|
|
|
|
#
|
|
|
|
# If you mess with these regexps, it's a good idea to check that
|
|
|
|
# the following functions' documentation still comes out right:
|
|
|
|
# - parport_register_device (function pointer parameters)
|
|
|
|
# - atomic_set (macro)
|
2006-02-01 19:06:55 +08:00
|
|
|
# - pci_match_device, __copy_to_user (long return type)
|
2021-05-14 22:42:44 +08:00
|
|
|
my $name = qr{[a-zA-Z0-9_~:]+};
|
|
|
|
my $prototype_end1 = qr{[^\(]*};
|
|
|
|
my $prototype_end2 = qr{[^\{]*};
|
|
|
|
my $prototype_end = qr{\(($prototype_end1|$prototype_end2)\)};
|
|
|
|
my $type1 = qr{[\w\s]+};
|
|
|
|
my $type2 = qr{$type1\*+};
|
|
|
|
|
|
|
|
if ($define && $prototype =~ m/^()($name)\s+/) {
|
2014-07-13 00:55:03 +08:00
|
|
|
# This is an object-like macro, it has no return type and no parameter
|
|
|
|
# list.
|
|
|
|
# Function-like macros are not allowed to have spaces between
|
|
|
|
# declaration_name and opening parenthesis (notice the \s+).
|
|
|
|
$return_type = $1;
|
|
|
|
$declaration_name = $2;
|
|
|
|
$noret = 1;
|
2021-05-14 22:42:44 +08:00
|
|
|
} elsif ($prototype =~ m/^()($name)\s*$prototype_end/ ||
|
|
|
|
$prototype =~ m/^($type1)\s+($name)\s*$prototype_end/ ||
|
|
|
|
$prototype =~ m/^($type2+)\s*($name)\s*$prototype_end/) {
|
2005-04-17 06:20:36 +08:00
|
|
|
$return_type = $1;
|
|
|
|
$declaration_name = $2;
|
|
|
|
my $args = $3;
|
|
|
|
|
scripts: kernel-doc: print the declaration name on warnings
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code,
it will never print anything. I suspect that originally
it was using the second argument of output_declaration().
I opted to not rely on a globally defined $declaration_name,
but, instead, to pass it explicitly as a parameter.
While here, I removed a unaligned check for !$anon_struct_union.
This is not needed, as, if $anon_struct_union is not zero,
$parameterdescs{$param} will be defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2017-12-18 20:30:15 +08:00
|
|
|
create_parameterlist($args, ',', $file, $declaration_name);
|
2005-04-17 06:20:36 +08:00
|
|
|
} else {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "cannot understand function prototype: '$prototype'\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2021-01-14 16:04:47 +08:00
|
|
|
if ($identifier ne $declaration_name) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "expecting prototype for $identifier(). Prototype was for $declaration_name() instead\n");
|
2021-01-14 16:04:47 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-09-30 15:47:01 +08:00
|
|
|
my $prms = join " ", @parameterlist;
|
|
|
|
check_sections($file, $declaration_name, "function", $sectcheck, $prms);
|
|
|
|
|
|
|
|
# This check emits a lot of warnings at the moment, because many
|
|
|
|
# functions don't have a 'Return' doc section. So until the number
|
|
|
|
# of warnings goes sufficiently down, the check is only performed in
|
|
|
|
# verbose mode.
|
|
|
|
# TODO: always perform the check.
|
|
|
|
if ($verbose && !$noret) {
|
|
|
|
check_return_section($file, $declaration_name, $return_type);
|
|
|
|
}
|
2012-11-27 05:22:27 +08:00
|
|
|
|
2020-09-30 15:47:01 +08:00
|
|
|
# The function parser can be called with a typedef parameter.
|
|
|
|
# Handle it.
|
|
|
|
if ($return_type =~ /typedef/) {
|
|
|
|
output_declaration($declaration_name,
|
|
|
|
'function',
|
|
|
|
{'function' => $declaration_name,
|
|
|
|
'typedef' => 1,
|
|
|
|
'module' => $modulename,
|
|
|
|
'functiontype' => $return_type,
|
|
|
|
'parameterlist' => \@parameterlist,
|
|
|
|
'parameterdescs' => \%parameterdescs,
|
|
|
|
'parametertypes' => \%parametertypes,
|
|
|
|
'sectionlist' => \@sectionlist,
|
|
|
|
'sections' => \%sections,
|
|
|
|
'purpose' => $declaration_purpose
|
|
|
|
});
|
|
|
|
} else {
|
|
|
|
output_declaration($declaration_name,
|
|
|
|
'function',
|
|
|
|
{'function' => $declaration_name,
|
|
|
|
'module' => $modulename,
|
|
|
|
'functiontype' => $return_type,
|
|
|
|
'parameterlist' => \@parameterlist,
|
|
|
|
'parameterdescs' => \%parameterdescs,
|
|
|
|
'parametertypes' => \%parametertypes,
|
|
|
|
'sectionlist' => \@sectionlist,
|
|
|
|
'sections' => \%sections,
|
|
|
|
'purpose' => $declaration_purpose
|
|
|
|
});
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
sub reset_state {
|
|
|
|
$function = "";
|
|
|
|
%parameterdescs = ();
|
|
|
|
%parametertypes = ();
|
|
|
|
@parameterlist = ();
|
|
|
|
%sections = ();
|
|
|
|
@sectionlist = ();
|
2008-12-20 00:49:30 +08:00
|
|
|
$sectcheck = "";
|
|
|
|
$struct_actual = "";
|
2005-04-17 06:20:36 +08:00
|
|
|
$prototype = "";
|
2006-02-01 19:06:58 +08:00
|
|
|
|
2016-05-26 19:56:05 +08:00
|
|
|
$state = STATE_NORMAL;
|
|
|
|
$inline_doc_state = STATE_INLINE_NA;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2009-05-01 01:29:36 +08:00
|
|
|
sub tracepoint_munge($) {
|
|
|
|
my $file = shift;
|
|
|
|
my $tracepointname = 0;
|
|
|
|
my $tracepointargs = 0;
|
|
|
|
|
2009-12-02 01:18:49 +08:00
|
|
|
if ($prototype =~ m/TRACE_EVENT\((.*?),/) {
|
2009-05-01 01:29:36 +08:00
|
|
|
$tracepointname = $1;
|
|
|
|
}
|
2009-12-02 01:18:49 +08:00
|
|
|
if ($prototype =~ m/DEFINE_SINGLE_EVENT\((.*?),/) {
|
|
|
|
$tracepointname = $1;
|
|
|
|
}
|
|
|
|
if ($prototype =~ m/DEFINE_EVENT\((.*?),(.*?),/) {
|
|
|
|
$tracepointname = $2;
|
|
|
|
}
|
|
|
|
$tracepointname =~ s/^\s+//; #strip leading whitespace
|
|
|
|
if ($prototype =~ m/TP_PROTO\((.*?)\)/) {
|
2009-05-01 01:29:36 +08:00
|
|
|
$tracepointargs = $1;
|
|
|
|
}
|
|
|
|
if (($tracepointname eq 0) || ($tracepointargs eq 0)) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "Unrecognized tracepoint format: \n".
|
|
|
|
"$prototype\n");
|
2009-05-01 01:29:36 +08:00
|
|
|
} else {
|
|
|
|
$prototype = "static inline void trace_$tracepointname($tracepointargs)";
|
2021-01-14 16:04:47 +08:00
|
|
|
$identifier = "trace_$identifier";
|
2009-05-01 01:29:36 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
kernel-doc: fix syscall wrapper processing
Fix kernel-doc processing of SYSCALL wrappers.
The SYSCALL wrapper patches played havoc with kernel-doc for
syscalls. Syscalls that were scanned for DocBook processing
reported warnings like this one, for sys_tgkill:
Warning(kernel/signal.c:2285): No description found for parameter 'tgkill'
Warning(kernel/signal.c:2285): No description found for parameter 'pid_t'
Warning(kernel/signal.c:2285): No description found for parameter 'int'
because the macro parameters all "look like" function parameters,
although they are not:
/**
* sys_tgkill - send signal to one specific thread
* @tgid: the thread group ID of the thread
* @pid: the PID of the thread
* @sig: signal to be sent
*
* This syscall also checks the @tgid and returns -ESRCH even if the PID
* exists but it's not belonging to the target process anymore. This
* method solves the problem of threads exiting and PIDs getting reused.
*/
SYSCALL_DEFINE3(tgkill, pid_t, tgid, pid_t, pid, int, sig)
{
...
This patch special-cases the handling SYSCALL_DEFINE* function
prototypes by expanding them to
long sys_foobar(type1 arg1, type1 arg2, ...)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-02-12 05:04:33 +08:00
|
|
|
sub syscall_munge() {
|
|
|
|
my $void = 0;
|
|
|
|
|
2017-12-18 20:30:12 +08:00
|
|
|
$prototype =~ s@[\r\n]+@ @gos; # strip newlines/CR's
|
kernel-doc: fix syscall wrapper processing
Fix kernel-doc processing of SYSCALL wrappers.
The SYSCALL wrapper patches played havoc with kernel-doc for
syscalls. Syscalls that were scanned for DocBook processing
reported warnings like this one, for sys_tgkill:
Warning(kernel/signal.c:2285): No description found for parameter 'tgkill'
Warning(kernel/signal.c:2285): No description found for parameter 'pid_t'
Warning(kernel/signal.c:2285): No description found for parameter 'int'
because the macro parameters all "look like" function parameters,
although they are not:
/**
* sys_tgkill - send signal to one specific thread
* @tgid: the thread group ID of the thread
* @pid: the PID of the thread
* @sig: signal to be sent
*
* This syscall also checks the @tgid and returns -ESRCH even if the PID
* exists but it's not belonging to the target process anymore. This
* method solves the problem of threads exiting and PIDs getting reused.
*/
SYSCALL_DEFINE3(tgkill, pid_t, tgid, pid_t, pid, int, sig)
{
...
This patch special-cases the handling SYSCALL_DEFINE* function
prototypes by expanding them to
long sys_foobar(type1 arg1, type1 arg2, ...)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-02-12 05:04:33 +08:00
|
|
|
## if ($prototype =~ m/SYSCALL_DEFINE0\s*\(\s*(a-zA-Z0-9_)*\s*\)/) {
|
|
|
|
if ($prototype =~ m/SYSCALL_DEFINE0/) {
|
|
|
|
$void = 1;
|
|
|
|
## $prototype = "long sys_$1(void)";
|
|
|
|
}
|
|
|
|
|
|
|
|
$prototype =~ s/SYSCALL_DEFINE.*\(/long sys_/; # fix return type & func name
|
|
|
|
if ($prototype =~ m/long (sys_.*?),/) {
|
|
|
|
$prototype =~ s/,/\(/;
|
|
|
|
} elsif ($void) {
|
|
|
|
$prototype =~ s/\)/\(void\)/;
|
|
|
|
}
|
|
|
|
|
|
|
|
# now delete all of the odd-number commas in $prototype
|
|
|
|
# so that arg types & arg names don't have a comma between them
|
|
|
|
my $count = 0;
|
|
|
|
my $len = length($prototype);
|
|
|
|
if ($void) {
|
|
|
|
$len = 0; # skip the for-loop
|
|
|
|
}
|
|
|
|
for (my $ix = 0; $ix < $len; $ix++) {
|
|
|
|
if (substr($prototype, $ix, 1) eq ',') {
|
|
|
|
$count++;
|
|
|
|
if ($count % 2 == 1) {
|
|
|
|
substr($prototype, $ix, 1) = ' ';
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-02 05:46:24 +08:00
|
|
|
sub process_proto_function($$) {
|
2005-04-17 06:20:36 +08:00
|
|
|
my $x = shift;
|
|
|
|
my $file = shift;
|
|
|
|
|
2007-07-19 16:48:24 +08:00
|
|
|
$x =~ s@\/\/.*$@@gos; # strip C99-style comments to end of line
|
|
|
|
|
2008-10-26 08:06:43 +08:00
|
|
|
if ($x =~ m#\s*/\*\s+MACDOC\s*#io || ($x =~ /^#/ && $x !~ /^#\s*define/)) {
|
2005-04-17 06:20:36 +08:00
|
|
|
# do nothing
|
|
|
|
}
|
|
|
|
elsif ($x =~ /([^\{]*)/) {
|
2007-05-08 15:24:39 +08:00
|
|
|
$prototype .= $1;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
kernel-doc: fix syscall wrapper processing
Fix kernel-doc processing of SYSCALL wrappers.
The SYSCALL wrapper patches played havoc with kernel-doc for
syscalls. Syscalls that were scanned for DocBook processing
reported warnings like this one, for sys_tgkill:
Warning(kernel/signal.c:2285): No description found for parameter 'tgkill'
Warning(kernel/signal.c:2285): No description found for parameter 'pid_t'
Warning(kernel/signal.c:2285): No description found for parameter 'int'
because the macro parameters all "look like" function parameters,
although they are not:
/**
* sys_tgkill - send signal to one specific thread
* @tgid: the thread group ID of the thread
* @pid: the PID of the thread
* @sig: signal to be sent
*
* This syscall also checks the @tgid and returns -ESRCH even if the PID
* exists but it's not belonging to the target process anymore. This
* method solves the problem of threads exiting and PIDs getting reused.
*/
SYSCALL_DEFINE3(tgkill, pid_t, tgid, pid_t, pid, int, sig)
{
...
This patch special-cases the handling SYSCALL_DEFINE* function
prototypes by expanding them to
long sys_foobar(type1 arg1, type1 arg2, ...)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-02-12 05:04:33 +08:00
|
|
|
|
2008-10-26 08:06:43 +08:00
|
|
|
if (($x =~ /\{/) || ($x =~ /\#\s*define/) || ($x =~ /;/)) {
|
2007-05-08 15:24:39 +08:00
|
|
|
$prototype =~ s@/\*.*?\*/@@gos; # strip comments.
|
2005-04-17 06:20:36 +08:00
|
|
|
$prototype =~ s@[\r\n]+@ @gos; # strip newlines/cr's.
|
|
|
|
$prototype =~ s@^\s+@@gos; # strip leading spaces
|
2020-06-23 15:09:02 +08:00
|
|
|
|
|
|
|
# Handle prototypes for function pointers like:
|
|
|
|
# int (*pcs_config)(struct foo)
|
|
|
|
$prototype =~ s@^(\S+\s+)\(\s*\*(\S+)\)@$1$2@gos;
|
|
|
|
|
kernel-doc: fix syscall wrapper processing
Fix kernel-doc processing of SYSCALL wrappers.
The SYSCALL wrapper patches played havoc with kernel-doc for
syscalls. Syscalls that were scanned for DocBook processing
reported warnings like this one, for sys_tgkill:
Warning(kernel/signal.c:2285): No description found for parameter 'tgkill'
Warning(kernel/signal.c:2285): No description found for parameter 'pid_t'
Warning(kernel/signal.c:2285): No description found for parameter 'int'
because the macro parameters all "look like" function parameters,
although they are not:
/**
* sys_tgkill - send signal to one specific thread
* @tgid: the thread group ID of the thread
* @pid: the PID of the thread
* @sig: signal to be sent
*
* This syscall also checks the @tgid and returns -ESRCH even if the PID
* exists but it's not belonging to the target process anymore. This
* method solves the problem of threads exiting and PIDs getting reused.
*/
SYSCALL_DEFINE3(tgkill, pid_t, tgid, pid_t, pid, int, sig)
{
...
This patch special-cases the handling SYSCALL_DEFINE* function
prototypes by expanding them to
long sys_foobar(type1 arg1, type1 arg2, ...)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-02-12 05:04:33 +08:00
|
|
|
if ($prototype =~ /SYSCALL_DEFINE/) {
|
|
|
|
syscall_munge();
|
|
|
|
}
|
2009-12-02 01:18:49 +08:00
|
|
|
if ($prototype =~ /TRACE_EVENT/ || $prototype =~ /DEFINE_EVENT/ ||
|
|
|
|
$prototype =~ /DEFINE_SINGLE_EVENT/)
|
|
|
|
{
|
2009-05-01 01:29:36 +08:00
|
|
|
tracepoint_munge($file);
|
|
|
|
}
|
kernel-doc: fix syscall wrapper processing
Fix kernel-doc processing of SYSCALL wrappers.
The SYSCALL wrapper patches played havoc with kernel-doc for
syscalls. Syscalls that were scanned for DocBook processing
reported warnings like this one, for sys_tgkill:
Warning(kernel/signal.c:2285): No description found for parameter 'tgkill'
Warning(kernel/signal.c:2285): No description found for parameter 'pid_t'
Warning(kernel/signal.c:2285): No description found for parameter 'int'
because the macro parameters all "look like" function parameters,
although they are not:
/**
* sys_tgkill - send signal to one specific thread
* @tgid: the thread group ID of the thread
* @pid: the PID of the thread
* @sig: signal to be sent
*
* This syscall also checks the @tgid and returns -ESRCH even if the PID
* exists but it's not belonging to the target process anymore. This
* method solves the problem of threads exiting and PIDs getting reused.
*/
SYSCALL_DEFINE3(tgkill, pid_t, tgid, pid_t, pid, int, sig)
{
...
This patch special-cases the handling SYSCALL_DEFINE* function
prototypes by expanding them to
long sys_foobar(type1 arg1, type1 arg2, ...)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-02-12 05:04:33 +08:00
|
|
|
dump_function($prototype, $file);
|
2005-04-17 06:20:36 +08:00
|
|
|
reset_state();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-02 05:46:24 +08:00
|
|
|
sub process_proto_type($$) {
|
2005-04-17 06:20:36 +08:00
|
|
|
my $x = shift;
|
|
|
|
my $file = shift;
|
|
|
|
|
|
|
|
$x =~ s@[\r\n]+@ @gos; # strip newlines/cr's.
|
|
|
|
$x =~ s@^\s+@@gos; # strip leading spaces
|
|
|
|
$x =~ s@\s+$@@gos; # strip trailing spaces
|
2007-07-19 16:48:24 +08:00
|
|
|
$x =~ s@\/\/.*$@@gos; # strip C99-style comments to end of line
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
if ($x =~ /^#/) {
|
|
|
|
# To distinguish preprocessor directive from regular declaration later.
|
|
|
|
$x .= ";";
|
|
|
|
}
|
|
|
|
|
|
|
|
while (1) {
|
2018-08-06 00:41:09 +08:00
|
|
|
if ( $x =~ /([^\{\};]*)([\{\};])(.*)/ ) {
|
2017-06-17 03:27:48 +08:00
|
|
|
if( length $prototype ) {
|
|
|
|
$prototype .= " "
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
$prototype .= $1 . $2;
|
|
|
|
($2 eq '{') && $brcount++;
|
|
|
|
($2 eq '}') && $brcount--;
|
|
|
|
if (($2 eq ';') && ($brcount == 0)) {
|
2009-06-09 23:50:38 +08:00
|
|
|
dump_declaration($prototype, $file);
|
2005-04-17 06:20:36 +08:00
|
|
|
reset_state();
|
2007-05-08 15:24:39 +08:00
|
|
|
last;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
$x = $3;
|
2007-05-08 15:24:39 +08:00
|
|
|
} else {
|
2005-04-17 06:20:36 +08:00
|
|
|
$prototype .= $x;
|
|
|
|
last;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-10-17 14:31:20 +08:00
|
|
|
|
2016-06-07 15:53:39 +08:00
|
|
|
sub map_filename($) {
|
2005-07-08 06:39:26 +08:00
|
|
|
my $file;
|
2015-09-02 06:48:49 +08:00
|
|
|
my ($orig_file) = @_;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2005-07-08 06:39:26 +08:00
|
|
|
if (defined($ENV{'SRCTREE'})) {
|
2015-09-02 06:48:49 +08:00
|
|
|
$file = "$ENV{'SRCTREE'}" . "/" . $orig_file;
|
2016-06-07 15:53:39 +08:00
|
|
|
} else {
|
2015-09-02 06:48:49 +08:00
|
|
|
$file = $orig_file;
|
2005-07-08 06:39:26 +08:00
|
|
|
}
|
2016-06-07 15:53:39 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
if (defined($source_map{$file})) {
|
|
|
|
$file = $source_map{$file};
|
|
|
|
}
|
|
|
|
|
2016-06-07 15:53:39 +08:00
|
|
|
return $file;
|
|
|
|
}
|
|
|
|
|
2016-06-07 16:00:52 +08:00
|
|
|
sub process_export_file($) {
|
|
|
|
my ($orig_file) = @_;
|
|
|
|
my $file = map_filename($orig_file);
|
|
|
|
|
|
|
|
if (!open(IN,"<$file")) {
|
|
|
|
print STDERR "Error: Cannot open file $file\n";
|
|
|
|
++$errors;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
while (<IN>) {
|
|
|
|
if (/$export_symbol/) {
|
2020-09-29 20:23:39 +08:00
|
|
|
next if (defined($nosymbol_table{$2}));
|
2016-06-07 16:00:52 +08:00
|
|
|
$function_table{$2} = 1;
|
|
|
|
}
|
2022-11-30 04:29:27 +08:00
|
|
|
if (/$export_symbol_ns/) {
|
|
|
|
next if (defined($nosymbol_table{$2}));
|
|
|
|
$function_table{$2} = 1;
|
|
|
|
}
|
2016-06-07 16:00:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
close(IN);
|
|
|
|
}
|
|
|
|
|
2018-02-06 05:15:19 +08:00
|
|
|
#
|
|
|
|
# Parsers for the various processing states.
|
|
|
|
#
|
|
|
|
# STATE_NORMAL: looking for the /** to begin everything.
|
|
|
|
#
|
|
|
|
sub process_normal() {
|
|
|
|
if (/$doc_start/o) {
|
|
|
|
$state = STATE_NAME; # next line is always the function name
|
|
|
|
$in_doc_sect = 0;
|
|
|
|
$declaration_start_line = $. + 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-02-06 05:36:33 +08:00
|
|
|
#
|
|
|
|
# STATE_NAME: Looking for the "name - description" line
|
|
|
|
#
|
|
|
|
sub process_name($$) {
|
|
|
|
my $file = shift;
|
2016-06-07 15:53:39 +08:00
|
|
|
my $descr;
|
2018-02-06 05:36:33 +08:00
|
|
|
|
|
|
|
if (/$doc_block/o) {
|
|
|
|
$state = STATE_DOCBLOCK;
|
|
|
|
$contents = "";
|
scripts: kernel-doc: fix line number handling
Address several issues related to pointing to the wrong line
number:
1) ensure that line numbers will always be initialized
When section is the default (Description), the line number
is not initializing, producing this:
$ ./scripts/kernel-doc --enable-lineno ./drivers/media/v4l2-core/v4l2-mem2mem.c|less
**Description**
#define LINENO 0
In case of streamoff or release called on any context,
1] If the context is currently running, then abort job will be called
2] If the context is queued, then the context will be removed from
the job_queue
Which is not right. Ensure that the line number will always
be there. After applied, the result now points to the right location:
**Description**
#define LINENO 410
In case of streamoff or release called on any context,
1] If the context is currently running, then abort job will be called
2] If the context is queued, then the context will be removed from
the job_queue
2) The line numbers for function prototypes are always + 1,
because it is taken at the line after handling the prototype.
Change the logic to point to the next line after the /** */
block;
3) The "DOC:" line number should point to the same line as this
markup is found, and not to the next one.
Probably part of the issues were due to a but that was causing
the line number offset to be incremented by one, if --export
were used.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-10-09 16:15:25 +08:00
|
|
|
$new_start_line = $.;
|
2018-02-06 05:36:33 +08:00
|
|
|
|
|
|
|
if ( $1 eq "" ) {
|
|
|
|
$section = $section_intro;
|
|
|
|
} else {
|
|
|
|
$section = $1;
|
|
|
|
}
|
2021-01-14 16:04:47 +08:00
|
|
|
} elsif (/$doc_decl/o) {
|
2018-02-06 05:36:33 +08:00
|
|
|
$identifier = $1;
|
2021-03-29 17:29:45 +08:00
|
|
|
my $is_kernel_comment = 0;
|
2021-05-14 22:42:44 +08:00
|
|
|
my $decl_start = qr{$doc_com};
|
2021-04-15 03:25:29 +08:00
|
|
|
# test for pointer declaration type, foo * bar() - desc
|
|
|
|
my $fn_type = qr{\w+\s*\*\s*};
|
|
|
|
my $parenthesis = qr{\(\w*\)};
|
|
|
|
my $decl_end = qr{[-:].*};
|
2021-05-14 22:42:44 +08:00
|
|
|
if (/^$decl_start([\w\s]+?)$parenthesis?\s*$decl_end?$/) {
|
2018-02-06 05:36:33 +08:00
|
|
|
$identifier = $1;
|
|
|
|
}
|
2021-01-14 16:04:47 +08:00
|
|
|
if ($identifier =~ m/^(struct|union|enum|typedef)\b\s*(\S*)/) {
|
|
|
|
$decl_type = $1;
|
|
|
|
$identifier = $2;
|
2021-03-29 17:29:45 +08:00
|
|
|
$is_kernel_comment = 1;
|
2021-01-14 16:04:47 +08:00
|
|
|
}
|
2021-04-15 03:25:29 +08:00
|
|
|
# Look for foo() or static void foo() - description; or misspelt
|
|
|
|
# identifier
|
2021-05-14 22:42:44 +08:00
|
|
|
elsif (/^$decl_start$fn_type?(\w+)\s*$parenthesis?\s*$decl_end?$/ ||
|
|
|
|
/^$decl_start$fn_type?(\w+.*)$parenthesis?\s*$decl_end$/) {
|
2021-04-15 03:25:29 +08:00
|
|
|
$identifier = $1;
|
|
|
|
$decl_type = 'function';
|
|
|
|
$identifier =~ s/^define\s+//;
|
|
|
|
$is_kernel_comment = 1;
|
|
|
|
}
|
2021-01-14 16:04:47 +08:00
|
|
|
$identifier =~ s/\s+$//;
|
2018-02-06 05:15:19 +08:00
|
|
|
|
2018-02-06 05:36:33 +08:00
|
|
|
$state = STATE_BODY;
|
|
|
|
# if there's no @param blocks need to set up default section
|
|
|
|
# here
|
|
|
|
$contents = "";
|
|
|
|
$section = $section_default;
|
|
|
|
$new_start_line = $. + 1;
|
2021-01-14 16:04:47 +08:00
|
|
|
if (/[-:](.*)/) {
|
2018-02-06 05:36:33 +08:00
|
|
|
# strip leading/trailing/multiple spaces
|
|
|
|
$descr= $1;
|
|
|
|
$descr =~ s/^\s*//;
|
|
|
|
$descr =~ s/\s*$//;
|
|
|
|
$descr =~ s/\s+/ /g;
|
|
|
|
$declaration_purpose = $descr;
|
|
|
|
$state = STATE_BODY_MAYBE;
|
|
|
|
} else {
|
|
|
|
$declaration_purpose = "";
|
|
|
|
}
|
|
|
|
|
2021-03-29 17:29:45 +08:00
|
|
|
if (!$is_kernel_comment) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst\n$_");
|
2021-03-29 17:29:45 +08:00
|
|
|
$state = STATE_NORMAL;
|
|
|
|
}
|
|
|
|
|
2018-02-06 05:36:33 +08:00
|
|
|
if (($declaration_purpose eq "") && $verbose) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "missing initial short description on line:\n$_");
|
2018-02-06 05:36:33 +08:00
|
|
|
}
|
|
|
|
|
2021-03-03 16:42:14 +08:00
|
|
|
if ($identifier eq "" && $decl_type ne "enum") {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "wrong kernel-doc identifier on line:\n$_");
|
2021-01-14 16:04:47 +08:00
|
|
|
$state = STATE_NORMAL;
|
2018-02-06 05:36:33 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if ($verbose) {
|
2021-01-14 16:04:47 +08:00
|
|
|
print STDERR "${file}:$.: info: Scanning doc for $decl_type $identifier\n";
|
2018-02-06 05:36:33 +08:00
|
|
|
}
|
|
|
|
} else {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "Cannot understand $_ on line $. - I thought it was a doc line\n");
|
2018-02-06 05:36:33 +08:00
|
|
|
$state = STATE_NORMAL;
|
|
|
|
}
|
|
|
|
}
|
2018-02-06 05:15:19 +08:00
|
|
|
|
2018-02-06 06:36:05 +08:00
|
|
|
|
|
|
|
#
|
|
|
|
# STATE_BODY and STATE_BODY_MAYBE: the bulk of a kerneldoc comment.
|
|
|
|
#
|
|
|
|
sub process_body($$) {
|
|
|
|
my $file = shift;
|
|
|
|
|
2020-04-15 00:48:29 +08:00
|
|
|
if ($state == STATE_BODY_WITH_BLANK_LINE && /^\s*\*\s?\S/) {
|
|
|
|
dump_section($file, $section, $contents);
|
|
|
|
$section = $section_default;
|
scripts: kernel-doc: fix line number handling
Address several issues related to pointing to the wrong line
number:
1) ensure that line numbers will always be initialized
When section is the default (Description), the line number
is not initializing, producing this:
$ ./scripts/kernel-doc --enable-lineno ./drivers/media/v4l2-core/v4l2-mem2mem.c|less
**Description**
#define LINENO 0
In case of streamoff or release called on any context,
1] If the context is currently running, then abort job will be called
2] If the context is queued, then the context will be removed from
the job_queue
Which is not right. Ensure that the line number will always
be there. After applied, the result now points to the right location:
**Description**
#define LINENO 410
In case of streamoff or release called on any context,
1] If the context is currently running, then abort job will be called
2] If the context is queued, then the context will be removed from
the job_queue
2) The line numbers for function prototypes are always + 1,
because it is taken at the line after handling the prototype.
Change the logic to point to the next line after the /** */
block;
3) The "DOC:" line number should point to the same line as this
markup is found, and not to the next one.
Probably part of the issues were due to a but that was causing
the line number offset to be incremented by one, if --export
were used.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-10-09 16:15:25 +08:00
|
|
|
$new_start_line = $.;
|
2020-04-15 00:48:29 +08:00
|
|
|
$contents = "";
|
|
|
|
}
|
|
|
|
|
2018-02-06 06:36:05 +08:00
|
|
|
if (/$doc_sect/i) { # case insensitive for supported section names
|
|
|
|
$newsection = $1;
|
|
|
|
$newcontents = $2;
|
|
|
|
|
|
|
|
# map the supported section names to the canonical names
|
|
|
|
if ($newsection =~ m/^description$/i) {
|
|
|
|
$newsection = $section_default;
|
|
|
|
} elsif ($newsection =~ m/^context$/i) {
|
|
|
|
$newsection = $section_context;
|
|
|
|
} elsif ($newsection =~ m/^returns?$/i) {
|
|
|
|
$newsection = $section_return;
|
|
|
|
} elsif ($newsection =~ m/^\@return$/) {
|
|
|
|
# special: @return is a section, not a param description
|
|
|
|
$newsection = $section_return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (($contents ne "") && ($contents ne "\n")) {
|
|
|
|
if (!$in_doc_sect && $verbose) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "contents before sections\n");
|
2018-02-06 06:36:05 +08:00
|
|
|
}
|
|
|
|
dump_section($file, $section, $contents);
|
|
|
|
$section = $section_default;
|
|
|
|
}
|
|
|
|
|
|
|
|
$in_doc_sect = 1;
|
|
|
|
$state = STATE_BODY;
|
|
|
|
$contents = $newcontents;
|
|
|
|
$new_start_line = $.;
|
|
|
|
while (substr($contents, 0, 1) eq " ") {
|
|
|
|
$contents = substr($contents, 1);
|
|
|
|
}
|
|
|
|
if ($contents ne "") {
|
|
|
|
$contents .= "\n";
|
|
|
|
}
|
|
|
|
$section = $newsection;
|
|
|
|
$leading_space = undef;
|
|
|
|
} elsif (/$doc_end/) {
|
|
|
|
if (($contents ne "") && ($contents ne "\n")) {
|
|
|
|
dump_section($file, $section, $contents);
|
|
|
|
$section = $section_default;
|
|
|
|
$contents = "";
|
|
|
|
}
|
|
|
|
# look for doc_com + <text> + doc_end:
|
|
|
|
if ($_ =~ m'\s*\*\s*[a-zA-Z_0-9:\.]+\*/') {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "suspicious ending line: $_");
|
2018-02-06 06:36:05 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
$prototype = "";
|
|
|
|
$state = STATE_PROTO;
|
|
|
|
$brcount = 0;
|
scripts: kernel-doc: fix line number handling
Address several issues related to pointing to the wrong line
number:
1) ensure that line numbers will always be initialized
When section is the default (Description), the line number
is not initializing, producing this:
$ ./scripts/kernel-doc --enable-lineno ./drivers/media/v4l2-core/v4l2-mem2mem.c|less
**Description**
#define LINENO 0
In case of streamoff or release called on any context,
1] If the context is currently running, then abort job will be called
2] If the context is queued, then the context will be removed from
the job_queue
Which is not right. Ensure that the line number will always
be there. After applied, the result now points to the right location:
**Description**
#define LINENO 410
In case of streamoff or release called on any context,
1] If the context is currently running, then abort job will be called
2] If the context is queued, then the context will be removed from
the job_queue
2) The line numbers for function prototypes are always + 1,
because it is taken at the line after handling the prototype.
Change the logic to point to the next line after the /** */
block;
3) The "DOC:" line number should point to the same line as this
markup is found, and not to the next one.
Probably part of the issues were due to a but that was causing
the line number offset to be incremented by one, if --export
were used.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2020-10-09 16:15:25 +08:00
|
|
|
$new_start_line = $. + 1;
|
2018-02-06 06:36:05 +08:00
|
|
|
} elsif (/$doc_content/) {
|
|
|
|
if ($1 eq "") {
|
2020-04-15 00:48:29 +08:00
|
|
|
if ($section eq $section_context) {
|
2018-02-06 06:36:05 +08:00
|
|
|
dump_section($file, $section, $contents);
|
|
|
|
$section = $section_default;
|
|
|
|
$contents = "";
|
|
|
|
$new_start_line = $.;
|
2020-04-15 00:48:29 +08:00
|
|
|
$state = STATE_BODY;
|
2018-02-06 06:36:05 +08:00
|
|
|
} else {
|
2020-04-15 00:48:29 +08:00
|
|
|
if ($section ne $section_default) {
|
|
|
|
$state = STATE_BODY_WITH_BLANK_LINE;
|
|
|
|
} else {
|
|
|
|
$state = STATE_BODY;
|
|
|
|
}
|
2018-02-06 06:36:05 +08:00
|
|
|
$contents .= "\n";
|
|
|
|
}
|
|
|
|
} elsif ($state == STATE_BODY_MAYBE) {
|
|
|
|
# Continued declaration purpose
|
|
|
|
chomp($declaration_purpose);
|
|
|
|
$declaration_purpose .= " " . $1;
|
|
|
|
$declaration_purpose =~ s/\s+/ /g;
|
|
|
|
} else {
|
|
|
|
my $cont = $1;
|
|
|
|
if ($section =~ m/^@/ || $section eq $section_context) {
|
|
|
|
if (!defined $leading_space) {
|
|
|
|
if ($cont =~ m/^(\s+)/) {
|
|
|
|
$leading_space = $1;
|
|
|
|
} else {
|
|
|
|
$leading_space = "";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
$cont =~ s/^$leading_space//;
|
|
|
|
}
|
|
|
|
$contents .= $cont . "\n";
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
# i dont know - bad line? ignore.
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "bad line: $_");
|
2018-02-06 06:36:05 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-02-06 06:46:30 +08:00
|
|
|
#
|
|
|
|
# STATE_PROTO: reading a function/whatever prototype.
|
|
|
|
#
|
|
|
|
sub process_proto($$) {
|
|
|
|
my $file = shift;
|
|
|
|
|
|
|
|
if (/$doc_inline_oneline/) {
|
|
|
|
$section = $1;
|
|
|
|
$contents = $2;
|
|
|
|
if ($contents ne "") {
|
|
|
|
$contents .= "\n";
|
|
|
|
dump_section($file, $section, $contents);
|
|
|
|
$section = $section_default;
|
|
|
|
$contents = "";
|
|
|
|
}
|
|
|
|
} elsif (/$doc_inline_start/) {
|
|
|
|
$state = STATE_INLINE;
|
|
|
|
$inline_doc_state = STATE_INLINE_NAME;
|
|
|
|
} elsif ($decl_type eq 'function') {
|
|
|
|
process_proto_function($_, $file);
|
|
|
|
} else {
|
|
|
|
process_proto_type($_, $file);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-02-06 07:11:47 +08:00
|
|
|
#
|
|
|
|
# STATE_DOCBLOCK: within a DOC: block.
|
|
|
|
#
|
|
|
|
sub process_docblock($$) {
|
|
|
|
my $file = shift;
|
|
|
|
|
|
|
|
if (/$doc_end/) {
|
|
|
|
dump_doc_section($file, $section, $contents);
|
|
|
|
$section = $section_default;
|
|
|
|
$contents = "";
|
|
|
|
$function = "";
|
|
|
|
%parameterdescs = ();
|
|
|
|
%parametertypes = ();
|
|
|
|
@parameterlist = ();
|
|
|
|
%sections = ();
|
|
|
|
@sectionlist = ();
|
|
|
|
$prototype = "";
|
|
|
|
$state = STATE_NORMAL;
|
|
|
|
} elsif (/$doc_content/) {
|
|
|
|
if ( $1 eq "" ) {
|
|
|
|
$contents .= $blankline;
|
|
|
|
} else {
|
|
|
|
$contents .= $1 . "\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#
|
|
|
|
# STATE_INLINE: docbook comments within a prototype.
|
|
|
|
#
|
|
|
|
sub process_inline($$) {
|
|
|
|
my $file = shift;
|
|
|
|
|
|
|
|
# First line (state 1) needs to be a @parameter
|
|
|
|
if ($inline_doc_state == STATE_INLINE_NAME && /$doc_inline_sect/o) {
|
|
|
|
$section = $1;
|
|
|
|
$contents = $2;
|
|
|
|
$new_start_line = $.;
|
|
|
|
if ($contents ne "") {
|
|
|
|
while (substr($contents, 0, 1) eq " ") {
|
|
|
|
$contents = substr($contents, 1);
|
|
|
|
}
|
|
|
|
$contents .= "\n";
|
|
|
|
}
|
|
|
|
$inline_doc_state = STATE_INLINE_TEXT;
|
|
|
|
# Documentation block end */
|
|
|
|
} elsif (/$doc_inline_end/) {
|
|
|
|
if (($contents ne "") && ($contents ne "\n")) {
|
|
|
|
dump_section($file, $section, $contents);
|
|
|
|
$section = $section_default;
|
|
|
|
$contents = "";
|
|
|
|
}
|
|
|
|
$state = STATE_PROTO;
|
|
|
|
$inline_doc_state = STATE_INLINE_NA;
|
|
|
|
# Regular text
|
|
|
|
} elsif (/$doc_content/) {
|
|
|
|
if ($inline_doc_state == STATE_INLINE_TEXT) {
|
|
|
|
$contents .= $1 . "\n";
|
|
|
|
# nuke leading blank lines
|
|
|
|
if ($contents =~ /^\s*$/) {
|
|
|
|
$contents = "";
|
|
|
|
}
|
|
|
|
} elsif ($inline_doc_state == STATE_INLINE_NAME) {
|
|
|
|
$inline_doc_state = STATE_INLINE_ERROR;
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:$.", "Incorrect use of kernel-doc format: $_");
|
2018-02-06 07:11:47 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-02-06 06:46:30 +08:00
|
|
|
|
2016-06-07 15:53:39 +08:00
|
|
|
sub process_file($) {
|
|
|
|
my $file;
|
|
|
|
my $initial_section_counter = $section_counter;
|
|
|
|
my ($orig_file) = @_;
|
|
|
|
|
|
|
|
$file = map_filename($orig_file);
|
|
|
|
|
2020-09-28 18:52:34 +08:00
|
|
|
if (!open(IN_FILE,"<$file")) {
|
2005-04-17 06:20:36 +08:00
|
|
|
print STDERR "Error: Cannot open file $file\n";
|
|
|
|
++$errors;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-02-27 05:05:47 +08:00
|
|
|
$. = 1;
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
$section_counter = 0;
|
2020-09-28 18:52:34 +08:00
|
|
|
while (<IN_FILE>) {
|
2012-10-05 08:15:05 +08:00
|
|
|
while (s/\\\s*$//) {
|
2020-09-28 18:52:34 +08:00
|
|
|
$_ .= <IN_FILE>;
|
2012-10-05 08:15:05 +08:00
|
|
|
}
|
2017-12-18 20:30:12 +08:00
|
|
|
# Replace tabs by spaces
|
|
|
|
while ($_ =~ s/\t+/' ' x (length($&) * 8 - length($`) % 8)/e) {};
|
2018-02-06 07:11:47 +08:00
|
|
|
# Hand this line to the appropriate state handler
|
2016-05-26 19:56:05 +08:00
|
|
|
if ($state == STATE_NORMAL) {
|
2018-02-06 05:15:19 +08:00
|
|
|
process_normal();
|
2018-02-06 05:36:33 +08:00
|
|
|
} elsif ($state == STATE_NAME) {
|
|
|
|
process_name($file, $_);
|
2020-04-15 00:48:29 +08:00
|
|
|
} elsif ($state == STATE_BODY || $state == STATE_BODY_MAYBE ||
|
|
|
|
$state == STATE_BODY_WITH_BLANK_LINE) {
|
2018-02-06 06:36:05 +08:00
|
|
|
process_body($file, $_);
|
2016-05-26 19:56:05 +08:00
|
|
|
} elsif ($state == STATE_INLINE) { # scanning for inline parameters
|
2018-02-06 07:11:47 +08:00
|
|
|
process_inline($file, $_);
|
2018-02-06 06:46:30 +08:00
|
|
|
} elsif ($state == STATE_PROTO) {
|
|
|
|
process_proto($file, $_);
|
2016-05-26 19:56:05 +08:00
|
|
|
} elsif ($state == STATE_DOCBLOCK) {
|
2018-02-06 07:11:47 +08:00
|
|
|
process_docblock($file, $_);
|
2007-05-08 15:24:39 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2018-02-06 07:11:47 +08:00
|
|
|
|
|
|
|
# Make sure we got something interesting.
|
2019-05-25 04:52:01 +08:00
|
|
|
if ($initial_section_counter == $section_counter && $
|
|
|
|
output_mode ne "none") {
|
|
|
|
if ($output_selection == OUTPUT_INCLUDE) {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:1", "'$_' not found\n")
|
2019-05-25 04:52:01 +08:00
|
|
|
for keys %function_table;
|
2017-11-21 02:40:40 +08:00
|
|
|
}
|
2019-05-25 04:52:01 +08:00
|
|
|
else {
|
2022-06-13 17:05:10 +08:00
|
|
|
emit_warning("${file}:1", "no structured comments found\n");
|
2013-11-13 07:11:12 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2020-09-28 18:52:34 +08:00
|
|
|
close IN_FILE;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2011-01-06 08:28:43 +08:00
|
|
|
|
|
|
|
|
2020-10-04 15:44:28 +08:00
|
|
|
if ($output_mode eq "rst") {
|
|
|
|
get_sphinx_version() if (!$sphinx_major);
|
|
|
|
}
|
|
|
|
|
2011-01-06 08:28:43 +08:00
|
|
|
$kernelversion = get_kernel_version();
|
|
|
|
|
|
|
|
# generate a sequence of code that will splice in highlighting information
|
|
|
|
# using the s// operator.
|
2015-11-17 23:29:49 +08:00
|
|
|
for (my $k = 0; $k < @highlights; $k++) {
|
2015-09-08 04:01:59 +08:00
|
|
|
my $pattern = $highlights[$k][0];
|
|
|
|
my $result = $highlights[$k][1];
|
|
|
|
# print STDERR "scanning pattern:$pattern, highlight:($result)\n";
|
|
|
|
$dohighlight .= "\$contents =~ s:$pattern:$result:gs;\n";
|
2011-01-06 08:28:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
# Read the file that maps relative names to absolute names for
|
|
|
|
# separate source and object directories and for shadow trees.
|
|
|
|
if (open(SOURCE_MAP, "<.tmp_filelist.txt")) {
|
|
|
|
my ($relname, $absname);
|
|
|
|
while(<SOURCE_MAP>) {
|
|
|
|
chop();
|
|
|
|
($relname, $absname) = (split())[0..1];
|
|
|
|
$relname =~ s:^/+::;
|
|
|
|
$source_map{$relname} = $absname;
|
|
|
|
}
|
|
|
|
close(SOURCE_MAP);
|
|
|
|
}
|
|
|
|
|
2016-06-07 16:00:52 +08:00
|
|
|
if ($output_selection == OUTPUT_EXPORTED ||
|
|
|
|
$output_selection == OUTPUT_INTERNAL) {
|
2016-06-07 16:05:53 +08:00
|
|
|
|
|
|
|
push(@export_file_list, @ARGV);
|
|
|
|
|
2016-06-07 16:00:52 +08:00
|
|
|
foreach (@export_file_list) {
|
|
|
|
chomp;
|
|
|
|
process_export_file($_);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-01-06 08:28:43 +08:00
|
|
|
foreach (@ARGV) {
|
|
|
|
chomp;
|
|
|
|
process_file($_);
|
|
|
|
}
|
|
|
|
if ($verbose && $errors) {
|
|
|
|
print STDERR "$errors errors\n";
|
|
|
|
}
|
|
|
|
if ($verbose && $warnings) {
|
|
|
|
print STDERR "$warnings warnings\n";
|
|
|
|
}
|
|
|
|
|
2020-07-29 00:20:40 +08:00
|
|
|
if ($Werror && $warnings) {
|
|
|
|
print STDERR "$warnings warnings as Errors\n";
|
|
|
|
exit($warnings);
|
|
|
|
} else {
|
|
|
|
exit($output_mode eq "none" ? 0 : $errors)
|
|
|
|
}
|
2022-02-19 02:16:21 +08:00
|
|
|
|
|
|
|
__END__
|
|
|
|
|
|
|
|
=head1 OPTIONS
|
|
|
|
|
|
|
|
=head2 Output format selection (mutually exclusive):
|
|
|
|
|
|
|
|
=over 8
|
|
|
|
|
|
|
|
=item -man
|
|
|
|
|
|
|
|
Output troff manual page format.
|
|
|
|
|
|
|
|
=item -rst
|
|
|
|
|
|
|
|
Output reStructuredText format. This is the default.
|
|
|
|
|
|
|
|
=item -none
|
|
|
|
|
|
|
|
Do not output documentation, only warnings.
|
|
|
|
|
|
|
|
=back
|
|
|
|
|
2022-02-19 02:16:22 +08:00
|
|
|
=head2 Output format modifiers
|
|
|
|
|
|
|
|
=head3 reStructuredText only
|
|
|
|
|
|
|
|
=over 8
|
|
|
|
|
|
|
|
=item -sphinx-version VERSION
|
|
|
|
|
|
|
|
Use the ReST C domain dialect compatible with a specific Sphinx Version.
|
|
|
|
|
|
|
|
If not specified, kernel-doc will auto-detect using the sphinx-build version
|
|
|
|
found on PATH.
|
|
|
|
|
|
|
|
=back
|
|
|
|
|
2022-02-19 02:16:23 +08:00
|
|
|
=head2 Output selection (mutually exclusive):
|
|
|
|
|
|
|
|
=over 8
|
|
|
|
|
|
|
|
=item -export
|
|
|
|
|
|
|
|
Only output documentation for the symbols that have been exported using
|
2022-11-30 04:29:27 +08:00
|
|
|
EXPORT_SYMBOL() and related macros in any input FILE or -export-file FILE.
|
2022-02-19 02:16:23 +08:00
|
|
|
|
|
|
|
=item -internal
|
|
|
|
|
|
|
|
Only output documentation for the symbols that have NOT been exported using
|
2022-11-30 04:29:27 +08:00
|
|
|
EXPORT_SYMBOL() and related macros in any input FILE or -export-file FILE.
|
2022-02-19 02:16:23 +08:00
|
|
|
|
|
|
|
=item -function NAME
|
|
|
|
|
|
|
|
Only output documentation for the given function or DOC: section title.
|
|
|
|
All other functions and DOC: sections are ignored.
|
|
|
|
|
|
|
|
May be specified multiple times.
|
|
|
|
|
|
|
|
=item -nosymbol NAME
|
|
|
|
|
|
|
|
Exclude the specified symbol from the output documentation.
|
|
|
|
|
|
|
|
May be specified multiple times.
|
|
|
|
|
|
|
|
=back
|
|
|
|
|
2022-02-19 02:16:24 +08:00
|
|
|
=head2 Output selection modifiers:
|
|
|
|
|
|
|
|
=over 8
|
|
|
|
|
|
|
|
=item -no-doc-sections
|
|
|
|
|
|
|
|
Do not output DOC: sections.
|
|
|
|
|
|
|
|
=item -export-file FILE
|
|
|
|
|
2022-11-30 04:29:27 +08:00
|
|
|
Specify an additional FILE in which to look for EXPORT_SYMBOL information.
|
2022-02-19 02:16:24 +08:00
|
|
|
|
|
|
|
To be used with -export or -internal.
|
|
|
|
|
|
|
|
May be specified multiple times.
|
|
|
|
|
|
|
|
=back
|
|
|
|
|
|
|
|
=head3 reStructuredText only
|
|
|
|
|
|
|
|
=over 8
|
|
|
|
|
|
|
|
=item -enable-lineno
|
|
|
|
|
2022-03-26 18:27:24 +08:00
|
|
|
Enable output of .. LINENO lines.
|
2022-02-19 02:16:24 +08:00
|
|
|
|
|
|
|
=back
|
|
|
|
|
2022-02-19 02:16:25 +08:00
|
|
|
=head2 Other parameters:
|
|
|
|
|
|
|
|
=over 8
|
|
|
|
|
|
|
|
=item -h, -help
|
|
|
|
|
|
|
|
Print this help.
|
|
|
|
|
|
|
|
=item -v
|
|
|
|
|
|
|
|
Verbose output, more warnings and other information.
|
|
|
|
|
|
|
|
=item -Werror
|
|
|
|
|
|
|
|
Treat warnings as errors.
|
|
|
|
|
|
|
|
=back
|
|
|
|
|
2022-02-19 02:16:21 +08:00
|
|
|
=cut
|