2019-05-27 14:55:06 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2006-03-25 20:19:53 +08:00
|
|
|
/*
|
2005-04-17 06:20:36 +08:00
|
|
|
* adv7170 - adv7170, adv7171 video encoder driver version 0.0.1
|
|
|
|
*
|
|
|
|
* Copyright (C) 2002 Maxim Yevtyushkin <max@linuxmedialabs.com>
|
|
|
|
*
|
2006-03-25 20:19:53 +08:00
|
|
|
* Based on adv7176 driver by:
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
|
|
|
* Copyright (C) 1998 Dave Perks <dperks@ibm.net>
|
|
|
|
* Copyright (C) 1999 Wolfgang Scherr <scherr@net4you.net>
|
|
|
|
* Copyright (C) 2000 Serguei Miridonov <mirsev@cicese.mx>
|
|
|
|
* - some corrections for Pinnacle Systems Inc. DC10plus card.
|
|
|
|
*
|
|
|
|
* Changes by Ronald Bultje <rbultje@ronald.bitfreak.net>
|
|
|
|
* - moved over to linux>=2.4.x i2c protocol (1/1/2003)
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/module.h>
|
2007-07-03 02:39:57 +08:00
|
|
|
#include <linux/types.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 16:04:11 +08:00
|
|
|
#include <linux/slab.h>
|
2008-09-07 18:58:20 +08:00
|
|
|
#include <linux/ioctl.h>
|
2016-12-25 03:46:01 +08:00
|
|
|
#include <linux/uaccess.h>
|
2008-09-07 18:58:20 +08:00
|
|
|
#include <linux/i2c.h>
|
2009-02-20 01:47:22 +08:00
|
|
|
#include <linux/videodev2.h>
|
|
|
|
#include <media/v4l2-device.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
MODULE_DESCRIPTION("Analog Devices ADV7170 video encoder driver");
|
|
|
|
MODULE_AUTHOR("Maxim Yevtyushkin");
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
|
2009-02-20 01:47:22 +08:00
|
|
|
|
2008-04-23 01:41:48 +08:00
|
|
|
static int debug;
|
2005-04-17 06:20:36 +08:00
|
|
|
module_param(debug, int, 0);
|
|
|
|
MODULE_PARM_DESC(debug, "Debug level (0-1)");
|
|
|
|
|
|
|
|
/* ----------------------------------------------------------------------- */
|
|
|
|
|
|
|
|
struct adv7170 {
|
2009-02-20 01:47:22 +08:00
|
|
|
struct v4l2_subdev sd;
|
2005-04-17 06:20:36 +08:00
|
|
|
unsigned char reg[128];
|
|
|
|
|
2009-02-19 04:26:06 +08:00
|
|
|
v4l2_std_id norm;
|
2005-04-17 06:20:36 +08:00
|
|
|
int input;
|
|
|
|
};
|
|
|
|
|
2009-02-20 01:47:22 +08:00
|
|
|
static inline struct adv7170 *to_adv7170(struct v4l2_subdev *sd)
|
|
|
|
{
|
|
|
|
return container_of(sd, struct adv7170, sd);
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
static char *inputs[] = { "pass_through", "play_back" };
|
|
|
|
|
2014-11-11 01:28:29 +08:00
|
|
|
static u32 adv7170_codes[] = {
|
|
|
|
MEDIA_BUS_FMT_UYVY8_2X8,
|
|
|
|
MEDIA_BUS_FMT_UYVY8_1X16,
|
2011-10-28 05:50:21 +08:00
|
|
|
};
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/* ----------------------------------------------------------------------- */
|
|
|
|
|
2009-02-20 01:47:22 +08:00
|
|
|
static inline int adv7170_write(struct v4l2_subdev *sd, u8 reg, u8 value)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-02-20 01:47:22 +08:00
|
|
|
struct i2c_client *client = v4l2_get_subdevdata(sd);
|
|
|
|
struct adv7170 *encoder = to_adv7170(sd);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
encoder->reg[reg] = value;
|
|
|
|
return i2c_smbus_write_byte_data(client, reg, value);
|
|
|
|
}
|
|
|
|
|
2009-02-20 01:47:22 +08:00
|
|
|
static inline int adv7170_read(struct v4l2_subdev *sd, u8 reg)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-02-20 01:47:22 +08:00
|
|
|
struct i2c_client *client = v4l2_get_subdevdata(sd);
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
return i2c_smbus_read_byte_data(client, reg);
|
|
|
|
}
|
|
|
|
|
2009-02-20 01:47:22 +08:00
|
|
|
static int adv7170_write_block(struct v4l2_subdev *sd,
|
2008-09-07 18:58:20 +08:00
|
|
|
const u8 *data, unsigned int len)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-02-20 01:47:22 +08:00
|
|
|
struct i2c_client *client = v4l2_get_subdevdata(sd);
|
|
|
|
struct adv7170 *encoder = to_adv7170(sd);
|
2005-04-17 06:20:36 +08:00
|
|
|
int ret = -1;
|
|
|
|
u8 reg;
|
|
|
|
|
|
|
|
/* the adv7170 has an autoincrement function, use it if
|
|
|
|
* the adapter understands raw I2C */
|
|
|
|
if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
|
|
|
|
/* do raw I2C, not smbus compatible */
|
|
|
|
u8 block_data[32];
|
2006-03-22 14:48:35 +08:00
|
|
|
int block_len;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
while (len >= 2) {
|
2006-03-22 14:48:35 +08:00
|
|
|
block_len = 0;
|
|
|
|
block_data[block_len++] = reg = data[0];
|
2005-04-17 06:20:36 +08:00
|
|
|
do {
|
2006-03-22 14:48:35 +08:00
|
|
|
block_data[block_len++] =
|
2005-04-17 06:20:36 +08:00
|
|
|
encoder->reg[reg++] = data[1];
|
|
|
|
len -= 2;
|
|
|
|
data += 2;
|
2008-09-07 18:58:20 +08:00
|
|
|
} while (len >= 2 && data[0] == reg && block_len < 32);
|
|
|
|
ret = i2c_master_send(client, block_data, block_len);
|
|
|
|
if (ret < 0)
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/* do some slow I2C emulation kind of thing */
|
|
|
|
while (len >= 2) {
|
|
|
|
reg = *data++;
|
2009-02-20 01:47:22 +08:00
|
|
|
ret = adv7170_write(sd, reg, *data++);
|
2008-09-07 18:58:20 +08:00
|
|
|
if (ret < 0)
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
len -= 2;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* ----------------------------------------------------------------------- */
|
|
|
|
|
|
|
|
#define TR0MODE 0x4c
|
|
|
|
#define TR0RST 0x80
|
|
|
|
|
|
|
|
#define TR1CAPT 0x00
|
|
|
|
#define TR1PLAY 0x00
|
|
|
|
|
|
|
|
static const unsigned char init_NTSC[] = {
|
2009-02-20 01:47:22 +08:00
|
|
|
0x00, 0x10, /* MR0 */
|
|
|
|
0x01, 0x20, /* MR1 */
|
|
|
|
0x02, 0x0e, /* MR2 RTC control: bits 2 and 1 */
|
|
|
|
0x03, 0x80, /* MR3 */
|
|
|
|
0x04, 0x30, /* MR4 */
|
|
|
|
0x05, 0x00, /* Reserved */
|
|
|
|
0x06, 0x00, /* Reserved */
|
|
|
|
0x07, TR0MODE, /* TM0 */
|
|
|
|
0x08, TR1CAPT, /* TM1 */
|
|
|
|
0x09, 0x16, /* Fsc0 */
|
|
|
|
0x0a, 0x7c, /* Fsc1 */
|
|
|
|
0x0b, 0xf0, /* Fsc2 */
|
|
|
|
0x0c, 0x21, /* Fsc3 */
|
|
|
|
0x0d, 0x00, /* Subcarrier Phase */
|
|
|
|
0x0e, 0x00, /* Closed Capt. Ext 0 */
|
|
|
|
0x0f, 0x00, /* Closed Capt. Ext 1 */
|
|
|
|
0x10, 0x00, /* Closed Capt. 0 */
|
|
|
|
0x11, 0x00, /* Closed Capt. 1 */
|
|
|
|
0x12, 0x00, /* Pedestal Ctl 0 */
|
|
|
|
0x13, 0x00, /* Pedestal Ctl 1 */
|
|
|
|
0x14, 0x00, /* Pedestal Ctl 2 */
|
|
|
|
0x15, 0x00, /* Pedestal Ctl 3 */
|
|
|
|
0x16, 0x00, /* CGMS_WSS_0 */
|
|
|
|
0x17, 0x00, /* CGMS_WSS_1 */
|
|
|
|
0x18, 0x00, /* CGMS_WSS_2 */
|
|
|
|
0x19, 0x00, /* Teletext Ctl */
|
2005-04-17 06:20:36 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const unsigned char init_PAL[] = {
|
2009-02-20 01:47:22 +08:00
|
|
|
0x00, 0x71, /* MR0 */
|
|
|
|
0x01, 0x20, /* MR1 */
|
|
|
|
0x02, 0x0e, /* MR2 RTC control: bits 2 and 1 */
|
|
|
|
0x03, 0x80, /* MR3 */
|
|
|
|
0x04, 0x30, /* MR4 */
|
|
|
|
0x05, 0x00, /* Reserved */
|
|
|
|
0x06, 0x00, /* Reserved */
|
|
|
|
0x07, TR0MODE, /* TM0 */
|
|
|
|
0x08, TR1CAPT, /* TM1 */
|
|
|
|
0x09, 0xcb, /* Fsc0 */
|
|
|
|
0x0a, 0x8a, /* Fsc1 */
|
|
|
|
0x0b, 0x09, /* Fsc2 */
|
|
|
|
0x0c, 0x2a, /* Fsc3 */
|
|
|
|
0x0d, 0x00, /* Subcarrier Phase */
|
|
|
|
0x0e, 0x00, /* Closed Capt. Ext 0 */
|
|
|
|
0x0f, 0x00, /* Closed Capt. Ext 1 */
|
|
|
|
0x10, 0x00, /* Closed Capt. 0 */
|
|
|
|
0x11, 0x00, /* Closed Capt. 1 */
|
|
|
|
0x12, 0x00, /* Pedestal Ctl 0 */
|
|
|
|
0x13, 0x00, /* Pedestal Ctl 1 */
|
|
|
|
0x14, 0x00, /* Pedestal Ctl 2 */
|
|
|
|
0x15, 0x00, /* Pedestal Ctl 3 */
|
|
|
|
0x16, 0x00, /* CGMS_WSS_0 */
|
|
|
|
0x17, 0x00, /* CGMS_WSS_1 */
|
|
|
|
0x18, 0x00, /* CGMS_WSS_2 */
|
|
|
|
0x19, 0x00, /* Teletext Ctl */
|
2005-04-17 06:20:36 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2009-02-20 01:47:22 +08:00
|
|
|
static int adv7170_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-02-20 01:47:22 +08:00
|
|
|
struct adv7170 *encoder = to_adv7170(sd);
|
|
|
|
|
2009-03-06 21:15:01 +08:00
|
|
|
v4l2_dbg(1, debug, sd, "set norm %llx\n", (unsigned long long)std);
|
2009-02-20 01:47:22 +08:00
|
|
|
|
|
|
|
if (std & V4L2_STD_NTSC) {
|
|
|
|
adv7170_write_block(sd, init_NTSC, sizeof(init_NTSC));
|
|
|
|
if (encoder->input == 0)
|
|
|
|
adv7170_write(sd, 0x02, 0x0e); /* Enable genlock */
|
|
|
|
adv7170_write(sd, 0x07, TR0MODE | TR0RST);
|
|
|
|
adv7170_write(sd, 0x07, TR0MODE);
|
|
|
|
} else if (std & V4L2_STD_PAL) {
|
|
|
|
adv7170_write_block(sd, init_PAL, sizeof(init_PAL));
|
|
|
|
if (encoder->input == 0)
|
|
|
|
adv7170_write(sd, 0x02, 0x0e); /* Enable genlock */
|
|
|
|
adv7170_write(sd, 0x07, TR0MODE | TR0RST);
|
|
|
|
adv7170_write(sd, 0x07, TR0MODE);
|
|
|
|
} else {
|
2009-03-06 21:15:01 +08:00
|
|
|
v4l2_dbg(1, debug, sd, "illegal norm: %llx\n",
|
|
|
|
(unsigned long long)std);
|
2009-02-20 01:47:22 +08:00
|
|
|
return -EINVAL;
|
2008-09-07 18:58:20 +08:00
|
|
|
}
|
2009-03-06 21:15:01 +08:00
|
|
|
v4l2_dbg(1, debug, sd, "switched to %llx\n", (unsigned long long)std);
|
2009-02-20 01:47:22 +08:00
|
|
|
encoder->norm = std;
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-04-02 22:26:22 +08:00
|
|
|
static int adv7170_s_routing(struct v4l2_subdev *sd,
|
|
|
|
u32 input, u32 output, u32 config)
|
2009-02-20 01:47:22 +08:00
|
|
|
{
|
|
|
|
struct adv7170 *encoder = to_adv7170(sd);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-04-02 22:26:22 +08:00
|
|
|
/* RJ: input = 0: input is from decoder
|
|
|
|
input = 1: input is from ZR36060
|
|
|
|
input = 2: color bar */
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-02-20 01:47:22 +08:00
|
|
|
v4l2_dbg(1, debug, sd, "set input from %s\n",
|
2009-04-02 22:26:22 +08:00
|
|
|
input == 0 ? "decoder" : "ZR36060");
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-04-02 22:26:22 +08:00
|
|
|
switch (input) {
|
2009-02-20 01:47:22 +08:00
|
|
|
case 0:
|
|
|
|
adv7170_write(sd, 0x01, 0x20);
|
|
|
|
adv7170_write(sd, 0x08, TR1CAPT); /* TR1 */
|
|
|
|
adv7170_write(sd, 0x02, 0x0e); /* Enable genlock */
|
|
|
|
adv7170_write(sd, 0x07, TR0MODE | TR0RST);
|
|
|
|
adv7170_write(sd, 0x07, TR0MODE);
|
|
|
|
/* udelay(10); */
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 1:
|
|
|
|
adv7170_write(sd, 0x01, 0x00);
|
|
|
|
adv7170_write(sd, 0x08, TR1PLAY); /* TR1 */
|
|
|
|
adv7170_write(sd, 0x02, 0x08);
|
|
|
|
adv7170_write(sd, 0x07, TR0MODE | TR0RST);
|
|
|
|
adv7170_write(sd, 0x07, TR0MODE);
|
|
|
|
/* udelay(10); */
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
2009-04-02 22:26:22 +08:00
|
|
|
v4l2_dbg(1, debug, sd, "illegal input: %d\n", input);
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
2009-04-02 22:26:22 +08:00
|
|
|
v4l2_dbg(1, debug, sd, "switched to %s\n", inputs[input]);
|
|
|
|
encoder->input = input;
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-04-09 15:01:33 +08:00
|
|
|
static int adv7170_enum_mbus_code(struct v4l2_subdev *sd,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2015-04-09 15:01:33 +08:00
|
|
|
struct v4l2_subdev_mbus_code_enum *code)
|
2011-10-28 05:50:21 +08:00
|
|
|
{
|
2015-04-09 15:01:33 +08:00
|
|
|
if (code->pad || code->index >= ARRAY_SIZE(adv7170_codes))
|
2011-10-28 05:50:21 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
2015-04-09 15:01:33 +08:00
|
|
|
code->code = adv7170_codes[code->index];
|
2011-10-28 05:50:21 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-04-09 15:02:34 +08:00
|
|
|
static int adv7170_get_fmt(struct v4l2_subdev *sd,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2015-04-09 15:02:34 +08:00
|
|
|
struct v4l2_subdev_format *format)
|
2011-10-28 05:50:21 +08:00
|
|
|
{
|
2015-04-09 15:02:34 +08:00
|
|
|
struct v4l2_mbus_framefmt *mf = &format->format;
|
2011-10-28 05:50:21 +08:00
|
|
|
u8 val = adv7170_read(sd, 0x7);
|
|
|
|
|
2015-04-09 15:02:34 +08:00
|
|
|
if (format->pad)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2011-10-28 05:50:21 +08:00
|
|
|
if ((val & 0x40) == (1 << 6))
|
2014-11-11 01:28:29 +08:00
|
|
|
mf->code = MEDIA_BUS_FMT_UYVY8_1X16;
|
2011-10-28 05:50:21 +08:00
|
|
|
else
|
2014-11-11 01:28:29 +08:00
|
|
|
mf->code = MEDIA_BUS_FMT_UYVY8_2X8;
|
2011-10-28 05:50:21 +08:00
|
|
|
|
|
|
|
mf->colorspace = V4L2_COLORSPACE_SMPTE170M;
|
|
|
|
mf->width = 0;
|
|
|
|
mf->height = 0;
|
|
|
|
mf->field = V4L2_FIELD_ANY;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-03-21 20:39:09 +08:00
|
|
|
static int adv7170_set_fmt(struct v4l2_subdev *sd,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 22:55:58 +08:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2015-03-21 20:39:09 +08:00
|
|
|
struct v4l2_subdev_format *format)
|
2011-10-28 05:50:21 +08:00
|
|
|
{
|
2015-03-21 20:39:09 +08:00
|
|
|
struct v4l2_mbus_framefmt *mf = &format->format;
|
2011-10-28 05:50:21 +08:00
|
|
|
u8 val = adv7170_read(sd, 0x7);
|
2015-03-21 20:39:09 +08:00
|
|
|
|
|
|
|
if (format->pad)
|
|
|
|
return -EINVAL;
|
2011-10-28 05:50:21 +08:00
|
|
|
|
|
|
|
switch (mf->code) {
|
2014-11-11 01:28:29 +08:00
|
|
|
case MEDIA_BUS_FMT_UYVY8_2X8:
|
2011-10-28 05:50:21 +08:00
|
|
|
val &= ~0x40;
|
|
|
|
break;
|
|
|
|
|
2014-11-11 01:28:29 +08:00
|
|
|
case MEDIA_BUS_FMT_UYVY8_1X16:
|
2011-10-28 05:50:21 +08:00
|
|
|
val |= 0x40;
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
v4l2_dbg(1, debug, sd,
|
|
|
|
"illegal v4l2_mbus_framefmt code: %d\n", mf->code);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2015-03-21 20:39:09 +08:00
|
|
|
if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
|
2017-01-04 04:22:43 +08:00
|
|
|
return adv7170_write(sd, 0x7, val);
|
2011-10-28 05:50:21 +08:00
|
|
|
|
2017-01-04 04:22:43 +08:00
|
|
|
return 0;
|
2011-10-28 05:50:21 +08:00
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/* ----------------------------------------------------------------------- */
|
|
|
|
|
2009-02-20 01:47:22 +08:00
|
|
|
static const struct v4l2_subdev_video_ops adv7170_video_ops = {
|
|
|
|
.s_std_output = adv7170_s_std_output,
|
|
|
|
.s_routing = adv7170_s_routing,
|
2015-04-09 15:01:33 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct v4l2_subdev_pad_ops adv7170_pad_ops = {
|
|
|
|
.enum_mbus_code = adv7170_enum_mbus_code,
|
2015-04-09 15:02:34 +08:00
|
|
|
.get_fmt = adv7170_get_fmt,
|
2015-03-21 20:39:09 +08:00
|
|
|
.set_fmt = adv7170_set_fmt,
|
2009-02-20 01:47:22 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct v4l2_subdev_ops adv7170_ops = {
|
|
|
|
.video = &adv7170_video_ops,
|
2015-04-09 15:01:33 +08:00
|
|
|
.pad = &adv7170_pad_ops,
|
2009-02-20 01:47:22 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
/* ----------------------------------------------------------------------- */
|
2006-03-25 20:19:53 +08:00
|
|
|
|
2022-11-19 06:41:00 +08:00
|
|
|
static int adv7170_probe(struct i2c_client *client)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct adv7170 *encoder;
|
2009-02-20 01:47:22 +08:00
|
|
|
struct v4l2_subdev *sd;
|
2008-09-07 18:58:20 +08:00
|
|
|
int i;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/* Check if the adapter supports the needed features */
|
2008-09-07 18:58:20 +08:00
|
|
|
if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA))
|
|
|
|
return -ENODEV;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-09-07 18:58:20 +08:00
|
|
|
v4l_info(client, "chip found @ 0x%x (%s)\n",
|
|
|
|
client->addr << 1, client->adapter->name);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2013-05-02 19:29:43 +08:00
|
|
|
encoder = devm_kzalloc(&client->dev, sizeof(*encoder), GFP_KERNEL);
|
2008-09-07 18:58:20 +08:00
|
|
|
if (encoder == NULL)
|
2005-04-17 06:20:36 +08:00
|
|
|
return -ENOMEM;
|
2009-02-20 01:47:22 +08:00
|
|
|
sd = &encoder->sd;
|
|
|
|
v4l2_i2c_subdev_init(sd, client, &adv7170_ops);
|
2009-02-19 04:26:06 +08:00
|
|
|
encoder->norm = V4L2_STD_NTSC;
|
2005-04-17 06:20:36 +08:00
|
|
|
encoder->input = 0;
|
|
|
|
|
2009-02-20 01:47:22 +08:00
|
|
|
i = adv7170_write_block(sd, init_NTSC, sizeof(init_NTSC));
|
2005-04-17 06:20:36 +08:00
|
|
|
if (i >= 0) {
|
2009-02-20 01:47:22 +08:00
|
|
|
i = adv7170_write(sd, 0x07, TR0MODE | TR0RST);
|
|
|
|
i = adv7170_write(sd, 0x07, TR0MODE);
|
|
|
|
i = adv7170_read(sd, 0x12);
|
|
|
|
v4l2_dbg(1, debug, sd, "revision %d\n", i & 1);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2008-09-07 18:58:20 +08:00
|
|
|
if (i < 0)
|
2009-02-20 01:47:22 +08:00
|
|
|
v4l2_dbg(1, debug, sd, "init error 0x%x\n", i);
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2022-08-15 16:02:30 +08:00
|
|
|
static void adv7170_remove(struct i2c_client *client)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-02-20 01:47:22 +08:00
|
|
|
struct v4l2_subdev *sd = i2c_get_clientdata(client);
|
|
|
|
|
|
|
|
v4l2_device_unregister_subdev(sd);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* ----------------------------------------------------------------------- */
|
|
|
|
|
2008-09-07 18:58:20 +08:00
|
|
|
static const struct i2c_device_id adv7170_id[] = {
|
|
|
|
{ "adv7170", 0 },
|
|
|
|
{ "adv7171", 0 },
|
|
|
|
{ }
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(i2c, adv7170_id);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-09-16 02:49:56 +08:00
|
|
|
static struct i2c_driver adv7170_driver = {
|
|
|
|
.driver = {
|
|
|
|
.name = "adv7170",
|
|
|
|
},
|
2023-05-14 20:04:07 +08:00
|
|
|
.probe = adv7170_probe,
|
2010-09-16 02:49:56 +08:00
|
|
|
.remove = adv7170_remove,
|
|
|
|
.id_table = adv7170_id,
|
2005-04-17 06:20:36 +08:00
|
|
|
};
|
2010-09-16 02:49:56 +08:00
|
|
|
|
2012-02-12 17:56:32 +08:00
|
|
|
module_i2c_driver(adv7170_driver);
|