2018-06-06 10:42:14 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2013-04-03 13:11:18 +08:00
|
|
|
/*
|
|
|
|
* Copyright (c) 2000-2006 Silicon Graphics, Inc.
|
|
|
|
* Copyright (c) 2012-2013 Red Hat, Inc.
|
|
|
|
* All rights reserved.
|
|
|
|
*/
|
|
|
|
#include "xfs.h"
|
2013-10-23 07:50:10 +08:00
|
|
|
#include "xfs_shared.h"
|
2013-04-03 13:11:18 +08:00
|
|
|
#include "xfs_fs.h"
|
2013-08-12 18:49:26 +08:00
|
|
|
#include "xfs_format.h"
|
2013-10-23 07:50:10 +08:00
|
|
|
#include "xfs_log_format.h"
|
|
|
|
#include "xfs_trans_resv.h"
|
2013-04-03 13:11:18 +08:00
|
|
|
#include "xfs_bit.h"
|
|
|
|
#include "xfs_mount.h"
|
2013-08-12 18:49:37 +08:00
|
|
|
#include "xfs_dir2.h"
|
2013-04-03 13:11:18 +08:00
|
|
|
#include "xfs_inode.h"
|
|
|
|
#include "xfs_bmap.h"
|
2013-10-23 07:51:50 +08:00
|
|
|
#include "xfs_bmap_btree.h"
|
2013-04-03 13:11:18 +08:00
|
|
|
#include "xfs_quota.h"
|
2019-11-07 09:19:33 +08:00
|
|
|
#include "xfs_symlink.h"
|
2013-04-03 13:11:18 +08:00
|
|
|
#include "xfs_trans_space.h"
|
|
|
|
#include "xfs_trace.h"
|
2013-10-23 07:50:10 +08:00
|
|
|
#include "xfs_trans.h"
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
/* ----- Kernel only functions below ----- */
|
2017-06-17 02:00:15 +08:00
|
|
|
int
|
|
|
|
xfs_readlink_bmap_ilocked(
|
2013-04-03 13:11:19 +08:00
|
|
|
struct xfs_inode *ip,
|
|
|
|
char *link)
|
2013-04-03 13:11:18 +08:00
|
|
|
{
|
2013-04-03 13:11:19 +08:00
|
|
|
struct xfs_mount *mp = ip->i_mount;
|
|
|
|
struct xfs_bmbt_irec mval[XFS_SYMLINK_MAPS];
|
|
|
|
struct xfs_buf *bp;
|
|
|
|
xfs_daddr_t d;
|
|
|
|
char *cur_chunk;
|
2021-03-30 02:11:40 +08:00
|
|
|
int pathlen = ip->i_disk_size;
|
2013-04-03 13:11:19 +08:00
|
|
|
int nmaps = XFS_SYMLINK_MAPS;
|
|
|
|
int byte_cnt;
|
|
|
|
int n;
|
|
|
|
int error = 0;
|
|
|
|
int fsblocks = 0;
|
|
|
|
int offset;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2017-07-14 03:14:34 +08:00
|
|
|
ASSERT(xfs_isilocked(ip, XFS_ILOCK_SHARED | XFS_ILOCK_EXCL));
|
|
|
|
|
2013-04-03 13:11:19 +08:00
|
|
|
fsblocks = xfs_symlink_blocks(mp, pathlen);
|
|
|
|
error = xfs_bmapi_read(ip, 0, fsblocks, mval, &nmaps, 0);
|
2013-04-03 13:11:18 +08:00
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
|
2013-04-03 13:11:19 +08:00
|
|
|
offset = 0;
|
2013-04-03 13:11:18 +08:00
|
|
|
for (n = 0; n < nmaps; n++) {
|
|
|
|
d = XFS_FSB_TO_DADDR(mp, mval[n].br_startblock);
|
|
|
|
byte_cnt = XFS_FSB_TO_B(mp, mval[n].br_blockcount);
|
|
|
|
|
2020-01-24 09:01:17 +08:00
|
|
|
error = xfs_buf_read(mp->m_ddev_targp, d, BTOBB(byte_cnt), 0,
|
|
|
|
&bp, &xfs_symlink_buf_ops);
|
|
|
|
if (error)
|
|
|
|
return error;
|
2013-04-03 13:11:19 +08:00
|
|
|
byte_cnt = XFS_SYMLINK_BUF_SPACE(mp, byte_cnt);
|
2013-04-03 13:11:18 +08:00
|
|
|
if (pathlen < byte_cnt)
|
|
|
|
byte_cnt = pathlen;
|
2013-04-03 13:11:19 +08:00
|
|
|
|
|
|
|
cur_chunk = bp->b_addr;
|
|
|
|
if (xfs_sb_version_hascrc(&mp->m_sb)) {
|
2014-04-14 17:05:43 +08:00
|
|
|
if (!xfs_symlink_hdr_ok(ip->i_ino, offset,
|
2013-04-03 13:11:19 +08:00
|
|
|
byte_cnt, bp)) {
|
2014-06-25 12:58:08 +08:00
|
|
|
error = -EFSCORRUPTED;
|
2013-04-03 13:11:19 +08:00
|
|
|
xfs_alert(mp,
|
|
|
|
"symlink header does not match required off/len/owner (0x%x/Ox%x,0x%llx)",
|
|
|
|
offset, byte_cnt, ip->i_ino);
|
|
|
|
xfs_buf_relse(bp);
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
cur_chunk += sizeof(struct xfs_dsymlink_hdr);
|
|
|
|
}
|
|
|
|
|
2015-06-22 07:42:48 +08:00
|
|
|
memcpy(link + offset, cur_chunk, byte_cnt);
|
2013-04-03 13:11:19 +08:00
|
|
|
|
2013-04-03 13:11:18 +08:00
|
|
|
pathlen -= byte_cnt;
|
2013-04-03 13:11:19 +08:00
|
|
|
offset += byte_cnt;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
xfs_buf_relse(bp);
|
|
|
|
}
|
2013-04-03 13:11:19 +08:00
|
|
|
ASSERT(pathlen == 0);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2021-03-30 02:11:40 +08:00
|
|
|
link[ip->i_disk_size] = '\0';
|
2013-04-03 13:11:18 +08:00
|
|
|
error = 0;
|
|
|
|
|
|
|
|
out:
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
xfs_readlink(
|
2013-04-03 13:11:19 +08:00
|
|
|
struct xfs_inode *ip,
|
2013-04-03 13:11:18 +08:00
|
|
|
char *link)
|
|
|
|
{
|
2013-04-03 13:11:19 +08:00
|
|
|
struct xfs_mount *mp = ip->i_mount;
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_fsize_t pathlen;
|
|
|
|
int error = 0;
|
|
|
|
|
|
|
|
trace_xfs_readlink(ip);
|
|
|
|
|
2021-04-14 02:15:11 +08:00
|
|
|
ASSERT(ip->i_df.if_format != XFS_DINODE_FMT_LOCAL);
|
2016-04-06 05:53:29 +08:00
|
|
|
|
2013-04-03 13:11:18 +08:00
|
|
|
if (XFS_FORCED_SHUTDOWN(mp))
|
2014-06-25 12:58:08 +08:00
|
|
|
return -EIO;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
xfs_ilock(ip, XFS_ILOCK_SHARED);
|
|
|
|
|
2021-03-30 02:11:40 +08:00
|
|
|
pathlen = ip->i_disk_size;
|
2013-04-03 13:11:18 +08:00
|
|
|
if (!pathlen)
|
|
|
|
goto out;
|
|
|
|
|
2017-07-07 23:37:26 +08:00
|
|
|
if (pathlen < 0 || pathlen > XFS_SYMLINK_MAXLEN) {
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_alert(mp, "%s: inode (%llu) bad symlink length (%lld)",
|
|
|
|
__func__, (unsigned long long) ip->i_ino,
|
|
|
|
(long long) pathlen);
|
|
|
|
ASSERT(0);
|
2014-06-25 12:58:08 +08:00
|
|
|
error = -EFSCORRUPTED;
|
2013-04-03 13:11:18 +08:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2017-06-17 02:00:15 +08:00
|
|
|
error = xfs_readlink_bmap_ilocked(ip, link);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
out:
|
|
|
|
xfs_iunlock(ip, XFS_ILOCK_SHARED);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
xfs_symlink(
|
2021-01-21 21:19:58 +08:00
|
|
|
struct user_namespace *mnt_userns,
|
2013-04-03 13:11:19 +08:00
|
|
|
struct xfs_inode *dp,
|
2013-04-03 13:11:18 +08:00
|
|
|
struct xfs_name *link_name,
|
|
|
|
const char *target_path,
|
|
|
|
umode_t mode,
|
2013-04-03 13:11:19 +08:00
|
|
|
struct xfs_inode **ipp)
|
2013-04-03 13:11:18 +08:00
|
|
|
{
|
2013-04-03 13:11:19 +08:00
|
|
|
struct xfs_mount *mp = dp->i_mount;
|
|
|
|
struct xfs_trans *tp = NULL;
|
|
|
|
struct xfs_inode *ip = NULL;
|
|
|
|
int error = 0;
|
2013-04-03 13:11:18 +08:00
|
|
|
int pathlen;
|
2015-02-23 19:38:08 +08:00
|
|
|
bool unlock_dp_on_error = false;
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_fileoff_t first_fsb;
|
|
|
|
xfs_filblks_t fs_blocks;
|
|
|
|
int nmaps;
|
2013-04-03 13:11:19 +08:00
|
|
|
struct xfs_bmbt_irec mval[XFS_SYMLINK_MAPS];
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_daddr_t d;
|
|
|
|
const char *cur_chunk;
|
|
|
|
int byte_cnt;
|
|
|
|
int n;
|
2020-12-17 08:07:34 +08:00
|
|
|
struct xfs_buf *bp;
|
2013-04-03 13:11:18 +08:00
|
|
|
prid_t prid;
|
2013-06-28 06:25:07 +08:00
|
|
|
struct xfs_dquot *udqp = NULL;
|
|
|
|
struct xfs_dquot *gdqp = NULL;
|
2013-07-11 13:00:40 +08:00
|
|
|
struct xfs_dquot *pdqp = NULL;
|
2013-04-03 13:11:18 +08:00
|
|
|
uint resblks;
|
|
|
|
|
|
|
|
*ipp = NULL;
|
|
|
|
|
|
|
|
trace_xfs_symlink(dp, link_name);
|
|
|
|
|
|
|
|
if (XFS_FORCED_SHUTDOWN(mp))
|
2014-06-25 12:58:08 +08:00
|
|
|
return -EIO;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Check component lengths of the target path name.
|
|
|
|
*/
|
|
|
|
pathlen = strlen(target_path);
|
2017-07-07 23:37:26 +08:00
|
|
|
if (pathlen >= XFS_SYMLINK_MAXLEN) /* total string too long */
|
2014-06-25 12:58:08 +08:00
|
|
|
return -ENAMETOOLONG;
|
2018-12-13 00:46:21 +08:00
|
|
|
ASSERT(pathlen > 0);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2013-12-18 08:22:39 +08:00
|
|
|
prid = xfs_get_initial_prid(dp);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Make sure that we have allocated dquot(s) on disk.
|
|
|
|
*/
|
2021-03-03 01:32:52 +08:00
|
|
|
error = xfs_qm_vop_dqalloc(dp, fsuid_into_mnt(mnt_userns),
|
|
|
|
fsgid_into_mnt(mnt_userns), prid,
|
2013-08-16 02:08:01 +08:00
|
|
|
XFS_QMOPT_QUOTALL | XFS_QMOPT_INHERIT,
|
|
|
|
&udqp, &gdqp, &pdqp);
|
2013-04-03 13:11:18 +08:00
|
|
|
if (error)
|
2015-02-23 19:38:08 +08:00
|
|
|
return error;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The symlink will fit into the inode data fork?
|
|
|
|
* There can't be any attributes so we get the whole variable part.
|
|
|
|
*/
|
2020-03-18 23:15:10 +08:00
|
|
|
if (pathlen <= XFS_LITINO(mp))
|
2013-04-03 13:11:18 +08:00
|
|
|
fs_blocks = 0;
|
|
|
|
else
|
2013-05-27 14:38:20 +08:00
|
|
|
fs_blocks = xfs_symlink_blocks(mp, pathlen);
|
2013-04-03 13:11:18 +08:00
|
|
|
resblks = XFS_SYMLINK_SPACE_RES(mp, link_name->len, fs_blocks);
|
2016-04-06 07:19:55 +08:00
|
|
|
|
2021-01-28 04:07:57 +08:00
|
|
|
error = xfs_trans_alloc_icreate(mp, &M_RES(mp)->tr_symlink, udqp, gdqp,
|
|
|
|
pdqp, resblks, &tp);
|
2015-06-04 11:47:56 +08:00
|
|
|
if (error)
|
2021-01-28 04:07:57 +08:00
|
|
|
goto out_release_dquots;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2016-11-30 11:33:25 +08:00
|
|
|
xfs_ilock(dp, XFS_ILOCK_EXCL | XFS_ILOCK_PARENT);
|
2013-04-03 13:11:18 +08:00
|
|
|
unlock_dp_on_error = true;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Check whether the directory allows new symlinks or not.
|
|
|
|
*/
|
2021-03-30 02:11:44 +08:00
|
|
|
if (dp->i_diflags & XFS_DIFLAG_NOSYMLINKS) {
|
2014-06-25 12:58:08 +08:00
|
|
|
error = -EPERM;
|
2015-02-23 19:38:08 +08:00
|
|
|
goto out_trans_cancel;
|
2013-04-03 13:11:18 +08:00
|
|
|
}
|
|
|
|
|
2021-01-23 08:48:12 +08:00
|
|
|
error = xfs_iext_count_may_overflow(dp, XFS_DATA_FORK,
|
|
|
|
XFS_IEXT_DIR_MANIP_CNT(mp));
|
|
|
|
if (error)
|
2015-02-23 19:38:08 +08:00
|
|
|
goto out_trans_cancel;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Allocate an inode for the symlink.
|
|
|
|
*/
|
2021-01-21 21:19:58 +08:00
|
|
|
error = xfs_dir_ialloc(mnt_userns, &tp, dp, S_IFLNK | (mode & ~S_IFMT),
|
xfs: initialise attr fork on inode create
When we allocate a new inode, we often need to add an attribute to
the inode as part of the create. This can happen as a result of
needing to add default ACLs or security labels before the inode is
made visible to userspace.
This is highly inefficient right now. We do the create transaction
to allocate the inode, then we do an "add attr fork" transaction to
modify the just created empty inode to set the inode fork offset to
allow attributes to be stored, then we go and do the attribute
creation.
This means 3 transactions instead of 1 to allocate an inode, and
this greatly increases the load on the CIL commit code, resulting in
excessive contention on the CIL spin locks and performance
degradation:
18.99% [kernel] [k] __pv_queued_spin_lock_slowpath
3.57% [kernel] [k] do_raw_spin_lock
2.51% [kernel] [k] __raw_callee_save___pv_queued_spin_unlock
2.48% [kernel] [k] memcpy
2.34% [kernel] [k] xfs_log_commit_cil
The typical profile resulting from running fsmark on a selinux enabled
filesytem is adds this overhead to the create path:
- 15.30% xfs_init_security
- 15.23% security_inode_init_security
- 13.05% xfs_initxattrs
- 12.94% xfs_attr_set
- 6.75% xfs_bmap_add_attrfork
- 5.51% xfs_trans_commit
- 5.48% __xfs_trans_commit
- 5.35% xfs_log_commit_cil
- 3.86% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.70% xfs_trans_alloc
0.52% xfs_trans_reserve
- 5.41% xfs_attr_set_args
- 5.39% xfs_attr_set_shortform.constprop.0
- 4.46% xfs_trans_commit
- 4.46% __xfs_trans_commit
- 4.33% xfs_log_commit_cil
- 2.74% _raw_spin_lock
- do_raw_spin_lock
__pv_queued_spin_lock_slowpath
0.60% xfs_inode_item_format
0.90% xfs_attr_try_sf_addname
- 1.99% selinux_inode_init_security
- 1.02% security_sid_to_context_force
- 1.00% security_sid_to_context_core
- 0.92% sidtab_entry_to_string
- 0.90% sidtab_sid2str_get
0.59% sidtab_sid2str_put.part.0
- 0.82% selinux_determine_inode_label
- 0.77% security_transition_sid
0.70% security_compute_sid.part.0
And fsmark creation rate performance drops by ~25%. The key point to
note here is that half the additional overhead comes from adding the
attribute fork to the newly created inode. That's crazy, considering
we can do this same thing at inode create time with a couple of
lines of code and no extra overhead.
So, if we know we are going to add an attribute immediately after
creating the inode, let's just initialise the attribute fork inside
the create transaction and chop that whole chunk of code out of
the create fast path. This completely removes the performance
drop caused by enabling SELinux, and the profile looks like:
- 8.99% xfs_init_security
- 9.00% security_inode_init_security
- 6.43% xfs_initxattrs
- 6.37% xfs_attr_set
- 5.45% xfs_attr_set_args
- 5.42% xfs_attr_set_shortform.constprop.0
- 4.51% xfs_trans_commit
- 4.54% __xfs_trans_commit
- 4.59% xfs_log_commit_cil
- 2.67% _raw_spin_lock
- 3.28% do_raw_spin_lock
3.08% __pv_queued_spin_lock_slowpath
0.66% xfs_inode_item_format
- 0.90% xfs_attr_try_sf_addname
- 0.60% xfs_trans_alloc
- 2.35% selinux_inode_init_security
- 1.25% security_sid_to_context_force
- 1.21% security_sid_to_context_core
- 1.19% sidtab_entry_to_string
- 1.20% sidtab_sid2str_get
- 0.86% sidtab_sid2str_put.part.0
- 0.62% _raw_spin_lock_irqsave
- 0.77% do_raw_spin_lock
__pv_queued_spin_lock_slowpath
- 0.84% selinux_determine_inode_label
- 0.83% security_transition_sid
0.86% security_compute_sid.part.0
Which indicates the XFS overhead of creating the selinux xattr has
been halved. This doesn't fix the CIL lock contention problem, just
means it's not a limiting factor for this workload. Lock contention
in the security subsystems is going to be an issue soon, though...
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[djwong: fix compilation error when CONFIG_SECURITY=n]
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Gao Xiang <hsiangkao@redhat.com>
2021-03-23 00:52:03 +08:00
|
|
|
1, 0, prid, false, &ip);
|
2015-02-23 19:38:08 +08:00
|
|
|
if (error)
|
|
|
|
goto out_trans_cancel;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
/*
|
2015-02-23 19:38:08 +08:00
|
|
|
* Now we join the directory inode to the transaction. We do not do it
|
|
|
|
* earlier because xfs_dir_ialloc might commit the previous transaction
|
|
|
|
* (and release all the locks). An error from here on will result in
|
|
|
|
* the transaction cancel unlocking dp so don't do it explicitly in the
|
2013-04-03 13:11:18 +08:00
|
|
|
* error path.
|
|
|
|
*/
|
2016-11-30 11:33:25 +08:00
|
|
|
xfs_trans_ijoin(tp, dp, XFS_ILOCK_EXCL);
|
2013-04-03 13:11:18 +08:00
|
|
|
unlock_dp_on_error = false;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Also attach the dquot(s) to it, if applicable.
|
|
|
|
*/
|
2013-07-11 13:00:40 +08:00
|
|
|
xfs_qm_vop_create_dqattach(tp, ip, udqp, gdqp, pdqp);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2020-04-23 12:54:31 +08:00
|
|
|
resblks -= XFS_IALLOC_SPACE_RES(mp);
|
2013-04-03 13:11:18 +08:00
|
|
|
/*
|
|
|
|
* If the symlink will fit into the inode, write it inline.
|
|
|
|
*/
|
|
|
|
if (pathlen <= XFS_IFORK_DSIZE(ip)) {
|
2016-04-06 05:41:43 +08:00
|
|
|
xfs_init_local_fork(ip, XFS_DATA_FORK, target_path, pathlen);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2021-03-30 02:11:40 +08:00
|
|
|
ip->i_disk_size = pathlen;
|
2020-05-19 01:28:05 +08:00
|
|
|
ip->i_df.if_format = XFS_DINODE_FMT_LOCAL;
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_trans_log_inode(tp, ip, XFS_ILOG_DDATA | XFS_ILOG_CORE);
|
|
|
|
} else {
|
2013-04-03 13:11:19 +08:00
|
|
|
int offset;
|
|
|
|
|
2013-04-03 13:11:18 +08:00
|
|
|
first_fsb = 0;
|
|
|
|
nmaps = XFS_SYMLINK_MAPS;
|
|
|
|
|
|
|
|
error = xfs_bmapi_write(tp, ip, first_fsb, fs_blocks,
|
2018-07-12 13:26:25 +08:00
|
|
|
XFS_BMAPI_METADATA, resblks, mval, &nmaps);
|
2013-04-03 13:11:18 +08:00
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2020-04-23 12:54:31 +08:00
|
|
|
resblks -= fs_blocks;
|
2021-03-30 02:11:40 +08:00
|
|
|
ip->i_disk_size = pathlen;
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
|
|
|
|
|
|
|
|
cur_chunk = target_path;
|
2013-04-03 13:11:19 +08:00
|
|
|
offset = 0;
|
2013-04-03 13:11:18 +08:00
|
|
|
for (n = 0; n < nmaps; n++) {
|
2013-05-27 14:38:20 +08:00
|
|
|
char *buf;
|
2013-04-03 13:11:19 +08:00
|
|
|
|
2013-04-03 13:11:18 +08:00
|
|
|
d = XFS_FSB_TO_DADDR(mp, mval[n].br_startblock);
|
|
|
|
byte_cnt = XFS_FSB_TO_B(mp, mval[n].br_blockcount);
|
2020-01-24 09:01:18 +08:00
|
|
|
error = xfs_trans_get_buf(tp, mp->m_ddev_targp, d,
|
|
|
|
BTOBB(byte_cnt), 0, &bp);
|
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-04-03 13:11:19 +08:00
|
|
|
bp->b_ops = &xfs_symlink_buf_ops;
|
|
|
|
|
|
|
|
byte_cnt = XFS_SYMLINK_BUF_SPACE(mp, byte_cnt);
|
2013-05-27 14:38:20 +08:00
|
|
|
byte_cnt = min(byte_cnt, pathlen);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2013-04-03 13:11:19 +08:00
|
|
|
buf = bp->b_addr;
|
|
|
|
buf += xfs_symlink_hdr_set(mp, ip->i_ino, offset,
|
|
|
|
byte_cnt, bp);
|
|
|
|
|
|
|
|
memcpy(buf, cur_chunk, byte_cnt);
|
|
|
|
|
2013-04-03 13:11:18 +08:00
|
|
|
cur_chunk += byte_cnt;
|
2013-04-03 13:11:19 +08:00
|
|
|
pathlen -= byte_cnt;
|
|
|
|
offset += byte_cnt;
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2013-09-02 08:32:00 +08:00
|
|
|
xfs_trans_buf_set_type(tp, bp, XFS_BLFT_SYMLINK_BUF);
|
2013-04-03 13:11:19 +08:00
|
|
|
xfs_trans_log_buf(tp, bp, 0, (buf + byte_cnt - 1) -
|
|
|
|
(char *)bp->b_addr);
|
2013-04-03 13:11:18 +08:00
|
|
|
}
|
2013-05-27 14:38:20 +08:00
|
|
|
ASSERT(pathlen == 0);
|
2013-04-03 13:11:18 +08:00
|
|
|
}
|
2021-03-30 02:11:40 +08:00
|
|
|
i_size_write(VFS_I(ip), ip->i_disk_size);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Create the directory entry for the symlink.
|
|
|
|
*/
|
2018-07-12 13:26:21 +08:00
|
|
|
error = xfs_dir_createname(tp, dp, link_name, ip->i_ino, resblks);
|
2013-04-03 13:11:18 +08:00
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto out_trans_cancel;
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_trans_ichgtime(tp, dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
|
|
|
|
xfs_trans_log_inode(tp, dp, XFS_ILOG_CORE);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If this is a synchronous mount, make sure that the
|
|
|
|
* symlink transaction goes to disk before returning to
|
|
|
|
* the user.
|
|
|
|
*/
|
|
|
|
if (mp->m_flags & (XFS_MOUNT_WSYNC|XFS_MOUNT_DIRSYNC)) {
|
|
|
|
xfs_trans_set_sync(tp);
|
|
|
|
}
|
|
|
|
|
2015-06-04 11:48:08 +08:00
|
|
|
error = xfs_trans_commit(tp);
|
2015-02-23 19:38:08 +08:00
|
|
|
if (error)
|
|
|
|
goto out_release_inode;
|
|
|
|
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_qm_dqrele(udqp);
|
|
|
|
xfs_qm_dqrele(gdqp);
|
2013-07-11 13:00:40 +08:00
|
|
|
xfs_qm_dqrele(pdqp);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
*ipp = ip;
|
|
|
|
return 0;
|
|
|
|
|
2015-02-23 19:38:08 +08:00
|
|
|
out_trans_cancel:
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2015-02-23 19:38:08 +08:00
|
|
|
out_release_inode:
|
|
|
|
/*
|
|
|
|
* Wait until after the current transaction is aborted to finish the
|
|
|
|
* setup of the inode and release the inode. This prevents recursive
|
|
|
|
* transactions and deadlocks from xfs_inactive.
|
|
|
|
*/
|
|
|
|
if (ip) {
|
|
|
|
xfs_finish_inode_setup(ip);
|
2018-07-26 03:52:32 +08:00
|
|
|
xfs_irele(ip);
|
2015-02-23 19:38:08 +08:00
|
|
|
}
|
2021-01-28 04:07:57 +08:00
|
|
|
out_release_dquots:
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_qm_dqrele(udqp);
|
|
|
|
xfs_qm_dqrele(gdqp);
|
2013-07-11 13:00:40 +08:00
|
|
|
xfs_qm_dqrele(pdqp);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
|
|
|
if (unlock_dp_on_error)
|
2016-11-30 11:33:25 +08:00
|
|
|
xfs_iunlock(dp, XFS_ILOCK_EXCL);
|
2013-04-03 13:11:18 +08:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Free a symlink that has blocks associated with it.
|
2018-12-13 00:46:21 +08:00
|
|
|
*
|
|
|
|
* Note: zero length symlinks are not allowed to exist. When we set the size to
|
|
|
|
* zero, also change it to a regular file so that it does not get written to
|
|
|
|
* disk as a zero length symlink. The inode is on the unlinked list already, so
|
|
|
|
* userspace cannot find this inode anymore, so this change is not user visible
|
|
|
|
* but allows us to catch corrupt zero-length symlinks in the verifiers.
|
2013-04-03 13:11:18 +08:00
|
|
|
*/
|
2013-06-18 04:35:57 +08:00
|
|
|
STATIC int
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_inactive_symlink_rmt(
|
2013-09-20 23:06:09 +08:00
|
|
|
struct xfs_inode *ip)
|
2013-04-03 13:11:18 +08:00
|
|
|
{
|
2020-12-17 08:07:34 +08:00
|
|
|
struct xfs_buf *bp;
|
2013-04-03 13:11:18 +08:00
|
|
|
int done;
|
|
|
|
int error;
|
|
|
|
int i;
|
|
|
|
xfs_mount_t *mp;
|
|
|
|
xfs_bmbt_irec_t mval[XFS_SYMLINK_MAPS];
|
|
|
|
int nmaps;
|
|
|
|
int size;
|
|
|
|
xfs_trans_t *tp;
|
|
|
|
|
|
|
|
mp = ip->i_mount;
|
2013-06-18 04:35:57 +08:00
|
|
|
ASSERT(ip->i_df.if_flags & XFS_IFEXTENTS);
|
2013-04-03 13:11:18 +08:00
|
|
|
/*
|
|
|
|
* We're freeing a symlink that has some
|
|
|
|
* blocks allocated to it. Free the
|
|
|
|
* blocks here. We know that we've got
|
|
|
|
* either 1 or 2 extents and that we can
|
|
|
|
* free them all in one bunmapi call.
|
|
|
|
*/
|
2020-05-19 01:27:22 +08:00
|
|
|
ASSERT(ip->i_df.if_nextents > 0 && ip->i_df.if_nextents <= 2);
|
2013-04-03 13:11:18 +08:00
|
|
|
|
2016-04-06 07:19:55 +08:00
|
|
|
error = xfs_trans_alloc(mp, &M_RES(mp)->tr_itruncate, 0, 0, 0, &tp);
|
|
|
|
if (error)
|
2013-09-20 23:06:09 +08:00
|
|
|
return error;
|
|
|
|
|
|
|
|
xfs_ilock(ip, XFS_ILOCK_EXCL);
|
|
|
|
xfs_trans_ijoin(tp, ip, 0);
|
|
|
|
|
2013-04-03 13:11:18 +08:00
|
|
|
/*
|
2018-12-13 00:46:21 +08:00
|
|
|
* Lock the inode, fix the size, turn it into a regular file and join it
|
|
|
|
* to the transaction. Hold it so in the normal path, we still have it
|
|
|
|
* locked for the second transaction. In the error paths we need it
|
2013-04-03 13:11:18 +08:00
|
|
|
* held so the cancel won't rele it, see below.
|
|
|
|
*/
|
2021-03-30 02:11:40 +08:00
|
|
|
size = (int)ip->i_disk_size;
|
|
|
|
ip->i_disk_size = 0;
|
2018-12-13 00:46:21 +08:00
|
|
|
VFS_I(ip)->i_mode = (VFS_I(ip)->i_mode & ~S_IFMT) | S_IFREG;
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
|
|
|
|
/*
|
|
|
|
* Find the block(s) so we can inval and unmap them.
|
|
|
|
*/
|
|
|
|
done = 0;
|
|
|
|
nmaps = ARRAY_SIZE(mval);
|
2013-04-03 13:11:19 +08:00
|
|
|
error = xfs_bmapi_read(ip, 0, xfs_symlink_blocks(mp, size),
|
2013-04-03 13:11:18 +08:00
|
|
|
mval, &nmaps, 0);
|
|
|
|
if (error)
|
2013-09-20 23:06:09 +08:00
|
|
|
goto error_trans_cancel;
|
2013-04-03 13:11:18 +08:00
|
|
|
/*
|
2013-04-03 13:11:19 +08:00
|
|
|
* Invalidate the block(s). No validation is done.
|
2013-04-03 13:11:18 +08:00
|
|
|
*/
|
|
|
|
for (i = 0; i < nmaps; i++) {
|
2020-01-24 09:01:18 +08:00
|
|
|
error = xfs_trans_get_buf(tp, mp->m_ddev_targp,
|
|
|
|
XFS_FSB_TO_DADDR(mp, mval[i].br_startblock),
|
|
|
|
XFS_FSB_TO_BB(mp, mval[i].br_blockcount), 0,
|
|
|
|
&bp);
|
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto error_trans_cancel;
|
2013-04-03 13:11:18 +08:00
|
|
|
xfs_trans_binval(tp, bp);
|
|
|
|
}
|
|
|
|
/*
|
2016-08-03 09:19:29 +08:00
|
|
|
* Unmap the dead block(s) to the dfops.
|
2013-04-03 13:11:18 +08:00
|
|
|
*/
|
2018-07-12 13:26:25 +08:00
|
|
|
error = xfs_bunmapi(tp, ip, 0, size, 0, nmaps, &done);
|
2013-09-20 23:06:09 +08:00
|
|
|
if (error)
|
2018-07-25 04:43:13 +08:00
|
|
|
goto error_trans_cancel;
|
2013-04-03 13:11:18 +08:00
|
|
|
ASSERT(done);
|
2018-05-09 22:49:09 +08:00
|
|
|
|
2013-04-03 13:11:18 +08:00
|
|
|
/*
|
2018-07-25 04:43:13 +08:00
|
|
|
* Commit the transaction. This first logs the EFI and the inode, then
|
|
|
|
* rolls and commits the transaction that frees the extents.
|
2013-04-03 13:11:18 +08:00
|
|
|
*/
|
2018-05-09 22:49:09 +08:00
|
|
|
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
|
2015-06-04 11:48:08 +08:00
|
|
|
error = xfs_trans_commit(tp);
|
2013-04-03 13:11:18 +08:00
|
|
|
if (error) {
|
|
|
|
ASSERT(XFS_FORCED_SHUTDOWN(mp));
|
2013-09-20 23:06:09 +08:00
|
|
|
goto error_unlock;
|
2013-04-03 13:11:18 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Remove the memory for extent descriptions (just bookkeeping).
|
|
|
|
*/
|
|
|
|
if (ip->i_df.if_bytes)
|
|
|
|
xfs_idata_realloc(ip, -ip->i_df.if_bytes, XFS_DATA_FORK);
|
|
|
|
ASSERT(ip->i_df.if_bytes == 0);
|
|
|
|
|
2013-09-20 23:06:09 +08:00
|
|
|
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
2013-04-03 13:11:18 +08:00
|
|
|
return 0;
|
|
|
|
|
2013-09-20 23:06:09 +08:00
|
|
|
error_trans_cancel:
|
2015-06-04 11:47:56 +08:00
|
|
|
xfs_trans_cancel(tp);
|
2013-09-20 23:06:09 +08:00
|
|
|
error_unlock:
|
|
|
|
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
2013-04-03 13:11:18 +08:00
|
|
|
return error;
|
|
|
|
}
|
2013-06-18 04:35:57 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* xfs_inactive_symlink - free a symlink
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_inactive_symlink(
|
2013-09-20 23:06:09 +08:00
|
|
|
struct xfs_inode *ip)
|
2013-06-18 04:35:57 +08:00
|
|
|
{
|
|
|
|
struct xfs_mount *mp = ip->i_mount;
|
|
|
|
int pathlen;
|
|
|
|
|
|
|
|
trace_xfs_inactive_symlink(ip);
|
|
|
|
|
|
|
|
if (XFS_FORCED_SHUTDOWN(mp))
|
2014-06-25 12:58:08 +08:00
|
|
|
return -EIO;
|
2013-06-18 04:35:57 +08:00
|
|
|
|
2013-09-20 23:06:09 +08:00
|
|
|
xfs_ilock(ip, XFS_ILOCK_EXCL);
|
2021-03-30 02:11:40 +08:00
|
|
|
pathlen = (int)ip->i_disk_size;
|
2018-12-13 00:46:21 +08:00
|
|
|
ASSERT(pathlen);
|
2013-06-18 04:35:57 +08:00
|
|
|
|
2018-12-13 00:46:21 +08:00
|
|
|
if (pathlen <= 0 || pathlen > XFS_SYMLINK_MAXLEN) {
|
2013-06-18 04:35:57 +08:00
|
|
|
xfs_alert(mp, "%s: inode (0x%llx) bad symlink length (%d)",
|
|
|
|
__func__, (unsigned long long)ip->i_ino, pathlen);
|
2013-09-20 23:06:09 +08:00
|
|
|
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
2013-06-18 04:35:57 +08:00
|
|
|
ASSERT(0);
|
2014-06-25 12:58:08 +08:00
|
|
|
return -EFSCORRUPTED;
|
2013-06-18 04:35:57 +08:00
|
|
|
}
|
|
|
|
|
2018-12-13 00:46:21 +08:00
|
|
|
/*
|
|
|
|
* Inline fork state gets removed by xfs_difree() so we have nothing to
|
|
|
|
* do here in that case.
|
|
|
|
*/
|
2021-04-14 02:15:11 +08:00
|
|
|
if (ip->i_df.if_format == XFS_DINODE_FMT_LOCAL) {
|
2013-09-20 23:06:09 +08:00
|
|
|
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
2013-06-18 04:35:57 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-09-20 23:06:09 +08:00
|
|
|
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
|
|
|
|
2013-06-18 04:35:57 +08:00
|
|
|
/* remove the remote symlink */
|
2013-09-20 23:06:09 +08:00
|
|
|
return xfs_inactive_symlink_rmt(ip);
|
2013-06-18 04:35:57 +08:00
|
|
|
}
|