2019-05-27 14:55:15 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2009-09-25 15:39:26 +08:00
|
|
|
/*
|
|
|
|
* max8660.c -- Voltage regulation for the Maxim 8660/8661
|
|
|
|
*
|
|
|
|
* based on max1586.c and wm8400-regulator.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 2009 Wolfram Sang, Pengutronix e.K.
|
|
|
|
*
|
|
|
|
* Some info:
|
|
|
|
*
|
|
|
|
* Datasheet: http://datasheets.maxim-ic.com/en/ds/MAX8660-MAX8661.pdf
|
|
|
|
*
|
|
|
|
* This chip is a bit nasty because it is a write-only device. Thus, the driver
|
|
|
|
* uses shadow registers to keep track of its values. The main problem appears
|
|
|
|
* to be the initialization: When Linux boots up, we cannot know if the chip is
|
|
|
|
* in the default state or not, so we would have to pass such information in
|
|
|
|
* platform_data. As this adds a bit of complexity to the driver, this is left
|
|
|
|
* out for now until it is really needed.
|
|
|
|
*
|
|
|
|
* [A|S|M]DTV1 registers are currently not used, but [A|S|M]DTV2.
|
|
|
|
*
|
|
|
|
* If the driver is feature complete, it might be worth to check if one set of
|
|
|
|
* functions for V3-V7 is sufficient. For maximum flexibility during
|
|
|
|
* development, they are separated for now.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/err.h>
|
|
|
|
#include <linux/i2c.h>
|
|
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <linux/regulator/driver.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 16:04:11 +08:00
|
|
|
#include <linux/slab.h>
|
2009-09-25 15:39:26 +08:00
|
|
|
#include <linux/regulator/max8660.h>
|
2013-08-02 18:59:44 +08:00
|
|
|
#include <linux/of.h>
|
|
|
|
#include <linux/of_device.h>
|
|
|
|
#include <linux/regulator/of_regulator.h>
|
2009-09-25 15:39:26 +08:00
|
|
|
|
|
|
|
#define MAX8660_DCDC_MIN_UV 725000
|
|
|
|
#define MAX8660_DCDC_MAX_UV 1800000
|
|
|
|
#define MAX8660_DCDC_STEP 25000
|
|
|
|
#define MAX8660_DCDC_MAX_SEL 0x2b
|
|
|
|
|
|
|
|
#define MAX8660_LDO5_MIN_UV 1700000
|
|
|
|
#define MAX8660_LDO5_MAX_UV 2000000
|
|
|
|
#define MAX8660_LDO5_STEP 25000
|
|
|
|
#define MAX8660_LDO5_MAX_SEL 0x0c
|
|
|
|
|
|
|
|
#define MAX8660_LDO67_MIN_UV 1800000
|
|
|
|
#define MAX8660_LDO67_MAX_UV 3300000
|
|
|
|
#define MAX8660_LDO67_STEP 100000
|
|
|
|
#define MAX8660_LDO67_MAX_SEL 0x0f
|
|
|
|
|
|
|
|
enum {
|
|
|
|
MAX8660_OVER1,
|
|
|
|
MAX8660_OVER2,
|
|
|
|
MAX8660_VCC1,
|
|
|
|
MAX8660_ADTV1,
|
|
|
|
MAX8660_ADTV2,
|
|
|
|
MAX8660_SDTV1,
|
|
|
|
MAX8660_SDTV2,
|
|
|
|
MAX8660_MDTV1,
|
|
|
|
MAX8660_MDTV2,
|
|
|
|
MAX8660_L12VCR,
|
|
|
|
MAX8660_FPWM,
|
|
|
|
MAX8660_N_REGS, /* not a real register */
|
|
|
|
};
|
|
|
|
|
|
|
|
struct max8660 {
|
|
|
|
struct i2c_client *client;
|
|
|
|
u8 shadow_regs[MAX8660_N_REGS]; /* as chip is write only */
|
|
|
|
};
|
|
|
|
|
|
|
|
static int max8660_write(struct max8660 *max8660, u8 reg, u8 mask, u8 val)
|
|
|
|
{
|
2014-03-18 18:23:02 +08:00
|
|
|
static const u8 max8660_addresses[MAX8660_N_REGS] = {
|
2014-03-19 20:32:58 +08:00
|
|
|
0x10, 0x12, 0x20, 0x23, 0x24, 0x29, 0x2a, 0x32, 0x33, 0x39, 0x80
|
|
|
|
};
|
2009-09-25 15:39:26 +08:00
|
|
|
|
|
|
|
int ret;
|
|
|
|
u8 reg_val = (max8660->shadow_regs[reg] & mask) | val;
|
2014-03-18 18:23:02 +08:00
|
|
|
|
2009-09-25 15:39:26 +08:00
|
|
|
dev_vdbg(&max8660->client->dev, "Writing reg %02x with %02x\n",
|
|
|
|
max8660_addresses[reg], reg_val);
|
|
|
|
|
|
|
|
ret = i2c_smbus_write_byte_data(max8660->client,
|
|
|
|
max8660_addresses[reg], reg_val);
|
|
|
|
if (ret == 0)
|
|
|
|
max8660->shadow_regs[reg] = reg_val;
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* DCDC functions
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int max8660_dcdc_is_enabled(struct regulator_dev *rdev)
|
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
u8 val = max8660->shadow_regs[MAX8660_OVER1];
|
|
|
|
u8 mask = (rdev_get_id(rdev) == MAX8660_V3) ? 1 : 4;
|
2014-03-18 18:23:02 +08:00
|
|
|
|
2009-09-25 15:39:26 +08:00
|
|
|
return !!(val & mask);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int max8660_dcdc_enable(struct regulator_dev *rdev)
|
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
u8 bit = (rdev_get_id(rdev) == MAX8660_V3) ? 1 : 4;
|
2014-03-18 18:23:02 +08:00
|
|
|
|
2009-09-25 15:39:26 +08:00
|
|
|
return max8660_write(max8660, MAX8660_OVER1, 0xff, bit);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int max8660_dcdc_disable(struct regulator_dev *rdev)
|
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
u8 mask = (rdev_get_id(rdev) == MAX8660_V3) ? ~1 : ~4;
|
2014-03-18 18:23:02 +08:00
|
|
|
|
2009-09-25 15:39:26 +08:00
|
|
|
return max8660_write(max8660, MAX8660_OVER1, mask, 0);
|
|
|
|
}
|
|
|
|
|
2012-05-15 21:42:12 +08:00
|
|
|
static int max8660_dcdc_get_voltage_sel(struct regulator_dev *rdev)
|
2009-09-25 15:39:26 +08:00
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
u8 reg = (rdev_get_id(rdev) == MAX8660_V3) ? MAX8660_ADTV2 : MAX8660_SDTV2;
|
|
|
|
u8 selector = max8660->shadow_regs[reg];
|
2014-03-18 18:23:02 +08:00
|
|
|
|
2012-05-15 21:42:12 +08:00
|
|
|
return selector;
|
2009-09-25 15:39:26 +08:00
|
|
|
}
|
|
|
|
|
2012-05-15 21:43:29 +08:00
|
|
|
static int max8660_dcdc_set_voltage_sel(struct regulator_dev *rdev,
|
|
|
|
unsigned int selector)
|
2009-09-25 15:39:26 +08:00
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
2012-05-15 21:43:29 +08:00
|
|
|
u8 reg, bits;
|
2009-09-25 15:39:26 +08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
reg = (rdev_get_id(rdev) == MAX8660_V3) ? MAX8660_ADTV2 : MAX8660_SDTV2;
|
|
|
|
ret = max8660_write(max8660, reg, 0, selector);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/* Select target voltage register and activate regulation */
|
|
|
|
bits = (rdev_get_id(rdev) == MAX8660_V3) ? 0x03 : 0x30;
|
|
|
|
return max8660_write(max8660, MAX8660_VCC1, 0xff, bits);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct regulator_ops max8660_dcdc_ops = {
|
|
|
|
.is_enabled = max8660_dcdc_is_enabled,
|
2012-05-15 21:41:18 +08:00
|
|
|
.list_voltage = regulator_list_voltage_linear,
|
2012-05-15 21:43:29 +08:00
|
|
|
.map_voltage = regulator_map_voltage_linear,
|
|
|
|
.set_voltage_sel = max8660_dcdc_set_voltage_sel,
|
2012-05-15 21:42:12 +08:00
|
|
|
.get_voltage_sel = max8660_dcdc_get_voltage_sel,
|
2009-09-25 15:39:26 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* LDO5 functions
|
|
|
|
*/
|
|
|
|
|
2012-05-15 21:42:12 +08:00
|
|
|
static int max8660_ldo5_get_voltage_sel(struct regulator_dev *rdev)
|
2009-09-25 15:39:26 +08:00
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
|
2012-05-15 21:42:12 +08:00
|
|
|
u8 selector = max8660->shadow_regs[MAX8660_MDTV2];
|
|
|
|
return selector;
|
2009-09-25 15:39:26 +08:00
|
|
|
}
|
|
|
|
|
2012-05-15 21:43:29 +08:00
|
|
|
static int max8660_ldo5_set_voltage_sel(struct regulator_dev *rdev,
|
|
|
|
unsigned int selector)
|
2009-09-25 15:39:26 +08:00
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = max8660_write(max8660, MAX8660_MDTV2, 0, selector);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/* Select target voltage register and activate regulation */
|
|
|
|
return max8660_write(max8660, MAX8660_VCC1, 0xff, 0xc0);
|
|
|
|
}
|
|
|
|
|
2017-03-12 03:01:20 +08:00
|
|
|
static const struct regulator_ops max8660_ldo5_ops = {
|
2012-05-15 21:41:18 +08:00
|
|
|
.list_voltage = regulator_list_voltage_linear,
|
2012-05-15 21:43:29 +08:00
|
|
|
.map_voltage = regulator_map_voltage_linear,
|
|
|
|
.set_voltage_sel = max8660_ldo5_set_voltage_sel,
|
2012-05-15 21:42:12 +08:00
|
|
|
.get_voltage_sel = max8660_ldo5_get_voltage_sel,
|
2009-09-25 15:39:26 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* LDO67 functions
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int max8660_ldo67_is_enabled(struct regulator_dev *rdev)
|
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
u8 val = max8660->shadow_regs[MAX8660_OVER2];
|
|
|
|
u8 mask = (rdev_get_id(rdev) == MAX8660_V6) ? 2 : 4;
|
2014-03-18 18:23:02 +08:00
|
|
|
|
2009-09-25 15:39:26 +08:00
|
|
|
return !!(val & mask);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int max8660_ldo67_enable(struct regulator_dev *rdev)
|
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
u8 bit = (rdev_get_id(rdev) == MAX8660_V6) ? 2 : 4;
|
2014-03-18 18:23:02 +08:00
|
|
|
|
2009-09-25 15:39:26 +08:00
|
|
|
return max8660_write(max8660, MAX8660_OVER2, 0xff, bit);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int max8660_ldo67_disable(struct regulator_dev *rdev)
|
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
u8 mask = (rdev_get_id(rdev) == MAX8660_V6) ? ~2 : ~4;
|
2014-03-18 18:23:02 +08:00
|
|
|
|
2009-09-25 15:39:26 +08:00
|
|
|
return max8660_write(max8660, MAX8660_OVER2, mask, 0);
|
|
|
|
}
|
|
|
|
|
2012-05-15 21:42:12 +08:00
|
|
|
static int max8660_ldo67_get_voltage_sel(struct regulator_dev *rdev)
|
2009-09-25 15:39:26 +08:00
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
|
|
|
u8 shift = (rdev_get_id(rdev) == MAX8660_V6) ? 0 : 4;
|
|
|
|
u8 selector = (max8660->shadow_regs[MAX8660_L12VCR] >> shift) & 0xf;
|
2014-03-18 18:23:02 +08:00
|
|
|
|
2012-05-15 21:42:12 +08:00
|
|
|
return selector;
|
2009-09-25 15:39:26 +08:00
|
|
|
}
|
|
|
|
|
2012-05-15 21:43:29 +08:00
|
|
|
static int max8660_ldo67_set_voltage_sel(struct regulator_dev *rdev,
|
|
|
|
unsigned int selector)
|
2009-09-25 15:39:26 +08:00
|
|
|
{
|
|
|
|
struct max8660 *max8660 = rdev_get_drvdata(rdev);
|
2010-11-10 22:38:29 +08:00
|
|
|
|
2009-09-25 15:39:26 +08:00
|
|
|
if (rdev_get_id(rdev) == MAX8660_V6)
|
|
|
|
return max8660_write(max8660, MAX8660_L12VCR, 0xf0, selector);
|
|
|
|
else
|
2012-05-15 21:43:29 +08:00
|
|
|
return max8660_write(max8660, MAX8660_L12VCR, 0x0f,
|
|
|
|
selector << 4);
|
2009-09-25 15:39:26 +08:00
|
|
|
}
|
|
|
|
|
2017-03-12 03:01:20 +08:00
|
|
|
static const struct regulator_ops max8660_ldo67_ops = {
|
2009-09-25 15:39:26 +08:00
|
|
|
.is_enabled = max8660_ldo67_is_enabled,
|
|
|
|
.enable = max8660_ldo67_enable,
|
|
|
|
.disable = max8660_ldo67_disable,
|
2012-05-15 21:41:18 +08:00
|
|
|
.list_voltage = regulator_list_voltage_linear,
|
2012-05-15 21:43:29 +08:00
|
|
|
.map_voltage = regulator_map_voltage_linear,
|
2012-05-15 21:42:12 +08:00
|
|
|
.get_voltage_sel = max8660_ldo67_get_voltage_sel,
|
2012-05-15 21:43:29 +08:00
|
|
|
.set_voltage_sel = max8660_ldo67_set_voltage_sel,
|
2009-09-25 15:39:26 +08:00
|
|
|
};
|
|
|
|
|
2012-04-06 08:26:59 +08:00
|
|
|
static const struct regulator_desc max8660_reg[] = {
|
2009-09-25 15:39:26 +08:00
|
|
|
{
|
|
|
|
.name = "V3(DCDC)",
|
|
|
|
.id = MAX8660_V3,
|
|
|
|
.ops = &max8660_dcdc_ops,
|
|
|
|
.type = REGULATOR_VOLTAGE,
|
|
|
|
.n_voltages = MAX8660_DCDC_MAX_SEL + 1,
|
|
|
|
.owner = THIS_MODULE,
|
2012-05-15 21:41:18 +08:00
|
|
|
.min_uV = MAX8660_DCDC_MIN_UV,
|
|
|
|
.uV_step = MAX8660_DCDC_STEP,
|
2009-09-25 15:39:26 +08:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = "V4(DCDC)",
|
|
|
|
.id = MAX8660_V4,
|
|
|
|
.ops = &max8660_dcdc_ops,
|
|
|
|
.type = REGULATOR_VOLTAGE,
|
|
|
|
.n_voltages = MAX8660_DCDC_MAX_SEL + 1,
|
|
|
|
.owner = THIS_MODULE,
|
2012-05-15 21:41:18 +08:00
|
|
|
.min_uV = MAX8660_DCDC_MIN_UV,
|
|
|
|
.uV_step = MAX8660_DCDC_STEP,
|
2009-09-25 15:39:26 +08:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = "V5(LDO)",
|
|
|
|
.id = MAX8660_V5,
|
|
|
|
.ops = &max8660_ldo5_ops,
|
|
|
|
.type = REGULATOR_VOLTAGE,
|
|
|
|
.n_voltages = MAX8660_LDO5_MAX_SEL + 1,
|
|
|
|
.owner = THIS_MODULE,
|
2012-05-15 21:41:18 +08:00
|
|
|
.min_uV = MAX8660_LDO5_MIN_UV,
|
|
|
|
.uV_step = MAX8660_LDO5_STEP,
|
2009-09-25 15:39:26 +08:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = "V6(LDO)",
|
|
|
|
.id = MAX8660_V6,
|
|
|
|
.ops = &max8660_ldo67_ops,
|
|
|
|
.type = REGULATOR_VOLTAGE,
|
|
|
|
.n_voltages = MAX8660_LDO67_MAX_SEL + 1,
|
|
|
|
.owner = THIS_MODULE,
|
2012-05-15 21:41:18 +08:00
|
|
|
.min_uV = MAX8660_LDO67_MIN_UV,
|
|
|
|
.uV_step = MAX8660_LDO67_STEP,
|
2009-09-25 15:39:26 +08:00
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = "V7(LDO)",
|
|
|
|
.id = MAX8660_V7,
|
|
|
|
.ops = &max8660_ldo67_ops,
|
|
|
|
.type = REGULATOR_VOLTAGE,
|
|
|
|
.n_voltages = MAX8660_LDO67_MAX_SEL + 1,
|
|
|
|
.owner = THIS_MODULE,
|
2012-05-15 21:41:18 +08:00
|
|
|
.min_uV = MAX8660_LDO67_MIN_UV,
|
|
|
|
.uV_step = MAX8660_LDO67_STEP,
|
2009-09-25 15:39:26 +08:00
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2013-08-02 16:19:15 +08:00
|
|
|
enum {
|
|
|
|
MAX8660 = 0,
|
|
|
|
MAX8661 = 1,
|
|
|
|
};
|
|
|
|
|
2013-08-02 18:59:44 +08:00
|
|
|
#ifdef CONFIG_OF
|
|
|
|
static const struct of_device_id max8660_dt_ids[] = {
|
|
|
|
{ .compatible = "maxim,max8660", .data = (void *) MAX8660 },
|
|
|
|
{ .compatible = "maxim,max8661", .data = (void *) MAX8661 },
|
|
|
|
{ }
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, max8660_dt_ids);
|
|
|
|
|
|
|
|
static int max8660_pdata_from_dt(struct device *dev,
|
|
|
|
struct device_node **of_node,
|
|
|
|
struct max8660_platform_data *pdata)
|
|
|
|
{
|
|
|
|
int matched, i;
|
|
|
|
struct device_node *np;
|
|
|
|
struct max8660_subdev_data *sub;
|
2014-11-03 22:40:43 +08:00
|
|
|
struct of_regulator_match rmatch[ARRAY_SIZE(max8660_reg)] = { };
|
2013-08-02 18:59:44 +08:00
|
|
|
|
2014-02-14 19:49:49 +08:00
|
|
|
np = of_get_child_by_name(dev->of_node, "regulators");
|
2013-08-02 18:59:44 +08:00
|
|
|
if (!np) {
|
|
|
|
dev_err(dev, "missing 'regulators' subnode in DT\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(rmatch); i++)
|
|
|
|
rmatch[i].name = max8660_reg[i].name;
|
|
|
|
|
|
|
|
matched = of_regulator_match(dev, np, rmatch, ARRAY_SIZE(rmatch));
|
2014-02-17 17:03:34 +08:00
|
|
|
of_node_put(np);
|
2013-08-02 18:59:44 +08:00
|
|
|
if (matched <= 0)
|
|
|
|
return matched;
|
|
|
|
|
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 05:07:58 +08:00
|
|
|
pdata->subdevs = devm_kcalloc(dev,
|
|
|
|
matched,
|
|
|
|
sizeof(struct max8660_subdev_data),
|
|
|
|
GFP_KERNEL);
|
2013-08-02 18:59:44 +08:00
|
|
|
if (!pdata->subdevs)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
pdata->num_subdevs = matched;
|
|
|
|
sub = pdata->subdevs;
|
|
|
|
|
|
|
|
for (i = 0; i < matched; i++) {
|
|
|
|
sub->id = i;
|
|
|
|
sub->name = rmatch[i].name;
|
|
|
|
sub->platform_data = rmatch[i].init_data;
|
|
|
|
of_node[i] = rmatch[i].of_node;
|
|
|
|
sub++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static inline int max8660_pdata_from_dt(struct device *dev,
|
|
|
|
struct device_node **of_node,
|
2013-08-08 18:02:18 +08:00
|
|
|
struct max8660_platform_data *pdata)
|
2013-08-02 18:59:44 +08:00
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2012-11-20 02:22:22 +08:00
|
|
|
static int max8660_probe(struct i2c_client *client,
|
2010-02-24 15:38:28 +08:00
|
|
|
const struct i2c_device_id *i2c_id)
|
2009-09-25 15:39:26 +08:00
|
|
|
{
|
2013-08-02 16:19:16 +08:00
|
|
|
struct device *dev = &client->dev;
|
2015-04-08 06:06:46 +08:00
|
|
|
struct max8660_platform_data pdata_of, *pdata = dev_get_platdata(dev);
|
2012-04-04 07:50:22 +08:00
|
|
|
struct regulator_config config = { };
|
2009-09-25 15:39:26 +08:00
|
|
|
struct max8660 *max8660;
|
|
|
|
int boot_on, i, id, ret = -EINVAL;
|
2013-08-02 18:59:44 +08:00
|
|
|
struct device_node *of_node[MAX8660_V_END];
|
2013-08-08 18:02:18 +08:00
|
|
|
unsigned long type;
|
2009-09-25 15:39:26 +08:00
|
|
|
|
2013-08-02 18:59:44 +08:00
|
|
|
if (dev->of_node && !pdata) {
|
|
|
|
const struct of_device_id *id;
|
|
|
|
|
|
|
|
id = of_match_device(of_match_ptr(max8660_dt_ids), dev);
|
|
|
|
if (!id)
|
|
|
|
return -ENODEV;
|
|
|
|
|
|
|
|
ret = max8660_pdata_from_dt(dev, of_node, &pdata_of);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
pdata = &pdata_of;
|
2013-08-08 18:02:18 +08:00
|
|
|
type = (unsigned long) id->data;
|
2013-08-02 18:59:44 +08:00
|
|
|
} else {
|
|
|
|
type = i2c_id->driver_data;
|
|
|
|
memset(of_node, 0, sizeof(of_node));
|
|
|
|
}
|
|
|
|
|
2009-09-25 15:39:26 +08:00
|
|
|
if (pdata->num_subdevs > MAX8660_V_END) {
|
2013-08-02 16:19:16 +08:00
|
|
|
dev_err(dev, "Too many regulators found!\n");
|
2012-04-11 23:08:27 +08:00
|
|
|
return -EINVAL;
|
2009-09-25 15:39:26 +08:00
|
|
|
}
|
|
|
|
|
2014-03-10 17:37:19 +08:00
|
|
|
max8660 = devm_kzalloc(dev, sizeof(struct max8660), GFP_KERNEL);
|
2012-04-11 23:08:27 +08:00
|
|
|
if (!max8660)
|
|
|
|
return -ENOMEM;
|
2009-09-25 15:39:26 +08:00
|
|
|
|
|
|
|
max8660->client = client;
|
|
|
|
|
|
|
|
if (pdata->en34_is_high) {
|
|
|
|
/* Simulate always on */
|
|
|
|
max8660->shadow_regs[MAX8660_OVER1] = 5;
|
|
|
|
} else {
|
|
|
|
/* Otherwise devices can be toggled via software */
|
|
|
|
max8660_dcdc_ops.enable = max8660_dcdc_enable;
|
|
|
|
max8660_dcdc_ops.disable = max8660_dcdc_disable;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* First, set up shadow registers to prevent glitches. As some
|
|
|
|
* registers are shared between regulators, everything must be properly
|
|
|
|
* set up for all regulators in advance.
|
|
|
|
*/
|
|
|
|
max8660->shadow_regs[MAX8660_ADTV1] =
|
|
|
|
max8660->shadow_regs[MAX8660_ADTV2] =
|
|
|
|
max8660->shadow_regs[MAX8660_SDTV1] =
|
|
|
|
max8660->shadow_regs[MAX8660_SDTV2] = 0x1b;
|
|
|
|
max8660->shadow_regs[MAX8660_MDTV1] =
|
|
|
|
max8660->shadow_regs[MAX8660_MDTV2] = 0x04;
|
|
|
|
|
|
|
|
for (i = 0; i < pdata->num_subdevs; i++) {
|
|
|
|
|
|
|
|
if (!pdata->subdevs[i].platform_data)
|
2015-04-10 21:23:42 +08:00
|
|
|
boot_on = false;
|
|
|
|
else
|
|
|
|
boot_on = pdata->subdevs[i].platform_data->constraints.boot_on;
|
2009-09-25 15:39:26 +08:00
|
|
|
|
|
|
|
switch (pdata->subdevs[i].id) {
|
|
|
|
case MAX8660_V3:
|
|
|
|
if (boot_on)
|
|
|
|
max8660->shadow_regs[MAX8660_OVER1] |= 1;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case MAX8660_V4:
|
|
|
|
if (boot_on)
|
|
|
|
max8660->shadow_regs[MAX8660_OVER1] |= 4;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case MAX8660_V5:
|
|
|
|
break;
|
|
|
|
|
|
|
|
case MAX8660_V6:
|
|
|
|
if (boot_on)
|
|
|
|
max8660->shadow_regs[MAX8660_OVER2] |= 2;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case MAX8660_V7:
|
2013-08-02 16:19:15 +08:00
|
|
|
if (type == MAX8661) {
|
2013-08-02 16:19:16 +08:00
|
|
|
dev_err(dev, "Regulator not on this chip!\n");
|
2013-09-04 13:37:58 +08:00
|
|
|
return -EINVAL;
|
2009-09-25 15:39:26 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (boot_on)
|
|
|
|
max8660->shadow_regs[MAX8660_OVER2] |= 4;
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
2013-08-02 16:19:16 +08:00
|
|
|
dev_err(dev, "invalid regulator %s\n",
|
2009-09-25 15:39:26 +08:00
|
|
|
pdata->subdevs[i].name);
|
2013-09-04 13:37:58 +08:00
|
|
|
return ret;
|
2009-09-25 15:39:26 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Finally register devices */
|
|
|
|
for (i = 0; i < pdata->num_subdevs; i++) {
|
2014-03-10 17:37:19 +08:00
|
|
|
struct regulator_dev *rdev;
|
2009-09-25 15:39:26 +08:00
|
|
|
|
|
|
|
id = pdata->subdevs[i].id;
|
|
|
|
|
2013-08-02 16:19:16 +08:00
|
|
|
config.dev = dev;
|
2012-04-04 07:50:22 +08:00
|
|
|
config.init_data = pdata->subdevs[i].platform_data;
|
2013-08-02 18:59:44 +08:00
|
|
|
config.of_node = of_node[i];
|
2012-04-04 07:50:22 +08:00
|
|
|
config.driver_data = max8660;
|
|
|
|
|
2014-03-10 17:37:19 +08:00
|
|
|
rdev = devm_regulator_register(&client->dev,
|
2013-09-04 13:37:58 +08:00
|
|
|
&max8660_reg[id], &config);
|
2014-03-10 17:37:19 +08:00
|
|
|
if (IS_ERR(rdev)) {
|
|
|
|
ret = PTR_ERR(rdev);
|
2013-09-04 13:37:58 +08:00
|
|
|
dev_err(&client->dev, "failed to register %s\n",
|
2009-09-25 15:39:26 +08:00
|
|
|
max8660_reg[id].name);
|
2014-03-10 17:37:19 +08:00
|
|
|
return PTR_ERR(rdev);
|
2009-09-25 15:39:26 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-08-06 13:35:27 +08:00
|
|
|
i2c_set_clientdata(client, max8660);
|
2009-09-25 15:39:26 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct i2c_device_id max8660_id[] = {
|
2013-08-02 16:19:15 +08:00
|
|
|
{ .name = "max8660", .driver_data = MAX8660 },
|
|
|
|
{ .name = "max8661", .driver_data = MAX8661 },
|
2009-09-25 15:39:26 +08:00
|
|
|
{ }
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(i2c, max8660_id);
|
|
|
|
|
|
|
|
static struct i2c_driver max8660_driver = {
|
|
|
|
.probe = max8660_probe,
|
|
|
|
.driver = {
|
|
|
|
.name = "max8660",
|
|
|
|
},
|
|
|
|
.id_table = max8660_id,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int __init max8660_init(void)
|
|
|
|
{
|
|
|
|
return i2c_add_driver(&max8660_driver);
|
|
|
|
}
|
|
|
|
subsys_initcall(max8660_init);
|
|
|
|
|
|
|
|
static void __exit max8660_exit(void)
|
|
|
|
{
|
|
|
|
i2c_del_driver(&max8660_driver);
|
|
|
|
}
|
|
|
|
module_exit(max8660_exit);
|
|
|
|
|
|
|
|
/* Module information */
|
|
|
|
MODULE_DESCRIPTION("MAXIM 8660/8661 voltage regulator driver");
|
|
|
|
MODULE_AUTHOR("Wolfram Sang");
|
|
|
|
MODULE_LICENSE("GPL v2");
|