2019-06-04 16:11:33 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2006-03-31 18:31:05 +08:00
|
|
|
/*
|
|
|
|
* LED Triggers Core
|
|
|
|
*
|
2007-07-09 06:19:31 +08:00
|
|
|
* Copyright 2005-2007 Openedhand Ltd.
|
2006-03-31 18:31:05 +08:00
|
|
|
*
|
|
|
|
* Author: Richard Purdie <rpurdie@openedhand.com>
|
|
|
|
*/
|
|
|
|
|
2016-08-16 04:54:48 +08:00
|
|
|
#include <linux/export.h>
|
2006-03-31 18:31:05 +08:00
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/list.h>
|
|
|
|
#include <linux/spinlock.h>
|
|
|
|
#include <linux/device.h>
|
|
|
|
#include <linux/timer.h>
|
2007-11-10 21:29:04 +08:00
|
|
|
#include <linux/rwsem.h>
|
2006-03-31 18:31:05 +08:00
|
|
|
#include <linux/leds.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 16:04:11 +08:00
|
|
|
#include <linux/slab.h>
|
2019-09-29 22:18:49 +08:00
|
|
|
#include <linux/mm.h>
|
2006-03-31 18:31:05 +08:00
|
|
|
#include "leds.h"
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Nests outside led_cdev->trigger_lock
|
|
|
|
*/
|
2007-11-10 21:29:04 +08:00
|
|
|
static DECLARE_RWSEM(triggers_list_lock);
|
2016-04-29 06:03:38 +08:00
|
|
|
LIST_HEAD(trigger_list);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2008-03-10 04:59:57 +08:00
|
|
|
/* Used by LED Class */
|
|
|
|
|
2020-07-17 01:17:28 +08:00
|
|
|
static inline bool
|
|
|
|
trigger_relevant(struct led_classdev *led_cdev, struct led_trigger *trig)
|
|
|
|
{
|
|
|
|
return !trig->trigger_type || trig->trigger_type == led_cdev->trigger_type;
|
|
|
|
}
|
|
|
|
|
2019-09-29 22:18:49 +08:00
|
|
|
ssize_t led_trigger_write(struct file *filp, struct kobject *kobj,
|
|
|
|
struct bin_attribute *bin_attr, char *buf,
|
|
|
|
loff_t pos, size_t count)
|
2006-03-31 18:31:05 +08:00
|
|
|
{
|
2019-09-29 22:18:49 +08:00
|
|
|
struct device *dev = kobj_to_dev(kobj);
|
2007-07-09 06:19:31 +08:00
|
|
|
struct led_classdev *led_cdev = dev_get_drvdata(dev);
|
2006-03-31 18:31:05 +08:00
|
|
|
struct led_trigger *trig;
|
2014-09-22 23:21:04 +08:00
|
|
|
int ret = count;
|
|
|
|
|
|
|
|
mutex_lock(&led_cdev->led_access);
|
|
|
|
|
|
|
|
if (led_sysfs_is_disabled(led_cdev)) {
|
|
|
|
ret = -EBUSY;
|
|
|
|
goto unlock;
|
|
|
|
}
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2016-03-09 06:08:36 +08:00
|
|
|
if (sysfs_streq(buf, "none")) {
|
2008-03-10 04:54:37 +08:00
|
|
|
led_trigger_remove(led_cdev);
|
2014-09-22 23:21:04 +08:00
|
|
|
goto unlock;
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
|
|
|
|
2007-11-10 21:29:04 +08:00
|
|
|
down_read(&triggers_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
list_for_each_entry(trig, &trigger_list, next_trig) {
|
2020-07-17 01:17:28 +08:00
|
|
|
if (sysfs_streq(buf, trig->name) && trigger_relevant(led_cdev, trig)) {
|
2007-11-10 21:29:04 +08:00
|
|
|
down_write(&led_cdev->trigger_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
led_trigger_set(led_cdev, trig);
|
2007-11-10 21:29:04 +08:00
|
|
|
up_write(&led_cdev->trigger_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2007-11-10 21:29:04 +08:00
|
|
|
up_read(&triggers_list_lock);
|
2014-09-22 23:21:04 +08:00
|
|
|
goto unlock;
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
|
|
|
}
|
2016-07-02 05:08:54 +08:00
|
|
|
/* we come here only if buf matches no trigger */
|
|
|
|
ret = -EINVAL;
|
2007-11-10 21:29:04 +08:00
|
|
|
up_read(&triggers_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2014-09-22 23:21:04 +08:00
|
|
|
unlock:
|
|
|
|
mutex_unlock(&led_cdev->led_access);
|
|
|
|
return ret;
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2019-09-29 22:18:49 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_write);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2019-09-29 22:18:49 +08:00
|
|
|
__printf(3, 4)
|
|
|
|
static int led_trigger_snprintf(char *buf, ssize_t size, const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list args;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
va_start(args, fmt);
|
|
|
|
if (size <= 0)
|
|
|
|
i = vsnprintf(NULL, 0, fmt, args);
|
|
|
|
else
|
|
|
|
i = vscnprintf(buf, size, fmt, args);
|
|
|
|
va_end(args);
|
|
|
|
|
|
|
|
return i;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int led_trigger_format(char *buf, size_t size,
|
|
|
|
struct led_classdev *led_cdev)
|
2006-03-31 18:31:05 +08:00
|
|
|
{
|
|
|
|
struct led_trigger *trig;
|
2019-09-29 22:18:49 +08:00
|
|
|
int len = led_trigger_snprintf(buf, size, "%s",
|
|
|
|
led_cdev->trigger ? "none" : "[none]");
|
|
|
|
|
|
|
|
list_for_each_entry(trig, &trigger_list, next_trig) {
|
2020-07-17 01:17:28 +08:00
|
|
|
bool hit;
|
|
|
|
|
|
|
|
if (!trigger_relevant(led_cdev, trig))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
hit = led_cdev->trigger && !strcmp(led_cdev->trigger->name, trig->name);
|
2019-09-29 22:18:49 +08:00
|
|
|
|
|
|
|
len += led_trigger_snprintf(buf + len, size - len,
|
|
|
|
" %s%s%s", hit ? "[" : "",
|
|
|
|
trig->name, hit ? "]" : "");
|
|
|
|
}
|
|
|
|
|
|
|
|
len += led_trigger_snprintf(buf + len, size - len, "\n");
|
|
|
|
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* It was stupid to create 10000 cpu triggers, but we are stuck with it now.
|
|
|
|
* Don't make that mistake again. We work around it here by creating binary
|
|
|
|
* attribute, which is not limited by length. This is _not_ good design, do not
|
|
|
|
* copy it.
|
|
|
|
*/
|
|
|
|
ssize_t led_trigger_read(struct file *filp, struct kobject *kobj,
|
|
|
|
struct bin_attribute *attr, char *buf,
|
|
|
|
loff_t pos, size_t count)
|
|
|
|
{
|
|
|
|
struct device *dev = kobj_to_dev(kobj);
|
|
|
|
struct led_classdev *led_cdev = dev_get_drvdata(dev);
|
|
|
|
void *data;
|
|
|
|
int len;
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2007-11-10 21:29:04 +08:00
|
|
|
down_read(&triggers_list_lock);
|
|
|
|
down_read(&led_cdev->trigger_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2019-09-29 22:18:49 +08:00
|
|
|
len = led_trigger_format(NULL, 0, led_cdev);
|
|
|
|
data = kvmalloc(len + 1, GFP_KERNEL);
|
|
|
|
if (!data) {
|
|
|
|
up_read(&led_cdev->trigger_lock);
|
|
|
|
up_read(&triggers_list_lock);
|
|
|
|
return -ENOMEM;
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2019-09-29 22:18:49 +08:00
|
|
|
len = led_trigger_format(data, len + 1, led_cdev);
|
|
|
|
|
2007-11-10 21:29:04 +08:00
|
|
|
up_read(&led_cdev->trigger_lock);
|
|
|
|
up_read(&triggers_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2019-09-29 22:18:49 +08:00
|
|
|
len = memory_read_from_buffer(buf, count, &pos, data, len);
|
|
|
|
|
|
|
|
kvfree(data);
|
|
|
|
|
2006-03-31 18:31:05 +08:00
|
|
|
return len;
|
|
|
|
}
|
2019-09-29 22:18:49 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_read);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
|
|
|
/* Caller must ensure led_cdev->trigger_lock held */
|
2018-07-03 04:05:21 +08:00
|
|
|
int led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
|
2006-03-31 18:31:05 +08:00
|
|
|
{
|
2012-08-27 09:31:49 +08:00
|
|
|
char *event = NULL;
|
|
|
|
char *envp[2];
|
|
|
|
const char *name;
|
2018-07-03 04:05:21 +08:00
|
|
|
int ret;
|
2012-08-27 09:31:49 +08:00
|
|
|
|
2016-09-19 02:24:29 +08:00
|
|
|
if (!led_cdev->trigger && !trig)
|
2018-07-03 04:05:21 +08:00
|
|
|
return 0;
|
2016-09-19 02:24:29 +08:00
|
|
|
|
2012-08-27 09:31:49 +08:00
|
|
|
name = trig ? trig->name : "none";
|
|
|
|
event = kasprintf(GFP_KERNEL, "TRIGGER=%s", name);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
|
|
|
/* Remove any existing trigger */
|
|
|
|
if (led_cdev->trigger) {
|
leds: trigger: use RCU to protect the led_cdevs list
Even with the previous commit 27af8e2c90fb
("leds: trigger: fix potential deadlock with libata")
to this file, we still get lockdep unhappy, and Boqun
explained the report here:
https://lore.kernel.org/r/YNA+d1X4UkoQ7g8a@boqun-archlinux
Effectively, this means that the read_lock_irqsave() isn't
enough here because another CPU might be trying to do a
write lock, and thus block the readers.
This is all pretty messy, but it doesn't seem right that
the LEDs framework imposes some locking requirements on
users, in particular we'd have to make the spinlock in the
iwlwifi driver always disable IRQs, even if we don't need
that for any other reason, just to avoid this deadlock.
Since writes to the led_cdevs list are rare (and are done
by userspace), just switch the list to RCU. This costs a
synchronize_rcu() at removal time so we can ensure things
are correct, but that seems like a small price to pay for
getting lock-free iterations and no deadlocks (nor any
locking requirements imposed on users.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
2021-09-16 00:16:01 +08:00
|
|
|
spin_lock(&led_cdev->trigger->leddev_list_lock);
|
|
|
|
list_del_rcu(&led_cdev->trig_list);
|
|
|
|
spin_unlock(&led_cdev->trigger->leddev_list_lock);
|
|
|
|
|
|
|
|
/* ensure it's no longer visible on the led_cdevs list */
|
|
|
|
synchronize_rcu();
|
|
|
|
|
2012-08-15 21:44:34 +08:00
|
|
|
cancel_work_sync(&led_cdev->set_brightness_work);
|
|
|
|
led_stop_software_blink(led_cdev);
|
2024-05-05 00:25:33 +08:00
|
|
|
device_remove_groups(led_cdev->dev, led_cdev->trigger->groups);
|
2006-03-31 18:31:05 +08:00
|
|
|
if (led_cdev->trigger->deactivate)
|
|
|
|
led_cdev->trigger->deactivate(led_cdev);
|
2008-07-17 05:51:14 +08:00
|
|
|
led_cdev->trigger = NULL;
|
2018-07-03 04:05:23 +08:00
|
|
|
led_cdev->trigger_data = NULL;
|
|
|
|
led_cdev->activated = false;
|
2012-06-14 04:34:30 +08:00
|
|
|
led_set_brightness(led_cdev, LED_OFF);
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2012-04-19 11:46:33 +08:00
|
|
|
if (trig) {
|
leds: trigger: use RCU to protect the led_cdevs list
Even with the previous commit 27af8e2c90fb
("leds: trigger: fix potential deadlock with libata")
to this file, we still get lockdep unhappy, and Boqun
explained the report here:
https://lore.kernel.org/r/YNA+d1X4UkoQ7g8a@boqun-archlinux
Effectively, this means that the read_lock_irqsave() isn't
enough here because another CPU might be trying to do a
write lock, and thus block the readers.
This is all pretty messy, but it doesn't seem right that
the LEDs framework imposes some locking requirements on
users, in particular we'd have to make the spinlock in the
iwlwifi driver always disable IRQs, even if we don't need
that for any other reason, just to avoid this deadlock.
Since writes to the led_cdevs list are rare (and are done
by userspace), just switch the list to RCU. This costs a
synchronize_rcu() at removal time so we can ensure things
are correct, but that seems like a small price to pay for
getting lock-free iterations and no deadlocks (nor any
locking requirements imposed on users.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
2021-09-16 00:16:01 +08:00
|
|
|
spin_lock(&trig->leddev_list_lock);
|
|
|
|
list_add_tail_rcu(&led_cdev->trig_list, &trig->led_cdevs);
|
|
|
|
spin_unlock(&trig->leddev_list_lock);
|
2012-04-19 11:46:33 +08:00
|
|
|
led_cdev->trigger = trig;
|
2018-07-03 04:05:21 +08:00
|
|
|
|
2024-05-31 20:01:24 +08:00
|
|
|
/*
|
|
|
|
* Some activate() calls use led_trigger_event() to initialize
|
|
|
|
* the brightness of the LED for which the trigger is being set.
|
|
|
|
* Ensure the led_cdev is visible on trig->led_cdevs for this.
|
|
|
|
*/
|
|
|
|
synchronize_rcu();
|
|
|
|
|
2024-06-13 23:24:51 +08:00
|
|
|
/*
|
|
|
|
* If "set brightness to 0" is pending in workqueue,
|
|
|
|
* we don't want that to be reordered after ->activate()
|
|
|
|
*/
|
|
|
|
flush_work(&led_cdev->set_brightness_work);
|
|
|
|
|
2024-03-05 04:57:30 +08:00
|
|
|
ret = 0;
|
2012-04-19 11:46:33 +08:00
|
|
|
if (trig->activate)
|
2018-07-03 04:05:21 +08:00
|
|
|
ret = trig->activate(led_cdev);
|
|
|
|
else
|
2024-03-05 04:57:30 +08:00
|
|
|
led_set_brightness(led_cdev, trig->brightness);
|
2018-07-03 04:05:21 +08:00
|
|
|
if (ret)
|
|
|
|
goto err_activate;
|
2018-07-03 04:05:22 +08:00
|
|
|
|
|
|
|
ret = device_add_groups(led_cdev->dev, trig->groups);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(led_cdev->dev, "Failed to add trigger attributes\n");
|
|
|
|
goto err_add_groups;
|
|
|
|
}
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2012-08-27 09:31:49 +08:00
|
|
|
|
|
|
|
if (event) {
|
|
|
|
envp[0] = event;
|
|
|
|
envp[1] = NULL;
|
2016-09-19 18:44:50 +08:00
|
|
|
if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
|
|
|
|
dev_err(led_cdev->dev,
|
|
|
|
"%s: Error sending uevent\n", __func__);
|
2012-08-27 09:31:49 +08:00
|
|
|
kfree(event);
|
|
|
|
}
|
2018-07-03 04:05:21 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
2018-07-03 04:05:22 +08:00
|
|
|
err_add_groups:
|
|
|
|
|
|
|
|
if (trig->deactivate)
|
|
|
|
trig->deactivate(led_cdev);
|
2018-07-03 04:05:21 +08:00
|
|
|
err_activate:
|
2018-07-03 04:05:22 +08:00
|
|
|
|
leds: trigger: use RCU to protect the led_cdevs list
Even with the previous commit 27af8e2c90fb
("leds: trigger: fix potential deadlock with libata")
to this file, we still get lockdep unhappy, and Boqun
explained the report here:
https://lore.kernel.org/r/YNA+d1X4UkoQ7g8a@boqun-archlinux
Effectively, this means that the read_lock_irqsave() isn't
enough here because another CPU might be trying to do a
write lock, and thus block the readers.
This is all pretty messy, but it doesn't seem right that
the LEDs framework imposes some locking requirements on
users, in particular we'd have to make the spinlock in the
iwlwifi driver always disable IRQs, even if we don't need
that for any other reason, just to avoid this deadlock.
Since writes to the led_cdevs list are rare (and are done
by userspace), just switch the list to RCU. This costs a
synchronize_rcu() at removal time so we can ensure things
are correct, but that seems like a small price to pay for
getting lock-free iterations and no deadlocks (nor any
locking requirements imposed on users.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
2021-09-16 00:16:01 +08:00
|
|
|
spin_lock(&led_cdev->trigger->leddev_list_lock);
|
|
|
|
list_del_rcu(&led_cdev->trig_list);
|
|
|
|
spin_unlock(&led_cdev->trigger->leddev_list_lock);
|
|
|
|
synchronize_rcu();
|
2019-09-04 05:18:19 +08:00
|
|
|
led_cdev->trigger = NULL;
|
|
|
|
led_cdev->trigger_data = NULL;
|
2018-07-03 04:05:21 +08:00
|
|
|
led_set_brightness(led_cdev, LED_OFF);
|
2019-08-20 04:41:42 +08:00
|
|
|
kfree(event);
|
2018-07-03 04:05:21 +08:00
|
|
|
|
|
|
|
return ret;
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2008-03-10 04:59:57 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_set);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2008-03-10 04:54:37 +08:00
|
|
|
void led_trigger_remove(struct led_classdev *led_cdev)
|
|
|
|
{
|
|
|
|
down_write(&led_cdev->trigger_lock);
|
|
|
|
led_trigger_set(led_cdev, NULL);
|
|
|
|
up_write(&led_cdev->trigger_lock);
|
|
|
|
}
|
2008-03-10 04:59:57 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_remove);
|
2008-03-10 04:54:37 +08:00
|
|
|
|
2006-03-31 18:31:05 +08:00
|
|
|
void led_trigger_set_default(struct led_classdev *led_cdev)
|
|
|
|
{
|
|
|
|
struct led_trigger *trig;
|
|
|
|
|
|
|
|
if (!led_cdev->default_trigger)
|
|
|
|
return;
|
|
|
|
|
2007-11-10 21:29:04 +08:00
|
|
|
down_read(&triggers_list_lock);
|
|
|
|
down_write(&led_cdev->trigger_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
list_for_each_entry(trig, &trigger_list, next_trig) {
|
2020-07-17 01:17:28 +08:00
|
|
|
if (!strcmp(led_cdev->default_trigger, trig->name) &&
|
|
|
|
trigger_relevant(led_cdev, trig)) {
|
2018-12-10 17:29:58 +08:00
|
|
|
led_cdev->flags |= LED_INIT_DEFAULT_TRIGGER;
|
2006-03-31 18:31:05 +08:00
|
|
|
led_trigger_set(led_cdev, trig);
|
2018-12-10 17:29:57 +08:00
|
|
|
break;
|
|
|
|
}
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2007-11-10 21:29:04 +08:00
|
|
|
up_write(&led_cdev->trigger_lock);
|
|
|
|
up_read(&triggers_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2008-03-10 04:59:57 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_set_default);
|
|
|
|
|
|
|
|
/* LED Trigger Interface */
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2012-04-19 11:46:33 +08:00
|
|
|
int led_trigger_register(struct led_trigger *trig)
|
2006-03-31 18:31:05 +08:00
|
|
|
{
|
|
|
|
struct led_classdev *led_cdev;
|
2012-04-19 11:46:33 +08:00
|
|
|
struct led_trigger *_trig;
|
2006-03-31 18:31:05 +08:00
|
|
|
|
leds: trigger: use RCU to protect the led_cdevs list
Even with the previous commit 27af8e2c90fb
("leds: trigger: fix potential deadlock with libata")
to this file, we still get lockdep unhappy, and Boqun
explained the report here:
https://lore.kernel.org/r/YNA+d1X4UkoQ7g8a@boqun-archlinux
Effectively, this means that the read_lock_irqsave() isn't
enough here because another CPU might be trying to do a
write lock, and thus block the readers.
This is all pretty messy, but it doesn't seem right that
the LEDs framework imposes some locking requirements on
users, in particular we'd have to make the spinlock in the
iwlwifi driver always disable IRQs, even if we don't need
that for any other reason, just to avoid this deadlock.
Since writes to the led_cdevs list are rare (and are done
by userspace), just switch the list to RCU. This costs a
synchronize_rcu() at removal time so we can ensure things
are correct, but that seems like a small price to pay for
getting lock-free iterations and no deadlocks (nor any
locking requirements imposed on users.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
2021-09-16 00:16:01 +08:00
|
|
|
spin_lock_init(&trig->leddev_list_lock);
|
2012-04-19 11:46:33 +08:00
|
|
|
INIT_LIST_HEAD(&trig->led_cdevs);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2007-11-10 21:29:04 +08:00
|
|
|
down_write(&triggers_list_lock);
|
2009-02-18 06:18:04 +08:00
|
|
|
/* Make sure the trigger's name isn't already in use */
|
2012-04-19 11:46:33 +08:00
|
|
|
list_for_each_entry(_trig, &trigger_list, next_trig) {
|
2020-07-17 01:17:28 +08:00
|
|
|
if (!strcmp(_trig->name, trig->name) &&
|
|
|
|
(trig->trigger_type == _trig->trigger_type ||
|
|
|
|
!trig->trigger_type || !_trig->trigger_type)) {
|
2009-02-18 06:18:04 +08:00
|
|
|
up_write(&triggers_list_lock);
|
|
|
|
return -EEXIST;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
/* Add to the list of led triggers */
|
2012-04-19 11:46:33 +08:00
|
|
|
list_add_tail(&trig->next_trig, &trigger_list);
|
2007-11-10 21:29:04 +08:00
|
|
|
up_write(&triggers_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
|
|
|
/* Register with any LEDs that have this as a default trigger */
|
2008-01-01 07:09:44 +08:00
|
|
|
down_read(&leds_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
list_for_each_entry(led_cdev, &leds_list, node) {
|
2007-11-10 21:29:04 +08:00
|
|
|
down_write(&led_cdev->trigger_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
if (!led_cdev->trigger && led_cdev->default_trigger &&
|
2020-07-17 01:17:28 +08:00
|
|
|
!strcmp(led_cdev->default_trigger, trig->name) &&
|
|
|
|
trigger_relevant(led_cdev, trig)) {
|
2018-12-10 17:29:59 +08:00
|
|
|
led_cdev->flags |= LED_INIT_DEFAULT_TRIGGER;
|
2012-04-19 11:46:33 +08:00
|
|
|
led_trigger_set(led_cdev, trig);
|
2018-12-10 17:29:59 +08:00
|
|
|
}
|
2007-11-10 21:29:04 +08:00
|
|
|
up_write(&led_cdev->trigger_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2008-01-01 07:09:44 +08:00
|
|
|
up_read(&leds_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2008-03-10 04:59:57 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_register);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2012-04-19 11:46:33 +08:00
|
|
|
void led_trigger_unregister(struct led_trigger *trig)
|
2006-03-31 18:31:05 +08:00
|
|
|
{
|
|
|
|
struct led_classdev *led_cdev;
|
|
|
|
|
2014-04-05 01:01:13 +08:00
|
|
|
if (list_empty_careful(&trig->next_trig))
|
|
|
|
return;
|
|
|
|
|
2006-03-31 18:31:05 +08:00
|
|
|
/* Remove from the list of led triggers */
|
2007-11-10 21:29:04 +08:00
|
|
|
down_write(&triggers_list_lock);
|
2014-04-05 01:01:13 +08:00
|
|
|
list_del_init(&trig->next_trig);
|
2007-11-10 21:29:04 +08:00
|
|
|
up_write(&triggers_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
|
|
|
/* Remove anyone actively using this trigger */
|
2008-01-01 07:09:44 +08:00
|
|
|
down_read(&leds_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
list_for_each_entry(led_cdev, &leds_list, node) {
|
2007-11-10 21:29:04 +08:00
|
|
|
down_write(&led_cdev->trigger_lock);
|
2012-04-19 11:46:33 +08:00
|
|
|
if (led_cdev->trigger == trig)
|
2006-03-31 18:31:05 +08:00
|
|
|
led_trigger_set(led_cdev, NULL);
|
2007-11-10 21:29:04 +08:00
|
|
|
up_write(&led_cdev->trigger_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2008-01-01 07:09:44 +08:00
|
|
|
up_read(&leds_list_lock);
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2008-03-10 04:59:57 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_unregister);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2016-01-02 08:36:41 +08:00
|
|
|
static void devm_led_trigger_release(struct device *dev, void *res)
|
|
|
|
{
|
|
|
|
led_trigger_unregister(*(struct led_trigger **)res);
|
|
|
|
}
|
|
|
|
|
|
|
|
int devm_led_trigger_register(struct device *dev,
|
|
|
|
struct led_trigger *trig)
|
|
|
|
{
|
|
|
|
struct led_trigger **dr;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
dr = devres_alloc(devm_led_trigger_release, sizeof(*dr),
|
|
|
|
GFP_KERNEL);
|
|
|
|
if (!dr)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
*dr = trig;
|
|
|
|
|
|
|
|
rc = led_trigger_register(trig);
|
|
|
|
if (rc)
|
|
|
|
devres_free(dr);
|
|
|
|
else
|
|
|
|
devres_add(dev, dr);
|
|
|
|
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(devm_led_trigger_register);
|
|
|
|
|
2020-06-09 23:49:29 +08:00
|
|
|
/* Simple LED Trigger Interface */
|
2008-03-10 04:59:57 +08:00
|
|
|
|
2012-04-19 11:46:33 +08:00
|
|
|
void led_trigger_event(struct led_trigger *trig,
|
2008-03-10 04:59:57 +08:00
|
|
|
enum led_brightness brightness)
|
2006-03-31 18:31:05 +08:00
|
|
|
{
|
2013-12-28 23:00:26 +08:00
|
|
|
struct led_classdev *led_cdev;
|
2008-03-10 04:59:57 +08:00
|
|
|
|
2012-04-19 11:46:33 +08:00
|
|
|
if (!trig)
|
2008-03-10 04:59:57 +08:00
|
|
|
return;
|
|
|
|
|
2024-03-05 04:57:30 +08:00
|
|
|
trig->brightness = brightness;
|
|
|
|
|
leds: trigger: use RCU to protect the led_cdevs list
Even with the previous commit 27af8e2c90fb
("leds: trigger: fix potential deadlock with libata")
to this file, we still get lockdep unhappy, and Boqun
explained the report here:
https://lore.kernel.org/r/YNA+d1X4UkoQ7g8a@boqun-archlinux
Effectively, this means that the read_lock_irqsave() isn't
enough here because another CPU might be trying to do a
write lock, and thus block the readers.
This is all pretty messy, but it doesn't seem right that
the LEDs framework imposes some locking requirements on
users, in particular we'd have to make the spinlock in the
iwlwifi driver always disable IRQs, even if we don't need
that for any other reason, just to avoid this deadlock.
Since writes to the led_cdevs list are rare (and are done
by userspace), just switch the list to RCU. This costs a
synchronize_rcu() at removal time so we can ensure things
are correct, but that seems like a small price to pay for
getting lock-free iterations and no deadlocks (nor any
locking requirements imposed on users.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
2021-09-16 00:16:01 +08:00
|
|
|
rcu_read_lock();
|
|
|
|
list_for_each_entry_rcu(led_cdev, &trig->led_cdevs, trig_list)
|
2012-08-15 21:44:34 +08:00
|
|
|
led_set_brightness(led_cdev, brightness);
|
leds: trigger: use RCU to protect the led_cdevs list
Even with the previous commit 27af8e2c90fb
("leds: trigger: fix potential deadlock with libata")
to this file, we still get lockdep unhappy, and Boqun
explained the report here:
https://lore.kernel.org/r/YNA+d1X4UkoQ7g8a@boqun-archlinux
Effectively, this means that the read_lock_irqsave() isn't
enough here because another CPU might be trying to do a
write lock, and thus block the readers.
This is all pretty messy, but it doesn't seem right that
the LEDs framework imposes some locking requirements on
users, in particular we'd have to make the spinlock in the
iwlwifi driver always disable IRQs, even if we don't need
that for any other reason, just to avoid this deadlock.
Since writes to the led_cdevs list are rare (and are done
by userspace), just switch the list to RCU. This costs a
synchronize_rcu() at removal time so we can ensure things
are correct, but that seems like a small price to pay for
getting lock-free iterations and no deadlocks (nor any
locking requirements imposed on users.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
2021-09-16 00:16:01 +08:00
|
|
|
rcu_read_unlock();
|
2006-03-31 18:31:05 +08:00
|
|
|
}
|
2008-03-10 04:59:57 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_event);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2012-06-15 22:15:27 +08:00
|
|
|
static void led_trigger_blink_setup(struct led_trigger *trig,
|
2012-05-27 07:19:22 +08:00
|
|
|
unsigned long *delay_on,
|
|
|
|
unsigned long *delay_off,
|
|
|
|
int oneshot,
|
|
|
|
int invert)
|
2011-01-08 00:28:16 +08:00
|
|
|
{
|
2013-12-28 23:00:26 +08:00
|
|
|
struct led_classdev *led_cdev;
|
2011-01-08 00:28:16 +08:00
|
|
|
|
2012-04-19 11:46:33 +08:00
|
|
|
if (!trig)
|
2011-01-08 00:28:16 +08:00
|
|
|
return;
|
|
|
|
|
leds: trigger: use RCU to protect the led_cdevs list
Even with the previous commit 27af8e2c90fb
("leds: trigger: fix potential deadlock with libata")
to this file, we still get lockdep unhappy, and Boqun
explained the report here:
https://lore.kernel.org/r/YNA+d1X4UkoQ7g8a@boqun-archlinux
Effectively, this means that the read_lock_irqsave() isn't
enough here because another CPU might be trying to do a
write lock, and thus block the readers.
This is all pretty messy, but it doesn't seem right that
the LEDs framework imposes some locking requirements on
users, in particular we'd have to make the spinlock in the
iwlwifi driver always disable IRQs, even if we don't need
that for any other reason, just to avoid this deadlock.
Since writes to the led_cdevs list are rare (and are done
by userspace), just switch the list to RCU. This costs a
synchronize_rcu() at removal time so we can ensure things
are correct, but that seems like a small price to pay for
getting lock-free iterations and no deadlocks (nor any
locking requirements imposed on users.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
2021-09-16 00:16:01 +08:00
|
|
|
rcu_read_lock();
|
|
|
|
list_for_each_entry_rcu(led_cdev, &trig->led_cdevs, trig_list) {
|
2012-05-27 07:19:22 +08:00
|
|
|
if (oneshot)
|
|
|
|
led_blink_set_oneshot(led_cdev, delay_on, delay_off,
|
|
|
|
invert);
|
|
|
|
else
|
|
|
|
led_blink_set(led_cdev, delay_on, delay_off);
|
2011-01-08 00:28:16 +08:00
|
|
|
}
|
leds: trigger: use RCU to protect the led_cdevs list
Even with the previous commit 27af8e2c90fb
("leds: trigger: fix potential deadlock with libata")
to this file, we still get lockdep unhappy, and Boqun
explained the report here:
https://lore.kernel.org/r/YNA+d1X4UkoQ7g8a@boqun-archlinux
Effectively, this means that the read_lock_irqsave() isn't
enough here because another CPU might be trying to do a
write lock, and thus block the readers.
This is all pretty messy, but it doesn't seem right that
the LEDs framework imposes some locking requirements on
users, in particular we'd have to make the spinlock in the
iwlwifi driver always disable IRQs, even if we don't need
that for any other reason, just to avoid this deadlock.
Since writes to the led_cdevs list are rare (and are done
by userspace), just switch the list to RCU. This costs a
synchronize_rcu() at removal time so we can ensure things
are correct, but that seems like a small price to pay for
getting lock-free iterations and no deadlocks (nor any
locking requirements imposed on users.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
2021-09-16 00:16:01 +08:00
|
|
|
rcu_read_unlock();
|
2011-01-08 00:28:16 +08:00
|
|
|
}
|
2012-05-27 07:19:22 +08:00
|
|
|
|
|
|
|
void led_trigger_blink(struct led_trigger *trig,
|
|
|
|
unsigned long *delay_on,
|
|
|
|
unsigned long *delay_off)
|
|
|
|
{
|
|
|
|
led_trigger_blink_setup(trig, delay_on, delay_off, 0, 0);
|
|
|
|
}
|
2011-01-08 00:28:16 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_blink);
|
|
|
|
|
2012-05-27 07:19:22 +08:00
|
|
|
void led_trigger_blink_oneshot(struct led_trigger *trig,
|
|
|
|
unsigned long *delay_on,
|
|
|
|
unsigned long *delay_off,
|
|
|
|
int invert)
|
|
|
|
{
|
|
|
|
led_trigger_blink_setup(trig, delay_on, delay_off, 1, invert);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_blink_oneshot);
|
|
|
|
|
2008-03-10 04:59:57 +08:00
|
|
|
void led_trigger_register_simple(const char *name, struct led_trigger **tp)
|
|
|
|
{
|
2012-04-19 11:46:33 +08:00
|
|
|
struct led_trigger *trig;
|
2008-03-10 04:59:57 +08:00
|
|
|
int err;
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2012-04-19 11:46:33 +08:00
|
|
|
trig = kzalloc(sizeof(struct led_trigger), GFP_KERNEL);
|
2006-03-31 18:31:05 +08:00
|
|
|
|
2012-04-19 11:46:33 +08:00
|
|
|
if (trig) {
|
|
|
|
trig->name = name;
|
|
|
|
err = led_trigger_register(trig);
|
2011-11-01 08:11:59 +08:00
|
|
|
if (err < 0) {
|
2012-04-19 11:46:33 +08:00
|
|
|
kfree(trig);
|
|
|
|
trig = NULL;
|
2012-11-25 15:30:44 +08:00
|
|
|
pr_warn("LED trigger %s failed to register (%d)\n",
|
|
|
|
name, err);
|
2011-11-01 08:11:59 +08:00
|
|
|
}
|
2012-11-25 15:30:44 +08:00
|
|
|
} else {
|
|
|
|
pr_warn("LED trigger %s failed to register (no memory)\n",
|
|
|
|
name);
|
|
|
|
}
|
2012-04-19 11:46:33 +08:00
|
|
|
*tp = trig;
|
2008-03-10 04:59:57 +08:00
|
|
|
}
|
2006-03-31 18:31:05 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_register_simple);
|
2008-03-10 04:59:57 +08:00
|
|
|
|
2012-04-19 11:46:33 +08:00
|
|
|
void led_trigger_unregister_simple(struct led_trigger *trig)
|
2008-03-10 04:59:57 +08:00
|
|
|
{
|
2012-04-19 11:46:33 +08:00
|
|
|
if (trig)
|
|
|
|
led_trigger_unregister(trig);
|
|
|
|
kfree(trig);
|
2008-03-10 04:59:57 +08:00
|
|
|
}
|
2006-03-31 18:31:05 +08:00
|
|
|
EXPORT_SYMBOL_GPL(led_trigger_unregister_simple);
|