korg/kmod
0
0
Fork 0
mirror of https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git synced 2024-11-26 21:33:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

libkmod: Clarify function signature

Browse Source 
The module_get_dependencies_noref function may modify content of
given kmod_module struct, so clarify this fact.

Actually we would have to adjust kmod API for total clarification,
but let's start with internally used functions first.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/211
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
This commit is contained in:
Tobias Stoeckmann 2024-10-24 21:04:28 +02:00 committed by Lucas De Marchi
parent be728dd347
commit 6ac1bccfe1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libkmod/libkmod-module.c
View File

@ -506,14 +506,14 @@ KMOD_EXPORT int kmod_module_get_filtered_blacklist(const struct kmod_ctx *ctx,
return kmod_module_apply_filter(ctx, KMOD_FILTER_BLACKLIST, input, output);
}
static void module_get_dependencies_noref(const struct kmod_module *mod)
static void module_get_dependencies_noref(struct kmod_module *mod)
{
if (!mod->init.dep) {
/* lazy init */
char *line = kmod_search_moddep(mod->ctx, mod->name);
if (line != NULL) {
kmod_module_parse_depline((struct kmod_module *)mod, line);
kmod_module_parse_depline(mod, line);
free(line);
}
}
@ -526,7 +526,7 @@ KMOD_EXPORT struct kmod_list *kmod_module_get_dependencies(const struct kmod_mod
if (mod == NULL)
return NULL;
module_get_dependencies_noref(mod);
module_get_dependencies_noref((struct kmod_module *)mod);
kmod_list_foreach(l, mod->dep) {
l_new = kmod_list_append(list_new, kmod_module_ref(l->data));
@ -575,7 +575,7 @@ KMOD_EXPORT const char *kmod_module_get_path(const struct kmod_module *mod)
return NULL;
/* lazy init */
module_get_dependencies_noref(mod);
module_get_dependencies_noref((struct kmod_module *)mod);
return mod->path;
}