mirror of
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git
synced 2024-11-15 22:15:13 +08:00
459f280813
When receiving a result from first query to netlink, we may exec
a another query inside the callback. If calling this sub-routine
in the same socket, it will be discarded the result from previous
exection.
To avoid this we perform a nested query in separate socket.
Fixes: 2021028306
("tipc: use the libmnl functions in lib/mnl_utils.c")
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
151 lines
3.8 KiB
C
151 lines
3.8 KiB
C
/*
|
|
* socket.c TIPC socket functionality.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*
|
|
* Authors: Richard Alpe <richard.alpe@ericsson.com>
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <errno.h>
|
|
|
|
#include <linux/tipc.h>
|
|
#include <linux/tipc_netlink.h>
|
|
#include <linux/genetlink.h>
|
|
#include <libmnl/libmnl.h>
|
|
|
|
#include "mnl_utils.h"
|
|
#include "cmdl.h"
|
|
#include "msg.h"
|
|
#include "socket.h"
|
|
|
|
#define PORTID_STR_LEN 45 /* Four u32 and five delimiter chars */
|
|
|
|
static int publ_list_cb(const struct nlmsghdr *nlh, void *data)
|
|
{
|
|
struct genlmsghdr *genl = mnl_nlmsg_get_payload(nlh);
|
|
struct nlattr *info[TIPC_NLA_MAX + 1] = {};
|
|
struct nlattr *attrs[TIPC_NLA_SOCK_MAX + 1] = {};
|
|
|
|
mnl_attr_parse(nlh, sizeof(*genl), parse_attrs, info);
|
|
if (!info[TIPC_NLA_PUBL])
|
|
return MNL_CB_ERROR;
|
|
|
|
mnl_attr_parse_nested(info[TIPC_NLA_PUBL], parse_attrs, attrs);
|
|
|
|
printf(" bound to {%u,%u,%u}\n",
|
|
mnl_attr_get_u32(attrs[TIPC_NLA_PUBL_TYPE]),
|
|
mnl_attr_get_u32(attrs[TIPC_NLA_PUBL_LOWER]),
|
|
mnl_attr_get_u32(attrs[TIPC_NLA_PUBL_UPPER]));
|
|
|
|
return MNL_CB_OK;
|
|
}
|
|
|
|
static int publ_list(uint32_t sock)
|
|
{
|
|
struct mnlu_gen_socket sock_nlg;
|
|
struct nlmsghdr *nlh;
|
|
struct nlattr *nest;
|
|
int err;
|
|
|
|
err = mnlu_gen_socket_open(&sock_nlg, TIPC_GENL_V2_NAME,
|
|
TIPC_GENL_V2_VERSION);
|
|
if (err)
|
|
return -1;
|
|
|
|
nlh = mnlu_gen_socket_cmd_prepare(&sock_nlg, TIPC_NL_PUBL_GET,
|
|
NLM_F_REQUEST | NLM_F_DUMP);
|
|
if (!nlh) {
|
|
fprintf(stderr, "error, message initialisation failed\n");
|
|
mnlu_gen_socket_close(&sock_nlg);
|
|
return -1;
|
|
}
|
|
|
|
nest = mnl_attr_nest_start(nlh, TIPC_NLA_SOCK);
|
|
mnl_attr_put_u32(nlh, TIPC_NLA_SOCK_REF, sock);
|
|
mnl_attr_nest_end(nlh, nest);
|
|
|
|
err = mnlu_gen_socket_sndrcv(&sock_nlg, nlh, publ_list_cb, NULL);
|
|
mnlu_gen_socket_close(&sock_nlg);
|
|
return err;
|
|
}
|
|
|
|
static int sock_list_cb(const struct nlmsghdr *nlh, void *data)
|
|
{
|
|
struct genlmsghdr *genl = mnl_nlmsg_get_payload(nlh);
|
|
struct nlattr *info[TIPC_NLA_MAX + 1] = {};
|
|
struct nlattr *attrs[TIPC_NLA_SOCK_MAX + 1] = {};
|
|
|
|
mnl_attr_parse(nlh, sizeof(*genl), parse_attrs, info);
|
|
if (!info[TIPC_NLA_SOCK])
|
|
return MNL_CB_ERROR;
|
|
|
|
mnl_attr_parse_nested(info[TIPC_NLA_SOCK], parse_attrs, attrs);
|
|
if (!attrs[TIPC_NLA_SOCK_REF])
|
|
return MNL_CB_ERROR;
|
|
|
|
printf("socket %u\n", mnl_attr_get_u32(attrs[TIPC_NLA_SOCK_REF]));
|
|
|
|
if (attrs[TIPC_NLA_SOCK_CON]) {
|
|
uint32_t node;
|
|
struct nlattr *con[TIPC_NLA_CON_MAX + 1] = {};
|
|
|
|
mnl_attr_parse_nested(attrs[TIPC_NLA_SOCK_CON], parse_attrs, con);
|
|
node = mnl_attr_get_u32(con[TIPC_NLA_CON_NODE]);
|
|
|
|
printf(" connected to %x:%u", node,
|
|
mnl_attr_get_u32(con[TIPC_NLA_CON_SOCK]));
|
|
|
|
if (con[TIPC_NLA_CON_FLAG])
|
|
printf(" via {%u,%u}\n",
|
|
mnl_attr_get_u32(con[TIPC_NLA_CON_TYPE]),
|
|
mnl_attr_get_u32(con[TIPC_NLA_CON_INST]));
|
|
else
|
|
printf("\n");
|
|
} else if (attrs[TIPC_NLA_SOCK_HAS_PUBL]) {
|
|
publ_list(mnl_attr_get_u32(attrs[TIPC_NLA_SOCK_REF]));
|
|
}
|
|
|
|
return MNL_CB_OK;
|
|
}
|
|
|
|
static int cmd_socket_list(struct nlmsghdr *nlh, const struct cmd *cmd,
|
|
struct cmdl *cmdl, void *data)
|
|
{
|
|
if (help_flag) {
|
|
fprintf(stderr, "Usage: %s socket list\n", cmdl->argv[0]);
|
|
return -EINVAL;
|
|
}
|
|
|
|
nlh = msg_init(TIPC_NL_SOCK_GET);
|
|
if (!nlh) {
|
|
fprintf(stderr, "error, message initialisation failed\n");
|
|
return -1;
|
|
}
|
|
|
|
return msg_dumpit(nlh, sock_list_cb, NULL);
|
|
}
|
|
|
|
void cmd_socket_help(struct cmdl *cmdl)
|
|
{
|
|
fprintf(stderr,
|
|
"Usage: %s socket COMMAND\n\n"
|
|
"Commands:\n"
|
|
" list - List sockets (ports)\n",
|
|
cmdl->argv[0]);
|
|
}
|
|
|
|
int cmd_socket(struct nlmsghdr *nlh, const struct cmd *cmd, struct cmdl *cmdl,
|
|
void *data)
|
|
{
|
|
const struct cmd cmds[] = {
|
|
{ "list", cmd_socket_list, NULL },
|
|
{ NULL }
|
|
};
|
|
|
|
return run_cmd(nlh, cmd, cmds, cmdl, NULL);
|
|
}
|