iproute2/tc
Nigel Kukard 9bea14ff6b Fix tc stats when using -batch mode
There are two global variables in tc/tc_class.c:
__u32 filter_qdisc;
__u32 filter_classid;

These are not re-initialized for each line received in -batch mode:
class show dev eth0 parent 1: classid 1:1
class show dev eth0 parent 1: classid 1:1
Error: duplicate "classid": "1:1" is the second value.

This patch fixes the issue by initializing the two globals when we
enter print_class().

Signed-off-by: Nigel Kukard <nkukard@lbsd.net>
2013-10-30 16:37:07 -07:00
..
.gitignore Add ignore files to make using git easier 2006-08-08 12:04:38 -07:00
em_canid.c Ematch used to classify CAN frames according to their identifiers 2012-08-20 13:11:55 -07:00
em_cmp.c Fix wrong comparison in cmp_print_eopt() 2011-10-07 11:16:15 -07:00
em_ipset.c tc: add ipset ematch 2012-08-13 08:33:50 -07:00
em_meta.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
em_nbyte.c tc: remove dlfcn.h from files that dont need it 2009-11-13 14:14:07 -08:00
em_u32.c tc: remove dlfcn.h from files that dont need it 2009-11-13 14:14:07 -08:00
emp_ematch.l fix build issues with flex ver 2.5 2010-04-22 15:27:42 -07:00
emp_ematch.y ematch: fix warning about yyerror and const 2012-01-03 13:55:00 -08:00
f_basic.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
f_cgroup.c iproute2: Remove unreachable code 2011-07-11 10:13:51 -07:00
f_flow.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
f_fw.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
f_route.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
f_rsvp.c ip: make local functions static 2013-02-12 11:38:35 -08:00
f_tcindex.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
f_u32.c ip: make local functions static 2013-02-12 11:38:35 -08:00
m_action.c ip: make local functions static 2013-02-12 11:38:35 -08:00
m_csum.c csum action, fix typo 2012-03-15 14:24:59 -07:00
m_ematch.c Fix NULL pointer reference when using basic match 2010-07-29 18:03:35 -07:00
m_ematch.h include needed files 2012-12-23 11:49:06 -08:00
m_estimator.c ip: make local functions static 2013-02-12 11:38:35 -08:00
m_gact.c ip: make local functions static 2013-02-12 11:38:35 -08:00
m_ipt.c More minor spelling fixes 2013-08-04 15:10:05 -07:00
m_mirred.c More minor spelling fixes 2013-08-04 15:10:05 -07:00
m_nat.c action: typo nat fix 2013-09-30 21:31:40 -07:00
m_pedit.c ip: make local functions static 2013-02-12 11:38:35 -08:00
m_pedit.h Remove trailing whitespace 2006-12-05 10:10:22 -08:00
m_police.c linklayer interface between kernel and tc/userspace 2013-09-03 08:21:24 -07:00
m_simple.c tc: introduce simple action 2013-09-30 21:29:34 -07:00
m_skbedit.c skbedit: fix set-never-used warning 2011-06-29 15:59:02 -07:00
m_xt_old.c More minor spelling fixes 2013-08-04 15:10:05 -07:00
m_xt.c More minor spelling fixes 2013-08-04 15:10:05 -07:00
Makefile tc: introduce simple action 2013-09-30 21:29:34 -07:00
p_icmp.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
p_ip.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
p_tcp.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
p_udp.c Remove trailing whitespace 2006-12-05 10:10:22 -08:00
q_atm.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
q_cbq.c linklayer interface between kernel and tc/userspace 2013-09-03 08:21:24 -07:00
q_choke.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
q_codel.c tc-codel: Update usage text 2012-05-24 15:02:05 -07:00
q_drr.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
q_dsmark.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
q_fifo.c iproute2: clearer error messages for fifo and tbf qdiscs 2013-02-21 08:34:34 -08:00
q_fq_codel.c fq_codel: Fair Queue Codel AQM 2012-05-22 14:17:49 -07:00
q_fq.c pkt_sched: fq: Fair Queue packet scheduler 2013-09-20 09:43:40 -07:00
q_gred.c gred: support TCA_GRED_MAX_P attribute 2012-01-20 08:12:24 -08:00
q_hfsc.c HFSC (7) & (8) documentation + assorted changes 2011-11-02 16:33:50 -07:00
q_htb.c htb: remove old unused duplicate qdisc name 2013-10-27 12:28:38 -07:00
q_ingress.c tc: remove stale code 2010-01-21 10:13:01 -08:00
q_mqprio.c ip: make local functions static 2013-02-12 11:38:35 -08:00
q_multiq.c ip: make local functions static 2013-02-12 11:38:35 -08:00
q_netem.c ip: make local functions static 2013-02-12 11:38:35 -08:00
q_prio.c tc: prio: Perform more strict check on priomap. 2012-06-18 12:25:08 -07:00
q_qfq.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
q_red.c Convert to use rta_getattr_ functions 2012-04-10 08:47:55 -07:00
q_rr.c ip: make local functions static 2013-02-12 11:38:35 -08:00
q_sfb.c tc : SFB flow scheduler 2011-04-12 14:27:37 -07:00
q_sfq.c sfq: add optional RED on top of SFQ 2012-01-20 08:12:22 -08:00
q_tbf.c linklayer interface between kernel and tc/userspace 2013-09-03 08:21:24 -07:00
README.last (Logical change 1.3) 2004-04-15 20:56:59 +00:00
static-syms.c Fix build when shared libraries are disabled 2013-03-13 08:29:59 -07:00
tc_cbq.c Replace "usec" by "time" in function names 2007-03-13 14:42:17 -07:00
tc_cbq.h (Logical change 1.3) 2004-04-15 20:56:59 +00:00
tc_class.c Fix tc stats when using -batch mode 2013-10-30 16:37:07 -07:00
tc_common.h add generic size table for qdiscs 2008-09-17 21:57:15 -07:00
tc_core.c linklayer interface between kernel and tc/userspace 2013-09-03 08:21:24 -07:00
tc_core.h add generic size table for qdiscs 2008-09-17 21:57:15 -07:00
tc_estimator.c Introduce TIME_UNITS_PER_SEC to represent internal clock resolution 2007-03-13 14:42:16 -07:00
tc_filter.c ip: make local functions static 2013-02-12 11:38:35 -08:00
tc_monitor.c ip: make local functions static 2013-02-12 11:38:35 -08:00
tc_qdisc.c Fix handling of qdis without options 2013-10-27 12:26:47 -07:00
tc_red.c red: give a hint about burst value 2011-12-01 09:23:43 -08:00
tc_red.h (Logical change 1.3) 2004-04-15 20:56:59 +00:00
tc_stab.c add generic size table for qdiscs 2008-09-17 21:57:15 -07:00
tc_util.c tc: support TCA_STATS_RATE_EST64 2013-09-20 09:46:33 -07:00
tc_util.h tc: support TCA_STATS_RATE_EST64 2013-09-20 09:46:33 -07:00
tc.c Make tc and ip batch mode consistent 2013-07-16 10:04:05 -07:00

Kernel code and interface.
--------------------------

* Compile time switches

There is only one, but very important, compile time switch.
It is not settable by "make config", but should be selected
manually and after a bit of thinking in <include/net/pkt_sched.h>

PSCHED_CLOCK_SOURCE can take three values:

	PSCHED_GETTIMEOFDAY
	PSCHED_JIFFIES
	PSCHED_CPU


 PSCHED_GETTIMEOFDAY

Default setting is the most conservative PSCHED_GETTIMEOFDAY.
It is very slow both because of weird slowness of do_gettimeofday()
and because it forces code to use unnatural "timeval" format,
where microseconds and seconds fields are separate.
Besides that, it will misbehave, when delays exceed 2 seconds
(f.e. very slow links or classes bounded to small slice of bandwidth)
To resume: as only you will get it working, select correct clock
source and forget about PSCHED_GETTIMEOFDAY forever.


 PSCHED_JIFFIES

Clock is derived from jiffies. On architectures with HZ=100
granularity of this clock is not enough to make reasonable
bindings to real time. However, taking into account Linux
architecture problems, which force us to use artificial
integrated clock in any case, this switch is not so bad
for schduling even on high speed networks, though policing
is not reliable.


 PSCHED_CPU

It is available only for alpha and pentiums with correct
CPU timestamp. It is the fastest way, use it when it is available,
but remember: not all pentiums have this facility, and
a lot of them have clock, broken by APM etc. etc.