mirror of
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git
synced 2024-11-30 13:26:12 +08:00
ac0a54b2d5
RDMA_NLDEV_ATTR_RES_PID and RDMA_NLDEV_ATTR_RES_KERN_NAME cannot be set together, as evident for the fill_res_name_pid() function in the kernel infiniband driver. This commit makes this clear at first glance, using an else branch for the RDMA_NLDEV_ATTR_RES_KERN_NAME case. This also helps coverity to better understand this code and avoid producing a bogus warning complaining about mnl_attr_get_str overwriting comme, and thus leaking the storage that comm points to. Signed-off-by: Andrea Claudi <aclaudi@redhat.com> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
104 lines
2.6 KiB
C
104 lines
2.6 KiB
C
// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
|
|
/*
|
|
* res-ctx.c RDMA tool
|
|
* Authors: Neta Ostrovsky <netao@nvidia.com>
|
|
*/
|
|
|
|
#include "res.h"
|
|
#include <inttypes.h>
|
|
|
|
static int res_ctx_line(struct rd *rd, const char *name, int idx,
|
|
struct nlattr **nla_line)
|
|
{
|
|
char *comm = NULL;
|
|
uint32_t ctxn = 0;
|
|
uint32_t pid = 0;
|
|
|
|
if (!nla_line[RDMA_NLDEV_ATTR_RES_CTXN])
|
|
return MNL_CB_ERROR;
|
|
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_PID]) {
|
|
SPRINT_BUF(b);
|
|
|
|
pid = mnl_attr_get_u32(nla_line[RDMA_NLDEV_ATTR_RES_PID]);
|
|
if (!get_task_name(pid, b, sizeof(b)))
|
|
comm = b;
|
|
} else if (nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME]) {
|
|
/* discard const from mnl_attr_get_str */
|
|
comm = (char *)mnl_attr_get_str(
|
|
nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME]);
|
|
}
|
|
|
|
if (rd_is_filtered_attr(rd, "pid", pid,
|
|
nla_line[RDMA_NLDEV_ATTR_RES_PID]))
|
|
goto out;
|
|
|
|
if (nla_line[RDMA_NLDEV_ATTR_RES_CTXN])
|
|
ctxn = mnl_attr_get_u32(nla_line[RDMA_NLDEV_ATTR_RES_CTXN]);
|
|
|
|
if (rd_is_filtered_attr(rd, "ctxn", ctxn,
|
|
nla_line[RDMA_NLDEV_ATTR_RES_CTXN]))
|
|
goto out;
|
|
|
|
open_json_object(NULL);
|
|
print_dev(rd, idx, name);
|
|
res_print_u32(rd, "ctxn", ctxn, nla_line[RDMA_NLDEV_ATTR_RES_CTXN]);
|
|
res_print_u32(rd, "pid", pid, nla_line[RDMA_NLDEV_ATTR_RES_PID]);
|
|
print_comm(rd, comm, nla_line);
|
|
|
|
print_driver_table(rd, nla_line[RDMA_NLDEV_ATTR_DRIVER]);
|
|
newline(rd);
|
|
|
|
out:
|
|
return MNL_CB_OK;
|
|
}
|
|
|
|
int res_ctx_idx_parse_cb(const struct nlmsghdr *nlh, void *data)
|
|
{
|
|
struct nlattr *tb[RDMA_NLDEV_ATTR_MAX] = {};
|
|
struct rd *rd = data;
|
|
const char *name;
|
|
uint32_t idx;
|
|
|
|
mnl_attr_parse(nlh, 0, rd_attr_cb, tb);
|
|
if (!tb[RDMA_NLDEV_ATTR_DEV_INDEX] || !tb[RDMA_NLDEV_ATTR_DEV_NAME])
|
|
return MNL_CB_ERROR;
|
|
|
|
name = mnl_attr_get_str(tb[RDMA_NLDEV_ATTR_DEV_NAME]);
|
|
idx = mnl_attr_get_u32(tb[RDMA_NLDEV_ATTR_DEV_INDEX]);
|
|
|
|
return res_ctx_line(rd, name, idx, tb);
|
|
}
|
|
|
|
int res_ctx_parse_cb(const struct nlmsghdr *nlh, void *data)
|
|
{
|
|
struct nlattr *tb[RDMA_NLDEV_ATTR_MAX] = {};
|
|
struct nlattr *nla_table, *nla_entry;
|
|
struct rd *rd = data;
|
|
int ret = MNL_CB_OK;
|
|
const char *name;
|
|
uint32_t idx;
|
|
|
|
mnl_attr_parse(nlh, 0, rd_attr_cb, tb);
|
|
if (!tb[RDMA_NLDEV_ATTR_DEV_INDEX] || !tb[RDMA_NLDEV_ATTR_DEV_NAME] ||
|
|
!tb[RDMA_NLDEV_ATTR_RES_CTX])
|
|
return MNL_CB_ERROR;
|
|
|
|
name = mnl_attr_get_str(tb[RDMA_NLDEV_ATTR_DEV_NAME]);
|
|
idx = mnl_attr_get_u32(tb[RDMA_NLDEV_ATTR_DEV_INDEX]);
|
|
nla_table = tb[RDMA_NLDEV_ATTR_RES_CTX];
|
|
|
|
mnl_attr_for_each_nested(nla_entry, nla_table) {
|
|
struct nlattr *nla_line[RDMA_NLDEV_ATTR_MAX] = {};
|
|
|
|
ret = mnl_attr_parse_nested(nla_entry, rd_attr_cb, nla_line);
|
|
if (ret != MNL_CB_OK)
|
|
break;
|
|
|
|
ret = res_ctx_line(rd, name, idx, nla_line);
|
|
if (ret != MNL_CB_OK)
|
|
break;
|
|
}
|
|
return ret;
|
|
}
|