korg/f2fs-tools
0
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git synced 2024-11-23 09:43:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fsck.f2fs: avoid uncessary recalculation

Browse Source 
There is no need to recalculate ADDRS_PER_INODE and ADDRS_PER_BLOCK,
especially in a for loop.

Signed-off-by: Sheng Yong <shengyong@oppo.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
Sheng Yong 2022-11-14 22:17:00 +08:00 committed by Jaegeuk Kim
parent ccd2361c29
commit 1bb669e872
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
fsck/fsck.c
View File

@ -706,7 +706,7 @@ void fsck_chk_inode_blk(struct f2fs_sb_info *sbi, u32 nid,
int ofs;
char *en;
u32 namelen;
unsigned int idx = 0;
unsigned int addrs, idx = 0;
unsigned short i_gc_failures;
int need_fix = 0;
int ret;
@ -932,17 +932,16 @@ check_next:
}
/* check data blocks in inode */
addrs = ADDRS_PER_INODE(&node_blk->i);
if (cur_qtype != -1) {
u64 addrs_per_blk = (u64)ADDRS_PER_BLOCK(&node_blk->i);
qf_szchk_type[cur_qtype] = QF_SZCHK_REGFILE;
qf_maxsize[cur_qtype] = (ADDRS_PER_INODE(&node_blk->i) +
2 * ADDRS_PER_BLOCK(&node_blk->i) +
2 * ADDRS_PER_BLOCK(&node_blk->i) *
NIDS_PER_BLOCK +
(u64) ADDRS_PER_BLOCK(&node_blk->i) *
NIDS_PER_BLOCK * NIDS_PER_BLOCK) * F2FS_BLKSIZE;
qf_maxsize[cur_qtype] = (u64)(addrs + 2 * addrs_per_blk +
2 * addrs_per_blk * NIDS_PER_BLOCK +
addrs_per_blk * NIDS_PER_BLOCK *
NIDS_PER_BLOCK) * F2FS_BLKSIZE;
}
for (idx = 0; idx < ADDRS_PER_INODE(&node_blk->i);
idx++, child.pgofs++) {
for (idx = 0; idx < addrs; idx++, child.pgofs++) {
block_t blkaddr = le32_to_cpu(node_blk->i.i_addr[ofs + idx]);
/* check extent info */