Go to file
Nick Kralevich b7343ebb63 AOSP: android/perms.c: clean up error handling
There are a number of error conditions which, due to the way
ext2fs_dir_iterate2 operates, would not be propagated to the upper
layers of the call stack. As a result, certain error conditions,
such as not having enough room to allocate blocks for SELinux
labels, would fail silently, instead of causing a compile
failure.

As suggested in
https://android-review.googlesource.com/c/platform/external/e2fsprogs/+/324363
, add a error field to the caller's private data structure, and use the
bit in the field to indicate an error condition. Now, certain errors
which were silently ignored will cause a compile failure when compiling
Android.

Test: Artifically modify selabel_lookup() to return a failure, and
      verify Android doesn't compile.
Test: Verify Android compiles under normal circumstances.
Test: Artifically modify ino_add_xattr() to return a failure, and
      verify Android doesn't compile.
Bug: 117502873
Bug: 117567573
Bug: 117473440

Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Change-Id: Icdb0105a77e98c3428f20d3c59bf824dcad5db8d
From AOSP commit: 7ca13b8b2953f93536ea09eb2ff19bd7cc85b3c1
2018-10-12 22:58:08 -04:00
config config: update config.{guess,sub} 2018-03-02 14:26:52 -05:00
contrib AOSP: android/perms.c: clean up error handling 2018-10-12 22:58:08 -04:00
debian debian: update changelog for 1.44.4-2 release 2018-08-23 11:31:53 -04:00
debugfs AOSP: Fix debugfs clang build. 2018-10-12 22:55:57 -04:00
doc Make sure all release note files have a single trailing empty line 2018-08-22 00:52:08 -04:00
e2fsck e2fsck: clear clang warnings for missing field initializers in structs 2018-10-11 10:25:31 -04:00
ext2ed Merge branch 'maint' into next 2017-10-15 23:20:53 -04:00
include e2fsprogs: fix Free Software Foundation address 2018-04-19 11:39:09 -04:00
install-utils Remove Changelog files since they're not used after the git migration 2007-07-08 08:50:41 -04:00
intl build: use MKDIR_P instead of MKINSTALLDIRS 2018-08-11 15:29:48 -04:00
lib Define __GNUC_PREREQ if necessary 2018-10-10 22:25:54 -04:00
misc filefrag.c: fix build problem when using musl libc 2018-10-10 22:24:01 -04:00
po Update release notes, etc., for the 1.44.4 release 2018-08-18 22:26:58 -04:00
resize AOSP: ODR violation in resize2fs during host build 2018-10-12 22:48:04 -04:00
tests test_one: make sure the tmpfile is cleaned up if the test script exits 2018-10-10 22:56:12 -04:00
util Drop subset tarball and replace it with "configure --enable-subset" 2018-08-18 11:21:30 -04:00
.gitignore misc: add e2mmpstatus utility via dumpe2fs 2018-06-22 18:22:37 -04:00
.missing-copyright Many files: 1997-04-29 16:15:03 +00:00
.release-checklist Stop generating e2fsprogs.spec automatically 2018-08-18 11:06:23 -04:00
ABOUT-NLS Update to gettext 0.11.5. We now enable NLS support by default. 2003-05-03 16:35:17 -04:00
acinclude.m4 build: use MKDIR_P instead of MKINSTALLDIRS 2018-08-11 15:29:48 -04:00
aclocal.m4 e2fsprogs: fix Free Software Foundation address 2018-04-19 11:39:09 -04:00
Android.bp AOSP: Remove unnecessary warning flags, now that the warnings are fixed. 2018-02-26 13:29:14 -05:00
CleanSpec.mk AOSP: e2fsdroid and mke2fs are dynamic executable in recovery partition 2018-06-27 23:51:40 -04:00
configure For --enable-subset, change "make install" so it implies "make install-libs" 2018-08-24 17:12:20 -04:00
configure.ac For --enable-subset, change "make install" so it implies "make install-libs" 2018-08-24 17:12:20 -04:00
depfix.sed Update Release Notes, Changelogs, version.h, etc. for 1.42 release 2011-11-29 16:48:14 -05:00
e2fsprogs.lsm Update release notes, etc., for the 1.44.4 release 2018-08-18 22:26:58 -04:00
e2fsprogs.spec Update release notes, etc., for the 1.44.4 release 2018-08-18 22:26:58 -04:00
INSTALL Fix typos in code comments and developer docs 2017-10-15 23:00:11 -04:00
INSTALL.elfbin Fix typos in code comments and developer docs 2017-10-15 23:00:11 -04:00
Makefile.in For --enable-subset, change "make install" so it implies "make install-libs" 2018-08-24 17:12:20 -04:00
MCONFIG.in build: use MKDIR_P instead of MKINSTALLDIRS 2018-08-11 15:29:48 -04:00
NOTICE e2fsprogs: fix Free Software Foundation address 2018-04-19 11:39:09 -04:00
README Update release notes, etc., for the 1.44.4 release 2018-08-18 22:26:58 -04:00
RELEASE-NOTES Update release notes, etc., for the 1.44.4 release 2018-08-18 22:26:58 -04:00
SHLIBS Many files: 1997-04-29 16:15:03 +00:00
SUBMITTING-PATCHES Added SUBMITTING-PATCHES file 2005-07-05 22:30:13 -05:00
version.h Update release notes, etc., for the 1.44.4 release 2018-08-18 22:26:58 -04:00
wordwrap.pl Fix wordwrap.pl so it is more portable 2012-09-21 12:50:04 -04:00

	This is the new version (1.44.4) of the second extended file
system management programs.

	From time to time, I release new versions of e2fsprogs, to fix
bugs and to make the utilities more robust.  You can always find
information about the latest version at the the e2fsprogs web page,
which is:

	http://e2fsprogs.sourceforge.net

	The INSTALL file has instructions on building and installing
e2fsprogs.  Provisions for building Red Hat RPMs and Debian dpkg files
are supplied as well.

	In case of bugs in these programs, please contact Ted Ts'o at
tytso@mit.edu or tytso@alum.mit.edu.  See the e2fsck man page for
suggestions of what sort of information to include when submitting bug
reports for these programs.