Go to file
Eric Sandeen 9c79612f21 libext2fs: copy cluster_bits in ext2fs_copy_generic_bmap
The f_lotsbad regression test was failing on some systems
with:

 Restarting e2fsck from the beginning...
 Pass 1: Checking inodes, blocks, and sizes
+Illegal block number passed to ext2fs_test_block_bitmap #0 for in-use block map
 Pass 2: Checking directory structure
 Entry 'termcap' in / (2) has deleted/unused inode 12.  Clear? yes

Running with valgrind (./test_script --valgrind f_lotsbad) we
see:

+==31409== Conditional jump or move depends on uninitialised value(s)
+==31409==    at 0x42927A: ext2fs_test_generic_bmap (gen_bitmap64.c:378)

among others.

Looking at gen_bitmap64.c:
376:        arg >>= bitmap->cluster_bits;
377:
378:        if ((arg < bitmap->start) || (arg > bitmap->end)) {

A little more debugging showed that it was actually
bitmap->cluster_bits which was uninitialized, because it never
gets copied over in ext2fs_copy_generic_bmap()

Patch below resolves the issue.

Reported-by: Andreas Dilger <adilger@whamcloud.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2011-08-10 21:49:38 -04:00
config Update config.guess and config.sub to the latest (2009-04-17) version 2009-05-29 22:22:23 -04:00
contrib fallocate: Add truncate (-t) option 2010-03-22 22:03:53 -04:00
debian Update for e2fsprogs 1.42-WIP-0702 release 2011-07-03 00:04:36 -04:00
debugfs debugfs: add a new debugfs command 'blocks' 2011-07-09 12:13:40 -04:00
doc Update Release Notes, Changelogs, version.h, etc. for 1.41.14 release 2010-12-22 18:55:15 -05:00
e2fsck e2fsck: teach e2fsck how to deal with bigalloc in non-extent-mapped inodes 2011-07-10 16:25:55 -04:00
ext2ed Merge branch 'maint' into next 2011-02-27 19:47:44 -05:00
include/nonunix Remove trailing whitespace for the entire source tree 2008-08-27 23:07:54 -04:00
install-utils Remove Changelog files since they're not used after the git migration 2007-07-08 08:50:41 -04:00
intl Fix intl/ build: add E/Q/V macros, process intl/libgnuintl.h 2009-07-18 18:21:46 -04:00
lib libext2fs: copy cluster_bits in ext2fs_copy_generic_bmap 2011-08-10 21:49:38 -04:00
misc mke2fs: document stripe_width, not stripe-width 2011-07-17 23:13:47 -04:00
po po: update fr.po (from translationproject.org) 2011-03-18 16:42:54 -04:00
resize ext2fs: Handle internal journal over 2^32 bytes 2011-06-11 12:17:29 -04:00
tests tests: add missing m_mkfs_overhead/expect 2011-07-12 15:22:14 -04:00
util Add support for configure --enable-verbose-makecmds 2009-07-02 00:11:17 -04:00
.gitignore e2fsprogs: ignore generated files for "git status" 2011-06-11 12:51:44 -04:00
.hgignore Ignore quilt work files 2005-07-19 08:41:27 -05:00
.missing-copyright Many files: 1997-04-29 16:15:03 +00:00
.release-checklist Update release checklist to include reminder to update translation 2008-07-10 17:25:22 -04:00
ABOUT-NLS Update to gettext 0.11.5. We now enable NLS support by default. 2003-05-03 16:35:17 -04:00
aclocal.m4 Enhance build system so that "make V=1" works like the Linux Kernel 2009-07-02 18:19:10 -04:00
configure configure: control whether e4defrag is built/installed via --disable-defrag 2010-12-24 15:19:44 -05:00
configure.in configure: control whether e4defrag is built/installed via --disable-defrag 2010-12-24 15:19:44 -05:00
COPYING Clarify the copyright licenses used by the various libraries in COPYING 2007-06-23 01:04:53 -04:00
depfix.sed Don't use in-tree header files if using system uuid or blkid libraries 2009-10-04 14:45:08 -04:00
e2fsprogs.lsm Update Release Notes, Changelogs, version.h, etc. for 1.41.14 release 2010-12-22 18:55:15 -05:00
e2fsprogs.spec.in misc: clean up compiler warnings 2011-06-11 10:58:25 -04:00
INSTALL Add a comment in INSTALL regarding --disable-tls on older systems 2008-07-10 09:08:44 -04:00
INSTALL.elfbin ChangeLog, INSTALL.elfbin: 1999-01-02 04:15:29 +00:00
Makefile.in check: build all dependencies before "make check" 2011-06-15 22:17:38 -04:00
MCONFIG.in MCONFIG: Fix dependency definitions for the static and profiled blkid library 2010-11-26 19:35:10 -05:00
README Update Release Notes, Changelogs, version.h, etc. for 1.41.14 release 2010-12-22 18:55:15 -05:00
README.subset Update release notes, version files for 1.40.4 release 2008-01-01 00:35:17 -05:00
RELEASE-NOTES Update for e2fsprogs 1.42-WIP-0702 release 2011-07-03 00:04:36 -04:00
SHLIBS Many files: 1997-04-29 16:15:03 +00:00
SUBMITTING-PATCHES Added SUBMITTING-PATCHES file 2005-07-05 22:30:13 -05:00
TODO Update TODO to remove item which is already completed. 2006-05-13 09:28:04 -04:00
version.h Update for e2fsprogs 1.42-WIP-0702 release 2011-07-03 00:04:36 -04:00
wordwrap.pl ChangeLog, wordwrap.pl: 2001-06-01 23:49:46 +00:00

	This is the new version (1.41.14) of the second extended file
system management programs.

	From time to time, I release new versions of e2fsprogs, to fix
bugs and to make the utilities more robust.  You can always find
information about the latest version at the the e2fsprogs web page,
which is:

	http://e2fsprogs.sourceforge.net

	The INSTALL file has instructions on building and installing
e2fsprogs.  Provisions for building Red Hat RPMs and Debian dpkg files
are supplied as well.

	In case of bugs in these programs, please contact Ted Ts'o at
tytso@mit.edu or tytso@alum.mit.edu.  See the e2fsck man page for
suggestions of what sort of information to include when submitting bug
reports for these programs.