mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git
synced 2024-11-16 08:44:31 +08:00
38cfeef103
As of now commands mentioned below (with in [..]) are calling call register-device
ioctl BTRFS_IOC_SCAN_DEV for all the devices in the system.
Some issues with it:
BTRFS_IOC_SCAN_DEV: ioctl is a write operation, we don't want command like
btrfs-debug-tree threads to do that..
eg:
----
$ cat /proc/fs/btrfs/devlist | egrep fsid | wc -l
0
$ btrfs-debug-tree /dev/sde (num_device > 1)
$ cat /proc/fs/btrfs/devlist | egrep fsid | wc -l
5
----
btrfs_scan_fs_devices() ends up calling this ioctl only when num_device > 1.
That's inconsistency with in feature/bug.
We don't have to register _all_ the btrfs devices (again) in the system
without user consent.
Why its inconsistent:
function btrfs_scan_fs_devices() calls btrfs_scan_lblkid only when
num_devices is > 1, which in turn calls BTRFS_IOC_SCAN_DEV ioctl, if
conditions are met.
But main issue is we have too many consumers of btrfs_scan_fs_devices()
the names below with in [] is the cli leading to this function.
open_ctree_broken() [btrfs-find-root]
recover_prepare() [btrfs rescue super-recover]
__open_ctree_fd
(updates always except when flag OPEN_CTREE_RECOVER_SUPER is set and
flag OPEN_CTREE_RECOVER_SUPER is set only by 'btrfs rescue super-
recover' but still this thread sneaks through the open_ctree function
to call register-device-ioctl as show below).
open_ctree_fs_info
[btrfs-debug-tree]
[btrfs-image -r]
[btrfs check]
open_fs
[btrfs restore]
open_ctree
[calc-size]
[btrfs-corrupt-block]
[btrfs-image] (create)
[btrfs-map-logical]
[btrfs-select-super]
[btrfstune]
[btrfs-zero-log]
[tester]
[mkfs]
[quick-test.c]
[btrfs label set unmounted]
[btrfs get label unmounted]
[btrfs rescue super-recover]
open_ctree_fd
[btrfs-convert]
Fix:
In an effort to make register-device consistent, all calls to
btrfs_scan_fs_devices() will have 5th parameter set to 0. that means
we don't need 5th parameter at all. And with this function not calling
the register ioctl at all, finally we will have following two cli to call
the ioctl BTRFS_IOC_SCAN_DEV.
btrfs dev scan and
mkfs.btrfs
Threads needing to update kernel about a device would have to use
btrfs_register_one_device() separately.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
117 lines
4.7 KiB
C
117 lines
4.7 KiB
C
/*
|
|
* Copyright (C) 2007 Oracle. All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License v2 as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program; if not, write to the
|
|
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
* Boston, MA 021110-1307, USA.
|
|
*/
|
|
|
|
#ifndef __DISKIO__
|
|
#define __DISKIO__
|
|
|
|
#define BTRFS_SUPER_INFO_OFFSET (64 * 1024)
|
|
#define BTRFS_SUPER_INFO_SIZE 4096
|
|
|
|
#define BTRFS_SUPER_MIRROR_MAX 3
|
|
#define BTRFS_SUPER_MIRROR_SHIFT 12
|
|
|
|
enum btrfs_open_ctree_flags {
|
|
OPEN_CTREE_WRITES = 1,
|
|
OPEN_CTREE_PARTIAL = 2,
|
|
OPEN_CTREE_BACKUP_ROOT = 4,
|
|
OPEN_CTREE_RECOVER_SUPER = 8,
|
|
OPEN_CTREE_RESTORE = 16,
|
|
OPEN_CTREE_NO_BLOCK_GROUPS = 32,
|
|
OPEN_CTREE_EXCLUSIVE = 64,
|
|
};
|
|
|
|
static inline u64 btrfs_sb_offset(int mirror)
|
|
{
|
|
u64 start = 16 * 1024;
|
|
if (mirror)
|
|
return start << (BTRFS_SUPER_MIRROR_SHIFT * mirror);
|
|
return BTRFS_SUPER_INFO_OFFSET;
|
|
}
|
|
|
|
struct btrfs_device;
|
|
|
|
int read_whole_eb(struct btrfs_fs_info *info, struct extent_buffer *eb, int mirror);
|
|
struct extent_buffer *read_tree_block(struct btrfs_root *root, u64 bytenr,
|
|
u32 blocksize, u64 parent_transid);
|
|
void readahead_tree_block(struct btrfs_root *root, u64 bytenr, u32 blocksize,
|
|
u64 parent_transid);
|
|
struct extent_buffer *btrfs_find_create_tree_block(struct btrfs_root *root,
|
|
u64 bytenr, u32 blocksize);
|
|
|
|
int __setup_root(u32 nodesize, u32 leafsize, u32 sectorsize,
|
|
u32 stripesize, struct btrfs_root *root,
|
|
struct btrfs_fs_info *fs_info, u64 objectid);
|
|
int clean_tree_block(struct btrfs_trans_handle *trans,
|
|
struct btrfs_root *root, struct extent_buffer *buf);
|
|
|
|
void btrfs_free_fs_info(struct btrfs_fs_info *fs_info);
|
|
struct btrfs_fs_info *btrfs_new_fs_info(int writable, u64 sb_bytenr);
|
|
int btrfs_check_fs_compatibility(struct btrfs_super_block *sb, int writable);
|
|
int btrfs_setup_all_roots(struct btrfs_fs_info *fs_info, u64 root_tree_bytenr,
|
|
enum btrfs_open_ctree_flags flags);
|
|
void btrfs_release_all_roots(struct btrfs_fs_info *fs_info);
|
|
void btrfs_cleanup_all_caches(struct btrfs_fs_info *fs_info);
|
|
int btrfs_scan_fs_devices(int fd, const char *path,
|
|
struct btrfs_fs_devices **fs_devices, u64 sb_bytenr,
|
|
int super_recover);
|
|
int btrfs_setup_chunk_tree_and_device_map(struct btrfs_fs_info *fs_info);
|
|
|
|
struct btrfs_root *open_ctree(const char *filename, u64 sb_bytenr,
|
|
enum btrfs_open_ctree_flags flags);
|
|
struct btrfs_root *open_ctree_fd(int fp, const char *path, u64 sb_bytenr,
|
|
enum btrfs_open_ctree_flags flags);
|
|
struct btrfs_fs_info *open_ctree_fs_info(const char *filename,
|
|
u64 sb_bytenr, u64 root_tree_bytenr,
|
|
enum btrfs_open_ctree_flags flags);
|
|
int close_ctree(struct btrfs_root *root);
|
|
int write_all_supers(struct btrfs_root *root);
|
|
int write_ctree_super(struct btrfs_trans_handle *trans,
|
|
struct btrfs_root *root);
|
|
int btrfs_read_dev_super(int fd, struct btrfs_super_block *sb, u64 sb_bytenr,
|
|
int super_recover);
|
|
int btrfs_map_bh_to_logical(struct btrfs_root *root, struct extent_buffer *bh,
|
|
u64 logical);
|
|
struct extent_buffer *btrfs_find_tree_block(struct btrfs_root *root,
|
|
u64 bytenr, u32 blocksize);
|
|
struct btrfs_root *btrfs_read_fs_root(struct btrfs_fs_info *fs_info,
|
|
struct btrfs_key *location);
|
|
struct btrfs_root *btrfs_read_fs_root_no_cache(struct btrfs_fs_info *fs_info,
|
|
struct btrfs_key *location);
|
|
int btrfs_free_fs_root(struct btrfs_root *root);
|
|
void btrfs_mark_buffer_dirty(struct extent_buffer *buf);
|
|
int btrfs_buffer_uptodate(struct extent_buffer *buf, u64 parent_transid);
|
|
int btrfs_set_buffer_uptodate(struct extent_buffer *buf);
|
|
int wait_on_tree_block_writeback(struct btrfs_root *root,
|
|
struct extent_buffer *buf);
|
|
u32 btrfs_csum_data(struct btrfs_root *root, char *data, u32 seed, size_t len);
|
|
void btrfs_csum_final(u32 crc, char *result);
|
|
|
|
int btrfs_commit_transaction(struct btrfs_trans_handle *trans,
|
|
struct btrfs_root *root);
|
|
int btrfs_open_device(struct btrfs_device *dev);
|
|
int csum_tree_block_size(struct extent_buffer *buf, u16 csum_sectorsize,
|
|
int verify);
|
|
int verify_tree_block_csum_silent(struct extent_buffer *buf, u16 csum_size);
|
|
int btrfs_read_buffer(struct extent_buffer *buf, u64 parent_transid);
|
|
int write_and_map_eb(struct btrfs_trans_handle *trans, struct btrfs_root *root,
|
|
struct extent_buffer *eb);
|
|
#endif
|
|
|
|
/* raid6.c */
|
|
void raid6_gen_syndrome(int disks, size_t bytes, void **ptrs);
|