Go to file
Nikolay Borisov c08983291e btrfs-progs: check: fix error reporting on root inode
If btrfs check detects an error on the root inode of a subvolume it
prints:

    Opening filesystem to check...
    Checking filesystem on /dev/vdc
    UUID: 4ac7a216-bf97-4c5f-9899-0f203c20d8af
    [1/7] checking root items
    [2/7] checking extents
    [3/7] checking free space cache
    [4/7] checking fs roots
    root 5 root dir 256 error
    ERROR: errors found in fs roots
    found 196608 bytes used, error(s) found
    total csum bytes: 0
    total tree bytes: 131072
    total fs tree bytes: 32768
    total extent tree bytes: 16384
    btree space waste bytes: 124376
    file data blocks allocated: 65536
     referenced 65536

This is not very helpful since there is no specific information about
the exact error. This is due to the fact that check_root_dir doesn't
set inode_record::errors accordingly. This patch rectifies this and now
the output would look like:

	[1/7] checking root items
	[2/7] checking extents
	[3/7] checking free space cache
	[4/7] checking fs roots
	root 5 inode 256 errors 2000, link count wrong
	ERROR: errors found in fs roots
	found 196608 bytes used, error(s) found
	total csum bytes: 0
	total tree bytes: 131072
	total fs tree bytes: 32768
	total extent tree bytes: 16384
	btree space waste bytes: 124376
	file data blocks allocated: 65536
	 referenced 65536

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2020-08-31 17:16:36 +02:00
check btrfs-progs: check: fix error reporting on root inode 2020-08-31 17:16:36 +02:00
ci btrfs-progs: ci: fix libreiserfs build 2020-08-31 17:01:06 +02:00
cmds btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
common btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
convert btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
crypto btrfs-progs: build: add support for libkcapi as crypto backend 2020-06-09 22:19:07 +02:00
Documentation btrfs-progs: docs: remove nonexistent nousebackuproot option 2020-08-31 17:01:03 +02:00
image btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
kernel-lib btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
kernel-shared btrfs-progs: make btrfs_lookup_dir_index in parity with kernel code 2020-08-31 17:09:49 +02:00
libbtrfsutil libbtrfsutil: update btrfs_util_delete_subvolume docs 2020-05-29 12:42:49 +02:00
m4 btrfs-progs: build: detect whether -std=gnu90 is supported 2018-06-07 16:37:35 +02:00
mkfs btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
tests btrfs-progs: tests: add test image to fsck/043 for inode transid repair 2020-08-31 17:09:55 +02:00
.editorconfig btrfs-progs: add basic .editorconfig 2020-08-31 17:01:02 +02:00
.gitignore btrfs-progs: add basic .editorconfig 2020-08-31 17:01:02 +02:00
.gitlab-ci.yml btrfs-progs: ci: setup GitLab-CI 2019-10-16 23:03:52 +02:00
.travis.yml btrfs-progs: ci: use newer image base on travis 2019-11-18 19:21:08 +01:00
64-btrfs-dm.rules btrfs-progs: udev: add rules for dm devices 2016-06-01 14:56:56 +02:00
Android.mk btrfs-progs: merge find-root.c and btrfs-find-root.c 2020-08-31 17:01:06 +02:00
androidcompat.h btrfs-progs: add compat header for android 2015-09-01 14:02:49 +02:00
autogen.sh btrfs-progs: build: simplify version tracking 2018-01-31 15:14:01 +01:00
btrfs-completion btrfs-progs: completion: let dump-tree/dump-super/inode-resolve accept any file 2018-10-23 14:48:38 +02:00
btrfs-corrupt-block.c btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
btrfs-crc.c btrfs-progs: move crc32c implementation to crypto/ 2019-11-18 19:20:02 +01:00
btrfs-debugfs btrfs-progs: port btrfs-debugfs to python3 2020-07-02 22:24:33 +02:00
btrfs-find-root.c btrfs-progs: merge find-root.c and btrfs-find-root.c 2020-08-31 17:01:06 +02:00
btrfs-fragments.c btrfs-progs: move ctree.c to kernel-shared/ 2020-08-31 17:01:05 +02:00
btrfs-list.c btrfs-progs: move transaction.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
btrfs-list.h btrfs-progs: build: drop kernel-lib from -I and update paths 2019-07-03 20:49:04 +02:00
btrfs-map-logical.c btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
btrfs-sb-mod.c btrfs-progs: move disk-io.c to kernel-shared/ 2020-08-31 17:01:05 +02:00
btrfs-select-super.c btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
btrfs.c btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
btrfsck.h btrfs-progs: move ctree.c to kernel-shared/ 2020-08-31 17:01:05 +02:00
btrfstune.c btrfs-progs: move volumes.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
CHANGES btrfs-progs: update CHANGES for 5.7 2020-07-02 22:58:38 +02:00
configure.ac btrfs-progs: build: add support for libkcapi as crypto backend 2020-06-09 22:19:07 +02:00
COPYING fix COPYING 2007-06-12 15:41:08 -04:00
fsck.btrfs btrfs-progs: fsck.btrfs: Fix bashism and bad getopts processing 2015-05-21 16:53:44 +02:00
INSTALL btrfs-progs: build: add support for libkcapi as crypto backend 2020-06-09 22:19:07 +02:00
ioctl.h btrfs-progs: complete the implementation RAID1C34 definitions 2020-04-01 20:20:59 +02:00
kerncompat.h btrfs-progs: Fix printf formats 2019-10-14 17:31:05 +02:00
libbtrfs.sym btrfs-progs: move send-utils.c to common/ 2020-08-31 17:01:04 +02:00
libbtrfsutil.sym libbtrfsutil: bump version to 1.2 2020-03-04 19:21:09 +01:00
Makefile btrfs-progs: merge find-root.c and btrfs-find-root.c 2020-08-31 17:01:06 +02:00
Makefile.extrawarn btrfs-progs: build: disable -Waddress-of-packed-member by default 2019-06-14 15:09:53 +02:00
Makefile.inc.in btrfs-progs: build: add support for libkcapi as crypto backend 2020-06-09 22:19:07 +02:00
props.c btrfs-progs: move ctree.c to kernel-shared/ 2020-08-31 17:01:05 +02:00
props.h btrfs-progs: unify header file inclusion protections 2015-01-21 17:49:26 +01:00
qgroup.c btrfs-progs: move ctree.c to kernel-shared/ 2020-08-31 17:01:05 +02:00
qgroup.h btrfs-progs: qgroups: introduce btrfs_qgroup_query 2019-07-03 13:31:14 +02:00
quick-test.c btrfs-progs: move transaction.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
random-test.c btrfs-progs: move transaction.c to kernel-shared/ 2020-08-31 17:01:06 +02:00
README.md btrfs-progs: Update README.md with editorconfig hint 2020-08-31 17:01:03 +02:00
repair.c btrfs-progs: move ctree.c to kernel-shared/ 2020-08-31 17:01:05 +02:00
repair.h btrfs-progs: move ctree.c to kernel-shared/ 2020-08-31 17:01:05 +02:00
send.h btrfs-progs: move ctree.c to kernel-shared/ 2020-08-31 17:01:05 +02:00
show-blocks btrfs-progs: Remove btrfs-debug-tree command 2018-04-24 13:00:10 +02:00
VERSION Btrfs progs v5.7 2020-07-02 22:59:41 +02:00
version.h.in btrfs-progs: re-introduce BTRFS_BUILD_VERSION in version.h 2015-03-16 18:40:06 +01:00

Btrfs-progs build status coverity status gitlab CI/CD

Userspace utilities to manage btrfs filesystems. License: GPLv2.

Btrfs is a copy on write (COW) filesystem for Linux aimed at implementing advanced features while focusing on fault tolerance, repair and easy administration.

This repository hosts following utilities:

  • btrfs — the main administration tool (manual page)
  • mkfs.btrfs — utility to create the filesystem (manual page)
  • all-in-one binary in the busybox style with mkfs.btrfs, btrfs-image and other tools built-in (standalone tools)

The C and python 3 bindings are provided by a LGPL library libbtrfsutil see libbtrfsutil/README.md for more.

See INSTALL for build instructions and tests/README.md for testing information.

Release cycle

The major version releases are time-based and follow the cycle of the linux kernel releases. The cycle usually takes 2 months. A minor version releases may happen in the meantime if there are bug fixes or minor useful improvements queued.

The release tags are signed with a GPG key ID F2B4 1200 C54E FB30 380C 1756 C565 D5F9 D76D 583B, release tarballs are hosted at kernel.org. See file CHANGES or changelogs on wiki.

Reporting bugs

There are several ways, each has its own specifics and audience that can give feedback or work on a fix. The following list is sorted in the order of preference:

  • github issue tracker
  • to the mailing list linux-btrfs@vger.kernel.org -- (not required to subscribe), beware that the mail might get overlooked in other traffic
  • IRC (irc.freenode.net #btrfs) -- good for discussions eg. if a bug is already known, but reports could miss developers' attention
  • bugzilla.kernel.org -- (requires registration), set the product to Filesystems and component Btrfs, please put 'btrfs-progs' into the subject so it's clear that it's not a kernel bug report

Development

The patch submissions, development or general discussions take place at linux-btrfs@vger.kernel.org mailinglist, subsciption is not required to post.

The GitHub pull requests will not be accepted directly, the preferred way is to send patches to the mailinglist instead. You can link to a branch in any git repository if the mails do not make it to the mailinglist or just for convenience (makes it easier to test).

The development model of btrfs-progs shares a lot with the kernel model. The github way is different in some ways. We, the upstream community, expect that the patches meet some criteria (often lacking in github contributions):

  • one logical change per patch: eg. not mixing bugfixes, cleanups, features etc., sometimes it's not clear and will be usually pointed out during reviews
  • proper subject line: eg. prefix with btrfs-progs: subpart, ... , descriptive yet not too long, see git log --oneline for some inspiration
  • proper changelog: the changelogs are often missing or lacking explanation why the change was made, or how is something broken, what are user-visible effects of the bug or the fix, how does an improvement help or the intended usecase
  • the Signed-off-by line: this documents who authored the change, you can read more about the The Developer's Certificate of Origin (chapter 11)
    • if you are not used to the signed-off style, your contributions won't be rejected just because of it's missing, the Author: tag will be added as a substitute in order to allow contributions without much bothering with formalities

Source code coding style and preferences follow the kernel coding style. You can find the editor settins in .editorconfig and use the EditorConfig plugin to let your editor use that, or update your editor settings manually.

Documentation updates

Documentation fixes or updates do not need much explanation so sticking to the code rules in the previous section is not necessary. GitHub pull requests are OK, patches could be sent to me directly and not required to be also in the mailinglist. Pointing out typos via IRC also works, although might get accidentally lost in the noise.

Third-party sources

Build dependencies are listed in INSTALL. Implementation of checksum/hash functions is provided by copies of the respective sources to avoid adding dependencies that would make deployments in rescure or limited environments harder. The implementations are portable and not optimized for speed nor accelerated. Optionally it's possible to use libgcrypt, libsodium or libkcapi implementations.

References