Go to file
Qu Wenruo 6dfc69104b btrfs-progs: add extra chunk alignment checks
Recently we had a scrub use-after-free caused by unaligned chunk
length, although the fix was submitted, we may want to do extra checks
for a chunk's alignment.

This patch adds such check for the starting bytenr and length of a
chunk, to make sure they are properly aligned to 64K stripe boundary.

By default, the check only leads to a warning but is not treated as an
error, as we expect kernel to handle such unalignment without any
problem.

But if the new debug environmental variable,
BTRFS_PROGS_DEBUG_STRICT_CHUNK_ALIGNMENT, is specified, then we will
treat it as an error.  So that we can detect unexpected chunks from
btrfs-progs, and fix them before reaching the end users.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2024-01-16 19:14:37 +01:00
.github/workflows btrfs-progs: ci: install RTD sphinx theme for devel workflow 2023-12-06 16:03:37 +01:00
check btrfs-progs: add extra chunk alignment checks 2024-01-16 19:14:37 +01:00
ci btrfs-progs: ci: update packages providing pahole 2023-12-04 18:47:31 +01:00
cmds btrfs-progs: scrub start: consider the lowest non-zero limit 2024-01-15 17:07:22 +01:00
common btrfs-progs: add extra chunk alignment checks 2024-01-16 19:14:37 +01:00
config btrfs-progs: detect PCLMUL CPU support for accelerated crc32c 2023-09-13 00:38:50 +02:00
convert btrfs-progs: convert: make sure the length of data chunks are also stripe aligned 2024-01-16 19:11:54 +01:00
crypto btrfs-progs: crypto: add openssl as crypto provider 2023-11-30 22:04:45 +01:00
Documentation btrfs-progs: docs: placeholder for contents.rst file on older sphinx version 2024-01-11 17:04:48 +01:00
image btrfs-progs: fix all variable shadowing 2023-10-10 19:16:29 +02:00
include btrfs-progs: kernel-shared: sync delayed-refs.[ch] 2023-10-03 01:11:57 +02:00
kernel-lib btrfs-progs: clean up includes, using include-what-you-use 2023-10-03 01:11:57 +02:00
kernel-shared btrfs-progs: tree-checker: dump the tree block when hitting an error 2024-01-12 16:34:44 +01:00
libbtrfs Revert "libbtrfs: remove the support for fs without uuid tree" 2023-09-01 13:58:46 +02:00
libbtrfsutil btrfs-progs: sync DEV_INFO ioctl from kernel 2023-03-21 02:55:56 +01:00
mkfs btrfs-progs: mkfs: print zone count for each device 2023-11-03 18:04:37 +01:00
tests btrfs-progs: cli-tests: add test case for return value of "btrfs subvlume create" 2024-01-10 16:31:39 +01:00
tune btrfs-progs: tune: use long option to enable simple quota 2023-10-21 15:51:07 +02:00
.editorconfig btrfs-progs: add basic .editorconfig 2020-08-31 17:01:02 +02:00
.gitignore btrfs-progs: docs: placeholder for contents.rst file on older sphinx version 2024-01-11 17:04:48 +01:00
.readthedocs.yaml btrfs-progs: docs: add config file for readthedocs.io 2023-12-05 16:36:24 +01:00
64-btrfs-dm.rules btrfs-progs: udev: add rules for dm devices 2016-06-01 14:56:56 +02:00
64-btrfs-zoned.rules btrfs-progs: add udev rule to use mq-deadline on zoned btrfs 2022-02-01 18:41:43 +01:00
autogen.sh btrfs-progs: build: reuse config/ directory for m4 macros 2023-05-26 21:08:17 +02:00
btrfs-completion btrfs-progs: move space cache removal to rescue group 2023-11-03 18:04:37 +01:00
btrfs-corrupt-block.c btrfs-progs: clean up includes, using include-what-you-use 2023-10-03 01:11:57 +02:00
btrfs-crc.c btrfs-progs: move crc32c implementation to crypto/ 2019-11-18 19:20:02 +01:00
btrfs-debugfs btrfs-progs: port btrfs-debugfs to python3 2020-07-02 22:24:33 +02:00
btrfs-find-root.c btrfs-progs: clean up includes, using include-what-you-use 2023-10-03 01:11:57 +02:00
btrfs-map-logical.c btrfs-progs: clean up includes, using include-what-you-use 2023-10-03 01:11:57 +02:00
btrfs-sb-mod.c btrfs-progs: sb-mod: fix build after removing log_root_transid 2023-10-21 15:51:07 +02:00
btrfs-select-super.c btrfs-progs: clean up includes, using include-what-you-use 2023-10-03 01:11:57 +02:00
btrfs.c btrfs-progs: add support for dry-run options 2023-11-03 18:04:37 +01:00
CHANGES btrfs-progs: update CHANGES for 6.6.3 2023-12-14 15:26:13 +01:00
configure.ac btrfs-progs: build: use AS_IF for target_cpu condition 2024-01-04 18:43:05 +01:00
COPYING fix COPYING 2007-06-12 15:41:08 -04:00
fsck.btrfs btrfs-progs: fsck.btrfs: Fix bashism and bad getopts processing 2015-05-21 16:53:44 +02:00
inject-error btrfs-progs: add error injection helper script 2023-07-27 14:45:29 +02:00
INSTALL btrfs-progs: crypto: add openssl as crypto provider 2023-11-30 22:04:45 +01:00
Makefile btrfs-progs: build: add target for all internal APIs 2023-12-01 01:39:27 +01:00
Makefile.extrawarn btrfs-progs: enable -Wshadow for default build 2023-10-10 19:23:10 +02:00
Makefile.inc.in btrfs-progs: crypto: add openssl as crypto provider 2023-11-30 22:04:45 +01:00
README.md btrfs-progs: README: add compatibility 2023-12-08 17:08:55 +01:00
show-blocks btrfs-progs: Remove btrfs-debug-tree command 2018-04-24 13:00:10 +02:00
VERSION Btrfs progs v6.6.3 2023-12-14 15:27:36 +01:00

Btrfs-progs

devel coverage codecov static release

Userspace utilities to manage btrfs filesystems. License: GPLv2.

Btrfs is a copy on write (COW) filesystem for Linux aimed at implementing advanced features while focusing on fault tolerance, repair and easy administration.

This repository hosts following utilities and also documentation:

See INSTALL for build instructions, tests/README.md for testing information and ci/README.md for CI information.

Release cycle

The major version releases are time-based and follow the cycle of the linux kernel releases. The cycle usually takes 2 months. A minor version releases may happen in the meantime if there are bug fixes or minor useful improvements queued.

The release tags are signed with a GPG key ID F2B4 1200 C54E FB30 380C 1756 C565 D5F9 D76D 583B, release tarballs are hosted at kernel.org. See file CHANGES or changelogs on RTD.

Releases with changelog are also published at Github release page.

Static binaries

For each release there are static binaries of btrfs and btrfs.box provided. These can be used in rescue environments and are built for x86_64 architecture (with maximum backward compatibility), inside the Github Actions workflow. The btrfs.box is an all-in-one tool in the busybox style, the functionality is determined by the binary names (either symlink, hradlink or a file copy).

Feature compatibility

The btrfs-progs of version X.Y declare support of kernel features of the same version. New progs on old kernel are expected to work, limited only by features provided by the kernel.

Build compatibility

Build is supported on the GNU C library as the primary target, and on the musl libc.

The supported compilers are gcc (minimal version 4.8) and clang (minimal version 3.4).

Build tests are done on several distributions, see Github actions workflow.

Reporting bugs

There are several ways, each has its own specifics and audience that can give feedback or work on a fix. The following list is sorted in the order of preference:

Development

The development takes place in the mailing list (linux-btrfs@vger.kernel.org) or at Github (issues, pull requests). Changes should be split to logical parts if possible, documentation may be included in the same patch as to code or separately.

The development model of btrfs-progs shares a lot with the kernel model. The

  • one logical change per patch: e.g. not mixing bugfixes, cleanups, features etc., sometimes it's not clear and will be usually pointed out during reviews
  • proper subject line: e.g. prefix with btrfs-progs: subpart, ... , descriptive yet not too long, see git log --oneline for some inspiration
  • proper changelog: the changelogs are often missing or lacking explanation why the change was made, or how is something broken, what are user-visible effects of the bug or the fix, how does an improvement help or the intended usecase
  • the Signed-off-by line is not mandatory for less significant changes (typos, documentation) but is desired as this documents who authored the change, you can read more about the The Developer's Certificate of Origin (chapter 11)
    • if you are not used to the signed-off style, your contributions won't be rejected just because of it's missing, the Author: tag will be added as a substitute in order to allow contributions without much bothering with formalities

Pull requests

The pull requests on Github may be used for code or documentation contributions. There are basic build checks enabled in the Github actions CI for pull requests. The status can be checked at the workflow page.

  • open a PR against branches devel or master
  • push update to the same branch if you need to
  • close the PR in case it's wrong, a mistake or needs rework
  • if you're sure the changes don't need a CI build verification, please add [skip ci] to the changelog

Source code coding style and preferences follow the kernel coding style. You can find the editor settings in .editorconfig and use the EditorConfig plugin to let your editor use that, or update your editor settings manually.

Testing

The documentation for writing and running tests can be found in tests/ and continuous integration/container images in ci/.

Development branches are tested by Github Action workflows.

Code coverage provided by codecov.io can be found here.

Documentation updates

Documentation fixes or updates do not need much explanation so sticking to the code rules in the previous section is not necessary. GitHub pull requests are OK, patches could be sent to me directly and not required to be also in the mailing list. Pointing out typos via IRC also works, although might get accidentally lost in the noise.

Documentation sources are written in RST and built by sphinx.

Third-party sources

Build dependencies are listed in INSTALL. Implementation of checksum/hash functions is provided by copies of the respective sources to avoid adding dependencies that would make deployments in rescue or limited environments harder. The implementations are portable and there are optimized versions for some architectures. Optionally it's possible to use libgcrypt, libsodium, libkcapi, Botan or OpenSSL implementations.

The builtin implemtations uses the following sources: CRC32C, XXHASH, SHA256, BLAKE2.

Some other code is borrowed from kernel, eg. the raid5 tables or data structure implementation (list, rb-tree).

References