korg/btrfs-progs
0
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git synced 2024-11-24 12:44:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: fix xxhash on big endian machines

Browse Source 
xxhash's state and results are always in little, but in progs after the
hash was calculated it was copied to the final buffer via memcpy,
meaning it'd be parsed as a big endian number on big endian machines.
This is incompatible with the kernel implementation of xxhash which
results in erroneous "checksum didn't match" errors on mount.

Fix it by using put_unaligned_le64 which always ensures the resulting
checksum will be copied in little endian format as the kernel expects
it.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=206835
Fixes: f070ece2e9 ("btrfs-progs: add xxhash64 to mkfs")
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Nikolay Borisov 2020-03-16 11:05:12 +02:00 committed by David Sterba
parent 1173a4ba26
commit 5b13164cf9
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crypto/hash.c
View File

@ -19,11 +19,7 @@ int hash_xxhash(const u8 *buf, size_t length, u8 *out)
XXH64_hash_t hash;
hash = XXH64(buf, length, 0);
/*
* NOTE: we're not taking the canonical form here but the plain hash to
* be compatible with the kernel implementation!
*/
memcpy(out, &hash, 8);
put_unaligned_le64(hash, out);
return 0;
}