korg/bluez
0
0
Fork 0
mirror of https://git.kernel.org/pub/scm/bluetooth/bluez.git synced 2024-12-18 08:24:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

add hog ref before adding to instances

Browse Source 
To avoid a double hog free, need to add a ref
when adding the hog to the slist.

This bug has been reproduced with gamepad-8718
which was connecting/disconnecting frantically.

Fix also a typo in the method hog_attach_instance
This commit is contained in:
Stéphane Cerveau 2020-04-20 20:40:29 +02:00 committed by Luiz Augusto von Dentz
parent 86fbb15cb7
commit 71b5dbc704
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
profiles/input/hog-lib.c
View File

@ -1357,7 +1357,7 @@ static struct bt_hog *hog_new(int fd, const char *name, uint16_t vendor,
return hog;
}
static void hog_attach_instace(struct bt_hog *hog,
static void hog_attach_instance(struct bt_hog *hog,
struct gatt_db_attribute *attr)
{
struct bt_hog *instance;
@ -1373,14 +1373,14 @@ static void hog_attach_instace(struct bt_hog *hog,
if (!instance)
return;
hog->instances = g_slist_append(hog->instances, instance);
hog->instances = g_slist_append(hog->instances, bt_hog_ref(instance));
}
static void foreach_hog_service(struct gatt_db_attribute *attr, void *user_data)
{
struct bt_hog *hog = user_data;
hog_attach_instace(hog, attr);
hog_attach_instance(hog, attr);
}
static void dis_notify(uint8_t source, uint16_t vendor, uint16_t product,