korg/bluez
0
0
Fork 0
mirror of https://git.kernel.org/pub/scm/bluetooth/bluez.git synced 2024-12-02 00:24:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

obexd: Use stack memory for application parameters in pbap module

Browse Source 
The maximum amount needed is known and sufficiently small to be in the
stack which is much simpler to deal with.
This commit is contained in:
Luiz Augusto von Dentz 2012-05-14 16:46:01 +03:00 committed by Marcel Holtmann
parent fcd02ad59b
commit 0cbb1f10f2
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
obexd/client/pbap.c
View File

@ -531,7 +531,7 @@ static DBusMessage *pull_vcard_listing(struct pbap_data *pbap,
{
struct pending_request *request;
struct obc_transfer *transfer;
guint8 *p, *apparam = NULL;
guint8 *p, apparam[272];
gint apparam_size;
GError *err = NULL;
DBusMessage *reply;
@ -549,7 +549,6 @@ static DBusMessage *pull_vcard_listing(struct pbap_data *pbap,
(APPARAM_HDR_SIZE + SEARCHATTRIB_LEN) +
(APPARAM_HDR_SIZE + MAXLISTCOUNT_LEN) +
(APPARAM_HDR_SIZE + LISTSTARTOFFSET_LEN);
apparam = g_malloc0(apparam_size);
p = apparam;
@ -566,7 +565,6 @@ static DBusMessage *pull_vcard_listing(struct pbap_data *pbap,
request = pending_request_new(pbap, message);
obc_transfer_set_params(transfer, apparam, apparam_size);
g_free(apparam);
if (obc_session_queue(pbap->session, transfer,
pull_vcard_listing_callback, request, &err))